[jdk8u-dev] RFR: 8200468: Port the native GSS-API bridge to Windows [v2]

[Andrew John Hughes]

On Wed, 28 Jun 2023 22:19:12 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Hello,
>> I'd like to backport JDK-8200568: port the native GSS-API bridge to Windows to JDK8u
>> This is a prerequisite of the JDK-6722928 and JDK-8225687
>> 
>> The backport is not clean. I have to to make the following changes:
>> jdk/make/lib/SecurityLibraries.gmk
>> - Patched manually, just removed platform dependency
>> 
>> jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.c
>> - Clean merge except for copyright year
>> 
>> jdk/src/share/native/sun/security/jgss/wrapper/NativeUtil.h
>> - Visual Studio 2010-2012 doesn't provide inttypes.h so provide appropriate definitions the header file
>> - Manually updated copyright year
>> 
>> jdk/src/share/classes/sun/security/jgss/GSSManagerImpl.java
>> - Manually removed platform OS dependency
>> 
>> jdk/src/solaris/native/sun/security/jgss/wrapper/NativeFunc.c is moved to jdk/src/share/native/sun/security/jgss/wrapper/NativeFunc.c
>> - All changes applied manually because of JDK-8238388 already applied 
>> 
>> jdk/src/solaris/native/sun/security/jgss/wrapper/NativeFunc.h is moved to jdk/src/share/native/sun/security/jgss/wrapper/NativeFunc.h
>> - All changes applied clean 
>> 
>> jdk/test/sun/security/krb5/auto/BasicProc.java
>> - Manually added Windows platform dependency code
>> 
>> jdk/test/java/security/testlibrary/Proc.java
>> - Manually extended debug output
>> 
>> All related jtreg tests passed successfully on Windows
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix copyright year and BasicProc test

Thanks. It looks good with the additional changes. If you flag with `jdk8u-fix-request`, I'll approve for 8u too.

What's the end goal here? [JDK-6722928](https://bugs.openjdk.org/browse/JDK-6722928)? I'm just wondering because that one will need a CSR, essentially a clone of what [was done for 11u](https://bugs.openjdk.org/browse/JDK-8256559)

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/335#pullrequestreview-1507032858