From duke at openjdk.org Wed Mar 1 12:56:51 2023 From: duke at openjdk.org (Deepa Kumari) Date: Wed, 1 Mar 2023 12:56:51 GMT Subject: [jdk8u-dev] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 Message-ID: The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) ------------- Commit messages: - 8303408 : [AIX] Broken jdk8u build after JDK-8266391 Changes: https://git.openjdk.org/jdk8u-dev/pull/274/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=274&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303408 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/274.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/274/head:pull/274 PR: https://git.openjdk.org/jdk8u-dev/pull/274 From andrew at openjdk.org Wed Mar 1 14:37:12 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 1 Mar 2023 14:37:12 GMT Subject: [jdk8u-dev] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 12:51:25 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) Thanks for catching this. Can you file this one against https://github.com/openjdk/jdk8u instead, so we can get it into the 8u372 release? I'm about to switch 8u-dev to 8u382 (development finished on Friday) and I'll approve there? Also make sure to turn on actions in your fork so the checks can run :) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/274 From andrew at openjdk.org Wed Mar 1 14:40:21 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 1 Mar 2023 14:40:21 GMT Subject: [jdk8u-dev] RFR: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 16:16:28 GMT, Severin Gehwolf wrote: > Clean backport modulo path changes. Parity with Oracle JDK 8u371. > > Testing: > - [x] `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` and `jdk/test/security/infra/java/security/cert/CertPathValidator`. All pass after fixes in #271 and #270 > > Thoughts? Can you file this one against https://github.com/openjdk/jdk8u instead, so we can get it into the 8u372 release? I'm about to switch 8u-dev to 8u382 (development finished on Friday) and I'll approve there? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/272 From duke at openjdk.org Wed Mar 1 14:42:15 2023 From: duke at openjdk.org (Deepa Kumari) Date: Wed, 1 Mar 2023 14:42:15 GMT Subject: [jdk8u-dev] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 14:34:24 GMT, Andrew John Hughes wrote: > Thanks for catching this. > Can you file this one against https://github.com/openjdk/jdk8u instead, so we can get it into the 8u372 release? I'm about to switch 8u-dev to 8u382 (development finished on Friday) and I'll approve there? Sure @gnu-andrew . Thanks for review. > Also make sure to turn on actions in your fork so the checks can run :) Okay. Thank You. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/274 From gnu.andrew at redhat.com Wed Mar 1 15:04:54 2023 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 1 Mar 2023 15:04:54 +0000 Subject: [RAMPDOWN] 8u372 now in Rampdown Stage Message-ID: 8u372 is now in rampdown for release in April. jdk8u-dev is CLOSED for commits until further notice, while the branch is prepared for the 8u382 release cycle [0]. For critical fixes (i.e. regressions or urgent fixes) for 8u372, please file a PR against https://github.com/openjdk/jdk8u and use jdk8u-critical-request to obtain approval to push. [0] https://github.com/openjdk/jdk8u-dev/pull/275 Thanks, -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Wed Mar 1 15:08:55 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 1 Mar 2023 15:08:55 GMT Subject: [jdk8u-dev] RFR: 8303462: Bump update version of OpenJDK: 8u382 Message-ID: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> Rampdown for 8u372 has begun. 8u-dev needs to transition to 8u382. ------------- Commit messages: - 8303462: Bump update version of OpenJDK: 8u382 Changes: https://git.openjdk.org/jdk8u-dev/pull/275/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=275&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303462 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/275.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/275/head:pull/275 PR: https://git.openjdk.org/jdk8u-dev/pull/275 From phh at openjdk.org Wed Mar 1 16:50:15 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 1 Mar 2023 16:50:15 GMT Subject: [jdk8u-dev] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: <4iA7_iL27T5oUHq_fcMxBkW0kXNfREfeJbmX0kz5fFU=.1220e010-cdb9-4e9d-a2ce-07e1fd2d4f97@github.com> On Tue, 28 Feb 2023 16:13:28 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and `ProblemList.txt` update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/271 From phh at openjdk.org Wed Mar 1 16:55:11 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 1 Mar 2023 16:55:11 GMT Subject: [jdk8u-dev] RFR: 8298108: Add a regression test for JDK-8297684 In-Reply-To: References: Message-ID: On Mon, 27 Feb 2023 19:13:58 GMT, Severin Gehwolf wrote: > Please review this backport of the regression test for a critical fix which we've included with the January CPU update. The fix was https://bugs.openjdk.org/browse/JDK-8280890 > > This patch adds an additional regression test which was seen in the wild with JDK 17. The patch isn't clean since the test library in jdk8u is different so needed a bit of a different setup routine for getting the jar with the provider created. Additionally, in jdk 8 the property to add providers is setting `java.ext.dirs=...` over `java.locale.providers=SPI` in later JDKs. > > Testing: The test passes for me on the current dev tree and fails with the fix from JDK-8280890 reverted. > > Thoughts? Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/269 From phh at openjdk.org Wed Mar 1 16:57:14 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 1 Mar 2023 16:57:14 GMT Subject: [jdk8u-dev] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 16:11:06 GMT, Severin Gehwolf wrote: > Clean, test-only fix modulo path changes and ProblemList.txt changes. > > Should be a trivial review. > > The test fails prior this fix and passes after. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/270 From naoto at openjdk.org Thu Mar 2 00:26:14 2023 From: naoto at openjdk.org (Naoto Sato) Date: Thu, 2 Mar 2023 00:26:14 GMT Subject: [jdk8u-ri] Integrated: 8301400: Allow additional characters for GB18030-2022 support In-Reply-To: <9lvxIc9KkKnyJCpMd17Oc0maZnRweQsMMVduW-Ru_Fg=.8c2cd1af-89e6-4b61-b1a4-827a205a02df@github.com> References: <9lvxIc9KkKnyJCpMd17Oc0maZnRweQsMMVduW-Ru_Fg=.8c2cd1af-89e6-4b61-b1a4-827a205a02df@github.com> Message-ID: On Tue, 21 Feb 2023 19:14:38 GMT, Naoto Sato wrote: > Please review the changes to the Reference Implementation of the proposed Maintenance Release of the Java SE 8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2023-February/016710.html). The RI contains a portion of previously released Maintenance Release 2 of the Java SE 8 (Unicode Characters) updates as well. (https://jcp.org/aboutJava/communityprocess/maintenance/jsr337/jsr337-mr2-changes.html#s3) This pull request has now been integrated. Changeset: a039f39e Author: Naoto Sato URL: https://git.openjdk.org/jdk8u-ri/commit/a039f39ee8486e990a4b4341c9e07fc49d3dac2d Stats: 367 lines in 5 files changed: 356 ins; 0 del; 11 mod 8301400: Allow additional characters for GB18030-2022 support Co-authored-by: Justin Lu Reviewed-by: andrew, lancea, iris, alanb ------------- PR: https://git.openjdk.org/jdk8u-ri/pull/10 From jlu at openjdk.org Thu Mar 2 00:33:10 2023 From: jlu at openjdk.org (Justin Lu) Date: Thu, 2 Mar 2023 00:33:10 GMT Subject: [jdk8u-ri] Integrated: 8303028: Update system property for Java SE specification maintenance version In-Reply-To: References: Message-ID: <5MRmNZL80uj5kgEz2Uu9uYjjjIamoqa5GlYiRiXST9o=.b7d8a369-440e-4bfa-ad60-c8b764123779@github.com> On Tue, 21 Feb 2023 21:47:26 GMT, Justin Lu wrote: > This PR updates the value of the system property: _java.specification.maintenance.version_ from 4 to 5. This change is done towards the Reference Implementation of the proposed Java SE 8 Maintenance Release 5 (https://mail.openjdk.org/pipermail/jdk8u-dev/2023-February/016710.html). This pull request has now been integrated. Changeset: 9eb797dc Author: Justin Lu Committer: Naoto Sato URL: https://git.openjdk.org/jdk8u-ri/commit/9eb797dc6ac09f250b4e308abd43bffa6529c534 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8303028: Update system property for Java SE specification maintenance version Reviewed-by: lancea, iris, naoto, andrew ------------- PR: https://git.openjdk.org/jdk8u-ri/pull/12 From duke at openjdk.org Thu Mar 2 10:08:13 2023 From: duke at openjdk.org (Deepa Kumari) Date: Thu, 2 Mar 2023 10:08:13 GMT Subject: [jdk8u-dev] Withdrawn: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 12:51:25 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/274 From duke at openjdk.org Thu Mar 2 10:24:09 2023 From: duke at openjdk.org (Deepa Kumari) Date: Thu, 2 Mar 2023 10:24:09 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 Message-ID: The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) ------------- Commit messages: - 8303408 : [AIX] Broken jdk8u build after JDK-8266391 Changes: https://git.openjdk.org/jdk8u/pull/33/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=33&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303408 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u/pull/33.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/33/head:pull/33 PR: https://git.openjdk.org/jdk8u/pull/33 From phh at openjdk.org Thu Mar 2 18:20:18 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 2 Mar 2023 18:20:18 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 10:18:18 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/33 From phh at openjdk.org Thu Mar 2 18:25:29 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 2 Mar 2023 18:25:29 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 10:18:18 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) Tagged the JBS issue. ------------- PR: https://git.openjdk.org/jdk8u/pull/33 From duke at openjdk.org Thu Mar 2 19:23:19 2023 From: duke at openjdk.org (Deepa Kumari) Date: Thu, 2 Mar 2023 19:23:19 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 18:17:13 GMT, Paul Hohensee wrote: > Lgtm. Thank you so much @phohensee for review. > Tagged the JBS issue. Okay. Thanks @phohensee . ------------- PR: https://git.openjdk.org/jdk8u/pull/33 From duke at openjdk.org Fri Mar 3 03:04:20 2023 From: duke at openjdk.org (Deepa Kumari) Date: Fri, 3 Mar 2023 03:04:20 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 10:18:18 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) I want more approvals for this fix before it gets Merge. Thanks . ------------- PR: https://git.openjdk.org/jdk8u/pull/33 From sgehwolf at openjdk.org Fri Mar 3 10:24:14 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 10:24:14 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 10:18:18 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) Looks fine. Thanks for the fix! ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/33 From sgehwolf at openjdk.org Fri Mar 3 10:27:33 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 10:27:33 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 10:18:18 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) The fix is fine. `Metrics` is a linux only (cgroups) feature. So returning null is the right thing to do on AIX. ------------- PR: https://git.openjdk.org/jdk8u/pull/33 From duke at openjdk.org Fri Mar 3 10:37:21 2023 From: duke at openjdk.org (Deepa Kumari) Date: Fri, 3 Mar 2023 10:37:21 GMT Subject: [jdk8u] Integrated: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 2 Mar 2023 10:18:18 GMT, Deepa Kumari wrote: > The AIX build fails after [JDK-8266391](https://bugs.openjdk.org/browse/JDK-8266391) was backported to jdk8. So, We added null returning SystemMetrics class an aix platform specific class that fixes the build error. > > Reported Issue : [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408) This pull request has now been integrated. Changeset: 4a837299 Author: Deepa Kumari Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8303408: [AIX] Broken jdk8u build after JDK-8266391 Reviewed-by: phh, sgehwolf ------------- PR: https://git.openjdk.org/jdk8u/pull/33 From sgehwolf at openjdk.org Fri Mar 3 10:40:14 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 10:40:14 GMT Subject: [jdk8u-dev] RFR: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: On Wed, 1 Mar 2023 14:37:49 GMT, Andrew John Hughes wrote: > Can you file this one against https://github.com/openjdk/jdk8u instead, so we can get it into the 8u372 release? I'm about to switch 8u-dev to 8u382 (development finished on Friday) and I'll approve there? @gnu-andrew Sounds good to me. I'll move test fixes #271 and #270 there as well. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/272 From sgehwolf at openjdk.org Fri Mar 3 10:40:17 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 10:40:17 GMT Subject: [jdk8u-dev] Withdrawn: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 16:16:28 GMT, Severin Gehwolf wrote: > Clean backport modulo path changes. Parity with Oracle JDK 8u371. > > Testing: > - [x] `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` and `jdk/test/security/infra/java/security/cert/CertPathValidator`. All pass after fixes in #271 and #270 > > Thoughts? This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/272 From sgehwolf at openjdk.org Fri Mar 3 10:46:13 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 10:46:13 GMT Subject: [jdk8u-dev] RFR: 8303462: Bump update version of OpenJDK: 8u382 In-Reply-To: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> References: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> Message-ID: <13MbcQ7mEMgiClVu-sjidY38VEN8doEuUbUkakkriLg=.962707be-96c1-4faf-bc0e-16418d5dacf2@github.com> On Wed, 1 Mar 2023 15:01:46 GMT, Andrew John Hughes wrote: > Rampdown for 8u372 has begun. 8u-dev needs to transition to 8u382. LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/275 From duke at openjdk.org Fri Mar 3 12:34:20 2023 From: duke at openjdk.org (Deepa Kumari) Date: Fri, 3 Mar 2023 12:34:20 GMT Subject: [jdk8u] RFR: 8303408 : [AIX] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 10:24:29 GMT, Severin Gehwolf wrote: > The fix is fine. `Metrics` is a linux only (cgroups) feature. So returning null is the right thing to do on AIX. Thanks @jerboaa for review the code. ------------- PR: https://git.openjdk.org/jdk8u/pull/33 From sgehwolf at openjdk.org Fri Mar 3 13:50:40 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 13:50:40 GMT Subject: [jdk8u-dev] RFR: 8298108: Add a regression test for JDK-8297684 In-Reply-To: References: Message-ID: On Mon, 27 Feb 2023 19:13:58 GMT, Severin Gehwolf wrote: > Please review this backport of the regression test for a critical fix which we've included with the January CPU update. The fix was https://bugs.openjdk.org/browse/JDK-8280890 > > This patch adds an additional regression test which was seen in the wild with JDK 17. The patch isn't clean since the test library in jdk8u is different so needed a bit of a different setup routine for getting the jar with the provider created. Additionally, in jdk 8 the property to add providers is setting `java.ext.dirs=...` over `java.locale.providers=SPI` in later JDKs. > > Testing: The test passes for me on the current dev tree and fails with the fix from JDK-8280890 reverted. > > Thoughts? Thanks for the review, Paul! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/269 From sgehwolf at openjdk.org Fri Mar 3 14:24:12 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:24:12 GMT Subject: [jdk8u-dev] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 16:11:06 GMT, Severin Gehwolf wrote: > Clean, test-only fix modulo path changes and ProblemList.txt changes. > > Should be a trivial review. > > The test fails prior this fix and passes after. Replaced by https://github.com/openjdk/jdk8u/pull/34 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/270 From sgehwolf at openjdk.org Fri Mar 3 14:24:13 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:24:13 GMT Subject: [jdk8u-dev] Withdrawn: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 16:11:06 GMT, Severin Gehwolf wrote: > Clean, test-only fix modulo path changes and ProblemList.txt changes. > > Should be a trivial review. > > The test fails prior this fix and passes after. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/270 From sgehwolf at openjdk.org Fri Mar 3 14:28:08 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:28:08 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails Message-ID: Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass. ------------- Commit messages: - Backport 45abbeed2f4f2899a3c1595b0cd8e573990a16fa Changes: https://git.openjdk.org/jdk8u/pull/34/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=34&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8243543 Stats: 245 lines in 1 file changed: 49 ins; 6 del; 190 mod Patch: https://git.openjdk.org/jdk8u/pull/34.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/34/head:pull/34 PR: https://git.openjdk.org/jdk8u/pull/34 From sgehwolf at openjdk.org Fri Mar 3 14:31:17 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:31:17 GMT Subject: [jdk8u-dev] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 16:13:28 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and `ProblemList.txt` update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! Replaced by https://github.com/openjdk/jdk8u/pull/35 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/271 From sgehwolf at openjdk.org Fri Mar 3 14:31:17 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:31:17 GMT Subject: [jdk8u-dev] Withdrawn: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: On Tue, 28 Feb 2023 16:13:28 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and `ProblemList.txt` update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/271 From sgehwolf at openjdk.org Fri Mar 3 14:35:20 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:35:20 GMT Subject: [jdk8u-dev] RFR: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: <31F_genEuJYkBlDOAia2LJFAHqhIoGbyyzvU5nGiDFY=.af1ae6ca-a59b-4a11-9452-2b43130a7dbb@github.com> On Tue, 28 Feb 2023 16:16:28 GMT, Severin Gehwolf wrote: > Clean backport modulo path changes. Parity with Oracle JDK 8u371. > > Testing: > - [x] `jdk/test/sun/security/lib/cacerts/VerifyCACerts.java` and `jdk/test/security/infra/java/security/cert/CertPathValidator`. All pass after fixes in #271 and #270 > > Thoughts? jdk8u PR is here: https://github.com/openjdk/jdk8u/pull/36 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/272 From sgehwolf at openjdk.org Fri Mar 3 14:36:16 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:36:16 GMT Subject: [jdk8u] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked Message-ID: Clean, test-only backport modulo path changes and ProblemList.txt update as it hasn't been added to the problem list on JDK 8u. Test fails prior this fix and passes after. Please review! ------------- Commit messages: - Backport d6bb846159be7e46fba0c3ca2915617f945e0b42 Changes: https://git.openjdk.org/jdk8u/pull/35/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=35&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8248899 Stats: 379 lines in 1 file changed: 34 ins; 31 del; 314 mod Patch: https://git.openjdk.org/jdk8u/pull/35.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/35/head:pull/35 PR: https://git.openjdk.org/jdk8u/pull/35 From sgehwolf at openjdk.org Fri Mar 3 14:40:16 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 14:40:16 GMT Subject: [jdk8u] RFR: 8245654: Add Certigna Root CA Message-ID: Clean backport modulo path changes. Parity with Oracle JDK 8u371. Testing: - [x] jdk/test/sun/security/lib/cacerts/VerifyCACerts.java and jdk/test/security/infra/java/security/cert/CertPathValidator. All pass after fixes in #34 and #35. Thoughts? ------------- Commit messages: - Backport c8ee076241cc7d83f423683d97ec37f9e0d6ebaa Changes: https://git.openjdk.org/jdk8u/pull/36/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=36&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8245654 Stats: 262 lines in 3 files changed: 258 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u/pull/36.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/36/head:pull/36 PR: https://git.openjdk.org/jdk8u/pull/36 From phh at openjdk.org Fri Mar 3 15:24:21 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 3 Mar 2023 15:24:21 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:20:41 GMT, Severin Gehwolf wrote: > Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/34 From phh at openjdk.org Fri Mar 3 15:26:23 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 3 Mar 2023 15:26:23 GMT Subject: [jdk8u] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:27:46 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and ProblemList.txt update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/35 From phh at openjdk.org Fri Mar 3 15:29:00 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 3 Mar 2023 15:29:00 GMT Subject: [jdk8u] RFR: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:31:53 GMT, Severin Gehwolf wrote: > Clean backport modulo path changes. Parity with Oracle JDK 8u371. > > Testing: > > - [x] jdk/test/sun/security/lib/cacerts/VerifyCACerts.java and jdk/test/security/infra/java/security/cert/CertPathValidator. All pass after fixes in #34 and #35. > > Thoughts? Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/36 From sgehwolf at openjdk.org Fri Mar 3 15:35:48 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 15:35:48 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:20:41 GMT, Severin Gehwolf wrote: > Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass. Thanks, Paul! ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From sgehwolf at openjdk.org Fri Mar 3 15:37:12 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 15:37:12 GMT Subject: [jdk8u] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:27:46 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and ProblemList.txt update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! Thanks, Paul! ------------- PR: https://git.openjdk.org/jdk8u/pull/35 From andrew at openjdk.org Fri Mar 3 16:40:11 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 16:40:11 GMT Subject: [jdk8u-dev] RFR: 8303462: Bump update version of OpenJDK: 8u382 In-Reply-To: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> References: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> Message-ID: On Wed, 1 Mar 2023 15:01:46 GMT, Andrew John Hughes wrote: > Rampdown for 8u372 has begun. 8u-dev needs to transition to 8u382. Thanks. Flagged for approval. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/275 From andrew at openjdk.org Fri Mar 3 17:02:22 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 17:02:22 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:20:41 GMT, Severin Gehwolf wrote: > Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass. Backport looks good (though not clean as it doesn't include changes to `ProblemList.txt`, due to the absence of [JDK-8263069](https://bugs.openjdk.org/browse/JDK-8263069)) I wouldn't usually approve this for a critical request on its own, but will do so as it's a pre-requisite for [JDK-8245654](https://bugs.openjdk.org/browse/JDK-8245654) Do you know if we also need [JDK-8263059](https://bugs.openjdk.org/browse/JDK-8263059), which fixes the third test excluded by 8263069? ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/34 From andrew at openjdk.org Fri Mar 3 17:10:10 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 17:10:10 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: <98FcH7dhD8XDlvea3R_iGaM4V9uOR5yj5Oc9QHrH0c8=.98342e12-a171-465b-977a-0bbe7a099d68@github.com> On Fri, 3 Mar 2023 16:59:47 GMT, Andrew John Hughes wrote: > Do you know if we also need [JDK-8263059](https://bugs.openjdk.org/browse/JDK-8263059), which fixes the third test excluded by 8263069? It seems we do, so I'll open a regular 8u-dev PR for that one. ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From andrew at openjdk.org Fri Mar 3 17:14:23 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 17:14:23 GMT Subject: [jdk8u] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:27:46 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and ProblemList.txt update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! Backport looks good (though not clean as it doesn't include changes to `ProblemList.txt`, due to the absence of [JDK-8263069](https://bugs.openjdk.org/browse/JDK-8263069)) I wouldn't usually approve this for a critical request on its own, but will do so as it's a pre-requisite for [JDK-8245654](https://bugs.openjdk.org/browse/JDK-8245654) ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/35 From andrew at openjdk.org Fri Mar 3 17:18:20 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 17:18:20 GMT Subject: [jdk8u] RFR: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:31:53 GMT, Severin Gehwolf wrote: > Clean backport modulo path changes. Parity with Oracle JDK 8u371. > > Testing: > > - [x] jdk/test/sun/security/lib/cacerts/VerifyCACerts.java and jdk/test/security/infra/java/security/cert/CertPathValidator. All pass after fixes in #34 and #35. > > Thoughts? Backport confirmed clean and approved. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/36 From sgehwolf at openjdk.org Fri Mar 3 17:32:22 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 17:32:22 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:20:41 GMT, Severin Gehwolf wrote: > Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass. Thanks! ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From sgehwolf at openjdk.org Fri Mar 3 17:32:22 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 17:32:22 GMT Subject: [jdk8u] Integrated: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: <2uzZ2gOQ6XoHkQkSHpoWMGd6p0wUSTbO8puwscgdEX4=.254beb32-ea2c-41d0-854b-fe6dbee74909@github.com> On Fri, 3 Mar 2023 14:20:41 GMT, Severin Gehwolf wrote: > Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass. This pull request has now been integrated. Changeset: 7c0d5b49 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u/commit/7c0d5b49c05b5990776584de9b3d9f53b8b55e94 Stats: 245 lines in 1 file changed: 49 ins; 6 del; 190 mod 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails Reviewed-by: phh, andrew Backport-of: 45abbeed2f4f2899a3c1595b0cd8e573990a16fa ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From sgehwolf at openjdk.org Fri Mar 3 17:34:15 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 17:34:15 GMT Subject: [jdk8u] RFR: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:27:46 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and ProblemList.txt update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! Thanks! ------------- PR: https://git.openjdk.org/jdk8u/pull/35 From sgehwolf at openjdk.org Fri Mar 3 17:34:17 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 17:34:17 GMT Subject: [jdk8u] Integrated: 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked In-Reply-To: References: Message-ID: <181Dl7Ij3L7q-yMJe2xxYXoofIRh9lTPl4SvrtUWk6Q=.0fbb89a7-8736-44b5-9d30-1a02eee6487e@github.com> On Fri, 3 Mar 2023 14:27:46 GMT, Severin Gehwolf wrote: > Clean, test-only backport modulo path changes and ProblemList.txt update as it hasn't been added to the problem list on JDK 8u. > > Test fails prior this fix and passes after. > > Please review! This pull request has now been integrated. Changeset: 3b80e877 Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u/commit/3b80e87798b41453738354aa4be030d420a0562a Stats: 379 lines in 1 file changed: 34 ins; 31 del; 314 mod 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked Reviewed-by: phh, andrew Backport-of: d6bb846159be7e46fba0c3ca2915617f945e0b42 ------------- PR: https://git.openjdk.org/jdk8u/pull/35 From sgehwolf at openjdk.org Fri Mar 3 17:36:13 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 17:36:13 GMT Subject: [jdk8u] RFR: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: <6GWipw8F1WJvh4cWhINSrJv8d7bvrcLEeEP1nX8Uo-w=.6ec2130a-96c3-422f-8181-86e905da5837@github.com> On Fri, 3 Mar 2023 14:31:53 GMT, Severin Gehwolf wrote: > Clean backport modulo path changes. Parity with Oracle JDK 8u371. > > Testing: > > - [x] jdk/test/sun/security/lib/cacerts/VerifyCACerts.java and jdk/test/security/infra/java/security/cert/CertPathValidator. All pass after fixes in #34 and #35. > > Thoughts? Thanks! ------------- PR: https://git.openjdk.org/jdk8u/pull/36 From sgehwolf at openjdk.org Fri Mar 3 17:36:15 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 17:36:15 GMT Subject: [jdk8u] Integrated: 8245654: Add Certigna Root CA In-Reply-To: References: Message-ID: <5xZpWvMo-srbmGZCE5cvcA9PdY10D7UVoHHLxlrgGZk=.5c718e1a-7bb9-4f82-8355-058c937bb3ca@github.com> On Fri, 3 Mar 2023 14:31:53 GMT, Severin Gehwolf wrote: > Clean backport modulo path changes. Parity with Oracle JDK 8u371. > > Testing: > > - [x] jdk/test/sun/security/lib/cacerts/VerifyCACerts.java and jdk/test/security/infra/java/security/cert/CertPathValidator. All pass after fixes in #34 and #35. > > Thoughts? This pull request has now been integrated. Changeset: 5806429f Author: Severin Gehwolf URL: https://git.openjdk.org/jdk8u/commit/5806429f7ac582c400896a7ac61e147e93ddeac8 Stats: 262 lines in 3 files changed: 258 ins; 0 del; 4 mod 8245654: Add Certigna Root CA Reviewed-by: phh, andrew Backport-of: c8ee076241cc7d83f423683d97ec37f9e0d6ebaa ------------- PR: https://git.openjdk.org/jdk8u/pull/36 From sgehwolf at openjdk.org Fri Mar 3 17:44:12 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 3 Mar 2023 17:44:12 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: <98FcH7dhD8XDlvea3R_iGaM4V9uOR5yj5Oc9QHrH0c8=.98342e12-a171-465b-977a-0bbe7a099d68@github.com> References: <98FcH7dhD8XDlvea3R_iGaM4V9uOR5yj5Oc9QHrH0c8=.98342e12-a171-465b-977a-0bbe7a099d68@github.com> Message-ID: <0v67zdqFjXdItcQJJ7a-wPFF_AELv1_hqBO25vSs50Y=.704cc3c5-4270-4526-b4be-850f5da0fab7@github.com> On Fri, 3 Mar 2023 17:07:40 GMT, Andrew John Hughes wrote: > Do you know if we also need [JDK-8263059](https://bugs.openjdk.org/browse/JDK-8263059), which fixes the third test excluded by 8263069? `ComodoCA.java` passes for me with latest jdk8u master: Passed: sun/security/lib/cacerts/VerifyCACerts.java Passed: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/CertignaCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/DTrustCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/EntrustCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/GoDaddyCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/SSLCA.java Passed: security/infra/java/security/cert/CertPathValidator/certification/TeliaSoneraCA.java Test results: passed: 15 ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From andrew at openjdk.org Fri Mar 3 18:04:19 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 18:04:19 GMT Subject: [jdk8u-dev] RFR: 8303462: Bump update version of OpenJDK: 8u382 In-Reply-To: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> References: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> Message-ID: On Wed, 1 Mar 2023 15:01:46 GMT, Andrew John Hughes wrote: > Rampdown for 8u372 has begun. 8u-dev needs to transition to 8u382. I see `jdk8u-fix-yes`. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/275 From andrew at openjdk.org Fri Mar 3 18:07:30 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 18:07:30 GMT Subject: [jdk8u-dev] Integrated: 8303462: Bump update version of OpenJDK: 8u382 In-Reply-To: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> References: <7o_vyvsIIgi42gRXPlgyUiGlhAhh2l4GjM4490z9Lh0=.51051be5-fd1b-494d-91e0-98c7dd80e250@github.com> Message-ID: On Wed, 1 Mar 2023 15:01:46 GMT, Andrew John Hughes wrote: > Rampdown for 8u372 has begun. 8u-dev needs to transition to 8u382. This pull request has now been integrated. Changeset: 3d1fc4bf Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/3d1fc4bf31e7b4bc7f3d0627f7aee44fe48d414c Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8303462: Bump update version of OpenJDK: 8u382 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/275 From andrew at openjdk.org Fri Mar 3 18:10:42 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 18:10:42 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: <0v67zdqFjXdItcQJJ7a-wPFF_AELv1_hqBO25vSs50Y=.704cc3c5-4270-4526-b4be-850f5da0fab7@github.com> References: <98FcH7dhD8XDlvea3R_iGaM4V9uOR5yj5Oc9QHrH0c8=.98342e12-a171-465b-977a-0bbe7a099d68@github.com> <0v67zdqFjXdItcQJJ7a-wPFF_AELv1_hqBO25vSs50Y=.704cc3c5-4270-4526-b4be-850f5da0fab7@github.com> Message-ID: On Fri, 3 Mar 2023 17:41:52 GMT, Severin Gehwolf wrote: > > Do you know if we also need [JDK-8263059](https://bugs.openjdk.org/browse/JDK-8263059), which fixes the third test excluded by 8263069? > > `ComodoCA.java` passes for me with latest jdk8u master: > > ``` > Passed: sun/security/lib/cacerts/VerifyCACerts.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/CertignaCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/DTrustCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/EntrustCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/GlobalSignR6CA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/GoDaddyCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/HaricaCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/LuxTrustCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/SSLCA.java > Passed: security/infra/java/security/cert/CertPathValidator/certification/TeliaSoneraCA.java > Test results: passed: 15 > ``` Passes with as well. Strange. https://github.com/openjdk/jdk8u-dev/pull/276 will at least sync the test with 11u. ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From andrew at openjdk.org Fri Mar 3 18:10:46 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 18:10:46 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: On Fri, 3 Mar 2023 14:20:41 GMT, Severin Gehwolf wrote: > Simple test fix. Clean, test-only fix modulo path changes and ProblemList.txt changes. Add this so that https://bugs.openjdk.org/browse/JDK-8245654 can be added and tests pass. BTW, is there a reason these aren't in the GitHub Actions testing? It seems we could have caught these earlier if so and keeping this up-to-date seems important. ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From andrew at openjdk.org Fri Mar 3 18:13:42 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 3 Mar 2023 18:13:42 GMT Subject: [jdk8u-dev] RFR: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert Message-ID: <9TtAd0bayt--BjbAoJ-qSnLtEu4SzgvPYZmhF6fFcS4=.019eae34-685f-47dc-81e3-d16697bacc3a@github.com> Changes apply cleanly bar the `ProblemList.txt` removal as JDK-8243543 was never backported. This is much the same as the backports of JDK-8248899 (https://github.com/openjdk/jdk8u/pull/35) and JDK-8243543 (https://github.com/openjdk/jdk8u/pull/34) All `security/infra` tests pass with the patch, with the exception of `ActalisCA.java` (problem listed) and the two tests fixed by the aforementioned PRs (will be fixed when 8u372-b05 is promoted & merged into jdk8u-dev) ------------- Commit messages: - Backport 0d0aa7ce8116db959836d59477598a8427a4c16f Changes: https://git.openjdk.org/jdk8u-dev/pull/276/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=276&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8263059 Stats: 439 lines in 1 file changed: 141 ins; 232 del; 66 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/276.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/276/head:pull/276 PR: https://git.openjdk.org/jdk8u-dev/pull/276 From duke at openjdk.org Fri Mar 3 19:27:11 2023 From: duke at openjdk.org (Stewart X Addison) Date: Fri, 3 Mar 2023 19:27:11 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 Message-ID: As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. ------------- Commit messages: - Backport 6042c6b9bbacbff1bd47f087f0f19646a20eef97 Changes: https://git.openjdk.org/jdk8u-dev/pull/277/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=277&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8295530 Stats: 11105 lines in 23 files changed: 9979 ins; 184 del; 942 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/277.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/277/head:pull/277 PR: https://git.openjdk.org/jdk8u-dev/pull/277 From duke at openjdk.org Sun Mar 5 11:42:25 2023 From: duke at openjdk.org (Stewart X Addison) Date: Sun, 5 Mar 2023 11:42:25 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v2] In-Reply-To: References: Message-ID: > As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. > > Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. > > I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. > > - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ > - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ > - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ > > This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. Stewart X Addison has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: Backport 6042c6b9bbacbff1bd47f087f0f19646a20eef97 Signed-off-by: Stewart X Addison ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/277/files - new: https://git.openjdk.org/jdk8u-dev/pull/277/files/28d430e5..d9c51d9b Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=277&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=277&range=00-01 Stats: 94 lines in 1 file changed: 0 ins; 92 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/277.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/277/head:pull/277 PR: https://git.openjdk.org/jdk8u-dev/pull/277 From dongbohe at openjdk.org Mon Mar 6 01:54:10 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Mon, 6 Mar 2023 01:54:10 GMT Subject: [jdk8u-dev] RFR: 8185736: missing default exception handler in calls to rethrow_Stub [v2] In-Reply-To: References: Message-ID: On Mon, 20 Feb 2023 03:11:34 GMT, Dongbo He wrote: >> Hi, >> >> I would like to backport this patch to fix missing of default exception handler in catch table produced by C2. >> Patch apply cleanly, worked correctly after patch. >> >> Testing: Performed hotspot jtreg test on linux x86-64 platforms with -XX:-TieredCompilation -Xcomp options. > > Dongbo He has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8185736 > - Backport b97f668af3f55c0d67cdd7a4a191bd81cdc4aa78 Got the jdk8u-fix-yes. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/231 From duke at openjdk.org Mon Mar 6 12:21:13 2023 From: duke at openjdk.org (Stewart X Addison) Date: Mon, 6 Mar 2023 12:21:13 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v2] In-Reply-To: References: Message-ID: On Sun, 5 Mar 2023 11:42:25 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 6042c6b9bbacbff1bd47f087f0f19646a20eef97 > > Signed-off-by: Stewart X Addison (Note to anyone reading the previous automated comment - the force push only changed the ChangeLog_Java file which was changed on my local file system but hadn't been pushed so shouldn't invalidate anything else above) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From sgehwolf at openjdk.org Mon Mar 6 13:14:16 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 6 Mar 2023 13:14:16 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v2] In-Reply-To: References: Message-ID: On Mon, 6 Mar 2023 12:18:05 GMT, Stewart X Addison wrote: >> Stewart X Addison has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> Backport 6042c6b9bbacbff1bd47f087f0f19646a20eef97 >> >> Signed-off-by: Stewart X Addison > > (Note to anyone reading the previous automated comment - the force push only changed the ChangeLog_Java file which was changed on my local file system but hadn't been pushed so shouldn't invalidate anything else above) @sxa Please enable testing on your fork. See `Pre-submit test status` section. Click on `Details` to see what needs to be done. Thanks! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From duke at openjdk.org Mon Mar 6 14:59:30 2023 From: duke at openjdk.org (Stewart X Addison) Date: Mon, 6 Mar 2023 14:59:30 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v2] In-Reply-To: References: Message-ID: On Mon, 6 Mar 2023 12:18:05 GMT, Stewart X Addison wrote: >> Stewart X Addison has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> Backport 6042c6b9bbacbff1bd47f087f0f19646a20eef97 >> >> Signed-off-by: Stewart X Addison > > (Note to anyone reading the previous automated comment - the force push only changed the ChangeLog_Java file which was changed on my local file system but hadn't been pushed so shouldn't invalidate anything else above) > @sxa Please enable testing on your fork. See `Pre-submit test status` section. Click on `Details` to see what needs to be done. Thanks! Done - and seems to have passed :-) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From dongbohe at openjdk.org Mon Mar 6 15:00:33 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Mon, 6 Mar 2023 15:00:33 GMT Subject: [jdk8u-dev] Integrated: 8185736: missing default exception handler in calls to rethrow_Stub In-Reply-To: References: Message-ID: On Wed, 18 Jan 2023 09:22:22 GMT, Dongbo He wrote: > Hi, > > I would like to backport this patch to fix missing of default exception handler in catch table produced by C2. > Patch apply cleanly, worked correctly after patch. > > Testing: Performed hotspot jtreg test on linux x86-64 platforms with -XX:-TieredCompilation -Xcomp options. This pull request has now been integrated. Changeset: eb2aee68 Author: Dongbo He Committer: Roland Westrelin URL: https://git.openjdk.org/jdk8u-dev/commit/eb2aee68eaff5d4880b52bc8c01967215dd6a741 Stats: 10 lines in 2 files changed: 10 ins; 0 del; 0 mod 8185736: missing default exception handler in calls to rethrow_Stub Reviewed-by: roland Backport-of: b97f668af3f55c0d67cdd7a4a191bd81cdc4aa78 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/231 From andrew at openjdk.org Tue Mar 7 22:55:21 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 7 Mar 2023 22:55:21 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: Bring in jdk8u372-b05 ------------- Commit messages: - Merge tag 'jdk8u372-b05' into sync - 8245654: Add Certigna Root CA - 8248899: security/infra/java/security/cert/CertPathValidator/certification/QuoVadisCA.java fails, Certificate has been revoked - 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails - 8303408: [AIX] Broken jdk8u build after JDK-8266391 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/278/files Stats: 887 lines in 6 files changed: 342 ins; 37 del; 508 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/278.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/278/head:pull/278 PR: https://git.openjdk.org/jdk8u-dev/pull/278 From andrew at openjdk.org Wed Mar 8 03:02:16 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 8 Mar 2023 03:02:16 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: References: Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- On Tue, 7 Mar 2023 22:49:01 GMT, Andrew John Hughes wrote: > Bring in jdk8u372-b05 This pull request has now been integrated. Changeset: 7c5d77cb Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/7c5d77cbd2cf993643d48ded46342e01772a96cc Stats: 887 lines in 6 files changed: 342 ins; 37 del; 508 mod Merge ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/278 From andrew at openjdk.org Wed Mar 8 03:09:09 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 8 Mar 2023 03:09:09 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v2] In-Reply-To: References: Message-ID: On Sun, 5 Mar 2023 11:42:25 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport 6042c6b9bbacbff1bd47f087f0f19646a20eef97 > > Signed-off-by: Stewart X Addison The changes made to `zlib.md` in the 11u patch need to be made to `THIRD_PARTY_README` in 8u. There are currently multiple identical copies of this file across the old subrepositories. I would suggest just updating the top-level one. I'll open a separate bug & PR to remove the duplicates which I don't think are helpful any more. ~~~ $ grep 'zlib' $(find -name 'THIRD_PARTY_README') ./THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ./corba/THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ./hotspot/THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ./jaxp/THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ./jaxws/THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ./jdk/THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ./langtools/THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ./nashorn/THIRD_PARTY_README:%% This notice is provided with respect to zlib v1.2.11, which may be included ~~~ ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From sgehwolf at openjdk.org Wed Mar 8 09:07:34 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 8 Mar 2023 09:07:34 GMT Subject: [jdk8u] RFR: 8243543: jtreg test security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java fails In-Reply-To: References: Message-ID: <9DD2VlVYGI855BAiKl5fJS1gDpnZy86aIHydlGxBvMk=.64ac252e-915c-43f8-b5de-c1ce135a370e@github.com> On Fri, 3 Mar 2023 18:08:32 GMT, Andrew John Hughes wrote: > BTW, is there a reason these aren't in the GitHub Actions testing? It seems we could have caught these earlier if so and keeping this up-to-date seems important. I don't think there is. Feel free to propose a patch to rectify this! Thanks. ------------- PR: https://git.openjdk.org/jdk8u/pull/34 From duke at openjdk.org Wed Mar 8 12:35:01 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 8 Mar 2023 12:35:01 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v3] In-Reply-To: References: Message-ID: > As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. > > Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. > > I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. > > - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ > - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ > - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ > > This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: zlib 1.2.13: Add updated license to top level THIRD_PARTY_README Signed-off-by: Stewart X Addison ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/277/files - new: https://git.openjdk.org/jdk8u-dev/pull/277/files/d9c51d9b..b56e4f3f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=277&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=277&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/277.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/277/head:pull/277 PR: https://git.openjdk.org/jdk8u-dev/pull/277 From duke at openjdk.org Wed Mar 8 12:40:59 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 8 Mar 2023 12:40:59 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: > As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. > > Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. > > I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. > > - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ > - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ > - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ > > This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: Update line for zlib 1.2.13 Signed-off-by: Stewart X Addison ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/277/files - new: https://git.openjdk.org/jdk8u-dev/pull/277/files/b56e4f3f..bc9c3614 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=277&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=277&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/277.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/277/head:pull/277 PR: https://git.openjdk.org/jdk8u-dev/pull/277 From duke at openjdk.org Wed Mar 8 12:41:04 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 8 Mar 2023 12:41:04 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v2] In-Reply-To: References: Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- On Wed, 8 Mar 2023 03:06:15 GMT, Andrew John Hughes wrote: > The changes made to `zlib.md` in the 11u patch need to be made to `THIRD_PARTY_README` in 8u. > > There are currently multiple identical copies of this file across the old subrepositories. I would suggest just updating the top-level one. I'll open a separate bug & PR to remove the duplicates which I don't think are helpful any more. Thanks - top level one updated to match the current contents at https://www.zlib.net/zlib_license.html (including the initial line containing the version number to be consistent with how it was before). The rest of the text matches what's in `zlib.md` ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From duke at openjdk.org Wed Mar 8 16:45:58 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 8 Mar 2023 16:45:58 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison Is there still sufficient runway to get this into 8u372? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From afarley at openjdk.org Wed Mar 8 17:52:57 2023 From: afarley at openjdk.org (Adam Farley) Date: Wed, 8 Mar 2023 17:52:57 GMT Subject: [jdk8u-dev] RFR: JDK-8303828: Fix for build break on Solaris due to missing class Message-ID: The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. ------------- Commit messages: - Fix for build break on Solaris due to missing class Changes: https://git.openjdk.org/jdk8u-dev/pull/280/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=280&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303828 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/280.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/280/head:pull/280 PR: https://git.openjdk.org/jdk8u-dev/pull/280 From sgehwolf at openjdk.org Wed Mar 8 19:34:07 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 8 Mar 2023 19:34:07 GMT Subject: [jdk8u-dev] RFR: JDK-8303828: Fix for build break on Solaris due to missing class In-Reply-To: References: Message-ID: <6KzXjK9fWwqXwrY6IyOvd1gXxr2PBCWxG4Iki1_YHug=.523cab7a-33fd-44c3-b55e-7ddb3f07a1f0@github.com> On Wed, 8 Mar 2023 17:47:41 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. @adamfarley I think this fix warrants getting included in the `8u372` release as we did with [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408). Please propose a PR here instead: https://github.com/openjdk/jdk8u Thanks! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/280 From afarley at openjdk.org Thu Mar 9 12:36:20 2023 From: afarley at openjdk.org (Adam Farley) Date: Thu, 9 Mar 2023 12:36:20 GMT Subject: [jdk8u-dev] RFR: JDK-8303828: Fix for build break on Solaris due to missing class In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 17:47:41 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. Good idea Severin. [PR created.](https://github.com/openjdk/jdk8u/pull/37) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/280 From afarley at openjdk.org Thu Mar 9 12:36:20 2023 From: afarley at openjdk.org (Adam Farley) Date: Thu, 9 Mar 2023 12:36:20 GMT Subject: [jdk8u-dev] Withdrawn: JDK-8303828: Fix for build break on Solaris due to missing class In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 17:47:41 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/280 From afarley at openjdk.org Thu Mar 9 13:38:24 2023 From: afarley at openjdk.org (Adam Farley) Date: Thu, 9 Mar 2023 13:38:24 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 Message-ID: Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). ------------- Commit messages: - Fix for build break on Solaris due to missing class Changes: https://git.openjdk.org/jdk8u/pull/37/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=37&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8303828 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u/pull/37.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/37/head:pull/37 PR: https://git.openjdk.org/jdk8u/pull/37 From sgehwolf at openjdk.org Thu Mar 9 13:38:24 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 9 Mar 2023 13:38:24 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 12:32:11 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. > > P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). LGTM. Please change the PR title to `8303828: [Solaris] Broken jdk8u build after JDK-8266391` so that it matches the JBS issue. Then, please enable testing on your fork. See `Details` link in `Pre-submit test status` which has instructions. Finally, switch the approval labels to `jdk8u-critical-request` (from `jdk8u-fix-request`). Thanks! ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/37 From sgehwolf at openjdk.org Thu Mar 9 16:58:58 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 9 Mar 2023 16:58:58 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: <-plXjj-ouPtp0tJ_579-fuHCJj6LqKNG-oWH9svvMy8=.b8b52672-40eb-4708-82f5-8ca80c9fc3da@github.com> On Thu, 9 Mar 2023 12:32:11 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. > > P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). @adamfarley The bug is approved, feel free to `/integrate` ------------- PR: https://git.openjdk.org/jdk8u/pull/37 From afarley at openjdk.org Thu Mar 9 17:02:37 2023 From: afarley at openjdk.org (Adam Farley) Date: Thu, 9 Mar 2023 17:02:37 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 12:32:11 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. > > P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). Thanks Severin. :) ------------- PR: https://git.openjdk.org/jdk8u/pull/37 From andrew at openjdk.org Thu Mar 9 17:15:53 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 9 Mar 2023 17:15:53 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: On Thu, 9 Mar 2023 12:32:11 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. > > P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). Makes sense. I guess we should have expected this after the AIX one. At least now we know who to contact for future issues that touch Solaris and AIX! ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/37 From andrew at openjdk.org Thu Mar 9 17:15:55 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 9 Mar 2023 17:15:55 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: <_SSyRspnCSXZOSdG6AziSvMId_JhMEdz0qD90Df-F9M=.cffd4321-2707-480a-96d5-5ec63f38bcae@github.com> On Thu, 9 Mar 2023 16:59:22 GMT, Adam Farley wrote: >> Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. >> >> This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. >> >> This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. >> >> P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). > > Thanks Severin. :) @adamfarley, doesn't matter for this one (as the testers don't build on Solaris anyway obviously), but you should make sure to enable GitHub Actions in your fork for any future changes, so testing will run. ------------- PR: https://git.openjdk.org/jdk8u/pull/37 From afarley at openjdk.org Thu Mar 9 17:18:57 2023 From: afarley at openjdk.org (Adam Farley) Date: Thu, 9 Mar 2023 17:18:57 GMT Subject: [jdk8u] Integrated: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: <727R3icf_I0-O-NB7d9f9ItUEmlkWQJukQUeKnTfZj0=.22e7ed55-bc9f-411f-8e03-726e16bff9db@github.com> On Thu, 9 Mar 2023 12:32:11 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. > > P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). This pull request has now been integrated. Changeset: ebbd3a87 Author: Adam Farley Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8303828: [Solaris] Broken jdk8u build after JDK-8266391 Reviewed-by: sgehwolf, andrew ------------- PR: https://git.openjdk.org/jdk8u/pull/37 From duke at openjdk.org Fri Mar 10 00:58:02 2023 From: duke at openjdk.org (=?UTF-8?B?5p+z6bKy6bmP?=) Date: Fri, 10 Mar 2023 00:58:02 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea Message-ID: JDK-8264728 : When use chinese IME, the candidate box isn't moved with caret of JTextArea Type: Bug Component: client-libs Sub-Component: java.awt:i18n Affected Version: 8,9,15,16 Priority: P3 Status: Open Resolution: Unresolved OS: linux CPU: x86_64 ------------- Commit messages: - 8264728:When use chinese IME, the candidate box isn't moved with caret of JTextArea Changes: https://git.openjdk.org/jdk8u-dev/pull/281/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=281&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8264728 Stats: 99 lines in 3 files changed: 99 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/281.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/281/head:pull/281 PR: https://git.openjdk.org/jdk8u-dev/pull/281 From andrew at openjdk.org Fri Mar 10 02:47:10 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 10 Mar 2023 02:47:10 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: <8iP7SWe8jPnATjKAFqhJsrJG7XdIgXyt9JXi3W8iVjI=.6a5b9224-0e0a-4668-9381-08a1856d335b@github.com> On Wed, 8 Mar 2023 16:43:05 GMT, Stewart X Addison wrote: > Is there still sufficient runway to get this into 8u372? I was wondering what your intention was here when I first reviewed it. Integrating this PR will include it in 8u382. We're still taking critical fixes and regression patches for 8u372 for the next few weeks (https://wiki.openjdk.org/display/jdk8u/Main), directly against https://github.com/openjdk/jdk8u Does this qualify? It's quite a large change to be making at that stage and I'd prefer it went into 8u382. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From andrew at openjdk.org Fri Mar 10 02:47:12 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 10 Mar 2023 02:47:12 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: <57bacWZ4TJOEsIBfHkfoDt7eN600LV6i4hZ-tASRwhs=.60deaec9-b9a9-4f20-bcb8-f09194ba4588@github.com> The message from this sender included one or more files which could not be scanned for virus detection; do not open these files unless you are certain of the sender's intent. ---------------------------------------------------------------------- On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison Patch now looks good, by the way. I'm just holding off until we decide whether this is the right tree to push to. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From sgehwolf at openjdk.org Fri Mar 10 09:34:14 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 10 Mar 2023 09:34:14 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 00:51:37 GMT, ??? wrote: > JDK-8264728 : When use chinese IME, the candidate box isn't moved with caret of JTextArea > Type: Bug > Component: client-libs > Sub-Component: java.awt:i18n > Affected Version: 8,9,15,16 > Priority: P3 > Status: Open > Resolution: Unresolved > OS: linux > CPU: x86_64 @quantum6 From the bug description it sounds like this is an issue in later JDKs as well, please fix it in the latest development tree first where it reproduces (possibly JDK 21 at https://github.com/openjdk/jdk/), Once a fix is in later JDKs, the fix can get backported. So in this case it would be something like: 1. Fix in JDK `XX` where `XX` is the latest JDK where this reproduces 2. Backport to older JDK `YY` where `YY` is `< 8` (LTS versions and latest STS seems sufficient). 3. Come back with a backport to 8 once 1 and 2 are done. Thanks! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/281 From sgehwolf at openjdk.org Fri Mar 10 09:36:18 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 10 Mar 2023 09:36:18 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: <8iP7SWe8jPnATjKAFqhJsrJG7XdIgXyt9JXi3W8iVjI=.6a5b9224-0e0a-4668-9381-08a1856d335b@github.com> References: <8iP7SWe8jPnATjKAFqhJsrJG7XdIgXyt9JXi3W8iVjI=.6a5b9224-0e0a-4668-9381-08a1856d335b@github.com> Message-ID: On Fri, 10 Mar 2023 02:44:02 GMT, Andrew John Hughes wrote: > Does this qualify? It's quite a large change to be making at that stage and I'd prefer it went into 8u382. +1 It seems `8u382` is sufficient for this? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From duke at openjdk.org Fri Mar 10 12:20:14 2023 From: duke at openjdk.org (Stewart X Addison) Date: Fri, 10 Mar 2023 12:20:14 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: <8iP7SWe8jPnATjKAFqhJsrJG7XdIgXyt9JXi3W8iVjI=.6a5b9224-0e0a-4668-9381-08a1856d335b@github.com> Message-ID: On Fri, 10 Mar 2023 09:33:09 GMT, Severin Gehwolf wrote: > Does this qualify? It's quite a large change to be making at that stage and I'd prefer it went into 8u382. The CVE referenced in the description was [raised by a customer](https://github.com/adoptium/adoptium-support/issues/619#issuecomment-1447720601zlib.net) about JDK17 where it was flagged by the [BDBA scanner](https://www.synopsys.com/software-integrity/security-testing/software-composition-analysis/binary-analysis.html) While I haven't run an equivalent scan against JDK8u I would expect the same to be true there, so it ultimately depends on whether this high vulnerability is considered a critical enough fix to warrant inclusion in 8u372. It is targetted for 17.0.7 and 11.0.19 based on [the bug](https://bugs.openjdk.org/browse/JDK-8295530) so getting it into 8u372 would put it into all streams simultaneously, but I'll defer to your judgement as to whether that's a good enough justification. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From sgehwolf at openjdk.org Fri Mar 10 17:43:06 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 10 Mar 2023 17:43:06 GMT Subject: [jdk8u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digest algorithms Message-ID: Please review this backport which fixes a regression new in 8u362 due to [JDK-8269039](https://bugs.openjdk.org/browse/JDK-8269039). For some jars which are signed with an obsolete digest algorithm, after JDK-8269039, they're treated as unsigned even though one of the signatories used a valid (non-obsolete) digest algo. The backport is not clean, mainly because of JDK-8275887 (which in 11u wasn't present when that bug was backported), copyright headers and different test infra in 8u. So the test looks a bit different so that it works on 8u. All of the changes are fairly trivial to resolve. Changes in `SecurityUtils.java` aren't needed as 8u-dev already has them. Testing: - [x] `jdk/test/sun/security/tools/jarsigner` tests pass. - [x] new regression test. Fails prior product fix, passes after. ------------- Commit messages: - Backport cbe497394786ff76a09f9743040e3ba96ee8298f Changes: https://git.openjdk.org/jdk8u-dev/pull/282/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=282&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278851 Stats: 264 lines in 3 files changed: 215 ins; 19 del; 30 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/282.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/282/head:pull/282 PR: https://git.openjdk.org/jdk8u-dev/pull/282 From sgehwolf at openjdk.org Mon Mar 13 09:27:35 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 13 Mar 2023 09:27:35 GMT Subject: [jdk8u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digest algorithms In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 17:35:19 GMT, Severin Gehwolf wrote: > Please review this backport which fixes a regression new in 8u362 due to [JDK-8269039](https://bugs.openjdk.org/browse/JDK-8269039). For some jars which are signed with an obsolete digest algorithm, after JDK-8269039, they're treated as unsigned even though one of the signatories used a valid (non-obsolete) digest algo. > > The backport is not clean, mainly because of JDK-8275887 (which in 11u wasn't present when that bug was backported), copyright headers and different test infra in 8u. So the test looks a bit different so that it works on 8u. All of the changes are fairly trivial to resolve. Changes in `SecurityUtils.java` aren't needed as 8u-dev already has them. > > Testing: > - [x] `jdk/test/sun/security/tools/jarsigner` tests pass. > - [x] new regression test. Fails prior product fix, passes after. GHA failure on Linux x86 (32 bit) of `gc/logging/TestGCId.java` seems unrelated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/282 From duke at openjdk.org Mon Mar 13 13:27:55 2023 From: duke at openjdk.org (Stewart X Addison) Date: Mon, 13 Mar 2023 13:27:55 GMT Subject: [jdk8u] RFR: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" Message-ID: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> This reverts commit 4a837299c68071be563e376efe6f12852bc130e7. After the [AIX build break fix](https://github.com/openjdk/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7), a [subsequent commit to fix Solaris](https://github.com/openjdk/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186) caused a duplicate symbol error during compilation on AIX. This should fix it. Verified on [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/254/console) and [Solaris/x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/290/console) This PR reverts the AIX fix, leaving the solaris (generic UNIX) fix to apply to both platforms. Opening against jdk8u since this is a build break. Will create an equivalent PR for jdk8u-dev. Please let me know if there is a specific process required for such revert commits Original AIX issue: https://bugs.openjdk.org/browse/JDK-8303408 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/274) Original Solaris issue: https://bugs.openjdk.org/browse/JDK-8303828 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/280) Earlier backport that introduced the original breaks: https://bugs.openjdk.org/browse/JDK-8266391 ------------- Commit messages: - Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" Changes: https://git.openjdk.org/jdk8u/pull/39/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=39&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304053 Stats: 32 lines in 1 file changed: 0 ins; 32 del; 0 mod Patch: https://git.openjdk.org/jdk8u/pull/39.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/39/head:pull/39 PR: https://git.openjdk.org/jdk8u/pull/39 From duke at openjdk.org Mon Mar 13 13:27:56 2023 From: duke at openjdk.org (Stewart X Addison) Date: Mon, 13 Mar 2023 13:27:56 GMT Subject: [jdk8u] RFR: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" In-Reply-To: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> References: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> Message-ID: <9j9Cbo8bfcvp-p5p7XAnpaDtlnfm3IQ4eY-sQSXTNOE=.4c309c12-2e2d-416d-9e9c-50d61492f5df@github.com> On Mon, 13 Mar 2023 12:27:52 GMT, Stewart X Addison wrote: > This reverts commit 4a837299c68071be563e376efe6f12852bc130e7. > > After the [AIX build break fix](https://github.com/openjdk/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7), a [subsequent commit to fix Solaris](https://github.com/openjdk/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186) caused a duplicate symbol error during compilation on AIX. This should fix it. Verified on [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/254/console) and [Solaris/x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/290/console) > > This PR reverts the AIX fix, leaving the solaris (generic UNIX) fix to apply to both platforms. Opening against jdk8u since this is a build break. Will create an equivalent PR for jdk8u-dev. > > Please let me know if there is a specific process required for such revert commits > > Original AIX issue: https://bugs.openjdk.org/browse/JDK-8303408 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/274) > Original Solaris issue: https://bugs.openjdk.org/browse/JDK-8303828 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/280) > Earlier backport that introduced the original breaks: https://bugs.openjdk.org/browse/JDK-8266391 @jerboaa @andrew-m-leonard @adamfarley Can one of you create a bug for this please so I can reference it in the title to be able to pass the checks? Title updated ------------- PR: https://git.openjdk.org/jdk8u/pull/39 From afarley at openjdk.org Mon Mar 13 13:27:57 2023 From: afarley at openjdk.org (Adam Farley) Date: Mon, 13 Mar 2023 13:27:57 GMT Subject: [jdk8u] RFR: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" In-Reply-To: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> References: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> Message-ID: On Mon, 13 Mar 2023 12:27:52 GMT, Stewart X Addison wrote: > This reverts commit 4a837299c68071be563e376efe6f12852bc130e7. > > After the [AIX build break fix](https://github.com/openjdk/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7), a [subsequent commit to fix Solaris](https://github.com/openjdk/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186) caused a duplicate symbol error during compilation on AIX. This should fix it. Verified on [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/254/console) and [Solaris/x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/290/console) > > This PR reverts the AIX fix, leaving the solaris (generic UNIX) fix to apply to both platforms. Opening against jdk8u since this is a build break. Will create an equivalent PR for jdk8u-dev. > > Please let me know if there is a specific process required for such revert commits > > Original AIX issue: https://bugs.openjdk.org/browse/JDK-8303408 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/274) > Original Solaris issue: https://bugs.openjdk.org/browse/JDK-8303828 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/280) > Earlier backport that introduced the original breaks: https://bugs.openjdk.org/browse/JDK-8266391 Sure. 1 second. https://bugs.openjdk.org/browse/JDK-8304053 ------------- PR: https://git.openjdk.org/jdk8u/pull/39 From sgehwolf at openjdk.org Mon Mar 13 13:41:51 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 13 Mar 2023 13:41:51 GMT Subject: [jdk8u] RFR: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" In-Reply-To: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> References: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> Message-ID: On Mon, 13 Mar 2023 12:27:52 GMT, Stewart X Addison wrote: > Will create an equivalent PR for jdk8u-dev. No need, thanks! Once integrated the change will get merged into `jdk8u-dev` in due time. Please add `/summary 8303828 supersedes fix of 8303408`. Thanks! ------------- PR: https://git.openjdk.org/jdk8u/pull/39 From sgehwolf at openjdk.org Mon Mar 13 15:59:58 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 13 Mar 2023 15:59:58 GMT Subject: [jdk8u] RFR: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" In-Reply-To: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> References: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> Message-ID: <_9hPZcmoNh6oOeoQ7rXmQaGeYOTqjNomaalJyTTWCsU=.1d8eb229-eec3-448a-8b61-051e44e86c82@github.com> On Mon, 13 Mar 2023 12:27:52 GMT, Stewart X Addison wrote: > This reverts commit 4a837299c68071be563e376efe6f12852bc130e7. > > After the [AIX build break fix](https://github.com/openjdk/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7), a [subsequent commit to fix Solaris](https://github.com/openjdk/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186) caused a duplicate symbol error during compilation on AIX. This should fix it. Verified on [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/254/console) and [Solaris/x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/290/console) > > This PR reverts the AIX fix, leaving the solaris (generic UNIX) fix to apply to both platforms. Opening against jdk8u since this is a build break. Will create an equivalent PR for jdk8u-dev. > > Please let me know if there is a specific process required for such revert commits > > Original AIX issue: https://bugs.openjdk.org/browse/JDK-8303408 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/274) > Original Solaris issue: https://bugs.openjdk.org/browse/JDK-8303828 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/280) > Earlier backport that introduced the original breaks: https://bugs.openjdk.org/browse/JDK-8266391 Marked as reviewed by sgehwolf (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u/pull/39 From sgehwolf at openjdk.org Tue Mar 14 14:57:59 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 14:57:59 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: Message-ID: <29UFZYxtQzdPeU1CRsHCG4WmVP3RRfE_ndQsIxovSuk=.ea3692fa-ac3e-46ee-9453-f910c7484f6f@github.com> On Thu, 9 Mar 2023 12:32:11 GMT, Adam Farley wrote: > Because Solaris currently lacks this class, the build breaks when compiling Metrics.java. Inserting a dummy class to fix that. > > This takes the same approach as [JDK-8303408](https://bugs.openjdk.org/browse/JDK-8303408), only on Solaris. > > This change is being proposed directly to JDK8u because I'm not aware of Solaris platform support post-JDK8. > > P.S. This PR is being created for jdk8u (as well as jdk8u-dev) as per this advice [here](https://github.com/openjdk/jdk8u-dev/pull/280#issuecomment-1460740821). This seems to have broken the build on linux and apparently on mac os on the rampdown tree. The issue seems to be that on the old build system `solaris/classes` are being merged on mac/linux/aix as well. So while it fixes the solaris build it breaks linux and mac. GHA would have caught it. Sigh. ------------- PR: https://git.openjdk.org/jdk8u/pull/37 From afarley at openjdk.org Tue Mar 14 15:02:32 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 15:02:32 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos Message-ID: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. ------------- Commit messages: - 8304143 - Exclude duplicated class on linux, aix, and macos Changes: https://git.openjdk.org/jdk8u/pull/40/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=40&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8304143 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u/pull/40.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/40/head:pull/40 PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 15:02:35 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 15:02:35 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos In-Reply-To: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 14:54:41 GMT, Adam Farley wrote: > This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. @adamfarley Please enable GHA. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From afarley at openjdk.org Tue Mar 14 15:02:35 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 15:02:35 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos In-Reply-To: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 14:54:41 GMT, Adam Farley wrote: > This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. I thought I did. It seems to be running something. Is this not GHA? https://github.com/adamfarley/jdk8u/actions/runs/4417066915 ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 15:10:18 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 15:10:18 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 14:58:14 GMT, Adam Farley wrote: > It seems to be running something. Is this not GHA? > > https://github.com/adamfarley/jdk8u/actions/runs/4417066915 Yes, that's GHA. I mentioned it, because #37 didn't have it enabled causing the breakage :-( ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From afarley at openjdk.org Tue Mar 14 15:20:16 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 15:20:16 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 15:07:27 GMT, Severin Gehwolf wrote: > > It seems to be running something. Is this not GHA? > > https://github.com/adamfarley/jdk8u/actions/runs/4417066915 > > Yes, that's GHA. I mentioned it, because #37 didn't have it enabled causing the breakage :-( Fair enough. Better to be safe than sorry. Again. :( ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 15:24:48 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 15:24:48 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos In-Reply-To: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 14:54:41 GMT, Adam Farley wrote: > This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. We should only exclude the class on Linux. That's the OS where the `SystemMetrics` class is actually implemented. In order to solve the resulting build break on Mac and AIX, we should revert additions of the `null` returning classes there. Perhaps with #39. I propose the following course of action to fix it: 1. Only exclude `SystemMetrics.java` on Linux from the `solaris` directory in this PR. Make this PR dependent on #39 (dependent pull request). 2. Revert stub impl additions on Mac OS X and AIX with #39. @gnu-andrew Thoughts? ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 15:27:25 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 15:27:25 GMT Subject: [jdk8u] RFR: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" In-Reply-To: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> References: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> Message-ID: <1MvSqZso8qGJasuLVbsbhxOYFbJ1dQYp7FeSrmrrXlI=.9020870b-3f07-45f0-9f0d-1d45e463d16b@github.com> On Mon, 13 Mar 2023 12:27:52 GMT, Stewart X Addison wrote: > This reverts commit 4a837299c68071be563e376efe6f12852bc130e7. > > After the [AIX build break fix](https://github.com/openjdk/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7), a [subsequent commit to fix Solaris](https://github.com/openjdk/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186) caused a duplicate symbol error during compilation on AIX. This should fix it. Verified on [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/254/console) and [Solaris/x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/290/console) > > This PR reverts the AIX fix, leaving the solaris (generic UNIX) fix to apply to both platforms. Opening against jdk8u since this is a build break. Will create an equivalent PR for jdk8u-dev. > > Please let me know if there is a specific process required for such revert commits > > Original AIX issue: https://bugs.openjdk.org/browse/JDK-8303408 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/274) > Original Solaris issue: https://bugs.openjdk.org/browse/JDK-8303828 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/280) > Earlier backport that introduced the original breaks: https://bugs.openjdk.org/browse/JDK-8266391 Hold off on integrating this, please. See https://github.com/openjdk/jdk8u/pull/40#pullrequestreview-1339562332 ------------- Changes requested by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/39 From afarley at openjdk.org Tue Mar 14 15:39:51 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 15:39:51 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos [v2] In-Reply-To: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: > This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. Adam Farley has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8304143: Fix duplicated class build error on linux, aix, and macos This change ensures that each of the affected platforms only uses one copy of the SystemMetrics class. Either the stub version, or a platform-specific version. Signed-off-by: Adam Farley ------------- Changes: - all: https://git.openjdk.org/jdk8u/pull/40/files - new: https://git.openjdk.org/jdk8u/pull/40/files/21be0c1d..d4e4f5b9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=40&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=40&range=00-01 Stats: 66 lines in 3 files changed: 0 ins; 65 del; 1 mod Patch: https://git.openjdk.org/jdk8u/pull/40.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/40/head:pull/40 PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 15:45:39 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 15:45:39 GMT Subject: [jdk8u] RFR: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" In-Reply-To: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> References: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> Message-ID: On Mon, 13 Mar 2023 12:27:52 GMT, Stewart X Addison wrote: > This reverts commit 4a837299c68071be563e376efe6f12852bc130e7. > > After the [AIX build break fix](https://github.com/openjdk/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7), a [subsequent commit to fix Solaris](https://github.com/openjdk/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186) caused a duplicate symbol error during compilation on AIX. This should fix it. Verified on [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/254/console) and [Solaris/x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/290/console) > > This PR reverts the AIX fix, leaving the solaris (generic UNIX) fix to apply to both platforms. Opening against jdk8u since this is a build break. Will create an equivalent PR for jdk8u-dev. > > Please let me know if there is a specific process required for such revert commits > > Original AIX issue: https://bugs.openjdk.org/browse/JDK-8303408 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/274) > Original Solaris issue: https://bugs.openjdk.org/browse/JDK-8303828 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/280) > Earlier backport that introduced the original breaks: https://bugs.openjdk.org/browse/JDK-8266391 This pr is superseded by #40. ------------- PR: https://git.openjdk.org/jdk8u/pull/39 From sgehwolf at openjdk.org Tue Mar 14 15:45:36 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 15:45:36 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 15:21:51 GMT, Severin Gehwolf wrote: > We should only exclude the class on Linux. That's the OS where the `SystemMetrics` class is actually implemented. In order to solve the resulting build break on Mac and AIX, we should revert additions of the `null` returning classes there. Perhaps with #39. > > I propose the following course of action to fix it: > > 1. Only exclude `SystemMetrics.java` on Linux from the `solaris` directory in this PR. Make this PR dependent on #39 (dependent pull request). > 2. Revert stub impl additions on Mac OS X and AIX with #39. Change of plan. Do all of it here, and use JDK-8304053 as the bug to integrate. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From andrew at openjdk.org Tue Mar 14 15:45:46 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 14 Mar 2023 15:45:46 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 15:39:51 GMT, Adam Farley wrote: >> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. > > Adam Farley has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8304143: Fix duplicated class build error on linux, aix, and macos > > This change ensures that each of the affected platforms only uses > one copy of the SystemMetrics class. Either the stub version, or > a platform-specific version. > > Signed-off-by: Adam Farley Ok, this just changed while I was looking at it :) I think the current version incorporates #39 now, so we just need this one? This seems to relate to what I was referring to in [my comment](https://bugs.openjdk.org/browse/JDK-8303828?focusedCommentId=14565610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14565610) on the bug about 11u. 11u uses `src/unix` for the generic versions and platform-specific overrides. On 8u, `src/solaris` is that generic version unless we opt out. So I would also remove the unused `unix` copy of the file here, assuming builds aren't broken, and refer to both bug IDs. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From duke at openjdk.org Tue Mar 14 15:52:11 2023 From: duke at openjdk.org (Stewart X Addison) Date: Tue, 14 Mar 2023 15:52:11 GMT Subject: [jdk8u] Withdrawn: 8304053: Revert "8303408: [AIX] Broken jdk8u build after JDK-8266391" In-Reply-To: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> References: <6aUnZ0-5c22hpaepQ-WU2FqDMDXXAlXEsrVv8iVRt1k=.570bd92f-b869-4c4a-ae86-dceb4e33096d@github.com> Message-ID: On Mon, 13 Mar 2023 12:27:52 GMT, Stewart X Addison wrote: > This reverts commit 4a837299c68071be563e376efe6f12852bc130e7. > > After the [AIX build break fix](https://github.com/openjdk/jdk8u/commit/4a837299c68071be563e376efe6f12852bc130e7), a [subsequent commit to fix Solaris](https://github.com/openjdk/jdk8u/commit/ebbd3a87b0c473a744499d5f7691e5207cd73186) caused a duplicate symbol error during compilation on AIX. This should fix it. Verified on [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/254/console) and [Solaris/x64](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/290/console) > > This PR reverts the AIX fix, leaving the solaris (generic UNIX) fix to apply to both platforms. Opening against jdk8u since this is a build break. Will create an equivalent PR for jdk8u-dev. > > Please let me know if there is a specific process required for such revert commits > > Original AIX issue: https://bugs.openjdk.org/browse/JDK-8303408 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/274) > Original Solaris issue: https://bugs.openjdk.org/browse/JDK-8303828 and [8u-dev PR](https://github.com/openjdk/jdk8u-dev/pull/280) > Earlier backport that introduced the original breaks: https://bugs.openjdk.org/browse/JDK-8266391 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u/pull/39 From andrew at openjdk.org Tue Mar 14 15:57:01 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 14 Mar 2023 15:57:01 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: <29UFZYxtQzdPeU1CRsHCG4WmVP3RRfE_ndQsIxovSuk=.ea3692fa-ac3e-46ee-9453-f910c7484f6f@github.com> References: <29UFZYxtQzdPeU1CRsHCG4WmVP3RRfE_ndQsIxovSuk=.ea3692fa-ac3e-46ee-9453-f910c7484f6f@github.com> Message-ID: On Tue, 14 Mar 2023 14:55:10 GMT, Severin Gehwolf wrote: > This seems to have broken the build on linux and apparently on mac os on the rampdown tree. The issue seems to be that on the old build system `solaris/classes` are being merged on mac/linux/aix as well. So while it fixes the solaris build it breaks linux and mac. GHA would have caught it. Sigh. My bad. I should have required that run before allowing this one. It completely slipped my mind that the `solaris` directory was the generic directory on 8u and older. ------------- PR: https://git.openjdk.org/jdk8u/pull/37 From sgehwolf at openjdk.org Tue Mar 14 16:03:07 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 16:03:07 GMT Subject: [jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 15:42:20 GMT, Andrew John Hughes wrote: > Ok, this just changed while I was looking at it :) Indeed. Sorry about that. > I think the current version incorporates #39 now, so we just need this one? Yes, lets' just use this one and https://bugs.openjdk.org/browse/JDK-8304053 as the associated bug to integrate. > This seems to relate to what I was referring to in [my comment](https://bugs.openjdk.org/browse/JDK-8303828?focusedCommentId=14565610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14565610) on the bug about 11u. 11u uses `src/unix` for the generic versions and platform-specific overrides. On 8u, `src/solaris` is that generic version unless we opt out. Yep. > So I would also remove the unused `unix` copy of the file here, assuming builds aren't broken, and refer to both bug IDs. Sounds good. The `unix` [copy](https://github.com/openjdk/jdk8u/blob/ebbd3a87b0c473a744499d5f7691e5207cd73186/jdk/src/unix/classes/jdk/internal/platform/SystemMetrics.java) doesn't do anything in 8u. @adamfarley Could you please do that? ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From afarley at openjdk.org Tue Mar 14 16:10:22 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 16:10:22 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 15:39:51 GMT, Adam Farley wrote: >> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. > > Adam Farley has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8304143: Fix duplicated class build error on linux, aix, and macos > > This change ensures that each of the affected platforms only uses > one copy of the SystemMetrics class. Either the stub version, or > a platform-specific version. > > Signed-off-by: Adam Farley Sure thing. I've changed the PR title as requested, and will remove the unix stub class. Will not squash or force push. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From afarley at openjdk.org Tue Mar 14 16:16:36 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 16:16:36 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v3] In-Reply-To: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: > This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. Adam Farley has updated the pull request incrementally with one additional commit since the last revision: Removing unix SystemMetrics stub class as well We shouldn't need it, as jdk8u uses the solaris stub class in the same way as it should have used the unix stub class. Signed-off-by: Adam Farley ------------- Changes: - all: https://git.openjdk.org/jdk8u/pull/40/files - new: https://git.openjdk.org/jdk8u/pull/40/files/d4e4f5b9..b6a882fe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=40&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=40&range=01-02 Stats: 31 lines in 1 file changed: 0 ins; 31 del; 0 mod Patch: https://git.openjdk.org/jdk8u/pull/40.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/40/head:pull/40 PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 16:16:39 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 16:16:39 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 15:39:51 GMT, Adam Farley wrote: >> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. > > Adam Farley has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8304143: Fix duplicated class build error on linux, aix, and macos > > This change ensures that each of the affected platforms only uses > one copy of the SystemMetrics class. Either the stub version, or > a platform-specific version. > > Signed-off-by: Adam Farley jdk/make/CompileJavaClasses.gmk line 310: > 308: ifeq ($(OPENJDK_TARGET_OS),linux) > 309: LINUX_SRC_DIRS += $(JDK_TOPDIR)/src/linux/classes > 310: EXFILES += $(JDK_TOPDIR)/src/solaris/classes/jdk/internal/platform/SystemMetrics.java Please add a comment above this line like this: # Linux is the only OS with an actual implementation of SystemMetrics. # Exclude the generic null-returning stub from solaris/classes for that reason. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From afarley at openjdk.org Tue Mar 14 16:19:39 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 16:19:39 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 16:12:09 GMT, Severin Gehwolf wrote: >> Adam Farley has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> 8304143: Fix duplicated class build error on linux, aix, and macos >> >> This change ensures that each of the affected platforms only uses >> one copy of the SystemMetrics class. Either the stub version, or >> a platform-specific version. >> >> Signed-off-by: Adam Farley > > jdk/make/CompileJavaClasses.gmk line 310: > >> 308: ifeq ($(OPENJDK_TARGET_OS),linux) >> 309: LINUX_SRC_DIRS += $(JDK_TOPDIR)/src/linux/classes >> 310: EXFILES += $(JDK_TOPDIR)/src/solaris/classes/jdk/internal/platform/SystemMetrics.java > > Please add a comment above this line like this: > > # Linux is the only OS with an actual implementation of SystemMetrics. > # Exclude the generic null-returning stub from solaris/classes for that reason. Sure. 1 moment. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 16:25:21 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 16:25:21 GMT Subject: [jdk8u] RFR: 8303828: [Solaris] Broken jdk8u build after JDK-8266391 In-Reply-To: References: <29UFZYxtQzdPeU1CRsHCG4WmVP3RRfE_ndQsIxovSuk=.ea3692fa-ac3e-46ee-9453-f910c7484f6f@github.com> Message-ID: On Tue, 14 Mar 2023 15:54:14 GMT, Andrew John Hughes wrote: > > This seems to have broken the build on linux and apparently on mac os on the rampdown tree. The issue seems to be that on the old build system `solaris/classes` are being merged on mac/linux/aix as well. So while it fixes the solaris build it breaks linux and mac. GHA would have caught it. Sigh. > > My bad. I should have required that run before allowing this one. It completely slipped my mind that the `solaris` directory was the generic directory on 8u and older. No worries. This `solaris` peculiarity slipped my mind as well... ------------- PR: https://git.openjdk.org/jdk8u/pull/37 From andrew at openjdk.org Tue Mar 14 16:26:29 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 14 Mar 2023 16:26:29 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison I tend to agree it would be better to do this across all JDKs at the same time, but, as explained in e-mail, I'll let Severin have the final ok on this. If we do move it to 8u372, just close this PR and open the same changes against openjdk/jdk8u instead. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From afarley at openjdk.org Tue Mar 14 16:27:08 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 16:27:08 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v4] In-Reply-To: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: > This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. Adam Farley has updated the pull request incrementally with one additional commit since the last revision: Adding comment Signed-off-by: Adam Farley ------------- Changes: - all: https://git.openjdk.org/jdk8u/pull/40/files - new: https://git.openjdk.org/jdk8u/pull/40/files/b6a882fe..02ec9735 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=40&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=40&range=02-03 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u/pull/40.diff Fetch: git fetch https://git.openjdk.org/jdk8u pull/40/head:pull/40 PR: https://git.openjdk.org/jdk8u/pull/40 From andrew at openjdk.org Tue Mar 14 16:27:12 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 14 Mar 2023 16:27:12 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v3] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: <0ckXb0NNRKb_C2PX4EESefWjSXNyunWgQTkv_6Eh7EI=.168a08c6-007f-4550-8e97-1982db689eec@github.com> On Tue, 14 Mar 2023 16:16:36 GMT, Adam Farley wrote: >> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. > > Adam Farley has updated the pull request incrementally with one additional commit since the last revision: > > Removing unix SystemMetrics stub class as well > > We shouldn't need it, as jdk8u uses the solaris stub class in the > same way as it should have used the unix stub class. > > Signed-off-by: Adam Farley Looks good to me, with Severin's suggested change. ------------- Marked as reviewed by andrew (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/40 From afarley at openjdk.org Tue Mar 14 16:27:19 2023 From: afarley at openjdk.org (Adam Farley) Date: Tue, 14 Mar 2023 16:27:19 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 16:16:17 GMT, Adam Farley wrote: >> jdk/make/CompileJavaClasses.gmk line 310: >> >>> 308: ifeq ($(OPENJDK_TARGET_OS),linux) >>> 309: LINUX_SRC_DIRS += $(JDK_TOPDIR)/src/linux/classes >>> 310: EXFILES += $(JDK_TOPDIR)/src/solaris/classes/jdk/internal/platform/SystemMetrics.java >> >> Please add a comment above this line like this: >> >> # Linux is the only OS with an actual implementation of SystemMetrics. >> # Exclude the generic null-returning stub from solaris/classes for that reason. > > Sure. 1 moment. Done. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 16:28:40 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 16:28:40 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v4] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 16:27:08 GMT, Adam Farley wrote: >> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. > > Adam Farley has updated the pull request incrementally with one additional commit since the last revision: > > Adding comment > > Signed-off-by: Adam Farley Looks good. Let's wait for a clean GHA run this time before we integrate :) ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 16:28:43 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 16:28:43 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 16:19:40 GMT, Adam Farley wrote: >> Sure. 1 moment. > > Done. Thanks! ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From zzambers at openjdk.org Tue Mar 14 16:41:42 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 14 Mar 2023 16:41:42 GMT Subject: [jdk8u-dev] RFR: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation Message-ID: Backport from [11u-dev](https://github.com/openjdk/jdk11u-dev/commit/80615a6f39bf8929908804ce3f9f5c6d4b3f2864#commitcomment-104241918) fixing debug messages printed by P11PSSSignature class during normal operation. Testing: [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4408224445/jobs/7722950851) OK (no regression to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395)). ------------- Commit messages: - Backport 80615a6f39bf8929908804ce3f9f5c6d4b3f2864 Changes: https://git.openjdk.org/jdk8u-dev/pull/283/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=283&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293815 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/283.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/283/head:pull/283 PR: https://git.openjdk.org/jdk8u-dev/pull/283 From zzambers at openjdk.org Tue Mar 14 16:52:05 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 14 Mar 2023 16:52:05 GMT Subject: [jdk8u-dev] RFR: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary Message-ID: Backport from [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/commit/e80528bf2bd1c87fc1394dd32015281ac6652363#commitcomment-104263811) fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client. Testing: [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4408247017/jobs/7723001910) OK (no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395)). ------------- Commit messages: - Backport e80528bf2bd1c87fc1394dd32015281ac6652363 Changes: https://git.openjdk.org/jdk8u-dev/pull/284/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=284&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8282600 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/284.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/284/head:pull/284 PR: https://git.openjdk.org/jdk8u-dev/pull/284 From andrew at openjdk.org Tue Mar 14 17:04:59 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 14 Mar 2023 17:04:59 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v4] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: <7I7-4B9gntVASQ9eBXuum7LljUq7ivwR2FVAFGbC1eI=.f9e09ef4-1fd4-4800-9ebf-a22e21b000bc@github.com> On Tue, 14 Mar 2023 16:27:08 GMT, Adam Farley wrote: >> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. > > Adam Farley has updated the pull request incrementally with one additional commit since the last revision: > > Adding comment > > Signed-off-by: Adam Farley FYI: Linux builds are broken without this too: ~~~ ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Tue Mar 14 17:27:04 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 17:27:04 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison I'm thinking this should be fine for 8u382 in July. Which platforms does in-tree zlib affect, Windows only? ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From sgehwolf at openjdk.org Tue Mar 14 18:07:46 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 18:07:46 GMT Subject: [jdk8u-dev] RFR: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert In-Reply-To: <9TtAd0bayt--BjbAoJ-qSnLtEu4SzgvPYZmhF6fFcS4=.019eae34-685f-47dc-81e3-d16697bacc3a@github.com> References: <9TtAd0bayt--BjbAoJ-qSnLtEu4SzgvPYZmhF6fFcS4=.019eae34-685f-47dc-81e3-d16697bacc3a@github.com> Message-ID: On Fri, 3 Mar 2023 18:06:57 GMT, Andrew John Hughes wrote: > Changes apply cleanly bar the `ProblemList.txt` removal as JDK-8243543 was never backported. This is much the same as the backports of JDK-8248899 (https://github.com/openjdk/jdk8u/pull/35) and JDK-8243543 (https://github.com/openjdk/jdk8u/pull/34) > > All `security/infra` tests pass with the patch, with the exception of `ActalisCA.java` (problem listed) and the two tests fixed by the aforementioned PRs (will be fixed when 8u372-b05 is promoted & merged into jdk8u-dev) Looks good to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/276 From sgehwolf at openjdk.org Tue Mar 14 18:15:24 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 14 Mar 2023 18:15:24 GMT Subject: [jdk8u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digest algorithms In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 17:35:19 GMT, Severin Gehwolf wrote: > Please review this backport which fixes a regression new in 8u362 due to [JDK-8269039](https://bugs.openjdk.org/browse/JDK-8269039). For some jars which are signed with an obsolete digest algorithm, after JDK-8269039, they're treated as unsigned even though one of the signatories used a valid (non-obsolete) digest algo. > > The backport is not clean, mainly because of JDK-8275887 (which in 11u wasn't present when that bug was backported), copyright headers and different test infra in 8u. So the test looks a bit different so that it works on 8u. All of the changes are fairly trivial to resolve. Changes in `SecurityUtils.java` aren't needed as 8u-dev already has them. > > Testing: > - [x] `jdk/test/sun/security/tools/jarsigner` tests pass. > - [x] new regression test. Fails prior product fix, passes after. @martinuy Hi! Could you please help review this? Thanks. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/282 From zzambers at openjdk.org Tue Mar 14 18:34:53 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 14 Mar 2023 18:34:53 GMT Subject: [jdk8u-dev] Integrated: 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation In-Reply-To: References: Message-ID: On Tue, 14 Mar 2023 16:34:43 GMT, Zdenek Zambersky wrote: > Backport from [11u-dev](https://github.com/openjdk/jdk11u-dev/commit/80615a6f39bf8929908804ce3f9f5c6d4b3f2864#commitcomment-104241918) fixing debug messages printed by P11PSSSignature class during normal operation. > > Testing: > [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4408224445/jobs/7722950851) OK (no regression to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395)). This pull request has now been integrated. Changeset: a7fb08c2 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/a7fb08c286f0181a3bb725b88a7da8c651202be0 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod 8293815: P11PSSSignature.engineUpdate should not print debug messages during normal operation Backport-of: 80615a6f39bf8929908804ce3f9f5c6d4b3f2864 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/283 From zzambers at openjdk.org Tue Mar 14 18:35:56 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 14 Mar 2023 18:35:56 GMT Subject: [jdk8u-dev] Integrated: 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary In-Reply-To: References: Message-ID: On Tue, 14 Mar 2023 16:44:47 GMT, Zdenek Zambersky wrote: > Backport from [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/commit/e80528bf2bd1c87fc1394dd32015281ac6652363#commitcomment-104263811) fixing SSLSocket, not to use workaround with user_canceled alert for TLS 1.3 close, when not necessary, as it causes problems with gnutls client. > > Testing: > [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4408247017/jobs/7723001910) OK (no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395)). This pull request has now been integrated. Changeset: d6f81510 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/d6f8151053f40ccd8c23b9f9eecb40c306a6253f Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 8282600: SSLSocketImpl should not use user_canceled workaround when not necessary Backport-of: e80528bf2bd1c87fc1394dd32015281ac6652363 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/284 From sgehwolf at openjdk.org Wed Mar 15 13:00:38 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 15 Mar 2023 13:00:38 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v4] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 16:27:08 GMT, Adam Farley wrote: >> This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. > > Adam Farley has updated the pull request incrementally with one additional commit since the last revision: > > Adding comment > > Signed-off-by: Adam Farley Failure (timeout) on mac of `java/math/BigInteger/LargeValueExceptions.java` seems unrelated. ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From sgehwolf at openjdk.org Wed Mar 15 13:00:41 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 15 Mar 2023 13:00:41 GMT Subject: [jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v2] In-Reply-To: References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: On Tue, 14 Mar 2023 16:07:40 GMT, Adam Farley wrote: >> Adam Farley has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> 8304143: Fix duplicated class build error on linux, aix, and macos >> >> This change ensures that each of the affected platforms only uses >> one copy of the SystemMetrics class. Either the stub version, or >> a platform-specific version. >> >> Signed-off-by: Adam Farley > > Sure thing. I've changed the PR title as requested, and will remove the unix stub class. Will not squash or force push. > > Edit: Done. @adamfarley The bug is approved. GHA looks OK. Please `/integrate`. Thanks! ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From afarley at openjdk.org Wed Mar 15 14:14:30 2023 From: afarley at openjdk.org (Adam Farley) Date: Wed, 15 Mar 2023 14:14:30 GMT Subject: [jdk8u] Integrated: 8304053: Revert os specific stubs for SystemMetrics In-Reply-To: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> References: <1K3z42EsIl_uSoGBwnegRVpl3SdMBpSDjItGBJVzKNQ=.d9597a31-acfa-4d9f-9e9d-c7980f2c7f30@github.com> Message-ID: <0yLifkzFIq4SI56pGEoGqMrNg-JGwq8qDZcw58ff_5c=.799985db-1783-42b7-9ce4-b9463dbeb432@github.com> On Tue, 14 Mar 2023 14:54:41 GMT, Adam Farley wrote: > This change excludes the duplicated class SystemMetrics, and ensures we use the platform-specific version of the SystemMetrics class instead. This pull request has now been integrated. Changeset: 89aeae16 Author: Adam Farley Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u/commit/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99 Stats: 98 lines in 4 files changed: 4 ins; 94 del; 0 mod 8304053: Revert os specific stubs for SystemMetrics Reviewed-by: sgehwolf, andrew ------------- PR: https://git.openjdk.org/jdk8u/pull/40 From zzambers at openjdk.org Wed Mar 15 15:04:36 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 15 Mar 2023 15:04:36 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode Message-ID: This is backport[1][2] of code adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires` First commit is backport Itself. Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6]) These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested) Testing: Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works). [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b [3] https://github.com/openjdk/jdk8u-dev/pull/222 [4] https://github.com/openjdk/jdk8u-dev/pull/182 [5] https://bugs.openjdk.org/browse/JDK-8154204 [6] https://github.com/openjdk/jdk8u-dev/pull/181 ------------- Commit messages: - Switch few tests (back) to uses @requires - 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode Changes: https://git.openjdk.org/jdk8u-dev/pull/286/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=286&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8152432 Stats: 161 lines in 5 files changed: 145 ins; 14 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/286.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/286/head:pull/286 PR: https://git.openjdk.org/jdk8u-dev/pull/286 From duke at openjdk.org Wed Mar 15 15:14:36 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 15 Mar 2023 15:14:36 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: <4cTVLHCIMxnsM_UdTr7lLwH1Axq3zh5KKzXcNdiZ4vk=.cc463644-5de1-4b11-8280-42555c58c2fc@github.com> On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison For Eclipse Temurin we're using `bundled` zlib on most platforms for JDK8 so I would expect Linux, AIX and others to be affected too. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From zzambers at openjdk.org Wed Mar 15 15:19:36 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 15 Mar 2023 15:19:36 GMT Subject: [jdk8u-dev] RFR: 8289301: P11Cipher should not throw out of bounds exception during padding Message-ID: <34U5wBJmzAgOIa0hNkfGU-gdviexXM7Xsl6QQoHUvcU=.2a59a8ed-0256-47d3-835b-c5c921566889@github.com> Fix for possible OOB exception by P11Cipher. Backported from [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/commit/7d8991978bbe1cc03ba2386f5e699239ba47934c). Only really modified `@library` (fixed by removing unnecessary path.) Testing: [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4427068905/jobs/7764159983) OK (new test passed, no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395) ) ------------- Commit messages: - Backport 7d8991978bbe1cc03ba2386f5e699239ba47934c Changes: https://git.openjdk.org/jdk8u-dev/pull/287/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=287&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8289301 Stats: 124 lines in 2 files changed: 117 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/287.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/287/head:pull/287 PR: https://git.openjdk.org/jdk8u-dev/pull/287 From duke at openjdk.org Wed Mar 15 15:19:40 2023 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 15 Mar 2023 15:19:40 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison Based on the above discussions targetting 8u382 sounds good to me, so are ok to get this tagged appropriately so it can be integrated? (I don't have author privileges so can't tag it myself) ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From zzambers at openjdk.org Wed Mar 15 15:27:44 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 15 Mar 2023 15:27:44 GMT Subject: [jdk8u-dev] RFR: 8293232: Fix race condition in pkcs11 SessionManager Message-ID: Backport from [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/commit/939741c0a0a4a5ce2c68d14b15e1f42563bc653d) - fix for race condition in pkcs11 SessionManager. Clean except for copyright date. Testing: [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4427088716/jobs/7764206204) OK (no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395)). ------------- Commit messages: - Backport 939741c0a0a4a5ce2c68d14b15e1f42563bc653d Changes: https://git.openjdk.org/jdk8u-dev/pull/288/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=288&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8293232 Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/288.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/288/head:pull/288 PR: https://git.openjdk.org/jdk8u-dev/pull/288 From phh at openjdk.org Wed Mar 15 17:48:29 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 15 Mar 2023 17:48:29 GMT Subject: [jdk8u-dev] RFR: 8289301: P11Cipher should not throw out of bounds exception during padding In-Reply-To: <34U5wBJmzAgOIa0hNkfGU-gdviexXM7Xsl6QQoHUvcU=.2a59a8ed-0256-47d3-835b-c5c921566889@github.com> References: <34U5wBJmzAgOIa0hNkfGU-gdviexXM7Xsl6QQoHUvcU=.2a59a8ed-0256-47d3-835b-c5c921566889@github.com> Message-ID: On Wed, 15 Mar 2023 15:12:36 GMT, Zdenek Zambersky wrote: > Fix for possible OOB exception by P11Cipher. Backported from [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/commit/7d8991978bbe1cc03ba2386f5e699239ba47934c). > > Only really modified `@library` (fixed by removing unnecessary path.) > > Testing: > [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4427068905/jobs/7764159983) OK (new test passed, no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395) ) Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/287 From mbalao at openjdk.org Wed Mar 15 18:31:31 2023 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 15 Mar 2023 18:31:31 GMT Subject: [jdk8u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digest algorithms In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 17:35:19 GMT, Severin Gehwolf wrote: > Please review this backport which fixes a regression new in 8u362 due to [JDK-8269039](https://bugs.openjdk.org/browse/JDK-8269039). For some jars which are signed with an obsolete digest algorithm, after JDK-8269039, they're treated as unsigned even though one of the signatories used a valid (non-obsolete) digest algo. > > The backport is not clean, mainly because of JDK-8275887 (which in 11u wasn't present when that bug was backported), copyright headers and different test infra in 8u. So the test looks a bit different so that it works on 8u. All of the changes are fairly trivial to resolve. Changes in `SecurityUtils.java` aren't needed as 8u-dev already has them. > > Testing: > - [x] `jdk/test/sun/security/tools/jarsigner` tests pass. > - [x] new regression test. Fails prior product fix, passes after. Hi @jerboaa , Thanks for contributing this backport. Looks good to me. I've run the _JarWithOneNonDisabledDigestAlg_ test locally and passes. Minor note ?which is not worth any change to the current proposal, in my view?: the list that _List.of_ returns is unmodifiable, which is not the case for _Arrays.asList_. Just out of curiosity, was there a reason for placing _JarWithOneNonDisabledDigestAlg_ into a new _disdigest_ directory? I see that in 11u and above is in the _jarsigner_ directory. Thanks, Martin.- ------------- Marked as reviewed by mbalao (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/282 From sgehwolf at openjdk.org Wed Mar 15 19:49:26 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 15 Mar 2023 19:49:26 GMT Subject: [jdk8u-dev] RFR: 8278851: Correct signer logic for jars signed with multiple digest algorithms In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 17:35:19 GMT, Severin Gehwolf wrote: > Please review this backport which fixes a regression new in 8u362 due to [JDK-8269039](https://bugs.openjdk.org/browse/JDK-8269039). For some jars which are signed with an obsolete digest algorithm, after JDK-8269039, they're treated as unsigned even though one of the signatories used a valid (non-obsolete) digest algo. > > The backport is not clean, mainly because of JDK-8275887 (which in 11u wasn't present when that bug was backported), copyright headers and different test infra in 8u. So the test looks a bit different so that it works on 8u. All of the changes are fairly trivial to resolve. Changes in `SecurityUtils.java` aren't needed as 8u-dev already has them. > > Testing: > - [x] `jdk/test/sun/security/tools/jarsigner` tests pass. > - [x] new regression test. Fails prior product fix, passes after. Thanks for the review! > Minor note ?which is not worth any change to the current proposal, in my view?: the list that _List.of_ returns is unmodifiable, which is not the case for _Arrays.asList_. OK. I could wrap it in `Collections.unmodifiableList(...)`, but it's probably not worth it in this case. > Just out of curiosity, was there a reason for placing _JarWithOneNonDisabledDigestAlg_ into a new _disdigest_ directory? I see that in 11u and above is in the _jarsigner_ directory. Yes, the test failed when adding to the `jarsigner` directory directly. At least when the full suite of tests was run in the `jarsigner` directory. If I remember correctly, this caused some weird CNFE. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/282 From phh at openjdk.org Wed Mar 15 20:50:25 2023 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 15 Mar 2023 20:50:25 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 14:57:06 GMT, Zdenek Zambersky wrote: > This is backport [1][2] which adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires` > > First commit is backport Itself. > > Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6]) > These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested) > > Testing: > Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works). > > [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 > [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b > [3] https://github.com/openjdk/jdk8u-dev/pull/222 > [4] https://github.com/openjdk/jdk8u-dev/pull/182 > [5] https://bugs.openjdk.org/browse/JDK-8154204 > [6] https://github.com/openjdk/jdk8u-dev/pull/181 In DefaultUseWithClient, please remove line 41 (i.e., "// Skip this test on any other platform"the comment for the Windows client check) because it's redundant. Otherwise, looks fine. ------------- Changes requested by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/286 From duke at openjdk.org Thu Mar 16 08:57:40 2023 From: duke at openjdk.org (ktakakuri) Date: Thu, 16 Mar 2023 08:57:40 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, ktakakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 I issued a PR for JDK-8154043 and JDK-8182577. https://github.com/openjdk/jdk8u-dev/pull/285 Thank you. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/212 From sgehwolf at openjdk.org Thu Mar 16 10:49:25 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 16 Mar 2023 10:49:25 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 14:57:06 GMT, Zdenek Zambersky wrote: > This is backport [1][2] which adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires` > > First commit is backport Itself. > > Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6]) > These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested) > > Testing: > Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works). > > [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 > [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b > [3] https://github.com/openjdk/jdk8u-dev/pull/222 > [4] https://github.com/openjdk/jdk8u-dev/pull/182 > [5] https://bugs.openjdk.org/browse/JDK-8154204 > [6] https://github.com/openjdk/jdk8u-dev/pull/181 This is supported with JTREG 4.1+. We use [jtreg 5.1](https://github.com/openjdk/jdk8u-dev/blob/d6f8151053f40ccd8c23b9f9eecb40c306a6253f/make/conf/test-dependencies#L29) minimum. So this seems fine (with changes suggested by Paul). ------------- Marked as reviewed by sgehwolf (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/286 From duke at openjdk.org Thu Mar 16 11:05:15 2023 From: duke at openjdk.org (SUN Guoyun) Date: Thu, 16 Mar 2023 11:05:15 GMT Subject: [jdk8u-dev] RFR: 8048076: [TESTBUG] runtime/Unsafe/RangeCheck.java fails with -Xcomp Message-ID: Backport from https://hg.openjdk.org/jdk9/jdk9/hotspot/rev/51b82a72aafb ------------- Commit messages: - Backport 30b9c7d9cb93e650177421c667760b91ba566103 Changes: https://git.openjdk.org/jdk8u-dev/pull/289/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=289&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8048076 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/289.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/289/head:pull/289 PR: https://git.openjdk.org/jdk8u-dev/pull/289 From zzambers at openjdk.org Thu Mar 16 12:26:50 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 16 Mar 2023 12:26:50 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode [v2] In-Reply-To: References: Message-ID: > This is backport [1][2] which adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires` > > First commit is backport Itself. > > Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6]) > These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested) > > Testing: > Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works). > > [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 > [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b > [3] https://github.com/openjdk/jdk8u-dev/pull/222 > [4] https://github.com/openjdk/jdk8u-dev/pull/182 > [5] https://bugs.openjdk.org/browse/JDK-8154204 > [6] https://github.com/openjdk/jdk8u-dev/pull/181 Zdenek Zambersky has updated the pull request incrementally with one additional commit since the last revision: DefaultUseWithClient.java: remove redundant comment line ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/286/files - new: https://git.openjdk.org/jdk8u-dev/pull/286/files/6ec2df7e..daa900e5 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=286&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=286&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/286.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/286/head:pull/286 PR: https://git.openjdk.org/jdk8u-dev/pull/286 From zzambers at openjdk.org Thu Mar 16 12:29:24 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 16 Mar 2023 12:29:24 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode [v2] In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 20:47:39 GMT, Paul Hohensee wrote: > In DefaultUseWithClient, please remove line 41 (i.e., "// Skip this test on any other platform"the comment for the Windows client check) because it's redundant. Otherwise, looks fine. Fixed ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/286 From zzambers at openjdk.org Thu Mar 16 12:47:28 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 16 Mar 2023 12:47:28 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode [v2] In-Reply-To: References: Message-ID: On Thu, 16 Mar 2023 10:46:50 GMT, Severin Gehwolf wrote: > This is supported with JTREG 4.1+. We use [jtreg 5.1](https://github.com/openjdk/jdk8u-dev/blob/d6f8151053f40ccd8c23b9f9eecb40c306a6253f/make/conf/test-dependencies#L29) minimum. So this seems fine (with changes suggested by Paul). Btw. I have also tried to run this with [jtreg-4.2-b16](https://github.com/zzambers/jdk8u-dev/actions/runs/4318478578), vm properties in `@requires` worked as expected. (this jtreg version seems to have some problems with shell tests on windows) I have also tried to run on windows with [client vm](https://github.com/zzambers/jdk8u-dev/actions/runs/4318332376/jobs/7655485292), where DefaultUseWithClient ran as expected. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/286 From zzambers at openjdk.org Thu Mar 16 12:52:30 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 16 Mar 2023 12:52:30 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode [v2] In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 20:47:39 GMT, Paul Hohensee wrote: >> Zdenek Zambersky has updated the pull request incrementally with one additional commit since the last revision: >> >> DefaultUseWithClient.java: remove redundant comment line > > In DefaultUseWithClient, please remove line 41 (i.e., "// Skip this test on any other platform"the comment for the Windows client check) because it's redundant. Otherwise, looks fine. @phohensee @jerboaa thanks ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/286 From phh at openjdk.org Thu Mar 16 13:29:28 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 16 Mar 2023 13:29:28 GMT Subject: [jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode [v2] In-Reply-To: References: Message-ID: <7QsrW7nx4eprpjQ0OiZqf8E4Dhmfgd7VI9eoenqScXI=.1d79be79-de88-4e6b-a847-5ba7a499cd9e@github.com> On Thu, 16 Mar 2023 12:26:50 GMT, Zdenek Zambersky wrote: >> This is backport [1][2] which adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires` >> >> First commit is backport Itself. >> >> Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6]) >> These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested) >> >> Testing: >> Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works). >> >> [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 >> [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b >> [3] https://github.com/openjdk/jdk8u-dev/pull/222 >> [4] https://github.com/openjdk/jdk8u-dev/pull/182 >> [5] https://bugs.openjdk.org/browse/JDK-8154204 >> [6] https://github.com/openjdk/jdk8u-dev/pull/181 > > Zdenek Zambersky has updated the pull request incrementally with one additional commit since the last revision: > > DefaultUseWithClient.java: remove redundant comment line Marked as reviewed by phh (Reviewer). ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/286 From duke at openjdk.org Fri Mar 17 05:54:18 2023 From: duke at openjdk.org (Ravali Yatham) Date: Fri, 17 Mar 2023 05:54:18 GMT Subject: [jdk8u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Message-ID: Added specific class loader object to proxy IllegalArgumentException from which the class was not visible The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 ------------- Commit messages: - Backport?9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae Changes: https://git.openjdk.org/jdk8u-dev/pull/290/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=290&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302791 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/290.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev pull/290/head:pull/290 PR: https://git.openjdk.org/jdk8u-dev/pull/290 From duke at openjdk.org Fri Mar 17 06:18:34 2023 From: duke at openjdk.org (Ravali Yatham) Date: Fri, 17 Mar 2023 06:18:34 GMT Subject: [jdk8u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <3Dz3ZuQK2r0b5IszNzo4dNkBZHL4G7YkwLmnPW14K6I=.70958022-2cdd-4202-aa4e-4c27d1939036@github.com> On Fri, 17 Mar 2023 05:40:57 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 @mlchung @jerboaa - As in JDK 8 there is no getName() and nameAndId() functionalities, it would be helpful to have the ClassLoader string representation in the IllegalArgumentException message. Please kindly review this PR, Thanks! ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/290 From duke at openjdk.org Fri Mar 17 11:25:56 2023 From: duke at openjdk.org (Stewart X Addison) Date: Fri, 17 Mar 2023 11:25:56 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison > Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ > Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ > Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ Also verified with the tier 1 suites on [AIX](https://ci.adoptium.net/view/Test_openjdk/job/Test_openjdk8_hs_sanity.openjdk_ppc64_aix/638/), [linux/s390x](https://ci.adoptium.net/view/Test_openjdk/job/Test_openjdk8_hs_sanity.openjdk_s390x_linux/773/) and Solaris [x64](https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_solaris/223/) and [SPARC](https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_sparcv9_solaris/244/) with this patch on top of the jdk8u codebase which has an additional fix in. No new regressions introduced. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From phh at openjdk.org Fri Mar 17 12:28:19 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 17 Mar 2023 12:28:19 GMT Subject: [jdk8u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 05:40:57 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Completely different context and implementation from the original commit, but accomplishes the same thing. Lgtm. ------------- Marked as reviewed by phh (Reviewer). PR: https://git.openjdk.org/jdk8u-dev/pull/290 From duke at openjdk.org Fri Mar 17 14:08:37 2023 From: duke at openjdk.org (Ravali Yatham) Date: Fri, 17 Mar 2023 14:08:37 GMT Subject: [jdk8u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <5PYEa-7MXLhP3Qg4jHfTl1y3nbyxwpMfQoOVbp4Y2KM=.0fc7612b-6bae-4e1a-8ca2-8efde68fb205@github.com> On Fri, 17 Mar 2023 12:25:31 GMT, Paul Hohensee wrote: >> Added specific class loader object to proxy IllegalArgumentException from which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 >> >> OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 > > Completely different context and implementation from the original commit, but accomplishes the same thing. > > Lgtm. Thanks @phohensee for reviewing. Issued `integrate`, now is ready to be sponsored ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/290 From phh at openjdk.org Fri Mar 17 18:01:06 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 17 Mar 2023 18:01:06 GMT Subject: [jdk8u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <9iLrtcFr3sHO6sipnX5rXcE2CWHHpzFwhO0EK8S-LWU=.3f9f2ed8-23c8-4fc7-a39b-30e89843572a@github.com> On Fri, 17 Mar 2023 05:40:57 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 I tagged the issue with an approval request (added jdk8u-fix-request label), have to wait for a maintainer to approve before integrating. In the future, please wait until maintainer approval before adding "/integrate". ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/290 From duke at openjdk.org Mon Mar 20 04:40:26 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 20 Mar 2023 04:40:26 GMT Subject: [jdk8u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: On Fri, 17 Mar 2023 05:40:57 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 Sure, I'll make a note of it. Tagging maintainers(https://wiki.openjdk.org/display/jdk8u) @theRealAph @gnu-andrew @jerboaa for their approval. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/290 From sgehwolf at openjdk.org Tue Mar 21 09:41:56 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 21 Mar 2023 09:41:56 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison This looks OK. I've tagged the bug and let @gnu-andrew approve it. Once that's done feel free to integrate. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/277#pullrequestreview-1350024288 From zzambers at openjdk.org Tue Mar 21 11:34:55 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 21 Mar 2023 11:34:55 GMT Subject: [jdk8u-dev] Integrated: 8289301: P11Cipher should not throw out of bounds exception during padding In-Reply-To: <34U5wBJmzAgOIa0hNkfGU-gdviexXM7Xsl6QQoHUvcU=.2a59a8ed-0256-47d3-835b-c5c921566889@github.com> References: <34U5wBJmzAgOIa0hNkfGU-gdviexXM7Xsl6QQoHUvcU=.2a59a8ed-0256-47d3-835b-c5c921566889@github.com> Message-ID: On Wed, 15 Mar 2023 15:12:36 GMT, Zdenek Zambersky wrote: > Fix for possible OOB exception by P11Cipher. Backported from [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/commit/7d8991978bbe1cc03ba2386f5e699239ba47934c). > > Only really modified `@library` (fixed by removing unnecessary path.) > > Testing: > [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4427068905/jobs/7764159983) OK (new test passed, no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395) ) This pull request has now been integrated. Changeset: ae6405fe Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/ae6405fe642c8b5092c82ed22b41a281f49961b5 Stats: 124 lines in 2 files changed: 117 ins; 0 del; 7 mod 8289301: P11Cipher should not throw out of bounds exception during padding Reviewed-by: phh Backport-of: 7d8991978bbe1cc03ba2386f5e699239ba47934c ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/287 From zzambers at openjdk.org Tue Mar 21 11:34:56 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 21 Mar 2023 11:34:56 GMT Subject: [jdk8u-dev] Integrated: 8293232: Fix race condition in pkcs11 SessionManager In-Reply-To: References: Message-ID: On Wed, 15 Mar 2023 15:21:15 GMT, Zdenek Zambersky wrote: > Backport from [jdk11u-dev](https://github.com/openjdk/jdk11u-dev/commit/939741c0a0a4a5ce2c68d14b15e1f42563bc653d) - fix for race condition in pkcs11 SessionManager. > > Clean except for copyright date. > > Testing: > [jdk_security](https://github.com/zzambers/jdk-tester/actions/runs/4427088716/jobs/7764206204) OK (no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4407115132/jobs/7720330395)). This pull request has now been integrated. Changeset: ad41d908 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/ad41d908eb4655782eb85272d28ccad80fa648eb Stats: 7 lines in 1 file changed: 5 ins; 0 del; 2 mod 8293232: Fix race condition in pkcs11 SessionManager Backport-of: 939741c0a0a4a5ce2c68d14b15e1f42563bc653d ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/288 From zzambers at openjdk.org Tue Mar 21 11:35:46 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 21 Mar 2023 11:35:46 GMT Subject: [jdk8u-dev] Integrated: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode In-Reply-To: References: Message-ID: <6L_1zqc3cn7p8BvomWDVRoQoUTN_x5eA_tdk8A8RpmM=.fdb50855-db05-4a23-b615-bf9e295596a9@github.com> On Wed, 15 Mar 2023 14:57:06 GMT, Zdenek Zambersky wrote: > This is backport [1][2] which adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires` > > First commit is backport Itself. > > Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6]) > These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested) > > Testing: > Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works). > > [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 > [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b > [3] https://github.com/openjdk/jdk8u-dev/pull/222 > [4] https://github.com/openjdk/jdk8u-dev/pull/182 > [5] https://bugs.openjdk.org/browse/JDK-8154204 > [6] https://github.com/openjdk/jdk8u-dev/pull/181 This pull request has now been integrated. Changeset: de0e5a2d Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/de0e5a2dcb61d3827e38e56655f5263813bfcc0f Stats: 162 lines in 5 files changed: 145 ins; 15 del; 2 mod 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode Reviewed-by: phh, sgehwolf Backport-of: 24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/286 From iris.clark at oracle.com Wed Mar 22 16:34:07 2023 From: iris.clark at oracle.com (Iris Clark) Date: Wed, 22 Mar 2023 16:34:07 +0000 Subject: JSR 337 (Java SE 8) MR 5 and JSR 384 (Java SE 11) MR 2 posted to jcp.org Message-ID: Maintenance Review 5 of JSR 337 and Maintenance Review 2 of JSR 384 which include changes to support GB 18030-2022 [0,1] have been posted to jcp.org: https://jcp.org/en/jsr/detail?id=337 https://jcp.org/en/jsr/detail?id=384 The review periods end 19 Apr and the ballots begin shortly thereafter. Thanks, Iris [0]: https://mail.openjdk.org/pipermail/jdk8u-dev/2023-February/016710.html [1]: https://mail.openjdk.org/pipermail/jdk-updates-dev/2023-February/020724.html From duke at openjdk.org Thu Mar 23 23:09:39 2023 From: duke at openjdk.org (Stewart X Addison) Date: Thu, 23 Mar 2023 23:09:39 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Tue, 14 Mar 2023 16:23:39 GMT, Andrew John Hughes wrote: >> Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: >> >> Update line for zlib 1.2.13 >> >> Signed-off-by: Stewart X Addison > > I tend to agree it would be better to do this across all JDKs at the same time, but, as explained in e-mail, I'll let Severin have the final ok on this. > > If we do move it to 8u372, just close this PR and open the same changes against openjdk/jdk8u instead. @gnu-andrew Are you happy to add the fix yes tag to the bug for this to go into 8u382? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/277#issuecomment-1482025840 From dongbohe at openjdk.org Fri Mar 24 08:04:39 2023 From: dongbohe at openjdk.org (Dongbo He) Date: Fri, 24 Mar 2023 08:04:39 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching Message-ID: I would like to backport this patch to fix crash during C2 compilation. This patch doesn't apply cleanly due to context differences, and I selected fuzzer tests from Fei Yang because the tests in the original commit cannot be reproduced on JDK8u. Performed hotspot jtreg test on linux x86-64 platforms with -Xcomp options, new test fails without product change and passes with it. ------------- Commit messages: - Backport 50e3aa4150dc1dd18870c5725666188ab38ab7d5 Changes: https://git.openjdk.org/jdk8u-dev/pull/291/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=291&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8202952 Stats: 68 lines in 2 files changed: 68 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/291.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/291/head:pull/291 PR: https://git.openjdk.org/jdk8u-dev/pull/291 From roland at openjdk.org Fri Mar 24 13:50:41 2023 From: roland at openjdk.org (Roland Westrelin) Date: Fri, 24 Mar 2023 13:50:41 GMT Subject: [jdk8u-dev] RFR: 8202952: C2: Unexpected dead nodes after matching In-Reply-To: References: Message-ID: On Fri, 24 Mar 2023 07:57:45 GMT, Dongbo He wrote: > I would like to backport this patch to fix crash during C2 compilation. > > This patch doesn't apply cleanly due to context differences, and > I selected fuzzer tests from Fei Yang because the tests in the original commit cannot be reproduced on JDK8u. > > Performed hotspot jtreg test on linux x86-64 platforms with -Xcomp options, new test fails without product change and passes with it. Looks reasonable to me. ------------- Marked as reviewed by roland (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/291#pullrequestreview-1356740419 From duke at openjdk.org Mon Mar 27 11:27:45 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 27 Mar 2023 11:27:45 GMT Subject: [jdk8u-dev] RFR: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: <9iLrtcFr3sHO6sipnX5rXcE2CWHHpzFwhO0EK8S-LWU=.3f9f2ed8-23c8-4fc7-a39b-30e89843572a@github.com> References: <9iLrtcFr3sHO6sipnX5rXcE2CWHHpzFwhO0EK8S-LWU=.3f9f2ed8-23c8-4fc7-a39b-30e89843572a@github.com> Message-ID: On Fri, 17 Mar 2023 17:58:21 GMT, Paul Hohensee wrote: >> Added specific class loader object to proxy IllegalArgumentException from which the class was not visible >> >> The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 >> >> OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 > > I tagged the issue with an approval request (added jdk8u-fix-request label), have to wait for a maintainer to approve before integrating. In the future, please wait until maintainer approval before adding "/integrate". @phohensee - Noticed that the JBS issue has the approval tag `jdk8u-fix-yes`. Could you please sponsor if there isn't any pending action? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/290#issuecomment-1484973195 From andrew at openjdk.org Mon Mar 27 14:49:22 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 27 Mar 2023 14:49:22 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison Sorry for the delay in getting back to this, I was away last week. I'm happier with it being for 8u382 and will approve. Patch itself looks fine with the `THIRD_PARTY_README` changes now included. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/277#pullrequestreview-1359230945 From duke at openjdk.org Mon Mar 27 14:52:38 2023 From: duke at openjdk.org (Ravali Yatham) Date: Mon, 27 Mar 2023 14:52:38 GMT Subject: [jdk8u-dev] Integrated: 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message In-Reply-To: References: Message-ID: <3MYqEkoEgzQRHoAFOylqCiAobM0iDicEOQkhQrMCLKk=.c7ba6a8a-cbd2-4aaa-907e-a6fb254a359b@github.com> On Fri, 17 Mar 2023 05:40:57 GMT, Ravali Yatham wrote: > Added specific class loader object to proxy IllegalArgumentException from which the class was not visible > > The bug report for the same: https://bugs.openjdk.org/browse/JDK-8302791 > > OpenJDK PR: https://github.com/openjdk/jdk/pull/12641 This pull request has now been integrated. Changeset: ca1c3b1e Author: Ravali Yatham Committer: Paul Hohensee URL: https://git.openjdk.org/jdk8u-dev/commit/ca1c3b1efd8fbe0716e2e6e3b287856299e9ceef Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8302791: Add specific ClassLoader object to Proxy IllegalArgumentException message Reviewed-by: phh Backport-of: 9f9d678591e02ecaeae7b81eeefb0ba41c7b4dae ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/290 From andrew at openjdk.org Mon Mar 27 15:01:03 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 27 Mar 2023 15:01:03 GMT Subject: [jdk8u-dev] RFR: 8295530: Update Zlib Data Compression Library to Version 1.2.13 [v4] In-Reply-To: References: Message-ID: On Wed, 8 Mar 2023 12:40:59 GMT, Stewart X Addison wrote: >> As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. >> >> Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) >> As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. >> >> I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. >> >> - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ >> - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ >> - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ >> >> This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. > > Stewart X Addison has updated the pull request incrementally with one additional commit since the last revision: > > Update line for zlib 1.2.13 > > Signed-off-by: Stewart X Addison Sorry for the delay in getting back to this, I was away last week. I'm happier with it being for 8u382 and will approve. Patch itself looks fine with the `THIRD_PARTY_README` changes now included. Bug approved. If you want to do `/integrate`, myself or Severin can sponsor. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/277#pullrequestreview-1359257641 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/277#issuecomment-1485272396 From andrew at openjdk.org Mon Mar 27 15:11:11 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 27 Mar 2023 15:11:11 GMT Subject: [jdk8u-dev] RFR: 8263059: security/infra/java/security/cert/CertPathValidator/certification/ComodoCA.java fails due to revoked cert In-Reply-To: References: <9TtAd0bayt--BjbAoJ-qSnLtEu4SzgvPYZmhF6fFcS4=.019eae34-685f-47dc-81e3-d16697bacc3a@github.com> Message-ID: <0jGUrVrF44T1gr8B23yLUbS5ufa7BZDLNcKlf6u5fsc=.41c73984-b53f-40fa-9498-6a6f09473a18@github.com> On Tue, 14 Mar 2023 18:04:32 GMT, Severin Gehwolf wrote: > Looks good to me. Thanks. Flagged for approval. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/276#issuecomment-1485291029 From andrew at openjdk.org Mon Mar 27 15:13:48 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 27 Mar 2023 15:13:48 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 09:31:17 GMT, Severin Gehwolf wrote: > @quantum6 From the bug description it sounds like this is an issue in later JDKs as well, please fix it in the latest development tree first where it reproduces (possibly JDK 21 at https://github.com/openjdk/jdk/), Once a fix is in later JDKs, the fix can get backported. So in this case it would be something like: > > 1. Fix in JDK `XX` where `XX` is the latest JDK where this reproduces > > 2. Backport to older JDK `YY` where `YY` is `< 8` (LTS versions and latest STS seems sufficient). > > 3. Come back with a backport to 8 once 1 and 2 are done. > > > Thanks! Yes, as I also mentioned here: https://github.com/openjdk/jdk8u/pull/31#issuecomment-1453806230 The fix either needs to be resolved in the main JDK development tree first, or we need to know why an 8u only fix is needed (e.g. code has changed in later versions and bug is fixed by a change that can't be backported as is) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/281#issuecomment-1485299781 From andrew at openjdk.org Mon Mar 27 15:15:59 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Mon, 27 Mar 2023 15:15:59 GMT Subject: [jdk8u-dev] RFR: 8301631: [8u] Enable full builds for additional Linux builds [v2] In-Reply-To: References: Message-ID: On Mon, 6 Feb 2023 15:46:06 GMT, Andrew John Hughes wrote: >> Let's try to enable full builds for the additional (i.e. cross-compilation to s390x, aarch64, arm & ppc64le) builds, so the JDK native code gets built as well. > > Andrew John Hughes has updated the pull request incrementally with one additional commit since the last revision: > > Try without --disable-headful I'll have another look at this after the 8u372 release is out of the way. I'll likely include a workaround for the Ubuntu issue I've seen suggested so we don't hit that again in future. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/259#issuecomment-1485305892 From duke at openjdk.org Mon Mar 27 15:52:48 2023 From: duke at openjdk.org (Stewart X Addison) Date: Mon, 27 Mar 2023 15:52:48 GMT Subject: [jdk8u-dev] Integrated: 8295530: Update Zlib Data Compression Library to Version 1.2.13 In-Reply-To: References: Message-ID: <9pHLdTvBPB74LOMdGw5cYT_yT_0daLOn-ZTPJMe7ADU=.4eef3b0e-f49c-4f57-a51f-f1be432ab4a7@github.com> On Fri, 3 Mar 2023 19:20:01 GMT, Stewart X Addison wrote: > As per https://github.com/openjdk/jdk11u-dev/pull/1788 which backported this to 11. > > Backporting zlib 1.2.13 due to https://nvd.nist.gov/vuln/detail/CVE-2022-37434 (9.8 CVSS score) > As per the JDK11u change this makes the zlib directory in the source identical to the one for JDK17u so I do not anticipate any problems. > > I've run a test build on one Linux/mac/windows version and will run the same set of tier1 testing that I did on the 11 PR, plus some others. I'll probably try to run on some other platforms before requesting an integrate, but I'll also need a sponsor to add the appropriate tags to [JDK-8295530](https://bugs.openjdk.org/browse/JDK-8295530) so I'm opening this now. > > - Tier 1 (Linux/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_linux/1019/testReport/ > - Tier 1 (macOS/x64): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-64_mac/778/testReport/ > - Tier 1 (Windows/x32): https://ci.adoptium.net/job/Test_openjdk8_hs_sanity.openjdk_x86-32_windows/719/testReport/ > > This is the first time I've backported to 8 with skara - I'm assuming the process is now the same as 11. If not, please let me know and I will adjust accordingly. This pull request has now been integrated. Changeset: 5dc33f2c Author: Stewart X Addison Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/5dc33f2c9c4de56b76ee56a3526c2fa21394aea2 Stats: 11194 lines in 24 files changed: 9975 ins; 272 del; 947 mod 8295530: Update Zlib Data Compression Library to Version 1.2.13 Reviewed-by: andrew, sgehwolf Backport-of: 6042c6b9bbacbff1bd47f087f0f19646a20eef97 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/277 From duke at openjdk.org Mon Mar 27 23:49:36 2023 From: duke at openjdk.org (=?UTF-8?B?5p+z6bKy6bmP?=) Date: Mon, 27 Mar 2023 23:49:36 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: References: Message-ID: On Fri, 10 Mar 2023 00:51:37 GMT, ??? wrote: > JDK-8264728 : When use chinese IME, the candidate box isn't moved with caret of JTextArea > Type: Bug > Component: client-libs > Sub-Component: java.awt:i18n > Affected Version: 8,9,15,16 > Priority: P3 > Status: Open > Resolution: Unresolved > OS: linux > CPU: x86_64 > Yes, as I also mentioned here: [openjdk/jdk8u#31 (comment)](https://github.com/openjdk/jdk8u/pull/31#issuecomment-1453806230) > > The fix either needs to be resolved in the main JDK development tree first, or we need to know why an 8u only fix is needed (e.g. code has changed in later versions and bug is fixed by a change that can't be backported as is) All jdk versions have this problem. I fixed it on jdk8u (for TSIT Office). I had created a PR on jdk, I hope it can be integrated ASAP. Thanks. https://github.com/openjdk/jdk/pull/13055 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/281#issuecomment-1486005659 From duke at openjdk.org Mon Mar 27 23:52:35 2023 From: duke at openjdk.org (=?UTF-8?B?5p+z6bKy6bmP?=) Date: Mon, 27 Mar 2023 23:52:35 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: References: Message-ID: <6bAapebDBZGCetqyutj7oQoouqrbasZ3x1vPKEVEPng=.4c7f07fc-1354-41b3-b9c7-eaa95f5826c6@github.com> On Mon, 27 Mar 2023 23:46:30 GMT, ??? wrote: > Yes, as I also mentioned here: [openjdk/jdk8u#31 (comment)](https://github.com/openjdk/jdk8u/pull/31#issuecomment-1453806230) > > The fix either needs to be resolved in the main JDK development tree first, or we need to know why an 8u only fix is needed (e.g. code has changed in later versions and bug is fixed by a change that can't be backported as is) All jdk versions have this problem. I fixed it on jdk8u (for TSIT Office). I had created a PR on jdk, I hope it can be integrated ASAP. Thanks. https://github.com/openjdk/jdk/pull/13055 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/281#issuecomment-1486007676 From gnu.andrew at redhat.com Tue Mar 28 01:34:46 2023 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Tue, 28 Mar 2023 02:34:46 +0100 Subject: [FREEZE] 8u372 NOW FROZEN Message-ID: The release tree: https://github.com/openjdk/jdk8u is now frozen in preparation for release on or after 2023-04-18. The final pre-release tag is jdk8u372-b06 [0]. The final release tag will be no lower than jdk8u372-b07. [0] https://github.com/openjdk/jdk8u/releases/tag/jdk8u372-b06 -- Andrew :) Pronouns: he / him or they / them Senior Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Tue Mar 28 01:52:39 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 28 Mar 2023 01:52:39 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master Message-ID: <09YHdvn2DyA2ijPykiEoGKUyBt3IUjfonBzJV1AabEQ=.10da1acc-80b0-4a00-9ec1-7e8441aa242d@github.com> Bring in jdk8u372-b06 ------------- Commit messages: - Merge jdk8u372-b06 - 8304053: Revert os specific stubs for SystemMetrics - 8303828: [Solaris] Broken jdk8u build after JDK-8266391 The merge commit only contains trivial merges, so no merge-specific webrevs have been generated. Changes: https://git.openjdk.org/jdk8u-dev/pull/292/files Stats: 67 lines in 4 files changed: 4 ins; 62 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/292.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/292/head:pull/292 PR: https://git.openjdk.org/jdk8u-dev/pull/292 From sgehwolf at openjdk.org Tue Mar 28 09:25:40 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 28 Mar 2023 09:25:40 GMT Subject: [jdk8u-dev] RFR: Merge jdk8u:master In-Reply-To: <09YHdvn2DyA2ijPykiEoGKUyBt3IUjfonBzJV1AabEQ=.10da1acc-80b0-4a00-9ec1-7e8441aa242d@github.com> References: <09YHdvn2DyA2ijPykiEoGKUyBt3IUjfonBzJV1AabEQ=.10da1acc-80b0-4a00-9ec1-7e8441aa242d@github.com> Message-ID: On Tue, 28 Mar 2023 01:47:35 GMT, Andrew John Hughes wrote: > Bring in jdk8u372-b06 Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/292#pullrequestreview-1360600625 From andrew at openjdk.org Tue Mar 28 18:27:44 2023 From: andrew at openjdk.org (Andrew John Hughes) Date: Tue, 28 Mar 2023 18:27:44 GMT Subject: [jdk8u-dev] Integrated: Merge jdk8u:master In-Reply-To: <09YHdvn2DyA2ijPykiEoGKUyBt3IUjfonBzJV1AabEQ=.10da1acc-80b0-4a00-9ec1-7e8441aa242d@github.com> References: <09YHdvn2DyA2ijPykiEoGKUyBt3IUjfonBzJV1AabEQ=.10da1acc-80b0-4a00-9ec1-7e8441aa242d@github.com> Message-ID: On Tue, 28 Mar 2023 01:47:35 GMT, Andrew John Hughes wrote: > Bring in jdk8u372-b06 This pull request has now been integrated. Changeset: cd40350f Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/cd40350f0e69faf4d9a4658408798eb6e389f573 Stats: 67 lines in 4 files changed: 4 ins; 62 del; 1 mod Merge Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/292 From zzambers at openjdk.org Tue Mar 28 19:19:38 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 28 Mar 2023 19:19:38 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: References: Message-ID: On Mon, 27 Mar 2023 15:10:42 GMT, Andrew John Hughes wrote: > 2. Backport to older JDK `YY` where `YY` is `< 8` (LTS versions and latest STS seems sufficient). shouldn't ther be: `YY` is `>8` ? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/281#issuecomment-1487471633 From zzambers at openjdk.org Tue Mar 28 19:38:39 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Tue, 28 Mar 2023 19:38:39 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: <6bAapebDBZGCetqyutj7oQoouqrbasZ3x1vPKEVEPng=.4c7f07fc-1354-41b3-b9c7-eaa95f5826c6@github.com> References: <6bAapebDBZGCetqyutj7oQoouqrbasZ3x1vPKEVEPng=.4c7f07fc-1354-41b3-b9c7-eaa95f5826c6@github.com> Message-ID: On Mon, 27 Mar 2023 23:49:32 GMT, ??? wrote: >>> Yes, as I also mentioned here: [openjdk/jdk8u#31 (comment)](https://github.com/openjdk/jdk8u/pull/31#issuecomment-1453806230) >>> >>> The fix either needs to be resolved in the main JDK development tree first, or we need to know why an 8u only fix is needed (e.g. code has changed in later versions and bug is fixed by a change that can't be backported as is) >> >> All jdk versions have this problem. Many people are confused by it. I fixed it on jdk8u (for Taishan Office). I had created a PR on jdk and I hope it can be integrated ASAP. Then I will commit to other versions. >> Thanks. >> >> https://github.com/openjdk/jdk/pull/13055 > >> Yes, as I also mentioned here: [openjdk/jdk8u#31 (comment)](https://github.com/openjdk/jdk8u/pull/31#issuecomment-1453806230) >> >> The fix either needs to be resolved in the main JDK development tree first, or we need to know why an 8u only fix is needed (e.g. code has changed in later versions and bug is fixed by a change that can't be backported as is) > > All jdk versions have this problem. I fixed it on jdk8u (for TSIT Office). I had created a PR on jdk, I hope it can be integrated ASAP. > Thanks. > > https://github.com/openjdk/jdk/pull/13055 @quantum6 If all jdks are affected, it currently basically means, that you should first fix it in `jdk`, then gradually backport it to `jdk17u-dev`, `jdk11u-dev` and `jdk8u-dev`. (In that order; because 17,11,8 are current LTS versions) (@jerboaa please correct me if I am wrong) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/281#issuecomment-1487489598 From duke at openjdk.org Tue Mar 28 23:22:35 2023 From: duke at openjdk.org (=?UTF-8?B?5p+z6bKy6bmP?=) Date: Tue, 28 Mar 2023 23:22:35 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: <6bAapebDBZGCetqyutj7oQoouqrbasZ3x1vPKEVEPng=.4c7f07fc-1354-41b3-b9c7-eaa95f5826c6@github.com> References: <6bAapebDBZGCetqyutj7oQoouqrbasZ3x1vPKEVEPng=.4c7f07fc-1354-41b3-b9c7-eaa95f5826c6@github.com> Message-ID: On Mon, 27 Mar 2023 23:49:32 GMT, ??? wrote: >>> Yes, as I also mentioned here: [openjdk/jdk8u#31 (comment)](https://github.com/openjdk/jdk8u/pull/31#issuecomment-1453806230) >>> >>> The fix either needs to be resolved in the main JDK development tree first, or we need to know why an 8u only fix is needed (e.g. code has changed in later versions and bug is fixed by a change that can't be backported as is) >> >> All jdk versions have this problem. Many people are confused by it. I fixed it on jdk8u (for Taishan Office). I had created a PR on jdk and I hope it can be integrated ASAP. Then I will commit to other versions. >> Thanks. >> >> https://github.com/openjdk/jdk/pull/13055 > >> Yes, as I also mentioned here: [openjdk/jdk8u#31 (comment)](https://github.com/openjdk/jdk8u/pull/31#issuecomment-1453806230) >> >> The fix either needs to be resolved in the main JDK development tree first, or we need to know why an 8u only fix is needed (e.g. code has changed in later versions and bug is fixed by a change that can't be backported as is) > > All jdk versions have this problem. I fixed it on jdk8u (for TSIT Office). I had created a PR on jdk, I hope it can be integrated ASAP. > Thanks. > > https://github.com/openjdk/jdk/pull/13055 > @quantum6 If all jdks are affected, it currently basically means, that you should first fix it in `jdk`, then gradually backport it to `jdk17u-dev`, `jdk11u-dev` and `jdk8u-dev`. (In that order; because 17,11,8 are current LTS versions) OK. I hope the PR can be processed ASAP. Thanks. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/281#issuecomment-1487728389 From sgehwolf at openjdk.org Wed Mar 29 08:41:15 2023 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 29 Mar 2023 08:41:15 GMT Subject: [jdk8u-dev] RFR: 8264728: When use chinese IME, the candidate box isn't moved with caret of JTextArea In-Reply-To: References: Message-ID: On Tue, 28 Mar 2023 19:17:17 GMT, Zdenek Zambersky wrote: > > ``` > > 2. Backport to older JDK `YY` where `YY` is `< 8` (LTS versions and latest STS seems sufficient). > > ``` > > shouldn't there be: `YY` is `>8` ? Correct. Updated the comment. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/281#issuecomment-1488170478 From jzhu at openjdk.org Wed Mar 29 09:59:54 2023 From: jzhu at openjdk.org (Joshua Zhu) Date: Wed, 29 Mar 2023 09:59:54 GMT Subject: [jdk8u-dev] RFR: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue Message-ID: Various Crashes in JvmtiExport::post_compiled_method_load were found in our production environment after users started to receive the JVMTI COMPILED_METHOD_LOAD event. ServiceThread::nmethods_do should have been called to keep nmethods from being zombied while in the JvmtiDeferredEventQueue, but JavaThead::nmethods_do is called at present. Make a virtual function call to the correct method to fix this issue. With the fix, various crashes were gone. This issue only exists in 8u. ------------- Commit messages: - 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue Changes: https://git.openjdk.org/jdk8u-dev/pull/293/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=293&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305165 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/293.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/293/head:pull/293 PR: https://git.openjdk.org/jdk8u-dev/pull/293 From phh at openjdk.org Thu Mar 30 15:56:51 2023 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 30 Mar 2023 15:56:51 GMT Subject: [jdk8u-dev] RFR: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue In-Reply-To: References: Message-ID: On Wed, 29 Mar 2023 09:54:09 GMT, Joshua Zhu wrote: > Various Crashes in JvmtiExport::post_compiled_method_load were found in > our production environment after users started to receive the JVMTI > COMPILED_METHOD_LOAD event. > ServiceThread::nmethods_do should have been called to keep nmethods from > being zombied while in the JvmtiDeferredEventQueue, but > JavaThead::nmethods_do is called at present. > Make a virtual function call to the correct method to fix this issue. > With the fix, various crashes were gone. > This issue only exists in 8u. Could you also add 'virtual' to the nmethods_do declaration in JavaThread? Not strictly necessary, but good code hygiene. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/293#pullrequestreview-1365442713 From zzambers at openjdk.org Thu Mar 30 21:20:45 2023 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Thu, 30 Mar 2023 21:20:45 GMT Subject: [jdk8u-dev] RFR: 8305329: [8u] Unify test libraries into single test library - step 1 Message-ID: <-myNqW_fw3D6SHLG0l05BA4m1w6zFs9TvCgvHSrAzzk=.222f6ecc-c89b-4d56-99d9-c66fda765078@github.com> I would like to start effort to unify test libraries in openjdk 8 into one unified library. This is first step of that effort, which moves newest copy of jdk test library (added with jfr backport) from `jdk/test/lib` to `test/lib`. For more details please continue reading. **Problem:** Test libraries in jdk8 are a bit messy. There are currently 3 different test libraries: - hotspot testlibrary - placed in [hotspot/test/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary), (pkgs `com.oracle.java.testlibrary`, `sun.hotspot...` ), includes testlibrary tests in [hotspot/test/testlibrary_tests](https://github.com/openjdk/jdk8u-dev/tree/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary_tests) - jdk testlibrary (old) - placed in [jdk/test/lib/testlibrary](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib/testlibrary), (pkgs `jdk.testlibrary`, `com.oracle.testlibrary.jsr292`) - jdk test lib - placed directly in [jdk/test/lib](https://github.com/openjdk/jdk8u-dev/tree/master/jdk/test/lib), was added with [jfr backport](https://github.com/openjdk/jdk8u-dev/commit/df7e09043392d5952d522a28702c6e5ec3e8492e), (pkgs `jdk.test.lib` `sun.hotspot...`) Many test library classes exist in multiple different copies (using different pkgs). Few examples: - Platform.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/Platform.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/Platform.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/Platform.java)) - OutputAnalyzer.java - 3 copies ([hs](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/com/oracle/java/testlibrary/OutputAnalyzer.java), [jdk (old)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/testlibrary/jdk/testlibrary/OutputAnalyzer.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/jdk/test/lib/process/OutputAnalyzer.java)) - WhiteBox.java - 2 copies ([hotspot](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/hotspot/test/testlibrary/whitebox/sun/hotspot/WhiteBox.java), [jdk (jfr)](https://github.com/openjdk/jdk8u-dev/blob/master/jdk/test/lib/sun/hotspot/WhiteBox.java)) Few additional observations: - classes in jdk test lib (jfr) use java packages compatible with newer jdks, other 2 don't (other 2 are actually not even compatible with each other) - test lib added with jfr has newest classes, but some of them are NOT JDK8 compatible, some of them do not even compile on 8 (see e.g. [SecurityTools.java](https://github.com/openjdk/jdk8u-dev/blob/cd40350f0e69faf4d9a4658408798eb6e389f573/jdk/test/lib/jdk/test/lib/SecurityTools.java#L86), [InMemoryJavaCompiler.java](https://github.com/openjdk/jdk8u-dev/blob/cd40350f0e69faf4d9a4658408798eb6e389f573/jdk/test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java#L146) ...) , some whitebox stuff in `sun.hotspot` also seem incompatible with 8 (e.g. [NMethod.java](https://github.com/openjdk/jdk8u-dev/blob/89aeae16e85ddfbd581cb86d0b0480b1e2d50e99/jdk/test/lib/sun/hotspot/code/NMethod.java#L37) (compare to [NMethod.java](https://github.com/openjdk/jdk8u-dev/blob/cd40350f0e69faf4d9a4658408798eb6e389f573/hotspot/test/testlibrary/whitebox/sun/hotspot/code/NMethod.java#L37) from hs)) - most jdk tests (with exception of jfr ones) use old testlibrary, but few tests already started using test lib added with jfr - paths to test lib as specified `@library` jtreg tag is different from newer jdks (for all 3 test libraries) This situation complicates backporting and leads to confusion. (What is correct library path? What package test lib classes use? Which library to use and to which one do backports? Which part are broken and why? etc...) See some examples: https://github.com/openjdk/jdk8u-dev/pull/129 https://github.com/openjdk/jdk8u-dev/pull/255#issuecomment-1412522724 **Solution:** Proposed solution is to have single test library placed in `test/lib` directory (+ test library tests in `test/lib-test`) by fixing/merging test libraries. (same locations are used in newer [jdks](https://github.com/openjdk/jdk17u-dev/tree/master/test/lib)) Goal is following: - single test library, removed code duplication - all test lib classes compatible with JDK8 - locations of test lib files and java packages (used by test library classes) same as in later jdks - path as specified by `@library` jtreg tag compatible with later jdks (`@library /test/lib`) - only test lib is moved. Tests and `TEST.ROOT` files are not moved, so this should not break existing CIs. Because this is big change it should be performed in steps: 1. move jdk test library added by jfr to `test/lib` and do necessary modifications to tests (add `external.lib.roots` to `TEST.ROOT` files, modify `@library` tag of affected test) 2. Fix test lib in new location to work with hotspot tests (fix/merge with hotspot testlibrary), modify hotpot tests to use it, remove hotspot testlibrary 3. continue with jdk tests, doing more fixes to test lib, if necessary (fix/merge with jdk testlibrary), eventually migrating all tests and removing jdk testlibrary (old) **Changes in this PR:** This is just the first step and consist of: - moved test lib classes `jdk/test/lib` -> `test/lib` (excluding `testlibrary`, `security` dirs belonging to the old jdk testlibrary) - added appropriate `external.lib.roots` to `TEST.ROOT` files of jdk and hotspot - modified affected tests to use moved library (just modifications of `@library`, with excpetion of `TestNative.sh`) **Testing:** tier1: passed (see Checks) jdk_core: [OK](https://github.com/zzambers/jdk-tester/actions/runs/4481657956/jobs/8053572622) (basically jdk tier1+tier2,no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/4481634969/jobs/7878603557)) jdk_jfr: [OK](https://github.com/zzambers/jdk-tester/actions/runs/4481322671/jobs/8053582402) (no regressions to [master](https://github.com/zzambers/jdk-tester/actions/runs/3997510473/jobs/6858945097)) ------------- Commit messages: - Moved test lib Changes: https://git.openjdk.org/jdk8u-dev/pull/294/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=294&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305329 Stats: 486 lines in 608 files changed: 8 ins; 12 del; 466 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/294.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/294/head:pull/294 PR: https://git.openjdk.org/jdk8u-dev/pull/294 From jzhu at openjdk.org Fri Mar 31 07:01:06 2023 From: jzhu at openjdk.org (Joshua Zhu) Date: Fri, 31 Mar 2023 07:01:06 GMT Subject: [jdk8u-dev] RFR: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue [v2] In-Reply-To: References: Message-ID: > Various Crashes in JvmtiExport::post_compiled_method_load were found in > our production environment after users started to receive the JVMTI > COMPILED_METHOD_LOAD event. > ServiceThread::nmethods_do should have been called to keep nmethods from > being zombied while in the JvmtiDeferredEventQueue, but > JavaThead::nmethods_do is called at present. > Make a virtual function call to the correct method to fix this issue. > With the fix, various crashes were gone. > This issue only exists in 8u. Joshua Zhu has updated the pull request incrementally with one additional commit since the last revision: Add 'virtual' in oops_do and nmethods_do declaration in JavaThread ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/293/files - new: https://git.openjdk.org/jdk8u-dev/pull/293/files/0c7e5a17..c3b83151 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=293&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=293&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/293.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/293/head:pull/293 PR: https://git.openjdk.org/jdk8u-dev/pull/293 From jzhu at openjdk.org Fri Mar 31 07:01:08 2023 From: jzhu at openjdk.org (Joshua Zhu) Date: Fri, 31 Mar 2023 07:01:08 GMT Subject: [jdk8u-dev] RFR: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue [v2] In-Reply-To: References: Message-ID: <31W4aKLdT_3z9VMcwhf7qVi0lFWiik4QTX-pUhV8L_c=.d47b3483-fff8-461e-959a-28e6ca0e129e@github.com> On Thu, 30 Mar 2023 15:53:49 GMT, Paul Hohensee wrote: > Could you also add 'virtual' to the nmethods_do declaration in JavaThread? Not strictly necessary, but good code hygiene. Done. Thanks for your review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/293#issuecomment-1491405790 From phh at openjdk.org Fri Mar 31 13:24:27 2023 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 31 Mar 2023 13:24:27 GMT Subject: [jdk8u-dev] RFR: 8305165: [8u] ServiceThread::nmethods_do is not called to keep nmethods from being zombied while in the queue [v2] In-Reply-To: References: Message-ID: On Fri, 31 Mar 2023 07:01:06 GMT, Joshua Zhu wrote: >> Various Crashes in JvmtiExport::post_compiled_method_load were found in >> our production environment after users started to receive the JVMTI >> COMPILED_METHOD_LOAD event. >> ServiceThread::nmethods_do should have been called to keep nmethods from >> being zombied while in the JvmtiDeferredEventQueue, but >> JavaThead::nmethods_do is called at present. >> Make a virtual function call to the correct method to fix this issue. >> With the fix, various crashes were gone. >> This issue only exists in 8u. > > Joshua Zhu has updated the pull request incrementally with one additional commit since the last revision: > > Add 'virtual' in oops_do and nmethods_do declaration in JavaThread Looks good. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/293#pullrequestreview-1366931699 From alexsch at openjdk.org Fri Mar 31 15:15:25 2023 From: alexsch at openjdk.org (Alexander Scherbatiy) Date: Fri, 31 Mar 2023 15:15:25 GMT Subject: [jdk8u-dev] RFR: 8276841: Add support for Visual Studio 2022 Message-ID: This is a backport of the fix from jdk11u-dev repository: https://github.com/openjdk/jdk11u-dev/commit/0ba5a81e7c0117855665a28a43f9589635e94222 The fix is manually merged with jdk8u-dev because it has conflicts in lines before the fix: jdk11u-dev: `VALID_VS_VERSIONS="2017 2019 2013 2015 2012 2010"` jdk8u-dev: `VALID_VS_VERSIONS="2010 2012 2013 2015 2017 2019"` The conflict is resolved so `2022` year is placed after `2019` in jdk8u-dev. The other part is backported as is into jdk8u-dev. The `generated-configure.sh` file is updated as well. To test the fix the jdk8u-dev was built on Windows Server 2012 R2 with: * Toolchain: microsoft (Microsoft Visual Studio 2022 17.5.2 (devkit)) * C Compiler: Version 19.31.31107 (at /cygdrive/c/cygwin64/VS2022-17.5.2-devkit/VC/bin/x64/cl) * C++ Compiler: Version 19.31.31107 (at /cygdrive/c/cygwin64/VS2022-17.5.2-devkit/VC/bin/x64/cl) and hotspot and compact3 tests were run. There were only 3 new failed tests comparing to the build without the fix. ``` jdk/internal/platform/cgroup/TestCgroupMetrics.java.TestCgroupMetrics jdk/internal/platform/docker/TestDockerMemoryMetrics.java.TestDockerMemoryMetrics jdk/internal/platform/docker/TestSystemMetrics.java.TestSystemMetrics The first test passes after the second run. It is also possible to update the second and the third tests so they pass as well. It looks like the tests failing does not really relate to the current fix. ------------- Commit messages: - 8276841: Add support for Visual Studio 2022 Changes: https://git.openjdk.org/jdk8u-dev/pull/295/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=295&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8276841 Stats: 32 lines in 2 files changed: 30 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/295.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/295/head:pull/295 PR: https://git.openjdk.org/jdk8u-dev/pull/295