[jdk8u] RFR: 8304143: Exclude duplicated class on linux, aix, and macos [v2]
Severin Gehwolf
sgehwolf at openjdk.org
Tue Mar 14 16:03:07 UTC 2023
On Tue, 14 Mar 2023 15:42:20 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:
> Ok, this just changed while I was looking at it :)
Indeed. Sorry about that.
> I think the current version incorporates #39 now, so we just need this one?
Yes, lets' just use this one and https://bugs.openjdk.org/browse/JDK-8304053 as the associated bug to integrate.
> This seems to relate to what I was referring to in [my comment](https://bugs.openjdk.org/browse/JDK-8303828?focusedCommentId=14565610&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14565610) on the bug about 11u. 11u uses `src/unix` for the generic versions and platform-specific overrides. On 8u, `src/solaris` is that generic version unless we opt out.
Yep.
> So I would also remove the unused `unix` copy of the file here, assuming builds aren't broken, and refer to both bug IDs.
Sounds good. The `unix` [copy](https://github.com/openjdk/jdk8u/blob/ebbd3a87b0c473a744499d5f7691e5207cd73186/jdk/src/unix/classes/jdk/internal/platform/SystemMetrics.java) doesn't do anything in 8u. @adamfarley Could you please do that?
-------------
PR: https://git.openjdk.org/jdk8u/pull/40
More information about the jdk8u-dev
mailing list