[jdk8u] RFR: 8304053: Revert os specific stubs for SystemMetrics [v2]

Adam Farley afarley at openjdk.org
Tue Mar 14 16:19:39 UTC 2023


On Tue, 14 Mar 2023 16:12:09 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Adam Farley has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   8304143: Fix duplicated class build error on linux, aix, and macos
>>   
>>   This change ensures that each of the affected platforms only uses
>>   one copy of the SystemMetrics class. Either the stub version, or
>>   a platform-specific version.
>>   
>>   Signed-off-by: Adam Farley <adfarley at redhat.com>
>
> jdk/make/CompileJavaClasses.gmk line 310:
> 
>> 308: ifeq ($(OPENJDK_TARGET_OS),linux)
>> 309:      LINUX_SRC_DIRS += $(JDK_TOPDIR)/src/linux/classes
>> 310:      EXFILES += $(JDK_TOPDIR)/src/solaris/classes/jdk/internal/platform/SystemMetrics.java
> 
> Please add a comment above this line like this:
> 
> # Linux is the only OS with an actual implementation of SystemMetrics.
> # Exclude the generic null-returning stub from solaris/classes for that reason.

Sure. 1 moment.

-------------

PR: https://git.openjdk.org/jdk8u/pull/40


More information about the jdk8u-dev mailing list