[jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode
Severin Gehwolf
sgehwolf at openjdk.org
Thu Mar 16 10:49:25 UTC 2023
On Wed, 15 Mar 2023 14:57:06 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:
> This is backport [1][2] which adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires`
>
> First commit is backport Itself.
>
> Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6])
> These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested)
>
> Testing:
> Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works).
>
> [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89
> [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b
> [3] https://github.com/openjdk/jdk8u-dev/pull/222
> [4] https://github.com/openjdk/jdk8u-dev/pull/182
> [5] https://bugs.openjdk.org/browse/JDK-8154204
> [6] https://github.com/openjdk/jdk8u-dev/pull/181
This is supported with JTREG 4.1+. We use [jtreg 5.1](https://github.com/openjdk/jdk8u-dev/blob/d6f8151053f40ccd8c23b9f9eecb40c306a6253f/make/conf/test-dependencies#L29) minimum. So this seems fine (with changes suggested by Paul).
-------------
Marked as reviewed by sgehwolf (Reviewer).
PR: https://git.openjdk.org/jdk8u-dev/pull/286
More information about the jdk8u-dev
mailing list