[jdk8u-dev] RFR: 8152432: Implement setting jtreg @requires properties vm.flavor, vm.bits, vm.compMode [v2]
Paul Hohensee
phh at openjdk.org
Thu Mar 16 13:29:28 UTC 2023
On Thu, 16 Mar 2023 12:26:50 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:
>> This is backport [1][2] which adds support for jtreg vm properties (`vm.flavor`, `vm.compMode`, `vm.bits`) for use in `@requires`
>>
>> First commit is backport Itself.
>>
>> Second commit switches some tests back to use `@requires` (2 are basically reverts [3][4] of jdk8u specific changes, 3rd updated test is not present in newer jdks [5][6])
>> These updated tests were used to test new properties, so I included them here. (However I can exclude them if requested)
>>
>> Testing:
>> Updated tests are part of hotspot tier1, which is executed in GitHub (Which confirms it works).
>>
>> [1] https://github.com/openjdk/jdk9u/commit/24a9e0ac188a37dc57cc4d1bb8d8635abb4c4f89
>> [2] https://github.com/openjdk/jdk9u/commit/2b7a70a9d3d9b4ca94605d22d3d4f3c78a5c8d8b
>> [3] https://github.com/openjdk/jdk8u-dev/pull/222
>> [4] https://github.com/openjdk/jdk8u-dev/pull/182
>> [5] https://bugs.openjdk.org/browse/JDK-8154204
>> [6] https://github.com/openjdk/jdk8u-dev/pull/181
>
> Zdenek Zambersky has updated the pull request incrementally with one additional commit since the last revision:
>
> DefaultUseWithClient.java: remove redundant comment line
Marked as reviewed by phh (Reviewer).
-------------
PR: https://git.openjdk.org/jdk8u-dev/pull/286
More information about the jdk8u-dev
mailing list