[jdk8u-dev] RFR: 8305329: [8u] Unify test libraries into single test library - step 1 [v2]

[Andrew John Hughes]

On Tue, 15 Aug 2023 18:35:33 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> I have removed lib classes, which do not compile on jdk 8 (and ones depending on them). Retested -> OK.

This looks good. All seem to have been added by the JFR backport. While some are unique and only used by that (`LingeredApp.java`, `LingeredAppWithDeadlock.java`, `ModuleInfoMaker.java`), the rest seem to be duplicated by (presumably working) versions in the hotspot and jdk libraries.

~~~
$ find -name RedefineClassHelper.java
./hotspot/test/testlibrary/RedefineClassHelper.java
./jdk/test/lib/RedefineClassHelper.java

$ find -name CompilerUtils.java
./jdk/test/lib/jdk/test/lib/compiler/CompilerUtils.java
./jdk/test/lib/testlibrary/CompilerUtils.java

$ find -name InMemoryJavaCompiler.java
./hotspot/test/testlibrary/com/oracle/java/testlibrary/InMemoryJavaCompiler.java
./jdk/test/lib/jdk/test/lib/compiler/InMemoryJavaCompiler.java
./jdk/test/lib/testlibrary/jdk/testlibrary/InMemoryJavaCompiler.java

$ find -name JarUtils.java
./jdk/test/lib/jdk/test/lib/util/JarUtils.java
./jdk/test/lib/testlibrary/jdk/testlibrary/JarUtils.java

$ find -name SecurityTools.java
./jdk/test/lib/jdk/test/lib/SecurityTools.java
./jdk/test/lib/testlibrary/jdk/testlibrary/SecurityTools.java
~~~

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/294#issuecomment-1791470098