[jdk8u-dev] RFR: 8305329: [8u] Unify test libraries into single test library - step 1

Andrew John Hughes andrew at openjdk.org
Thu Nov 2 20:12:21 UTC 2023


On Mon, 14 Aug 2023 14:35:32 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> > I think we should also probably have a step 4 to actually move the tests. That will then solve the backporting problem where tests keep being introduced in the wrong location.
> 
> Even though, it would be good for backporting, I have so far excluded tests themselfs from move, as there are some additional difficulties with that. While changing test library location can be done more or less transparently, in case of tests there are some complications:
> 
>     * It would be more invasive change needing changes to build system (makefiles)
> 
>     * It would break existing CI testing (would require changes), in cases, where jtreg is being called directly, rater than through main makefile, (e.g. Adoptium aqa-tests, see: [openjdk.mk](https://github.com/adoptium/aqa-tests/blob/07cac1895144ecb63a2ad03c3214a52fb108cfbc/openjdk/openjdk.mk#L122) [playlist.xml](https://github.com/adoptium/aqa-tests/blob/07cac1895144ecb63a2ad03c3214a52fb108cfbc/openjdk/playlist.xml#L717).)

I know what you mean, and it is what has put me off doing this earlier. We can see how things look once the library work is done, but I think it would actually help remove a lot of special casing for 8u long term.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/294#issuecomment-1791471409


More information about the jdk8u-dev mailing list