[jdk8u-dev] RFR: JDK-8319405: [s390] [jdk8] Increase javac default stack size for s390x zero
Thomas Stuefe
stuefe at openjdk.org
Wed Nov 8 11:10:12 UTC 2023
On Wed, 8 Nov 2023 10:01:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:
>> This is a JDK8 - only patch to fix failing TCK tests for javac on s390.
>>
>> s390x, by default, needs a lot of stack space for C++ frames since the s390x ABI requires a 160-byte register save area per frame. That affects JDK 8 in particular since we run Zero, and the C++ interpreter builds up C-frames for Java frames; furthermore, it affects javac since it recurses a lot.
>>
>> This causes several javac TCK tests to fail with SOE (stmt33002mxxx).
>>
>> To pass TCK, the default stack size of javac should be increased for s390 on JDK 8.
>>
>> Testing:
>>
>> - manually tested on s390 to see if the issue was resolved, which it was.
>> - manually tested on x64 to check that nothing changed
>> - GHAs
>
> Looks good.
Thanks @jerboaa !
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/385#issuecomment-1801659963
More information about the jdk8u-dev
mailing list