[jdk8u-dev] RFR: 8176509: Use pandoc for converting build readme to html

Zdenek Zambersky zzambers at openjdk.org
Tue Nov 14 11:41:44 UTC 2023


On Mon, 13 Nov 2023 22:53:32 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>>> Looks good to me. 8u build requirements seem to have been retained as is and I think moving the file to the final place here is the right thing to do.
>> 
>> Yy, pandoc should be optional, it builds without it in GHA.
>> 
>> Unfortunately there is little additional noise in `generated-configure.sh`'s diff concerning `--runstatedir` option, even though, I have used same version of autofonf, as was used before (2.69). It boils down to whether autoconf is ran on distro which has [specific backport](https://bugzilla.redhat.com/show_bug.cgi?id=1831941#c6). (Not present on rhel-8 I used) But I don't think this affects OpenJDK in any way.
>
>> > Looks good to me. 8u build requirements seem to have been retained as is and I think moving the file to the final place here is the right thing to do.
>> 
>> Yy, pandoc should be optional, it builds without it in GHA.
>> 
>> Unfortunately there is little additional noise in `generated-configure.sh`'s diff concerning `--runstatedir` option, even though, I have used same version of autofonf, as was used before (2.69). It boils down to whether autoconf is ran on distro which has [specific backport](https://bugzilla.redhat.com/show_bug.cgi?id=1831941#c6). (Not present on rhel-8 I used) But I don't think this affects OpenJDK in any way.
> 
> No, it shouldn't and one can always regenerate configure if it is an issue. I'm in two minds about whether it is finally time to backport [JDK-8195689](https://bugs.openjdk.org/browse/JDK-8195689) to 8u and get rid of this once and for all. It is the only JDK to have this baggage (it is removed in 11u and up) and I think it causes more problems than it solves, but then I've never been a fan of bundling generated files to begin with.

@gnu-andrew thanks

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/370#issuecomment-1810042504


More information about the jdk8u-dev mailing list