[jdk8u-dev] RFR: 8297955: LDAP CertStore should use LdapName and not String for DNs

[Severin Gehwolf]

On Fri, 24 Nov 2023 07:10:49 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> [JDK-8308592](https://bugs.openjdk.org/browse/JDK-8308592): "Framework for CA interoperability testing" merges the Actalis test into a single test which handles multiple CAs. Before we can backport that, we thus need to fix the Actalis test by backporting [JDK-8297955](https://bugs.openjdk.org/browse/JDK-8297955) which also fixes [8224768](https://bugs.openjdk.org/browse/JDK-8224768)
> 
> The backport is mostly clean. The code changes apply cleanly once applied to `LDAPCertStore.java` rather than `LDAPCertStoreImpl.java` which doesn't exist in 8u (a refactoring in [JDK-8038084](https://bugs.openjdk.org/browse/JDK-8038084): "CertStore needs a way to add new CertStore types"). The unused `getName()` method needed to be removed as `name` is no longer a `String`. The `ProblemList.txt` change had to be manually added as did the copyright header change to `LDAPCertStore.java`.
> 
> The Actalis test passes after this backport. All other CA results match those on an unpatched build (GoogleCA currently seems to be broken on all 8u builds I had to hand)

This looks OK. `getName()` got removed in later JDKs, by JDK-8224729. This patch is fine, though. No need to drag in that additional dependency.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/388#pullrequestreview-1748071509