From fweimer at openjdk.org  Fri Sep  1 10:29:11 2023
From: fweimer at openjdk.org (Florian Weimer)
Date: Fri, 1 Sep 2023 10:29:11 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
Message-ID: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>

The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.

Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.

Patch originally submitted by @djdelorie as openjdk/jdk8u#42.

Related to:

* https://fedoraproject.org/wiki/Changes/PortingToModernC
* https://fedoraproject.org/wiki/Toolchain/PortingToModernC

-------------

Commit messages:
 - 8315506: C99 compatibility issue in LinuxNativeDispatcher

Changes: https://git.openjdk.org/jdk8u-dev/pull/362/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=362&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8315506
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/362.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/362/head:pull/362

PR: https://git.openjdk.org/jdk8u-dev/pull/362

From sgehwolf at openjdk.org  Fri Sep  1 11:09:46 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 1 Sep 2023 11:09:46 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
Message-ID: <Mk74uAX9JWLd9LqKG2U9zyQSqX-gaMyrW-ITjqvhX6g=.8ccec945-a105-4ab7-94a4-9da3dfbd8b6b@github.com>

On Fri, 1 Sep 2023 10:12:18 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.
> 
> Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.
> 
> Patch originally submitted by @djdelorie as openjdk/jdk8u#42.
> 
> Related to:
> 
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC

LGTM.

For the future please enable GHA on your fork! Thanks.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/362#pullrequestreview-1606740620
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1702575995

From fweimer at openjdk.org  Fri Sep  1 11:13:46 2023
From: fweimer at openjdk.org (Florian Weimer)
Date: Fri, 1 Sep 2023 11:13:46 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
Message-ID: <azjYtPgWc1cyioHHo-wi_zAsej-YgfCmrF7M_4dom-0=.e3c7a9d6-76b2-48d3-9894-57ea769a8a20@github.com>

On Fri, 1 Sep 2023 10:12:18 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.
> 
> Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.
> 
> Patch originally submitted by @djdelorie as openjdk/jdk8u#42.
> 
> Related to:
> 
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC

> For the future please enable GHA on your fork! Thanks.

Already done.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1702580921

From sgehwolf at openjdk.org  Fri Sep  1 12:35:43 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 1 Sep 2023 12:35:43 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <azjYtPgWc1cyioHHo-wi_zAsej-YgfCmrF7M_4dom-0=.e3c7a9d6-76b2-48d3-9894-57ea769a8a20@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
 <azjYtPgWc1cyioHHo-wi_zAsej-YgfCmrF7M_4dom-0=.e3c7a9d6-76b2-48d3-9894-57ea769a8a20@github.com>
Message-ID: <N39r_shpNsmu63Bndr9Yt7wlZkQWWABjEcNjaA9Pasc=.655577c3-b0d6-4251-a393-cb56c38c5570@github.com>

On Fri, 1 Sep 2023 11:11:02 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> > For the future please enable GHA on your fork! Thanks.
> 
> Already done.

Could you please trigger test runs for this? I don't see them. Also, please don't integrate without approval on the bug.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1702674843

From andrew at openjdk.org  Fri Sep  1 13:02:43 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 1 Sep 2023 13:02:43 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
Message-ID: <v1DwwcNPcuNGyO-TgUDKepTwIePut-fRxXNgpXStc1U=.fa0adaa3-6694-497d-8ea0-cc64ee1f549d@github.com>

On Fri, 1 Sep 2023 10:12:18 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.
> 
> Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.
> 
> Patch originally submitted by @djdelorie as openjdk/jdk8u#42.
> 
> Related to:
> 
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC

The function that introduces the `free` was added in `UnixNativeDispatcher.c` on 11u, which had a `stdlib.h` import since creation. As mentioned on the bug report, it was moved to `LinuxNativeDispatcher.c` in the backport of [JDK-8229872](https://bugs.openjdk.org/browse/JDK-8229872) to 8u, so this is 8u-specific.

Patch looks ok for 8u. Please run the GHA tests and then add `jdk8u-fix-request` to the bug, with a note on why this should be included.

Out of interest, what flags are you building with to make this a build failure? I've not seen that when building 8u. I don't believe this code is built with `-Werror` by default.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/362#pullrequestreview-1606899972
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1702711595

From simonis at openjdk.org  Fri Sep  1 14:45:49 2023
From: simonis at openjdk.org (Volker Simonis)
Date: Fri, 1 Sep 2023 14:45:49 GMT
Subject: [jdk8u-dev] RFR: 8315135: Memory leak in the native implementation
 of Pack200.Unpacker.unpack()
In-Reply-To: <dUWZc1Ik8FJCK7Do3rUUdQGiNgCzxttMew-rbvt6xhQ=.a2a6f9a7-4d20-41aa-a771-0ec1be5e909f@github.com>
References: <X5WD9i7KqMjplTAlzbhxJp3PQf0VO9Cuof7c4G1uQf8=.cd95ead8-85a4-442e-9dc7-66493fedb29b@github.com>
 <dUWZc1Ik8FJCK7Do3rUUdQGiNgCzxttMew-rbvt6xhQ=.a2a6f9a7-4d20-41aa-a771-0ec1be5e909f@github.com>
Message-ID: <R5IdTIU9FlKwVQj8pr-0yg4faqEyta7qzQxRduYnZ9c=.8ae77678-8a56-4a18-94a5-b96765d3e571@github.com>

On Thu, 31 Aug 2023 22:30:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [b77c161e](https://github.com/openjdk/jdk11u-dev/commit/b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
>> 
>> The commit being backported was authored by Volker Simonis on 30 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe.
>> 
>> The backport applies cleanly except for the usual 11/8 directory shuffling and the following cosmetic context change in `jni.cpp`:
>> 
>>> --- a/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp
>>> +++ b/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp
>> 58c58
>> <    CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0);
>> ---
>>>    CHECK_EXCEPTION_RETURN_VALUE(uPtr, NULL);
>> 
>> Thanks!
>
> Backport looks ok (though not clean due to the context difference)

Thanks @gnu-andrew! Regarding the "clean" label, I was a little confused by the following line in the [OpenJDK Backports Wiki](https://wiki.openjdk.org/display/SKARA/Backports):

> A backport commit is considered clean if the changes in the original commit are identical to the changes in the backport commit. Note that only the changes have to be identical, not the changed lines.

And I actually still don't fully understand what exactly "**_Note that only the changes have to be identical, not the changed lines_**" means?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/361#issuecomment-1702865000

From simonis at openjdk.org  Fri Sep  1 14:45:50 2023
From: simonis at openjdk.org (Volker Simonis)
Date: Fri, 1 Sep 2023 14:45:50 GMT
Subject: [jdk8u-dev] Integrated: 8315135: Memory leak in the native
 implementation of Pack200.Unpacker.unpack()
In-Reply-To: <X5WD9i7KqMjplTAlzbhxJp3PQf0VO9Cuof7c4G1uQf8=.cd95ead8-85a4-442e-9dc7-66493fedb29b@github.com>
References: <X5WD9i7KqMjplTAlzbhxJp3PQf0VO9Cuof7c4G1uQf8=.cd95ead8-85a4-442e-9dc7-66493fedb29b@github.com>
Message-ID: <H9zBuABhgV4Sxagc9xkA-mkrlx7IKD9L_scQQ7qNbcI=.2c183fac-7254-459e-9760-f4c7cf2c0a23@github.com>

On Wed, 30 Aug 2023 16:14:51 GMT, Volker Simonis <simonis at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [b77c161e](https://github.com/openjdk/jdk11u-dev/commit/b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Volker Simonis on 30 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe.
> 
> The backport applies cleanly except for the usual 11/8 directory shuffling and the following cosmetic context change in `jni.cpp`:
> 
>> --- a/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp
>> +++ b/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp
> 58c58
> <    CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0);
> ---
>>    CHECK_EXCEPTION_RETURN_VALUE(uPtr, NULL);
> 
> Thanks!

This pull request has now been integrated.

Changeset: 6632d0a7
Author:    Volker Simonis <simonis at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/6632d0a78758d11744906fdef6c3268d7091070e
Stats:     65 lines in 4 files changed: 63 ins; 0 del; 2 mod

8315135: Memory leak in the native implementation of Pack200.Unpacker.unpack()

Reviewed-by: andrew
Backport-of: b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/361

From fweimer at openjdk.org  Fri Sep  1 15:36:47 2023
From: fweimer at openjdk.org (Florian Weimer)
Date: Fri, 1 Sep 2023 15:36:47 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <v1DwwcNPcuNGyO-TgUDKepTwIePut-fRxXNgpXStc1U=.fa0adaa3-6694-497d-8ea0-cc64ee1f549d@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
 <v1DwwcNPcuNGyO-TgUDKepTwIePut-fRxXNgpXStc1U=.fa0adaa3-6694-497d-8ea0-cc64ee1f549d@github.com>
Message-ID: <H1QzRal2UsPalKCIWeLGM7TJ4fdX3wuIaHV-fEQ-0cU=.4c82e380-c90f-4e87-8d73-4f2f82ccce6c@github.com>

On Fri, 1 Sep 2023 12:59:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Out of interest, what flags are you building with to make this a build failure? I've not seen that when building 8u. I don't believe this code is built with `-Werror` by default.

@gnu-andrew This was originally detected with an instrumented compilers that treats such issues errors, and logs them so that build scripts have a hard time suppressing errors (relevant to configure scripts).

Current Clang defaults `-Werror=implict-function-declaration`, so no special build flags are necessary there to trigger this issue (but I haven't tried building OpenJDK with Clang). For quite some time, expected GCC 14 to something like this as well, but I'm not sure if things will work out.

Speaking of flags, I plan to add `-Werror=implict-function-declaration -Werror=implicit-int` to the default flags in Fedora. Should I backport this change proactively to the `java-1.8.0-openjdk-portable`?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1702941502

From andrew at openjdk.org  Fri Sep  1 15:38:50 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 1 Sep 2023 15:38:50 GMT
Subject: [jdk8u-dev] RFR: 8315135: Memory leak in the native implementation
 of Pack200.Unpacker.unpack()
In-Reply-To: <dUWZc1Ik8FJCK7Do3rUUdQGiNgCzxttMew-rbvt6xhQ=.a2a6f9a7-4d20-41aa-a771-0ec1be5e909f@github.com>
References: <X5WD9i7KqMjplTAlzbhxJp3PQf0VO9Cuof7c4G1uQf8=.cd95ead8-85a4-442e-9dc7-66493fedb29b@github.com>
 <dUWZc1Ik8FJCK7Do3rUUdQGiNgCzxttMew-rbvt6xhQ=.a2a6f9a7-4d20-41aa-a771-0ec1be5e909f@github.com>
Message-ID: <bnytZbsvynPptLidNIn_KhRg0IIPgDlrTRQrbmWJf98=.c47a3a30-aa5c-4aa4-ace2-d603e6b75d03@github.com>

On Thu, 31 Aug 2023 22:30:35 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [b77c161e](https://github.com/openjdk/jdk11u-dev/commit/b77c161e7509aa3b09ebf3e6b2b1490c0667bbdc) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
>> 
>> The commit being backported was authored by Volker Simonis on 30 Aug 2023 and was reviewed by Christoph Langer and Thomas Stuefe.
>> 
>> The backport applies cleanly except for the usual 11/8 directory shuffling and the following cosmetic context change in `jni.cpp`:
>> 
>>> --- a/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp
>>> +++ b/jdk/src/share/native/com/sun/java/util/jar/pack/jni.cpp
>> 58c58
>> <    CHECK_EXCEPTION_RETURN_VALUE(uPtr, 0);
>> ---
>>>    CHECK_EXCEPTION_RETURN_VALUE(uPtr, NULL);
>> 
>> Thanks!
>
> Backport looks ok (though not clean due to the context difference)

> Thanks @gnu-andrew! Regarding the "clean" label, I was a little confused by the following line in the [OpenJDK Backports Wiki](https://wiki.openjdk.org/display/SKARA/Backports):
> 
> > A backport commit is considered clean if the changes in the original commit are identical to the changes in the backport commit. Note that only the changes have to be identical, not the changed lines.
> 
> And I actually still don't fully understand what exactly "**_Note that only the changes have to be identical, not the changed lines_**" means?

It's the first time I've seen that myself and I agree it's confusing. I think the intention may be to imply that it's clean if you make the same code changes even if they are in a different place in the file or even a different file. To me, that would be going a bit far.

The approach I've always used, even before we used GitHub and Skara, is that a backport is clean if it can be automated by tools i.e. if you apply the shuffle script, and then run `patch`, and it applies, it is clean. If you have to open a file and apply any hunks manually, that is not clean.

Even the former can be problematic if patch fuzzes the change into the wrong place, so I would be cautious even in those cases. That's why I actually quite like that 8u doesn't automatically add `clean` and patches do get a once over from a real human :) As someone has to approve anyway, I don't think it's really much extra work.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/361#issuecomment-1702943787

From fweimer at openjdk.org  Fri Sep  1 15:44:25 2023
From: fweimer at openjdk.org (Florian Weimer)
Date: Fri, 1 Sep 2023 15:44:25 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher [v2]
In-Reply-To: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
Message-ID: <v7yWqU9uSMkF8_XpHeI1uUy9QPAZqAjIWN9109utzSQ=.42a15bd5-45fd-4b8f-91c9-9f269930cb39@github.com>

> The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.
> 
> Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.
> 
> Patch originally submitted by @djdelorie as openjdk/jdk8u#42.
> 
> Related to:
> 
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC

Florian Weimer has updated the pull request incrementally with one additional commit since the last revision:

  Trigger tests

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/362/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/362/files/f5eaefe1..d089e826

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=362&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=362&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/362.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/362/head:pull/362

PR: https://git.openjdk.org/jdk8u-dev/pull/362

From andrew at openjdk.org  Fri Sep  1 15:52:48 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 1 Sep 2023 15:52:48 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <H1QzRal2UsPalKCIWeLGM7TJ4fdX3wuIaHV-fEQ-0cU=.4c82e380-c90f-4e87-8d73-4f2f82ccce6c@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
 <v1DwwcNPcuNGyO-TgUDKepTwIePut-fRxXNgpXStc1U=.fa0adaa3-6694-497d-8ea0-cc64ee1f549d@github.com>
 <H1QzRal2UsPalKCIWeLGM7TJ4fdX3wuIaHV-fEQ-0cU=.4c82e380-c90f-4e87-8d73-4f2f82ccce6c@github.com>
Message-ID: <VKRovpm_tUCLiXcdw7xtDME-IG9bCDLzDf7BrosZEV8=.53c28a51-99c4-42dc-b17d-a998e263355b@github.com>

On Fri, 1 Sep 2023 15:34:24 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> > Out of interest, what flags are you building with to make this a build failure? I've not seen that when building 8u. I don't believe this code is built with `-Werror` by default.
> 
> @gnu-andrew This was originally detected with an instrumented compilers that treats such issues errors, and logs them so that build scripts have a hard time suppressing errors (relevant to configure scripts).
> 

Ah, that explains why I haven't seen it. I have built with some newer GCCs and even have a PR in flight to get GCC 11 working (https://github.com/openjdk/jdk8u-dev/pull/357 - still  need to work out why that is failing on cross-compile)

> Current Clang defaults `-Werror=implict-function-declaration`, so no special build flags are necessary there to trigger this issue (but I haven't tried building OpenJDK with Clang). For quite some time, expected GCC 14 to something like this as well, but I'm not sure if things will work out.
> 

I think later JDK versions should support Clang, but probably not 8u. I did have backporting support on a long TODO list at one point, but it's probably not worth it at this stage. That said, the situation might be better due to the MacOS support that's been added since, making Linux Clang support less problematic.

If we did support it, we'd probably need to add a build-only run with Clang to GHA.

> Speaking of flags, I plan to add `-Werror=implict-function-declaration -Werror=implicit-int` to the default flags in Fedora. Should I backport this change proactively to the `java-1.8.0-openjdk-portable`?

Do you mean this change or the additional flags? I thought this change was already in there.

There is a `-Wno-error` added in the Fedora build which I expect may cancel this out even if the flags you suggest are added. `-Werror=implicit-function-declaration` is certainly a useful one to have and one I ran with myself locally for a while. But fixing stuff like that in a JDK as old as 8u might be problematic and I'd certainly start with `java-21-openjdk` first.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1702962197

From abakhtin at openjdk.org  Fri Sep  1 22:48:45 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Fri, 1 Sep 2023 22:48:45 GMT
Subject: [jdk8u] RFR: 8225687: Newly added sspi.cpp in JDK-6722928 still
 contains some small errors
In-Reply-To: <TkKKl6Kg_EIJJyShyYPgH21mJtZpzMpOmT4IF7Bjsvs=.4e06bcb1-f0b8-4999-a9ca-92bab1b72ede@github.com>
References: <TkKKl6Kg_EIJJyShyYPgH21mJtZpzMpOmT4IF7Bjsvs=.4e06bcb1-f0b8-4999-a9ca-92bab1b72ede@github.com>
Message-ID: <swaqqsr5EONIoJ1bOgXWO6EIk2ZYIm_FyFOLB3bwiwo=.1c1cae8d-665a-4c34-9ef6-51023054b796@github.com>

On Wed, 30 Aug 2023 14:05:26 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This is a follow-up fix for JDK-6722928.
> Clean backport from JDK11

@gnu-andrew Could you please review, so it could be added to 8u392

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/47#issuecomment-1703400214

From sgehwolf at openjdk.org  Mon Sep  4 08:25:48 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 4 Sep 2023 08:25:48 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher [v2]
In-Reply-To: <v7yWqU9uSMkF8_XpHeI1uUy9QPAZqAjIWN9109utzSQ=.42a15bd5-45fd-4b8f-91c9-9f269930cb39@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
 <v7yWqU9uSMkF8_XpHeI1uUy9QPAZqAjIWN9109utzSQ=.42a15bd5-45fd-4b8f-91c9-9f269930cb39@github.com>
Message-ID: <lLo0U8NxI4tnAm2MbCvmolhhxodgvG8slFhnVF4wMCY=.a5b07404-2b43-41b4-9e35-305eae9b50d8@github.com>

On Fri, 1 Sep 2023 15:44:25 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

>> The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.
>> 
>> Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.
>> 
>> Patch originally submitted by @djdelorie as openjdk/jdk8u#42.
>> 
>> Related to:
>> 
>> * https://fedoraproject.org/wiki/Changes/PortingToModernC
>> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC
>
> Florian Weimer has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Trigger tests

Thanks for the test run trigger. I'll sponsor.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1704827633

From fweimer at openjdk.org  Mon Sep  4 10:05:48 2023
From: fweimer at openjdk.org (Florian Weimer)
Date: Mon, 4 Sep 2023 10:05:48 GMT
Subject: [jdk8u-dev] RFR: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <VKRovpm_tUCLiXcdw7xtDME-IG9bCDLzDf7BrosZEV8=.53c28a51-99c4-42dc-b17d-a998e263355b@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
 <v1DwwcNPcuNGyO-TgUDKepTwIePut-fRxXNgpXStc1U=.fa0adaa3-6694-497d-8ea0-cc64ee1f549d@github.com>
 <H1QzRal2UsPalKCIWeLGM7TJ4fdX3wuIaHV-fEQ-0cU=.4c82e380-c90f-4e87-8d73-4f2f82ccce6c@github.com>
 <VKRovpm_tUCLiXcdw7xtDME-IG9bCDLzDf7BrosZEV8=.53c28a51-99c4-42dc-b17d-a998e263355b@github.com>
Message-ID: <zgapyt6scE_MfKbk9kcLjAOizyYMDldJRXhMGqE9gRQ=.097b898c-d884-4ec1-849c-0bfc4746f32b@github.com>

On Fri, 1 Sep 2023 15:49:46 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > Speaking of flags, I plan to add `-Werror=implict-function-declaration -Werror=implicit-int` to the default flags in Fedora. Should I backport this change proactively to the `java-1.8.0-openjdk-portable`?
> 
> Do you mean this change or the additional flags? I thought this change was already in there.

No, it's not yet integrated into Fedora rawhide.  Hopefully this week.

> There is a `-Wno-error` added in the Fedora build which I expect may cancel this out even if the flags you suggest are added. `-Werror=implicit-function-declaration` is certainly a useful one to have and one I ran with myself locally for a while. But fixing stuff like that in a JDK as old as 8u might be problematic and I'd certainly start with `java-21-openjdk` first.

It was the only issue in our tests. That was a couple of months ago, but presumably the change rate in 8u is not that high.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1704979529

From fweimer at openjdk.org  Mon Sep  4 10:36:50 2023
From: fweimer at openjdk.org (Florian Weimer)
Date: Mon, 4 Sep 2023 10:36:50 GMT
Subject: [jdk8u-dev] Integrated: 8315506: C99 compatibility issue in
 LinuxNativeDispatcher
In-Reply-To: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
References: <u7CqujNLuDjf_lUjaQSCyyqQvewajVSqowrPTSdiIdE=.3d8386e2-f378-45e1-a6de-5599d0216acf@github.com>
Message-ID: <U6LF4K79wOdImpj7cGUtLaZ9N4ANyRJup059cMmL4SQ=.a5e00927-1ee6-4cbc-ad24-7b56a114dfe8@github.com>

On Fri, 1 Sep 2023 10:12:18 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.
> 
> Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.
> 
> Patch originally submitted by @djdelorie as openjdk/jdk8u#42.
> 
> Related to:
> 
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC

This pull request has now been integrated.

Changeset: 89a08b38
Author:    Florian Weimer <fweimer at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/89a08b389947078ae150a758c1ff9da7ba404857
Stats:     1 line in 1 file changed: 1 ins; 0 del; 0 mod

8315506: C99 compatibility issue in LinuxNativeDispatcher

Co-authored-by: DJ Delorie <dj at redhat.com>
Reviewed-by: sgehwolf, andrew

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/362

From duke at openjdk.org  Mon Sep  4 13:02:46 2023
From: duke at openjdk.org (Deepa Kumari)
Date: Mon, 4 Sep 2023 13:02:46 GMT
Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are
 not passed to ADLC build
In-Reply-To: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
References: <HwTCn7srlkqR2qIMM7ztvPJsTcOa1K6gubSyWmFed2w=.763de711-41ac-4017-a045-ba0ba2c9bafc@github.com>
Message-ID: <eQlPukFPZFHXNmzv02Ep9v1ZpEKwEKis4P47D2I8KbA=.e74870f2-05ef-41ba-bdde-5b1764d92860@github.com>

On Wed, 23 Aug 2023 03:58:10 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user.
> 
> 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build.
> 
> ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set.
> 
> However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code.
> 
> We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped.
> 
> This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system.
> 
> With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms)

Hi @gnu-andrew , It successfully built on jdk8u-dev on **AIX**. This is a positive sign that the changes are effective. 
Please let me know for further assistance. I would be happy to check.
Thank You.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-1705233524

From sgehwolf at openjdk.org  Tue Sep  5 09:42:15 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Sep 2023 09:42:15 GMT
Subject: [jdk8u-dev] RFR: 8295894: Remove SECOM certificate that is expiring in
 September 2023
Message-ID: <AqcabNH3AocUNnZUV8AscxZtLBVP8sCemdBUvJKbuIY=.4da59a60-4a30-441b-a179-4366a8c3308e@github.com>

Low risk backport of JDK-8295894 which removes an expired certificate from cacerts. It expires in September and we should get it into 8u (8u402 or if so desired as a critical fix to 8u392). Patch is a clean backport modulo usual path changes to adust to the 8u layout.

It's also a dependency so that the backport of JDK-8314960 (Add certigna 2 root CA) applies clean.

-------------

Commit messages:
 - Backport b40b1ca1f6ab606387bb1a466810f0e23dead560

Changes: https://git.openjdk.org/jdk8u-dev/pull/363/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=363&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295894
  Stats: 33 lines in 2 files changed: 0 ins; 30 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/363.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/363/head:pull/363

PR: https://git.openjdk.org/jdk8u-dev/pull/363

From sgehwolf at openjdk.org  Tue Sep  5 09:47:03 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Sep 2023 09:47:03 GMT
Subject: [jdk8u-dev] RFR: 8271838: AmazonCA.java interop test fails
In-Reply-To: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
References: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
Message-ID: <V5rthFX3kTLvUhHa4VVDfheH6TJVblssxPxCy8nCSvk=.77c23237-b197-4e7b-9d34-f84bf2631553@github.com>

On Tue, 5 Sep 2023 09:37:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of JDK-8271838 which applies clean modulo path differences and copyright. Test only change, thus, very low risk. It's a dependency to get JDK-8309088 in (which makes `AmazonCA.java` test pass again; fails currently).

Marking as clean as the only difference is in copyright header hunk which I've done manually.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/364#issuecomment-1706285050

From sgehwolf at openjdk.org  Tue Sep  5 09:47:03 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Sep 2023 09:47:03 GMT
Subject: [jdk8u-dev] RFR: 8271838: AmazonCA.java interop test fails
Message-ID: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>

Backport of JDK-8271838 which applies clean modulo path differences and copyright. Test only change, thus, very low risk. It's a dependency to get JDK-8309088 in (which makes `AmazonCA.java` test pass again; fails currently).

-------------

Commit messages:
 - Backport 512db0ff31a0a1a2bd8805964ba3d06e2cbfb9e9

Changes: https://git.openjdk.org/jdk8u-dev/pull/364/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=364&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8271838
  Stats: 245 lines in 1 file changed: 0 ins; 51 del; 194 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/364.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/364/head:pull/364

PR: https://git.openjdk.org/jdk8u-dev/pull/364

From sgehwolf at openjdk.org  Tue Sep  5 10:01:17 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Sep 2023 10:01:17 GMT
Subject: [jdk8u-dev] RFR: 8309088:
 security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
 fails
Message-ID: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>

Clean backport so as to make `AmazonCA.java` test pass again. It fails currently. See the bug for details. Test only, low risk.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/364

Commit messages:
 - Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3

Changes: https://git.openjdk.org/jdk8u-dev/pull/365/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=365&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8309088
  Stats: 491 lines in 1 file changed: 142 ins; 30 del; 319 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/365.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/365/head:pull/365

PR: https://git.openjdk.org/jdk8u-dev/pull/365

From sgehwolf at openjdk.org  Tue Sep  5 10:04:05 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Sep 2023 10:04:05 GMT
Subject: [jdk8u-dev] RFR: 8314960: Add Certigna Root CA - 2
Message-ID: <OM21WjVBe-E-UPFK7Yr06ZBbN6vDMRY0eXdAIZDFEog=.47c87100-4b60-4138-9b68-6e2a149df79b@github.com>

Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See https://github.com/openjdk/jdk8u-dev/pull/363

Testing:
- [ ] GHA (still running)
- [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass once JDK-8309088 (see #365) is in as well.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/363

Commit messages:
 - Backport a44f8b059847135ecd0618cb04abbb0d2be1d2d0

Changes: https://git.openjdk.org/jdk8u-dev/pull/366/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=366&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8314960
  Stats: 568 lines in 4 files changed: 338 ins; 227 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/366.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/366/head:pull/366

PR: https://git.openjdk.org/jdk8u-dev/pull/366

From sgehwolf at openjdk.org  Tue Sep  5 14:55:46 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Sep 2023 14:55:46 GMT
Subject: [jdk8u-dev] RFR: 8159156: [TESTBUG] ReserveMemory test is not
 useful on Aix.
In-Reply-To: <xZPm88QhArwjxz5ahOZNmjk4-IWtn5OERUjWxoxCJzk=.b18527d3-122d-41fb-b63f-31647d846b6c@github.com>
References: <xZPm88QhArwjxz5ahOZNmjk4-IWtn5OERUjWxoxCJzk=.b18527d3-122d-41fb-b63f-31647d846b6c@github.com>
Message-ID: <NnE4TH4d0JBhU_yeTUBx8swv2pqOIC_p2yJug6i5B08=.c4456876-9675-408f-82a2-a0b56d5724c5@github.com>

On Fri, 25 Aug 2023 17:54:50 GMT, Ilarion Nakonechnyy <inakonechnyy at openjdk.org> wrote:

> Backport of JDK-8159156 [TESTBUG] ReserveMemory test is not useful on Aix.
> Applied cleanly.

Only path changes have been done, marking as clean.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/358#issuecomment-1706775023

From sgehwolf at openjdk.org  Tue Sep  5 14:58:45 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 5 Sep 2023 14:58:45 GMT
Subject: [jdk8u-dev] RFR: 8225687: Newly added sspi.cpp in JDK-6722928
 still contains some small errors
In-Reply-To: <CQNCoiYiHQeBv_Ca5PzJ-4ZK4O5vW4bJN7d3Kvk4ijA=.b66d5abd-f376-4e30-97c3-aebef28e3eca@github.com>
References: <nkVLz-nBryCwrQeSZzub0njIrM73TaxnRT-p0KQuZOk=.46a87572-0696-4587-b379-cde9cca82070@github.com>
 <24wuSQY6u7Ibq7FNLskRZICPFUIC_VW3IYMc9xBRuYA=.84ed9e2a-434b-4e6c-b745-649fbb12a3f1@github.com>
 <CQNCoiYiHQeBv_Ca5PzJ-4ZK4O5vW4bJN7d3Kvk4ijA=.b66d5abd-f376-4e30-97c3-aebef28e3eca@github.com>
Message-ID: <Tr-v63ICEnuXQ51ENGfi4nJjmUCjsh_ouYsxhoXzEvs=.c7627f90-95d1-44a5-93e3-f44b26a89f85@github.com>

On Wed, 30 Aug 2023 14:08:52 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Sorry, I missed this one prior to rampdown. Can we do it against openjdk/jdk8u instead so it still makes 8u392? Apologies for the trouble.
>
>> Sorry, I missed this one prior to rampdown. Can we do it against openjdk/jdk8u instead so it still makes 8u392? Apologies for the trouble.
> 
> Sure, just made a PR against openjdk/jdk8u

@alexeybakhtin Please close this in favor of https://github.com/openjdk/jdk8u/pull/47

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/353#issuecomment-1706780340

From abakhtin at openjdk.org  Tue Sep  5 19:49:43 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Tue, 5 Sep 2023 19:49:43 GMT
Subject: [jdk8u-dev] RFR: 8225687: Newly added sspi.cpp in JDK-6722928
 still contains some small errors
In-Reply-To: <nkVLz-nBryCwrQeSZzub0njIrM73TaxnRT-p0KQuZOk=.46a87572-0696-4587-b379-cde9cca82070@github.com>
References: <nkVLz-nBryCwrQeSZzub0njIrM73TaxnRT-p0KQuZOk=.46a87572-0696-4587-b379-cde9cca82070@github.com>
Message-ID: <dSucINXMTA7rydapoH1I5-4Vjim3GOnjrjrRmfJXVRE=.46fca369-ab5e-4cad-a215-3194268e895b@github.com>

On Sat, 12 Aug 2023 00:25:03 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This is a follow-up fix for JDK-6722928.
> Clean backport from JDK11

Sure. Review moved to https://github.com/openjdk/jdk8u/pull/47

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/353#issuecomment-1707217907

From abakhtin at openjdk.org  Tue Sep  5 19:49:43 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Tue, 5 Sep 2023 19:49:43 GMT
Subject: [jdk8u-dev] Withdrawn: 8225687: Newly added sspi.cpp in JDK-6722928
 still contains some small errors
In-Reply-To: <nkVLz-nBryCwrQeSZzub0njIrM73TaxnRT-p0KQuZOk=.46a87572-0696-4587-b379-cde9cca82070@github.com>
References: <nkVLz-nBryCwrQeSZzub0njIrM73TaxnRT-p0KQuZOk=.46a87572-0696-4587-b379-cde9cca82070@github.com>
Message-ID: <feE6yhkNMTHsVFfmggTrdieL0d4QPd5_HO3YBvP5roU=.6c3261b7-e807-442d-b858-8bd445df5027@github.com>

On Sat, 12 Aug 2023 00:25:03 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This is a follow-up fix for JDK-6722928.
> Clean backport from JDK11

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/353

From abakhtin at openjdk.org  Tue Sep  5 23:51:02 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Tue, 5 Sep 2023 23:51:02 GMT
Subject: [jdk8u-dev] RFR: 8029995: accept yes/no for boolean krb5.conf settings
Message-ID: <7M8VUgALHVYnX5W0Iz7LMABFYGima_NuUgowTz5nSnk=.4884c35a-5118-4d18-863b-43d4533c8450@github.com>

This fix solves regression caused by JDK-8139348 and found by the test suite of 3rd party library.
The fix allows to use "yes" and "no" values in the krb5.conf file. It is important because sometimes krb5.conf is autogenerated and uses "yes"/"no" values inside.
The backport is almost clean except of the Config.java file. Config.java already has some changes applied as part of JDK-8077102
sun/security/krb5 jtreg tests passed

-------------

Commit messages:
 - Backport 9bae1e597b2d884e1d8a2a7a499b8d83ec002dbd

Changes: https://git.openjdk.org/jdk8u-dev/pull/367/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=367&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8029995
  Stats: 109 lines in 6 files changed: 75 ins; 25 del; 9 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/367.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/367/head:pull/367

PR: https://git.openjdk.org/jdk8u-dev/pull/367

From andrew at openjdk.org  Wed Sep  6 01:16:44 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 6 Sep 2023 01:16:44 GMT
Subject: [jdk8u-dev] RFR: 8271838: AmazonCA.java interop test fails
In-Reply-To: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
References: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
Message-ID: <-w-uFUzz1KmU7io_sF2ktwjRghiAGhuxT1oB2b77kG0=.bb4bb0b3-2a84-4446-999e-19a0cb9851aa@github.com>

On Tue, 5 Sep 2023 09:37:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of JDK-8271838 which applies clean modulo path differences and copyright. Test only change, thus, very low risk. It's a dependency to get JDK-8309088 in (which makes `AmazonCA.java` test pass again; fails currently).

> Marking as clean as the only difference is in copyright header hunk which I've done manually.
> 
> /clean

If manual changes have to be made, it is not clean.  See similar comment here: https://github.com/openjdk/jdk8u-dev/pull/361#issuecomment-1702943787

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/364#issuecomment-1707506575

From andrew at openjdk.org  Wed Sep  6 01:20:43 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 6 Sep 2023 01:20:43 GMT
Subject: [jdk8u-dev] RFR: 8271838: AmazonCA.java interop test fails
In-Reply-To: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
References: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
Message-ID: <MJATrasU2Ck9qLH_4hlYzV3B6ESYwSp6PTSkKxdZwgk=.434bcb84-6cf1-4192-a70a-9b7d8a32eec1@github.com>

On Tue, 5 Sep 2023 09:37:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of JDK-8271838 which applies clean modulo path differences and copyright. Test only change, thus, very low risk. It's a dependency to get JDK-8309088 in (which makes `AmazonCA.java` test pass again; fails currently).

Backport looks correct, with adjusted copyright header.

Does the test now pass? Or does JDK-8309088 also need to be applied for that to happen?

Are these tests run by GHA? They seem to fail so frequently that it would seem worth running them there if this is not already the case.

Windows failure seems to be a Visual Studio issue and not related to the change (which is test only)

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/364#pullrequestreview-1612170592
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/364#issuecomment-1707509172

From andrew at openjdk.org  Wed Sep  6 01:55:43 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 6 Sep 2023 01:55:43 GMT
Subject: [jdk8u] RFR: 8225687: Newly added sspi.cpp in JDK-6722928 still
 contains some small errors
In-Reply-To: <TkKKl6Kg_EIJJyShyYPgH21mJtZpzMpOmT4IF7Bjsvs=.4e06bcb1-f0b8-4999-a9ca-92bab1b72ede@github.com>
References: <TkKKl6Kg_EIJJyShyYPgH21mJtZpzMpOmT4IF7Bjsvs=.4e06bcb1-f0b8-4999-a9ca-92bab1b72ede@github.com>
Message-ID: <ddAUXI8Iy8PAXBA7SObAgrx6OfesU20Tb9s8X0NxvLc=.79b675ec-2245-404e-8632-fcc2ad50e38c@github.com>

On Wed, 30 Aug 2023 14:05:26 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This is a follow-up fix for JDK-6722928.
> Clean backport from JDK11

Backport looks clean and tests pass.
Please add `jdk8u-critical-request` to the bug and an appropriate comment, and I'll approve for 8u392. Thanks.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/47#pullrequestreview-1612199351

From duke at openjdk.org  Wed Sep  6 06:52:18 2023
From: duke at openjdk.org (ktakakuri)
Date: Wed, 6 Sep 2023 06:52:18 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
Message-ID: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>

> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
> 
> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
> 
> Testing:
> java/awt
> javax/swing
> ButtonGroupLayoutTraversalTest.java
> bug8033699.java
> DefaultButtonModelCrashTest.java
> on Windows x86_64

ktakakuri has updated the pull request incrementally with one additional commit since the last revision:

  Fix the copyright years

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/285/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/285/files/cc8ef7ee..a1eac9d6

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=285&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=285&range=01-02

  Stats: 6 lines in 5 files changed: 0 ins; 0 del; 6 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/285.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/285/head:pull/285

PR: https://git.openjdk.org/jdk8u-dev/pull/285

From duke at openjdk.org  Wed Sep  6 06:52:35 2023
From: duke at openjdk.org (ktakakuri)
Date: Wed, 6 Sep 2023 06:52:35 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v2]
In-Reply-To: <oO-X7iCP0ZCjDQaiKMypFcV2_CZrM18iuLNALksOoV4=.16e3a06e-423c-4c95-9343-d469d7869467@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <oO-X7iCP0ZCjDQaiKMypFcV2_CZrM18iuLNALksOoV4=.16e3a06e-423c-4c95-9343-d469d7869467@github.com>
Message-ID: <FwE6dk7G3FtI6XqifZvJT1wYA301rIoWIjYYs-VkAoY=.a0672cd3-b122-4546-8e45-c688a6c0a042@github.com>

On Tue, 13 Jun 2023 06:58:31 GMT, ktakakuri <duke at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> ktakakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'openjdk:master' into 8154043
>  - Chmod ButtonGroupLayoutTraversalTest
>  - Chmod DefaultButtonModelCrashTest
>  - Fix the copyright year
>  - Backport f3abf05b31893b9a066a436e2c4a587f8899ab10
>  - Backport 8d81ec63b2bafc431cbb8572a3e45e76580ab46f

I corrected the copyright date.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-1707769258

From sgehwolf at openjdk.org  Wed Sep  6 08:28:45 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 08:28:45 GMT
Subject: [jdk8u-dev] RFR: 8271838: AmazonCA.java interop test fails
In-Reply-To: <MJATrasU2Ck9qLH_4hlYzV3B6ESYwSp6PTSkKxdZwgk=.434bcb84-6cf1-4192-a70a-9b7d8a32eec1@github.com>
References: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
 <MJATrasU2Ck9qLH_4hlYzV3B6ESYwSp6PTSkKxdZwgk=.434bcb84-6cf1-4192-a70a-9b7d8a32eec1@github.com>
Message-ID: <YvIYYZ50OIVwcNt4sG07EM1rcaehy-U1y7gC4EZQBHA=.afd1cb22-49db-47e2-a061-8907d6398dd3@github.com>

On Wed, 6 Sep 2023 01:17:18 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Backport looks correct, with adjusted copyright header.

Thanks for the review.

> Does the test now pass? Or does JDK-8309088 also need to be applied for that to happen?

No. It needs JDK-8309088 as well.

> Are these tests run by GHA? They seem to fail so frequently that it would seem worth running them there if this is not already the case.

No they're not run as part of "tier1" GHA. I'll see if I can find the time to do this, though.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/364#issuecomment-1707896712

From sgehwolf at openjdk.org  Wed Sep  6 09:36:48 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 09:36:48 GMT
Subject: [jdk8u-dev] Withdrawn: 8295894: Remove SECOM certificate that is
 expiring in September 2023
In-Reply-To: <AqcabNH3AocUNnZUV8AscxZtLBVP8sCemdBUvJKbuIY=.4da59a60-4a30-441b-a179-4366a8c3308e@github.com>
References: <AqcabNH3AocUNnZUV8AscxZtLBVP8sCemdBUvJKbuIY=.4da59a60-4a30-441b-a179-4366a8c3308e@github.com>
Message-ID: <U7QIka9MvSmRNyldoWMg1zVFDbIR2jjHbYUZXyJkBlY=.283af4a6-a3da-4f81-a603-8355b78da7b4@github.com>

On Tue, 5 Sep 2023 09:34:23 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Low risk backport of JDK-8295894 which removes an expired certificate from cacerts. It expires in September and we should get it into 8u (8u402 or if so desired as a critical fix to 8u392). Patch is a clean backport modulo usual path changes to adust to the 8u layout.
> 
> It's also a dependency so that the backport of JDK-8314960 (Add certigna 2 root CA) applies clean.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/363

From sgehwolf at openjdk.org  Wed Sep  6 09:36:47 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 09:36:47 GMT
Subject: [jdk8u-dev] RFR: 8295894: Remove SECOM certificate that is
 expiring in September 2023
In-Reply-To: <AqcabNH3AocUNnZUV8AscxZtLBVP8sCemdBUvJKbuIY=.4da59a60-4a30-441b-a179-4366a8c3308e@github.com>
References: <AqcabNH3AocUNnZUV8AscxZtLBVP8sCemdBUvJKbuIY=.4da59a60-4a30-441b-a179-4366a8c3308e@github.com>
Message-ID: <Ezp7PvZPRp6a-_MvRWsbQCiPdx1WeJhCPUq6ut_N3iw=.fd6d947d-5fff-4c26-838e-acb700ddffa1@github.com>

On Tue, 5 Sep 2023 09:34:23 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Low risk backport of JDK-8295894 which removes an expired certificate from cacerts. It expires in September and we should get it into 8u (8u402 or if so desired as a critical fix to 8u392). Patch is a clean backport modulo usual path changes to adust to the 8u layout.
> 
> It's also a dependency so that the backport of JDK-8314960 (Add certigna 2 root CA) applies clean.

Moved to: https://github.com/openjdk/jdk8u/pull/48

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/363#issuecomment-1708001480

From sgehwolf at openjdk.org  Wed Sep  6 09:41:27 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 09:41:27 GMT
Subject: [jdk8u] RFR: 8295894: Remove SECOM certificate that is expiring in
 September 2023
Message-ID: <AwxRJyAksutoDQ5KkUEL7CASUlUiCuZ_1SN8pdJjwf8=.a1960e0a-a261-4d05-9b37-42b66333f902@github.com>

Low risk backport of JDK-8295894 which removes an expired certificate from cacerts. It expires in September and we should get it into 8u392. Patch is a clean backport modulo usual path changes to adjust to the 8u layout.

It's also a dependency so that the backport of JDK-8314960 (Add certigna 2 root CA) applies clean.

Testing:
- [ ] GHA (still running)
- [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts`. Pass, except for `AmazonCA.java` which is being dealt with elsewhere: https://git.openjdk.org/jdk8u-dev/pull/364 and https://git.openjdk.org/jdk8u-dev/pull/365

-------------

Commit messages:
 - Backport b40b1ca1f6ab606387bb1a466810f0e23dead560

Changes: https://git.openjdk.org/jdk8u/pull/48/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=48&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295894
  Stats: 33 lines in 2 files changed: 0 ins; 30 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u/pull/48.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/48/head:pull/48

PR: https://git.openjdk.org/jdk8u/pull/48

From sgehwolf at openjdk.org  Wed Sep  6 09:43:27 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 09:43:27 GMT
Subject: [jdk8u-dev] RFR: 8314960: Add Certigna Root CA - 2 [v2]
In-Reply-To: <OM21WjVBe-E-UPFK7Yr06ZBbN6vDMRY0eXdAIZDFEog=.47c87100-4b60-4138-9b68-6e2a149df79b@github.com>
References: <OM21WjVBe-E-UPFK7Yr06ZBbN6vDMRY0eXdAIZDFEog=.47c87100-4b60-4138-9b68-6e2a149df79b@github.com>
Message-ID: <kdqXvHoMUb0bRP3eQP-Y7ZPSgfmuABIPdOYfpW6SQTk=.0240885b-e5d1-4494-8027-7406d5e01fbc@github.com>

> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See https://github.com/openjdk/jdk8u-dev/pull/363
> 
> Testing:
> - [ ] GHA (still running)
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass once JDK-8309088 (see #365) is in as well.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/366/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/366/files/19e9cae3..19e9cae3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=366&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=366&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/366.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/366/head:pull/366

PR: https://git.openjdk.org/jdk8u-dev/pull/366

From sgehwolf at openjdk.org  Wed Sep  6 10:34:04 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 10:34:04 GMT
Subject: [jdk8u] RFR: 8314960: Add Certigna Root CA - 2
Message-ID: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>

Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u392 as a critical fix during rampdown. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See #48 

Testing:
- [ ] GHA (still running)
- [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass except `AmazonCA.java` which is a different matter (it'll be OK again once JDK-8309088 is in as well).

-------------

Depends on: https://git.openjdk.org/jdk8u/pull/48

Commit messages:
 - Backport a44f8b059847135ecd0618cb04abbb0d2be1d2d0

Changes: https://git.openjdk.org/jdk8u/pull/49/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=49&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8314960
  Stats: 568 lines in 4 files changed: 338 ins; 227 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u/pull/49.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/49/head:pull/49

PR: https://git.openjdk.org/jdk8u/pull/49

From sgehwolf at openjdk.org  Wed Sep  6 10:36:44 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 10:36:44 GMT
Subject: [jdk8u-dev] RFR: 8314960: Add Certigna Root CA - 2 [v2]
In-Reply-To: <kdqXvHoMUb0bRP3eQP-Y7ZPSgfmuABIPdOYfpW6SQTk=.0240885b-e5d1-4494-8027-7406d5e01fbc@github.com>
References: <OM21WjVBe-E-UPFK7Yr06ZBbN6vDMRY0eXdAIZDFEog=.47c87100-4b60-4138-9b68-6e2a149df79b@github.com>
 <kdqXvHoMUb0bRP3eQP-Y7ZPSgfmuABIPdOYfpW6SQTk=.0240885b-e5d1-4494-8027-7406d5e01fbc@github.com>
Message-ID: <bnPPJw30xj7J7JRssz0CyoRqS4pqySfBwuNGmGscxHg=.660142c8-322c-4e39-9e94-da24ad03c83a@github.com>

On Wed, 6 Sep 2023 09:43:27 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See https://github.com/openjdk/jdk8u-dev/pull/363
>> 
>> Testing:
>> - [ ] GHA (still running)
>> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass once JDK-8309088 (see #365) is in as well.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

Replaced by: https://github.com/openjdk/jdk8u/pull/49

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/366#issuecomment-1708090736

From sgehwolf at openjdk.org  Wed Sep  6 10:36:45 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 10:36:45 GMT
Subject: [jdk8u-dev] Withdrawn: 8314960: Add Certigna Root CA - 2
In-Reply-To: <OM21WjVBe-E-UPFK7Yr06ZBbN6vDMRY0eXdAIZDFEog=.47c87100-4b60-4138-9b68-6e2a149df79b@github.com>
References: <OM21WjVBe-E-UPFK7Yr06ZBbN6vDMRY0eXdAIZDFEog=.47c87100-4b60-4138-9b68-6e2a149df79b@github.com>
Message-ID: <JrnxyoC4L4Mnp7J6Ivn9LRln36katgAGCIN1Jo0w70c=.cd528e0c-9dc1-4e6a-927a-b7cbb93bcaa3@github.com>

On Tue, 5 Sep 2023 09:56:16 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See https://github.com/openjdk/jdk8u-dev/pull/363
> 
> Testing:
> - [ ] GHA (still running)
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass once JDK-8309088 (see #365) is in as well.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/366

From inakonechnyy at openjdk.org  Wed Sep  6 13:38:47 2023
From: inakonechnyy at openjdk.org (Ilarion Nakonechnyy)
Date: Wed, 6 Sep 2023 13:38:47 GMT
Subject: [jdk8u-dev] Integrated: 8239365: ProcessBuilder test modifications for
 AIX execution
In-Reply-To: <METk67GwtlMr1doPtjhUMf6BMPFUnnYzTx3GfSCWapA=.2a0f1784-5240-4b41-ad14-3cb665b7881f@github.com>
References: <METk67GwtlMr1doPtjhUMf6BMPFUnnYzTx3GfSCWapA=.2a0f1784-5240-4b41-ad14-3cb665b7881f@github.com>
Message-ID: <Sfe3cwGuOeVNNqUEC-rGWqIjriyVs9TFB4JyTZwqBXQ=.1f93a77c-c346-4385-afdb-6c17c73b7118@github.com>

On Tue, 25 Jul 2023 13:51:18 GMT, Ilarion Nakonechnyy <inakonechnyy at openjdk.org> wrote:

> Applied cleanly, fixes JTREG failed test java/lang/ProcessBuilder/Basic.java on AIX 7.2

This pull request has now been integrated.

Changeset: 115e74d2
Author:    Ilarion Nakonechnyy <inakonechnyy at openjdk.org>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/115e74d22d3b324afa6e53814c8f9c5599bec542
Stats:     11 lines in 1 file changed: 4 ins; 0 del; 7 mod

8239365: ProcessBuilder test modifications for AIX execution

Backport-of: 2785fe5621bd3af64450f1f5069dc2a4b47785fe

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/348

From inakonechnyy at openjdk.org  Wed Sep  6 13:40:53 2023
From: inakonechnyy at openjdk.org (Ilarion Nakonechnyy)
Date: Wed, 6 Sep 2023 13:40:53 GMT
Subject: [jdk8u-dev] Integrated: 8159156: [TESTBUG] ReserveMemory test is not
 useful on Aix.
In-Reply-To: <xZPm88QhArwjxz5ahOZNmjk4-IWtn5OERUjWxoxCJzk=.b18527d3-122d-41fb-b63f-31647d846b6c@github.com>
References: <xZPm88QhArwjxz5ahOZNmjk4-IWtn5OERUjWxoxCJzk=.b18527d3-122d-41fb-b63f-31647d846b6c@github.com>
Message-ID: <yEb8GmM9EpoQJwaWysk4WznJAAmjKb4F9nGEQ8QGeNs=.1628a3c9-a31e-4543-964a-0993318d2ec3@github.com>

On Fri, 25 Aug 2023 17:54:50 GMT, Ilarion Nakonechnyy <inakonechnyy at openjdk.org> wrote:

> Backport of JDK-8159156 [TESTBUG] ReserveMemory test is not useful on Aix.
> Applied cleanly.

This pull request has now been integrated.

Changeset: 1fc2e331
Author:    Ilarion Nakonechnyy <inakonechnyy at openjdk.org>
Committer: Yuri Nesterenko <yan at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/1fc2e331ebbeb38908f48d1903041324f2406ee6
Stats:     12 lines in 1 file changed: 2 ins; 8 del; 2 mod

8159156: [TESTBUG] ReserveMemory test is not useful on Aix.

Backport-of: 8bb3799029d34e7f5bbc3d9e5bc6da7068360bc7

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/358

From sgehwolf at openjdk.org  Wed Sep  6 14:02:48 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 14:02:48 GMT
Subject: [jdk8u-dev] RFR: 8271838: AmazonCA.java interop test fails
In-Reply-To: <DUuhN19Ja42zsT4LyM8A4nFyZ6wLHVpFCWBgiUWBBWQ=.591a7031-e7e8-450e-ae53-9819dd0c6562@github.com>
References: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
 <DUuhN19Ja42zsT4LyM8A4nFyZ6wLHVpFCWBgiUWBBWQ=.591a7031-e7e8-450e-ae53-9819dd0c6562@github.com>
Message-ID: <_UoqydLeeRIOdw6YnpQP4nAeuht9DylIyy4QZcekIyM=.a00c1091-3e00-4f17-9f13-2a90417c1b8a@github.com>

On Wed, 6 Sep 2023 13:58:41 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Ok, approving this so we can move onto the other one. We can add a regular test for this to GHA separately.

Thanks! See #368 for the tests part (still in draft).

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/364#issuecomment-1708433564

From andrew at openjdk.org  Wed Sep  6 14:02:47 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 6 Sep 2023 14:02:47 GMT
Subject: [jdk8u-dev] RFR: 8271838: AmazonCA.java interop test fails
In-Reply-To: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
References: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
Message-ID: <DUuhN19Ja42zsT4LyM8A4nFyZ6wLHVpFCWBgiUWBBWQ=.591a7031-e7e8-450e-ae53-9819dd0c6562@github.com>

On Tue, 5 Sep 2023 09:37:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of JDK-8271838 which applies clean modulo path differences and copyright. Test only change, thus, very low risk. It's a dependency to get JDK-8309088 in (which makes `AmazonCA.java` test pass again; fails currently).

Ok, approving this so we can move onto the other one. We can add a regular test for this to GHA separately.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/364#pullrequestreview-1613416239

From sgehwolf at openjdk.org  Wed Sep  6 14:14:51 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 14:14:51 GMT
Subject: [jdk8u-dev] Integrated: 8271838: AmazonCA.java interop test fails
In-Reply-To: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
References: <0IOJ5pCLXEDGbQLmzGjTUSCwHUJrN-nLu7_JkVkyUKM=.f63a5378-b283-40a4-a79c-05237df30e1d@github.com>
Message-ID: <A88-kUYVc2ofWeLfWY5zn8-Nz1HNwZUMbAUsDyZ_-SU=.7f0bac5f-0fd7-46f8-975e-17cd43503894@github.com>

On Tue, 5 Sep 2023 09:37:25 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of JDK-8271838 which applies clean modulo path differences and copyright. Test only change, thus, very low risk. It's a dependency to get JDK-8309088 in (which makes `AmazonCA.java` test pass again; fails currently).

This pull request has now been integrated.

Changeset: 54c0440e
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/54c0440e3358542c1646997fcc155b4e4e2fcb34
Stats:     245 lines in 1 file changed: 0 ins; 51 del; 194 mod

8271838: AmazonCA.java interop test fails

Reviewed-by: andrew
Backport-of: 512db0ff31a0a1a2bd8805964ba3d06e2cbfb9e9

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/364

From sgehwolf at openjdk.org  Wed Sep  6 14:21:13 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 14:21:13 GMT
Subject: [jdk8u-dev] RFR: 8309088:
 security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
 fails [v2]
In-Reply-To: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
References: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
Message-ID: <ngCB1bbRVP9QSJFDe5HWYc4tl1L15Ktt2ukFxCYfUYM=.afce6264-5104-4b14-abf3-2f3946c633ea@github.com>

> Clean backport so as to make `AmazonCA.java` test pass again. It fails currently. See the bug for details. Test only, low risk.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/365/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/365/files/a4d12302..a4d12302

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=365&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=365&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/365.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/365/head:pull/365

PR: https://git.openjdk.org/jdk8u-dev/pull/365

From sgehwolf at openjdk.org  Wed Sep  6 14:48:05 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 14:48:05 GMT
Subject: [jdk8u-dev] RFR: 8309088:
 security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
 fails [v3]
In-Reply-To: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
References: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
Message-ID: <Qixqk3NocJQCMFm25TMbRd4RWhGkssf5-AleeAdMyTY=.20e9879b-007c-4c92-a36e-f28b1a5bda5c@github.com>

> Clean backport so as to make `AmazonCA.java` test pass again. It fails currently. See the bug for details. Test only, low risk.

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:

  Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/365/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/365/files/a4d12302..aff61714

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=365&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=365&range=01-02

  Stats: 23 lines in 2 files changed: 6 ins; 8 del; 9 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/365.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/365/head:pull/365

PR: https://git.openjdk.org/jdk8u-dev/pull/365

From sgehwolf at openjdk.org  Wed Sep  6 14:53:59 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Wed, 6 Sep 2023 14:53:59 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA tier1
 test set
Message-ID: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>

Simple GHA only change to add cacert tests to the tier1 test set. Please review.

Testing:
 - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/365

Commit messages:
 - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set
 - Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3
 - Backport 512db0ff31a0a1a2bd8805964ba3d06e2cbfb9e9

Changes: https://git.openjdk.org/jdk8u-dev/pull/368/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=368&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8315757
  Stats: 513 lines in 2 files changed: 112 ins; 46 del; 355 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/368.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/368/head:pull/368

PR: https://git.openjdk.org/jdk8u-dev/pull/368

From abakhtin at openjdk.org  Wed Sep  6 15:27:52 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 6 Sep 2023 15:27:52 GMT
Subject: [jdk8u] Integrated: 8225687: Newly added sspi.cpp in JDK-6722928 still
 contains some small errors
In-Reply-To: <TkKKl6Kg_EIJJyShyYPgH21mJtZpzMpOmT4IF7Bjsvs=.4e06bcb1-f0b8-4999-a9ca-92bab1b72ede@github.com>
References: <TkKKl6Kg_EIJJyShyYPgH21mJtZpzMpOmT4IF7Bjsvs=.4e06bcb1-f0b8-4999-a9ca-92bab1b72ede@github.com>
Message-ID: <RairWNgV1btquhdV6qvtadwT2Q1Vjjr_Maay7zrVz44=.25de496a-f8cd-41a6-89df-1f80b652cd39@github.com>

On Wed, 30 Aug 2023 14:05:26 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This is a follow-up fix for JDK-6722928.
> Clean backport from JDK11

This pull request has now been integrated.

Changeset: 599bb77c
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/599bb77c451274bacdb38cb7fd2d8fe658846ab3
Stats:     127 lines in 3 files changed: 42 ins; 1 del; 84 mod

8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors

Reviewed-by: andrew
Backport-of: e03c2a270b291e7b1edcf4df491d6d386a882a87

-------------

PR: https://git.openjdk.org/jdk8u/pull/47

From duke at openjdk.org  Wed Sep  6 21:58:54 2023
From: duke at openjdk.org (Chad Rakoczy)
Date: Wed, 6 Sep 2023 21:58:54 GMT
Subject: [jdk8u-dev] RFR: 8311813: C1: Uninitialized PhiResolver::_loop field
Message-ID: <YW2zxJ0x7KfAgOImTxaUCnKp1PdGyfFDx6qKG32oA0E=.c438ade7-7322-4517-b99f-c203b31813a1@github.com>

[JDK-8311813](https://bugs.openjdk.org/browse/JDK-8311813)

Initialize `PhiResolver::_loop` field to `nullptr`

Clean backport

-------------

Commit messages:
 - Backport 489a32fe40e2a2c539296d51d4ffc0abc036d33c

Changes: https://git.openjdk.org/jdk8u-dev/pull/369/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=369&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8311813
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/369.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/369/head:pull/369

PR: https://git.openjdk.org/jdk8u-dev/pull/369

From duke at openjdk.org  Wed Sep  6 22:47:10 2023
From: duke at openjdk.org (Chad Rakoczy)
Date: Wed, 6 Sep 2023 22:47:10 GMT
Subject: [jdk8u-dev] RFR: 8311813: C1: Uninitialized PhiResolver::_loop
 field [v2]
In-Reply-To: <YW2zxJ0x7KfAgOImTxaUCnKp1PdGyfFDx6qKG32oA0E=.c438ade7-7322-4517-b99f-c203b31813a1@github.com>
References: <YW2zxJ0x7KfAgOImTxaUCnKp1PdGyfFDx6qKG32oA0E=.c438ade7-7322-4517-b99f-c203b31813a1@github.com>
Message-ID: <ZcYVG-wqvWNENP49UadDG2Z_2nH66Bt78wA-0JpbEYk=.de3cf756-9377-44da-9244-5d456a5ba092@github.com>

> [JDK-8311813](https://bugs.openjdk.org/browse/JDK-8311813)
> 
> Initialize `PhiResolver::_loop` field to `nullptr`
> 
> Clean backport

Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:

  Change nullptr to NULL

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/369/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/369/files/d1233fd4..daff8417

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=369&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=369&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/369.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/369/head:pull/369

PR: https://git.openjdk.org/jdk8u-dev/pull/369

From phh at openjdk.org  Thu Sep  7 19:52:47 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 7 Sep 2023 19:52:47 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set
In-Reply-To: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
Message-ID: <_iPX_VmyeYXYEVWeFOzs3elrQFCUueozeIiMgGep2pk=.0f9e5319-9f09-46d2-8ddf-52672b9a16d2@github.com>

On Wed, 6 Sep 2023 13:50:09 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
> 
> Testing:
>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)

This seems to include the changes from https://github.com/openjdk/jdk8u-dev/pull/365. Maybe forgot to derive your 8315757 branch from your 8309088 branch?

-------------

Changes requested by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/368#pullrequestreview-1616141156

From phh at openjdk.org  Thu Sep  7 19:54:45 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 7 Sep 2023 19:54:45 GMT
Subject: [jdk8u-dev] RFR: 8309088:
 security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
 fails [v3]
In-Reply-To: <Qixqk3NocJQCMFm25TMbRd4RWhGkssf5-AleeAdMyTY=.20e9879b-007c-4c92-a36e-f28b1a5bda5c@github.com>
References: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
 <Qixqk3NocJQCMFm25TMbRd4RWhGkssf5-AleeAdMyTY=.20e9879b-007c-4c92-a36e-f28b1a5bda5c@github.com>
Message-ID: <EYVAuJfb3zGOstOv38ga8Sd9TWR01oXzeiGZ8Gec0fY=.8fec65e2-ad2f-416a-9aae-1bbe0a135354@github.com>

On Wed, 6 Sep 2023 14:48:05 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport so as to make `AmazonCA.java` test pass again. It fails currently. See the bug for details. Test only, low risk.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/365#pullrequestreview-1616143041

From zzambers at openjdk.org  Thu Sep  7 20:16:18 2023
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Thu, 7 Sep 2023 20:16:18 GMT
Subject: [jdk8u-dev] RFR: 8176509: Use pandoc for converting build readme to
 html
Message-ID: <-b_sIr0DdNgucwSKVckSqwjg0ChhDmEuf2e6YtHjXUs=.baa26a5c-fcc2-4523-ae18-bfaea88da7d8@github.com>

This backport switches to pandoc for coversion of building readme to html. It also does some style/formating changes/fixes to building readme, which is moved to new location and also removes redundant information in other Readme files.

Backport is not clear. Code for coversion to html had to be modified to work with JDK8 build system. Change set (patch) for building readme mostly applied automatically, but some parts had to be done by hand due to few differences.

Unlike in original change set, this backport moves `README-builds.{md,html}` files directly to `doc/building.{md,html}` and not to intermediate location `common/doc/building.{md,html}`. (additional move was done in jdk10 as part of [JDK-8187443](https://bugs.openjdk.org/browse/JDK-8187443))

-------------

Commit messages:
 - Backport 9d0bd1b495012de5de1c62f65f14c4de36aef056

Changes: https://git.openjdk.org/jdk8u-dev/pull/370/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=370&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8176509
  Stats: 5004 lines in 16 files changed: 2140 ins; 2854 del; 10 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/370.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/370/head:pull/370

PR: https://git.openjdk.org/jdk8u-dev/pull/370

From phh at openjdk.org  Thu Sep  7 22:06:45 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 7 Sep 2023 22:06:45 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <N8hboJKI-EVM4NO2TWvRrqezuseCfSOObL9t6W9iZE4=.7a0c7ef3-b84b-4fc3-b602-a21dbdee13b0@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, ktakakuri <duke at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> ktakakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/285#pullrequestreview-1616298160

From sgehwolf at openjdk.org  Fri Sep  8 09:19:02 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 8 Sep 2023 09:19:02 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v2]
In-Reply-To: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
Message-ID: <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>

> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
> 
> Testing:
>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/368/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=368&range=01
  Stats: 6 lines in 1 file changed: 5 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/368.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/368/head:pull/368

PR: https://git.openjdk.org/jdk8u-dev/pull/368

From sgehwolf at openjdk.org  Fri Sep  8 09:20:46 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 8 Sep 2023 09:20:46 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set
In-Reply-To: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
Message-ID: <nAwnGZ2bquE7wb8Q4xPKBM4wtnCdHT4Ne4c1C_490fQ=.0d09d8b6-28f5-4195-b416-d9f0ff02d937@github.com>

On Wed, 6 Sep 2023 13:50:09 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
> 
> Testing:
>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)

> This seems to include the changes from #365. Maybe forgot to derive your 8315757 branch from your 8309088 branch?

It's an oddity of dependent pull requests. As soon as one of the PRs you depend on integrate, you need to rebase to the actually committed/rebased version in all dependants. Should be fixed now.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1711350692

From inakonechnyy at openjdk.org  Fri Sep  8 13:36:47 2023
From: inakonechnyy at openjdk.org (Ilarion Nakonechnyy)
Date: Fri, 8 Sep 2023 13:36:47 GMT
Subject: [jdk8u-dev] RFR: 8207404: MulticastSocket tests failing on AIX
In-Reply-To: <05e3dm1BROrR_sCq-zzryCP0u5ZKq7mrpEHkpdXZ2pQ=.4b658ebe-9dda-4517-8341-150e9e755828@github.com>
References: <05e3dm1BROrR_sCq-zzryCP0u5ZKq7mrpEHkpdXZ2pQ=.4b658ebe-9dda-4517-8341-150e9e755828@github.com>
Message-ID: <eL8r52-3PBpSK21W3d_c3MPBPgNf-1Rwg3BZwiHUmFQ=.aaccc0b4-e13e-47ee-b7f9-0561f838d6b5@github.com>

On Tue, 25 Jul 2023 11:39:05 GMT, Ilarion Nakonechnyy <inakonechnyy at openjdk.org> wrote:

> This backport fixes the tier2 test:
> FAILED: java/net/MulticastSocket/JoinLeave.java -- The socket name is not available on this system. (Error setting socket option)
> 
> Changes are applied non-cleanly. 
> Tested on AIX 7.2

The GHA was enabled, and all checks passed. Waiting for review

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/347#issuecomment-1711682380

From phh at openjdk.org  Fri Sep  8 14:35:43 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 8 Sep 2023 14:35:43 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v2]
In-Reply-To: <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
Message-ID: <K-fYE1rDPFISM2Q3S0_lNHt5LeyqM5ZyiNv-5GEN1Y0=.fdb87b33-32f9-4788-b958-a0e249bb8f4a@github.com>

On Fri, 8 Sep 2023 09:19:02 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

Fixed. :)

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/368#pullrequestreview-1617627540

From phh at openjdk.org  Fri Sep  8 15:15:47 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 8 Sep 2023 15:15:47 GMT
Subject: [jdk8u-dev] RFR: 8207404: MulticastSocket tests failing on AIX
In-Reply-To: <05e3dm1BROrR_sCq-zzryCP0u5ZKq7mrpEHkpdXZ2pQ=.4b658ebe-9dda-4517-8341-150e9e755828@github.com>
References: <05e3dm1BROrR_sCq-zzryCP0u5ZKq7mrpEHkpdXZ2pQ=.4b658ebe-9dda-4517-8341-150e9e755828@github.com>
Message-ID: <VUi8FBkEEiqqAUtwnfeVeaZtUp9805KuGW_m782elDA=.0a4064da-6ff9-49c7-aacf-17f72bff7390@github.com>

On Tue, 25 Jul 2023 11:39:05 GMT, Ilarion Nakonechnyy <inakonechnyy at openjdk.org> wrote:

> This backport fixes the tier2 test:
> FAILED: java/net/MulticastSocket/JoinLeave.java -- The socket name is not available on this system. (Error setting socket option)
> 
> Changes are applied non-cleanly. 
> Tested on AIX 7.2

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/347#pullrequestreview-1617707204

From andrew at openjdk.org  Fri Sep  8 17:48:48 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 8 Sep 2023 17:48:48 GMT
Subject: [jdk8u] RFR: 8295894: Remove SECOM certificate that is expiring in
 September 2023
In-Reply-To: <AwxRJyAksutoDQ5KkUEL7CASUlUiCuZ_1SN8pdJjwf8=.a1960e0a-a261-4d05-9b37-42b66333f902@github.com>
References: <AwxRJyAksutoDQ5KkUEL7CASUlUiCuZ_1SN8pdJjwf8=.a1960e0a-a261-4d05-9b37-42b66333f902@github.com>
Message-ID: <BFncuAnzKYsRNhk2lqKrY068piUYBRG_dnIgg7AYMQE=.3bdea816-dcf9-4f2e-a416-0986fed23567@github.com>

On Wed, 6 Sep 2023 09:32:37 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Low risk backport of JDK-8295894 which removes an expired certificate from cacerts. It expires in September and we should get it into 8u392. Patch is a clean backport modulo usual path changes to adjust to the 8u layout.
> 
> It's also a dependency so that the backport of JDK-8314960 (Add certigna 2 root CA) applies clean.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts`. Pass, except for `AmazonCA.java` which is being dealt with elsewhere: https://git.openjdk.org/jdk8u-dev/pull/364 and https://git.openjdk.org/jdk8u-dev/pull/365

Backport looks good to me. Approved for 8u392.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/48#pullrequestreview-1617985336

From andrew at openjdk.org  Fri Sep  8 18:15:46 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 8 Sep 2023 18:15:46 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v2]
In-Reply-To: <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
Message-ID: <KZ59pU8lzl5FNrJ4Y6s4pWlqoPqlNM8MQIiM3sOAxAE=.3f3bab48-60f2-43a2-9e28-b823170542eb@github.com>

On Fri, 8 Sep 2023 09:19:02 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

There's already a `jdk_security_infra` so should we not reuse that, either adding `cacerts` to it or including it in `jdk_cacerts`?

Also, why is this not being proposed to trunk first?

On the positive side, the checks show it is working :)

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/368#pullrequestreview-1618031102
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1712054011

From andrew at openjdk.org  Fri Sep  8 18:18:48 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 8 Sep 2023 18:18:48 GMT
Subject: [jdk8u-dev] RFR: 8309088:
 security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
 fails [v3]
In-Reply-To: <Qixqk3NocJQCMFm25TMbRd4RWhGkssf5-AleeAdMyTY=.20e9879b-007c-4c92-a36e-f28b1a5bda5c@github.com>
References: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
 <Qixqk3NocJQCMFm25TMbRd4RWhGkssf5-AleeAdMyTY=.20e9879b-007c-4c92-a36e-f28b1a5bda5c@github.com>
Message-ID: <4SoajU6N0OnbEoO3vRMG-rYDMVGEHmG1yUH0nF97NTk=.d57989da-23b3-45d1-bd83-19db33b90301@github.com>

On Wed, 6 Sep 2023 14:48:05 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport so as to make `AmazonCA.java` test pass again. It fails currently. See the bug for details. Test only, low risk.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3

Patch looks clean. Approved for 8u.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/365#pullrequestreview-1618034602

From sgehwolf at openjdk.org  Mon Sep 11 08:12:49 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:12:49 GMT
Subject: [jdk8u] RFR: 8295894: Remove SECOM certificate that is expiring in
 September 2023
In-Reply-To: <AwxRJyAksutoDQ5KkUEL7CASUlUiCuZ_1SN8pdJjwf8=.a1960e0a-a261-4d05-9b37-42b66333f902@github.com>
References: <AwxRJyAksutoDQ5KkUEL7CASUlUiCuZ_1SN8pdJjwf8=.a1960e0a-a261-4d05-9b37-42b66333f902@github.com>
Message-ID: <knDtnDBp6CfOrkF1vHe4N3dMNbuEbaDbIOBAQUw0S9k=.fd897015-e468-472b-a4db-d99e640e3e9b@github.com>

On Wed, 6 Sep 2023 09:32:37 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Low risk backport of JDK-8295894 which removes an expired certificate from cacerts. It expires in September and we should get it into 8u392. Patch is a clean backport modulo usual path changes to adjust to the 8u layout.
> 
> It's also a dependency so that the backport of JDK-8314960 (Add certigna 2 root CA) applies clean.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts`. Pass, except for `AmazonCA.java` which is being dealt with elsewhere: https://git.openjdk.org/jdk8u-dev/pull/364 and https://git.openjdk.org/jdk8u-dev/pull/365

Thanks for the review!

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/48#issuecomment-1713379460

From sgehwolf at openjdk.org  Mon Sep 11 08:12:50 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:12:50 GMT
Subject: [jdk8u] Integrated: 8295894: Remove SECOM certificate that is expiring
 in September 2023
In-Reply-To: <AwxRJyAksutoDQ5KkUEL7CASUlUiCuZ_1SN8pdJjwf8=.a1960e0a-a261-4d05-9b37-42b66333f902@github.com>
References: <AwxRJyAksutoDQ5KkUEL7CASUlUiCuZ_1SN8pdJjwf8=.a1960e0a-a261-4d05-9b37-42b66333f902@github.com>
Message-ID: <59svM_zIXAiNb-AgBLozNnPGoRavBJdAW1ixJp0JZNQ=.87ae6ed0-61fd-4e4b-8a31-84acc960ea6d@github.com>

On Wed, 6 Sep 2023 09:32:37 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Low risk backport of JDK-8295894 which removes an expired certificate from cacerts. It expires in September and we should get it into 8u392. Patch is a clean backport modulo usual path changes to adjust to the 8u layout.
> 
> It's also a dependency so that the backport of JDK-8314960 (Add certigna 2 root CA) applies clean.
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts`. Pass, except for `AmazonCA.java` which is being dealt with elsewhere: https://git.openjdk.org/jdk8u-dev/pull/364 and https://git.openjdk.org/jdk8u-dev/pull/365

This pull request has now been integrated.

Changeset: e74d29d6
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/e74d29d67429a8059ec168882ee3b540dea67a1f
Stats:     33 lines in 2 files changed: 0 ins; 30 del; 3 mod

8295894: Remove SECOM certificate that is expiring in September 2023

Reviewed-by: andrew
Backport-of: b40b1ca1f6ab606387bb1a466810f0e23dead560

-------------

PR: https://git.openjdk.org/jdk8u/pull/48

From sgehwolf at openjdk.org  Mon Sep 11 08:18:49 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:18:49 GMT
Subject: [jdk8u-dev] RFR: 8309088:
 security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
 fails [v3]
In-Reply-To: <Qixqk3NocJQCMFm25TMbRd4RWhGkssf5-AleeAdMyTY=.20e9879b-007c-4c92-a36e-f28b1a5bda5c@github.com>
References: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
 <Qixqk3NocJQCMFm25TMbRd4RWhGkssf5-AleeAdMyTY=.20e9879b-007c-4c92-a36e-f28b1a5bda5c@github.com>
Message-ID: <GXnIDtes57e-sWwROpCiAqJeKTToCRcZTmQs9HtQFgU=.218cd9a5-8c2f-4d91-b7d0-23e08f998dce@github.com>

On Wed, 6 Sep 2023 14:48:05 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Clean backport so as to make `AmazonCA.java` test pass again. It fails currently. See the bug for details. Test only, low risk.
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Backport 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3

Thanks for the reviews!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/365#issuecomment-1713391209

From sgehwolf at openjdk.org  Mon Sep 11 08:18:51 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:18:51 GMT
Subject: [jdk8u-dev] Integrated: 8309088:
 security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java
 fails
In-Reply-To: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
References: <Ip-fkX1YLGxYfdEyeLmVszu5aqevx9D9UIZBwjYmQS8=.0c03275e-7ad3-4205-a8fa-477fb087d43a@github.com>
Message-ID: <6IKymaHI2zpjvG-lFf8m4YValMGsLSg5tG8BfjNuVik=.2d5ec9b0-5619-4d5e-b490-6cd5dd172f33@github.com>

On Tue, 5 Sep 2023 09:55:36 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Clean backport so as to make `AmazonCA.java` test pass again. It fails currently. See the bug for details. Test only, low risk.

This pull request has now been integrated.

Changeset: c519409d
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c519409d4a3e603f343f60144f44e88d88bb9fb6
Stats:     491 lines in 1 file changed: 142 ins; 30 del; 319 mod

8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails

Reviewed-by: phh, andrew
Backport-of: 4c2e54fb055bee0af5cd838fdd32a0f7902d51e3

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/365

From sgehwolf at openjdk.org  Mon Sep 11 08:19:34 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:19:34 GMT
Subject: [jdk8u] RFR: 8314960: Add Certigna Root CA - 2 [v2]
In-Reply-To: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
References: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
Message-ID: <fwS_lhdTxBizszfecmEvsycP3rNAFSpUA8vFWd5K3J0=.e395a301-cbc7-4bfc-a71f-c03be2d0aa88@github.com>

> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u392 as a critical fix during rampdown. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See #48 
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass except `AmazonCA.java` which is a different matter (it'll be OK again once JDK-8309088 is in as well).

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u/pull/49/files
  - new: https://git.openjdk.org/jdk8u/pull/49/files/c8e4d168..c8e4d168

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u&pr=49&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u&pr=49&range=00-01

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u/pull/49.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/49/head:pull/49

PR: https://git.openjdk.org/jdk8u/pull/49

From sgehwolf at openjdk.org  Mon Sep 11 08:21:16 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:21:16 GMT
Subject: [jdk8u] RFR: 8314960: Add Certigna Root CA - 2 [v3]
In-Reply-To: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
References: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
Message-ID: <WOOdrVsgF1rxecaoPd3EVKDlV-0SZMaRAk9SiJsxejQ=.29f1a165-a894-48f3-995f-ddb6281e63e7@github.com>

> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u392 as a critical fix during rampdown. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See #48 
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass except `AmazonCA.java` which is a different matter (it'll be OK again once JDK-8309088 is in as well).

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport a44f8b059847135ecd0618cb04abbb0d2be1d2d0

-------------

Changes: https://git.openjdk.org/jdk8u/pull/49/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=49&range=02
  Stats: 568 lines in 4 files changed: 338 ins; 227 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u/pull/49.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/49/head:pull/49

PR: https://git.openjdk.org/jdk8u/pull/49

From sgehwolf at openjdk.org  Mon Sep 11 08:46:03 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:46:03 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v3]
In-Reply-To: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
Message-ID: <BqzskWTlflVl7VtferNcBLbvUoliL2EBnJsMRlJtVLs=.74f5c9f3-4b02-4f97-b71e-9b524087ebba@github.com>

> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
> 
> Testing:
>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:

 - Move to jdk_security_infra and add to tier1
 - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/368/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=368&range=02
  Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/368.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/368/head:pull/368

PR: https://git.openjdk.org/jdk8u-dev/pull/368

From sgehwolf at openjdk.org  Mon Sep 11 08:53:46 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 08:53:46 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v2]
In-Reply-To: <KZ59pU8lzl5FNrJ4Y6s4pWlqoPqlNM8MQIiM3sOAxAE=.3f3bab48-60f2-43a2-9e28-b823170542eb@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
 <KZ59pU8lzl5FNrJ4Y6s4pWlqoPqlNM8MQIiM3sOAxAE=.3f3bab48-60f2-43a2-9e28-b823170542eb@github.com>
Message-ID: <p8A5t5VzGB2AX2jW67EC83PPvrcMdh9zjkGSl8eQSE4=.e27a8ad5-42ec-4616-9eaa-79d7a2897425@github.com>

On Fri, 8 Sep 2023 18:12:48 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> There's already a `jdk_security_infra` so should we not reuse that, either adding `cacerts` to it or including it in `jdk_cacerts`?

Good catch. I've added it to `jdk_security_infra`.

> Also, why is this not being proposed to trunk first?

`VerifyCACerts.java` is part of `tier2` in JDK head by means of `jdk_security => jdk_security_3 => sun/security`. `jdk_security_infra` is not part of any group yet, which I assume has a reason. Probably, because those tests depend on what CAs do (external factors?). The situation in 8u is a bit different to later JDKs, IMO. It's more like GHA being the best option for the early heads-up in 8u as later tiers aren't being run publicly. I have no strong opinion about this, but I lack the relevant cycles in order to push this upstream at this point. Feel free to go ahead and propose it though.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1713452763

From andrew at openjdk.org  Mon Sep 11 16:22:47 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 11 Sep 2023 16:22:47 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v2]
In-Reply-To: <p8A5t5VzGB2AX2jW67EC83PPvrcMdh9zjkGSl8eQSE4=.e27a8ad5-42ec-4616-9eaa-79d7a2897425@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
 <KZ59pU8lzl5FNrJ4Y6s4pWlqoPqlNM8MQIiM3sOAxAE=.3f3bab48-60f2-43a2-9e28-b823170542eb@github.com>
 <p8A5t5VzGB2AX2jW67EC83PPvrcMdh9zjkGSl8eQSE4=.e27a8ad5-42ec-4616-9eaa-79d7a2897425@github.com>
Message-ID: <IgPxMNBA1a4mfbmHzrQKuVmLt7wFxSI4yVWO019N2_c=.5f00e963-5831-4ce8-bd9d-a06b9ff88fbf@github.com>

On Mon, 11 Sep 2023 08:51:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > There's already a `jdk_security_infra` so should we not reuse that, either adding `cacerts` to it or including it in `jdk_cacerts`?
> 
> Good catch. I've added it to `jdk_security_infra`.

It looks like it was added by [JDK-8189131](https://bugs.openjdk.org/browse/JDK-8189131) but that didn't add it to any tier. It does seem worth investigating if this was just an oversight or intentional.

> 
> > Also, why is this not being proposed to trunk first?
> 
> `VerifyCACerts.java` is part of `tier2` in JDK head by means of `jdk_security => jdk_security_3 => sun/security`. `jdk_security_infra` is not part of any group yet, which I assume has a reason. Probably, because those tests depend on what CAs do (external factors?). The situation in 8u is a bit different to later JDKs, IMO. It's more like GHA being the best option for the early heads-up in 8u as later tiers aren't being run publicly. I have no strong opinion about this, but I lack the relevant cycles in order to push this upstream at this point. Feel free to go ahead and propose it though.

Ah ok, I hadn't realised 8u was running a smaller test set than later JDKs. I'm guessing later tiers don't pass? Given the `cacerts` part is a 8u-only omission, I'm happy for this to go in as is.

I think the infra story is worth pursuing upstream. I've no issue with adding them like this to 8u for now, under this ticket, so we have tests running in some form. However, we may need to adjust further, depending on the decision upstream.

Do you know if the GHA tests will now pass? If not, is there a PR waiting that will make that happen? I'm happy to push this once GHA passes.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1714204283

From sgehwolf at openjdk.org  Mon Sep 11 16:43:40 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 11 Sep 2023 16:43:40 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v2]
In-Reply-To: <IgPxMNBA1a4mfbmHzrQKuVmLt7wFxSI4yVWO019N2_c=.5f00e963-5831-4ce8-bd9d-a06b9ff88fbf@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
 <KZ59pU8lzl5FNrJ4Y6s4pWlqoPqlNM8MQIiM3sOAxAE=.3f3bab48-60f2-43a2-9e28-b823170542eb@github.com>
 <p8A5t5VzGB2AX2jW67EC83PPvrcMdh9zjkGSl8eQSE4=.e27a8ad5-42ec-4616-9eaa-79d7a2897425@github.com>
 <IgPxMNBA1a4mfbmHzrQKuVmLt7wFxSI4yVWO019N2_c=.5f00e963-5831-4ce8-bd9d-a06b9ff88fbf@github.com>
Message-ID: <pGfZzzaMRFdr21iSa-GXCHw58iB_NnJwP2PA8RU6Cd4=.237c5588-c3aa-489b-ad56-5cdc7dd87001@github.com>

On Mon, 11 Sep 2023 16:20:31 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Do you know if the GHA tests will now pass? If not, is there a PR waiting that will make that happen? I'm happy to push this once GHA passes.

It should pass once jdk8u merges with jdk8u-dev as we need JDK-8295894 in jdk8u-dev for this to be clean.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1714234492

From sgehwolf at openjdk.org  Tue Sep 12 15:34:45 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 12 Sep 2023 15:34:45 GMT
Subject: [jdk8u] RFR: 8314960: Add Certigna Root CA - 2 [v3]
In-Reply-To: <WOOdrVsgF1rxecaoPd3EVKDlV-0SZMaRAk9SiJsxejQ=.29f1a165-a894-48f3-995f-ddb6281e63e7@github.com>
References: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
 <WOOdrVsgF1rxecaoPd3EVKDlV-0SZMaRAk9SiJsxejQ=.29f1a165-a894-48f3-995f-ddb6281e63e7@github.com>
Message-ID: <KeGPWg7BxUF4bvqmrcZspB3WF2isp5LEuQTmrmV9TgQ=.b576a3b2-15aa-4843-b435-c5c9b30bf43c@github.com>

On Mon, 11 Sep 2023 08:21:16 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u392 as a critical fix during rampdown. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See #48 
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass except `AmazonCA.java` which is a different matter (it'll be OK again once JDK-8309088 is in as well).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport a44f8b059847135ecd0618cb04abbb0d2be1d2d0

@gnu-andrew Ready for you to review, please!

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/49#issuecomment-1715952555

From mbalao at openjdk.org  Thu Sep 14 18:39:10 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 14 Sep 2023 18:39:10 GMT
Subject: [jdk8u-dev] RFR: 8209115: adjust libsplashscreen linux ppc64le builds
 for easier libpng update
Message-ID: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>

The 11u patch does not apply cleanly because of the file paths and because the context for the change in jdk/make/lib/Awt2dLibraries.gmk is slightly different.

-------------

Commit messages:
 - Backport e4fdd0391733756f5b898371a66b38869d625c77

Changes: https://git.openjdk.org/jdk8u-dev/pull/371/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=371&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8209115
  Stats: 9 lines in 2 files changed: 6 ins; 3 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/371.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/371/head:pull/371

PR: https://git.openjdk.org/jdk8u-dev/pull/371

From mbalao at openjdk.org  Thu Sep 14 20:36:07 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 14 Sep 2023 20:36:07 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38
Message-ID: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>

Hi all,

This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.

This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).

This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.

Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.

Thanks!

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/371

Commit messages:
 - Backport d183dc25f7360c3012726acf8c03874df6fc41a4

Changes: https://git.openjdk.org/jdk8u-dev/pull/372/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=372&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8295685
  Stats: 624 lines in 22 files changed: 444 ins; 33 del; 147 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/372.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/372/head:pull/372

PR: https://git.openjdk.org/jdk8u-dev/pull/372

From mbalao at openjdk.org  Thu Sep 14 20:51:09 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 14 Sep 2023 20:51:09 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39
Message-ID: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>

Hi all,

This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.

This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).

This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.

Thanks!

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/372

Commit messages:
 - Backport c1f759e9d01d646eac69442452151b0467eab306

Changes: https://git.openjdk.org/jdk8u-dev/pull/373/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=373&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8305815
  Stats: 129 lines in 17 files changed: 29 ins; 8 del; 92 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/373.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/373/head:pull/373

PR: https://git.openjdk.org/jdk8u-dev/pull/373

From andrew at openjdk.org  Fri Sep 15 03:00:46 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 15 Sep 2023 03:00:46 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v2]
In-Reply-To: <pGfZzzaMRFdr21iSa-GXCHw58iB_NnJwP2PA8RU6Cd4=.237c5588-c3aa-489b-ad56-5cdc7dd87001@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <bLrUR6zSAh2cGMeL43uEsLOipyBM-W-16UDF8-vuXf8=.6b2701a1-7782-4f6a-9d02-7612bceaa761@github.com>
 <KZ59pU8lzl5FNrJ4Y6s4pWlqoPqlNM8MQIiM3sOAxAE=.3f3bab48-60f2-43a2-9e28-b823170542eb@github.com>
 <p8A5t5VzGB2AX2jW67EC83PPvrcMdh9zjkGSl8eQSE4=.e27a8ad5-42ec-4616-9eaa-79d7a2897425@github.com>
 <IgPxMNBA1a4mfbmHzrQKuVmLt7wFxSI4yVWO019N2_c=.5f00e963-5831-4ce8-bd9d-a06b9ff88fbf@github.com>
 <pGfZzzaMRFdr21iSa-GXCHw58iB_NnJwP2PA8RU6Cd4=.237c5588-c3aa-489b-ad56-5cdc7dd87001@github.com>
Message-ID: <pFXDNx1Wmwon3DtkVG-hidXS2OuhTUoDTXE1Iat4B-Q=.a2db7a06-f77c-44f2-86fe-8e4a4048a8b0@github.com>

On Mon, 11 Sep 2023 16:40:48 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > Do you know if the GHA tests will now pass? If not, is there a PR waiting that will make that happen? I'm happy to push this once GHA passes.
> 
> It should pass once jdk8u merges with jdk8u-dev as we need JDK-8295894 in jdk8u-dev for this to be clean.

Ok that one's on me then. I'll get that merged and then you can merge this PR with the merged 8u-dev HEAD and run the tests.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1720415367

From andrew at openjdk.org  Fri Sep 15 03:02:42 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 15 Sep 2023 03:02:42 GMT
Subject: [jdk8u-dev] RFR: 8209115: adjust libsplashscreen linux ppc64le
 builds for easier libpng update
In-Reply-To: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
References: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
Message-ID: <nhXh-vFASVNHC3zRCcqYaLoQ3ctOMhjeAh6P1JkdVIo=.3a26bfb3-a895-405b-8a8f-cc1bf6d674ec@github.com>

On Thu, 14 Sep 2023 18:31:14 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> The 11u patch does not apply cleanly because of the file paths and because the context for the change in jdk/make/lib/Awt2dLibraries.gmk is slightly different.

Backport looks good to me (clean bar a little context difference). Please add the `jdk8u-fix-request` label to the bug for approval.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/371#pullrequestreview-1628122178

From andrew at openjdk.org  Fri Sep 15 03:11:43 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 15 Sep 2023 03:11:43 GMT
Subject: [jdk8u-dev] RFR: 8209115: adjust libsplashscreen linux ppc64le
 builds for easier libpng update
In-Reply-To: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
References: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
Message-ID: <QCmL4ImqltNoDGz4-KuRkIbFRLFgM_HxXs9IJmStjow=.1b57ff01-ff8a-48b0-a062-966025e980cc@github.com>

On Thu, 14 Sep 2023 18:31:14 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> The 11u patch does not apply cleanly because of the file paths and because the context for the change in jdk/make/lib/Awt2dLibraries.gmk is slightly different.

The situation here is a bit ugly. JDK-8195615 is not listed as being in 8u, but it seems it was silently included in JDK-8208353 ("Upgrade JDK 8u to libpng 1.6.35").  This is the version of libpng that adds PPC and x86 optimisations to the library. Prior to that, there were only ones for ARM (see the `-DPNG_ARM_NEON_OPT=0` in the context) and MIPS.

The reason this is problematic in OpenJDK seems to be because the sources don't include the subdirectories with this optimised code. It isn't a problem on x86 because SSE has to be explicitly enabled, but it is enabled on PPC, so we have to force it back off.

The Makefile logic for libpng upstream looks like this:

~~~
if PNG_ARM_NEON
libpng at PNGLIB_MAJOR@@PNGLIB_MINOR at _la_SOURCES += arm/arm_init.c\
        arm/filter_neon.S arm/filter_neon_intrinsics.c \
        arm/palette_neon_intrinsics.c
endif

if PNG_MIPS_MSA
libpng at PNGLIB_MAJOR@@PNGLIB_MINOR at _la_SOURCES += mips/mips_init.c\
        mips/filter_msa_intrinsics.c
endif

if PNG_INTEL_SSE
libpng at PNGLIB_MAJOR@@PNGLIB_MINOR at _la_SOURCES += intel/intel_init.c\
        intel/filter_sse2_intrinsics.c
endif

if PNG_POWERPC_VSX
libpng at PNGLIB_MAJOR@@PNGLIB_MINOR at _la_SOURCES += powerpc/powerpc_init.c\
        powerpc/filter_vsx_intrinsics.c
endif
~~~

OpenJDK doesn't have any of these files in the subdirectories. It is `filter_vsx_intrinsics.c` that contains the missing `png_init_filter_functions_vsx` that triggered JDK-8195615.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/371#issuecomment-1720421188

From evergizova at openjdk.org  Fri Sep 15 12:59:45 2023
From: evergizova at openjdk.org (Ekaterina Vergizova)
Date: Fri, 15 Sep 2023 12:59:45 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38
In-Reply-To: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
Message-ID: <sPVVC57mekMO9-D2cy5wB7jognu_d9XpS8bYBlJgp-8=.47b37314-af66-4a8f-b6d9-d8f8ed51b350@github.com>

On Thu, 14 Sep 2023 20:27:03 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
> 
> Thanks!

The changes look good to me, although I'm not a reviewer.
But maybe it's better not to transfer .md syntax like ### and ``` into plain THIRD_PARTY_README files?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/372#issuecomment-1721239913

From andrew at openjdk.org  Fri Sep 15 15:47:47 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 15 Sep 2023 15:47:47 GMT
Subject: [jdk8u] RFR: 8314960: Add Certigna Root CA - 2 [v3]
In-Reply-To: <WOOdrVsgF1rxecaoPd3EVKDlV-0SZMaRAk9SiJsxejQ=.29f1a165-a894-48f3-995f-ddb6281e63e7@github.com>
References: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
 <WOOdrVsgF1rxecaoPd3EVKDlV-0SZMaRAk9SiJsxejQ=.29f1a165-a894-48f3-995f-ddb6281e63e7@github.com>
Message-ID: <dogM41AuZ6uf4khTTeWLHg6hnZ6dHslXDL38v_HLpYc=.22c6bc22-e3c5-4fed-b9fd-149e7ef5e0c8@github.com>

On Mon, 11 Sep 2023 08:21:16 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u392 as a critical fix during rampdown. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See #48 
>> 
>> Testing:
>> - [x] GHA
>> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass except `AmazonCA.java` which is a different matter (it'll be OK again once JDK-8309088 is in as well).
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Backport a44f8b059847135ecd0618cb04abbb0d2be1d2d0

Patch looks clean. Approved for 8u392.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/49#pullrequestreview-1629263630

From phh at openjdk.org  Fri Sep 15 17:19:46 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 15 Sep 2023 17:19:46 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39
In-Reply-To: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
Message-ID: <e81RLg7WSLgoCxy22zUeAgc_Ew6TcWE4nHl0W8j_8Vg=.05513495-8d13-4ec5-b3b1-2070e60d2669@github.com>

On Thu, 14 Sep 2023 20:44:35 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Thanks!

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/373#pullrequestreview-1629409755

From phh at openjdk.org  Fri Sep 15 19:25:44 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 15 Sep 2023 19:25:44 GMT
Subject: [jdk8u-dev] RFR: 8209115: adjust libsplashscreen linux ppc64le
 builds for easier libpng update
In-Reply-To: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
References: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
Message-ID: <25xeMbVQ6GVopINaQFsLvl7rWavRXNleJy3DqfQl8-I=.880da5a5-6a89-4d1d-97e4-af8cee5e82de@github.com>

On Thu, 14 Sep 2023 18:31:14 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> The 11u patch does not apply cleanly because of the file paths and because the context for the change in jdk/make/lib/Awt2dLibraries.gmk is slightly different.

Marked as reviewed by phh (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/371#pullrequestreview-1629580459

From mbalao at openjdk.org  Fri Sep 15 19:49:45 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Fri, 15 Sep 2023 19:49:45 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38
In-Reply-To: <sPVVC57mekMO9-D2cy5wB7jognu_d9XpS8bYBlJgp-8=.47b37314-af66-4a8f-b6d9-d8f8ed51b350@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
 <sPVVC57mekMO9-D2cy5wB7jognu_d9XpS8bYBlJgp-8=.47b37314-af66-4a8f-b6d9-d8f8ed51b350@github.com>
Message-ID: <QLIWjPf0DbF6DIW_hH0MCqPn-_P3C5kswUizshnykwY=.ff7015b2-3278-4f96-9a67-d12cb826f565@github.com>

On Fri, 15 Sep 2023 12:57:08 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
>> 
>> Thanks!
>
> The changes look good to me, although I'm not a reviewer.
> But maybe it's better not to transfer .md syntax like ### and ``` into plain THIRD_PARTY_README files?

Hi @kvergizova ,

Thanks for having a look. You're right. The markdown syntax does not belong to the original libpng file, and there is no gain in keeping it because 11u-dev changes will not apply cleanly anyways (it's different files). I'll fix it and rebase PR 373.

Martin.-

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/372#issuecomment-1721760649

From mbalao at openjdk.org  Fri Sep 15 20:01:11 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Fri, 15 Sep 2023 20:01:11 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38 [v2]
In-Reply-To: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
Message-ID: <EfRwllmry3e8gWsWsiTHqe8xIKTJwz1K73EH0brNkNo=.0edc5deb-d650-4b87-8c42-78f4a3ce0249@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
> 
> Thanks!

Martin Balao has updated the pull request incrementally with one additional commit since the last revision:

  Removal of the markdown syntax as it's not in the original libpng AUTHORS file.

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/372/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/372/files/85094a60..3fa3cfaf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=372&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=372&range=00-01

  Stats: 24 lines in 8 files changed: 0 ins; 8 del; 16 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/372.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/372/head:pull/372

PR: https://git.openjdk.org/jdk8u-dev/pull/372

From mbalao at openjdk.org  Fri Sep 15 20:12:03 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Fri, 15 Sep 2023 20:12:03 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39 [v2]
In-Reply-To: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
Message-ID: <7Jfs9rXOLkMH1OhoPrkFKWVdvq3WbyFYHoIdk1kTB4A=.3d06afcc-c453-436e-9cfb-31bf33d081bf@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Thanks!

Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport c1f759e9d01d646eac69442452151b0467eab306

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/373/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=373&range=01
  Stats: 129 lines in 17 files changed: 29 ins; 8 del; 92 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/373.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/373/head:pull/373

PR: https://git.openjdk.org/jdk8u-dev/pull/373

From mbalao at openjdk.org  Fri Sep 15 20:12:03 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Fri, 15 Sep 2023 20:12:03 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39 [v2]
In-Reply-To: <e81RLg7WSLgoCxy22zUeAgc_Ew6TcWE4nHl0W8j_8Vg=.05513495-8d13-4ec5-b3b1-2070e60d2669@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
 <e81RLg7WSLgoCxy22zUeAgc_Ew6TcWE4nHl0W8j_8Vg=.05513495-8d13-4ec5-b3b1-2070e60d2669@github.com>
Message-ID: <Y7-XHe-Rfb6cEWqpy3soN2095I_zkcM2mrbvmd-Yr_E=.c0b8bb20-8aa7-4fbf-874a-df33c7877502@github.com>

On Fri, 15 Sep 2023 17:16:50 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   Backport c1f759e9d01d646eac69442452151b0467eab306
>
> Marked as reviewed by phh (Reviewer).

Thanks @phohensee for your review. I had to rebase after https://github.com/openjdk/jdk8u-dev/pull/372/commits/3fa3cfaf04acf444b55957fec1e82f8994360e57 in PR 372. Nothing was changed as part of this.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/373#issuecomment-1721790366

From sgehwolf at openjdk.org  Mon Sep 18 09:09:57 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 18 Sep 2023 09:09:57 GMT
Subject: [jdk8u] Integrated: 8314960: Add Certigna Root CA - 2
In-Reply-To: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
References: <odCcTQVXN3CaAJeUJgxAPv8QgZ00kLxzUxIeBHFgV48=.75f55be1-2d73-47bf-84a0-8d9c27081bc2@github.com>
Message-ID: <Mlyn-mIh-DN7mkz2UiqMnl_bsh_eAPzReTFjvIXL5qg=.081717bf-8b6e-41d0-8b90-051e04f0fba8@github.com>

On Wed, 6 Sep 2023 10:27:03 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Backport of JDK-8314960 to add new certigna root 2 certificate to OpenJDK 8u392 as a critical fix during rampdown. Patch applies cleanly after path shuffling and backporting [JDK-8295894](https://bugs.openjdk.org/browse/JDK-8295894). See #48 
> 
> Testing:
> - [x] GHA
> - [x] `jdk/test/security/infra/java/security/cert/CertPathValidator` and  `jdk/test/sun/security/lib/cacerts` jtreg tests. All pass except `AmazonCA.java` which is a different matter (it'll be OK again once JDK-8309088 is in as well).

This pull request has now been integrated.

Changeset: b24b03f9
Author:    Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u/commit/b24b03f9dbeb2c1e8b5cb0279659eee489bd9df4
Stats:     568 lines in 4 files changed: 338 ins; 227 del; 3 mod

8314960: Add Certigna Root CA - 2

Reviewed-by: andrew
Backport-of: a44f8b059847135ecd0618cb04abbb0d2be1d2d0

-------------

PR: https://git.openjdk.org/jdk8u/pull/49

From duke at openjdk.org  Mon Sep 18 11:13:49 2023
From: duke at openjdk.org (duke)
Date: Mon, 18 Sep 2023 11:13:49 GMT
Subject: [jdk8u-dev] Withdrawn: 8300939:
 sun/security/provider/certpath/OCSP/OCSPNoContentLength.java fails due to
 network errors
In-Reply-To: <8UMMFqO6YtZ4zrh7iCzjdWVpD7xjNUk_oUWmb8D32UQ=.924222f9-249c-4a40-a15d-bf680a2c9925@github.com>
References: <8UMMFqO6YtZ4zrh7iCzjdWVpD7xjNUk_oUWmb8D32UQ=.924222f9-249c-4a40-a15d-bf680a2c9925@github.com>
Message-ID: <bV1Ke2LbxpcAEyuBLByd9Ve-taqXLRwfNKEpZdwVTCg=.a3deba95-4b7e-48b2-8cbe-e9775b011fbe@github.com>

On Wed, 7 Jun 2023 18:28:23 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is backport of [JDK-8300939](https://bugs.openjdk.org/browse/JDK-8300939) fixing `sun/security/provider/certpath/OCSP/OCSPNoContentLength.java` test. The patch from `11u` applied cleanly except the path shuffling
> 
> Verification/regression (amd64/LTS20.04): `jdk_security`

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/333

From duke at openjdk.org  Mon Sep 18 11:14:49 2023
From: duke at openjdk.org (duke)
Date: Mon, 18 Sep 2023 11:14:49 GMT
Subject: [jdk8u-dev] Withdrawn: 8296343: CPVE thrown on missing content-length
 in OCSP response
In-Reply-To: <uaB82QwS7dzonrEJ6hW3GIGvCvvFXPKiK2J0W7ZQhgI=.95b0af6c-a775-4602-a93d-01011599e73b@github.com>
References: <uaB82QwS7dzonrEJ6hW3GIGvCvvFXPKiK2J0W7ZQhgI=.95b0af6c-a775-4602-a93d-01011599e73b@github.com>
Message-ID: <TW7clYC_xzDpJNxfCrdL2IBbgGP8C7PeHRkBmymDfFU=.d35f1552-bef3-4403-9c75-6936b639d435@github.com>

On Wed, 7 Jun 2023 10:17:57 GMT, Alexey Pavlyutkin <duke at openjdk.org> wrote:

> Hi!
> 
> Here is backport of **[JDK-8296343: CPVE thrown on missing content-length in OCSP response](https://bugs.openjdk.org/browse/JDK-8296343)**. The patch from `11u` applied with the following changes (except the path shuflling):
> 
> **`jdk/src/java.base/share/classes/sun/security/provider/certpath/OCSP.java`**
> - reading response content from the input stream reworked due to `InputStream.readAllBytes()` and `IOUtils.readExactlyNBytes()` are not available in `8`
> 
> **`jdk/test/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java`**
> - unsupported `List.of()` and `Set.of()` replaced with equivalent code
> - added a newline at the end of the file
> 
> Verification (amd64/20.04): newly added `test/jdk/sun/security/provider/certpath/OCSP/OCSPNoContentLength.java` **FAILS**, will be fixed by backporting of [JDK-8300939](https://bugs.openjdk.org/browse/JDK-8300939)
> Regression (amd64/20.04): `jdk_security`

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/332

From andrew at openjdk.org  Tue Sep 19 01:18:43 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 19 Sep 2023 01:18:43 GMT
Subject: [jdk8u-dev] RFR: 8307837: [8u] Check step in GHA should also print
 errors
In-Reply-To: <HUXB-aMOEbR5mbuDg3hMnyPeCSfzkC-kfkUZykLSubw=.24b77963-6e03-4c5b-ba36-6fb863620765@github.com>
References: <HUXB-aMOEbR5mbuDg3hMnyPeCSfzkC-kfkUZykLSubw=.24b77963-6e03-4c5b-ba36-6fb863620765@github.com>
Message-ID: <c0dWf59m1oB6DfF369DnBG6jQmelGjqG2gmtdXU7nME=.e4a4617c-6ec9-4dc3-84ef-bdd21a44c7f3@github.com>

On Wed, 10 May 2023 15:25:28 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Check step currently only prints list of failed tests. It should also print tests, which finished with error (e.g. test ending on timeout). See e.g.: https://github.com/naotoj/jdk8u-dev/actions/runs/4931190096/jobs/8813500528

Changes look fine, though the referenced link has expired.

Any way we can test this work as expected?

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/317#pullrequestreview-1632235119

From andrew at openjdk.org  Tue Sep 19 01:19:43 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 19 Sep 2023 01:19:43 GMT
Subject: [jdk8u-dev] RFR: 8209115: adjust libsplashscreen linux ppc64le
 builds for easier libpng update
In-Reply-To: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
References: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
Message-ID: <JuYl3N0kCAobbrYmZci8N4MkwlBF_mlsD553mcyMX1U=.247751a4-3701-48a8-8ff0-ca82d253be70@github.com>

On Thu, 14 Sep 2023 18:31:14 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> The 11u patch does not apply cleanly because of the file paths and because the context for the change in jdk/make/lib/Awt2dLibraries.gmk is slightly different.

Thanks. Approved.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/371#issuecomment-1724690354

From mbalao at openjdk.org  Tue Sep 19 01:38:49 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 19 Sep 2023 01:38:49 GMT
Subject: [jdk8u-dev] Integrated: 8209115: adjust libsplashscreen linux ppc64le
 builds for easier libpng update
In-Reply-To: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
References: <ocHLohFgvqRUHECc06V3TnB_ZfJAyr1rWkZpSxmOnfE=.6051e27d-d05d-42bc-9a8e-8115de97c600@github.com>
Message-ID: <1la8fT9txK7B_D4L-cLHyEUX8j8Pcc0VZRVpfpN6Kd4=.6ed50279-8d55-4d97-aa52-41e0174ad80e@github.com>

On Thu, 14 Sep 2023 18:31:14 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> The 11u patch does not apply cleanly because of the file paths and because the context for the change in jdk/make/lib/Awt2dLibraries.gmk is slightly different.

This pull request has now been integrated.

Changeset: 50069a8d
Author:    Martin Balao <mbalao at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/50069a8dbccf07fcd412ac394a33be0afc97257e
Stats:     9 lines in 2 files changed: 6 ins; 3 del; 0 mod

8209115: adjust libsplashscreen linux ppc64le builds for easier libpng update

Reviewed-by: andrew, phh
Backport-of: e4fdd0391733756f5b898371a66b38869d625c77

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/371

From andrew at openjdk.org  Tue Sep 19 01:41:45 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 19 Sep 2023 01:41:45 GMT
Subject: [jdk8u-dev] RFR: 8029995: accept yes/no for boolean krb5.conf
 settings
In-Reply-To: <7M8VUgALHVYnX5W0Iz7LMABFYGima_NuUgowTz5nSnk=.4884c35a-5118-4d18-863b-43d4533c8450@github.com>
References: <7M8VUgALHVYnX5W0Iz7LMABFYGima_NuUgowTz5nSnk=.4884c35a-5118-4d18-863b-43d4533c8450@github.com>
Message-ID: <4SgxJnGj3WJ_U9S_s865Y_cNl0CJK2D_yiY3IwE8PZ8=.6046a084-f853-4553-ae93-ab718f491d41@github.com>

On Tue, 5 Sep 2023 23:44:06 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This fix solves regression caused by JDK-8139348 and found by the test suite of 3rd party library.
> The fix allows to use "yes" and "no" values in the krb5.conf file. It is important because sometimes krb5.conf is autogenerated and uses "yes"/"no" values inside.
> The backport is almost clean except of the Config.java file. Config.java already has some changes applied as part of JDK-8077102
> sun/security/krb5 jtreg tests passed

Yes, seems like we already partially have this fix because of the way JDK-8077102 was backported. It makes sense to bring `useAddresses` into line with this and get rid of `getBooleanValue` rather than having a different method for each boolean property.

Backport looks good. Please add `jdk8u-fix-request` and an appropriate comment to the bug to request approval.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/367#pullrequestreview-1632253916

From mbalao at openjdk.org  Tue Sep 19 01:55:32 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 19 Sep 2023 01:55:32 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38 [v3]
In-Reply-To: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
Message-ID: <zZz8V6djGaC0Fa8CCYPRRn-pl018aj0nR22zgHIXGP8=.7bf1943a-4f7a-4fd9-8e70-6595a21ffe01@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
> 
> Thanks!

Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:

 - Merge branch 'JDK-8295685' of https://github.com/martinuy/jdk8u-dev into JDK-8295685
 - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
 - Backport d183dc25f7360c3012726acf8c03874df6fc41a4
 - Backport e4fdd0391733756f5b898371a66b38869d625c77
 - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
 - Backport d183dc25f7360c3012726acf8c03874df6fc41a4

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/372/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/372/files/3fa3cfaf..76485d11

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=372&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=372&range=01-02

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/372.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/372/head:pull/372

PR: https://git.openjdk.org/jdk8u-dev/pull/372

From mbalao at openjdk.org  Tue Sep 19 02:12:43 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 19 Sep 2023 02:12:43 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38 [v4]
In-Reply-To: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
Message-ID: <1GKH0pcBWL44u2nZDnHN2atX2MOxZ-zbwMwsFd4X1YE=.f961836f-4d43-4432-ab40-488e295222ab@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
> 
> Thanks!

Martin Balao has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits:

 - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
 - Backport d183dc25f7360c3012726acf8c03874df6fc41a4

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/372/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/372/files/76485d11..a08562f1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=372&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=372&range=02-03

  Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/372.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/372/head:pull/372

PR: https://git.openjdk.org/jdk8u-dev/pull/372

From andrew at openjdk.org  Tue Sep 19 02:12:43 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 19 Sep 2023 02:12:43 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38 [v4]
In-Reply-To: <1GKH0pcBWL44u2nZDnHN2atX2MOxZ-zbwMwsFd4X1YE=.f961836f-4d43-4432-ab40-488e295222ab@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
 <1GKH0pcBWL44u2nZDnHN2atX2MOxZ-zbwMwsFd4X1YE=.f961836f-4d43-4432-ab40-488e295222ab@github.com>
Message-ID: <AKTNebI8rqm-Oi3v_p41nKoMD0J-Q_Z54yFmwxgjbO0=.bff59635-51a1-4b1c-a1a9-711ef069cb28@github.com>

On Tue, 19 Sep 2023 02:07:04 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
>> 
>> Thanks!
>
> Martin Balao has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits:
> 
>  - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
>  - Backport d183dc25f7360c3012726acf8c03874df6fc41a4

Backport looks good to me. Good catch on the markdown. Please request approval with the `jdk8u-fix-request` label and an appropriate comment on the bug.

I thought we'd removed the duplicate `README` files but it appears not. Maybe worth proposing after these PRs are in.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/372#pullrequestreview-1632278866

From mbalao at openjdk.org  Tue Sep 19 02:12:46 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 19 Sep 2023 02:12:46 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38 [v3]
In-Reply-To: <zZz8V6djGaC0Fa8CCYPRRn-pl018aj0nR22zgHIXGP8=.7bf1943a-4f7a-4fd9-8e70-6595a21ffe01@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
 <zZz8V6djGaC0Fa8CCYPRRn-pl018aj0nR22zgHIXGP8=.7bf1943a-4f7a-4fd9-8e70-6595a21ffe01@github.com>
Message-ID: <0Fr4reko98GSioTg5og1AwOI3tVrxGzz4Ttls0fIdEE=.8c9ca25b-81f0-4f21-9a71-4b79e70f7a67@github.com>

On Tue, 19 Sep 2023 01:55:32 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
>> 
>> Thanks!
>
> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'JDK-8295685' of https://github.com/martinuy/jdk8u-dev into JDK-8295685
>  - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
>  - Backport d183dc25f7360c3012726acf8c03874df6fc41a4
>  - Backport e4fdd0391733756f5b898371a66b38869d625c77
>  - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
>  - Backport d183dc25f7360c3012726acf8c03874df6fc41a4

Sorry for the noise, I intended to rebase and somehow a merge sneaked into. The history is clean now.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/372#issuecomment-1724725342

From andrew at openjdk.org  Tue Sep 19 02:12:45 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 19 Sep 2023 02:12:45 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38 [v3]
In-Reply-To: <zZz8V6djGaC0Fa8CCYPRRn-pl018aj0nR22zgHIXGP8=.7bf1943a-4f7a-4fd9-8e70-6595a21ffe01@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
 <zZz8V6djGaC0Fa8CCYPRRn-pl018aj0nR22zgHIXGP8=.7bf1943a-4f7a-4fd9-8e70-6595a21ffe01@github.com>
Message-ID: <mrHBteRdvlUfnnOmqoL7gEPlisx2M7iF5cxwlcMR-xc=.90dcb0dc-e6ee-43e5-afd8-b94b3cedfcf5@github.com>

On Tue, 19 Sep 2023 01:55:32 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
>> 
>> Thanks!
>
> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
> 
>  - Merge branch 'JDK-8295685' of https://github.com/martinuy/jdk8u-dev into JDK-8295685
>  - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
>  - Backport d183dc25f7360c3012726acf8c03874df6fc41a4
>  - Backport e4fdd0391733756f5b898371a66b38869d625c77
>  - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
>  - Backport d183dc25f7360c3012726acf8c03874df6fc41a4

Rebasing was the right thing for a dependent PR. The bot whines regardless, and the list of commits was a mess with the merge.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/372#issuecomment-1724724017

From jianyesun at openjdk.org  Tue Sep 19 02:26:04 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 02:26:04 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
Message-ID: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>

Hi~,  as reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
The key problem is this way of using: 

size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  

The return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it's should be a type of size_t. 
Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
We found  [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) can sovle it, so please let's do backport it. We also added a test case.
Thanks.

-------------

Commit messages:
 - Backport-6899049 G1: Clean up code in ptrQueue.[ch]pp and ptrQueue.inline.hpp

Changes: https://git.openjdk.org/jdk8u/pull/50/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=50&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8316278
  Stats: 243 lines in 7 files changed: 133 ins; 42 del; 68 mod
  Patch: https://git.openjdk.org/jdk8u/pull/50.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/50/head:pull/50

PR: https://git.openjdk.org/jdk8u/pull/50

From sgehwolf at openjdk.org  Tue Sep 19 08:34:46 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 19 Sep 2023 08:34:46 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
Message-ID: <bOBwjBNi8Z0XPWeyfIXMJiUs9x1OakOlmB9IcBHOnNo=.aafb17ae-f7d5-47ec-a88c-a7c9dda43e6e@github.com>

On Tue, 19 Sep 2023 02:09:15 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> Hi~,  as reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it's should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We found  [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) can sovle it, so please let's do backport it. We also added a test case.
> Thanks.

Please open this PR against [jdk8u-dev](https://github.com/openjdk/jdk8u-dev) (which is the development tree). jdk8u is closed for rampdown and this fix doesn't seem warranted as a critical fix for 8u392. Also be sure to enable GHA tests and that those GHA runs show up on the PR as well. Thank you!

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725059848

From jianyesun at openjdk.org  Tue Sep 19 09:18:48 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 09:18:48 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <bOBwjBNi8Z0XPWeyfIXMJiUs9x1OakOlmB9IcBHOnNo=.aafb17ae-f7d5-47ec-a88c-a7c9dda43e6e@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
 <bOBwjBNi8Z0XPWeyfIXMJiUs9x1OakOlmB9IcBHOnNo=.aafb17ae-f7d5-47ec-a88c-a7c9dda43e6e@github.com>
Message-ID: <14MhfeFMWxhee4NbP6ndN1mM608CyNJHxyLXyIowTMI=.e823555f-1dbd-4c53-af77-2eded80dffcd@github.com>

On Tue, 19 Sep 2023 08:32:26 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Please open this PR against [jdk8u-dev](https://github.com/openjdk/jdk8u-dev) (which is the development tree). jdk8u is closed for rampdown and this fix doesn't seem warranted as a critical fix for 8u392. Also be sure to enable GHA tests and that those GHA runs show up on the PR as well. Thank you!

Good tips ! This is my first PR to JDK 8. Thank you for telling me. I will do it later.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725128895

From sgehwolf at openjdk.org  Tue Sep 19 09:34:44 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 19 Sep 2023 09:34:44 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
Message-ID: <ex6HjLXgryTm7Hofe7fQioZP8ZQYZ9WNQLxT2BEtT5U=.85c8ad90-1f2f-464f-8117-8bd9b894d483@github.com>

On Tue, 19 Sep 2023 02:09:15 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> Hi~,  as reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it's should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We found  [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) can sovle it, so please let's do backport it. We also added a test case.
> Thanks.

You also need to create the backport PR title as `Backport <sha-of-original-change>` so that the bots recognize it as backport. One way to figure this out is to go to a later JDK version, jdk11u-dev, for example and use `git log --grep 8316278`. HTH.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725153907

From jianyesun at openjdk.org  Tue Sep 19 12:21:43 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 12:21:43 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <ex6HjLXgryTm7Hofe7fQioZP8ZQYZ9WNQLxT2BEtT5U=.85c8ad90-1f2f-464f-8117-8bd9b894d483@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
 <ex6HjLXgryTm7Hofe7fQioZP8ZQYZ9WNQLxT2BEtT5U=.85c8ad90-1f2f-464f-8117-8bd9b894d483@github.com>
Message-ID: <ZAJbCTrUcPxO26l5vHMiQp3P-PvoSq8fXk_upJNcj74=.e6b1bc38-bce6-4a0d-882e-0ccf4ebc355f@github.com>

On Tue, 19 Sep 2023 09:32:14 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> 8316278

Well, I have 2 questions here:
1/   Can the bots automatically backport to JDK8,  when using the title as `Backport <sha-of-original-change>`?   The code path is different because of the modularization after JDK9.
2/  When using the title as `Backport <sha-of-original-change>`, how can this PR associate the JBS' issue id as https://bugs.openjdk.org/browse/JDK-8316278 ?  You can see  the title i setted at the beginning is `Backport <f541df955aca> G1 ...` ,  i got a  jcheck error when i do that.  
Please give me more guidance, bro~ Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725403032

From sgehwolf at openjdk.org  Tue Sep 19 12:31:43 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 19 Sep 2023 12:31:43 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <ZAJbCTrUcPxO26l5vHMiQp3P-PvoSq8fXk_upJNcj74=.e6b1bc38-bce6-4a0d-882e-0ccf4ebc355f@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
 <ex6HjLXgryTm7Hofe7fQioZP8ZQYZ9WNQLxT2BEtT5U=.85c8ad90-1f2f-464f-8117-8bd9b894d483@github.com>
 <ZAJbCTrUcPxO26l5vHMiQp3P-PvoSq8fXk_upJNcj74=.e6b1bc38-bce6-4a0d-882e-0ccf4ebc355f@github.com>
Message-ID: <LGyZgzj5umM7SGblFg1oXLDICpaCS7cbg-HrkfB93bY=.51b8c566-5483-4c4f-9106-f0ed220007d6@github.com>

On Tue, 19 Sep 2023 12:18:54 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> > 8316278
> 
> Well, I have 2 questions here: 1/ Can the bots automatically backport to JDK8, when using the title as `Backport <sha-of-original-change>`? The code path is different because of the modularization after JDK9.

For the Github bots, it's the **pull request** title that matters. So the backporting and path unshuffeling needs to happen by yourself. Then once you are happy you create a pull request. That's when the PR title comes into play.

> 2/ When using the title as `Backport <sha-of-original-change>`, how can this PR associate the JBS' issue id as https://bugs.openjdk.org/browse/JDK-8316278 ? You can see the title i setted at the beginning is `Backport <f541df955aca> G1 ...` , i got a jcheck error when i do that. Please give me more guidance, bro~ Thanks!

That's how the skara tooling works. See for example [this comment](https://github.com/openjdk/jdk8u-dev/pull/372#event-10376618046) in an jdk8u-dev PR. The bot changed the title to the title of the master bug that commit referred to. It probably uses the same mechanism (but reverse) to do that. Hope that makes sense.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725417331

From jianyesun at openjdk.org  Tue Sep 19 12:55:42 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 12:55:42 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <LGyZgzj5umM7SGblFg1oXLDICpaCS7cbg-HrkfB93bY=.51b8c566-5483-4c4f-9106-f0ed220007d6@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
 <ex6HjLXgryTm7Hofe7fQioZP8ZQYZ9WNQLxT2BEtT5U=.85c8ad90-1f2f-464f-8117-8bd9b894d483@github.com>
 <ZAJbCTrUcPxO26l5vHMiQp3P-PvoSq8fXk_upJNcj74=.e6b1bc38-bce6-4a0d-882e-0ccf4ebc355f@github.com>
 <LGyZgzj5umM7SGblFg1oXLDICpaCS7cbg-HrkfB93bY=.51b8c566-5483-4c4f-9106-f0ed220007d6@github.com>
Message-ID: <Tjc6KLWFclI22a2ddQlf6YVHHdI-keXcCArU5HfOL6U=.9fc2403d-020e-4c53-9a56-fadceb34311e@github.com>

On Tue, 19 Sep 2023 12:29:08 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > 
> > Well, I have 2 questions here: 1/ Can the bots automatically backport to JDK8, when using the title as `Backport <sha-of-original-change>`? The code path is different because of the modularization after JDK9.
> 
> For the Github bots, it's the **pull request** title that matters. So the backporting and path unshuffeling needs to happen by yourself. Then once you are happy you create a pull request. That's when the PR title comes into play.
> 
> > 2/ When using the title as `Backport <sha-of-original-change>`, how can this PR associate the JBS' issue id as https://bugs.openjdk.org/browse/JDK-8316278 ? You can see the title i setted at the beginning is `Backport <f541df955aca> G1 ...` , i got a jcheck error when i do that. Please give me more guidance, bro~ Thanks!
> 
> That's how the skara tooling works. See for example [this comment](https://github.com/openjdk/jdk8u-dev/pull/372#event-10376618046) in an jdk8u-dev PR. The bot changed the title to the title of the master bug that commit referred to. It probably uses the same mechanism (but reverse) to do that. Hope that makes sense.

Got it ! So cool ! You are a nice man , Thank you very much?

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725457176

From zzambers at openjdk.org  Tue Sep 19 13:23:51 2023
From: zzambers at openjdk.org (Zdenek Zambersky)
Date: Tue, 19 Sep 2023 13:23:51 GMT
Subject: [jdk8u-dev] RFR: 8307837: [8u] Check step in GHA should also print
 errors
In-Reply-To: <c0dWf59m1oB6DfF369DnBG6jQmelGjqG2gmtdXU7nME=.e4a4617c-6ec9-4dc3-84ef-bdd21a44c7f3@github.com>
References: <HUXB-aMOEbR5mbuDg3hMnyPeCSfzkC-kfkUZykLSubw=.24b77963-6e03-4c5b-ba36-6fb863620765@github.com>
 <c0dWf59m1oB6DfF369DnBG6jQmelGjqG2gmtdXU7nME=.e4a4617c-6ec9-4dc3-84ef-bdd21a44c7f3@github.com>
Message-ID: <srcXkA8osOD2j7fn7EVautNnb9edHnHwQxTQnyOr1b4=.fec3b077-6ada-46a4-8ce0-7863650ff443@github.com>

On Tue, 19 Sep 2023 01:15:55 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Check step currently only prints list of failed tests. It should also print tests, which finished with error (e.g. test ending on timeout). See e.g.: https://github.com/naotoj/jdk8u-dev/actions/runs/4931190096/jobs/8813500528
>
> Changes look fine, though the referenced link has expired.
> 
> Any way we can test this works as expected?

@gnu-andrew I have made branch with dummy failing and erroring test added on top of this. Works as expected, see: https://github.com/zzambers/jdk8u-dev/actions/runs/6234555212/job/16923516100

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/317#issuecomment-1725507247

From andrew at openjdk.org  Tue Sep 19 13:55:50 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 19 Sep 2023 13:55:50 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
Message-ID: <EbfkfBfG2_CEc1mR5B8ppLr0XxmAr8KFxtWoTMI0xbo=.436e471c-fbac-4ee8-9a7d-94dac5bb44a7@github.com>

On Tue, 19 Sep 2023 02:09:15 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> Hi~,  as reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it's should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We found  [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) can sovle it, so please let's do backport it. We also added a test case.
> Thanks.

2/ When using the title as `Backport <sha-of-original-change>`, how can this PR associate the JBS' issue id as https://bugs.openjdk.org/browse/JDK-8316278 ? You can see the title i setted at the beginning is `Backport <f541df955aca> G1 ...` , i got a jcheck error when i do that. Please give me more guidance, bro~ Thanks!

It will recognise it as as backport of [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) which is the one you need to [find in jdk11](https://github.com/search?q=repo%3Aopenjdk%2Fjdk11u+6899049&type=commits).

You don't need to manually create backport bugs, but I've now corrected the one you created to be a backport of 6899049 and it should be automatically resolved when this is fixed in 8u-dev.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725627164

From andrew at openjdk.org  Tue Sep 19 14:40:50 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 19 Sep 2023 14:40:50 GMT
Subject: [jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38 [v4]
In-Reply-To: <1GKH0pcBWL44u2nZDnHN2atX2MOxZ-zbwMwsFd4X1YE=.f961836f-4d43-4432-ab40-488e295222ab@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
 <1GKH0pcBWL44u2nZDnHN2atX2MOxZ-zbwMwsFd4X1YE=.f961836f-4d43-4432-ab40-488e295222ab@github.com>
Message-ID: <fZSGd4SE3ucZ_NJPCRAUeeR-Hm2ES3enmz6nWKo_RGg=.df229ffe-ac66-4dd0-95d6-b1e8feee90b0@github.com>

On Tue, 19 Sep 2023 02:12:43 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
>> 
>> Thanks!
>
> Martin Balao has refreshed the contents of this pull request, and previous commits have been removed. Incremental views are not available. The pull request now contains two commits:
> 
>  - Removal of the markdown syntax as it's not in the original libpng AUTHORS file.
>  - Backport d183dc25f7360c3012726acf8c03874df6fc41a4

Approved for 8u-dev.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/372#issuecomment-1725776655

From mbalao at openjdk.org  Tue Sep 19 14:45:48 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 19 Sep 2023 14:45:48 GMT
Subject: [jdk8u-dev] Integrated: 8295685: Update Libpng to 1.6.38
In-Reply-To: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
References: <TNy-gddsfdNCvKwm5qeyhWa1oiYBYEq0hOp-CpMxBrM=.6ba39715-1b7a-4c74-8eb6-9dd0f767a7de@github.com>
Message-ID: <MFNyz9mrUk5aR4e8tceBjynE2XCpc-0wmoZ5mJr20q8=.e96a4b77-79d6-45cc-870f-866abd11522a@github.com>

On Thu, 14 Sep 2023 20:27:03 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
> 
> Thanks!

This pull request has now been integrated.

Changeset: 5b76d032
Author:    Martin Balao <mbalao at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/5b76d03291edd805ce594972a108c305a32ac478
Stats:     616 lines in 22 files changed: 436 ins; 33 del; 147 mod

8295685: Update Libpng to 1.6.38

Reviewed-by: andrew
Backport-of: d183dc25f7360c3012726acf8c03874df6fc41a4

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/372

From jianyesun at openjdk.org  Tue Sep 19 15:21:43 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 15:21:43 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <EbfkfBfG2_CEc1mR5B8ppLr0XxmAr8KFxtWoTMI0xbo=.436e471c-fbac-4ee8-9a7d-94dac5bb44a7@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
 <EbfkfBfG2_CEc1mR5B8ppLr0XxmAr8KFxtWoTMI0xbo=.436e471c-fbac-4ee8-9a7d-94dac5bb44a7@github.com>
Message-ID: <THipdQRR29tNves_bk7A8nRGfB4r-2XvywN_DgxlJfE=.4716e24a-53d4-4ce6-aa80-08449f6c4bcc@github.com>

On Tue, 19 Sep 2023 13:53:15 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> 2/ When using the title as `Backport <sha-of-original-change>`, how can this PR associate the JBS' issue id as https://bugs.openjdk.org/browse/JDK-8316278 ? You can see the title i setted at the beginning is `Backport <f541df955aca> G1 ...` , i got a jcheck error when i do that. Please give me more guidance, bro~ Thanks!
> 
> It will recognise it as as backport of [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) which is the one you need to [find in jdk11](https://github.com/search?q=repo%3Aopenjdk%2Fjdk11u+6899049&type=commits).
> 
> You don't need to manually create backport bugs, but I've now corrected the one you created to be a backport of 6899049 and it should be automatically resolved when this is fixed in 8u-dev.

Thanks for helping me correct it! I've created a new [PR](https://github.com/openjdk/jdk8u-dev/pull/374). Do you have time to review it ? Thanks a lot.

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725876030

From sgehwolf at openjdk.org  Tue Sep 19 15:39:41 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 19 Sep 2023 15:39:41 GMT
Subject: [jdk8u] RFR: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
Message-ID: <6yix9rk9bXi7921yzhliVc3VNu5_sp55-foNHvHRAw8=.255c93b2-5b73-404c-93f0-b0b69e625bed@github.com>

On Tue, 19 Sep 2023 02:09:15 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> Hi~,  as reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it's should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We found  [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) can sovle it, so please let's do backport it. We also added a test case.
> Thanks.

Please close this PR (replaced by https://github.com/openjdk/jdk8u-dev/pull/374).

-------------

PR Comment: https://git.openjdk.org/jdk8u/pull/50#issuecomment-1725908161

From mbalao at openjdk.org  Tue Sep 19 15:44:26 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 19 Sep 2023 15:44:26 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39 [v3]
In-Reply-To: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
Message-ID: <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Thanks!

Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:

  Backport c1f759e9d01d646eac69442452151b0467eab306

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/373/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=373&range=02
  Stats: 129 lines in 17 files changed: 29 ins; 8 del; 92 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/373.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/373/head:pull/373

PR: https://git.openjdk.org/jdk8u-dev/pull/373

From jianyesun at openjdk.org  Tue Sep 19 16:22:48 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 16:22:48 GMT
Subject: [jdk8u] Withdrawn: 8316278 G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
References: <HzHPtT8wiastC-YPx9LATO_zhPC99sy9pv3jwDWrpMY=.deca78c2-4d2f-4f5c-9204-b854717194f0@github.com>
Message-ID: <RJ1DHx64lIO8CJT3Su34pVq2yKfOea8jixIfpEJX5pI=.13d7efcd-7be0-4235-a74f-ee081239237b@github.com>

On Tue, 19 Sep 2023 02:09:15 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> Hi~,  as reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it's should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We found  [JDK-6899049](https://bugs.openjdk.org/browse/JDK-6899049) can sovle it, so please let's do backport it. We also added a test case.
> Thanks.

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u/pull/50

From jianyesun at openjdk.org  Tue Sep 19 16:52:05 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 16:52:05 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
Message-ID: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>

Hi all,

This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.

As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
The key problem is this way of using: 

size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  

The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
We also added a test case.
Please review this PR. Thanks.

-------------

Commit messages:
 - 8316278: Fix the indexing method of PtrQueue's buf when a large integer value overflow

Changes: https://git.openjdk.org/jdk8u-dev/pull/374/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=374&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-6899049
  Stats: 243 lines in 7 files changed: 133 ins; 42 del; 68 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/374.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/374/head:pull/374

PR: https://git.openjdk.org/jdk8u-dev/pull/374

From jianyesun at openjdk.org  Tue Sep 19 16:52:06 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 16:52:06 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
Message-ID: <4PQ2N9wcNaiFJh5wv-iwX0dlXeUeKJG0iQSZDJfarEQ=.1ef2e860-6b67-4cd9-b8de-2366e34d6dd7@github.com>

On Tue, 19 Sep 2023 15:06:33 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We also added a test case.
> Please review this PR. Thanks.

It triggers the jcheck error again... It shows this: 

The commit message does not reference any issue. To add an issue reference to this PR, edit the title to be of the format issue number: message.

This PR's title seems ok, do you know why? @jerboaa

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1725892099

From sgehwolf at openjdk.org  Tue Sep 19 16:52:06 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 19 Sep 2023 16:52:06 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <4PQ2N9wcNaiFJh5wv-iwX0dlXeUeKJG0iQSZDJfarEQ=.1ef2e860-6b67-4cd9-b8de-2366e34d6dd7@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <4PQ2N9wcNaiFJh5wv-iwX0dlXeUeKJG0iQSZDJfarEQ=.1ef2e860-6b67-4cd9-b8de-2366e34d6dd7@github.com>
Message-ID: <icMReurBP1D2LeEYRqucJpe9WKIW9oERJ7wCz0fJiOU=.a0a173b9-4ea2-48cb-986c-a734f73821c4@github.com>

On Tue, 19 Sep 2023 15:28:00 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
>> The key problem is this way of using: 
>> 
>> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
>> 
>> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
>> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
>> We also added a test case.
>> Please review this PR. Thanks.
>
> It triggers the jcheck error again... It shows this: 
> 
> The commit message does not reference any issue. To add an issue reference to this PR, edit the title to be of the format issue number: message.
> 
> This PR's title seems ok, do you know why? @jerboaa

@jianyesun PR title needs to be `Backport b256989eb34a32c8f03be448c0645baeb5192a01` (provided the sha is correct).

@jianyesun You are changing the title to something like `Backport b256989eb34a32c8f03be448c0645baeb5192a01 8316278: Fix the indexing method of PtrQueue's buf when a large integer value overflow`. It should be `Backport b256989eb34a32c8f03be448c0645baeb5192a01`. I.e. drop `8316278: ...` from the title.

The bots will do the rest.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1725904237
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1726061338

From jianyesun at openjdk.org  Tue Sep 19 16:53:44 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 16:53:44 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp
In-Reply-To: <4PQ2N9wcNaiFJh5wv-iwX0dlXeUeKJG0iQSZDJfarEQ=.1ef2e860-6b67-4cd9-b8de-2366e34d6dd7@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <4PQ2N9wcNaiFJh5wv-iwX0dlXeUeKJG0iQSZDJfarEQ=.1ef2e860-6b67-4cd9-b8de-2366e34d6dd7@github.com>
Message-ID: <SI2NwHPCqdwLHsMLt3PkkcttVoXpiiUwD1D6QASH5IM=.41a5cdf4-82f1-438a-bbb9-f9a157010c7b@github.com>

On Tue, 19 Sep 2023 15:28:00 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
>> The key problem is this way of using: 
>> 
>> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
>> 
>> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
>> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
>> We also added a test case.
>> Please review this PR. Thanks.
>
> It triggers the jcheck error again... It shows this: 
> 
> The commit message does not reference any issue. To add an issue reference to this PR, edit the title to be of the format issue number: message.
> 
> This PR's title seems ok, do you know why? @jerboaa

> @jianyesun You are changing the title to something like `Backport b256989eb34a32c8f03be448c0645baeb5192a01 8316278: Fix the indexing method of PtrQueue's buf when a large integer value overflow`. It should be `Backport b256989eb34a32c8f03be448c0645baeb5192a01`. I.e. drop `8316278: ...` from the title.
> 
> The bots will do the rest.

Finally done. Thank you for your patience and guidance,bro~

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1726076222

From jianyesun at openjdk.org  Tue Sep 19 17:24:20 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Tue, 19 Sep 2023 17:24:20 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v2]
In-Reply-To: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
Message-ID: <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We also added a test case.
> Please review this PR. Thanks.

Sun Jianye has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  8316278: Fix the indexing method of PtrQueue's buf when a large integer value overflow

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/374/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/374/files/5f71f84e..584e5ee1

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=374&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=374&range=00-01

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/374.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/374/head:pull/374

PR: https://git.openjdk.org/jdk8u-dev/pull/374

From andrew at openjdk.org  Wed Sep 20 00:11:47 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 20 Sep 2023 00:11:47 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v2]
In-Reply-To: <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>
Message-ID: <OUSOTULaxn6ifF9r-d7e3iEMbLWz04jrhEoUXZ1Nrz4=.81937c3d-4caf-4a00-aeb1-23b7dc5f0732@github.com>

On Tue, 19 Sep 2023 17:24:20 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
>> The key problem is this way of using: 
>> 
>> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
>> 
>> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
>> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
>> We also added a test case.
>> Please review this PR. Thanks.
>
> Sun Jianye has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8316278: Fix the indexing method of PtrQueue's buf when a large integer value overflow

Looks like the new test is failing.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1726701566

From andrew at openjdk.org  Wed Sep 20 00:16:45 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 20 Sep 2023 00:16:45 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v2]
In-Reply-To: <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>
Message-ID: <mzT37iVQy78uldDe-w162MVPZPXYtQGEs0J0UIangpQ=.cd1f42a0-7bea-4cf0-bed0-a895c21fbfbb@github.com>

On Tue, 19 Sep 2023 17:24:20 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
>> The key problem is this way of using: 
>> 
>> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
>> 
>> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
>> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
>> We also added a test case.
>> Please review this PR. Thanks.
>
> Sun Jianye has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   8316278: Fix the indexing method of PtrQueue's buf when a large integer value overflow

Where does this test come from? I don't see it in the patch being backported.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1726704837

From jianyesun at openjdk.org  Wed Sep 20 01:18:45 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Wed, 20 Sep 2023 01:18:45 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v2]
In-Reply-To: <mzT37iVQy78uldDe-w162MVPZPXYtQGEs0J0UIangpQ=.cd1f42a0-7bea-4cf0-bed0-a895c21fbfbb@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>
 <mzT37iVQy78uldDe-w162MVPZPXYtQGEs0J0UIangpQ=.cd1f42a0-7bea-4cf0-bed0-a895c21fbfbb@github.com>
Message-ID: <sQVFfHhQ3ffWf0Nx3NAIEvx1w7SYa5Q8ISiOIJvpM34=.962203d4-5df9-450d-932b-bd7f85a1ba1b@github.com>

On Wed, 20 Sep 2023 00:14:00 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Where does this test come from? I don't see it in the patch being backported.

We added it to check whether the problem is sovled.  I saw there are errors like `Insufficient Memory Error` or `could not reserve enough space for 2097152KB object heap`. Maybe the resources of the CI environment are limited? the size of memory  is less than 2G when the jvm starts with `-Xmx2048m`.

Do you think it is necessary to add this test case ? If not, i will delete it. Or  set the test  not to execute in these three scenarios(Linux x86/windows x86/Windows x64) ?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1726742044

From andrew at openjdk.org  Wed Sep 20 14:08:06 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 20 Sep 2023 14:08:06 GMT
Subject: [jdk8u-dev] RFR: 8029995: accept yes/no for boolean krb5.conf
 settings
In-Reply-To: <7M8VUgALHVYnX5W0Iz7LMABFYGima_NuUgowTz5nSnk=.4884c35a-5118-4d18-863b-43d4533c8450@github.com>
References: <7M8VUgALHVYnX5W0Iz7LMABFYGima_NuUgowTz5nSnk=.4884c35a-5118-4d18-863b-43d4533c8450@github.com>
Message-ID: <l942thogtB6i9ygEfhfDcf8GRQrpZtF7Fr8kwTmlWec=.57c9bb23-a312-4d44-8ec0-9646bac8db50@github.com>

On Tue, 5 Sep 2023 23:44:06 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This fix solves regression caused by JDK-8139348 and found by the test suite of 3rd party library.
> The fix allows to use "yes" and "no" values in the krb5.conf file. It is important because sometimes krb5.conf is autogenerated and uses "yes"/"no" values inside.
> The backport is almost clean except of the Config.java file. Config.java already has some changes applied as part of JDK-8077102
> sun/security/krb5 jtreg tests passed

Thanks. Approved for 8u.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/367#issuecomment-1727804384

From abakhtin at openjdk.org  Wed Sep 20 14:44:55 2023
From: abakhtin at openjdk.org (Alexey Bakhtin)
Date: Wed, 20 Sep 2023 14:44:55 GMT
Subject: [jdk8u-dev] Integrated: 8029995: accept yes/no for boolean krb5.conf
 settings
In-Reply-To: <7M8VUgALHVYnX5W0Iz7LMABFYGima_NuUgowTz5nSnk=.4884c35a-5118-4d18-863b-43d4533c8450@github.com>
References: <7M8VUgALHVYnX5W0Iz7LMABFYGima_NuUgowTz5nSnk=.4884c35a-5118-4d18-863b-43d4533c8450@github.com>
Message-ID: <pZPRKb2um3HgPhYgMPXAox3Velty-wSgQb5HI7Lh7vQ=.48b95906-1bb0-4d23-86bb-ed9b4d929ee9@github.com>

On Tue, 5 Sep 2023 23:44:06 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> This fix solves regression caused by JDK-8139348 and found by the test suite of 3rd party library.
> The fix allows to use "yes" and "no" values in the krb5.conf file. It is important because sometimes krb5.conf is autogenerated and uses "yes"/"no" values inside.
> The backport is almost clean except of the Config.java file. Config.java already has some changes applied as part of JDK-8077102
> sun/security/krb5 jtreg tests passed

This pull request has now been integrated.

Changeset: ee4caa8b
Author:    Alexey Bakhtin <abakhtin at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/ee4caa8b41570edb5137eaa30a8867de2cae4e5d
Stats:     109 lines in 6 files changed: 75 ins; 25 del; 9 mod

8029995: accept yes/no for boolean krb5.conf settings

Reviewed-by: andrew
Backport-of: 9bae1e597b2d884e1d8a2a7a499b8d83ec002dbd

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/367

From andrew at openjdk.org  Wed Sep 20 18:51:50 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 20 Sep 2023 18:51:50 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v2]
In-Reply-To: <sQVFfHhQ3ffWf0Nx3NAIEvx1w7SYa5Q8ISiOIJvpM34=.962203d4-5df9-450d-932b-bd7f85a1ba1b@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>
 <mzT37iVQy78uldDe-w162MVPZPXYtQGEs0J0UIangpQ=.cd1f42a0-7bea-4cf0-bed0-a895c21fbfbb@github.com>
 <sQVFfHhQ3ffWf0Nx3NAIEvx1w7SYa5Q8ISiOIJvpM34=.962203d4-5df9-450d-932b-bd7f85a1ba1b@github.com>
Message-ID: <1KwU4ApD3m6ZpaR-Pp64CuOpEewPNcjYcXE0Sfhhx_g=.5dacc582-251e-4e5e-9007-07b56c022999@github.com>

On Wed, 20 Sep 2023 01:16:22 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

> > Where does this test come from? I don't see it in the patch being backported.
> 
> We added it to check whether the problem is sovled. I saw there are errors like `Insufficient Memory Error` or `could not reserve enough space for 2097152KB object heap`. Maybe the resources of the CI environment are limited? the size of memory is less than 4G when the jvm starts with `-Xmx4096m`. When i change it to `-Xmx2048m`, it seems that the jvm cannot start or run with OOM.
> 
> Do you think it is necessary to add this test case ? If not, i will delete it. Or set the test not to execute in these three scenarios(Linux x86/windows x86/Windows x64) ?

Even with a working test, this is not the place to include something new unless it is specific to 8u.  If you do want to include it, it needs to be separated from your backport and proposed to https://github.com/openjdk/jdk under its own bug ID.  Once included there, it can be backported to 8u, as you have with JDK-6899049 here. Not only do we not want tests being unique to the 8u repository, but changes to the main repository get attention from those who are experts in this field. Stable update trees are generally expected to get fixes that have already been reviewed, but might need some minor modification to work on an older version, and so don't get the same reviewer coverage.

As to the test case itself, it's not clear to me what it's trying to test. Is it the command-line options? Or the actual allocation? I see other cases in the HotSpot tests where a 2GB heap is used, but they only run the VM with `-version` (e.g. https://github.com/openjdk/jdk/blob/HEAD/test/hotspot/jtreg/runtime/CompressedOops/UseCompressedOops.java ) 

The failure isn't architecture-specific, so the appropriate exclusion would be to check the available memory before running the VM process. If you only want to check the arguments work, then running with `-version` should be enough.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1728262048

From andrew at openjdk.org  Wed Sep 20 22:03:52 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 20 Sep 2023 22:03:52 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
Message-ID: <jlhDKUYsbk8PiRyqHIZxotugufKcZvyIf_86BvqMH1U=.83cd4c3b-cf7b-4285-b02f-2c38b0e8680a@github.com>

Merge jdk8u392-b06

-------------

Commit messages:
 - Merge
 - Merge
 - 8295894: Remove SECOM certificate that is expiring in September 2023
 - Merge
 - 8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk8u-dev/pull/375/files
  Stats: 160 lines in 5 files changed: 42 ins; 31 del; 87 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/375.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/375/head:pull/375

PR: https://git.openjdk.org/jdk8u-dev/pull/375

From andrew at openjdk.org  Wed Sep 20 23:42:47 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 20 Sep 2023 23:42:47 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v3]
In-Reply-To: <BqzskWTlflVl7VtferNcBLbvUoliL2EBnJsMRlJtVLs=.74f5c9f3-4b02-4f97-b71e-9b524087ebba@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <BqzskWTlflVl7VtferNcBLbvUoliL2EBnJsMRlJtVLs=.74f5c9f3-4b02-4f97-b71e-9b524087ebba@github.com>
Message-ID: <997C6ezSWuHnJG2lkrlUHAFmTvNkVoXcpgtN-2XwHyQ=.3b8746ad-55de-4abd-919b-bd1eb002bd22@github.com>

On Mon, 11 Sep 2023 08:46:03 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Move to jdk_security_infra and add to tier1
>  - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

8u392-b06 now merged  back into 8u-dev (https://github.com/openjdk/jdk8u-dev/pull/375), so merging this with HEAD should re-run the tests with JDK-8295894.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1728559436

From andrew at openjdk.org  Wed Sep 20 23:42:46 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 20 Sep 2023 23:42:46 GMT
Subject: [jdk8u-dev] Integrated: Merge jdk8u:master
In-Reply-To: <jlhDKUYsbk8PiRyqHIZxotugufKcZvyIf_86BvqMH1U=.83cd4c3b-cf7b-4285-b02f-2c38b0e8680a@github.com>
References: <jlhDKUYsbk8PiRyqHIZxotugufKcZvyIf_86BvqMH1U=.83cd4c3b-cf7b-4285-b02f-2c38b0e8680a@github.com>
Message-ID: <VadXDbE76DwFS6N7a_Uj7LeQlAbxmuxUMcx2qKve0_4=.84796443-56bd-45af-b3c5-0fbcd13b0ab0@github.com>

On Wed, 20 Sep 2023 21:59:20 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Merge jdk8u392-b06

This pull request has now been integrated.

Changeset: a9e2be48
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/a9e2be4802c602cad94349f25a88e5ba2c965978
Stats:     160 lines in 5 files changed: 42 ins; 31 del; 87 mod

Merge

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/375

From sgehwolf at openjdk.org  Thu Sep 21 07:47:06 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 21 Sep 2023 07:47:06 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v4]
In-Reply-To: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
Message-ID: <J-W_DUJot9IsxKp_rurgKtTWdHpTi9k6ijLhXytTQfY=.c8b043be-8a0f-4b0a-92fb-54ec80bae6a9@github.com>

> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
> 
> Testing:
>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)

Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into JDK-8315757-tier1-gha
 - Move to jdk_security_infra and add to tier1
 - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/368/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/368/files/f66b60c2..3bcf7e23

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=368&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=368&range=02-03

  Stats: 893 lines in 34 files changed: 558 ins; 91 del; 244 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/368.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/368/head:pull/368

PR: https://git.openjdk.org/jdk8u-dev/pull/368

From sgehwolf at openjdk.org  Thu Sep 21 07:47:08 2023
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Thu, 21 Sep 2023 07:47:08 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v3]
In-Reply-To: <BqzskWTlflVl7VtferNcBLbvUoliL2EBnJsMRlJtVLs=.74f5c9f3-4b02-4f97-b71e-9b524087ebba@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <BqzskWTlflVl7VtferNcBLbvUoliL2EBnJsMRlJtVLs=.74f5c9f3-4b02-4f97-b71e-9b524087ebba@github.com>
Message-ID: <hjb2IZ1qE5wZnt7THlGBORiKH9SuQLJsMwbbotdx1IM=.4641c26e-2973-45b0-bcf3-8c6ec1526cf8@github.com>

On Mon, 11 Sep 2023 08:46:03 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Move to jdk_security_infra and add to tier1
>  - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

Done. Lets see how it goes.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1729027230

From jianyesun at openjdk.org  Thu Sep 21 07:51:47 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Thu, 21 Sep 2023 07:51:47 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v2]
In-Reply-To: <1KwU4ApD3m6ZpaR-Pp64CuOpEewPNcjYcXE0Sfhhx_g=.5dacc582-251e-4e5e-9007-07b56c022999@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <WXnC5YVV4AB4XWRI90nUBZZkcvYJrvy1xx_GJxZCw8A=.b5e46379-fac3-48d2-8525-36f785b77072@github.com>
 <mzT37iVQy78uldDe-w162MVPZPXYtQGEs0J0UIangpQ=.cd1f42a0-7bea-4cf0-bed0-a895c21fbfbb@github.com>
 <sQVFfHhQ3ffWf0Nx3NAIEvx1w7SYa5Q8ISiOIJvpM34=.962203d4-5df9-450d-932b-bd7f85a1ba1b@github.com>
 <1KwU4ApD3m6ZpaR-Pp64CuOpEewPNcjYcXE0Sfhhx_g=.5dacc582-251e-4e5e-9007-07b56c022999@github.com>
Message-ID: <DJV4eKHrVeyoqqSkYGBaBIJJR9AQaPktIKojf_JZUQg=.8e9fc2c4-dba5-43f2-bf1c-30bd897d6dc5@github.com>

On Wed, 20 Sep 2023 18:48:41 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> As to the test case itself, it's not clear to me what it's trying to test. Is it the command-line options? Or the actual allocation?

Well, as i described in issue [JDK-8316278](https://bugs.openjdk.org/browse/JDK-8316278) , the crash happends when looking for a element with a special index in PtrQueue's buf during  G1GC STAB processing.  Therefore, the value of G1SATBBufferSize is related to the size of the heap space or the size of the remaining heap space. We added this test which is already reported by other reporter (ie.see [JDK-8308169](https://bugs.openjdk.org/browse/JDK-8308169))  just to check whether this problem will still be triggered in linux x64. Maybe the test doesn't quite fit.

>Even with a working test, this is not the place to include something new unless it is specific to 8u. If you do want to include it, it needs to be separated from your backport and proposed to https://github.com/openjdk/jdk under its own bug ID. Once included there, it can be backported to 8u, as you have with JDK-6899049 here. Not only do we not want tests being unique to the 8u repository, but changes to the main repository get attention from those who are experts in this field. Stable update trees are generally expected to get fixes that have already been reviewed, but might need some minor modification to work on an older version, and so don't get the same reviewer coverage.

OK, i understand what you mean. Code's version management should really be considered. I have decided to delete the test.
By the way, this backport is clean. Indeed, the risk of index's type conversion is avoided. Therefore it is valuable. What do you think? 

We will continue to pay attention to the reasons why other platforms failed to pass in the future. Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/374#issuecomment-1729037709

From gnu.andrew at redhat.com  Thu Sep 21 12:05:05 2023
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Thu, 21 Sep 2023 13:05:05 +0100
Subject: OpenJDK 8u392-b06 EA Released
Message-ID: <ZQwxcdal7j/r5iFo@hex.discworld.ac.uk>

I've made available an early access source bundle for 8u392, based on
the tag jdk8u392-b06:

https://openjdk-sources.osci.io/openjdk8/openjdk8u392-b06-ea.tar.xz

The tarball is accompanied by a digital signature available at:

https://openjdk-sources.osci.io/openjdk8/openjdk8u392-b06-ea.tar.xz.sig

This is signed by our Red Hat OpenJDK key (openjdk at redhat.com):

PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net)
Fingerprint: CA5F 11C6 CE22 644D 42C6  AC44 92EF 8D39 DC13 168F

SHA256 checksums:

5a05a325c358cc28b57b3b13932b3b55af9349dadbc5570b11ddcc482814fb43  openjdk8u392-b06-ea.tar.xz
d4223c16097f2bb7ff6949388b7f7ed0f3400086db5249ef38fc3a766b485ee3  openjdk8u392-b06-ea.tar.xz.sig

They are listed at
https://openjdk-sources.osci.io/openjdk8/openjdk8u392-b06-ea.sha256

The tarball was built on RHEL 6 (x86, x86_64) and RHEL 7 (aarch64,
ppc, ppc64, ppc64le, s390x, x86, x86_64)

Changes in 8u392 so far:
  - JDK-6722928: Provide a default native GSS-API library on Windows
  - JDK-8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java
  - JDK-8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal
  - JDK-8139348: Deprecate 3DES and RC4 in Kerberos
  - JDK-8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field"
  - JDK-8200468: Port the native GSS-API bridge to Windows
  - JDK-8202952: C2: Unexpected dead nodes after matching
  - JDK-8205399: Set node color on pinned HashMap.TreeNode deletion
  - JDK-8214046: [macosx] Undecorated Frame does not Iconify when set to
  - JDK-8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException
  - JDK-8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors
  - JDK-8232225: Rework the fix for JDK-8071483
  - JDK-8253269: The CheckCommonColors test should provide more info on failure
  - JDK-8287073: NPE from CgroupV2Subsystem.getInstance()
  - JDK-8287663: Add a regression test for JDK-8287073
  - JDK-8295894: Remove SECOM certificate that is expiring in September 2023
  - JDK-8308788: [8u] Remove duplicate HaricaCA.java test
  - JDK-8309122: Bump update version of OpenJDK: 8u392
  - JDK-8309143: [8u] fix archiving inconsistencies in GHA
  - JDK-8310026: [8u] make java_lang_String::hash_code consistent across platforms

Notes on individual issues:
===========================

security-libs/org.ietf.jgss:

JDK-6722928: Added a Default Native GSS-API Library on Windows
==============================================================

A native GSS-API library named `sspi_bridge.dll` has been added to the
JDK on the Windows platform.  As with native GSS-API library provision
on other operating systems, it will only be loaded when the
`sun.security.jgss.native` system property is set to "true". A user
can still load a third-party native GSS-API library instead by setting
the `sun.security.jgss.lib` system property to the appropriate path.

The library is client-side only and uses the default credentials.
Native GSS support automatically uses cached credentials from the
underlying operating system, so the
`javax.security.auth.useSubjectCredsOnly` system property should be
set to false.

The `com.sun.security.auth.module.Krb5LoginModule` does not call
native JGSS and so its use in your JAAS config should be avoided.

security-libs/org.ietf.jgss:krb5:

JDK-8139348: Deprecate 3DES and RC4 in Kerberos
===============================================
The `des3-hmac-sha1` and `rc4-hmac` Kerberos encryption types (etypes)
are now deprecated and disabled by default.  To re-enable them, you
can either enable all weak crypto (which also includes `des-cbc-crc`
and `des-cbc-md5`) by setting `allow_weak_crypto = true` in the
`krb5.conf` configuration file or explicitly list all the preferred
encryption types using the `default_tkt_enctypes`,
`default_tgs_enctypes`, or `permitted_enctypes` settings.

security-libs/java.security:

JDK-8295894: Removed SECOM Trust System's RootCA1 Root Certificate
==================================================================
The following root certificate from SECOM Trust System has been
removed from the `cacerts` keystore:

Alias Name: secomscrootca1 [jdk]
Distinguished Name: OU=Security Communication RootCA1, O=SECOM Trust.net, C=JP

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20230921/3fab9af3/signature.asc>

From jianyesun at openjdk.org  Thu Sep 21 14:13:01 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Thu, 21 Sep 2023 14:13:01 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v3]
In-Reply-To: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
Message-ID: <V1N76syq42I_VR_PPyTXueD8g41UbFqT8mqpc8sBbpY=.b62e77ac-4bf4-4e1b-8777-e4db3df5cfa5@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We also added a test case.
> Please review this PR. Thanks.

Sun Jianye has updated the pull request incrementally with one additional commit since the last revision:

  delete the test

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/374/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/374/files/584e5ee1..0ee3da36

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=374&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=374&range=01-02

  Stats: 58 lines in 1 file changed: 0 ins; 58 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/374.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/374/head:pull/374

PR: https://git.openjdk.org/jdk8u-dev/pull/374

From phh at openjdk.org  Thu Sep 21 14:20:54 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 21 Sep 2023 14:20:54 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39 [v3]
In-Reply-To: <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
 <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
Message-ID: <DY-dEG6ulYHHENYMKrarW0tMChqhs_cXdUrE8Qbx6Ro=.a95fb93f-97f8-40f7-ab93-540b1128b2c0@github.com>

On Tue, 19 Sep 2023 15:44:26 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Thanks!
>
> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport c1f759e9d01d646eac69442452151b0467eab306

The GHA failure looks unrelated to me, but please check it out.

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/373#pullrequestreview-1637959413

From mbalao at openjdk.org  Thu Sep 21 21:04:19 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Thu, 21 Sep 2023 21:04:19 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39 [v3]
In-Reply-To: <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
 <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
Message-ID: <2T2mMSOsvv8MQb2uChD7i-_gnl7NDUDL0JpfcVrfluY=.09f3d65e-38e7-4cad-aba6-726e8fbe6266@github.com>

On Tue, 19 Sep 2023 15:44:26 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Thanks!
>
> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport c1f759e9d01d646eac69442452151b0467eab306

The macOS x64 failure (build release) shown in the GHA looks unrelated to me as it happened while compiling hotspot. This backport is not related in any meaningful way to hotspot code.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/373#issuecomment-1730296946

From phh at openjdk.org  Thu Sep 21 21:22:18 2023
From: phh at openjdk.org (Paul Hohensee)
Date: Thu, 21 Sep 2023 21:22:18 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39 [v3]
In-Reply-To: <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
 <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
Message-ID: <u0FlSXlatjr9CK1NTCgK2w8tD91iGqyr63s3ppv8EVA=.ecd6ba60-f40f-4974-9cc0-a429b5c90659@github.com>

On Tue, 19 Sep 2023 15:44:26 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Thanks!
>
> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport c1f759e9d01d646eac69442452151b0467eab306

Then you're good to go. I saw the same failure on a few other PRs.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/373#issuecomment-1730317112

From jvanek at openjdk.org  Fri Sep 22 08:39:55 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 22 Sep 2023 08:39:55 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int)
Message-ID: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>

backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed

Build and test passes, now running full jtregs

-------------

Commit messages:
 - JDK-8283441 - C2: segmentation fault in ciMethodBlocks::make_block_at(int)

Changes: https://git.openjdk.org/jdk8u-dev/pull/376/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=376&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8283441
  Stats: 106 lines in 5 files changed: 94 ins; 0 del; 12 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/376.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/376/head:pull/376

PR: https://git.openjdk.org/jdk8u-dev/pull/376

From jvanek at openjdk.org  Fri Sep 22 10:11:18 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Fri, 22 Sep 2023 10:11:18 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int)
In-Reply-To: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
Message-ID: <tTsm4WleLO6zh4cDECn6LZHyr-lLmWPIq17DDf_0480=.1f06073b-630c-4868-8bd2-819e955822a2@github.com>

On Fri, 22 Sep 2023 08:29:23 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
> 
> Build and test passes, now running full jtregs

all jtregs seems to be passing.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/376#issuecomment-1731161124

From mbalao at openjdk.org  Fri Sep 22 21:02:16 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Fri, 22 Sep 2023 21:02:16 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int)
In-Reply-To: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
Message-ID: <4UHBKjvcTm9cGF33K-BDzQJRdPwy8KFGO3D6mFVNs7M=.a250bd74-54f0-441e-8473-68c3f64c4566@github.com>

On Fri, 22 Sep 2023 08:29:23 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
> 
> Build and test passes, now running full jtregs

Hi @judovana ,

Thanks for proposing this backport. The copyright date in ciMethodBlocks.cpp could have been 2022 as in the 11u patch, but looks good to me anyways. Please wait for the jdk8u-fix-yes Maintainer approval in the 8283441 ticket before integrating.

-------------

Marked as reviewed by mbalao (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/376#pullrequestreview-1640636001

From jvanek at openjdk.org  Sat Sep 23 06:02:03 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Sat, 23 Sep 2023 06:02:03 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int) [v2]
In-Reply-To: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
Message-ID: <xBbyWMpDq-FlilD3ge4NxiH800YKHHvox5lKdpZV4GU=.8bf7e601-d8b2-427e-9cb9-138343117719@github.com>

> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
> 
> Build and test passes, now running full jtregs

Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:

  Fixed (C) header to 2022

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/376/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/376/files/7fa11e40..6b86f363

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=376&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=376&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/376.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/376/head:pull/376

PR: https://git.openjdk.org/jdk8u-dev/pull/376

From jvanek at openjdk.org  Sat Sep 23 06:02:05 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Sat, 23 Sep 2023 06:02:05 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int)
In-Reply-To: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
Message-ID: <HutREbsU9_jlRd_4ud7u-FWHVZtmf3l0OH2BRKqtkAs=.81ff0b5a-9011-47a5-81dd-959807aebffb@github.com>

On Fri, 22 Sep 2023 08:29:23 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
> 
> Build and test passes, now running full jtregs

TY for review! I had changed the (C) header.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/376#issuecomment-1732223913

From jvanek at openjdk.org  Sat Sep 23 06:02:06 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Sat, 23 Sep 2023 06:02:06 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int) [v2]
In-Reply-To: <4UHBKjvcTm9cGF33K-BDzQJRdPwy8KFGO3D6mFVNs7M=.a250bd74-54f0-441e-8473-68c3f64c4566@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
 <4UHBKjvcTm9cGF33K-BDzQJRdPwy8KFGO3D6mFVNs7M=.a250bd74-54f0-441e-8473-68c3f64c4566@github.com>
Message-ID: <aojF7vTgPAGmKyvRhXltm-pNWeTqbXX0qhcGdeRo5os=.36ca323f-d181-4b54-8cc1-47e8978bc5de@github.com>

On Fri, 22 Sep 2023 20:59:11 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixed (C) header to 2022
>
> Hi @judovana ,
> 
> Thanks for proposing this backport. The copyright date in ciMethodBlocks.cpp could have been 2022 as in the 11u patch, but looks good to me anyways. Please wait for the jdk8u-fix-yes Maintainer approval in the 8283441 ticket before integrating.

@martinuy  if you would be so kind to psonsor, would be awesome. TY!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/376#issuecomment-1732224062

From mbalao at openjdk.org  Sat Sep 23 06:04:19 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Sat, 23 Sep 2023 06:04:19 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int)
In-Reply-To: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
Message-ID: <XXMaMp_5JVfqkm64k3_I9Xdn7ex0Qf4jwccjS_p7aTs=.bbff9e04-23a1-446d-a3ae-2ece34affae6@github.com>

On Fri, 22 Sep 2023 08:29:23 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
> 
> Build and test passes, now running full jtregs

Sure, I'll do as soon as we get 8u Maintainer approval (@gnu-andrew @jerboaa).

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/376#issuecomment-1732224872

From jvanek at openjdk.org  Sat Sep 23 06:09:17 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Sat, 23 Sep 2023 06:09:17 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int) [v2]
In-Reply-To: <xBbyWMpDq-FlilD3ge4NxiH800YKHHvox5lKdpZV4GU=.8bf7e601-d8b2-427e-9cb9-138343117719@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
 <xBbyWMpDq-FlilD3ge4NxiH800YKHHvox5lKdpZV4GU=.8bf7e601-d8b2-427e-9cb9-138343117719@github.com>
Message-ID: <PgbyfLN7aYbbHkhspY1XTf5sZHUEjgIzwN9BXaeO6Ec=.550d75ec-a376-4a71-a51b-29ceaf1e439f@github.com>

On Sat, 23 Sep 2023 06:02:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
>> 
>> Build and test passes, now running full jtregs
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed (C) header to 2022

tyvm!

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/376#issuecomment-1732225723

From andrew at openjdk.org  Mon Sep 25 14:07:30 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 25 Sep 2023 14:07:30 GMT
Subject: [jdk8u-dev] RFR: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int) [v2]
In-Reply-To: <xBbyWMpDq-FlilD3ge4NxiH800YKHHvox5lKdpZV4GU=.8bf7e601-d8b2-427e-9cb9-138343117719@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
 <xBbyWMpDq-FlilD3ge4NxiH800YKHHvox5lKdpZV4GU=.8bf7e601-d8b2-427e-9cb9-138343117719@github.com>
Message-ID: <2Vhj-SYIbeMsU6k41gucSJ0-uDEVCyZBUOsyZ8QXM_s=.dc55e837-9d26-4148-8471-57f1817d5a9d@github.com>

On Sat, 23 Sep 2023 06:02:03 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

>> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
>> 
>> Build and test passes, now running full jtregs
>
> Ji?? Van?k has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed (C) header to 2022

Approved for 8u.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/376#issuecomment-1733779317

From jvanek at openjdk.org  Mon Sep 25 14:07:32 2023
From: jvanek at openjdk.org (=?UTF-8?B?SmnFmcOt?= =?UTF-8?B?IA==?= =?UTF-8?B?VmFuxJtr?=)
Date: Mon, 25 Sep 2023 14:07:32 GMT
Subject: [jdk8u-dev] Integrated: 8283441: C2: segmentation fault in
 ciMethodBlocks::make_block_at(int)
In-Reply-To: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
References: <mKYW6_jkUJl8k2eIVA04r8QoJ4m3_Ci8oL4I8GQJLBQ=.ee2c5015-ac88-4405-be72-85468a77ca7f@github.com>
Message-ID: <hSTWXC-fI6clbVsgA7YwHH88lZwl23Ed2H7Xm4a7V_U=.52d61bd0-0fca-4c28-8b45-fbe583387046@github.com>

On Fri, 22 Sep 2023 08:29:23 GMT, Ji?? Van?k <jvanek at openjdk.org> wrote:

> backport of https://github.com/openjdk/jdk/commit/947869609ce6b74d4d28f79724b823d8781adbed
> 
> Build and test passes, now running full jtregs

This pull request has now been integrated.

Changeset: 961ab463
Author:    Ji?? Van?k <jvanek at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/961ab463974b7d05600b826303f9111c4f367a04
Stats:     106 lines in 5 files changed: 94 ins; 0 del; 12 mod

8283441: C2: segmentation fault in ciMethodBlocks::make_block_at(int)

Reviewed-by: mbalao
Backport-of: 947869609ce6b74d4d28f79724b823d8781adbed

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/376

From gnu.andrew at redhat.com  Mon Sep 25 23:21:22 2023
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 26 Sep 2023 00:21:22 +0100
Subject: [FREEZE] 8u392 NOW FROZEN
Message-ID: <ZRIV8tq6UtWC8YFn@hex.discworld.ac.uk>

The release forest:

https://github.com/openjdk/jdk8u

is now frozen in preparation for release on or after 2023-10-17.

I will push the final pre-release tag, jdk8u392-b07, once testing completes.

The final release tag will be no lower than jdk8u392-b08.

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20230926/89e0bc61/signature-0001.asc>

From andrew at openjdk.org  Mon Sep 25 23:43:17 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 25 Sep 2023 23:43:17 GMT
Subject: [jdk8u-dev] RFR: 8307837: [8u] Check step in GHA should also print
 errors
In-Reply-To: <HUXB-aMOEbR5mbuDg3hMnyPeCSfzkC-kfkUZykLSubw=.24b77963-6e03-4c5b-ba36-6fb863620765@github.com>
References: <HUXB-aMOEbR5mbuDg3hMnyPeCSfzkC-kfkUZykLSubw=.24b77963-6e03-4c5b-ba36-6fb863620765@github.com>
Message-ID: <1wHbrVX1OFXYhDbceIqedWEa2g0l9Yn8yCY_m3a5vpA=.a4749abc-eed9-485e-bf04-400a597cdc2a@github.com>

On Wed, 10 May 2023 15:25:28 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Check step currently only prints list of failed tests. It should also print tests, which finished with error (e.g. test ending on timeout). See e.g.: https://github.com/naotoj/jdk8u-dev/actions/runs/4931190096/jobs/8813500528

Thanks. Looks good to me.
Please label the bug with `jdk8u-fix-request` and add an appropriate comment to request approval.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/317#pullrequestreview-1643128680

From andrew at openjdk.org  Mon Sep 25 23:50:16 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 25 Sep 2023 23:50:16 GMT
Subject: [jdk8u-dev] RFR: 8305815: Update Libpng to 1.6.39 [v3]
In-Reply-To: <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
 <OEFJ2O6_b2mu1u8msp6BrPDz9a_DLHe6YUl4vRp5tlA=.564e08dc-5295-48ab-bee6-7c8d497a3d5b@github.com>
Message-ID: <Ew9jfMOg936nvHuMPOMcqVjgvGNI-9T07shBPAvIR_M=.f917cb36-c210-4555-89e9-2077c4e66300@github.com>

On Tue, 19 Sep 2023 15:44:26 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
>> 
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>> 
>> Thanks!
>
> Martin Balao has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport c1f759e9d01d646eac69442452151b0467eab306

Looks good. Approved for 8u.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/373#pullrequestreview-1643134223

From mbalao at openjdk.org  Tue Sep 26 00:04:20 2023
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 26 Sep 2023 00:04:20 GMT
Subject: [jdk8u-dev] Integrated: 8305815: Update Libpng to 1.6.39
In-Reply-To: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
References: <xBEYgTkfbQ-AFW0oVK6AuT-vxhlvTyWON064LoOrMOY=.5fef9fea-2ca8-497f-a421-e1841eba498b@github.com>
Message-ID: <h7WNzFAE4XoNM8TWM1vOEejITHBcRtVIfo8mfqlwmac=.dda56774-063b-42dd-bd40-7a3724beb022@github.com>

On Thu, 14 Sep 2023 20:44:35 GMT, Martin Balao <mbalao at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [c1f759e9d01d646eac69442452151b0467eab306](https://github.com/openjdk/jdk11u-dev/commit/c1f759e9d01d646eac69442452151b0467eab306) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> This backport is a follow up fix of [JDK-8295685](https://bugs.openjdk.org/browse/JDK-8295685).
> 
> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
> 
> Thanks!

This pull request has now been integrated.

Changeset: f4260a4d
Author:    Martin Balao <mbalao at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e
Stats:     129 lines in 17 files changed: 29 ins; 8 del; 92 mod

8305815: Update Libpng to 1.6.39

Reviewed-by: phh, andrew
Backport-of: c1f759e9d01d646eac69442452151b0467eab306

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/373

From andrew at openjdk.org  Tue Sep 26 00:12:21 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 26 Sep 2023 00:12:21 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v3]
In-Reply-To: <V1N76syq42I_VR_PPyTXueD8g41UbFqT8mqpc8sBbpY=.b62e77ac-4bf4-4e1b-8777-e4db3df5cfa5@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <V1N76syq42I_VR_PPyTXueD8g41UbFqT8mqpc8sBbpY=.b62e77ac-4bf4-4e1b-8777-e4db3df5cfa5@github.com>
Message-ID: <SwhCYtxxhRWpH2wpTSsURM1p_9bx0iN2somyZuMQ0LU=.2c3d5b88-cf31-4591-ab68-f7064c936e43@github.com>

On Thu, 21 Sep 2023 14:13:01 GMT, Sun Jianye <jianyesun at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>> 
>> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
>> The key problem is this way of using: 
>> 
>> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
>> 
>> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
>> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
>> We also added a test case.
>> Please review this PR. Thanks.
>
> Sun Jianye has updated the pull request incrementally with one additional commit since the last revision:
> 
>   delete the test

A few minor unwanted differences have crept into the backport, but otherwise now looks mostly clean.

As to the test, if you do think it is worthwhile, please consider submitting it to openjdk/jdk.

hotspot/src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp line 316:

> 314:     DirtyCardQueue& dcq = t->dirty_card_queue();
> 315:     if (dcq.size() != 0) {
> 316:       void **buf = dcq.get_buf();

The 11u version changes this to `void** buf`. Was there a reason for the difference here?

hotspot/src/share/vm/gc_implementation/g1/ptrQueue.hpp line 79:

> 77:   // Initialize this queue to contain a null buffer, and be part of the
> 78:   // given PtrQueueSet.
> 79:   PtrQueue(PtrQueueSet* qset, bool permanent  = false, bool active = false);

An extra space has sneaked in here between `permanent` and the `=` sign.

-------------

Changes requested by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/374#pullrequestreview-1643146248
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/374#discussion_r1336493277
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/374#discussion_r1336493682

From duke at openjdk.org  Tue Sep 26 07:59:19 2023
From: duke at openjdk.org (ktakakuri)
Date: Tue, 26 Sep 2023 07:59:19 GMT
Subject: [jdk8u-dev] RFR: 8210560: [TEST] convert com/sun/jdi
 redefineClass-related tests
In-Reply-To: <uL_to5DEdwu_aIVrdqCFxudecSU2Beav8j6b8tf9zaY=.48cfeed6-7529-46e6-a856-a446dc48878b@github.com>
References: <uL_to5DEdwu_aIVrdqCFxudecSU2Beav8j6b8tf9zaY=.48cfeed6-7529-46e6-a856-a446dc48878b@github.com>
Message-ID: <z8gvZOhXuL9E13OD2I2rJe5MuEdQSc9HDrNY73LAjqE=.13ae20cb-4c12-487d-9a23-95e97018fa61@github.com>

On Thu, 3 Aug 2023 07:15:41 GMT, ktakakuri <duke at openjdk.org> wrote:

> This is a backport of JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests.
> 
> Original patch does not apply cleanly to 8u, because:
> 1. ClassTranformer.java of the original patch uses jdk.test.lib.compiler.CompilerUtils in test/lib.
> 2. However, CompilerUtils in test/lib cannot be compiled with JDK8 because it uses an API added in JDK9 (javax.tools.StandardJavaFileManager).
> 
> So, I replaced the CompilerUtils with test/lib/testlibrary/CompilerUtils.java to avoid using StandardJavaFileManager.
> 
> I confirmed that all of these tests pass on Windows x86_64 and Linux RedHat x86_64.

Could someone please review this backport?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/350#issuecomment-1735021445

From gnu.andrew at redhat.com  Tue Sep 26 16:47:04 2023
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 26 Sep 2023 17:47:04 +0100
Subject: CFV: New OpenJDK 8 Updates Committer: Dongbo He
Message-ID: <ZRMLCHzGR88ZZVjv@hex.discworld.ac.uk>

I hereby nominate Dongbo He (dongbohe) [0] to OpenJDK 8 Updates
Committer.

They have already made a number of contributions to both trunk [1] [2]
and backporting work for 8u [3]. Having the committer role would aid
this backporting work by avoiding the need to wait for sponsorship of
fixes, after review & approval.

Votes are due by 17h00 UTC on Tuesday, the 10th of October, 2023.

Only current OpenJDK 8 Updates Committers (and above) [4] are eligible
to vote on this nomination.

Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [5].

[0] https://openjdk.java.net/census#dongbohe
[1] https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated
[2] https://hg.openjdk.org/jdk/jdk/log?revcount=300&rev=(desc(%22hedongbo%40huawei.com%22))+and+not+merge()
[3] https://github.com/openjdk/jdk8u-dev/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated
[4] http://openjdk.java.net/census#jdk8u
[5] http://openjdk.java.net/projects/#committer-vote

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20230926/ae28a62f/signature.asc>

From hohensee at amazon.com  Tue Sep 26 19:39:23 2023
From: hohensee at amazon.com (Hohensee, Paul)
Date: Tue, 26 Sep 2023 19:39:23 +0000
Subject: CFV: New OpenJDK 8 Updates Committer: Dongbo He
Message-ID: <604ADE3F-023C-4481-916C-E76E66A789BE@amazon.com>

Vote: yes

?On 9/26/23, 9:47 AM, "jdk8u-dev on behalf of Andrew Hughes" <jdk8u-dev-retn at openjdk.org <mailto:jdk8u-dev-retn at openjdk.org> on behalf of gnu.andrew at redhat.com <mailto:gnu.andrew at redhat.com>> wrote:

I hereby nominate Dongbo He (dongbohe) [0] to OpenJDK 8 Updates
Committer.

They have already made a number of contributions to both trunk [1] [2]
and backporting work for 8u [3]. Having the committer role would aid
this backporting work by avoiding the need to wait for sponsorship of
fixes, after review & approval.

Votes are due by 17h00 UTC on Tuesday, the 10th of October, 2023.

Only current OpenJDK 8 Updates Committers (and above) [4] are eligible
to vote on this nomination.

Votes must be cast in the open by replying to this mailing list.

For Lazy Consensus voting instructions, see [5].

[0] https://openjdk.java.net/census#dongbohe <https://openjdk.java.net/census#dongbohe>
[1] https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated <https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated>
[2] https://hg.openjdk.org/jdk/jdk/log?revcount=300&rev= <https://hg.openjdk.org/jdk/jdk/log?revcount=300&amp;rev=>(desc(%22hedongbo%40huawei.com%22))+and+not+merge()
[3] https://github.com/openjdk/jdk8u-dev/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated <https://github.com/openjdk/jdk8u-dev/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated>
[4] http://openjdk.java.net/census#jdk8u <http://openjdk.java.net/census#jdk8u>
[5] http://openjdk.java.net/projects/#committer-vote <http://openjdk.java.net/projects/#committer-vote>

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com <http://www.redhat.com>)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew




From gnu.andrew at redhat.com  Tue Sep 26 21:14:52 2023
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Tue, 26 Sep 2023 22:14:52 +0100
Subject: OpenJDK 8u392-b07 EA Released
Message-ID: <ZRNJzJxP+1OX+kpJ@hex.discworld.ac.uk>

I've made available an early access source bundle for 8u392, based on
the tag jdk8u392-b07:

https://openjdk-sources.osci.io/openjdk8/openjdk8u392-b07-ea.tar.xz

The tarball is accompanied by a digital signature available at:

https://openjdk-sources.osci.io/openjdk8/openjdk8u392-b07-ea.tar.xz.sig

This is signed by our Red Hat OpenJDK key (openjdk at redhat.com):

PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net)
Fingerprint: CA5F 11C6 CE22 644D 42C6  AC44 92EF 8D39 DC13 168F

SHA256 checksums:

5f7ecc10107cb637fa31507e90b5ec6c0b98ebefe2e4b61168b274af54eaeeaa  openjdk8u392-b07-ea.tar.xz
96d3a93918eb552f6e2f1dd57325ca96d2e17ddef19d22f867b256b911d28934  openjdk8u392-b07-ea.tar.xz.sig

They are listed at
https://openjdk-sources.osci.io/openjdk8/openjdk8u392-b07-ea.sha256

The tarball was built on RHEL 6 (x86, x86_64) and RHEL 7 (aarch64,
ppc, ppc64, ppc64le, s390x, x86, x86_64)

Changes in 8u392 so far:
  - JDK-6722928: Provide a default native GSS-API library on Windows
  - JDK-8040887: [TESTBUG] Remove test/runtime/6925573/SortMethodsTest.java
  - JDK-8042726: [TESTBUG] TEST.groups file was not updated after runtime/6925573/SortMethodsTest.java removal
  - JDK-8139348: Deprecate 3DES and RC4 in Kerberos
  - JDK-8173072: zipfs fails to handle incorrect info-zip "extended timestamp extra field"
  - JDK-8200468: Port the native GSS-API bridge to Windows
  - JDK-8202952: C2: Unexpected dead nodes after matching
  - JDK-8205399: Set node color on pinned HashMap.TreeNode deletion
  - JDK-8214046: [macosx] Undecorated Frame does not Iconify when set to
  - JDK-8219804: java/net/MulticastSocket/Promiscuous.java fails intermittently due to NumberFormatException
  - JDK-8225687: Newly added sspi.cpp in JDK-6722928 still contains some small errors
  - JDK-8232225: Rework the fix for JDK-8071483
  - JDK-8253269: The CheckCommonColors test should provide more info on failure
  - JDK-8287073: NPE from CgroupV2Subsystem.getInstance()
  - JDK-8287663: Add a regression test for JDK-8287073
  - JDK-8295894: Remove SECOM certificate that is expiring in September 2023
  - JDK-8308788: [8u] Remove duplicate HaricaCA.java test
  - JDK-8309122: Bump update version of OpenJDK: 8u392
  - JDK-8309143: [8u] fix archiving inconsistencies in GHA
  - JDK-8310026: [8u] make java_lang_String::hash_code consistent across platforms
  - JDK-8314960: Add Certigna Root CA - 2

Notes on individual issues:
===========================

security-libs/org.ietf.jgss:

JDK-6722928: Added a Default Native GSS-API Library on Windows
==============================================================

A native GSS-API library named `sspi_bridge.dll` has been added to the
JDK on the Windows platform.  As with native GSS-API library provision
on other operating systems, it will only be loaded when the
`sun.security.jgss.native` system property is set to "true". A user
can still load a third-party native GSS-API library instead by setting
the `sun.security.jgss.lib` system property to the appropriate path.

The library is client-side only and uses the default credentials.
Native GSS support automatically uses cached credentials from the
underlying operating system, so the
`javax.security.auth.useSubjectCredsOnly` system property should be
set to false.

The `com.sun.security.auth.module.Krb5LoginModule` does not call
native JGSS and so its use in your JAAS config should be avoided.

security-libs/org.ietf.jgss:krb5:

JDK-8139348: Deprecate 3DES and RC4 in Kerberos
===============================================
The `des3-hmac-sha1` and `rc4-hmac` Kerberos encryption types (etypes)
are now deprecated and disabled by default.  To re-enable them, you
can either enable all weak crypto (which also includes `des-cbc-crc`
and `des-cbc-md5`) by setting `allow_weak_crypto = true` in the
`krb5.conf` configuration file or explicitly list all the preferred
encryption types using the `default_tkt_enctypes`,
`default_tgs_enctypes`, or `permitted_enctypes` settings.

security-libs/java.security:

JDK-8295894: Removed SECOM Trust System's RootCA1 Root Certificate
==================================================================
The following root certificate from SECOM Trust System has been
removed from the `cacerts` keystore:

Alias Name: secomscrootca1 [jdk]
Distinguished Name: OU=Security Communication RootCA1, O=SECOM Trust.net, C=JP

JDK-8314960: Added Certigna Root CA Certificate
===============================================
The following root certificate has been added to the cacerts
truststore:

Name: Certigna (Dhimyotis)
Alias Name: certignarootca
Distinguished Name: CN=Certigna Root CA, OU=0002 48146308100036, O=Dhimyotis, C=FR

Thanks,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20230926/66e8fcc8/signature-0001.asc>

From andrew at openjdk.org  Tue Sep 26 23:17:19 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 26 Sep 2023 23:17:19 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v4]
In-Reply-To: <J-W_DUJot9IsxKp_rurgKtTWdHpTi9k6ijLhXytTQfY=.c8b043be-8a0f-4b0a-92fb-54ec80bae6a9@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <J-W_DUJot9IsxKp_rurgKtTWdHpTi9k6ijLhXytTQfY=.c8b043be-8a0f-4b0a-92fb-54ec80bae6a9@github.com>
Message-ID: <HXpIPcdHaiipYA54FsN17f-J8PECEjgMhXXeucPGYhw=.41e12762-b4b3-41f0-8fac-e9f90deb5dfd@github.com>

On Thu, 21 Sep 2023 07:47:06 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8315757-tier1-gha
>  - Move to jdk_security_infra and add to tier1
>  - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

Looks like this is [JDK-8316215](https://bugs.openjdk.org/browse/JDK-8316215) and the solution seems to be to change the approach to this testing altogether; see [JDK-8308592](https://bugs.openjdk.org/browse/JDK-8308592)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1736427055

From jianyesun at openjdk.org  Wed Sep 27 10:03:24 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Wed, 27 Sep 2023 10:03:24 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v3]
In-Reply-To: <SwhCYtxxhRWpH2wpTSsURM1p_9bx0iN2somyZuMQ0LU=.2c3d5b88-cf31-4591-ab68-f7064c936e43@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
 <V1N76syq42I_VR_PPyTXueD8g41UbFqT8mqpc8sBbpY=.b62e77ac-4bf4-4e1b-8777-e4db3df5cfa5@github.com>
 <SwhCYtxxhRWpH2wpTSsURM1p_9bx0iN2somyZuMQ0LU=.2c3d5b88-cf31-4591-ab68-f7064c936e43@github.com>
Message-ID: <FSwEj2M5r3TcVXSUl6uEV_6WhBmrxdKw-X51lsvd19c=.bf1f5785-d5d9-4e32-9f19-66205ab452c3@github.com>

On Tue, 26 Sep 2023 00:07:11 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Sun Jianye has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   delete the test
>
> hotspot/src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp line 316:
> 
>> 314:     DirtyCardQueue& dcq = t->dirty_card_queue();
>> 315:     if (dcq.size() != 0) {
>> 316:       void **buf = dcq.get_buf();
> 
> The 11u version changes this to `void** buf`. Was there a reason for the difference here?

I think the return type of get_buf which  is defined for the first time is inappropriate, see [here](https://github.com/openjdk/jdk8u-dev/blob/f4260a4deed5210fc56f08774e8ca50cf6f7cc8e/hotspot/src/share/vm/gc_implementation/g1/dirtyCardQueue.hpp#L74), first commited in [here](https://github.com/openjdk/jdk8u-dev/commit/18f3386a98e67f1c5b75c4cc47a0ebb898c59b9b). 
The 11u version changes the buf allocation by  `BufferNode::make_buffer_from_node`(see [here](https://github.com/openjdk/jdk11u/blob/master/src/hotspot/share/gc/g1/dirtyCardQueue.cpp#L178)), however the jdk8 does not do that.
I can modify it to `void** buf`, should  i do that?

> hotspot/src/share/vm/gc_implementation/g1/ptrQueue.hpp line 79:
> 
>> 77:   // Initialize this queue to contain a null buffer, and be part of the
>> 78:   // given PtrQueueSet.
>> 79:   PtrQueue(PtrQueueSet* qset, bool permanent  = false, bool active = false);
> 
> An extra space has sneaked in here between `permanent` and the `=` sign.

Thanks, i will fix it.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/374#discussion_r1338368602
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/374#discussion_r1338370305

From jianyesun at openjdk.org  Wed Sep 27 14:06:30 2023
From: jianyesun at openjdk.org (Sun Jianye)
Date: Wed, 27 Sep 2023 14:06:30 GMT
Subject: [jdk8u-dev] RFR: 6899049: G1: Clean up code in ptrQueue.[ch]pp and
 ptrQueue.inline.hpp [v4]
In-Reply-To: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
References: <jYHZRcP3-GyhMxrKkXepi7Tu3f0o-1yF6jzIApA2gEg=.dbcbd355-32ba-40ca-a8e1-0eb7011282e8@github.com>
Message-ID: <9ZRGfkLAHdEXMJ-bmZRo0wLUJ-9XhSMB-xwFhYw5wMM=.1b8dd889-10b5-4804-8a67-a548c951defc@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [b256989eb34a32c8f03be448c0645baeb5192a01](https://github.com/openjdk/jdk11u-dev/commit/b256989eb34a32c8f03be448c0645baeb5192a01) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
> 
> As reported by issue :  https://bugs.openjdk.org/browse/JDK-8316278 .  We found  the indexing method of PtrQueue's buf  is not  correct  when  converting an integer of type size_t to type int, then calling the method PtrQueue::byte_index_to_index . 
> The key problem is this way of using: 
> 
> size_t i=0;    _buf[byte_index_to_index((int)i)] = NULL;  
> 
> The variable i of size_t type  cannot be converted directly to an int type . Other than that, the return value of the function byte_index_to_index is the index of the array _buf, and it should be non-negative. So it  should be a type of size_t. 
> Currently we have found 2 issues related to this problem,  https://bugs.openjdk.org/browse/JDK-8308169 and  https://bugs.openjdk.org/browse/JDK-8303961.  They are all triggered by a special  size number of buf, like '-XX:G1UpdateBufferSize=512M'  or  '-XX:G1SATBBufferSize=500m'
> We also added a test case.
> Please review this PR. Thanks.

Sun Jianye has updated the pull request incrementally with two additional commits since the last revision:

 - fix the return type
 - remove extra spaces

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/374/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/374/files/0ee3da36..4486486f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=374&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=374&range=02-03

  Stats: 3 lines in 3 files changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/374.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/374/head:pull/374

PR: https://git.openjdk.org/jdk8u-dev/pull/374

From andrew at openjdk.org  Wed Sep 27 17:14:25 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 27 Sep 2023 17:14:25 GMT
Subject: [jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA
 tier1 test set [v4]
In-Reply-To: <J-W_DUJot9IsxKp_rurgKtTWdHpTi9k6ijLhXytTQfY=.c8b043be-8a0f-4b0a-92fb-54ec80bae6a9@github.com>
References: <hSXmJG79osybcyjstgXMaQmApYP57uvq6-zKsIkLpaM=.7c65c08f-bb11-46f0-a0ba-e303ce684db5@github.com>
 <J-W_DUJot9IsxKp_rurgKtTWdHpTi9k6ijLhXytTQfY=.c8b043be-8a0f-4b0a-92fb-54ec80bae6a9@github.com>
Message-ID: <QJA_Jv6igOpO0GwXCxDbOYBMMrEdWUjDav9wjT6gxCo=.5b30964f-7ce9-4a70-a0af-28cc076577ed@github.com>

On Thu, 21 Sep 2023 07:47:06 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Simple GHA only change to add cacert tests to the tier1 test set. Please review.
>> 
>> Testing:
>>  - [x] GHA (which shows a failure in tier1 now, `VerifyCACerts.java` fails due to JDK-8295894; being worked on in jdk8u repo)
>
> Severin Gehwolf has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JDK-8315757-tier1-gha
>  - Move to jdk_security_infra and add to tier1
>  - 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set

I've started the backporting of that change with 17u: https://github.com/openjdk/jdk17u-dev/pull/1805 Once it's in 8u, this should pass (fingers crossed)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1737786959

From duke at openjdk.org  Thu Sep 28 09:36:03 2023
From: duke at openjdk.org (Taizo Kurashige)
Date: Thu, 28 Sep 2023 09:36:03 GMT
Subject: [jdk8u-dev] RFR: 8021961: setAlwaysOnTop doesn't behave correctly in
 Linux/Solaris under certain scenarios
Message-ID: <KZcaOGlwxpng_ccCsvf0T0LubH7qHRSurJwNT3JWUho=.a1165ffe-5257-420a-9f4f-181b1db6e655@github.com>

Hi,

This is a backoport of JDK-8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios

Original patch does not apply cleanly to 8u, bacause "parent" is declared at XWindowPeer.java#1652 in 8u.
So I deleted that declaration. 

There is a related Issue: JDK-8222323, and I submit the corresponding PR. Testing was done after applying this related patch.
Testing: jdk_awt on RHEL7, GHA testing

Thanks.

-------------

Commit messages:
 - Backport 09a7c4bc4624dd39ab5500c394c1e298a43a711a

Changes: https://git.openjdk.org/jdk8u-dev/pull/377/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=377&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8021961
  Stats: 204 lines in 2 files changed: 193 ins; 4 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/377.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/377/head:pull/377

PR: https://git.openjdk.org/jdk8u-dev/pull/377

From duke at openjdk.org  Thu Sep 28 09:45:49 2023
From: duke at openjdk.org (Taizo Kurashige)
Date: Thu, 28 Sep 2023 09:45:49 GMT
Subject: [jdk8u-dev] RFR: 8222323: ChildAlwaysOnTopTest.java fails with
 "RuntimeException: Failed to unset alwaysOnTop"
Message-ID: <bSeYckLRwr37fpJOCSWMOyG2oGwLaXPqFLRK8HF5CBk=.59fe0382-8a5e-4dad-8a7b-a59b59d60d1b@github.com>

Hi,

This is a backport of JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"

Original patch does not apply cleanly to JDK-8021961 applied code, because the fix uses "StringBuffer.isEmpty()" published in JDK15. I fixed the test so as not to use "StringBuffer.isEmpty()".

Testing: jdk_awt on RHEL7, GHA testing

Thanks.

-------------

Depends on: https://git.openjdk.org/jdk8u-dev/pull/377

Commit messages:
 - Backport 837928ba7955dbfd4a9c966209c3469c0fb5e195

Changes: https://git.openjdk.org/jdk8u-dev/pull/378/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=378&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8222323
  Stats: 224 lines in 1 file changed: 128 ins; 32 del; 64 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/378.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/378/head:pull/378

PR: https://git.openjdk.org/jdk8u-dev/pull/378

From sgehwolf at redhat.com  Thu Sep 28 12:01:25 2023
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Thu, 28 Sep 2023 14:01:25 +0200
Subject: CFV: New OpenJDK 8 Updates Committer: Dongbo He
In-Reply-To: <ZRMLCHzGR88ZZVjv@hex.discworld.ac.uk>
References: <ZRMLCHzGR88ZZVjv@hex.discworld.ac.uk>
Message-ID: <ae9b84b984e68898ada50918f92c22a3b572c8ac.camel@redhat.com>

Vote: yes

On Tue, 2023-09-26 at 17:47 +0100, Andrew Hughes wrote:
> I hereby nominate Dongbo He (dongbohe) [0] to OpenJDK 8 Updates
> Committer.


From yangfei at iscas.ac.cn  Thu Sep 28 15:39:02 2023
From: yangfei at iscas.ac.cn (yangfei at iscas.ac.cn)
Date: Thu, 28 Sep 2023 23:39:02 +0800 (GMT+08:00)
Subject: CFV: New OpenJDK 8 Updates Committer: Dongbo He
In-Reply-To: <ZRMLCHzGR88ZZVjv@hex.discworld.ac.uk>
References: <ZRMLCHzGR88ZZVjv@hex.discworld.ac.uk>
Message-ID: <6369acb8.8f3b9.18adc718614.Coremail.yangfei@iscas.ac.cn>

Vote: yes

&gt; -----Original Messages-----
&gt; From: "Andrew Hughes" <gnu.andrew at redhat.com>
&gt; Sent Time: 2023-09-27 00:47:04 (Wednesday)
&gt; To: jdk8u-dev at openjdk.org
&gt; Cc: 
&gt; Subject: CFV: New OpenJDK 8 Updates Committer: Dongbo He
&gt; 
&gt; I hereby nominate Dongbo He (dongbohe) [0] to OpenJDK 8 Updates
&gt; Committer.
&gt; 
&gt; They have already made a number of contributions to both trunk [1] [2]
&gt; and backporting work for 8u [3]. Having the committer role would aid
&gt; this backporting work by avoiding the need to wait for sponsorship of
&gt; fixes, after review &amp; approval.
&gt; 
&gt; Votes are due by 17h00 UTC on Tuesday, the 10th of October, 2023.
&gt; 
&gt; Only current OpenJDK 8 Updates Committers (and above) [4] are eligible
&gt; to vote on this nomination.
&gt; 
&gt; Votes must be cast in the open by replying to this mailing list.
&gt; 
&gt; For Lazy Consensus voting instructions, see [5].
&gt; 
&gt; [0] https://openjdk.java.net/census#dongbohe
&gt; [1] https://github.com/openjdk/jdk/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated
&gt; [2] https://hg.openjdk.org/jdk/jdk/log?revcount=300&amp;rev=(desc(%22hedongbo%40huawei.com%22))+and+not+merge()
&gt; [3] https://github.com/openjdk/jdk8u-dev/pulls?q=is%3Apr+author%3Adongbohe+is%3Aclosed+label%3Aintegrated
&gt; [4] http://openjdk.java.net/census#jdk8u
&gt; [5] http://openjdk.java.net/projects/#committer-vote
&gt; 
&gt; Thanks,
&gt; -- 
&gt; Andrew :)
&gt; Pronouns: he / him or they / them
&gt; Principal Free Java Software Engineer
&gt; OpenJDK Package Owner
&gt; Red Hat, Inc. (http://www.redhat.com)
&gt; 
&gt; PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
&gt; Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222
&gt; 
&gt; Please contact via e-mail, not proprietary chat networks
&gt; Available on Libera Chat &amp; OFTC IRC networks as gnu_andrew
</gnu.andrew at redhat.com>

From andrew at openjdk.org  Thu Sep 28 17:08:32 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 28 Sep 2023 17:08:32 GMT
Subject: [jdk8u-dev] RFR: 8307837: [8u] Check step in GHA should also print
 errors
In-Reply-To: <HUXB-aMOEbR5mbuDg3hMnyPeCSfzkC-kfkUZykLSubw=.24b77963-6e03-4c5b-ba36-6fb863620765@github.com>
References: <HUXB-aMOEbR5mbuDg3hMnyPeCSfzkC-kfkUZykLSubw=.24b77963-6e03-4c5b-ba36-6fb863620765@github.com>
Message-ID: <ZPZMkfvwYUdIzuXtN03XCvKUj9ap2PgcKUdRZ60gcKU=.3b984691-813e-444e-aecb-f4d3ca01f816@github.com>

On Wed, 10 May 2023 15:25:28 GMT, Zdenek Zambersky <zzambers at openjdk.org> wrote:

> Check step currently only prints list of failed tests. It should also print tests, which finished with error (e.g. test ending on timeout). See e.g.: https://github.com/naotoj/jdk8u-dev/actions/runs/4931190096/jobs/8813500528

Approved.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/317#issuecomment-1739709607

From duke at openjdk.org  Fri Sep 29 04:22:56 2023
From: duke at openjdk.org (KIRIYAMA Takuya)
Date: Fri, 29 Sep 2023 04:22:56 GMT
Subject: [jdk8u-dev] RFR: 8317291: Missing null check for
 nmethod::is_native_method()
Message-ID: <HpvNkJjgE96CLaD3vAcE3n5XJEuqGlVNqjVMbExqqlg=.1403279f-6d0f-4858-b918-686bc703b44b@github.com>

I added null check to nmethod::is_native_method() and is_java_method().
I verified that the JVM crash problem no longer occurs by this fix.
I don't attach the test for this fix beause I could reproduce this problem only with debug build.

Would anyone review this fix, pelase?

-------------

Commit messages:
 - 8317291: Missing null check for nmethod::is_native_method()

Changes: https://git.openjdk.org/jdk8u-dev/pull/379/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=379&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8317291
  Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/379.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/379/head:pull/379

PR: https://git.openjdk.org/jdk8u-dev/pull/379

From sgehwolf at redhat.com  Fri Sep 29 08:54:04 2023
From: sgehwolf at redhat.com (Severin Gehwolf)
Date: Fri, 29 Sep 2023 10:54:04 +0200
Subject: [8u Communication] New PRs check for jdk8u-fix-yes before being ready
Message-ID: <9f63f54d0ef27919068be49127d9c0b77d8281b6.camel@redhat.com>

Hi,
 
A new feature in the SKARA tooling is now live for the jdk8u-dev[1]
repository. New PRs will not gain the "ready" label until a
maintainer[2] has acked the bug with "jdk8u-fix-yes" label or with the
'/approve' command[4] on the PR.
 
Also, you can request approval with the /approval[3] command.
Thus you can do this now without having access to JBS.
Please note that the new command doesn?t change the requirement
of a useful fix request comment according to [5](Step 10). The 
comment can be included in the /approval command.
 
Details in:
https://bugs.openjdk.org/browse/SKARA-2047

A similar process hook is in place for the jdk8u[6] repository where we
collect critical fixes during ramp-down prior a release. 
 
Please let us know if that isn't working as expected.
 
Thanks,
Severin
 
[1] https://github.com/openjdk/jdk8u-dev
[2]?See "Maintainers" in https://wiki.openjdk.org/display/jdk8u
[3] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval
[4] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approve
[5]?See "Contributing" in https://wiki.openjdk.org/display/jdk8u
[6] https://bugs.openjdk.org/browse/SKARA-2048
    https://github.com/openjdk/jdk8u


From yan at openjdk.org  Fri Sep 29 16:45:08 2023
From: yan at openjdk.org (Yuri Nesterenko)
Date: Fri, 29 Sep 2023 16:45:08 GMT
Subject: [jdk8u-dev] RFR: 8242330: Arrays should be cloned in several JAAS
 Callback classes
Message-ID: <VkxS_ekWkLFmxnZb09lJLLa57Y-EhLyCpBamcNKZLrY=.d024d4da-8273-46c0-82ba-e500e087f4e4@github.com>

For 8u this backport does require a minimal update of the test preamble,  some copyright date changes and paragraph symbols in comments. 
CSR copy is filed as [JDK-8317297](https://bugs.openjdk.org/browse/JDK-8317297).

-------------

Commit messages:
 - Backport 8cd9241448f818b5e307d408ac4395b518791096

Changes: https://git.openjdk.org/jdk8u-dev/pull/380/files
 Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=380&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8242330
  Stats: 132 lines in 3 files changed: 107 ins; 0 del; 25 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/380.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/380/head:pull/380

PR: https://git.openjdk.org/jdk8u-dev/pull/380

From andrew at openjdk.org  Fri Sep 29 16:45:09 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 29 Sep 2023 16:45:09 GMT
Subject: [jdk8u-dev] RFR: 8242330: Arrays should be cloned in several JAAS
 Callback classes
In-Reply-To: <Qjsrd88k2WJMg-SdiqXk_W1ey2KaI7yZYRuljPCgjmg=.96c6d5cb-3114-4e0d-8994-d635b3cfa594@github.com>
References: <VkxS_ekWkLFmxnZb09lJLLa57Y-EhLyCpBamcNKZLrY=.d024d4da-8273-46c0-82ba-e500e087f4e4@github.com>
 <Qjsrd88k2WJMg-SdiqXk_W1ey2KaI7yZYRuljPCgjmg=.96c6d5cb-3114-4e0d-8994-d635b3cfa594@github.com>
Message-ID: <aUhmuUEGqOtmWamYkjdmyqUtO5XUK82iLRr9utC7PW0=.ae61457a-4952-4022-ac11-b813728c62b7@github.com>

On Fri, 29 Sep 2023 15:51:58 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Are we not able to link the CSR to two bugs?

I've linked it to an 8u backport bug now

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/380#issuecomment-1741116811

From andrew at openjdk.org  Fri Sep 29 16:45:09 2023
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 29 Sep 2023 16:45:09 GMT
Subject: [jdk8u-dev] RFR: 8242330: Arrays should be cloned in several JAAS
 Callback classes
In-Reply-To: <VkxS_ekWkLFmxnZb09lJLLa57Y-EhLyCpBamcNKZLrY=.d024d4da-8273-46c0-82ba-e500e087f4e4@github.com>
References: <VkxS_ekWkLFmxnZb09lJLLa57Y-EhLyCpBamcNKZLrY=.d024d4da-8273-46c0-82ba-e500e087f4e4@github.com>
Message-ID: <Qjsrd88k2WJMg-SdiqXk_W1ey2KaI7yZYRuljPCgjmg=.96c6d5cb-3114-4e0d-8994-d635b3cfa594@github.com>

On Fri, 29 Sep 2023 12:15:35 GMT, Yuri Nesterenko <yan at openjdk.org> wrote:

> For 8u this backport does require a minimal update of the test preamble,  some copyright date changes and paragraph symbols in comments. 
> CSR copy is filed as [JDK-8317297](https://bugs.openjdk.org/browse/JDK-8317297).

Backport looks good to me. Paragraph tags are due to 8u lacking JDK-8028266

Are we not able to link the CSR to two bugs?

HotSpot test fail seems unrelated.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/380#pullrequestreview-1651074897
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/380#issuecomment-1741116378