[jdk8u-dev] RFR: 8315506: C99 compatibility issue in LinuxNativeDispatcher

Fri Sep 1 11:09:46 UTC 2023

On Fri, 1 Sep 2023 10:12:18 GMT, Florian Weimer <fweimer at openjdk.org> wrote:

> The `Java_sun_nio_fs_LinuxNativeDispatcher_getlinelen` function calls the `free` function without including `<stdlib.h>`. This results in an implicit function declarations, and some compilers no longer support that by default, leading to a build failure.
> 
> Per the comment in the file, this function was introduced in the backport from jdk11, so this bug is specific to jdk8u.
> 
> Patch originally submitted by @djdelorie as openjdk/jdk8u#42.
> 
> Related to:
> 
> * https://fedoraproject.org/wiki/Changes/PortingToModernC
> * https://fedoraproject.org/wiki/Toolchain/PortingToModernC

LGTM.

For the future please enable GHA on your fork! Thanks.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/362#pullrequestreview-1606740620
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1702575995