[jdk8u-dev] RFR: 8315506: C99 compatibility issue in LinuxNativeDispatcher

[Florian Weimer]

On Fri, 1 Sep 2023 15:49:46 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > Speaking of flags, I plan to add `-Werror=implict-function-declaration -Werror=implicit-int` to the default flags in Fedora. Should I backport this change proactively to the `java-1.8.0-openjdk-portable`?
> 
> Do you mean this change or the additional flags? I thought this change was already in there.

No, it's not yet integrated into Fedora rawhide.  Hopefully this week.

> There is a `-Wno-error` added in the Fedora build which I expect may cancel this out even if the flags you suggest are added. `-Werror=implicit-function-declaration` is certainly a useful one to have and one I ran with myself locally for a while. But fixing stuff like that in a JDK as old as 8u might be problematic and I'd certainly start with `java-21-openjdk` first.

It was the only issue in our tests. That was a couple of months ago, but presumably the change rate in 8u is not that high.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/362#issuecomment-1704979529