[jdk8u-dev] RFR: 8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set [v2]

Andrew John Hughes andrew at openjdk.org
Mon Sep 11 16:22:47 UTC 2023


On Mon, 11 Sep 2023 08:51:20 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> > There's already a `jdk_security_infra` so should we not reuse that, either adding `cacerts` to it or including it in `jdk_cacerts`?
> 
> Good catch. I've added it to `jdk_security_infra`.

It looks like it was added by [JDK-8189131](https://bugs.openjdk.org/browse/JDK-8189131) but that didn't add it to any tier. It does seem worth investigating if this was just an oversight or intentional.

> 
> > Also, why is this not being proposed to trunk first?
> 
> `VerifyCACerts.java` is part of `tier2` in JDK head by means of `jdk_security => jdk_security_3 => sun/security`. `jdk_security_infra` is not part of any group yet, which I assume has a reason. Probably, because those tests depend on what CAs do (external factors?). The situation in 8u is a bit different to later JDKs, IMO. It's more like GHA being the best option for the early heads-up in 8u as later tiers aren't being run publicly. I have no strong opinion about this, but I lack the relevant cycles in order to push this upstream at this point. Feel free to go ahead and propose it though.

Ah ok, I hadn't realised 8u was running a smaller test set than later JDKs. I'm guessing later tiers don't pass? Given the `cacerts` part is a 8u-only omission, I'm happy for this to go in as is.

I think the infra story is worth pursuing upstream. I've no issue with adding them like this to 8u for now, under this ticket, so we have tests running in some form. However, we may need to adjust further, depending on the decision upstream.

Do you know if the GHA tests will now pass? If not, is there a PR waiting that will make that happen? I'm happy to push this once GHA passes.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/368#issuecomment-1714204283


More information about the jdk8u-dev mailing list