[jdk8u-dev] RFR: 8295685: Update Libpng to 1.6.38
Martin Balao
mbalao at openjdk.org
Fri Sep 15 19:49:45 UTC 2023
On Fri, 15 Sep 2023 12:57:08 GMT, Ekaterina Vergizova <evergizova at openjdk.org> wrote:
>> Hi all,
>>
>> This pull request contains a backport of commit [d183dc25f7360c3012726acf8c03874df6fc41a4](https://github.com/openjdk/jdk11u-dev/commit/d183dc25f7360c3012726acf8c03874df6fc41a4) from the [openjdk/jdk11u-dev](https://github.com/openjdk/jdk11u-dev) repository.
>>
>> This backport is a follow up fix of [JDK-8209115](https://bugs.openjdk.org/browse/JDK-8209115), and a dependency of [JDK-8305815](https://bugs.openjdk.org/browse/JDK-8305815).
>>
>> This backport applied cleanly, except for the changes to the THIRD_PARTY_README files that are specific to 8u.
>>
>> Note: Changes to src/java.desktop/share/native/libsplashscreen/libpng/UPDATING.txt were skipped because this file was not introduced by the 8u backport of 8208353. That's okay, as for 8u we will backport libpng from 11u or newer JDK releases, and not directly from the library.
>>
>> Thanks!
>
> The changes look good to me, although I'm not a reviewer.
> But maybe it's better not to transfer .md syntax like ### and ``` into plain THIRD_PARTY_README files?
Hi @kvergizova ,
Thanks for having a look. You're right. The markdown syntax does not belong to the original libpng file, and there is no gain in keeping it because 11u-dev changes will not apply cleanly anyways (it's different files). I'll fix it and rebase PR 373.
Martin.-
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/372#issuecomment-1721760649
More information about the jdk8u-dev
mailing list