[jdk8u-dev] RFR: 8029995: accept yes/no for boolean krb5.conf settings
Andrew John Hughes
andrew at openjdk.org
Tue Sep 19 01:41:45 UTC 2023
On Tue, 5 Sep 2023 23:44:06 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:
> This fix solves regression caused by JDK-8139348 and found by the test suite of 3rd party library.
> The fix allows to use "yes" and "no" values in the krb5.conf file. It is important because sometimes krb5.conf is autogenerated and uses "yes"/"no" values inside.
> The backport is almost clean except of the Config.java file. Config.java already has some changes applied as part of JDK-8077102
> sun/security/krb5 jtreg tests passed
Yes, seems like we already partially have this fix because of the way JDK-8077102 was backported. It makes sense to bring `useAddresses` into line with this and get rid of `getBooleanValue` rather than having a different method for each boolean property.
Backport looks good. Please add `jdk8u-fix-request` and an appropriate comment to the bug to request approval.
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/367#pullrequestreview-1632253916
More information about the jdk8u-dev
mailing list