From serb at openjdk.org  Mon Apr  1 00:18:36 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Mon, 1 Apr 2024 00:18:36 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests.
In-Reply-To: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
Message-ID: <8SFw8tCrXdotkDRantWzv0yOw3bpVnbo892d9oBxV4A=.b5c2c026-b328-436c-ae0c-ca44cf9d9971@github.com>

On Mon, 4 Mar 2024 02:36:32 GMT, yaqsun <duke at openjdk.org> wrote:

> the two cases no longer exist in the high version jdk, so backport is not performed
> jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java
> jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh

The test is still [there](https://github.com/openjdk/jdk8u-dev/blob/66fa62a441498d5e5da6773d1acb3085864d49ca/jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh#L26) in the jdk8u-dev:

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2028961884

From duke at openjdk.org  Mon Apr  1 05:53:03 2024
From: duke at openjdk.org (yaqsun)
Date: Mon, 1 Apr 2024 05:53:03 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v2]
In-Reply-To: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
Message-ID: <Ki3-QoiAiHW3QRmQATu374qkH6QWoDhd2eDKtPjquig=.86db5f68-4bf3-4b81-ba7d-05621252efc6@github.com>

> This backport has modified the following aspects:
> 
> -  there are 53 cases that do not exist: 
> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
> jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button
> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.j...

yaqsun has updated the pull request incrementally with one additional commit since the last revision:

  Backport 34afeced211cd7115e2529b043c1e57dfa1291fe

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/464/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/464/files/008dff40..5b8b0b82

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=00-01

  Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464

PR: https://git.openjdk.org/jdk8u-dev/pull/464

From duke at openjdk.org  Mon Apr  1 06:16:35 2024
From: duke at openjdk.org (yaqsun)
Date: Mon, 1 Apr 2024 06:16:35 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests.
In-Reply-To: <8SFw8tCrXdotkDRantWzv0yOw3bpVnbo892d9oBxV4A=.b5c2c026-b328-436c-ae0c-ca44cf9d9971@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
 <8SFw8tCrXdotkDRantWzv0yOw3bpVnbo892d9oBxV4A=.b5c2c026-b328-436c-ae0c-ca44cf9d9971@github.com>
Message-ID: <6J-0FjWLX8owacwq8WG-BCVXPChOMSibLUUbY1se08U=.b01734ef-dc79-41f9-b1f6-2e57de8bf0cd@github.com>

On Mon, 1 Apr 2024 00:15:32 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> > the two cases no longer exist in the high version jdk, so backport is not performed
> > jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.java
> > jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh
> 
> The test is still [there](https://github.com/openjdk/jdk8u-dev/blob/66fa62a441498d5e5da6773d1acb3085864d49ca/jdk/test/java/awt/appletviewer/IOExceptionIfEncodedURLTest/IOExceptionIfEncodedURLTest.sh#L26) in the jdk8u-dev:

The above two cases have been backport and updated with descriptions.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2029227977

From jjiang at openjdk.org  Mon Apr  1 09:11:38 2024
From: jjiang at openjdk.org (John Jiang)
Date: Mon, 1 Apr 2024 09:11:38 GMT
Subject: [jdk8u-dev] RFR: 8168518: rcache interop with krb5-1.15
In-Reply-To: <slsMeAW8vSXlhwEhau-PZPJ6uesp9GIZOnq4vbGOU-M=.267faab8-c954-4a0f-85b6-ec8777c1024e@github.com>
References: <slsMeAW8vSXlhwEhau-PZPJ6uesp9GIZOnq4vbGOU-M=.267faab8-c954-4a0f-85b6-ec8777c1024e@github.com>
Message-ID: <Ei91g9Mi0bOEhWHpNg41XFfELvtk4wZujKRmT-Z_yMg=.b35d619d-581a-44f5-bc5b-be99af1b3f5e@github.com>

On Thu, 11 Jan 2024 22:34:19 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

> I'd like to backport JDK-8168518 to update rcache hash algorithm from MD5 to SHA-256. It fixes issues on the FIPS environment without MD5 digest support
> 
> Implementation classes are applied cleanly.
> 
> Test changes are merged manually:
> - Changes in the Proc.java are skipped because of no module support in JDK8
> - "-Dsun.net.spi.nameservice.provider.1=ns,mock" option is added to rcache_usemd5.sh
> - ReplayCacheTestProc.java is merged manually because of JDK-8190690 changes in JDK8
> 
> sun/security/krb5/auto tests passed

jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java line 28:

> 26:  * @bug 7152176 8168518
> 27:  * @summary More krb5 tests
> 28:  * @library ../../../../java/security/testlibrary/

The library path `/test/lib` looks missing.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/418#discussion_r1546141680

From serb at openjdk.org  Tue Apr  2 15:45:37 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 2 Apr 2024 15:45:37 GMT
Subject: [jdk8u-dev] RFR: 8203691: [TESTBUG] Test
 /runtime/containers/cgroup/PlainRead.java fails
Message-ID: <5vv4FF6QFtnypr0WuvCxMvw016sFMJYOM9sWBl2f8SE=.c242c7e7-885d-4d93-b023-6e1479071fd2@github.com>

Hi all,

This pull request contains a backport of commit [2fa6eac4](https://github.com/openjdk/jdk11u-dev/commit/2fa6eac464048176087092c91c8430781ab15301) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.

The commit being backported was authored by Bob Vandette on 12 Jun 2018 and was reviewed by David Holmes, Mikhailo Seledtsov and Robbin Ehn.

Thanks!

-------------

Commit messages:
 - Backport 2fa6eac464048176087092c91c8430781ab15301

Changes: https://git.openjdk.org/jdk8u-dev/pull/477/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=477&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8203691
  Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/477.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/477/head:pull/477

PR: https://git.openjdk.org/jdk8u-dev/pull/477

From imyers at openjdk.org  Tue Apr  2 16:59:21 2024
From: imyers at openjdk.org (Ian Myers)
Date: Tue, 2 Apr 2024 16:59:21 GMT
Subject: [jdk8u-dev] RFR: 8329544: [8u]
 sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary
Message-ID: <uTOj3lmPUJQ1yAfGLjjlo97SiwYAwIIR4JOmhDsWkvg=.f11aa8ff-e7ee-4b50-9d8d-8dddb4e3b593@github.com>

`sun/security/krb5/auto/ReplayCacheTestProc.java` fails on jdk8u-412 due to a compilation error. This is because the classpath is being set incorrectly by the `@library` annotation.


TEST: sun/security/krb5/auto/ReplayCacheTestProc.java
TEST JDK: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image

ACTION: compile -- Failed. Compilation failed: Compilation failed
REASON: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
TIME:   0.752 seconds
messages:
command: compile -XDignore.symbol.file /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java
reason: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
Mode: agentvm
Agent id: 1
elapsed time (seconds): 0.752
configuration:
Boot Layer (javac runtime environment)
  class path: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
              /local/home/ianrichr/openjdk/jtreg/lib/javatest.jar
              /local/home/ianrichr/openjdk/jtreg/lib/jtreg.jar

javac compilation environment
  source path: /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
               /local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary
  class path:  /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
               /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto
               /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar

rerun:
cd /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/scratch/0 && \
HOME=/home/ianrichr \
LANG=en_US.UTF-8 \
PATH=/bin:/usr/bin:/usr/sbin \
    /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/javac \
        -J-ea \
        -J-esa \
        -J-Xmx512m \
        -J-Dtest.vm.opts='-ea -esa -Xmx512m' \
        -J-Dtest.tool.vm.opts='-J-ea -J-esa -J-Xmx512m' \
        -J-Dtest.compiler.opts= \
        -J-Dtest.java.opts= \
        -J-Dtest.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
        -J-Dcompile.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
        -J-Dtest.timeout.factor=4.0 \
        -J-Dtest.root=/local/home/ianrichr/openjdk/jdk8u/jdk/test \
        -J-Dtest.name=sun/security/krb5/auto/ReplayCacheTestProc.java \
        -J-Dtest.file=/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java \
        -J-Dtest.src=/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto \
        -J-Dtest.src.path=/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary \
        -J-Dtest.classes=/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto \
        -J-Dtest.class.path=/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/java/security/testlibrary \
        -J-Dtest.class.path.prefix=/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto \
        -d /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto \
        -sourcepath /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary \
        -classpath /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto:/local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto:/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar \
        -XDignore.symbol.file /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java
direct:
/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java:46: error: package jdk.test.lib does not exist
import jdk.test.lib.Platform;
                   ^
/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java:138: error: cannot find symbol
                if (Platform.isOSX() || Platform.isWindows()) {
                    ^
  symbol:   variable Platform
  location: class ReplayCacheTestProc
/local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java:138: error: cannot find symbol
                if (Platform.isOSX() || Platform.isWindows()) {
                                        ^
  symbol:   variable Platform
  location: class ReplayCacheTestProc
Note: /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/KDC.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
3 errors

TEST RESULT: Failed. Compilation failed: Compilation failed
--------------------------------------------------
Test results: failed: 1
Report written to /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTreport/html/report.html
Results written to /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork
Error: Some tests failed or other problems occurred.
Summary: jdk_adhoc
FAILED: sun/security/krb5/auto/ReplayCacheTestProc.java


Appending `/test/lib` to the `@library` annotation allows the compilation to succeed and the test passes.


Passed: sun/security/krb5/auto/ReplayCacheTestProc.java
Test results: passed: 1


This was introduced with this PR/issue https://bugs.openjdk.org/browse/JDK-8168518 when the `import jdk.test.lib.Platform;` was added to the test file.

-------------

Commit messages:
 - Add /test/lib path to @library in sun/security/krb5/auto/ReplayCacheTestProc.java

Changes: https://git.openjdk.org/jdk8u-dev/pull/478/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=478&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329544
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/478.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/478/head:pull/478

PR: https://git.openjdk.org/jdk8u-dev/pull/478

From shade at openjdk.org  Tue Apr  2 17:07:08 2024
From: shade at openjdk.org (Aleksey Shipilev)
Date: Tue, 2 Apr 2024 17:07:08 GMT
Subject: [jdk8u-dev] RFR: 8329544: [8u]
 sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary
In-Reply-To: <uTOj3lmPUJQ1yAfGLjjlo97SiwYAwIIR4JOmhDsWkvg=.f11aa8ff-e7ee-4b50-9d8d-8dddb4e3b593@github.com>
References: <uTOj3lmPUJQ1yAfGLjjlo97SiwYAwIIR4JOmhDsWkvg=.f11aa8ff-e7ee-4b50-9d8d-8dddb4e3b593@github.com>
Message-ID: <sbKfIgUwNxdyEAc_RkYbqxGkM2192YMzbXrsdx_bCwU=.5cc35a5a-6bb6-40df-b86d-3cc0d3ac03ce@github.com>

On Tue, 2 Apr 2024 16:48:49 GMT, Ian Myers <imyers at openjdk.org> wrote:

> `sun/security/krb5/auto/ReplayCacheTestProc.java` fails on jdk8u-412 due to a compilation error. This is because the classpath is being set incorrectly by the `@library` annotation.
> 
> 
> TEST: sun/security/krb5/auto/ReplayCacheTestProc.java
> TEST JDK: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image
> 
> ACTION: compile -- Failed. Compilation failed: Compilation failed
> REASON: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
> TIME:   0.752 seconds
> messages:
> command: compile -XDignore.symbol.file /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java
> reason: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
> Mode: agentvm
> Agent id: 1
> elapsed time (seconds): 0.752
> configuration:
> Boot Layer (javac runtime environment)
>   class path: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
>               /local/home/ianrichr/openjdk/jtreg/lib/javatest.jar
>               /local/home/ianrichr/openjdk/jtreg/lib/jtreg.jar
> 
> javac compilation environment
>   source path: /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
>                /local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary
>   class path:  /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
>                /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto
>                /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
> 
> rerun:
> cd /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/scratch/0 && \
> HOME=/home/ianrichr \
> LANG=en_US.UTF-8 \
> PATH=/bin:/usr/bin:/usr/sbin \
>     /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/javac \
>         -J-ea \
>         -J-esa \
>         -J-Xmx512m \
>         -J-Dtest.vm.opts='-ea -esa -Xmx512m' \
>         -J-Dtest.tool.vm.opts='-J-ea -J-esa -J-Xmx512m' \
>         -J-Dtest.compiler.opts= \
>         -J-Dtest.java.opts= \
>         -J-Dtest.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
>         -J-Dcompile.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
>         -J-Dtest.timeout.factor=4.0 \
>         -J-Dtest.root=/local/home/ianrichr/openjdk/j...

This really looks like an omission in the 8u backport. The original change does add `/test/lib`: https://github.com/openjdk/jdk/commit/e10da9956fba577bcc097b63eb3b4d09896fa77d?diff=unified&w=0#diff-a66e8361b5d10cd8f8bff535c2759ad4f2e4bdbbd2368ddf5c644bce77e5aa18R28

-------------

Marked as reviewed by shade (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/478#pullrequestreview-1974437626

From imyers at openjdk.org  Tue Apr  2 17:25:13 2024
From: imyers at openjdk.org (Ian Myers)
Date: Tue, 2 Apr 2024 17:25:13 GMT
Subject: [jdk8u-dev] RFR: 8168518: rcache interop with krb5-1.15
In-Reply-To: <Ei91g9Mi0bOEhWHpNg41XFfELvtk4wZujKRmT-Z_yMg=.b35d619d-581a-44f5-bc5b-be99af1b3f5e@github.com>
References: <slsMeAW8vSXlhwEhau-PZPJ6uesp9GIZOnq4vbGOU-M=.267faab8-c954-4a0f-85b6-ec8777c1024e@github.com>
 <Ei91g9Mi0bOEhWHpNg41XFfELvtk4wZujKRmT-Z_yMg=.b35d619d-581a-44f5-bc5b-be99af1b3f5e@github.com>
Message-ID: <j58fBx5e8_BkAImGYl8S0qSfMcLvb3NuE8P_8gVZm0A=.818ff43b-df29-4d0a-b26a-bac647be8705@github.com>

On Mon, 1 Apr 2024 09:09:22 GMT, John Jiang <jjiang at openjdk.org> wrote:

>> I'd like to backport JDK-8168518 to update rcache hash algorithm from MD5 to SHA-256. It fixes issues on the FIPS environment without MD5 digest support
>> 
>> Implementation classes are applied cleanly.
>> 
>> Test changes are merged manually:
>> - Changes in the Proc.java are skipped because of no module support in JDK8
>> - "-Dsun.net.spi.nameservice.provider.1=ns,mock" option is added to rcache_usemd5.sh
>> - ReplayCacheTestProc.java is merged manually because of JDK-8190690 changes in JDK8
>> 
>> sun/security/krb5/auto tests passed
>
> jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java line 28:
> 
>> 26:  * @bug 7152176 8168518
>> 27:  * @summary More krb5 tests
>> 28:  * @library ../../../../java/security/testlibrary/
> 
> The library path `/test/lib` looks missing.

I have made a PR for this exact problem: https://github.com/openjdk/jdk8u-dev/pull/478

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/418#discussion_r1548281807

From sgehwolf at openjdk.org  Fri Apr  5 13:54:12 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 5 Apr 2024 13:54:12 GMT
Subject: [jdk8u-dev] RFR: 8291226: Create Test Cases to cover scenarios for
 JDK-8278067 [v5]
In-Reply-To: <LyeaVG9c16fEikK9_DqzNPMd844jVwCxnDnYTFqK8SU=.21a3299d-6bdf-4f36-950c-4666d79bfc05@github.com>
References: <iBvJmnmAZUE-w3dELQZ_c1x8CCAN3QN9DN4oKdeeXNQ=.4117a7cc-2d28-4534-a511-529b6652e440@github.com>
 <LyeaVG9c16fEikK9_DqzNPMd844jVwCxnDnYTFqK8SU=.21a3299d-6bdf-4f36-950c-4666d79bfc05@github.com>
Message-ID: <E21_Pwnkeg3p0eHS0HzwJGm5jKixso8DNpSy1cYWFq4=.75489f0d-c214-4bdf-bd3a-0c69112e3bbe@github.com>

On Tue, 26 Mar 2024 16:52:55 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
>
> Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - Merge master
>  - Merge branch 'pr/466' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8291226
>  - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07
>  - Adjusting the indentation according to 11u.
>  - Adjusting the library paths
>  - 8291226: Create Test Cases to cover scenarios for JDK-8278067
>    
>    Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
>  - Merge branch 'master' into Backport-JDK-8278067
>  - Remove SystemProperty tag as it is not supported in JDK8
>  - Fix indentation
>  - Backport d8f44aa39e921594505864e6270f42b745265293
>  - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/039fb8aa...7a3e3fd9

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/453#pullrequestreview-1983249721

From sgehwolf at openjdk.org  Fri Apr  5 14:18:11 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 5 Apr 2024 14:18:11 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
Message-ID: <4Zza-0Q4nGMQY0Zi01t_ZIPSQErlOYxhCV9OoBSzHvk=.a3e55042-f3a9-4208-9d41-99e7f065310b@github.com>

On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
> 
> What follows is Thomas' introduction from the original PR:
> 
> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
> 
> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
> 
> ~~~
> java.lang.RuntimeException: zipfile: zip64 end failed
> 	at ReadZip.main(ReadZip.java:209)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> ~~~
> 
> With the fix applied the test passes:
> 
> ~~~
> Passed: java/util/zip/ZipFile/ReadZip.java
> ~~~
> 
> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
> ~~~
> Test results: passed: 3,122
> ~~~
> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
> 
> Thank you,
> Thomas

@gnu-andrew @fitzsim I concur with @tstuefe: What are the changes in `zip_util.c` about? I don't see them in jdk head either... Should that be a separate bug that then needs backporting?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2039917881

From sgehwolf at openjdk.org  Fri Apr  5 14:28:11 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 5 Apr 2024 14:28:11 GMT
Subject: [jdk8u-dev] RFR: 8318410:
 jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese
 Windows
In-Reply-To: <wEuB6WuiMXPQ7LcM6HvuGHUvi-diLAT09Petd7S7POY=.9a8f82cc-f1d6-4192-a3c5-5a3e5bf7b529@github.com>
References: <wEuB6WuiMXPQ7LcM6HvuGHUvi-diLAT09Petd7S7POY=.9a8f82cc-f1d6-4192-a3c5-5a3e5bf7b529@github.com>
Message-ID: <YuCo8YG43UNeEEXAjjNPNa8K-MsfXn3JPFNugH63Mvo=.359239cf-c1d4-48d7-a748-93252db44627@github.com>

On Tue, 13 Feb 2024 12:07:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> I would like to fix this issue because the test dose not work as intended. 8318410 resolved two issues. However, the first issue related to JEP400 is not relevant to JDK8. Therefore, I would like to backport only the second issue, which is the problem of tests not running properly on Windows cygwin. The fix applis cleanly to 8u from 17u.

@ktakakuri Please apply for approval. See https://github.com/openjdk/jdk8u-dev/pull/440#issuecomment-1941928022

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/440#issuecomment-2039940593

From sgehwolf at openjdk.org  Fri Apr  5 14:42:14 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 5 Apr 2024 14:42:14 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v2]
In-Reply-To: <CYfEn1cJYBChGfNEPwP12MicVlc_rPcc7EKFnZiDx28=.9dad6117-b528-491a-86f1-5122c2a680ef@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
 <CYfEn1cJYBChGfNEPwP12MicVlc_rPcc7EKFnZiDx28=.9dad6117-b528-491a-86f1-5122c2a680ef@github.com>
Message-ID: <9eC_UIOB5PkSmj4TwDT_0ddr7CBp0ix9iUAO-Li9r_A=.2753e464-eebb-45ab-843e-59f6ea1bf6f0@github.com>

On Mon, 25 Mar 2024 18:29:42 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.
>> 
>> Thanks!
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Same logic different file

hotspot/src/os/aix/vm/os_aix.cpp line 1455:

> 1453: // Loads .dll/.so and in case of error it checks if .dll/.so was built
> 1454: // for the same architecture as Hotspot is running on.
> 1455: static void* dll_load(const char *filename, char *ebuf, int ebuflen) {

Are you sure this is correct? The [JDK 11u](https://github.com/openjdk/jdk11u-dev/commit/6808c5c89d1e30f481ebe444f93175232bcd30e2#diff-5f68fc3ce77d56a6e5a398c51eb1e1b56ea41175e8a86a1c5d92e167ba2b2b40R1316) change renamed this to `dll_load_library`. Does this even work?

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/473#discussion_r1553772106

From phh at openjdk.org  Fri Apr  5 14:57:13 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Fri, 5 Apr 2024 14:57:13 GMT
Subject: [jdk8u-dev] Integrated: 8313081: MonitoringSupport_lock should be
 unconditionally initialized after 8304074
In-Reply-To: <6LxrLQHMrJSJlnbUFdcKFjO7aiZCLeMSobLxCZZcA4o=.620ecc4c-a0e6-454c-a545-8eaa734caef9@github.com>
References: <6LxrLQHMrJSJlnbUFdcKFjO7aiZCLeMSobLxCZZcA4o=.620ecc4c-a0e6-454c-a545-8eaa734caef9@github.com>
Message-ID: <P_PcxRuIuALcietuFRUl8byGORHGG-e9atiKzpLoLDY=.e6b59af6-826f-42ec-a5ac-ae597040c709@github.com>

On Wed, 27 Mar 2024 21:40:48 GMT, Paul Hohensee <phh at openjdk.org> wrote:

> This is a replacement for https://github.com/openjdk/jdk8u-dev/pull/393 and is identical to it.
> 
> Follow-on bug fix for [JDK-8304074](https://bugs.openjdk.org/browse/JDK-8304074) backport. Unclean backport from 11u, see https://github.com/openjdk/jdk11u-dev/pull/2287. Other than file location and context, the lock definition macro changed between 8 and 11, so the definition of MonitoringSupport_lock is different.

This pull request has now been integrated.

Changeset: af033c67
Author:    Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/af033c67fda11807f1de52c0ab1cdf840a839cb0
Stats:     17 lines in 3 files changed: 12 ins; 2 del; 3 mod

8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074

Reviewed-by: simonis
Backport-of: a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/475

From sroy at openjdk.org  Fri Apr  5 15:15:12 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Fri, 5 Apr 2024 15:15:12 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v2]
In-Reply-To: <9eC_UIOB5PkSmj4TwDT_0ddr7CBp0ix9iUAO-Li9r_A=.2753e464-eebb-45ab-843e-59f6ea1bf6f0@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
 <CYfEn1cJYBChGfNEPwP12MicVlc_rPcc7EKFnZiDx28=.9dad6117-b528-491a-86f1-5122c2a680ef@github.com>
 <9eC_UIOB5PkSmj4TwDT_0ddr7CBp0ix9iUAO-Li9r_A=.2753e464-eebb-45ab-843e-59f6ea1bf6f0@github.com>
Message-ID: <UQaAL2isRfnFRdL9goSEEAgEXja2FeXf3EAiOV_TXzk=.ea254c85-d53a-446e-9e24-d46f7f73ae93@github.com>

On Fri, 5 Apr 2024 14:38:46 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Same logic different file
>
> hotspot/src/os/aix/vm/os_aix.cpp line 1455:
> 
>> 1453: // Loads .dll/.so and in case of error it checks if .dll/.so was built
>> 1454: // for the same architecture as Hotspot is running on.
>> 1455: static void* dll_load(const char *filename, char *ebuf, int ebuflen) {
> 
> Are you sure this is correct? The [JDK 11u](https://github.com/openjdk/jdk11u-dev/commit/6808c5c89d1e30f481ebe444f93175232bcd30e2#diff-5f68fc3ce77d56a6e5a398c51eb1e1b56ea41175e8a86a1c5d92e167ba2b2b40R1316) change renamed this to `dll_load_library`. Does this even work?

@jerboaa  Still working on it. 11 and 17 backports were very much clean and had no issues. For some reason jdk8 compilation is failing in my local. So hopefully i will get it working soon.

@jerboaa  thanks for the catch. That might be causing it. I had to make changes in a file located in different location , so the backport didn't apply clean.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/473#discussion_r1553835085
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/473#discussion_r1553838079

From sroy at openjdk.org  Fri Apr  5 15:18:24 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Fri, 5 Apr 2024 15:18:24 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v3]
In-Reply-To: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
Message-ID: <bpNu8QTN2OXew11ngT26ZjdNvWcyjJK5kW5OJG9u714=.45612450-01ed-4472-950a-4699c9ea06f3@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.
> 
> Thanks!

Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:

  rename method

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/473/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/473/files/dafec068..beb289f4

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=473&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=473&range=01-02

  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/473.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/473/head:pull/473

PR: https://git.openjdk.org/jdk8u-dev/pull/473

From dhanalla at openjdk.org  Fri Apr  5 15:23:11 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Fri, 5 Apr 2024 15:23:11 GMT
Subject: [jdk8u-dev] RFR: 8291226: Create Test Cases to cover scenarios for
 JDK-8278067 [v5]
In-Reply-To: <E21_Pwnkeg3p0eHS0HzwJGm5jKixso8DNpSy1cYWFq4=.75489f0d-c214-4bdf-bd3a-0c69112e3bbe@github.com>
References: <iBvJmnmAZUE-w3dELQZ_c1x8CCAN3QN9DN4oKdeeXNQ=.4117a7cc-2d28-4534-a511-529b6652e440@github.com>
 <LyeaVG9c16fEikK9_DqzNPMd844jVwCxnDnYTFqK8SU=.21a3299d-6bdf-4f36-950c-4666d79bfc05@github.com>
 <E21_Pwnkeg3p0eHS0HzwJGm5jKixso8DNpSy1cYWFq4=.75489f0d-c214-4bdf-bd3a-0c69112e3bbe@github.com>
Message-ID: <LyoPMr6BJNpc-RgSxQ-NIikV9Z-z3o-yOmEBmpKjCiQ=.a1c00058-a2ae-494b-8593-bb930f2340e7@github.com>

On Fri, 5 Apr 2024 13:51:42 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> LGTM.
Thanks @jerboaa for reviewing this PR. I've added a JDK8 patch request to the bug as the next step.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/453#issuecomment-2040074343

From duke at openjdk.org  Fri Apr  5 16:31:09 2024
From: duke at openjdk.org (fitzsim)
Date: Fri, 5 Apr 2024 16:31:09 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <PSyf18PRNEiwpksqa1UVty5xVcd2sESNzKABQwHK3Yk=.7a7da105-00c9-4bf6-b0d1-c0f0201e8aa9@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
 <PSyf18PRNEiwpksqa1UVty5xVcd2sESNzKABQwHK3Yk=.7a7da105-00c9-4bf6-b0d1-c0f0201e8aa9@github.com>
Message-ID: <vfqfzbrphBERKHRwAOIStzcDUPKe4pfUs_0LhBS2yTw=.c10d582a-7ddf-4c64-b72a-4dcad5b63d54@github.com>

On Wed, 20 Mar 2024 15:23:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
>> 
>> What follows is Thomas' introduction from the original PR:
>> 
>> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
>> 
>> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
>> 
>> ~~~
>> java.lang.RuntimeException: zipfile: zip64 end failed
>> 	at ReadZip.main(ReadZip.java:209)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> 	at java.lang.reflect.Method.invoke(Method.java:498)
>> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>> 	at java.lang.Thread.run(Thread.java:750)
>> ~~~
>> 
>> With the fix applied the test passes:
>> 
>> ~~~
>> Passed: java/util/zip/ZipFile/ReadZip.java
>> ~~~
>> 
>> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
>> ~~~
>> Test results: passed: 3,122
>> ~~~
>> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
>> 
>> Thank you,
>> Thomas
>
>> I verified that the patch applies cleanly to jdk8u-dev master. 
> 
> I'm confused. The original patch https://hg.openjdk.org/jdk10/master/rev/723486922bfe touches ZipFile.java, not zip_util.c. How is this a clean apply? AFAICS this patch re-implements part of the original patch.

Sorry for the delay in replying; I did not notice that @tstuefe had commented.  Thanks for reviewing @jerboaa and @tstuefe .

I did the zip_util.c change to fix this Windows build failure (from my notes, because I cannot find the run in GitHub Actions anymore):


2024-02-15T23:16:09.7594742Z zip_util.c
2024-02-15T23:16:09.7614547Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(601) : error C2143: syntax error : missing ';' before 'type'
2024-02-15T23:16:09.7630440Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(602) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7634131Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(602) : warning C4022: 'findEND64' : pointer mismatch for actual parameter 2
2024-02-15T23:16:09.7637070Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7698807Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7704889Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7710221Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7719684Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7725741Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7728339Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7744006Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(604) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7746613Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7768297Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7779205Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7818211Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7820739Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7823157Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7841271Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7843802Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(605) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7850043Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7857203Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7877689Z make[2]: *** [lib/CoreLibraries.gmk:285: /cygdrive/d/a/jdk8u-dev/jdk8u-dev/jdk/build/windows-x86/jdk/objs/libzip/zip_util.obj] Error 2
2024-02-15T23:16:09.7880764Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7901316Z make[2]: *** Waiting for unfinished jobs....
2024-02-15T23:16:09.7904955Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7908669Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7919215Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7922355Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7924744Z d:/a/jdk8u-dev/jdk8u-dev/jdk/jdk/src/share/native/java/util/zip/zip_util.c(606) : error C2065: 'end64buf' : undeclared identifier
2024-02-15T23:16:09.7926720Z zutil.c
2024-02-15T23:16:09.8678783Z make[1]: *** [BuildJdk.gmk:70: libs-only] Error 2
2024-02-15T23:16:09.8979013Z make: *** [/cygdrive/d/a/jdk8u-dev/jdk8u-dev/jdk//make/Main.gmk:117: jdk-only] Error 2
2024-02-15T23:16:09.9840583Z ##[error]Process completed with exit code 1.


The older compiler on that build machine needed the end64buf declaration to be at the start of the function.

I do see end64buf is declared in the same place in zip_util.c on jdk master, so it would make more sense to start there and backport that change separately.  But now I wonder why no one else has seen this and fixed it already.

I think my next step should be to change this pull request to remove the zip_util.c part and see if the builders pass.  If they do, then this review can proceed.  If they don't, then I will file a jdk/master bug with the relevant explanation and pointers to GHA logs.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040216482

From duke at openjdk.org  Fri Apr  5 16:44:10 2024
From: duke at openjdk.org (fitzsim)
Date: Fri, 5 Apr 2024 16:44:10 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <PSyf18PRNEiwpksqa1UVty5xVcd2sESNzKABQwHK3Yk=.7a7da105-00c9-4bf6-b0d1-c0f0201e8aa9@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
 <PSyf18PRNEiwpksqa1UVty5xVcd2sESNzKABQwHK3Yk=.7a7da105-00c9-4bf6-b0d1-c0f0201e8aa9@github.com>
Message-ID: <77tVR5P-VBMhbDt4jifpwk6aCVKPQTiXuZR8ehL4c-Y=.5f4b17c6-76b8-45fc-b49d-478e989c50e2@github.com>

On Wed, 20 Mar 2024 15:23:45 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
>> 
>> What follows is Thomas' introduction from the original PR:
>> 
>> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
>> 
>> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
>> 
>> ~~~
>> java.lang.RuntimeException: zipfile: zip64 end failed
>> 	at ReadZip.main(ReadZip.java:209)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> 	at java.lang.reflect.Method.invoke(Method.java:498)
>> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>> 	at java.lang.Thread.run(Thread.java:750)
>> ~~~
>> 
>> With the fix applied the test passes:
>> 
>> ~~~
>> Passed: java/util/zip/ZipFile/ReadZip.java
>> ~~~
>> 
>> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
>> ~~~
>> Test results: passed: 3,122
>> ~~~
>> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
>> 
>> Thank you,
>> Thomas
>
>> I verified that the patch applies cleanly to jdk8u-dev master. 
> 
> I'm confused. The original patch https://hg.openjdk.org/jdk10/master/rev/723486922bfe touches ZipFile.java, not zip_util.c. How is this a clean apply? AFAICS this patch re-implements part of the original patch.

(From what I can tell, I will not receive GitHub email updates just for comments on this pull request because I did not file it -- that is why I did not receive a notification for @tstuefe's initial question.  I will try to visit this/refresh this more often, and @jerboaa's mention of me did send a notification.  See also https://github.com/orgs/community/discussions/44376)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040239049

From sgehwolf at openjdk.org  Fri Apr  5 16:57:09 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 5 Apr 2024 16:57:09 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <77tVR5P-VBMhbDt4jifpwk6aCVKPQTiXuZR8ehL4c-Y=.5f4b17c6-76b8-45fc-b49d-478e989c50e2@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
 <PSyf18PRNEiwpksqa1UVty5xVcd2sESNzKABQwHK3Yk=.7a7da105-00c9-4bf6-b0d1-c0f0201e8aa9@github.com>
 <77tVR5P-VBMhbDt4jifpwk6aCVKPQTiXuZR8ehL4c-Y=.5f4b17c6-76b8-45fc-b49d-478e989c50e2@github.com>
Message-ID: <ZqMYici39nszU8-3OeUFP5MYjElt1wGZKp4EvX9LL14=.b64e23e0-2b13-4c68-8b45-ebc1f70422f1@github.com>

On Fri, 5 Apr 2024 16:41:55 GMT, fitzsim <duke at openjdk.org> wrote:

>>> I verified that the patch applies cleanly to jdk8u-dev master. 
>> 
>> I'm confused. The original patch https://hg.openjdk.org/jdk10/master/rev/723486922bfe touches ZipFile.java, not zip_util.c. How is this a clean apply? AFAICS this patch re-implements part of the original patch.
>
> (From what I can tell, I will not receive GitHub email updates just for comments on this pull request because I did not file it -- that is why I did not receive a notification for @tstuefe's initial question.  I will try to visit this/refresh this more often, and @jerboaa's mention of me did send a notification.  See also https://github.com/orgs/community/discussions/44376)

@fitzsim Yes, please remove the `zip_util.c` changes. Then we can proceed with reviewing. Different question: Is there a reason why you didn't submit this PR for review?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040258527

From duke at openjdk.org  Fri Apr  5 16:57:10 2024
From: duke at openjdk.org (fitzsim)
Date: Fri, 5 Apr 2024 16:57:10 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
Message-ID: <lesm8e8-MZxNw2xyxihmRHp9VB7aDPp2hPyFWahon0o=.d9a76262-5624-4cf8-a7ce-afb461b498eb@github.com>

On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
> 
> What follows is Thomas' introduction from the original PR:
> 
> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
> 
> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
> 
> ~~~
> java.lang.RuntimeException: zipfile: zip64 end failed
> 	at ReadZip.main(ReadZip.java:209)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> ~~~
> 
> With the fix applied the test passes:
> 
> ~~~
> Passed: java/util/zip/ZipFile/ReadZip.java
> ~~~
> 
> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
> ~~~
> Test results: passed: 3,122
> ~~~
> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
> 
> Thank you,
> Thomas

I will also investigate whether the `zip_util.c` changes in @gnu-andrew's commit, https://github.com/openjdk/jdk8u-dev/pull/452/commits/462cd916c26f9745abca2cfd78ed8d1107db9f0c, should be a separate backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040259310

From dhanalla at openjdk.org  Fri Apr  5 17:02:13 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Fri, 5 Apr 2024 17:02:13 GMT
Subject: [jdk8u-dev] Integrated: 8291226: Create Test Cases to cover scenarios
 for JDK-8278067
In-Reply-To: <iBvJmnmAZUE-w3dELQZ_c1x8CCAN3QN9DN4oKdeeXNQ=.4117a7cc-2d28-4534-a511-529b6652e440@github.com>
References: <iBvJmnmAZUE-w3dELQZ_c1x8CCAN3QN9DN4oKdeeXNQ=.4117a7cc-2d28-4534-a511-529b6652e440@github.com>
Message-ID: <oRSXHyXCRsd_kdPaCbZK9Q_G6cO8ydDKkc1Qpd15G24=.beb17c7a-79dc-43fe-8559-7b62c4eb0070@github.com>

On Wed, 21 Feb 2024 20:12:54 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
> 
> Clean backport from JDK11u patch.
> 
> Test performed:
> 
> 1. JTreg jdk_tier1, hotspot_tier1
> 2. JTreg jdk_tier2
> 3. The backported test case in this PR passed.

This pull request has now been integrated.

Changeset: a4b40e84
Author:    Dhamoder Nalla <dhanalla at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/a4b40e846b77b6b28127ee9cf3e127c6434b6c81
Stats:     1277 lines in 1 file changed: 1277 ins; 0 del; 0 mod

8291226: Create Test Cases to cover scenarios for JDK-8278067

Reviewed-by: sgehwolf
Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/453

From duke at openjdk.org  Fri Apr  5 17:04:12 2024
From: duke at openjdk.org (fitzsim)
Date: Fri, 5 Apr 2024 17:04:12 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <ZqMYici39nszU8-3OeUFP5MYjElt1wGZKp4EvX9LL14=.b64e23e0-2b13-4c68-8b45-ebc1f70422f1@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
 <PSyf18PRNEiwpksqa1UVty5xVcd2sESNzKABQwHK3Yk=.7a7da105-00c9-4bf6-b0d1-c0f0201e8aa9@github.com>
 <77tVR5P-VBMhbDt4jifpwk6aCVKPQTiXuZR8ehL4c-Y=.5f4b17c6-76b8-45fc-b49d-478e989c50e2@github.com>
 <ZqMYici39nszU8-3OeUFP5MYjElt1wGZKp4EvX9LL14=.b64e23e0-2b13-4c68-8b45-ebc1f70422f1@github.com>
Message-ID: <Vjc1gZulOxL4R9xtyyAOWasfOsIQ0mxieyQhwyZvq5g=.4e60109e-eac3-4da1-ab71-37a1639e7374@github.com>

On Fri, 5 Apr 2024 16:54:01 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> (From what I can tell, I will not receive GitHub email updates just for comments on this pull request because I did not file it -- that is why I did not receive a notification for @tstuefe's initial question.  I will try to visit this/refresh this more often, and @jerboaa's mention of me did send a notification.  See also https://github.com/orgs/community/discussions/44376)
>
> @fitzsim Yes, please remove the `zip_util.c` changes. Then we can proceed with reviewing. Different question: Is there a reason why you didn't submit this PR for review?

@jerboaa Yes, @gnu-andrew explained it in the first comment of this pull request:

> This is a re-do of https://github.com/openjdk/jdk8u-dev/pull/445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040265000

From duke at openjdk.org  Fri Apr  5 17:04:12 2024
From: duke at openjdk.org (fitzsim)
Date: Fri, 5 Apr 2024 17:04:12 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
Message-ID: <pYnD3p5uk0roRSXuB2D2usewZC2Tj_PazkhWtPBobr8=.68bcd0f7-5b20-4fe8-b160-605b7ed0d915@github.com>

On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
> 
> What follows is Thomas' introduction from the original PR:
> 
> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
> 
> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
> 
> ~~~
> java.lang.RuntimeException: zipfile: zip64 end failed
> 	at ReadZip.main(ReadZip.java:209)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> ~~~
> 
> With the fix applied the test passes:
> 
> ~~~
> Passed: java/util/zip/ZipFile/ReadZip.java
> ~~~
> 
> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
> ~~~
> Test results: passed: 3,122
> ~~~
> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
> 
> Thank you,
> Thomas

Basically, @gnu-andrew is the author, but I volunteered to do the submission process, and we are not sure how to represent that situation with the tooling.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040267963

From sgehwolf at openjdk.org  Fri Apr  5 17:07:10 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Fri, 5 Apr 2024 17:07:10 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <pYnD3p5uk0roRSXuB2D2usewZC2Tj_PazkhWtPBobr8=.68bcd0f7-5b20-4fe8-b160-605b7ed0d915@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
 <pYnD3p5uk0roRSXuB2D2usewZC2Tj_PazkhWtPBobr8=.68bcd0f7-5b20-4fe8-b160-605b7ed0d915@github.com>
Message-ID: <dm4q8_3tQVaKV_8LdYYbegsS1BuDxhxdHx9pcWKQd9A=.9952ec60-92db-4723-b5a6-3808298453b2@github.com>

On Fri, 5 Apr 2024 17:00:58 GMT, fitzsim <duke at openjdk.org> wrote:

> Basically, @gnu-andrew is the author, but I volunteered to do the submission process, and we are not sure how to represent that situation with the tooling.

I'm afraid, there is not much we can do but for @gnu-andrew to drive this (because of [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The only alternative is to erase some of the credit, which is probably not wanted.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040272329

From sroy at openjdk.org  Fri Apr  5 18:16:12 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Fri, 5 Apr 2024 18:16:12 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v2]
In-Reply-To: <9eC_UIOB5PkSmj4TwDT_0ddr7CBp0ix9iUAO-Li9r_A=.2753e464-eebb-45ab-843e-59f6ea1bf6f0@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
 <CYfEn1cJYBChGfNEPwP12MicVlc_rPcc7EKFnZiDx28=.9dad6117-b528-491a-86f1-5122c2a680ef@github.com>
 <9eC_UIOB5PkSmj4TwDT_0ddr7CBp0ix9iUAO-Li9r_A=.2753e464-eebb-45ab-843e-59f6ea1bf6f0@github.com>
Message-ID: <dDQAuW-AAsCqskxPqaETWw-KHgDjUaBk8Pk6d0nUNAA=.b160a808-a183-49bf-884e-49f0d036a8f1@github.com>

On Fri, 5 Apr 2024 14:38:46 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

>> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Same logic different file
>
> hotspot/src/os/aix/vm/os_aix.cpp line 1455:
> 
>> 1453: // Loads .dll/.so and in case of error it checks if .dll/.so was built
>> 1454: // for the same architecture as Hotspot is running on.
>> 1455: static void* dll_load(const char *filename, char *ebuf, int ebuflen) {
> 
> Are you sure this is correct? The [JDK 11u](https://github.com/openjdk/jdk11u-dev/commit/6808c5c89d1e30f481ebe444f93175232bcd30e2#diff-5f68fc3ce77d56a6e5a398c51eb1e1b56ea41175e8a86a1c5d92e167ba2b2b40R1316) change renamed this to `dll_load_library`. Does this even work?

@jerboaa I see the certificate tests failing in the tests. Are these due to some other issue ? I do not see how my fix would cause a certificate issue.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/473#discussion_r1554079699

From duke at openjdk.org  Fri Apr  5 19:13:12 2024
From: duke at openjdk.org (fitzsim)
Date: Fri, 5 Apr 2024 19:13:12 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
Message-ID: <jti7DP4DeV9zaZYc6XVX4a8aTip_le5QGq770GQunm8=.b80f85ee-c95d-46dc-8189-ae245fe89c98@github.com>

On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
> 
> What follows is Thomas' introduction from the original PR:
> 
> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
> 
> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
> 
> ~~~
> java.lang.RuntimeException: zipfile: zip64 end failed
> 	at ReadZip.main(ReadZip.java:209)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> ~~~
> 
> With the fix applied the test passes:
> 
> ~~~
> Passed: java/util/zip/ZipFile/ReadZip.java
> ~~~
> 
> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
> ~~~
> Test results: passed: 3,122
> ~~~
> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
> 
> Thank you,
> Thomas

I did more research: the C parts of the proposed changes are jdk8u-specific, so there are no equivalent parts of zip_util.c in newer branches from which to backport them.  They are there because they avoid the need to backport the entire large JDK9-era rewrite of the Java parts of Zip support to jdk8u.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040480862

From serb at openjdk.org  Fri Apr  5 19:45:12 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Fri, 5 Apr 2024 19:45:12 GMT
Subject: [jdk8u-dev] Integrated: 8203691: [TESTBUG] Test
 /runtime/containers/cgroup/PlainRead.java fails
In-Reply-To: <5vv4FF6QFtnypr0WuvCxMvw016sFMJYOM9sWBl2f8SE=.c242c7e7-885d-4d93-b023-6e1479071fd2@github.com>
References: <5vv4FF6QFtnypr0WuvCxMvw016sFMJYOM9sWBl2f8SE=.c242c7e7-885d-4d93-b023-6e1479071fd2@github.com>
Message-ID: <I59L0VLuQArIv55OVfj8Trts1TwcCBKhNRK0gWbUkH0=.4baec32f-1d50-419c-9eb7-c7140b9bbae1@github.com>

On Tue, 2 Apr 2024 05:32:06 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [2fa6eac4](https://github.com/openjdk/jdk11u-dev/commit/2fa6eac464048176087092c91c8430781ab15301) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Bob Vandette on 12 Jun 2018 and was reviewed by David Holmes, Mikhailo Seledtsov and Robbin Ehn.
> 
> Thanks!

This pull request has now been integrated.

Changeset: 1db6a760
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/1db6a7606c297fd87d5f143cac40e7652b94404c
Stats:     4 lines in 1 file changed: 0 ins; 3 del; 1 mod

8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails

Backport-of: 2fa6eac464048176087092c91c8430781ab15301

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/477

From dhanalla at openjdk.org  Fri Apr  5 20:23:17 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Fri, 5 Apr 2024 20:23:17 GMT
Subject: [jdk8u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close
 connection immediately [v4]
In-Reply-To: <bnu_bQbAL7WleYUmSrXBmvjAoPMK2VDNwWlWSUdZTfo=.cf6da58d-23a9-4178-a96f-a00a61fd7c50@github.com>
References: <bnu_bQbAL7WleYUmSrXBmvjAoPMK2VDNwWlWSUdZTfo=.cf6da58d-23a9-4178-a96f-a00a61fd7c50@github.com>
Message-ID: <vXukf3hnsoePeuM7yPwM5f2Q1cRIl6cHBg5WaNhI1dA=.e013c597-71ca-44dc-9077-d0003ea2d3f7@github.com>

> Backport of 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec

Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:

 - Merge master
 - adjust JDK8 library path
 - merge dependent pr/453
 - Merge branch 'pr/466' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8291226
 - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07
 - Adjusting the indentation according to 11u.
 - Adjusting the library paths
 - Backport 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec
 - 8291226: Create Test Cases to cover scenarios for JDK-8278067
   
   Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
 - Merge branch 'master' into Backport-JDK-8278067
 - ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/a4b40e84...e2fc39da

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/454/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=454&range=03
  Stats: 40 lines in 4 files changed: 29 ins; 8 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/454.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/454/head:pull/454

PR: https://git.openjdk.org/jdk8u-dev/pull/454

From t.glaser at qvest-digital.com  Sat Apr  6 15:52:01 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Sat, 6 Apr 2024 17:52:01 +0200 (CEST)
Subject: making sense of crashes in build logs
Message-ID: <1ab39069-857a-a4b2-9034-07db9f5fe1d8@qvest-digital.com>

Hi,

how do I make sense of crashes in buildd logs, such as:
https://buildd.debian.org/status/fetch.php?pkg=openjdk-8&arch=m68k&ver=8u402-ga-6&stamp=1711506075&raw=1

I saw?
#  Internal Error (os_linux_zero.cpp:254), pid=830846, tid=0x3f629440
? and thought, yay, we can look at where the segfault is,
but that address is the generic signal handler ?

Is there a way to get a backtrace into these messages?

Building locally in a VM would take? over a week, I think,
and gdb is also currently not very usable on m68k, at least
it wasn?t when I was trying to debug a different crash in a
different software?

Help with m68k is welcome in general; the last version that
built was 8u171-b11, the first to fail was 8u181-b13 and all
others since. Some patch probably needs updating or something.

Thanks,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From david.holmes at oracle.com  Mon Apr  8 05:47:26 2024
From: david.holmes at oracle.com (David Holmes)
Date: Mon, 8 Apr 2024 15:47:26 +1000
Subject: making sense of crashes in build logs
In-Reply-To: <1ab39069-857a-a4b2-9034-07db9f5fe1d8@qvest-digital.com>
References: <1ab39069-857a-a4b2-9034-07db9f5fe1d8@qvest-digital.com>
Message-ID: <7c1ba89d-2818-44f0-affc-73322e9417d7@oracle.com>

On 7/04/2024 1:52 am, Thorsten Glaser wrote:
> Hi,
> 
> how do I make sense of crashes in buildd logs, such as:
> https://buildd.debian.org/status/fetch.php?pkg=openjdk-8&arch=m68k&ver=8u402-ga-6&stamp=1711506075&raw=1
> 
> I saw?
> #  Internal Error (os_linux_zero.cpp:254), pid=830846, tid=0x3f629440
> ? and thought, yay, we can look at where the segfault is,
> but that address is the generic signal handler ?
> 
> Is there a way to get a backtrace into these messages?

If there is no backtrace in the hs_err log then it is because the VM was 
not in a state where stack walking (as per the port) was possible. If 
there was a core file then you may be able to debug that. Otherwise if 
this crashed during the build you should be able to run the crashing JVM 
directly and potentially debug things further that way i.e.

 > configure:5339: checking if the VM and compiler work together

Try running the underlying command directly.

Is this running under an emulator? The build version is for m68k but the 
crash log shows an x86 machine.

David
-----

> Building locally in a VM would take? over a week, I think,
> and gdb is also currently not very usable on m68k, at least
> it wasn?t when I was trying to debug a different crash in a
> different software?
> 
> Help with m68k is welcome in general; the last version that
> built was 8u171-b11, the first to fail was 8u181-b13 and all
> others since. Some patch probably needs updating or something.
> 
> Thanks,
> //mirabilos

From sgehwolf at openjdk.org  Mon Apr  8 08:40:11 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 8 Apr 2024 08:40:11 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v2]
In-Reply-To: <dDQAuW-AAsCqskxPqaETWw-KHgDjUaBk8Pk6d0nUNAA=.b160a808-a183-49bf-884e-49f0d036a8f1@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
 <CYfEn1cJYBChGfNEPwP12MicVlc_rPcc7EKFnZiDx28=.9dad6117-b528-491a-86f1-5122c2a680ef@github.com>
 <9eC_UIOB5PkSmj4TwDT_0ddr7CBp0ix9iUAO-Li9r_A=.2753e464-eebb-45ab-843e-59f6ea1bf6f0@github.com>
 <dDQAuW-AAsCqskxPqaETWw-KHgDjUaBk8Pk6d0nUNAA=.b160a808-a183-49bf-884e-49f0d036a8f1@github.com>
Message-ID: <KaTcfxvYALMVkF50OKeAB0juQU_NQQMEzvGu4MVghk4=.f9719895-bd1f-4f9d-9d3c-ba53a2edc485@github.com>

On Fri, 5 Apr 2024 18:13:15 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> hotspot/src/os/aix/vm/os_aix.cpp line 1455:
>> 
>>> 1453: // Loads .dll/.so and in case of error it checks if .dll/.so was built
>>> 1454: // for the same architecture as Hotspot is running on.
>>> 1455: static void* dll_load(const char *filename, char *ebuf, int ebuflen) {
>> 
>> Are you sure this is correct? The [JDK 11u](https://github.com/openjdk/jdk11u-dev/commit/6808c5c89d1e30f481ebe444f93175232bcd30e2#diff-5f68fc3ce77d56a6e5a398c51eb1e1b56ea41175e8a86a1c5d92e167ba2b2b40R1316) change renamed this to `dll_load_library`. Does this even work?
>
> @jerboaa I see the certificate tests failing in the tests. Are these due to some other issue ? I do not see how my fix would cause a certificate issue.

@suchismith1993 Please merge latest master, those tests should be on the problem list by now. See https://bugs.openjdk.org/browse/JDK-8328809

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/473#discussion_r1555440244

From sgehwolf at openjdk.org  Mon Apr  8 08:41:13 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 8 Apr 2024 08:41:13 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <jti7DP4DeV9zaZYc6XVX4a8aTip_le5QGq770GQunm8=.b80f85ee-c95d-46dc-8189-ae245fe89c98@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
 <jti7DP4DeV9zaZYc6XVX4a8aTip_le5QGq770GQunm8=.b80f85ee-c95d-46dc-8189-ae245fe89c98@github.com>
Message-ID: <mpkRpYaTKjgPXludqOOSIKB1Td-WO1WaGpAei6L_Kps=.1645fbe0-f102-44a4-85ef-60ae207c289e@github.com>

On Fri, 5 Apr 2024 19:10:21 GMT, fitzsim <duke at openjdk.org> wrote:

> They are there because they avoid the need to backport the entire large JDK9-era rewrite of the Java parts of Zip support to jdk8u.

Do you know which bug did the rewrite? It would be good to have that on record.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2042183397

From sroy at openjdk.org  Mon Apr  8 08:46:35 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Mon, 8 Apr 2024 08:46:35 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v4]
In-Reply-To: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
Message-ID: <hb75wYfRbmGXsGQVGrxz7oBsa0mBezJS1vTwaQKzLp0=.455e52cd-13c0-4b9a-bf84-405819775c0d@github.com>

> Hi all,
> 
> This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.
> 
> Thanks!

Suchismith Roy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - rename method
 - Same logic different file
 - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/473/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/473/files/beb289f4..79f53bbb

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=473&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=473&range=02-03

  Stats: 2246 lines in 17 files changed: 2226 ins; 5 del; 15 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/473.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/473/head:pull/473

PR: https://git.openjdk.org/jdk8u-dev/pull/473

From ktakakuri at openjdk.org  Mon Apr  8 12:17:28 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 8 Apr 2024 12:17:28 GMT
Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2]
In-Reply-To: <hHGVNHSzBxCWG8IZUYgfMmomgaIXX4uJqOzPyXSc_d0=.d6e301fb-1ff6-4ce9-bcb2-fda821aa9ecf@github.com>
References: <hHGVNHSzBxCWG8IZUYgfMmomgaIXX4uJqOzPyXSc_d0=.d6e301fb-1ff6-4ce9-bcb2-fda821aa9ecf@github.com>
Message-ID: <uti4cm9Xus57wwtg3EVIjVbB4xKEYbgJN2Fi3vfAuy0=.482763dc-f131-473d-bc93-2ae9eb119216@github.com>

> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags.
> The bug reported is reproducible in JDK8, so this patch should be applied.
> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted.
> The original patch does not apply cleanly, and the following modifications are needed:
> 
> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java
> 
> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java.
> * The size_t type was introduced in JDK9, so the related fix is skipped.
> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used.
> * Replace var with String.
> 
> hotspot/src/share/vm/runtime/globals.hpp
> 
> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR.
> 
> hotspot/test/serviceability/sa/ClhsdbFlags.java
> 
> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future.
> 
> Testing
> 
> * manually check the behaviour  
>   Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx.  
> 
> without patch
> 
> 
> hsdb> flags NativeMemoryTracking
> NativeMemoryTracking = null 1
> hsdb> flags OnError
> OnError = null 1
> hsdb> flags Max...

Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:

 - Merge branch 'master' into 8217612
 - d6a75a0f86d4c84132a3794c432b34068163fa60

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/431/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/431/files/554b8da9..465ea187

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=431&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=431&range=00-01

  Stats: 9273 lines in 512 files changed: 4235 ins; 3728 del; 1310 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/431.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/431/head:pull/431

PR: https://git.openjdk.org/jdk8u-dev/pull/431

From ktakakuri at openjdk.org  Mon Apr  8 12:19:43 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 8 Apr 2024 12:19:43 GMT
Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails
 after JDK-8217612 [v2]
In-Reply-To: <k7HhLB2KvVg5AAN6tmv9pWtwlMPA14WW7-dttthdpFg=.b8c154c7-620a-4df8-b142-a973cc518faa@github.com>
References: <k7HhLB2KvVg5AAN6tmv9pWtwlMPA14WW7-dttthdpFg=.b8c154c7-620a-4df8-b142-a973cc518faa@github.com>
Message-ID: <xmPuXgfPdbXJert0ir-gTPD7xYkHwn4VnhxhR1op6ys=.35a3df11-31fd-44eb-bb9a-61798d6d6fe5@github.com>

> Hi all,
> 
> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612  
> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed.
> 
> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations.
> 
> Thank you.

Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8217850
 - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d
 - d6a75a0f86d4c84132a3794c432b34068163fa60

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/433/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/433/files/ccb8463a..be3e6030

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=433&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=433&range=00-01

  Stats: 9273 lines in 512 files changed: 4235 ins; 3728 del; 1310 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/433.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/433/head:pull/433

PR: https://git.openjdk.org/jdk8u-dev/pull/433

From ktakakuri at openjdk.org  Mon Apr  8 12:23:55 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 8 Apr 2024 12:23:55 GMT
Subject: [jdk8u-dev] RFR: 8137329: [windows] Build broken on VS2010 after
 "8046148: JEP 158: Unified JVM Logging" [v2]
In-Reply-To: <VKCKtc4PbdqZX11nJpWjQD43MGO6I8g92fBD1rzgUCs=.cbd3801c-7a00-468e-8b3e-346c4979ac7c@github.com>
References: <VKCKtc4PbdqZX11nJpWjQD43MGO6I8g92fBD1rzgUCs=.cbd3801c-7a00-468e-8b3e-346c4979ac7c@github.com>
Message-ID: <ZEsgsb87ag5jTtrZ3MhMprN8PpsFD4xH5yKGhYzrK0A=.ba210082-763a-43b0-82a2-1c9e482825f5@github.com>

> Hi all, This is a backport of JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging".
> I worked on backporting JDK-8159695 to jdk8u ( https://github.com/openjdk/jdk8u-dev/pull/428 ), and found that VS2010 build fails. This is because strtoull function, which the JDK-8159695 patch contains, is not predefined in VS2010. This patch defines strtoull macro when the earlier versions of Visual Studio are used, so this patch need to be backported for builing with VS2010 if JDK-8159695 is backported as proposed.
> 
> This patch couldn't be applied cleanly due to a previously backported fix for earlier versions of Visual Studio at the same location, which needs to be merged.
> 
> The risk is low as this only affects earlier VS builds and introduces one macro.  
> Testing: GHA
> 
> Thank you.

Kazuhisa Takakuri has updated the pull request incrementally with 40 additional commits since the last revision:

 - Merge branch 'master' into 8137329
 - 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
   
   Backport-of: 2fa6eac464048176087092c91c8430781ab15301
 - 8291226: Create Test Cases to cover scenarios for JDK-8278067
   
   Reviewed-by: sgehwolf
   Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
 - 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
   
   Reviewed-by: simonis
   Backport-of: a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1
 - 8325927: [8u] Backport of JDK-8170552 missed part of the test
   
   Reviewed-by: sgehwolf
 - 8328809: [8u] Problem list some CA tests
   
   Reviewed-by: andrew
 - 8317507: C2 compilation fails with "Exceeded _node_regs array"
   
   Reviewed-by: roland, andrew
   Backport-of: a5818972c16bd883d768ff2fb23a8aa9e0142c65
 - Merge
 - 8321408: Add Certainly roots R1 and E1
   
   Reviewed-by: sgehwolf
   Backport-of: e8f7eaeefe503a34089fd49051f9114d98a63cb1
 - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
   
   Reviewed-by: phh, andrew
   Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb
 - ... and 30 more: https://git.openjdk.org/jdk8u-dev/compare/7b175458...5fbb88b2

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/434/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/434/files/7b175458..5fbb88b2

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=434&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=434&range=00-01

  Stats: 9273 lines in 512 files changed: 4235 ins; 3728 del; 1310 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/434.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/434/head:pull/434

PR: https://git.openjdk.org/jdk8u-dev/pull/434

From ktakakuri at openjdk.org  Mon Apr  8 12:28:29 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Mon, 8 Apr 2024 12:28:29 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v2]
In-Reply-To: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
Message-ID: <lMjzWbIyUYdJJDWOAsA7CQVc_bYWF4g4kcfxQ8sIcw8=.77eb7dd6-8541-464c-a95f-c47c100712cc@github.com>

> I would like to fix this issue because the test dose not work as intended.
> Could someone please review it?

Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8320964
 - Fix copyright year and @bug
 - Fix Native2AsciiTests.sh

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/400/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/400/files/d29d1e5c..bb315b1f

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=400&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=400&range=00-01

  Stats: 17881 lines in 566 files changed: 7049 ins; 9336 del; 1496 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/400.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/400/head:pull/400

PR: https://git.openjdk.org/jdk8u-dev/pull/400

From t.glaser at qvest-digital.com  Mon Apr  8 13:09:13 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Mon, 8 Apr 2024 15:09:13 +0200 (CEST)
Subject: making sense of crashes in build logs
In-Reply-To: <7c1ba89d-2818-44f0-affc-73322e9417d7@oracle.com>
References: <1ab39069-857a-a4b2-9034-07db9f5fe1d8@qvest-digital.com>
 <7c1ba89d-2818-44f0-affc-73322e9417d7@oracle.com>
Message-ID: <6fe4e272-84cc-5675-b9d4-727fd13185b8@qvest-digital.com>

Hi David,

> If there is no backtrace in the hs_err log then it is because the VM was not in
> a state where stack walking (as per the port) was possible.

ok.

> If there was a core file then you may be able to debug that.

Yes, "may"? I have not had much luck with gdb on m68k recently,
sadly, but I?ll ask other people to have a look into *that*.

> Otherwise if this crashed during the build you should be able to run
> the crashing JVM directly and potentially debug things further that
> way i.e.
>
>> configure:5339: checking if the VM and compiler work together
>
> Try running the underlying command directly.

It did crash during the build, but on one of the "fast" qemu-user-
based buildds, which means I do not have access to the build chroot.

I can build it on my Atari VM myself, but it takes about a week at
least to get to that place?

> Is this running under an emulator? The build version is for m68k but
> the crash log shows an x86 machine.

Yes, qemu-user here.

Thanks nevertheless,
//mirabilos
-- 
15:41?<Lo-lan-do:#fusionforge> Somebody write a testsuite for helloworld :-)

From sgehwolf at openjdk.org  Mon Apr  8 13:10:11 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 8 Apr 2024 13:10:11 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
Message-ID: <1SWGaK8NrZqvLy6jxo1qQULTjS-XZdIi5iU3aU6CXME=.de97a23a-4354-49f7-a3cd-466defcfe797@github.com>

On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups.
>> 
>> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577.
>> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u.
>> So, I propose to judge the buttonModel is an instance of DefaultButtonModel.
>> 
>> Testing:
>> java/awt
>> javax/swing
>> ButtonGroupLayoutTraversalTest.java
>> bug8033699.java
>> DefaultButtonModelCrashTest.java
>> on Windows x86_64
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the copyright years

My bad `/issue add JDK-8182577`

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2042715632

From sgehwolf at openjdk.org  Mon Apr  8 13:13:11 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 8 Apr 2024 13:13:11 GMT
Subject: [jdk8u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close
 connection immediately [v4]
In-Reply-To: <vXukf3hnsoePeuM7yPwM5f2Q1cRIl6cHBg5WaNhI1dA=.e013c597-71ca-44dc-9077-d0003ea2d3f7@github.com>
References: <bnu_bQbAL7WleYUmSrXBmvjAoPMK2VDNwWlWSUdZTfo=.cf6da58d-23a9-4178-a96f-a00a61fd7c50@github.com>
 <vXukf3hnsoePeuM7yPwM5f2Q1cRIl6cHBg5WaNhI1dA=.e013c597-71ca-44dc-9077-d0003ea2d3f7@github.com>
Message-ID: <4Y3Qm8TPbMx4jbz57AE3aANyrp5xd6GUh_z_IgV7yeU=.aec42a5b-51ba-4f0d-8426-66515f4c83ab@github.com>

On Fri, 5 Apr 2024 20:23:17 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Backport of 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec
>
> Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
> 
>  - Merge master
>  - adjust JDK8 library path
>  - merge dependent pr/453
>  - Merge branch 'pr/466' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8291226
>  - Backport b17a745d7f55941f02b0bdde83866aa5d32cce07
>  - Adjusting the indentation according to 11u.
>  - Adjusting the library paths
>  - Backport 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec
>  - 8291226: Create Test Cases to cover scenarios for JDK-8278067
>    
>    Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
>  - Merge branch 'master' into Backport-JDK-8278067
>  - ... and 4 more: https://git.openjdk.org/jdk8u-dev/compare/a4b40e84...e2fc39da

Looks good.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/454#pullrequestreview-1986412730

From sgehwolf at openjdk.org  Mon Apr  8 13:15:09 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 8 Apr 2024 13:15:09 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v4]
In-Reply-To: <hb75wYfRbmGXsGQVGrxz7oBsa0mBezJS1vTwaQKzLp0=.455e52cd-13c0-4b9a-bf84-405819775c0d@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
 <hb75wYfRbmGXsGQVGrxz7oBsa0mBezJS1vTwaQKzLp0=.455e52cd-13c0-4b9a-bf84-405819775c0d@github.com>
Message-ID: <d35HFx3fEul7WnTtoC_Gk2BdryOs8w2O9RS6C5qo9G8=.2f7bfd67-0365-4bc4-8cb0-dbcc679e23df@github.com>

On Mon, 8 Apr 2024 08:46:35 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.
>> 
>> Thanks!
>
> Suchismith Roy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - rename method
>  - Same logic different file
>  - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab

Looks fine.

`gc/logging/TestGCId.java` fails intermittently on x86 (32 bit). Unrelated to this patch.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/473#pullrequestreview-1986417988
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/473#issuecomment-2042726044

From dhanalla at openjdk.org  Mon Apr  8 13:31:12 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Mon, 8 Apr 2024 13:31:12 GMT
Subject: [jdk8u-dev] RFR: 8291638: Keep-Alive timeout of 0 should close
 connection immediately [v4]
In-Reply-To: <4Y3Qm8TPbMx4jbz57AE3aANyrp5xd6GUh_z_IgV7yeU=.aec42a5b-51ba-4f0d-8426-66515f4c83ab@github.com>
References: <bnu_bQbAL7WleYUmSrXBmvjAoPMK2VDNwWlWSUdZTfo=.cf6da58d-23a9-4178-a96f-a00a61fd7c50@github.com>
 <vXukf3hnsoePeuM7yPwM5f2Q1cRIl6cHBg5WaNhI1dA=.e013c597-71ca-44dc-9077-d0003ea2d3f7@github.com>
 <4Y3Qm8TPbMx4jbz57AE3aANyrp5xd6GUh_z_IgV7yeU=.aec42a5b-51ba-4f0d-8426-66515f4c83ab@github.com>
Message-ID: <PijfbN7S7TaiYdTjBEL_sf4fw7XoLu__dyl4mdOZZkk=.59a0a49c-0614-4586-bc7c-e70be0fadbc4@github.com>

On Mon, 8 Apr 2024 13:10:49 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> Looks good.

Thanks @jerboaa for reviewing this PR. I've added a JDK8 patch request to the bug as the next step.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/454#issuecomment-2042760783

From dhanalla at openjdk.org  Mon Apr  8 15:51:13 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Mon, 8 Apr 2024 15:51:13 GMT
Subject: [jdk8u-dev] Integrated: 8291638: Keep-Alive timeout of 0 should close
 connection immediately
In-Reply-To: <bnu_bQbAL7WleYUmSrXBmvjAoPMK2VDNwWlWSUdZTfo=.cf6da58d-23a9-4178-a96f-a00a61fd7c50@github.com>
References: <bnu_bQbAL7WleYUmSrXBmvjAoPMK2VDNwWlWSUdZTfo=.cf6da58d-23a9-4178-a96f-a00a61fd7c50@github.com>
Message-ID: <7OtVw5kEC2H_mAMuGgK4vOb4MWvdgohMODoEq9tTcpg=.45becf15-0252-40df-a6ec-ff9f2df2c036@github.com>

On Wed, 21 Feb 2024 22:45:28 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

> Backport of 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec
> 
> A clean backport from JDK11u patch, excluding one version-specific API, "!OptionalInt::isPresent() vs OptionalInt::isEmpty()".
> 
> Test performed:
> 1. JTreg jdk_tier1, hotspot_tier1
> 2. The backported test case in this PR passed.

This pull request has now been integrated.

Changeset: d0d9a152
Author:    Dhamoder Nalla <dhanalla at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/d0d9a152d14fb3e056d5534ab7e6b0bde3870c14
Stats:     40 lines in 4 files changed: 29 ins; 8 del; 3 mod

8291638: Keep-Alive timeout of 0 should close connection immediately

Reviewed-by: sgehwolf
Backport-of: 26ac8366360685ef0cf3447ee7db16ba7a7fa1ec

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/454

From duke at openjdk.org  Mon Apr  8 16:12:16 2024
From: duke at openjdk.org (fitzsim)
Date: Mon, 8 Apr 2024 16:12:16 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
Message-ID: <6IKwO2Ssx8gGJrhogkTHuuvGmOSx8rcll59NAvyIOC0=.fc70c5ae-0701-40e8-bbb3-855b26497999@github.com>

On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
> 
> What follows is Thomas' introduction from the original PR:
> 
> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
> 
> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
> 
> ~~~
> java.lang.RuntimeException: zipfile: zip64 end failed
> 	at ReadZip.main(ReadZip.java:209)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
> 	at java.lang.Thread.run(Thread.java:750)
> ~~~
> 
> With the fix applied the test passes:
> 
> ~~~
> Passed: java/util/zip/ZipFile/ReadZip.java
> ~~~
> 
> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
> ~~~
> Test results: passed: 3,122
> ~~~
> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
> 
> Thank you,
> Thomas

Here is some public discussion: https://bugzilla.redhat.com/show_bug.cgi?id=1433262#c21 and https://bugzilla.redhat.com/show_bug.cgi?id=1433262#c22

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2043145352

From dhanalla at openjdk.org  Mon Apr  8 18:22:38 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Mon, 8 Apr 2024 18:22:38 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v4]
In-Reply-To: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
Message-ID: <P8bVcPcOGJLjBdpPZEADUYAbdtg1jqQwa3JV1eR2UNM=.0b72d889-7649-4574-963a-0a06e9ec0425@github.com>

> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
> 
> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
> 
> Test performed:
> 
> 1. JTreg jdk_tier1
> 2. JTreg jdk_tier2
> 3. New test case added to this PR passed with the fix and failed without it.
> 4. The customer failure scenario has been validated.

Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:

 - Merge master
 - Merge branch 'pr/453' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8293562
 - 8291226: Create Test Cases to cover scenarios for JDK-8278067
   
   Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
 - Merge branch 'master' into Backport-JDK-8278067
 - Remove SystemProperty tag as it is not supported in JDK8
 - Merge pr/437
 - Fix indentation
 - Backport d8f44aa39e921594505864e6270f42b745265293
 - Fix indentation
 - Backport 770c1f65c588f3156f9b70097df752d8059c1038
 - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/d0d9a152...36cb9124

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/409/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=409&range=03
  Stats: 347 lines in 3 files changed: 276 ins; 7 del; 64 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/409.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/409/head:pull/409

PR: https://git.openjdk.org/jdk8u-dev/pull/409

From sroy at openjdk.org  Mon Apr  8 18:25:13 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Mon, 8 Apr 2024 18:25:13 GMT
Subject: [jdk8u-dev] Integrated: 8320005: Allow loading of shared objects with
 .a extension on AIX
In-Reply-To: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
Message-ID: <PB3VXeIlJrYozAcBKPb3o0QWSJYy9nIgEkmB2H0ZHTw=.f597770f-1b07-4701-bcf4-7ae97bdf3442@github.com>

On Mon, 25 Mar 2024 18:20:49 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
> 
> The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.
> 
> Thanks!

This pull request has now been integrated.

Changeset: c1c8064e
Author:    Suchismith Roy <sroy at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c1c8064ef0f67e85cb6a28990f4784271d949a08
Stats:     22 lines in 1 file changed: 20 ins; 0 del; 2 mod

8320005: Allow loading of shared objects with .a extension on AIX

Reviewed-by: sgehwolf
Backport-of: e85355ada4ac1061c49ee9f1247d37a437c7b5ab

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/473

From syan at openjdk.org  Tue Apr  9 01:40:14 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 9 Apr 2024 01:40:14 GMT
Subject: [jdk8u-dev] RFR: 8325096: Test
 java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing
In-Reply-To: <Uga80Eg0XKg8CV388t5gMAaPy-3uXzYbbrqdorpjqVg=.40e9cf12-16ab-4d0e-9938-e806288aa1b7@github.com>
References: <Uga80Eg0XKg8CV388t5gMAaPy-3uXzYbbrqdorpjqVg=.40e9cf12-16ab-4d0e-9938-e806288aa1b7@github.com>
Message-ID: <ytsXL_fmBp5kUZxc-b61DIKr1peODsJFqqXTldxLYrs=.7832838d-38d1-4935-ae5d-ad4772c6b3bc@github.com>

On Thu, 1 Feb 2024 15:08:08 GMT, SendaoYan <syan at openjdk.org> wrote:

> 8325096: Test java/security/cert/CertPathBuilder/akiExt/AKISerialNumber.java is failing

> /sponsor

@jerboaa Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/436#issuecomment-2043988857

From syan at openjdk.org  Tue Apr  9 01:48:14 2024
From: syan at openjdk.org (SendaoYan)
Date: Tue, 9 Apr 2024 01:48:14 GMT
Subject: [jdk8u-dev] RFR: 8323640: [TESTBUG]testMemoryFailCount in
 jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because
 OOM killed
In-Reply-To: <6xs_hxYaiFM_-uhrT-zBG_APlGuaOdv0_KQsL0mQ3lY=.09982b55-8491-4d07-a517-ba331374b0f2@github.com>
References: <6xs_hxYaiFM_-uhrT-zBG_APlGuaOdv0_KQsL0mQ3lY=.09982b55-8491-4d07-a517-ba331374b0f2@github.com>
Message-ID: <CyRZJYHweeWcpflBcG40S7sotqOPjs02QByN3yPj1UM=.23302a08-9c1e-4a15-bf92-9c0e4ad310d3@github.com>

On Wed, 24 Jan 2024 07:22:39 GMT, SendaoYan <syan at openjdk.org> wrote:

> 8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed

> /sponsor
> 
> Windows GHA failures are unrelated.

@phohensee Thanks.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/426#issuecomment-2043995293

From sgehwolf at openjdk.org  Tue Apr  9 14:18:16 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 9 Apr 2024 14:18:16 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v4]
In-Reply-To: <P8bVcPcOGJLjBdpPZEADUYAbdtg1jqQwa3JV1eR2UNM=.0b72d889-7649-4574-963a-0a06e9ec0425@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <P8bVcPcOGJLjBdpPZEADUYAbdtg1jqQwa3JV1eR2UNM=.0b72d889-7649-4574-963a-0a06e9ec0425@github.com>
Message-ID: <2LvgyXQrVnqFOsXU0nFTphccv5xRrQDInkqxeyeP90Q=.daa4bc85-04ff-4cb5-bcb1-97ed5c06fb04@github.com>

On Mon, 8 Apr 2024 18:22:38 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - Merge master
>  - Merge branch 'pr/453' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8293562
>  - 8291226: Create Test Cases to cover scenarios for JDK-8278067
>    
>    Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
>  - Merge branch 'master' into Backport-JDK-8278067
>  - Remove SystemProperty tag as it is not supported in JDK8
>  - Merge pr/437
>  - Fix indentation
>  - Backport d8f44aa39e921594505864e6270f42b745265293
>  - Fix indentation
>  - Backport 770c1f65c588f3156f9b70097df752d8059c1038
>  - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/d0d9a152...36cb9124

This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the  current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.

http tests pass for me:

Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java
Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java
Passed: sun/net/www/http/ChunkedInputStream/TestAvailable.java
Passed: sun/net/www/http/ChunkedOutputStream/checkError.java
Passed: sun/net/www/http/ChunkedOutputStream/Test.java
Passed: sun/net/www/http/HttpClient/B6726695.java
Passed: sun/net/www/http/HttpClient/B7025238.java
Passed: sun/net/www/http/HttpClient/B8025710.java
Passed: sun/net/www/http/HttpClient/B8209178.java
Passed: sun/net/www/http/HttpClient/CookieHttpClientTest.java
Passed: sun/net/www/http/HttpClient/GetProxyPort.java
Passed: sun/net/www/http/HttpClient/ImplicitFileName.java
Passed: sun/net/www/http/HttpClient/IsAvailable.java
Passed: sun/net/www/http/HttpClient/IsKeepingAlive.java
Passed: sun/net/www/http/HttpClient/KeepAliveTest.java
Passed: sun/net/www/http/HttpClient/MultiThreadTest.java
Passed: sun/net/www/http/HttpClient/OpenServer.java
Passed: sun/net/www/http/HttpClient/ProxyFromCache.java
Passed: sun/net/www/http/HttpClient/ProxyTest.java
Passed: sun/net/www/http/HttpClient/RequestURI.java
Passed: sun/net/www/http/HttpClient/RetryPost.sh
Passed: sun/net/www/http/HttpClient/StreamingRetry.java
Passed: sun/net/www/http/HttpURLConnection/PostOnDelete.java
Passed: sun/net/www/http/KeepAliveCache/B5045306.java
Passed: sun/net/www/http/KeepAliveCache/B8291637.java
Passed: sun/net/www/http/KeepAliveCache/B8293562.java
Passed: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java
Passed: sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java
Passed: sun/net/www/http/KeepAliveStream/InfiniteLoop.java
Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamClose.java
Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java
Passed: sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java
Test results: passed: 32

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/409#pullrequestreview-1989178436

From dhanalla at openjdk.org  Tue Apr  9 17:07:27 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Tue, 9 Apr 2024 17:07:27 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v5]
In-Reply-To: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
Message-ID: <KKOn-yl6DYcNAUc1YkzlsddpxHbYz5B0q2aUyvC9pwI=.3df9ece0-82e2-4fe1-975f-39d528fe3485@github.com>

> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
> 
> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
> 
> Test performed:
> 
> 1. JTreg jdk_tier1
> 2. JTreg jdk_tier2
> 3. New test case added to this PR passed with the fix and failed without it.
> 4. The customer failure scenario has been validated.

Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:

  Fix white spaces

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/409/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/409/files/36cb9124..0476345c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=409&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=409&range=03-04

  Stats: 19 lines in 1 file changed: 1 ins; 2 del; 16 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/409.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/409/head:pull/409

PR: https://git.openjdk.org/jdk8u-dev/pull/409

From dhanalla at openjdk.org  Tue Apr  9 17:14:12 2024
From: dhanalla at openjdk.org (Dhamoder Nalla)
Date: Tue, 9 Apr 2024 17:14:12 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v4]
In-Reply-To: <2LvgyXQrVnqFOsXU0nFTphccv5xRrQDInkqxeyeP90Q=.daa4bc85-04ff-4cb5-bcb1-97ed5c06fb04@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <P8bVcPcOGJLjBdpPZEADUYAbdtg1jqQwa3JV1eR2UNM=.0b72d889-7649-4574-963a-0a06e9ec0425@github.com>
 <2LvgyXQrVnqFOsXU0nFTphccv5xRrQDInkqxeyeP90Q=.daa4bc85-04ff-4cb5-bcb1-97ed5c06fb04@github.com>
Message-ID: <9scXMQfGnko8ujEpvFEEXS4bQ9LktaakvD0TXnRlC6Q=.105f7012-5868-485d-b98d-c72e1d30045b@github.com>

On Tue, 9 Apr 2024 14:15:08 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.
> 
> http tests pass for me:
> 
> ```
> Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java
> Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java
> Passed: sun/net/www/http/ChunkedInputStream/TestAvailable.java
> Passed: sun/net/www/http/ChunkedOutputStream/checkError.java
> Passed: sun/net/www/http/ChunkedOutputStream/Test.java
> Passed: sun/net/www/http/HttpClient/B6726695.java
> Passed: sun/net/www/http/HttpClient/B7025238.java
> Passed: sun/net/www/http/HttpClient/B8025710.java
> Passed: sun/net/www/http/HttpClient/B8209178.java
> Passed: sun/net/www/http/HttpClient/CookieHttpClientTest.java
> Passed: sun/net/www/http/HttpClient/GetProxyPort.java
> Passed: sun/net/www/http/HttpClient/ImplicitFileName.java
> Passed: sun/net/www/http/HttpClient/IsAvailable.java
> Passed: sun/net/www/http/HttpClient/IsKeepingAlive.java
> Passed: sun/net/www/http/HttpClient/KeepAliveTest.java
> Passed: sun/net/www/http/HttpClient/MultiThreadTest.java
> Passed: sun/net/www/http/HttpClient/OpenServer.java
> Passed: sun/net/www/http/HttpClient/ProxyFromCache.java
> Passed: sun/net/www/http/HttpClient/ProxyTest.java
> Passed: sun/net/www/http/HttpClient/RequestURI.java
> Passed: sun/net/www/http/HttpClient/RetryPost.sh
> Passed: sun/net/www/http/HttpClient/StreamingRetry.java
> Passed: sun/net/www/http/HttpURLConnection/PostOnDelete.java
> Passed: sun/net/www/http/KeepAliveCache/B5045306.java
> Passed: sun/net/www/http/KeepAliveCache/B8291637.java
> Passed: sun/net/www/http/KeepAliveCache/B8293562.java
> Passed: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java
> Passed: sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java
> Passed: sun/net/www/http/KeepAliveStream/InfiniteLoop.java
> Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamClose.java
> Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java
> Passed: sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java
> Test results: passed: 32
> ```

Done

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-2045713126

From andrew at openjdk.org  Wed Apr 10 00:44:09 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 10 Apr 2024 00:44:09 GMT
Subject: [jdk8u-dev] RFR: 8329544: [8u]
 sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary
In-Reply-To: <uTOj3lmPUJQ1yAfGLjjlo97SiwYAwIIR4JOmhDsWkvg=.f11aa8ff-e7ee-4b50-9d8d-8dddb4e3b593@github.com>
References: <uTOj3lmPUJQ1yAfGLjjlo97SiwYAwIIR4JOmhDsWkvg=.f11aa8ff-e7ee-4b50-9d8d-8dddb4e3b593@github.com>
Message-ID: <eH8DwBm1SRllfuzvODo7mlvpE0kduPISTcCk5GUmLA0=.089951b7-2a99-422c-bc23-da43b33801e2@github.com>

On Tue, 2 Apr 2024 16:48:49 GMT, Ian Myers <imyers at openjdk.org> wrote:

> `sun/security/krb5/auto/ReplayCacheTestProc.java` fails on jdk8u-412 due to a compilation error. This is because the classpath is being set incorrectly by the `@library` annotation.
> 
> 
> TEST: sun/security/krb5/auto/ReplayCacheTestProc.java
> TEST JDK: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image
> 
> ACTION: compile -- Failed. Compilation failed: Compilation failed
> REASON: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
> TIME:   0.752 seconds
> messages:
> command: compile -XDignore.symbol.file /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java
> reason: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
> Mode: agentvm
> Agent id: 1
> elapsed time (seconds): 0.752
> configuration:
> Boot Layer (javac runtime environment)
>   class path: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
>               /local/home/ianrichr/openjdk/jtreg/lib/javatest.jar
>               /local/home/ianrichr/openjdk/jtreg/lib/jtreg.jar
> 
> javac compilation environment
>   source path: /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
>                /local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary
>   class path:  /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
>                /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto
>                /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
> 
> rerun:
> cd /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/scratch/0 && \
> HOME=/home/ianrichr \
> LANG=en_US.UTF-8 \
> PATH=/bin:/usr/bin:/usr/sbin \
>     /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/javac \
>         -J-ea \
>         -J-esa \
>         -J-Xmx512m \
>         -J-Dtest.vm.opts='-ea -esa -Xmx512m' \
>         -J-Dtest.tool.vm.opts='-J-ea -J-esa -J-Xmx512m' \
>         -J-Dtest.compiler.opts= \
>         -J-Dtest.java.opts= \
>         -J-Dtest.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
>         -J-Dcompile.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
>         -J-Dtest.timeout.factor=4.0 \
>         -J-Dtest.root=/local/home/ianrichr/openjdk/j...

Seems a harmless addition, but also not always necessary

> This really looks like an omission in the 8u backport. The original change does add `/test/lib`: [openjdk/jdk at e10da99?diff=unified&w=0#diff-a66e8361b5d10cd8f8bff535c2759ad4f2e4bdbbd2368ddf5c644bce77e5aa18R28](https://github.com/openjdk/jdk/commit/e10da9956fba577bcc097b63eb3b4d09896fa77d?diff=unified&w=0#diff-a66e8361b5d10cd8f8bff535c2759ad4f2e4bdbbd2368ddf5c644bce77e5aa18R28)



> This really looks like an omission in the 8u backport. The original change does add `/test/lib`: [openjdk/jdk at e10da99?diff=unified&w=0#diff-a66e8361b5d10cd8f8bff535c2759ad4f2e4bdbbd2368ddf5c644bce77e5aa18R28](https://github.com/openjdk/jdk/commit/e10da9956fba577bcc097b63eb3b4d09896fa77d?diff=unified&w=0#diff-a66e8361b5d10cd8f8bff535c2759ad4f2e4bdbbd2368ddf5c644bce77e5aa18R28)

Probably because it wasn't necessary. If you read https://github.com/openjdk/jdk8u-dev/pull/418 it passes without this and indeed it didn't fail for me just now either. The only way I could get the error quoted was to remove `external.lib.roots` (https://github.com/openjdk/jdk8u/commit/eace2d732133accd3be9e95a9e75aee0fc1938f8#diff-6f996ccac16c4cddc35780b36cf8a2ea80780bb3486564a30f71dafa2af0fbe3R31)

I see no harm in adding it, but it's not that this went untested to begin with. It does work as is in some configurations.

Note that `/test/lib` is pretty new in 8u and was only created by JDK-8305329 last November, so it has been standard to remove/change this prior to that change.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/478#pullrequestreview-1990512372
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/478#issuecomment-2046254392

From andrew at openjdk.org  Wed Apr 10 00:48:09 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 10 Apr 2024 00:48:09 GMT
Subject: [jdk8u-dev] RFR: 8069389: CompilerOracle prefix wildcarding is
 broken for long strings [v3]
In-Reply-To: <Zk7emBjZkBI_fJjEjMF8zI-Ta60cVagp9mB8cffjTAY=.9090fe9d-2b35-4ed6-9da8-786607e099c1@github.com>
References: <byKoVIetLf3aGI-RkmACc7a5eDxA27XjpcjLZ5_dck8=.f8011d38-5b5d-4913-b2d6-4360bf52fa64@github.com>
 <Zk7emBjZkBI_fJjEjMF8zI-Ta60cVagp9mB8cffjTAY=.9090fe9d-2b35-4ed6-9da8-786607e099c1@github.com>
Message-ID: <kU0Bd6HSCfoXp75vlW60Z6M9mmoPu5WN0Ypusj067BE=.6fb51503-010a-47a7-9ce1-d2e51dd098b8@github.com>

On Fri, 23 Feb 2024 09:53:21 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Clean backport.
>> 
>> I've just found that the issue occurs even with short strings like "*123*", see my screenshot attached to JDK-8069389. This can be reproduced currently with "slowdebug" build on my Ubuntu 22.04 + gcc-9.5.0, however I believe we cannot rely on it isn't reproduced with "release" now.
>> 
>> Anyway, it wasn't good to use "strcpy" with overlapped buffers, because strcpy's docs says "The behavior is undefined if the strings overlap." So, I believe it should be fixed in jdk8 as well.
>
> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   Backport 01ec6950020268a375eb5330373e6c0813f3a924

Verified clean.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/446#pullrequestreview-1990517985

From ktakakuri at openjdk.org  Wed Apr 10 11:47:16 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 10 Apr 2024 11:47:16 GMT
Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2]
In-Reply-To: <uti4cm9Xus57wwtg3EVIjVbB4xKEYbgJN2Fi3vfAuy0=.482763dc-f131-473d-bc93-2ae9eb119216@github.com>
References: <hHGVNHSzBxCWG8IZUYgfMmomgaIXX4uJqOzPyXSc_d0=.d6e301fb-1ff6-4ce9-bcb2-fda821aa9ecf@github.com>
 <uti4cm9Xus57wwtg3EVIjVbB4xKEYbgJN2Fi3vfAuy0=.482763dc-f131-473d-bc93-2ae9eb119216@github.com>
Message-ID: <Q1-pJSiPd32i1bzk1w8PaH2Lrqdb0e2BeuP8eJb7AgI=.593b4786-08c2-4e7b-99dc-30103c4bc7a0@github.com>

On Mon, 8 Apr 2024 12:17:28 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags.
>> The bug reported is reproducible in JDK8, so this patch should be applied.
>> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted.
>> The original patch does not apply cleanly, and the following modifications are needed:
>> 
>> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java
>> 
>> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java.
>> * The size_t type was introduced in JDK9, so the related fix is skipped.
>> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used.
>> * Replace var with String.
>> 
>> hotspot/src/share/vm/runtime/globals.hpp
>> 
>> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR.
>> 
>> hotspot/test/serviceability/sa/ClhsdbFlags.java
>> 
>> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future.
>> 
>> Testing
>> 
>> * manually check the behaviour  
>>   Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx.  
>> 
>> without patch
>> 
>> 
>> hsdb> flags NativeMemoryTracking
>> NativeMemoryTracking =...
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into 8217612
>  - d6a75a0f86d4c84132a3794c432b34068163fa60

Could anyone review this backport please?
Failure of gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java in GHA will be resolved in https://github.com/openjdk/jdk8u-dev/pull/433.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2047310058

From ktakakuri at openjdk.org  Wed Apr 10 12:43:18 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 10 Apr 2024 12:43:18 GMT
Subject: [jdk8u-dev] RFR: 8320964:
 sun/tools/native2ascii/Native2AsciiTests.sh fails on Japanese [v2]
In-Reply-To: <lMjzWbIyUYdJJDWOAsA7CQVc_bYWF4g4kcfxQ8sIcw8=.77eb7dd6-8541-464c-a95f-c47c100712cc@github.com>
References: <5cvLYA6PgVxQXmRRBXLPdNv4E9zi-zqqq1IL3nU_3mw=.49d05d7d-a4b8-473b-a9e8-59018d95b2c8@github.com>
 <lMjzWbIyUYdJJDWOAsA7CQVc_bYWF4g4kcfxQ8sIcw8=.77eb7dd6-8541-464c-a95f-c47c100712cc@github.com>
Message-ID: <6UnqRRjKFhWawsr343TQxHMajWQXK-Cey-rohO6J0lc=.b646c477-5471-459d-bf41-3b8fe433380d@github.com>

On Mon, 8 Apr 2024 12:28:29 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> I would like to fix this issue because the test dose not work as intended.
>> Could someone please review it?
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8320964
>  - Fix copyright year and @bug
>  - Fix Native2AsciiTests.sh

* I run the test on English Windows and also found to occur on the following environment:

$ systeminfo
OS Name:                   Microsoft Windows Server 2016 Standard
System Locale:             en-us;English (United States)

$ sed --version
sed (GNU sed) 4.8
Packaged by Cygwin (4.8-1)
Copyright (C) 2020 Free Software Foundation, Inc.


* I fixed copyright and added the bug ID.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/400#issuecomment-2047434437

From rmarchenko at openjdk.org  Wed Apr 10 14:27:16 2024
From: rmarchenko at openjdk.org (Roman Marchenko)
Date: Wed, 10 Apr 2024 14:27:16 GMT
Subject: [jdk8u-dev] Integrated: 8069389: CompilerOracle prefix wildcarding is
 broken for long strings
In-Reply-To: <byKoVIetLf3aGI-RkmACc7a5eDxA27XjpcjLZ5_dck8=.f8011d38-5b5d-4913-b2d6-4360bf52fa64@github.com>
References: <byKoVIetLf3aGI-RkmACc7a5eDxA27XjpcjLZ5_dck8=.f8011d38-5b5d-4913-b2d6-4360bf52fa64@github.com>
Message-ID: <sBg-geIVQCsl_gAnmGKFXUmu5Jm8Xc8qnuWeLm3gFVA=.c71865e8-e4ba-4092-a645-b7527a852d33@github.com>

On Fri, 16 Feb 2024 18:33:02 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Clean backport.
> 
> I've just found that the issue occurs even with short strings like "*123*", see my screenshot attached to JDK-8069389. This can be reproduced currently with "slowdebug" build on my Ubuntu 22.04 + gcc-9.5.0, however I believe we cannot rely on it isn't reproduced with "release" now.
> 
> Anyway, it wasn't good to use "strcpy" with overlapped buffers, because strcpy's docs says "The behavior is undefined if the strings overlap." So, I believe it should be fixed in jdk8 as well.

This pull request has now been integrated.

Changeset: cde8aca6
Author:    Roman Marchenko <rmarchenko at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/cde8aca6cb0fae77b9300b9d65d094a4f74e4d53
Stats:     80 lines in 2 files changed: 79 ins; 0 del; 1 mod

8069389: CompilerOracle prefix wildcarding is broken for long strings

Replace strcpy with memmove

Reviewed-by: andrew
Backport-of: 01ec6950020268a375eb5330373e6c0813f3a924

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/446

From andrew at openjdk.org  Wed Apr 10 14:31:14 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 10 Apr 2024 14:31:14 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v4]
In-Reply-To: <hb75wYfRbmGXsGQVGrxz7oBsa0mBezJS1vTwaQKzLp0=.455e52cd-13c0-4b9a-bf84-405819775c0d@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
 <hb75wYfRbmGXsGQVGrxz7oBsa0mBezJS1vTwaQKzLp0=.455e52cd-13c0-4b9a-bf84-405819775c0d@github.com>
Message-ID: <oA3pk7L752hrt2cU_yz4rfCN1Sw4xTKqk5s_RjTDISA=.63ed8e87-ca33-4caf-af23-bdfadb5d93b2@github.com>

On Mon, 8 Apr 2024 08:46:35 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit [e85355ad](https://github.com/openjdk/jdk/commit/e85355ada4ac1061c49ee9f1247d37a437c7b5ab) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Suchismith Roy on 27 Feb 2024 and was reviewed by Amit Kumar, Thomas Stuefe, Joachim Kern and Martin Doerr.
>> 
>> Thanks!
>
> Suchismith Roy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - rename method
>  - Same logic different file
>  - Backport e85355ada4ac1061c49ee9f1247d37a437c7b5ab

Hmmm, this seems to have travelled from trunk to 8u very quickly. This change is not in any released version as yet.

I think it would have been better to wait until at least the release of 22.0.2. I guess at least the change is isolated to AIX only, but I would make sure this is tested well before the July releases.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/473#issuecomment-2047708615

From lyang at openjdk.org  Thu Apr 11 03:36:46 2024
From: lyang at openjdk.org (Long Yang)
Date: Thu, 11 Apr 2024 03:36:46 GMT
Subject: [jdk8u-dev] RFR: 8312065: Socket.connect does not timeout when
 profiling
In-Reply-To: <kU2OUMEmk4aP92nKCFvgxdnYKY_pDb0bBXbDdiAb030=.23c470d0-81f5-49a1-8a0b-2254f5bbd322@github.com>
References: <kU2OUMEmk4aP92nKCFvgxdnYKY_pDb0bBXbDdiAb030=.23c470d0-81f5-49a1-8a0b-2254f5bbd322@github.com>
Message-ID: <BkkmmBeL-cE0m7WSH7X6KEZ3GYekdKDBSwkOXFaVE14=.4eb94a88-689d-4ee6-a802-ff93c65469d4@github.com>

On Thu, 21 Dec 2023 08:45:32 GMT, Long Yang <lyang at openjdk.org> wrote:

> Hi,
> 
> This pull request contains the backport of [JDK-8312065](https://bugs.openjdk.org/browse/JDK-8312065), commit [1ce12c4](https://github.com/openjdk/jdk17u-dev/commit/1ce12c4f33d3d6905703d95df2574f4037dfd57d) from the [openjdk/jdk17u-dev](https://github.com/openjdk/jdk17u-dev) repository.
> 
> I added the test `B8312065.java`. The test will fail on the JDK8 without my fix, and it will pass on the JDK8 containing my fix.
> This test relies on [libNativeThread](https://github.com/openjdk/jdk/blob/master/test/jdk/java/net/Socket/libNativeThread.c) to get the `OS thread ID` of the `Java threads`, and send signals to `OS threads`.
> The `libNativeThread` was introduced to test the fix for [JDK-8237858](https://bugs.openjdk.org/browse/JDK-8237858). However, `JDK-8237858` only exists in Java 10 and above. There is no `JDK-8237858` problem on Java 8, so `JDK-8237858` cannot be backported to Java 8.
> In order to use `libNativeThread`, I copied it to my backport.
> 
> I ran all the `jtreg` tests in `test/jdk/java/net/ServerSocket`,`test/jdk/java/net/Socket`,`test/jdk/java/net/SocketOption`,`test/jdk/java/net/ipv6` on my host, all passed.
> 
> Thanks!

Gentle ping. I would be very grateful if anyone could help with the review.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/410#issuecomment-2048871517

From ktakakuri at openjdk.org  Thu Apr 11 04:37:18 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Thu, 11 Apr 2024 04:37:18 GMT
Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with
 @key headful. [v3]
In-Reply-To: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
References: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
Message-ID: <lSPbNZv_g8yk7_abewq6ot0Hot2FIaSG4R8r2jsuYlY=.da3612cd-0bc1-4127-8c82-15640d29def8@github.com>

> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.
> 
> This patch has already been applied to OracleJDK8.
> As noted in the Bug Issue comments, some tests do not exist in 8u.

Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into 8160974
 - Merge branch 'master' into 8160974
 - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/383/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/383/files/7fb82b04..757abee7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=383&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=383&range=01-02

  Stats: 23372 lines in 618 files changed: 9431 ins; 12356 del; 1585 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/383.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/383/head:pull/383

PR: https://git.openjdk.org/jdk8u-dev/pull/383

From kwang at openjdk.org  Thu Apr 11 07:43:55 2024
From: kwang at openjdk.org (Kun Wang)
Date: Thu, 11 Apr 2024 07:43:55 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
Message-ID: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>

Env:
ldd (GNU libc) 2.38
gcc (GCC) 12.3.1 

Test the PR patch;
Build release/fastdebug/slowdebug version pass

Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

-------------

Commit messages:
 - 8329826: GCC 12 reports some compiler error when building jdk8

Changes: https://git.openjdk.org/jdk8u-dev/pull/479/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=479&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8329826
  Stats: 16 lines in 4 files changed: 11 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/479.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/479/head:pull/479

PR: https://git.openjdk.org/jdk8u-dev/pull/479

From ktakakuri at openjdk.org  Fri Apr 12 12:37:08 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Fri, 12 Apr 2024 12:37:08 GMT
Subject: [jdk8u-dev] RFR: 8159454: [TEST_BUG]
 javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics
 configurations should be limited [v2]
In-Reply-To: <9JkNl5f6NIflswSXOTwTexI8lh4G5isxpiUbGDPX4ZA=.f5283fa5-cfea-4723-9856-246da6918036@github.com>
References: <9JkNl5f6NIflswSXOTwTexI8lh4G5isxpiUbGDPX4ZA=.f5283fa5-cfea-4723-9856-246da6918036@github.com>
Message-ID: <Ph_y67XV6sSjVtHUA5Mm7IKV2t3C7qcliE-oNDoyByk=.d48c99a9-afd8-4c5a-9883-2c6319cacc0a@github.com>

> Hi all,
> 
> This is a clean backport of JDK-8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited.
> I have confirmed that bug7123767.java passes by backporting this fix.
> 
> Thank you.

Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:

  Backport 64a2db9060bc9fc81afe451d0b057af57fc10f94

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/405/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/405/files/38bde236..3c33db93

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=405&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=405&range=00-01

  Stats: 2 lines in 1 file changed: 1 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/405.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/405/head:pull/405

PR: https://git.openjdk.org/jdk8u-dev/pull/405

From ktakakuri at openjdk.org  Fri Apr 12 12:46:44 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Fri, 12 Apr 2024 12:46:44 GMT
Subject: [jdk8u-dev] RFR: 8324587: @headful key is contained in
 ExceptionFromPrintableIsIgnoredTest.java
In-Reply-To: <v8CK5-U6tWI1BM8agx9DSiEvr0xFBdAnkJETfYe7KLI=.161aac8d-ac9f-4a3a-a4b4-c22ac4ec43aa@github.com>
References: <v8CK5-U6tWI1BM8agx9DSiEvr0xFBdAnkJETfYe7KLI=.161aac8d-ac9f-4a3a-a4b4-c22ac4ec43aa@github.com>
Message-ID: <A1N2FlUYYQoYRyemxr6M-tSclB-sBDtGJ_ylcvQp4fI=.1589e696-8849-441b-96c5-9c73ee9e4245@github.com>

On Wed, 24 Jan 2024 07:02:49 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This fix removes the "@key headful printer" tag that was granted to ExceptionFromPrintableIsIgnoredTest.java in JDK-8273687. The test passed after this fix.
> Would you review this fix, please?

It appears that a pull request has already been issued for JDK-8185500. #464
I will close my pull request once it is merged.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/425#issuecomment-2051692388

From duke at openjdk.org  Mon Apr 15 09:53:10 2024
From: duke at openjdk.org (Shruthi)
Date: Mon, 15 Apr 2024 09:53:10 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
Message-ID: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>

Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f

-------------

Commit messages:
 - Backport 1b925183894778acce8aff4c101f67af98f0097f

Changes: https://git.openjdk.org/jdk8u-dev/pull/480/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=480&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8235834
  Stats: 264 lines in 2 files changed: 261 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/480.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/480/head:pull/480

PR: https://git.openjdk.org/jdk8u-dev/pull/480

From sroy at openjdk.org  Mon Apr 15 16:15:51 2024
From: sroy at openjdk.org (Suchismith Roy)
Date: Mon, 15 Apr 2024 16:15:51 GMT
Subject: [jdk8u-dev] RFR: 8320005: Allow loading of shared objects with .a
 extension on AIX [v4]
In-Reply-To: <oA3pk7L752hrt2cU_yz4rfCN1Sw4xTKqk5s_RjTDISA=.63ed8e87-ca33-4caf-af23-bdfadb5d93b2@github.com>
References: <SFb4ZXabl3OIWIFq3JpPVfuZoKywmPdLqpBi4TZEAq0=.d7efbe6c-e6c8-4bb6-97b5-1e4a700c09bd@github.com>
 <hb75wYfRbmGXsGQVGrxz7oBsa0mBezJS1vTwaQKzLp0=.455e52cd-13c0-4b9a-bf84-405819775c0d@github.com>
 <oA3pk7L752hrt2cU_yz4rfCN1Sw4xTKqk5s_RjTDISA=.63ed8e87-ca33-4caf-af23-bdfadb5d93b2@github.com>
Message-ID: <_VLRhMvtwXToiOh_-IFa4BqQakj6f7d02MPCUWSiW_k=.8678534e-1a59-4703-9761-e61521922817@github.com>

On Wed, 10 Apr 2024 14:28:12 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Hmmm, this seems to have travelled from trunk to 8u very quickly. This change is not in any released version as yet.
> 
> I think it would have been better to wait until at least the release of 22.0.2. I guess at least the change is isolated to AIX only, but I would make sure this is tested well before the July releases.

Hi @gnu-andrew  What is the usual timeline for a fix to go to the release branch from u-dev branch ? 
I am not sure how it went. I just did the usual backport as i did for 11 and 17.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/473#issuecomment-2057231883

From andrew at openjdk.org  Mon Apr 15 21:42:08 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 15 Apr 2024 21:42:08 GMT
Subject: [jdk8u-dev] RFR: 8159454: [TEST_BUG]
 javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics
 configurations should be limited [v2]
In-Reply-To: <Ph_y67XV6sSjVtHUA5Mm7IKV2t3C7qcliE-oNDoyByk=.d48c99a9-afd8-4c5a-9883-2c6319cacc0a@github.com>
References: <9JkNl5f6NIflswSXOTwTexI8lh4G5isxpiUbGDPX4ZA=.f5283fa5-cfea-4723-9856-246da6918036@github.com>
 <Ph_y67XV6sSjVtHUA5Mm7IKV2t3C7qcliE-oNDoyByk=.d48c99a9-afd8-4c5a-9883-2c6319cacc0a@github.com>
Message-ID: <JysWNLFRnJAR1t_kkw3qxHT4uvfgduk0cgyyGxrrzNc=.6c24f609-5fee-4f16-9004-d2c50e455bac@github.com>

On Fri, 12 Apr 2024 12:37:08 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a clean backport of JDK-8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited.
>> I have confirmed that bug7123767.java passes by backporting this fix.
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 64a2db9060bc9fc81afe451d0b057af57fc10f94

I guess we're removing `@modules` elsewhere then.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/405#issuecomment-2057855906

From imyers at openjdk.org  Mon Apr 15 21:48:03 2024
From: imyers at openjdk.org (Ian Myers)
Date: Mon, 15 Apr 2024 21:48:03 GMT
Subject: [jdk8u-dev] Integrated: 8329544: [8u]
 sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary
In-Reply-To: <uTOj3lmPUJQ1yAfGLjjlo97SiwYAwIIR4JOmhDsWkvg=.f11aa8ff-e7ee-4b50-9d8d-8dddb4e3b593@github.com>
References: <uTOj3lmPUJQ1yAfGLjjlo97SiwYAwIIR4JOmhDsWkvg=.f11aa8ff-e7ee-4b50-9d8d-8dddb4e3b593@github.com>
Message-ID: <aOjYD_POlu09y65zBucHZ38b_LTKVXoiZTjPn_G5fn0=.c7fdaf6c-7cad-4acb-8b9e-20a997160a3c@github.com>

On Tue, 2 Apr 2024 16:48:49 GMT, Ian Myers <imyers at openjdk.org> wrote:

> `sun/security/krb5/auto/ReplayCacheTestProc.java` fails on jdk8u-412 due to a compilation error. This is because the classpath is being set incorrectly by the `@library` annotation.
> 
> 
> TEST: sun/security/krb5/auto/ReplayCacheTestProc.java
> TEST JDK: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image
> 
> ACTION: compile -- Failed. Compilation failed: Compilation failed
> REASON: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
> TIME:   0.752 seconds
> messages:
> command: compile -XDignore.symbol.file /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto/ReplayCacheTestProc.java
> reason: User specified action: run compile -XDignore.symbol.file ReplayCacheTestProc.java
> Mode: agentvm
> Agent id: 1
> elapsed time (seconds): 0.752
> configuration:
> Boot Layer (javac runtime environment)
>   class path: /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
>               /local/home/ianrichr/openjdk/jtreg/lib/javatest.jar
>               /local/home/ianrichr/openjdk/jtreg/lib/jtreg.jar
> 
> javac compilation environment
>   source path: /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
>                /local/home/ianrichr/openjdk/jdk8u/jdk/test/java/security/testlibrary
>   class path:  /local/home/ianrichr/openjdk/jdk8u/jdk/test/sun/security/krb5/auto
>                /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/classes/0/sun/security/krb5/auto
>                /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/lib/tools.jar
> 
> rerun:
> cd /local/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/testoutput/jdk_adhoc/JTwork/scratch/0 && \
> HOME=/home/ianrichr \
> LANG=en_US.UTF-8 \
> PATH=/bin:/usr/bin:/usr/sbin \
>     /home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/bin/javac \
>         -J-ea \
>         -J-esa \
>         -J-Xmx512m \
>         -J-Dtest.vm.opts='-ea -esa -Xmx512m' \
>         -J-Dtest.tool.vm.opts='-J-ea -J-esa -J-Xmx512m' \
>         -J-Dtest.compiler.opts= \
>         -J-Dtest.java.opts= \
>         -J-Dtest.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
>         -J-Dcompile.jdk=/home/ianrichr/openjdk/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image \
>         -J-Dtest.timeout.factor=4.0 \
>         -J-Dtest.root=/local/home/ianrichr/openjdk/j...

This pull request has now been integrated.

Changeset: c6ba33ee
Author:    Ian Myers <imyers at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/c6ba33ee0016089917e1d1a4ef30c7d94399dc4d
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8329544: [8u] sun/security/krb5/auto/ReplayCacheTestProc.java cannot find the testlibrary

Reviewed-by: shade, andrew

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/478

From andrew at openjdk.org  Mon Apr 15 23:56:59 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 15 Apr 2024 23:56:59 GMT
Subject: [jdk8u-dev] RFR: 8324185: [8u] Accept Xcode 12+ builds on macOS
 [v4]
In-Reply-To: <EDSsf4K-w1KWvX3XNSlYPnW9mZ4HVkHkSTXWHnwSxrE=.420ce0c0-9cc8-4e2d-b0da-b95e16cbdcf2@github.com>
References: <wFC7MxDwgfdw32RrKlRDDdlzC1iAnu1SN2Y6jrFjYjs=.2a7a1733-2d30-4b3e-985e-5082e8099218@github.com>
 <EDSsf4K-w1KWvX3XNSlYPnW9mZ4HVkHkSTXWHnwSxrE=.420ce0c0-9cc8-4e2d-b0da-b95e16cbdcf2@github.com>
Message-ID: <ZojDyy6IDfvaYffYUdu_P_aZA4J8ANw-dEXKxAMRaQk=.acdf6848-20f2-448d-b99f-bab3375b1d78@github.com>

On Tue, 27 Feb 2024 17:45:03 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I would like to update the build logic for macOS so it will accept the XCode 14 and 15. It could be done in a few ways:
>> 
>>  - Add XCode 13, 14 and 15 to the list of supported versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d2d157ff4dd04cb108e036282643b21ac132016c)
>>  - Accept all XCode 9+ versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d1d5e2d214135084e50bc5aba839afab98cf2de7).
>>  - Delete the "fail fast" code path. So if the xcode and command-line tools are there then build it, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d28f6cdbc2bd6cb6bfefc84837a6c7c76c287572). 
>> 
>> I think we can safely delete this check, so this PR implements it.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'openjdk:master' into xcode
>  - Merge branch 'master' into xcode
>  - Merge branch 'openjdk:master' into xcode
>  - Drop "Fail-fast" code path
>  - Accept XCode 9+
>  - Add Xcode 13, 14 and 15

I agree removal is appropriate here. These kind of version tests serve no real purpose in the first place. If one is trying to get the JDK to build with a new XCode version, this check is just a blocker that has to be removed to get to the real issues and actually have something to work with to add support.  If the aim is to avoid a specific bug, or check for a specific feature, then the check should be for the bug or feature (see what we do with flags for GCC)

The thing I was most curious about with this PR was why it wasn't a backport from later versions. It seems that [JDK-8043340](https://bugs.openjdk.org/browse/JDK-8043340) was implemented differently in 8u and 9. In [the 9 version](https://hg.openjdk.org/jdk9/jdk9/rev/26ba036c46fc) this check is not added. It is unique to [the 8 version](https://github.com/openjdk/jdk8u/commit/d85158eee8a044501fd316ffe709e2483ab578e8), restricting it to XCode 4. @benty-amzn's later change just extended it to more versions.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/422#pullrequestreview-2002359139

From andrew at openjdk.org  Mon Apr 15 23:58:59 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Mon, 15 Apr 2024 23:58:59 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
Message-ID: <WVWJaiB6FUwIx_BUIH2UN5a9NH8Fs-X6oTCJM3wk6LE=.ca1e06fc-48f4-4adf-a12f-f255ff41275e@github.com>

On Tue, 9 Apr 2024 09:30:05 GMT, Kun Wang <kwang at openjdk.org> wrote:

> Env:
> ldd (GNU libc) 2.38
> gcc (GCC) 12.3.1 
> 
> Test the PR patch;
> Build release/fastdebug/slowdebug version pass
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

The `register` issue is already being handled by the work ongoing in https://github.com/openjdk/jdk8u-dev/pull/357

I have not seen other failures. Are they specific to certain architectures?

We should not be introducing changes uniquely to 8u unless it is really necessary, so we need to look at this code in later JDKs.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/479#issuecomment-2058002929

From kwang at openjdk.org  Tue Apr 16 01:38:00 2024
From: kwang at openjdk.org (Kun Wang)
Date: Tue, 16 Apr 2024 01:38:00 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
Message-ID: <0DDJ86_8bANGpX3EOoz9Ci1Ot1_n-2YLG-Uf3soxmRQ=.585d9783-3175-454b-bf9b-0bc24258ccb0@github.com>

On Tue, 9 Apr 2024 09:30:05 GMT, Kun Wang <kwang at openjdk.org> wrote:

> Env:
> ldd (GNU libc) 2.38
> gcc (GCC) 12.3.1 
> 
> Test the PR patch;
> Build release/fastdebug/slowdebug version pass
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

> The `register` issue is already being handled by the work ongoing in #357
> 
> I have not seen other failures. Are they specific to certain architectures?
> 
> We should not be introducing changes uniquely to 8u unless it is really necessary, so we need to look at this code in later JDKs.

Thank you very much for your code review and also suggest.
I found this problem when using gcc12 under the aarch64 architecture. After referring to https://github.com/openjdk/jdk8u-dev/pull/357, I still encounter other problems. I may need to remove the changes in adlc.make, the others are still having build issues in gcc12.

In file included from /home//jdk8u-dev-master/hotspot/src/share/vm/runtime/orderAccess.inline.hpp:45,
                 from /home//jdk8u-dev-master/hotspot/src/os/linux/vm/os_linux.inline.hpp:29,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/utilities/histogram.hpp:32,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/runtime/mutex.hpp:30,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/classfile/classLoaderData.hpp:32,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/typeArrayKlass.hpp:28,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/typeArrayOop.hpp:29,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/constantPool.hpp:32,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/oops/method.hpp:33,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/runtime/frame.hpp:28,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/code/codeBlob.hpp:30,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/code/codeCache.hpp:28,
                 from /home//jdk8u-dev-master/hotspot/src/cpu/aarch64/vm/assembler_aarch64.inline.hpp:32,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/asm/assembler.inline.hpp:46,
                 from /home//jdk8u-dev-master/hotspot/src/share/vm/precompiled/precompiled.hpp:30:
In static member function ?static void* OrderAccess::load_ptr_acquire(const volatile void*)?,
    inlined from ?nmethod* volatile Method::code() const? at /home//jdk8u-dev-master/hotspot/src/share/vm/oops/method.hpp:454:127,
    inlined from ?static bool CompileBroker::compilation_is_complete(methodHandle, int, int)? at /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compileBroker.cpp:1463:37,
    inlined from ?static bool CompileBroker::compilation_is_complete(methodHandle, int, int)? at /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compileBroker.cpp:1448:6,
    inlined from ?static nmethod* CompileBroker::compile_method(methodHandle, int, int, methodHandle, int, const char*, Thread*)? at /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compileBroker.cpp:1357:34:
/home//jdk8u-dev-master/hotspot/src/os_cpu/linux_aarch64/vm/orderAccess_linux_aarch64.inline.hpp:78:28: error: ?long unsigned int __atomic_load_8(const volatile void*, int)? writing 8 bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=]
   78 | { void* data; __atomic_load((void* const volatile *)p, &data, __ATOMIC_ACQUIRE); return data; }
      |               ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Done with /home//jdk8u-dev-master/hotspot/src/share/vm/compiler/compilerOracle.cpp

`-Werror=stringop-overflow=`, 

I'll test it on x86 architecture, and I'll report back with the results.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/479#issuecomment-2058078166

From serb at openjdk.org  Tue Apr 16 07:56:02 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 16 Apr 2024 07:56:02 GMT
Subject: [jdk8u-dev] Integrated: 8324185: [8u] Accept Xcode 12+ builds on macOS
In-Reply-To: <wFC7MxDwgfdw32RrKlRDDdlzC1iAnu1SN2Y6jrFjYjs=.2a7a1733-2d30-4b3e-985e-5082e8099218@github.com>
References: <wFC7MxDwgfdw32RrKlRDDdlzC1iAnu1SN2Y6jrFjYjs=.2a7a1733-2d30-4b3e-985e-5082e8099218@github.com>
Message-ID: <94dHrLuOXv7Os7zjMRojIHJkC5Eib9DdPMl7AiAaS3Q=.4cf9c993-44be-4967-b9cb-9cae88568e1b@github.com>

On Fri, 19 Jan 2024 02:50:11 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> I would like to update the build logic for macOS so it will accept the XCode 14 and 15. It could be done in a few ways:
> 
>  - Add XCode 13, 14 and 15 to the list of supported versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d2d157ff4dd04cb108e036282643b21ac132016c)
>  - Accept all XCode 9+ versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d1d5e2d214135084e50bc5aba839afab98cf2de7).
>  - Delete the "fail fast" code path. So if the xcode and command-line tools are there then build it, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d28f6cdbc2bd6cb6bfefc84837a6c7c76c287572). 
> 
> I think we can safely delete this check, so this PR implements it.

This pull request has now been integrated.

Changeset: 0f59d5ce
Author:    Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/0f59d5ce82d146c1b238437731c26b02036dfdb2
Stats:     16 lines in 2 files changed: 0 ins; 15 del; 1 mod

8324185: [8u] Accept Xcode 12+ builds on macOS

Reviewed-by: phh, andrew

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/422

From duke at openjdk.org  Tue Apr 16 09:32:02 2024
From: duke at openjdk.org (Shruthi)
Date: Tue, 16 Apr 2024 09:32:02 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
Message-ID: <KtYUEdXkVtIeyrKHxN9ADFoMRTg6WHLBmamT2Xme5bw=.c452fa11-cec0-4690-bd75-286d7552196e@github.com>

On Mon, 15 Apr 2024 09:48:45 GMT, Shruthi <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f

@naotoj Can you please review this PR

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/480#issuecomment-2058648947

From ktakakuri at openjdk.org  Tue Apr 16 14:33:07 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 16 Apr 2024 14:33:07 GMT
Subject: [jdk8u-dev] RFR: 8137329: [windows] Build broken on VS2010 after
 "8046148: JEP 158: Unified JVM Logging" [v2]
In-Reply-To: <ZEsgsb87ag5jTtrZ3MhMprN8PpsFD4xH5yKGhYzrK0A=.ba210082-763a-43b0-82a2-1c9e482825f5@github.com>
References: <VKCKtc4PbdqZX11nJpWjQD43MGO6I8g92fBD1rzgUCs=.cbd3801c-7a00-468e-8b3e-346c4979ac7c@github.com>
 <ZEsgsb87ag5jTtrZ3MhMprN8PpsFD4xH5yKGhYzrK0A=.ba210082-763a-43b0-82a2-1c9e482825f5@github.com>
Message-ID: <FEd67eXAGzUbR9JE_td2S6-VcKEyeLLLH7h9fLwsjuY=.2ae90ae4-c835-4787-aac3-9f5176dd4914@github.com>

On Mon, 8 Apr 2024 12:23:55 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all, This is a backport of JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging".
>> I worked on backporting JDK-8159695 to jdk8u ( https://github.com/openjdk/jdk8u-dev/pull/428 ), and found that VS2010 build fails. This is because strtoull function, which the JDK-8159695 patch contains, is not predefined in VS2010. This patch defines strtoull macro when the earlier versions of Visual Studio are used, so this patch need to be backported for builing with VS2010 if JDK-8159695 is backported as proposed.
>> 
>> This patch couldn't be applied cleanly due to a previously backported fix for earlier versions of Visual Studio at the same location, which needs to be merged.
>> 
>> The risk is low as this only affects earlier VS builds and introduces one macro.  
>> Testing: GHA
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request incrementally with 40 additional commits since the last revision:
> 
>  - Merge branch 'master' into 8137329
>  - 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
>    
>    Backport-of: 2fa6eac464048176087092c91c8430781ab15301
>  - 8291226: Create Test Cases to cover scenarios for JDK-8278067
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
>  - 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
>    
>    Reviewed-by: simonis
>    Backport-of: a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1
>  - 8325927: [8u] Backport of JDK-8170552 missed part of the test
>    
>    Reviewed-by: sgehwolf
>  - 8328809: [8u] Problem list some CA tests
>    
>    Reviewed-by: andrew
>  - 8317507: C2 compilation fails with "Exceeded _node_regs array"
>    
>    Reviewed-by: roland, andrew
>    Backport-of: a5818972c16bd883d768ff2fb23a8aa9e0142c65
>  - Merge
>  - 8321408: Add Certainly roots R1 and E1
>    
>    Reviewed-by: sgehwolf
>    Backport-of: e8f7eaeefe503a34089fd49051f9114d98a63cb1
>  - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
>    
>    Reviewed-by: phh, andrew
>    Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb
>  - ... and 30 more: https://git.openjdk.org/jdk8u-dev/compare/7b175458...5fbb88b2

Some tests are failing in GHA, but they are irrelevant as they are related to certification or GC.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/434#issuecomment-2059237715

From ktakakuri at openjdk.org  Tue Apr 16 14:35:06 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 16 Apr 2024 14:35:06 GMT
Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect
 overflows
In-Reply-To: <L7n5VaEVNKP-Ru5auzJvVOj-ODVqIbhrQHdvBnRuSss=.6f6e3cc7-4291-42b0-b5cf-1e7a2f1d52aa@github.com>
References: <L7n5VaEVNKP-Ru5auzJvVOj-ODVqIbhrQHdvBnRuSss=.6f6e3cc7-4291-42b0-b5cf-1e7a2f1d52aa@github.com>
Message-ID: <uuJYEnkqWKzBJgM8x1W4yH18fGtSMAR8giGbdfSEj1E=.32ef40e2-e3bc-4bd4-9188-5b0950cefd4d@github.com>

On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows.
> The bug reported is reproducible in JDK8, so this patch should be applied.
> The original patch does not apply cleanly, and the following modifications are needed:
> 
> - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9.
> - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8.
> 
> Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options.
> Testing
> 
> - Manually check the behaviour
> When a given value is too large to fit in a julong, the proper exception is raised with this patch.
> 
> without patch
> 
> java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget
> 
>     uintx GCDrainStackTargetSize                   := 18446744073709551615                    {product}
> 
> 
> with patch
> 
> java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version
> Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999'
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> 
> 
> - hotspot_tier1
> 
> Thank you.

As phohensee has pointed out ,strtoull needs to be declared for Windows-x86. A corresponding fix exists in JDK9, but it's in a different context. I am currently working on backporting this fix in issue #434. Once issue #434 is integrated, the build failure will be resolved and GHA result is fine (see #434).

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2059241778

From duke at openjdk.org  Tue Apr 16 14:38:05 2024
From: duke at openjdk.org (mirabilos)
Date: Tue, 16 Apr 2024 14:38:05 GMT
Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when
 building jdk8
In-Reply-To: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
References: <b27UjYcVCUPbdQn5UeTT_EGzsV1pcGmOvs-2y44iGDw=.6e9b76dc-051e-49c9-b8aa-6f50e95998d3@github.com>
Message-ID: <0LVLu1jW_ggLUHugcFa6cdySqSVmR4pJ8U36_VepFqQ=.fa972d59-baf5-4c77-a6fd-be5d654a48dd@github.com>

On Tue, 9 Apr 2024 09:30:05 GMT, Kun Wang <kwang at openjdk.org> wrote:

> Env:
> ldd (GNU libc) 2.38
> gcc (GCC) 12.3.1 
> 
> Test the PR patch;
> Build release/fastdebug/slowdebug version pass
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826

Changes requested by mirabilos at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/479#pullrequestreview-2003833891

From iris.clark at oracle.com  Tue Apr 16 15:00:31 2024
From: iris.clark at oracle.com (Iris Clark)
Date: Tue, 16 Apr 2024 15:00:31 +0000
Subject: Proposal: Support Wayland and add KEM APIs
Message-ID: <SJ0PR10MB5440E3E08EA29C0BFF1D36FDFB082@SJ0PR10MB5440.namprd10.prod.outlook.com>

In November 2023, Red Hat announced [0] their intent to remove the Xorg server
from RHEL 10; therefore, only Wayland will be supported in RHEL 10 and
subsequent releases.  Other Linux distributions may choose a similar path.

This will be an issue for Java SE 8, 11, and 17 as they only support the Xorg
server.

  - (JSRs 337, 384, 392) The Java SE 8, 11, and 17 specifications of
    java.awt.Robot make several assumptions about programmatic access to the
    desktop and related behaviours which may not be valid due to restrictions
    in underlying environments such as Wayland.  In Java SE 21, the
    specification was amended to allow operations to degrade or fail.  This
    specification change alone is sufficient to allow for variances in desktop
    behaviour. [1]

We would also like to add support in Java SE 17 for functionality required by
some Post-Quantum Cryptographic (PQC) algorithms.  The following new APIs are
necessary to support all of the candidate algorithms currently identified by
the U.S. National Institute of Standards and Technology (NIST) for PQC
standardization.  This will be an issue as:

  - (JSR 392) KEM APIs were added to Java SE 21 with JEP 452 (Key
    Encapsulation Mechanism (KEM) API) [2].  They support secure encryption
    techniques to derive symmetric keys using public key cryptography.  None
    of the existing cryptographic APIs in the Java Platform are capable of
    representing KEMs in a natural way. [3]

Finally, we would like to add the system property
"java.specification.maintenance.version" to Java SE 17, thus aligning it with
Java SE 8, Java SE 11, and releases Java SE 19 and beyond.  The issue is:

  - (JSR 392) The Java SE 17 Specification does not have a programmatic means
    to identify whether a JDK is implementing an original, or maintenance
    release of the Java SE specification.  The system property
    "java.specification.maintenance.version" was added in Java SE 19 and
    subsequently backported to Java SE 8 via MR 4 and Java SE 11 via MR 2. [4]

To resolve these issues for future JDK updates, I'll shortly propose
Maintenance Releases of the Java SE 8 [5], the Java SE 11 [6], and Java SE 17
[7] Platform JSRs in the JCP.  For Java SE 8 and Java SE 11, this will require
updates to the Specification only; for Java SE 17 this will require updates to
the Specification, the Reference Implementation (RI), and the TCK.  These will
be provided by me and my Oracle colleagues.  I expect the Maintenance Release
process to complete by July 2024, in time for these changes to be merged into
the October security releases of JDK 8, JDK 11, and JDK 17.

Following the standard practice, we will base the open-source RI on the most
recent RI for the release, rather than the most recent JDK Updates release.
We propose to label the RI build as "17.0.0.1" in order to convey that it is
outside the contemporary train of update releases.  It is neither meant for
production use, nor will it be updated with security fixes.

If it's not too much work, we'll also contribute the changes required by these
MRs to the next appropriate JDK 8, 11, and 17 Updates releases (most likely
8u432, 11.0.25, and 17.0.13 respectively).  We do not plan to backport the
DH-Based KEM implementation that was included in JEP 452.

Comments?

Iris

[0]: https://www.redhat.com/en/blog/rhel-10-plans-wayland-and-xorg-server
[1]: https://bugs.openjdk.org/browse/JDK-8308012 [Robot]
[2]: https://openjdk.org/jeps/452
[3]: https://bugs.openjdk.org/browse/JDK-8305384 [KEM]
[4]: https://bugs.openjdk.org/browse/JDK-8285764 [sys prop]
[5]: https://jcp.org/en/jsr/detail?id=337
[6]: https://jcp.org/en/jsr/detail?id=384
[7]: https://jcp.org/en/jsr/detail?id=392

From t.glaser at qvest-digital.com  Tue Apr 16 15:59:59 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Tue, 16 Apr 2024 17:59:59 +0200 (CEST)
Subject: Proposal: Support Wayland and add KEM APIs
In-Reply-To: <SJ0PR10MB5440E3E08EA29C0BFF1D36FDFB082@SJ0PR10MB5440.namprd10.prod.outlook.com>
References: <SJ0PR10MB5440E3E08EA29C0BFF1D36FDFB082@SJ0PR10MB5440.namprd10.prod.outlook.com>
Message-ID: <2dd56dbb-f640-d113-e67c-d6902d3d938f@qvest-digital.com>

On Tue, 16 Apr 2024, Iris Clark wrote:

>Comments?

Please do not break X11 support while doing so.

Thanks,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From iris.clark at oracle.com  Tue Apr 16 16:58:38 2024
From: iris.clark at oracle.com (Iris Clark)
Date: Tue, 16 Apr 2024 16:58:38 +0000
Subject: [External] : Re: Proposal: Support Wayland and add KEM APIs
In-Reply-To: <2dd56dbb-f640-d113-e67c-d6902d3d938f@qvest-digital.com>
References: <SJ0PR10MB5440E3E08EA29C0BFF1D36FDFB082@SJ0PR10MB5440.namprd10.prod.outlook.com>
 <2dd56dbb-f640-d113-e67c-d6902d3d938f@qvest-digital.com>
Message-ID: <SJ0PR10MB5440708584834EDD357B511BFB082@SJ0PR10MB5440.namprd10.prod.outlook.com>

Hi.

>>Comments?

> Please do not break X11 support while doing so.

Since we're just backporting Specification changes, X11 support should be unchanged.  These Spec changes are already in JDK 21 and later.

Best,
Iris

________________________________
From: Thorsten Glaser <t.glaser at qvest-digital.com>
Sent: Tuesday, April 16, 2024 8:59 AM
To: Iris Clark <iris.clark at oracle.com>
Cc: jdk8u-dev at openjdk.org <jdk8u-dev at openjdk.org>; jdk-updates-dev at openjdk.org <jdk-updates-dev at openjdk.org>
Subject: [External] : Re: Proposal: Support Wayland and add KEM APIs

On Tue, 16 Apr 2024, Iris Clark wrote:

>Comments?

Please do not break X11 support while doing so.

Thanks,
//mirabilos
--
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://urldefense.com/v3/__https://www.qvest-digital.com/__;!!ACWV5N9M2RV99hQ!Mr7s-cX9bPo-_0CmuVcdoGhmXRau4zf9rfhRs1wp8YBo_GA9sFj2N_pe71D0lvv3tJnqHAm1NGpGigV2uPdmwQ9Q$
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240416/5e135001/attachment-0001.htm>

From andrew at openjdk.org  Tue Apr 16 18:39:24 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Tue, 16 Apr 2024 18:39:24 GMT
Subject: [jdk8u-dev] RFR: 8258855: Two tests
 sun/security/krb5/auto/ReplayCacheTestProc.java and
 ReplayCacheTestProcWithMD5.java failed on OL8.3
Message-ID: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>

In testing `sun/security/krb5/auto/ReplayCacheTestProc.java` following [JDK-8168518](https://bugs.openjdk.org/browse/JDK-8168518), I found both it and `sun/security/krb5/auto/rcache_usemd5.sh` failed on RHEL 8.  This did not seem to be a regression caused by the 8u412 change as it failed on the current release, 8u402.  The failure was further confirmed by @martinuy who found it was due to the newer Kerberos version on RHEL 8, and it passed on Fedora 31.

 @jerboaa alerted me to [JDK-8258855](https://bugs.openjdk.org/browse/JDK-8258855) and backporting this change to 8u makes the tests pass.

The code changes apply as is. The headers have to be adjusted slightly to take into account the different DNS options used in 8u.  The change to `test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java` also moves to `jdk/test/sun/security/krb5/auto/rcache_usemd5.sh` on 8u and has to be manually applied. I looked briefly at backporting [JDK-8180569](https://bugs.openjdk.org/browse/JDK-8180569) which refactors these Kerberos shell tests into Java tests, and I think it has merit, but is likely quite involved and requires other test library backports. For now, we can just backport this change as the shell script is different to the one removed by 8180569 with or without this patch applied first.

-------------

Commit messages:
 - Backport 8d780729c65bbfd19f23004723b8786d52f8310a

Changes: https://git.openjdk.org/jdk8u-dev/pull/481/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=481&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8258855
  Stats: 46 lines in 2 files changed: 23 ins; 20 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/481.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/481/head:pull/481

PR: https://git.openjdk.org/jdk8u-dev/pull/481

From mbalao at openjdk.org  Tue Apr 16 20:09:01 2024
From: mbalao at openjdk.org (Martin Balao)
Date: Tue, 16 Apr 2024 20:09:01 GMT
Subject: [jdk8u-dev] RFR: 8258855: Two tests
 sun/security/krb5/auto/ReplayCacheTestProc.java and
 ReplayCacheTestProcWithMD5.java failed on OL8.3
In-Reply-To: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
References: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
Message-ID: <EqYuWry2o69rJKqoC0NtyhUaYKXOffqCigA625kZa_Y=.3df29c6a-ce9b-448f-a349-2b59bc1061b5@github.com>

On Tue, 16 Apr 2024 18:33:12 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> In testing `sun/security/krb5/auto/ReplayCacheTestProc.java` following [JDK-8168518](https://bugs.openjdk.org/browse/JDK-8168518), I found both it and `sun/security/krb5/auto/rcache_usemd5.sh` failed on RHEL 8.  This did not seem to be a regression caused by the 8u412 change as it failed on the current release, 8u402.  The failure was further confirmed by @martinuy who found it was due to the newer Kerberos version on RHEL 8, and it passed on Fedora 31.
> 
>  @jerboaa alerted me to [JDK-8258855](https://bugs.openjdk.org/browse/JDK-8258855) and backporting this change to 8u makes the tests pass.
> 
> The code changes apply as is. The headers have to be adjusted slightly to take into account the different DNS options used in 8u.  The change to `test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java` also moves to `jdk/test/sun/security/krb5/auto/rcache_usemd5.sh` on 8u and has to be manually applied. I looked briefly at backporting [JDK-8180569](https://bugs.openjdk.org/browse/JDK-8180569) which refactors these Kerberos shell tests into Java tests, and I think it has merit, but is likely quite involved and requires other test library backports. For now, we can just backport this change as the shell script is different to the one removed by 8180569 with or without this patch applied first.

Thanks for proposing this backport. Looks good to me.

-------------

Marked as reviewed by mbalao (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/481#pullrequestreview-2004506978

From serb at openjdk.org  Tue Apr 16 20:25:01 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Tue, 16 Apr 2024 20:25:01 GMT
Subject: [jdk8u-dev] RFR: 8258855: Two tests
 sun/security/krb5/auto/ReplayCacheTestProc.java and
 ReplayCacheTestProcWithMD5.java failed on OL8.3
In-Reply-To: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
References: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
Message-ID: <k2AGPAa-V57WMkyxU6A8hJbP_XOEOP0xqIQ8fmhWvJs=.793cbb7a-9597-4b7c-9782-c9bbd6d084e4@github.com>

On Tue, 16 Apr 2024 18:33:12 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> In testing `sun/security/krb5/auto/ReplayCacheTestProc.java` following [JDK-8168518](https://bugs.openjdk.org/browse/JDK-8168518), I found both it and `sun/security/krb5/auto/rcache_usemd5.sh` failed on RHEL 8.  This did not seem to be a regression caused by the 8u412 change as it failed on the current release, 8u402.  The failure was further confirmed by @martinuy who found it was due to the newer Kerberos version on RHEL 8, and it passed on Fedora 31.
> 
>  @jerboaa alerted me to [JDK-8258855](https://bugs.openjdk.org/browse/JDK-8258855) and backporting this change to 8u makes the tests pass.
> 
> The code changes apply as is. The headers have to be adjusted slightly to take into account the different DNS options used in 8u.  The change to `test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java` also moves to `jdk/test/sun/security/krb5/auto/rcache_usemd5.sh` on 8u and has to be manually applied. I looked briefly at backporting [JDK-8180569](https://bugs.openjdk.org/browse/JDK-8180569) which refactors these Kerberos shell tests into Java tests, and I think it has merit, but is likely quite involved and requires other test library backports. For now, we can just backport this change as the shell script is different to the one removed by 8180569 with or without this patch applied first.

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/481#pullrequestreview-2004532587

From andrew at openjdk.org  Wed Apr 17 01:04:02 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 17 Apr 2024 01:04:02 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
Message-ID: <nhegTpoH9ykpRLubmvklBtFY18Yy76pCNb4vA8iYC4M=.b4f75c93-ee4e-4f88-b8e5-65ccc331e11c@github.com>

Sync jdk8u412-b08/jdk8u412-ga

-------------

Commit messages:
 - Merge
 - 8317507: C2 compilation fails with "Exceeded _node_regs array"
 - 8322122: Enhance generation of addresses
 - 8322114: Improve Pack 200 handling
 - 8319851: Improve exception logging
 - 8318340: Improve RSA key implementations

The merge commit only contains trivial merges, so no merge-specific webrevs have been generated.

Changes: https://git.openjdk.org/jdk8u-dev/pull/482/files
  Stats: 321 lines in 17 files changed: 146 ins; 77 del; 98 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/482.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/482/head:pull/482

PR: https://git.openjdk.org/jdk8u-dev/pull/482

From andrew at openjdk.org  Wed Apr 17 02:15:01 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 17 Apr 2024 02:15:01 GMT
Subject: [jdk8u-dev] RFR: Merge jdk8u:master
In-Reply-To: <nhegTpoH9ykpRLubmvklBtFY18Yy76pCNb4vA8iYC4M=.b4f75c93-ee4e-4f88-b8e5-65ccc331e11c@github.com>
References: <nhegTpoH9ykpRLubmvklBtFY18Yy76pCNb4vA8iYC4M=.b4f75c93-ee4e-4f88-b8e5-65ccc331e11c@github.com>
Message-ID: <bY7LRnqeiexU2KFVawYoyoVzaOxCHJJ3picSSXidrso=.d66443e1-2f85-4a4f-bb15-5bd4e08c93f1@github.com>

On Wed, 17 Apr 2024 00:59:42 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Sync jdk8u412-b08/jdk8u412-ga

Failures are a Certigna certificate test and an Ubuntu outage causing package download failures.
Neither are related to the merge.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/482#issuecomment-2060212781

From andrew at openjdk.org  Wed Apr 17 02:27:01 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 17 Apr 2024 02:27:01 GMT
Subject: [jdk8u-dev] RFR: 8258855: Two tests
 sun/security/krb5/auto/ReplayCacheTestProc.java and
 ReplayCacheTestProcWithMD5.java failed on OL8.3
In-Reply-To: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
References: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
Message-ID: <Nd9rr9do5iwfi3WgPIRlZii__zqPpZaYn0W3ZiTGffI=.684c2897-b3f3-4c0b-89d4-1d49465cc15e@github.com>

On Tue, 16 Apr 2024 18:33:12 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> In testing `sun/security/krb5/auto/ReplayCacheTestProc.java` following [JDK-8168518](https://bugs.openjdk.org/browse/JDK-8168518), I found both it and `sun/security/krb5/auto/rcache_usemd5.sh` failed on RHEL 8.  This did not seem to be a regression caused by the 8u412 change as it failed on the current release, 8u402.  The failure was further confirmed by @martinuy who found it was due to the newer Kerberos version on RHEL 8, and it passed on Fedora 31.
> 
>  @jerboaa alerted me to [JDK-8258855](https://bugs.openjdk.org/browse/JDK-8258855) and backporting this change to 8u makes the tests pass.
> 
> The code changes apply as is. The headers have to be adjusted slightly to take into account the different DNS options used in 8u.  The change to `test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java` also moves to `jdk/test/sun/security/krb5/auto/rcache_usemd5.sh` on 8u and has to be manually applied. I looked briefly at backporting [JDK-8180569](https://bugs.openjdk.org/browse/JDK-8180569) which refactors these Kerberos shell tests into Java tests, and I think it has merit, but is likely quite involved and requires other test library backports. For now, we can just backport this change as the shell script is different to the one removed by 8180569 with or without this patch applied first.

* Test failures are the Certigna certificate and a sporadic HotSpot GC test failure, `gc/logging/TestGCId.java`
* Build failures seem to be down to Buster inaccessibility for the cross-compile. With it going EOL at the end of June, we may need to backport [JDK-8314658](https://bugs.openjdk.org/browse/JDK-8314658) to upgrade to bullseye.

None of them relate to this change.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/481#issuecomment-2060222244

From andrew at openjdk.org  Wed Apr 17 02:32:03 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Wed, 17 Apr 2024 02:32:03 GMT
Subject: [jdk8u-dev] Integrated: Merge jdk8u:master
In-Reply-To: <nhegTpoH9ykpRLubmvklBtFY18Yy76pCNb4vA8iYC4M=.b4f75c93-ee4e-4f88-b8e5-65ccc331e11c@github.com>
References: <nhegTpoH9ykpRLubmvklBtFY18Yy76pCNb4vA8iYC4M=.b4f75c93-ee4e-4f88-b8e5-65ccc331e11c@github.com>
Message-ID: <YCcm54xJM0cccHdseVBOq3iYm8zy46Co-gTW7DGPzek=.4b8913b0-11f3-43fe-9817-efc7c958bb4a@github.com>

On Wed, 17 Apr 2024 00:59:42 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Sync jdk8u412-b08/jdk8u412-ga

This pull request has now been integrated.

Changeset: 0e0b018a
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/0e0b018acba9a869f8795a18b03f94e85cfaf86f
Stats:     321 lines in 17 files changed: 146 ins; 77 del; 98 mod

Merge

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/482

From ktakakuri at openjdk.org  Wed Apr 17 08:22:04 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 08:22:04 GMT
Subject: [jdk8u-dev] RFR: 8210560: [TEST] convert com/sun/jdi
 redefineClass-related tests
In-Reply-To: <uL_to5DEdwu_aIVrdqCFxudecSU2Beav8j6b8tf9zaY=.48cfeed6-7529-46e6-a856-a446dc48878b@github.com>
References: <uL_to5DEdwu_aIVrdqCFxudecSU2Beav8j6b8tf9zaY=.48cfeed6-7529-46e6-a856-a446dc48878b@github.com>
Message-ID: <SyTAJPLRefA_UPaOlf66d2p_REywx7wRNy9KeK4lH88=.f0dad820-d51e-4a9a-a359-683bf5631d3f@github.com>

On Thu, 3 Aug 2023 07:15:41 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This is a backport of JDK-8210560: [TEST] convert com/sun/jdi redefineClass-related tests.
> 
> Original patch does not apply cleanly to 8u, because:
> 1. ClassTranformer.java of the original patch uses jdk.test.lib.compiler.CompilerUtils in test/lib.
> 2. However, CompilerUtils in test/lib cannot be compiled with JDK8 because it uses an API added in JDK9 (javax.tools.StandardJavaFileManager).
> 
> So, I replaced the CompilerUtils with test/lib/testlibrary/CompilerUtils.java to avoid using StandardJavaFileManager.
> 
> I confirmed that all of these tests pass on Windows x86_64 and Linux RedHat x86_64.

Indeed, this pull request includes some bug IDs.
I close this pull request to backport each bug ID separately.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/350#issuecomment-2060679323

From ktakakuri at openjdk.org  Wed Apr 17 08:24:11 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 08:24:11 GMT
Subject: [jdk8u-dev] Integrated: 8318410:
 jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese
 Windows
In-Reply-To: <wEuB6WuiMXPQ7LcM6HvuGHUvi-diLAT09Petd7S7POY=.9a8f82cc-f1d6-4192-a3c5-5a3e5bf7b529@github.com>
References: <wEuB6WuiMXPQ7LcM6HvuGHUvi-diLAT09Petd7S7POY=.9a8f82cc-f1d6-4192-a3c5-5a3e5bf7b529@github.com>
Message-ID: <OfXw2yFjWOIWPejJkgkR5ngTwTG8M10bRGLdf8fPq68=.0020bc09-55b9-4499-b4dc-275bf9c0a092@github.com>

On Tue, 13 Feb 2024 12:07:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> I would like to fix this issue because the test dose not work as intended. 8318410 resolved two issues. However, the first issue related to JEP400 is not relevant to JDK8. Therefore, I would like to backport only the second issue, which is the problem of tests not running properly on Windows cygwin. The fix applis cleanly to 8u from 17u.

This pull request has now been integrated.

Changeset: 68ab0f3b
Author:    Kazuhisa Takakuri <ktakakuri at openjdk.org>
Committer: Severin Gehwolf <sgehwolf at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/68ab0f3b243c7b7934b47ccf9513f052aaf6536f
Stats:     24 lines in 2 files changed: 20 ins; 0 del; 4 mod

8318410: jdk/java/lang/instrument/BootClassPath/BootClassPathTest.sh fails on Japanese Windows

Reviewed-by: phh
Backport-of: 4144ef36bcefb0ba597be9c871b15be5043ad231

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/440

From ktakakuri at openjdk.org  Wed Apr 17 09:01:01 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 09:01:01 GMT
Subject: [jdk8u-dev] RFR: 8159454: [TEST_BUG]
 javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics
 configurations should be limited [v2]
In-Reply-To: <Ph_y67XV6sSjVtHUA5Mm7IKV2t3C7qcliE-oNDoyByk=.d48c99a9-afd8-4c5a-9883-2c6319cacc0a@github.com>
References: <9JkNl5f6NIflswSXOTwTexI8lh4G5isxpiUbGDPX4ZA=.f5283fa5-cfea-4723-9856-246da6918036@github.com>
 <Ph_y67XV6sSjVtHUA5Mm7IKV2t3C7qcliE-oNDoyByk=.d48c99a9-afd8-4c5a-9883-2c6319cacc0a@github.com>
Message-ID: <vw_4huuPAgh9iFWtCcajw-k0eIR_WywAAdR3s21_0us=.f13abb1e-8b9a-4248-8fc1-5e1b122656b3@github.com>

On Fri, 12 Apr 2024 12:37:08 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a clean backport of JDK-8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited.
>> I have confirmed that bug7123767.java passes by backporting this fix.
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 64a2db9060bc9fc81afe451d0b057af57fc10f94

After requesting the fix request I made an additional commit, which is a fix for a syntax error.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/405#issuecomment-2060752420

From ktakakuri at openjdk.org  Wed Apr 17 09:53:04 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 09:53:04 GMT
Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails
 after JDK-8217612 [v2]
In-Reply-To: <xmPuXgfPdbXJert0ir-gTPD7xYkHwn4VnhxhR1op6ys=.35a3df11-31fd-44eb-bb9a-61798d6d6fe5@github.com>
References: <k7HhLB2KvVg5AAN6tmv9pWtwlMPA14WW7-dttthdpFg=.b8c154c7-620a-4df8-b142-a973cc518faa@github.com>
 <xmPuXgfPdbXJert0ir-gTPD7xYkHwn4VnhxhR1op6ys=.35a3df11-31fd-44eb-bb9a-61798d6d6fe5@github.com>
Message-ID: <x4MDnsuf_OOzCC7FAhAJZ9EHpDEwV-LqI3KSUfPZnLI=.a9a4f797-b40d-4ed3-9e27-44c57eaa1d3b@github.com>

On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612  
>> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed.
>> 
>> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations.
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8217850
>  - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d
>  - d6a75a0f86d4c84132a3794c432b34068163fa60

Could someone please review this backport?
I have merged master branch to resolve the GHA error. Once #431 is merged, these diffs will disappear.
The only fix I put in this backport is https://github.com/openjdk/jdk8u-dev/pull/433/commits/ccb8463a09dc09a6df363017a350c8bc00fcbd60.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2060860956

From ktakakuri at openjdk.org  Wed Apr 17 11:04:28 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 11:04:28 GMT
Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with
 @key headful. [v4]
In-Reply-To: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
References: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
Message-ID: <WCNXSWgO6nmsJzzvJ8L12rUsopC6O-JK1YHKEAV4pmk=.500406f9-adc1-40b5-a338-459940685e47@github.com>

> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.
> 
> This patch has already been applied to OracleJDK8.
> As noted in the Bug Issue comments, some tests do not exist in 8u.

Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:

  Backport e52b963d0cdc49e2048757eae2e4b10bb279f296

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/383/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/383/files/757abee7..df1f54df

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=383&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=383&range=02-03

  Stats: 12 lines in 3 files changed: 1 ins; 4 del; 7 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/383.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/383/head:pull/383

PR: https://git.openjdk.org/jdk8u-dev/pull/383

From ktakakuri at openjdk.org  Wed Apr 17 11:14:36 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 11:14:36 GMT
Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with
 @key headful. [v5]
In-Reply-To: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
References: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
Message-ID: <oqaQzzhE0dPfidCSwo-sOu37PoGIMsCtzohWciSRLf8=.fe4ab449-c786-47c9-b7a0-f22903bdfd2f@github.com>

> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.
> 
> This patch has already been applied to OracleJDK8.
> As noted in the Bug Issue comments, some tests do not exist in 8u.

Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:

  Backport e52b963d0cdc49e2048757eae2e4b10bb279f296

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/383/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/383/files/df1f54df..341e9a82

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=383&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=383&range=03-04

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/383.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/383/head:pull/383

PR: https://git.openjdk.org/jdk8u-dev/pull/383

From ktakakuri at openjdk.org  Wed Apr 17 11:31:02 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 11:31:02 GMT
Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with
 @key headful. [v5]
In-Reply-To: <oqaQzzhE0dPfidCSwo-sOu37PoGIMsCtzohWciSRLf8=.fe4ab449-c786-47c9-b7a0-f22903bdfd2f@github.com>
References: <xZwOORWtfakLj99fCwtmT0x5RuD_wpqAFASjs-pzgZI=.ec9901c5-7f0e-4776-8a00-a54d90227e31@github.com>
 <oqaQzzhE0dPfidCSwo-sOu37PoGIMsCtzohWciSRLf8=.fe4ab449-c786-47c9-b7a0-f22903bdfd2f@github.com>
Message-ID: <_pdtKlvfZ_LyksLqH7VAO5lXm7olyvHVlsci1WcxwW4=.1e6f762e-8b42-4de4-97f5-d07266ce4245@github.com>

On Wed, 17 Apr 2024 11:14:36 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful.
>> 
>> This patch has already been applied to OracleJDK8.
>> As noted in the Bug Issue comments, some tests do not exist in 8u.
>
> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport e52b963d0cdc49e2048757eae2e4b10bb279f296

To backport this patch, the following change has been made, other than minor conflict resolution.

* The following 56 tests do not exist in jdk8u, and skipped.
jdk/test/com/sun/java/accessibility/util/8051626/Bug8051626.java
jdk/test/java/awt/Component/GetScreenLocTest/GetScreenLocTest.java
jdk/test/java/awt/Dialog/ChildProperties/ChildDialogProperties.java
jdk/test/java/awt/LightweightComponent/LightweightEventTest/LightweightEventTest.java
jdk/test/java/awt/PrintJob/PrinterException.java
jdk/test/java/awt/TextField/TextFieldEditing/TextFieldEditing.java
jdk/test/java/awt/Window/ChildProperties/ChildWindowProperties.java
jdk/test/java/awt/datatransfer/UnicodeTransferTest/UnicodeTransferTest.java
jdk/test/java/awt/image/multiresolution/MenuMultiresolutionIconTest.java
jdk/test/java/awt/image/multiresolution/MultiResolutionJOptionPaneIconTest.java
jdk/test/java/awt/print/PrinterJob/LandscapeStackOverflow.java
jdk/test/javax/swing/Action/8133039/bug8133039.java
jdk/test/javax/swing/GroupLayout/8013566/bug8013566.java
jdk/test/javax/swing/GroupLayout/8079640/bug8079640.java
jdk/test/javax/swing/InputVerifier/VerifyTarget/VerifyTargetTest.java
jdk/test/javax/swing/JButton/PressedButtonRightClickTest.java
jdk/test/javax/swing/JColorChooser/Test8051548.java
jdk/test/javax/swing/JDialog/Transparency/TransparencyTest.java
jdk/test/javax/swing/JEditorPane/8146319/JEditorPaneTest.java
jdk/test/javax/swing/JFileChooser/8016665/JFileChooserOrientation.java
jdk/test/javax/swing/JFileChooser/8041694/bug8041694.java
jdk/test/javax/swing/JFileChooser/DeserializedJFileChooser/DeserializedJFileChooserTest.java
jdk/test/javax/swing/JInternalFrame/4769772/TestJInternalFrameIconify.java
jdk/test/javax/swing/JInternalFrame/8069348/bug8069348.java
jdk/test/javax/swing/JInternalFrame/8145896/TestJInternalFrameMaximize.java
jdk/test/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java
jdk/test/javax/swing/JInternalFrame/NormalBoundsTest.java
jdk/test/javax/swing/JMenu/4213634/bug4213634.java
jdk/test/javax/swing/JOptionPane/8139213/OptionPaneTest.java
jdk/test/javax/swing/JPopupMenu/8147521/PopupMenuTest.java
jdk/test/javax/swing/JProgressBar/8015748/JProgressBarOrientationRobotTest.java
jdk/test/javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java
jdk/test/javax/swing/JRootPane/SilenceOfDeprecatedMenuBar/SilenceOfDeprecatedMenuBar.java
jdk/test/javax/swing/JScrollPane/bug8044371.java
jdk/test/javax/swing/JSpinner/6421058/bug6421058.java
jdk/test/javax/swing/JSpinner/WrongEditorTextFieldFont/WrongEditorTextFieldFont.java
jdk/test/javax/swing/JTabbedPane/8017284/bug8017284.java
jdk/test/javax/swing/JTabbedPane/8134116/Bug8134116.java
jdk/test/javax/swing/JTabbedPane/8137169/ScrollableTabbedPaneTest.java
jdk/test/javax/swing/JTable/6894632/bug6894632.java
jdk/test/javax/swing/JTableHeader/4473075/bug4473075.java
jdk/test/javax/swing/JTextArea/8149849/DNDTextToScaledArea.java
jdk/test/javax/swing/JTextPane/bug8025082.java
jdk/test/javax/swing/JToolTip/6219960/bug6219960.java
jdk/test/javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java
jdk/test/javax/swing/LookAndFeel/6897701/JMenuItemsTest.java
jdk/test/javax/swing/LookAndFeel/8146276/NimbusGlueTest.java
jdk/test/javax/swing/plaf/basic/BasicComboPopup/7072653/bug7072653.java
jdk/test/javax/swing/plaf/basic/BasicRootPaneUI/HiddenDefaultButtonTest.java
jdk/test/javax/swing/plaf/basic/BasicTextUI/8001470/bug8001470.java
jdk/test/javax/swing/plaf/synth/8040328/bug8040328.java
jdk/test/javax/swing/plaf/synth/SynthScrollbarThumbPainter/SynthScrollbarThumbPainterTest.java
jdk/test/javax/swing/text/NavigationFilter/8058305/bug8058305.java
jdk/test/javax/swing/text/TableView/I18nLayoutTest.java
jdk/test/javax/swing/text/html/8031109/bug8031109.java
jdk/test/javax/swing/text/rtf/RTFWriteParagraphAlignTest.java

* jdk/test/java/awt/dnd/DisposeFrameOnDragCrash/DisposeFrameOnDragTest.java skipped
The bacported patch JDK-8252470 already introduced the headful keyword.

* add headful keyword for jdk/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.html
At the time the original patch was applied, JDK-8144164 had been already applied. JDK-8144164 integrates MouseClickRequestFocusRaceTest.html and MouseClickRequestFocusRaceTest.java. Therefore, it is preferable to add headful keyword to MouseClickRequestFocusRaceTest.html.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2061043143

From ktakakuri at openjdk.org  Wed Apr 17 14:14:12 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 17 Apr 2024 14:14:12 GMT
Subject: [jdk8u-dev] Integrated: 8159454: [TEST_BUG]
 javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics
 configurations should be limited
In-Reply-To: <9JkNl5f6NIflswSXOTwTexI8lh4G5isxpiUbGDPX4ZA=.f5283fa5-cfea-4723-9856-246da6918036@github.com>
References: <9JkNl5f6NIflswSXOTwTexI8lh4G5isxpiUbGDPX4ZA=.f5283fa5-cfea-4723-9856-246da6918036@github.com>
Message-ID: <lMqP5zh1RGplZgAJYvi3yi6dnRrdMMz63SWdRJtrKQc=.2033199b-45df-43a3-b5bd-d3cabf20c072@github.com>

On Thu, 14 Dec 2023 12:16:03 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> Hi all,
> 
> This is a clean backport of JDK-8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited.
> I have confirmed that bug7123767.java passes by backporting this fix.
> 
> Thank you.

This pull request has now been integrated.

Changeset: 6a096374
Author:    Kazuhisa Takakuri <ktakakuri at openjdk.org>
Committer: Paul Hohensee <phh at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/6a096374a52eddf28fb87c2cfe1778ef6d3be8e9
Stats:     128 lines in 1 file changed: 71 ins; 12 del; 45 mod

8159454: [TEST_BUG] javax/swing/ToolTipManager/7123767/bug7123767.java: number of checked graphics configurations should be limited

Reviewed-by: andrew, serb
Backport-of: 64a2db9060bc9fc81afe451d0b057af57fc10f94

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/405

From gnu.andrew at redhat.com  Thu Apr 18 00:53:47 2024
From: gnu.andrew at redhat.com (Andrew Hughes)
Date: Thu, 18 Apr 2024 01:53:47 +0100
Subject: OpenJDK 8u412 Released
Message-ID: <ZiBvG9WMa9Z8VwYC@hex.discworld.ac.uk>

We are pleased to announce the release of OpenJDK 8u412.

The source tarball is available from:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u412-b08.tar.xz

The tarball is accompanied by a digital signature available at:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u412-b08.tar.xz.sig

This is signed by our Red Hat OpenJDK key (openjdk at redhat.com):

PGP Key: rsa4096/0x92EF8D39DC13168F (hkp://keys.gnupg.net)
Fingerprint = CA5F 11C6 CE22 644D 42C6  AC44 92EF 8D39 DC13 168F

SHA256 checksums:

530f41efa5ad4a5b76aa6160d55c32c45b3dd0bb3103988da32bb5d6c7ffc073  openjdk8u412-b08.tar.xz
3c5feba06fe0949534d4db9dfff113fae9e17ddb755f94b3bfd816779e6eb7e5  openjdk8u412-b08.tar.xz.sig

SHA512 checksums:

1f88b24393abb022a1f6eb9c70594df444797428248bd124715d7eae777e8a360ac2c8dbc3402decd98d138d089617c151d01a0c29c625d76ba6c3e5db02e6ef  openjdk8u412-b08.tar.xz
cf0ee203824cee10d63b288be291506dbbbf37275bca0f835cfc78a3d8643c78fa3893435499ac28e6470a85128b347a5ca12f579f5b4beffe6adf02520a2b64  openjdk8u412-b08.tar.xz.sig

The checksums can be downloaded from:

* https://openjdk-sources.osci.io/openjdk8/openjdk8u412-b08.sha256
* https://openjdk-sources.osci.io/openjdk8/openjdk8u412-b08.sha512

New in release OpenJDK 8u412 (2024-04-16):
===========================================
Live versions of these release notes can be found at:
  * https://bit.ly/openjdk8u412

* CVEs
  - CVE-2024-21011
  - CVE-2024-21085
  - CVE-2024-21068
  - CVE-2024-21094
* Security fixes
  - JDK-8317507, JDK-8325348: C2 compilation fails with "Exceeded _node_regs array"
  - JDK-8318340: Improve RSA key implementations
  - JDK-8319851: Improve exception logging
  - JDK-8322114: Improve Pack 200 handling
  - JDK-8322122: Enhance generation of addresses
* Other changes
  - JDK-8011180: Delete obsolete scripts
  - JDK-8016451: Scary messages emitted by build.tools.generatenimbus.PainterGenerator during build
  - JDK-8021961: setAlwaysOnTop doesn't behave correctly in Linux/Solaris under certain scenarios
  - JDK-8023735: [TESTBUG][macosx] runtime/XCheckJniJsig/XCheckJSig.java fails on MacOS X
  - JDK-8074860: Structured Exception Catcher missing around CreateJavaVM on Windows
  - JDK-8079441: Intermittent failures on Windows with "Unexpected exit from test [exit code: 1080890248]" (0x406d1388)
  - JDK-8155590: Dubious collection management in sun.net.www.http.KeepAliveCache
  - JDK-8168518: rcache interop with krb5-1.15
  - JDK-8183503: Update hotspot tests to allow for unique test classes directory
  - JDK-8186095: upgrade to jtreg 4.2 b08
  - JDK-8186199: [windows] JNI_DestroyJavaVM not covered by SEH
  - JDK-8192931: Regression test java/awt/font/TextLayout/CombiningPerf.java fails
  - JDK-8208655: use JTreg skipped status in hotspot tests
  - JDK-8208701: Fix for JDK-8208655 causes test failures in CI tier1
  - JDK-8208706: compiler/tiered/ConstantGettersTransitionsTest.java fails to compile
  - JDK-8213410: UseCompressedOops requirement check fails fails on 32-bit system
  - JDK-8222323: ChildAlwaysOnTopTest.java fails with "RuntimeException: Failed to unset alwaysOnTop"
  - JDK-8224768: Test ActalisCA.java fails
  - JDK-8251155: HostIdentifier fails to canonicalize hostnames starting with digits
  - JDK-8251551: Use .md filename extension for README
  - JDK-8268678: LetsEncryptCA.java test fails as Let?s Encrypt Authority X3 is retired
  - JDK-8270280: security/infra/java/security/cert/CertPathValidator/certification/LetsEncryptCA.java  OCSP response error
  - JDK-8270517: Add Zero support for LoongArch
  - JDK-8272708: [Test]: Cleanup: test/jdk/security/infra/java/security/cert/CertPathValidator/certification/BuypassCA.java no longer needs ocspEnabled
  - JDK-8276139: TestJpsHostName.java not reliable, better to expand HostIdentifierCreate.java test
  - JDK-8288132: Update test artifacts in QuoVadis CA interop tests
  - JDK-8297955: LDAP CertStore should use LdapName and not String for DNs
  - JDK-8301310: The SendRawSysexMessage test may cause a JVM crash
  - JDK-8308592: Framework for CA interoperability testing
  - JDK-8312126: NullPointerException in CertStore.getCRLs after 8297955
  - JDK-8315042: NPE in PKCS7.parseOldSignedData
  - JDK-8315757: [8u] Add cacerts JTREG tests to GHA tier1 test set
  - JDK-8320713: Bump update version of OpenJDK: 8u412
  - JDK-8321060: [8u] hotspot needs to recognise VS2022
  - JDK-8321408: Add Certainly roots R1 and E1
  - JDK-8322725: (tz) Update Timezone Data to 2023d
  - JDK-8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
  - JDK-8323202: [8u] Remove get_source.sh and hgforest.sh
  - JDK-8323640: [TESTBUG]testMemoryFailCount in jdk/internal/platform/docker/TestDockerMemoryMetrics.java always fail because OOM killed
  - JDK-8324184: Windows VS2010 build failed with "error C2275: 'int64_t'"
  - JDK-8324530: Build error with gcc 10
  - JDK-8325150: (tz) Update Timezone Data to 2024a

Notes on individual issues:
===========================

security-libs/org.ietf.jgss:krb5:

JDK-8168518: rcache interop with krb5-1.15
==========================================
The hash algorithm used in the Kerberos 5 replay cache file (rcache)
has been changed from MD5 to SHA256. This is the same algorithm used
by MIT krb5-1.15 and is interoperable with earlier releases of MIT
krb5.

The MD5 algorithm can still be used by setting the new
jdk.krb5.rcache.useMD5 property to 'true':

java -Djdk.krb5.rcache.useMD5=true ...

This is useful where either the system has a coarse clock and has to
depend on hash values in replay attack detection, or interoperability
with the rcache files in older versions of OpenJDK is required.

client-libs/java.awt:

JDK-8322750: AWT SystemTray API Is Not Supported on Most Linux Desktops
=======================================================================
The java.awt.SystemTray API is used to interact with the system's
desktop taskbar to provide notifications and may include an icon
representing an application. The GNOME desktop's support for taskbar
icons has not worked properly for several years, due to a platform
bug. This bug, in turn, affects the JDK's SystemTray support on GNOME
desktops.

Therefore, in accordance with the SystemTray API specification,
java.awt.SystemTray.isSupported() will now return false on systems
that exhibit this bug, which is assumed to be those running a version
of GNOME Shell below 45.

The impact of this change is likely to be minimal, as users of the
SystemTray API should already be able to handle isSupported()
returning false and the system tray on such platforms has already been
unsupported for a number of years for all applications.

security-libs/java.security:

JDK-8321408: Added Certainly R1 and E1 Root Certificates
========================================================
The following root certificate has been added to the cacerts
truststore:

Name: Certainly
Alias Name: certainlyrootr1
Distinguished Name: CN=Certainly Root R1, O=Certainly, C=US

Name: Certainly
Alias Name: certainlyroote1
Distinguished Name: CN=Certainly Root E1, O=Certainly, C=US

Happy hacking,
-- 
Andrew :)
Pronouns: he / him or they / them
Principal Free Java Software Engineer
OpenJDK Package Owner
Red Hat, Inc. (http://www.redhat.com)

PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222

Please contact via e-mail, not proprietary chat networks
Available on Libera Chat & OFTC IRC networks as gnu_andrew
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 228 bytes
Desc: not available
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240418/83fcdf7b/signature-0001.asc>

From andrew at openjdk.org  Thu Apr 18 00:59:06 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 18 Apr 2024 00:59:06 GMT
Subject: [jdk8u-dev] Integrated: 8258855: Two tests
 sun/security/krb5/auto/ReplayCacheTestProc.java and
 ReplayCacheTestProcWithMD5.java failed on OL8.3
In-Reply-To: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
References: <Sx1aET0J9n6ctH6NtGCAQxKkyteXMYc8zyHEvAfvFjg=.6540665e-2603-47de-a345-884135983a3d@github.com>
Message-ID: <j6ut-mOsDb2HTS4n6IFh5tb4W55rOTJsrRGNONhtO7U=.38b69f74-a336-4e86-bc06-4319dc8f85ad@github.com>

On Tue, 16 Apr 2024 18:33:12 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> In testing `sun/security/krb5/auto/ReplayCacheTestProc.java` following [JDK-8168518](https://bugs.openjdk.org/browse/JDK-8168518), I found both it and `sun/security/krb5/auto/rcache_usemd5.sh` failed on RHEL 8.  This did not seem to be a regression caused by the 8u412 change as it failed on the current release, 8u402.  The failure was further confirmed by @martinuy who found it was due to the newer Kerberos version on RHEL 8, and it passed on Fedora 31.
> 
>  @jerboaa alerted me to [JDK-8258855](https://bugs.openjdk.org/browse/JDK-8258855) and backporting this change to 8u makes the tests pass.
> 
> The code changes apply as is. The headers have to be adjusted slightly to take into account the different DNS options used in 8u.  The change to `test/jdk/sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java` also moves to `jdk/test/sun/security/krb5/auto/rcache_usemd5.sh` on 8u and has to be manually applied. I looked briefly at backporting [JDK-8180569](https://bugs.openjdk.org/browse/JDK-8180569) which refactors these Kerberos shell tests into Java tests, and I think it has merit, but is likely quite involved and requires other test library backports. For now, we can just backport this change as the shell script is different to the one removed by 8180569 with or without this patch applied first.

This pull request has now been integrated.

Changeset: 6b53212e
Author:    Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/6b53212ef78ad50f9eede829c5ff87cadcdb434b
Stats:     46 lines in 2 files changed: 23 ins; 20 del; 3 mod

8258855: Two tests sun/security/krb5/auto/ReplayCacheTestProc.java and ReplayCacheTestProcWithMD5.java failed on OL8.3

Reviewed-by: mbalao, serb
Backport-of: 8d780729c65bbfd19f23004723b8786d52f8310a

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/481

From ktakakuri at openjdk.org  Thu Apr 18 08:52:34 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Thu, 18 Apr 2024 08:52:34 GMT
Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong
 position
Message-ID: <y18TcWDDTjzYVzGMNGQg73umjt78Uy6Zzwdmt13MSrw=.57d61ea3-6ab6-48bf-a66c-a585868897e6@github.com>

This fix includes a fix for JDK-8189687 in JDK9.
JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow

1. Fix to make OpenCandidateWindow reference the correct Window
Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND."


--- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
+++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
@@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
 {
     UINT bits = 1;
     POINT p = {0, 0}; // upper left corner of the client area
-    HWND hWnd = GetHWnd();
+    HWND hWnd = ImmGetHWnd();
     if (!::IsWindowVisible(hWnd)) {
         return;
     }



2. Scaling fixes to enhance JDK-8073320
OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device.


--- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
+++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
@@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
     HWND hTop = GetTopLevelParentForWindow(hWnd);
     ::ClientToScreen(hTop, &p);
+    int sx = ScaleUpX(x) - p.x;
+    int sy = ScaleUpY(y) - p.y;
     if (!m_bitsCandType) {
-        SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y);
+        SetCandidateWindow(m_bitsCandType, sx, sy);
         return;
     }
     for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) {
         if ( m_bitsCandType & bits )
-            SetCandidateWindow(iCandType, x - p.x, y - p.y);
+            SetCandidateWindow(iCandType, sx, sy);
     }
 }


In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window.
Therefore, the candidate window will appear in the correct position with the "1" fix.
Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request.

-------------

Commit messages:
 - Fix 8330561

Changes: https://git.openjdk.org/jdk8u-dev/pull/483/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=483&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8330561
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/483.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/483/head:pull/483

PR: https://git.openjdk.org/jdk8u-dev/pull/483

From ktakakuri at openjdk.org  Thu Apr 18 09:07:58 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Thu, 18 Apr 2024 09:07:58 GMT
Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages
 whose ftp:// links are broken
In-Reply-To: <jMTv1HYrMchzSnzSayjwTg79aevzrphgwJkrtHKh8EY=.9b20ecd3-4dac-40a6-a2e5-6f8f0d5ddf01@github.com>
References: <jMTv1HYrMchzSnzSayjwTg79aevzrphgwJkrtHKh8EY=.9b20ecd3-4dac-40a6-a2e5-6f8f0d5ddf01@github.com>
Message-ID: <DmGzYPjjJNUasBDEhAIKuSvHfOOvr5w_GcI4hAC_dDA=.4f5daeb5-24a1-4ba3-b19f-c590aee68ae3@github.com>

On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> I would like to backport
> 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken.
> There are minor differences regarding DocRoot, but otherwise this is a clean backport.

Could anyone review this backport please?
This is a simple fix, almost a clean backport.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2063387877

From t.glaser at qvest-digital.com  Thu Apr 18 11:06:18 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Thu, 18 Apr 2024 13:06:18 +0200 (CEST)
Subject: OpenJDK 8u412 Released
In-Reply-To: <ZiBvG9WMa9Z8VwYC@hex.discworld.ac.uk>
References: <ZiBvG9WMa9Z8VwYC@hex.discworld.ac.uk>
Message-ID: <91d011ef-2e12-e996-0fd9-90f4c75ca1f5@qvest-digital.com>

Hi developers,

>We are pleased to announce the release of OpenJDK 8u412.

please don?t forget the accompanying repo for armhf:
https://github.com/openjdk/aarch32-port-jdk8u/tags

Thanks,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From duke at openjdk.org  Thu Apr 18 12:23:25 2024
From: duke at openjdk.org (yaqsun)
Date: Thu, 18 Apr 2024 12:23:25 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v3]
In-Reply-To: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
Message-ID: <hMEpNsv1ZF5yjvcjVGOvGOAXusb6kXPRjhRlqvdO-UI=.27ae0827-1023-47fd-b5d9-5834e218a8d0@github.com>

> This backport has modified the following aspects:
> 
> -  there are 53 cases that do not exist: 
> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
> jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button
> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.j...

yaqsun has updated the pull request incrementally with one additional commit since the last revision:

  Backport 34afeced211cd7115e2529b043c1e57dfa1291fe

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/464/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/464/files/5b8b0b82..232db3b3

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=01-02

  Stats: 128 lines in 1 file changed: 70 ins; 12 del; 46 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464

PR: https://git.openjdk.org/jdk8u-dev/pull/464

From duke at openjdk.org  Thu Apr 18 12:42:27 2024
From: duke at openjdk.org (yaqsun)
Date: Thu, 18 Apr 2024 12:42:27 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v4]
In-Reply-To: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
Message-ID: <egsILCEeynTjLwKBZBfLg_4BTLEo9cFvFx4smKNSbGs=.1fa5e246-846e-450d-a2bf-541ec9d93bf0@github.com>

> This backport has modified the following aspects:
> 
> -  there are 53 cases that do not exist: 
> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
> jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button
> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java
> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.j...

yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:

 - Merge branch 'openjdk:master' into backport-8185500
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
 - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe

-------------

Changes: https://git.openjdk.org/jdk8u-dev/pull/464/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=464&range=03
  Stats: 471 lines in 77 files changed: 156 ins; 24 del; 291 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/464.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/464/head:pull/464

PR: https://git.openjdk.org/jdk8u-dev/pull/464

From jlu at openjdk.org  Thu Apr 18 15:51:25 2024
From: jlu at openjdk.org (Justin Lu)
Date: Thu, 18 Apr 2024 15:51:25 GMT
Subject: [jdk8u-ri] RFR: 8330415: Update system property for Java SE
 specification maintenance version
Message-ID: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>

Please review this PR which updates the "java.specification.maintenance.version" system property value from 5 to 6. This corresponds with the Java SE 8 Maintenance Release 6.

-------------

Commit messages:
 - init

Changes: https://git.openjdk.org/jdk8u-ri/pull/14/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-ri&pr=14&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8330415
  Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-ri/pull/14.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-ri.git pull/14/head:pull/14

PR: https://git.openjdk.org/jdk8u-ri/pull/14

From lancea at openjdk.org  Thu Apr 18 15:57:10 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Thu, 18 Apr 2024 15:57:10 GMT
Subject: [jdk8u-ri] RFR: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
References: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
Message-ID: <B_xOlOwo_FfU8IQyBLn8eC5uNfazyoEgY1y6bLH_Svo=.82468866-5b83-4440-ba20-d954537172cc@github.com>

On Thu, 18 Apr 2024 15:44:15 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which updates the "java.specification.maintenance.version" system property value from 5 to 6. This corresponds with the Java SE 8 Maintenance Release 6.

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/14#pullrequestreview-2009297923

From serb at openjdk.org  Thu Apr 18 17:03:09 2024
From: serb at openjdk.org (Sergey Bylokhov)
Date: Thu, 18 Apr 2024 17:03:09 GMT
Subject: [jdk8u-dev] RFR: 8298887: On the latest macOS+XCode the Robot API
 may report wrong colors
In-Reply-To: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com>
References: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com>
Message-ID: <K4JxqL0U9crYg2KS5D8k_vS1rrMiiwFbiz9xSXbI56Q=.95cfda9c-2cc9-468a-964c-96584cf30229@github.com>

On Mon, 26 Feb 2024 20:40:53 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [ceb6793b](https://github.com/openjdk/jdk11u-dev/commit/ceb6793bf3b5855c7c521678b5d99d752800b441) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Sergey Bylokhov on 5 May 2023 and was reviewed by Paul Hohensee.
> 
> This patch is needed to support XCode 14.2+
> 
> Thanks!

keep open

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/457#issuecomment-2064568207

From iris at openjdk.org  Thu Apr 18 17:08:05 2024
From: iris at openjdk.org (Iris Clark)
Date: Thu, 18 Apr 2024 17:08:05 GMT
Subject: [jdk8u-ri] RFR: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
References: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
Message-ID: <mf2OoFw5mbOfrzOHMRrHOgESUiAjeqJnY2SRQ0m4k38=.9fd769de-ccae-478b-ae21-3d9c7c325f25@github.com>

On Thu, 18 Apr 2024 15:44:15 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which updates the "java.specification.maintenance.version" system property value from 5 to 6. This corresponds with the Java SE 8 Maintenance Release 6.

Marked as reviewed by iris (Author).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/14#pullrequestreview-2009445946

From duke at openjdk.org  Fri Apr 19 02:43:02 2024
From: duke at openjdk.org (yaqsun)
Date: Fri, 19 Apr 2024 02:43:02 GMT
Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer
 in java/awt and javax tests. [v4]
In-Reply-To: <egsILCEeynTjLwKBZBfLg_4BTLEo9cFvFx4smKNSbGs=.1fa5e246-846e-450d-a2bf-541ec9d93bf0@github.com>
References: <OzzKaKHgfVsLTTs8LTkigNgghch7rQtSPOcVdh26oq8=.0762214c-2240-464a-9bc1-c077836f7458@github.com>
 <egsILCEeynTjLwKBZBfLg_4BTLEo9cFvFx4smKNSbGs=.1fa5e246-846e-450d-a2bf-541ec9d93bf0@github.com>
Message-ID: <7oyhKbyejE1hFmTXAkP6QKbrjGU_QYbG11pxv8kG1AI=.1310157e-f60a-4491-afa6-283704458546@github.com>

On Thu, 18 Apr 2024 12:42:27 GMT, yaqsun <duke at openjdk.org> wrote:

>> This backport has modified the following aspects:
>> 
>> -  there are 53 cases that do not exist: 
>> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java
>> jdk/test/java/awt/datatransfer/HTMLDataFlavors/HTMLDataFlavorTest.java
>> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java
>> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java
>> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button
>> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java
>> jdk/test/java/awt/Frame/8158918/SetExtendedState.java
>> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java
>> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java
>> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java
>> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java
>> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java
>> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java
>> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java
>> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java
>> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java
>> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java
>> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java
>> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java
>> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java
>> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java
>> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java
>> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java
>> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java
>> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java
>> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java
>> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java
>> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java
>> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java
>> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java
>> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java
>> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIco...
>
> yaqsun has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge branch 'openjdk:master' into backport-8185500
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe
>  - Backport 34afeced211cd7115e2529b043c1e57dfa1291fe

security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca always fail.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2065650503

From duke at openjdk.org  Fri Apr 19 11:23:01 2024
From: duke at openjdk.org (Shruthi)
Date: Fri, 19 Apr 2024 11:23:01 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
Message-ID: <R_FOydEvF2VVMSJcvq8gHqR3Sn8XJUd3bkxLIKRidkw=.0d23d5ea-e432-4e43-9622-5868f77e372a@github.com>

On Mon, 15 Apr 2024 09:48:45 GMT, Shruthi <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f

@naotoj Can you please take a look at this PR

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/480#issuecomment-2066364866

From naoto at openjdk.org  Fri Apr 19 20:48:33 2024
From: naoto at openjdk.org (Naoto Sato)
Date: Fri, 19 Apr 2024 20:48:33 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <R_FOydEvF2VVMSJcvq8gHqR3Sn8XJUd3bkxLIKRidkw=.0d23d5ea-e432-4e43-9622-5868f77e372a@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
 <R_FOydEvF2VVMSJcvq8gHqR3Sn8XJUd3bkxLIKRidkw=.0d23d5ea-e432-4e43-9622-5868f77e372a@github.com>
Message-ID: <3n1MjOS7QXcYhQR8_WnSHV7xLT59J_HWJ_wb06lmq-c=.230b3341-9082-43ab-8605-ff306d0c1605@github.com>

On Fri, 19 Apr 2024 11:20:30 GMT, Shruthi <duke at openjdk.org> wrote:

>> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
>> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
>> 
>> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
>> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f
>
> @naotoj Can you please take a look at this PR

@shruacha1234 Looks like the changeset includes more than the original fix. Also can you please ask someone else who maintains OpenJDK 8u for the 'R'eview? Thank you.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/480#issuecomment-2067262568

From duke at openjdk.org  Fri Apr 19 21:07:04 2024
From: duke at openjdk.org (Robert Toyonaga)
Date: Fri, 19 Apr 2024 21:07:04 GMT
Subject: [jdk8u-dev] RFR: 8326529: JFR: Test for CompilerCompile events fails
 due to time out
Message-ID: <2g8E5z-FlvdvGwg-PduE119bq9bx0g81_cXvwFcAlFw=.4002bf20-9532-4b7e-8400-3f016117ae7a@github.com>

This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8

This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046).

Testing: the updated `jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java` test passes.

-------------

Commit messages:
 - Backport 4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8

Changes: https://git.openjdk.org/jdk8u-dev/pull/484/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=484&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8326529
  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/484.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/484/head:pull/484

PR: https://git.openjdk.org/jdk8u-dev/pull/484

From duke at openjdk.org  Fri Apr 19 22:05:38 2024
From: duke at openjdk.org (Robert Toyonaga)
Date: Fri, 19 Apr 2024 22:05:38 GMT
Subject: [jdk8u-dev] Withdrawn: 8326529: JFR: Test for CompilerCompile events
 fails due to time out
In-Reply-To: <9qnKGxn0ZlHCviXfPXjIp_kSit_CqevGPchIS0xCFmQ=.75de15f7-0a66-4b79-b747-e133be69fbc6@github.com>
References: <9qnKGxn0ZlHCviXfPXjIp_kSit_CqevGPchIS0xCFmQ=.75de15f7-0a66-4b79-b747-e133be69fbc6@github.com>
Message-ID: <k0dvahpXoNa3sLb0TnUNvMuG03pA2GJejCzJvDaVVT4=.b98361a0-9e85-4972-a111-a863c754b32d@github.com>

On Wed, 28 Feb 2024 20:46:29 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8
> 
> This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046).

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/463

From duke at openjdk.org  Mon Apr 22 09:13:56 2024
From: duke at openjdk.org (Shruthi)
Date: Mon, 22 Apr 2024 09:13:56 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
 [v2]
In-Reply-To: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
Message-ID: <EF7JyZDfucOUSIKYUMT16SzaDGRkCUtxOHtE-cn7ENA=.5c6ca1fd-c033-4ec1-a6f5-bec034a9cfda@github.com>

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f

Shruthi has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:

  Backport 1b925183894778acce8aff4c101f67af98f0097f
  
  Signed-off-by: Shruthi.Shruthi1 <Shruthi.Shruthi1 at ibm.com>

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-dev/pull/480/files
  - new: https://git.openjdk.org/jdk8u-dev/pull/480/files/e5ab96ae..82990ffd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=480&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=480&range=00-01

  Stats: 152 lines in 1 file changed: 0 ins; 151 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/480.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/480/head:pull/480

PR: https://git.openjdk.org/jdk8u-dev/pull/480

From duke at openjdk.org  Mon Apr 22 09:13:56 2024
From: duke at openjdk.org (Shruthi)
Date: Mon, 22 Apr 2024 09:13:56 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
References: <rxoc07haLLu3wnaQqgW2fiAsHIBO1vNgcoKWWbJolbw=.8713cda0-cea5-4736-bec6-e907152c1b68@github.com>
Message-ID: <o0AtDVPKxYKbnNOOBBtbsxOyG6KBB3f6E6qM1-V37yg=.8b282753-dd0c-494f-9825-0b6201bcedc9@github.com>

On Mon, 15 Apr 2024 09:48:45 GMT, Shruthi <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834
> Backporting https://github.com/openjdk/jdk/commit/1b925183894778acce8aff4c101f67af98f0097f

@gnu-andrew Can you please review this PR

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/480#issuecomment-2068884455

From duke at openjdk.org  Mon Apr 22 16:44:37 2024
From: duke at openjdk.org (Eirik =?UTF-8?B?w5h2ZXJieQ==?=)
Date: Mon, 22 Apr 2024 16:44:37 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v3]
In-Reply-To: <hGYQOOPCgAmVPaOPHea8Hd-8PNjONUXKO0tJnMjC3fg=.0af938f6-ccfb-42d3-941d-2480bb74ba6b@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <hGYQOOPCgAmVPaOPHea8Hd-8PNjONUXKO0tJnMjC3fg=.0af938f6-ccfb-42d3-941d-2480bb74ba6b@github.com>
Message-ID: <nraprN3hbX8F4bT_55pZvLS3YMApVCtENe-pWidDR5o=.d2691db8-1f9a-43fb-8f61-356df08324a2@github.com>

On Thu, 8 Feb 2024 22:28:29 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge pr/437
>  - Fix indentation
>  - Backport 770c1f65c588f3156f9b70097df752d8059c1038

I'd like to pitch in that this feels (to us) like a serious bug that warrants fixing in 8. I don't know what the criteria for calling something a "performance issue" are, but my gut feeling tells me it falls far short of being classified as "just" that. Our application ground to a complete halt (not just a slowdown) when the client switched on TLS 1.3, and it took us the better part of a day to figure out the root cause and restore service.

My few cents, and a huge thanks to @dhanalla and anyone else working on backporting this fix.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-1976406480

From sgehwolf at openjdk.org  Mon Apr 22 17:36:35 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Mon, 22 Apr 2024 17:36:35 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v5]
In-Reply-To: <KKOn-yl6DYcNAUc1YkzlsddpxHbYz5B0q2aUyvC9pwI=.3df9ece0-82e2-4fe1-975f-39d528fe3485@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <KKOn-yl6DYcNAUc1YkzlsddpxHbYz5B0q2aUyvC9pwI=.3df9ece0-82e2-4fe1-975f-39d528fe3485@github.com>
Message-ID: <NPLuBxVYrIJliL-mKnezBxAhpdRkZevq3PDxsO3OymY=.04103b76-d649-4d19-b3b1-0d3033ffa20e@github.com>

On Tue, 9 Apr 2024 17:07:27 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix white spaces

This looks OK to me, but I'd like for somebody else to give the go-ahead as well.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/409#pullrequestreview-2015423199

From phh at openjdk.org  Mon Apr 22 20:09:30 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Mon, 22 Apr 2024 20:09:30 GMT
Subject: [jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while
 Closing Connections [v5]
In-Reply-To: <KKOn-yl6DYcNAUc1YkzlsddpxHbYz5B0q2aUyvC9pwI=.3df9ece0-82e2-4fe1-975f-39d528fe3485@github.com>
References: <tsr_2xjg4Zur_JQL3UM8naUOqwCw7LjlWND2t6L5lDU=.86699dd2-e3a1-49ae-8ff6-af06db07a3e3@github.com>
 <KKOn-yl6DYcNAUc1YkzlsddpxHbYz5B0q2aUyvC9pwI=.3df9ece0-82e2-4fe1-975f-39d528fe3485@github.com>
Message-ID: <nHehPvC9xw6luHpHwWERb4Ze5P19kztievVzYqU0SHE=.a30a3738-1dd9-4b6c-8139-9330ee42bce2@github.com>

On Tue, 9 Apr 2024 17:07:27 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix white spaces

Lgtm. The only real difference from the 11u backport looks to be the keepAliveTimer thread creation code.

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/409#pullrequestreview-2015712659

From jwtang at openjdk.org  Tue Apr 23 06:48:55 2024
From: jwtang at openjdk.org (Jiawei Tang)
Date: Tue, 23 Apr 2024 06:48:55 GMT
Subject: [jdk8u-dev] RFR: 8276125: RunThese24H.java SIGSEGV in
 JfrThreadGroup::thread_group_id
Message-ID: <emfLbU8cFQunkxfJHNu3XY1mUZQkzmkoBP2aOxGqfdY=.307c4ead-6984-4e32-99b3-ea27ed536208@github.com>

Hi all,

This pull request contains a backport of commit [a4a5c7fe](https://github.com/openjdk/jdk11u-dev/commit/a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.

The commit being backported was authored by Jiawei Tang on 4 Mar 2024 and was reviewed by Markus Gr?nlund.

Thanks!

-------------

Commit messages:
 - Backport a4a5c7fe66679ce4d9022443e3cd1f9ec38059ac

Changes: https://git.openjdk.org/jdk8u-dev/pull/485/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=485&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8276125
  Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/485.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/485/head:pull/485

PR: https://git.openjdk.org/jdk8u-dev/pull/485

From jwtang at openjdk.org  Tue Apr 23 06:51:44 2024
From: jwtang at openjdk.org (Jiawei Tang)
Date: Tue, 23 Apr 2024 06:51:44 GMT
Subject: [jdk8u-dev] RFR: 8322511: [11u] JfrCheckpointThreadClosure::do_thread
 crashes when fetching thread_id
Message-ID: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>

Hi all,

This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.

The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.

Thanks!

-------------

Commit messages:
 - Backport 29f300eb2ac4c038fad7f8e09eab8a53b69526c6

Changes: https://git.openjdk.org/jdk8u-dev/pull/486/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=486&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8322511
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/486.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/486/head:pull/486

PR: https://git.openjdk.org/jdk8u-dev/pull/486

From ktakakuri at openjdk.org  Tue Apr 23 11:29:36 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Tue, 23 Apr 2024 11:29:36 GMT
Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, 
 because of new tabbing behaviour of radio button groups. [v3]
In-Reply-To: <N8hboJKI-EVM4NO2TWvRrqezuseCfSOObL9t6W9iZE4=.7a0c7ef3-b84b-4fc3-b602-a21dbdee13b0@github.com>
References: <uS3pR-oynm7HF88V25wPugtA6mhPhDMLeLaQ-V2aWVA=.5a3ec1fe-7f63-4ce2-80c9-cd145022d928@github.com>
 <VgtgJOE9vekLz5_K4-3Q5UOjr58GNR8NPjdmwsbKUCk=.8644d611-52d9-4662-94ca-1b13330e3908@github.com>
 <N8hboJKI-EVM4NO2TWvRrqezuseCfSOObL9t6W9iZE4=.7a0c7ef3-b84b-4fc3-b602-a21dbdee13b0@github.com>
Message-ID: <M3B6C6lSlBlqt8JPvD9GcQ9WRAB6oLZOp4no-wG-RmA=.0a74e1dc-9702-43c0-bb3b-1629b29d1e35@github.com>

On Thu, 7 Sep 2023 22:04:06 GMT, Paul Hohensee <phh at openjdk.org> wrote:

>> Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix the copyright years
>
> Marked as reviewed by phh (Reviewer).

@phohensee 
Is it OK to request a fix request?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2072051870

From afarley at openjdk.org  Tue Apr 23 13:06:45 2024
From: afarley at openjdk.org (Adam Farley)
Date: Tue, 23 Apr 2024 13:06:45 GMT
Subject: [jdk8u-dev] RFR: 8330973: To increase deopt variance tolerance for
 Test8009761
Message-ID: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>

In certain environments, the deopt count is known to vary by 1, as noted in JDK-8021775.

This is a backport for a portion of that fix, to allow this tolerance in JDK8's version of the test while not requiring the full body of the original fix.

https://bugs.openjdk.org/browse/JDK-8330973

-------------

Commit messages:
 - 8330973: To increase deopt variance tolerance for Test8009761

Changes: https://git.openjdk.org/jdk8u-dev/pull/487/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=487&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8330973
  Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/487.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/487/head:pull/487

PR: https://git.openjdk.org/jdk8u-dev/pull/487

From sgehwolf at openjdk.org  Tue Apr 23 13:30:36 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 23 Apr 2024 13:30:36 GMT
Subject: [jdk8u-dev] RFR: 8330973: To increase deopt variance tolerance for
 Test8009761
In-Reply-To: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>
References: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>
Message-ID: <VXufBptnbOw2ZDOP4GEaxVbPFbEdLZIrarwzwV76mRU=.8c5e2e3b-9403-4c81-a544-1527ae67e319@github.com>

On Tue, 23 Apr 2024 13:02:30 GMT, Adam Farley <afarley at openjdk.org> wrote:

> In certain environments, the deopt count is known to vary by 1, as noted in JDK-8021775.
> 
> This is a backport for a portion of that fix, to allow this tolerance in JDK8's version of the test while not requiring the full body of the original fix.
> 
> https://bugs.openjdk.org/browse/JDK-8330973

I think we should try backporting the test-only fix itself: JDK-8021775

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/487#issuecomment-2072325451

From afarley at openjdk.org  Tue Apr 23 14:54:32 2024
From: afarley at openjdk.org (Adam Farley)
Date: Tue, 23 Apr 2024 14:54:32 GMT
Subject: [jdk8u-dev] RFR: 8330973: Test8009761 fails on ppcle_linux: init
 recursive calls: 38. After deopt 37
In-Reply-To: <VXufBptnbOw2ZDOP4GEaxVbPFbEdLZIrarwzwV76mRU=.8c5e2e3b-9403-4c81-a544-1527ae67e319@github.com>
References: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>
 <VXufBptnbOw2ZDOP4GEaxVbPFbEdLZIrarwzwV76mRU=.8c5e2e3b-9403-4c81-a544-1527ae67e319@github.com>
Message-ID: <x06wNbXi1K_jhEsHF5LnKpKebO-P4lUBqwJ2ml1AKrs=.37e36821-8a13-418e-be4a-da1175e251c3@github.com>

On Tue, 23 Apr 2024 13:27:59 GMT, Severin Gehwolf <sgehwolf at openjdk.org> wrote:

> I think we should try backporting the test-only fix itself: JDK-8021775

I don't mind. Will see if that fix merges cleanly with the current version of the JDK8 test.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/487#issuecomment-2072562068

From phh at openjdk.org  Tue Apr 23 16:41:34 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 23 Apr 2024 16:41:34 GMT
Subject: [jdk8u-dev] RFR: 8322511: [11u]
 JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id
In-Reply-To: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
References: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
Message-ID: <mYY8is1gzUJaboaOnE0HtCOYKOq8Hu9-JezvL6ewlN0=.96cb51b7-11b0-40d2-ac75-170c6293e40e@github.com>

On Tue, 23 Apr 2024 06:46:24 GMT, Jiawei Tang <jwtang at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.
> 
> Thanks!

Only file location differs.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/486#issuecomment-2072893486

From phh at openjdk.org  Tue Apr 23 16:45:30 2024
From: phh at openjdk.org (Paul Hohensee)
Date: Tue, 23 Apr 2024 16:45:30 GMT
Subject: [jdk8u-dev] RFR: 8322511: [11u]
 JfrCheckpointThreadClosure::do_thread crashes when fetching thread_id
In-Reply-To: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
References: <td3LcSZ7QRoMIH89iKNLCsRvCJD_yzSN8Pz296M-PFk=.2a9aa45d-eafa-4572-95b1-90bb7085a488@github.com>
Message-ID: <g8OgQSCD6cBIAlXV-L-63W8eRvh0ME7SG_mQ_LFi7ZI=.1e495233-2da4-4302-a979-a6145db4eddc@github.com>

On Tue, 23 Apr 2024 06:46:24 GMT, Jiawei Tang <jwtang at openjdk.org> wrote:

> Hi all,
> 
> This pull request contains a backport of commit [29f300eb](https://github.com/openjdk/jdk11u-dev/commit/29f300eb2ac4c038fad7f8e09eab8a53b69526c6) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository.
> 
> The commit being backported was authored by Jiawei Tang on 11 Mar 2024 and was reviewed by Paul Hohensee.
> 
> Thanks!

Many GHA infra issues, plus what seem to be unrelated test failures.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/486#issuecomment-2072899494

From afarley at openjdk.org  Wed Apr 24 08:22:36 2024
From: afarley at openjdk.org (Adam Farley)
Date: Wed, 24 Apr 2024 08:22:36 GMT
Subject: [jdk8u-dev] RFR: 8330973: Test8009761 fails on ppcle_linux: init
 recursive calls: 38. After deopt 37
In-Reply-To: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>
References: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>
Message-ID: <lIEttOh3IhFxZYpqOszJcOb7qps6Zynb31vtu7P26v4=.60816f92-b412-4e9a-b1b4-5ed54f85db81@github.com>

On Tue, 23 Apr 2024 13:02:30 GMT, Adam Farley <afarley at openjdk.org> wrote:

> In certain environments, the deopt count is known to vary by 1, as noted in JDK-8021775.
> 
> This is a backport for a portion of that fix, to allow this tolerance in JDK8's version of the test while not requiring the full body of the original fix.
> 
> https://bugs.openjdk.org/browse/JDK-8330973

Closing this as it's cleaner to have the automated system open a new PR with the backported change.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/487#issuecomment-2074367199

From afarley at openjdk.org  Wed Apr 24 08:22:36 2024
From: afarley at openjdk.org (Adam Farley)
Date: Wed, 24 Apr 2024 08:22:36 GMT
Subject: [jdk8u-dev] Withdrawn: 8330973: Test8009761 fails on ppcle_linux: init
 recursive calls: 38. After deopt 37
In-Reply-To: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>
References: <jixfWiluO1cAmqVjt1JEZ_dzshY5k6KGkauf_NCSDDk=.6074d4c9-7eee-47b4-9bc5-a55db6468fc0@github.com>
Message-ID: <VCrTeZ7l3p1VvXZiIiQUBQGrrrGv4zuReaB04_6zaLs=.21e20f45-1d40-4dbe-9f65-0f1c8a4d5156@github.com>

On Tue, 23 Apr 2024 13:02:30 GMT, Adam Farley <afarley at openjdk.org> wrote:

> In certain environments, the deopt count is known to vary by 1, as noted in JDK-8021775.
> 
> This is a backport for a portion of that fix, to allow this tolerance in JDK8's version of the test while not requiring the full body of the original fix.
> 
> https://bugs.openjdk.org/browse/JDK-8330973

This pull request has been closed without being integrated.

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/487

From ktakakuri at openjdk.org  Wed Apr 24 13:52:43 2024
From: ktakakuri at openjdk.org (Kazuhisa Takakuri)
Date: Wed, 24 Apr 2024 13:52:43 GMT
Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong
 position
In-Reply-To: <y18TcWDDTjzYVzGMNGQg73umjt78Uy6Zzwdmt13MSrw=.57d61ea3-6ab6-48bf-a66c-a585868897e6@github.com>
References: <y18TcWDDTjzYVzGMNGQg73umjt78Uy6Zzwdmt13MSrw=.57d61ea3-6ab6-48bf-a66c-a585868897e6@github.com>
Message-ID: <B86qEtnX14G_KzhSdCAyuahVyqgg0iv3UquE_qkiKO0=.b835a20a-bc28-48cc-8a76-af2f8d222619@github.com>

On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

> This fix includes a fix for JDK-8189687 in JDK9.
> JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow
> 
> 1. Fix to make OpenCandidateWindow reference the correct Window
> Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND."
> 
> 
> --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
>  {
>      UINT bits = 1;
>      POINT p = {0, 0}; // upper left corner of the client area
> -    HWND hWnd = GetHWnd();
> +    HWND hWnd = ImmGetHWnd();
>      if (!::IsWindowVisible(hWnd)) {
>          return;
>      }
> 
> 
> 
> 2. Scaling fixes to enhance JDK-8073320
> OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device.
> 
> 
> --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
> @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y)
>      HWND hTop = GetTopLevelParentForWindow(hWnd);
>      ::ClientToScreen(hTop, &p);
> +    int sx = ScaleUpX(x) - p.x;
> +    int sy = ScaleUpY(y) - p.y;
>      if (!m_bitsCandType) {
> -        SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y);
> +        SetCandidateWindow(m_bitsCandType, sx, sy);
>          return;
>      }
>      for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) {
>          if ( m_bitsCandType & bits )
> -            SetCandidateWindow(iCandType, x - p.x, y - p.y);
> +            SetCandidateWindow(iCandType, sx, sy);
>      }
>  }
> 
> 
> In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window.
> Therefore, the candidate window will appear in the correct position with the "1" fix.
> Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request.

The following jtreg test failed on Windows x64/x86:
security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#certignarootca.
This is a test on certificates and is not related to the awt affected by this fix. Therefore, this error is not a defect caused by this fix. Some error occurred on Linux and Mac, but since this is a WIndows-only fix, it is irrelevant.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/483#issuecomment-2075000406

From azvegint at openjdk.org  Wed Apr 24 18:24:48 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Wed, 24 Apr 2024 18:24:48 GMT
Subject: [jdk8u-ri] RFR: 8307779: Relax the java.awt.Robot specification
Message-ID: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>

Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809.

It is backport of the original commit + build failure fix. 

8u  does not have the changes related to the to the missing `createMultiResolutionScreenCapture` method.

CSR: [JDK-8331038](https://bugs.openjdk.org/browse/JDK-8331038)

-------------

Commit messages:
 - Backport 02dc95e6b99e5998b028e90c3fe9c64ad9f47d9e
 - Backport 21aa057fafd88f4dd677bbf7c99a7eabb6b18409

Changes: https://git.openjdk.org/jdk8u-ri/pull/15/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-ri&pr=15&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8307779
  Stats: 74 lines in 1 file changed: 69 ins; 0 del; 5 mod
  Patch: https://git.openjdk.org/jdk8u-ri/pull/15.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-ri.git pull/15/head:pull/15

PR: https://git.openjdk.org/jdk8u-ri/pull/15

From azvegint at openjdk.org  Thu Apr 25 07:43:49 2024
From: azvegint at openjdk.org (Alexander Zvegintsev)
Date: Thu, 25 Apr 2024 07:43:49 GMT
Subject: [jdk8u-ri] RFR: 8307779: Relax the java.awt.Robot specification
 [v2]
In-Reply-To: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
References: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
Message-ID: <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>

> Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809.
> 
> It is backport of the original commit + build failure fix. 
> 
> 8u  does not have the changes related to the to the missing `createMultiResolutionScreenCapture` method.
> 
> CSR: [JDK-8331038](https://bugs.openjdk.org/browse/JDK-8331038)

Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:

  Backport 56064c7e5c0b5e5f0a59d87e7c5889bb782a7b70

-------------

Changes:
  - all: https://git.openjdk.org/jdk8u-ri/pull/15/files
  - new: https://git.openjdk.org/jdk8u-ri/pull/15/files/98f071f1..12c879ad

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk8u-ri&pr=15&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk8u-ri&pr=15&range=00-01

  Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/jdk8u-ri/pull/15.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-ri.git pull/15/head:pull/15

PR: https://git.openjdk.org/jdk8u-ri/pull/15

From prr at openjdk.org  Thu Apr 25 18:01:42 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 25 Apr 2024 18:01:42 GMT
Subject: [jdk8u-ri] RFR: 8307779: Relax the java.awt.Robot specification
 [v2]
In-Reply-To: <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
References: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
 <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
Message-ID: <n4Z9bLXXlLlXZi8V3LsYvtIAYgi_T-lbKsKxrdgLdis=.e2f21489-f921-4348-b7f8-be276bc0d268@github.com>

On Thu, 25 Apr 2024 07:43:49 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809.
>> 
>> It is backport of the original commit + build failure fix. 
>> 
>> 8u  does not have the changes related to the to the missing `createMultiResolutionScreenCapture` method.
>> 
>> CSR: [JDK-8331038](https://bugs.openjdk.org/browse/JDK-8331038)
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 56064c7e5c0b5e5f0a59d87e7c5889bb782a7b70

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/15#pullrequestreview-2023221020

From erikj at openjdk.org  Thu Apr 25 18:40:08 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Thu, 25 Apr 2024 18:40:08 GMT
Subject: [jdk8u-ri] RFR: 8331152: Update .jcheck/conf for 8u44
Message-ID: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>

The version number in .jcheck/conf needs to be updated for the new 8u44 release.

-------------

Commit messages:
 - JDK-8331152

Changes: https://git.openjdk.org/jdk8u-ri/pull/16/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-ri&pr=16&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8331152
  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk8u-ri/pull/16.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-ri.git pull/16/head:pull/16

PR: https://git.openjdk.org/jdk8u-ri/pull/16

From iris at openjdk.org  Thu Apr 25 18:40:08 2024
From: iris at openjdk.org (Iris Clark)
Date: Thu, 25 Apr 2024 18:40:08 GMT
Subject: [jdk8u-ri] RFR: 8331152: Update .jcheck/conf for 8u44
In-Reply-To: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
References: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
Message-ID: <VnDuxihRQH0DCiiBCGhTStT6Rwd_rce0NwZzSGshp6o=.9958387f-b197-4292-b285-3f9a942e9699@github.com>

On Thu, 25 Apr 2024 18:34:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The version number in .jcheck/conf needs to be updated for the new 8u44 release.

Marked as reviewed by iris (Author).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/16#pullrequestreview-2023312558

From lancea at openjdk.org  Thu Apr 25 18:40:08 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Thu, 25 Apr 2024 18:40:08 GMT
Subject: [jdk8u-ri] RFR: 8331152: Update .jcheck/conf for 8u44
In-Reply-To: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
References: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
Message-ID: <-cIfatbSg2ZuU2jWaQFxRiXQyd9LiYb8AoE-okVKtn8=.21393ee7-d6a9-4acf-b746-bd1d0e303338@github.com>

On Thu, 25 Apr 2024 18:34:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The version number in .jcheck/conf needs to be updated for the new 8u44 release.

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/16#pullrequestreview-2023312643

From prr at openjdk.org  Thu Apr 25 19:27:40 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 25 Apr 2024 19:27:40 GMT
Subject: [jdk8u-ri] RFR: 8331152: Update .jcheck/conf for 8u44
In-Reply-To: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
References: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
Message-ID: <fcoZFadyupag0wA5-IyivnGcG_gxmKPDD-xErhasPUY=.cf15ef27-77ea-44c9-a949-46085f081f74@github.com>

On Thu, 25 Apr 2024 18:34:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The version number in .jcheck/conf needs to be updated for the new 8u44 release.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/16#pullrequestreview-2023407125

From mullan at openjdk.org  Thu Apr 25 20:33:35 2024
From: mullan at openjdk.org (Sean Mullan)
Date: Thu, 25 Apr 2024 20:33:35 GMT
Subject: [jdk8u-ri] RFR: 8331152: Update .jcheck/conf for 8u44
In-Reply-To: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
References: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
Message-ID: <M7LrjIaqPN1ZTNkjPLLVcxvWAoWGazN5qxjpfkwaXX8=.dadeec60-6316-423c-9e8d-9459a2cb8251@github.com>

On Thu, 25 Apr 2024 18:34:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The version number in .jcheck/conf needs to be updated for the new 8u44 release.

Marked as reviewed by mullan (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/16#pullrequestreview-2023521117

From iris at openjdk.org  Thu Apr 25 20:48:36 2024
From: iris at openjdk.org (Iris Clark)
Date: Thu, 25 Apr 2024 20:48:36 GMT
Subject: [jdk8u-ri] RFR: 8307779: Relax the java.awt.Robot specification
 [v2]
In-Reply-To: <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
References: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
 <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
Message-ID: <sz5UnK7Ts61DbQwzLDC1ChBWneb3WZYUl1uuUY4PErE=.df5be8f5-0924-4e2f-b23d-8a39343e2fd0@github.com>

On Thu, 25 Apr 2024 07:43:49 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809.
>> 
>> It is backport of the original commit + build failure fix. 
>> 
>> 8u  does not have the changes related to the to the missing `createMultiResolutionScreenCapture` method.
>> 
>> CSR: [JDK-8331038](https://bugs.openjdk.org/browse/JDK-8331038)
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 56064c7e5c0b5e5f0a59d87e7c5889bb782a7b70

Spec and implementation changes as expected for 8u44.

Associated CSR (JDK-8331038 already Approved.

-------------

Marked as reviewed by iris (Author).

PR Review: https://git.openjdk.org/jdk8u-ri/pull/15#pullrequestreview-2023548629

From lancea at openjdk.org  Thu Apr 25 20:59:36 2024
From: lancea at openjdk.org (Lance Andersen)
Date: Thu, 25 Apr 2024 20:59:36 GMT
Subject: [jdk8u-ri] RFR: 8307779: Relax the java.awt.Robot specification
 [v2]
In-Reply-To: <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
References: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
 <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
Message-ID: <dc4e7QPkTvq0nwhWlMcx6jZaxkgFGS8Q1Xj7j060iiQ=.b05decd5-6171-48e3-8915-9cb959196fcc@github.com>

On Thu, 25 Apr 2024 07:43:49 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809.
>> 
>> It is backport of the original commit + build failure fix. 
>> 
>> 8u  does not have the changes related to the to the missing `createMultiResolutionScreenCapture` method.
>> 
>> CSR: [JDK-8331038](https://bugs.openjdk.org/browse/JDK-8331038)
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 56064c7e5c0b5e5f0a59d87e7c5889bb782a7b70

Marked as reviewed by lancea (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/15#pullrequestreview-2023567106

From prr at openjdk.org  Thu Apr 25 21:00:35 2024
From: prr at openjdk.org (Phil Race)
Date: Thu, 25 Apr 2024 21:00:35 GMT
Subject: [jdk8u-ri] RFR: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
References: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
Message-ID: <yevGHKqqoeRetnV5EMgAu_UMTVRcM-5SvyTuGfvhJh8=.098a525f-8c3d-4c38-ad62-7bc42533889d@github.com>

On Thu, 18 Apr 2024 15:44:15 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which updates the "java.specification.maintenance.version" system property value from 5 to 6. This corresponds with the Java SE 8 Maintenance Release 6.

Marked as reviewed by prr (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk8u-ri/pull/14#pullrequestreview-2023568991

From andrew at openjdk.org  Thu Apr 25 22:34:38 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 25 Apr 2024 22:34:38 GMT
Subject: [jdk8u-ri] RFR: 8331152: Update .jcheck/conf for 8u44
In-Reply-To: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
References: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
Message-ID: <xb7P_UdIOpRqBebG2W-jp5mmkTMxjVDEPjhPKKxb5to=.ed465fd7-f538-411f-a4a3-31973772aef0@github.com>

On Thu, 25 Apr 2024 18:34:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The version number in .jcheck/conf needs to be updated for the new 8u44 release.

Looks correct.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-ri/pull/16#pullrequestreview-2023707469

From andrew at openjdk.org  Thu Apr 25 23:21:48 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 25 Apr 2024 23:21:48 GMT
Subject: [jdk8u-ri] RFR: 8307779: Relax the java.awt.Robot specification
 [v2]
In-Reply-To: <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
References: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
 <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
Message-ID: <A4s54ioCuPsb-OucBGQzVQuSHvokY_anixm3dLt1YIk=.4c613f10-1d1d-4eba-bc09-36dfe75579c8@github.com>

On Thu, 25 Apr 2024 07:43:49 GMT, Alexander Zvegintsev <azvegint at openjdk.org> wrote:

>> Please review the doc only backport PR of https://github.com/openjdk/jdk/pull/13809.
>> 
>> It is backport of the original commit + build failure fix. 
>> 
>> 8u  does not have the changes related to the to the missing `createMultiResolutionScreenCapture` method.
>> 
>> CSR: [JDK-8331038](https://bugs.openjdk.org/browse/JDK-8331038)
>
> Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Backport 56064c7e5c0b5e5f0a59d87e7c5889bb782a7b70

Change looks good, adapting for older copyright and context, and the lack of `createMultiResolutionScreenCapture`
Again, as with 17u, not sure if we should mention JDK-8308370 or not. We usually would for a regular 8u backport.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-ri/pull/15#pullrequestreview-2023761903

From andrew at openjdk.org  Thu Apr 25 23:24:42 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Thu, 25 Apr 2024 23:24:42 GMT
Subject: [jdk8u-ri] RFR: 8330415: Update system property for Java SE
 specification maintenance version
In-Reply-To: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
References: <sHKS_KJkiEs8yJiVJYiBCrlkaBolJKoNUzBR2T8x-rk=.e34dcf9e-bd9b-4690-a4c7-58b4d7aac4e2@github.com>
Message-ID: <iRUtVhcmuqzuUe2fnFzaa8tsJpwo9v6goBibbJoEG7E=.3994f1ec-9a81-4e78-9277-adcf12581e4a@github.com>

On Thu, 18 Apr 2024 15:44:15 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which updates the "java.specification.maintenance.version" system property value from 5 to 6. This corresponds with the Java SE 8 Maintenance Release 6.

Looks good.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-ri/pull/14#pullrequestreview-2023764005

From andrew at openjdk.org  Fri Apr 26 00:19:39 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 26 Apr 2024 00:19:39 GMT
Subject: [jdk8u-ri] RFR: 8307779: Relax the java.awt.Robot specification
 [v2]
In-Reply-To: <A4s54ioCuPsb-OucBGQzVQuSHvokY_anixm3dLt1YIk=.4c613f10-1d1d-4eba-bc09-36dfe75579c8@github.com>
References: <HkelCnodBHijih-cOmYH7CnmzUhO9WDJZqn1tVysK04=.3df5df44-5249-4ef2-be69-b0da50449a0e@github.com>
 <QhLsqcyXC0cjjz4cwl2rMsNbRubdOH7s0t0fo1V7rAk=.7099968e-433e-472b-9932-48628983a6f5@github.com>
 <A4s54ioCuPsb-OucBGQzVQuSHvokY_anixm3dLt1YIk=.4c613f10-1d1d-4eba-bc09-36dfe75579c8@github.com>
Message-ID: <cPRf9fN1ephW8wTrgDG7Z5pOZ6N0Jd--JMXTNoxTGBw=.fa3a5e16-bc76-4c7e-8561-8930bdb335f7@github.com>

On Thu, 25 Apr 2024 23:18:48 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> Change looks good, adapting for older copyright and context, and the lack of `createMultiResolutionScreenCapture` Again, as with 17u, not sure if we should mention JDK-8308370 or not. We usually would for a regular 8u backport.

8u also adds `checkScreenCaptureAllowed` as 11u does. I missed this earlier due to the documentation differences between 17 & 8.

-------------

PR Comment: https://git.openjdk.org/jdk8u-ri/pull/15#issuecomment-2078377535

From andrew at openjdk.org  Fri Apr 26 00:59:37 2024
From: andrew at openjdk.org (Andrew John Hughes)
Date: Fri, 26 Apr 2024 00:59:37 GMT
Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64
 zip files
In-Reply-To: <6IKwO2Ssx8gGJrhogkTHuuvGmOSx8rcll59NAvyIOC0=.fc70c5ae-0701-40e8-bbb3-855b26497999@github.com>
References: <vPlcutUN7j5bN_2y5oW6Imut80ENRm0pCSnxTtqlD20=.ccd90066-21b1-4e64-b242-72abf3e308c8@github.com>
 <6IKwO2Ssx8gGJrhogkTHuuvGmOSx8rcll59NAvyIOC0=.fc70c5ae-0701-40e8-bbb3-855b26497999@github.com>
Message-ID: <FQpdvH8kpW_XNuAlX0lgxHbLxkaIOh644avwcX-0bVg=.99bc1e82-b93a-4aa7-b90d-75195c22c71c@github.com>

On Mon, 8 Apr 2024 16:09:30 GMT, fitzsim <duke at openjdk.org> wrote:

>> This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same.
>> 
>> What follows is Thomas' introduction from the original PR:
>> 
>> This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years.
>> 
>> I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception:
>> 
>> ~~~
>> java.lang.RuntimeException: zipfile: zip64 end failed
>> 	at ReadZip.main(ReadZip.java:209)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> 	at java.lang.reflect.Method.invoke(Method.java:498)
>> 	at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
>> 	at java.lang.Thread.run(Thread.java:750)
>> ~~~
>> 
>> With the fix applied the test passes:
>> 
>> ~~~
>> Passed: java/util/zip/ZipFile/ReadZip.java
>> ~~~
>> 
>> With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with:
>> ~~~
>> Test results: passed: 3,122
>> ~~~
>> I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed.
>> 
>> Thank you,
>> Thomas
>
> Here is some public discussion: https://bugzilla.redhat.com/show_bug.cgi?id=1433262#c21 and https://bugzilla.redhat.com/show_bug.cgi?id=1433262#c22

> @fitzsim Yes, please remove the `zip_util.c` changes. Then we can proceed with reviewing. Different question: Is there a reason why you didn't submit this PR for review?

If you remove the `zip_util.c` changes, you remove the core of the fix. The `zip_util.c` changes are equivalent to the `ZipFile.java` in the 9+ version of this patch. 8u does not have [JDK-8145260](https://bugs.openjdk.org/browse/JDK-8145260): "To bring j.u.z.ZipFile's native implementation to Java to remove the expensive jni cost and mmap crash risk" and this is not a suitable candidate for backport to a stable release.

The test and zipfs changes are the same. The reason I didn't upstream this at the time of development was I was unsure that the test was adequately testing the changes, particularly the ZipFileSystem ones. In 9+, the ZipFileSystem is part of the JDK, thanks to [JDK-8038500](https://bugs.openjdk.org/browse/JDK-8038500): "(zipfs) Upgrade ZIP provider to be a supported provider" and so I presume is tested by the `FileSystem fs = FileSystems.newFileSystem(uri, Map.of())` code in a way it isn't when it's demo code.

Thomas kindly agreed to verify the tests and upstream the patch. I think the 'clean patch' confusion arose from the RPM patch applying cleanly, not the 11u version.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2078410441

From erikj at openjdk.org  Fri Apr 26 14:02:06 2024
From: erikj at openjdk.org (Erik Joelsson)
Date: Fri, 26 Apr 2024 14:02:06 GMT
Subject: [jdk8u-ri] Integrated: 8331152: Update .jcheck/conf for 8u44
In-Reply-To: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
References: <Paj97YkFzTTdpd4BtdaG7h6dYy4YaxiEHgLTbSTQWHc=.f58b1798-19ea-4d75-a2e4-1810599eaa3a@github.com>
Message-ID: <0jpJsYfF-2VHU8SoF0moFrHfWzDD_62e_UVJm7X-TZ0=.425c6566-69cc-4d4e-b3cc-9ab6e0017342@github.com>

On Thu, 25 Apr 2024 18:34:19 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> The version number in .jcheck/conf needs to be updated for the new 8u44 release.

This pull request has now been integrated.

Changeset: dde7fde1
Author:    Erik Joelsson <erikj at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-ri/commit/dde7fde1fe6aa27594efbfe4f9155d6939ffacef
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8331152: Update .jcheck/conf for 8u44

Reviewed-by: iris, lancea, prr, mullan, andrew

-------------

PR: https://git.openjdk.org/jdk8u-ri/pull/16

From t.glaser at qvest-digital.com  Fri Apr 26 15:01:43 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Fri, 26 Apr 2024 17:01:43 +0200 (CEST)
Subject: 8u412-ga build error on loong64
Message-ID: <7f215cb1-d8ad-f29a-099b-7efb1f1966bb@qvest-digital.com>

/<<PKGBUILDDIR>>/src/hotspot/src/os/linux/vm/os_linux.cpp: In static member function 'static void* os::dll_load(c
onst char*, char*, int)':
/<<PKGBUILDDIR>>/src/hotspot/src/os/linux/vm/os_linux.cpp:2041:9: error: 'running_arch_code' was not declared in
this scope; did you mean 'running_arch_index'?
 2041 |     if (running_arch_code == arch_array[i].code) {
      |         ^~~~~~~~~~~~~~~~~
      |         running_arch_index

This is probably from?

   #elif  (defined LOONGARCH)
     static  Elf32_Half running_arch_code=EM_LOONGARCH;

? not triggering. An earlier version of that patch had?

+  #elif  (defined LOONGARCH64)
+    static  Elf32_Half running_arch_code=EM_LOONGARCH;

? there, notice the difference in the architecture definition,
which (looking at other places) seems to be the correct one.

bye,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From duke at openjdk.org  Sun Apr 28 06:34:26 2024
From: duke at openjdk.org (yaqsun)
Date: Sun, 28 Apr 2024 06:34:26 GMT
Subject: [jdk8u-dev] RFR: 8222299: [TESTBUG] move hotspot container tests to
 hotspot/containers
Message-ID: <7l16zKtEYlqbUdRXuxhHUMB6cjsRwfZw7p1Bm7kTzck=.493954ea-bf01-4dae-bd81-8e7af0c798c9@github.com>

This is a backport of JDK-8222299: [TESTBUG] move hotspot container tests to hotspot/container.

This patch has already been applied to OracleJDK8.

This backport has resolved the conflict about hotspot/test/TEST.groups. doc/testing.html and doc/testing.md do not exist in 8u.

-------------

Commit messages:
 - Backport 66c817134fa012d53128eecfc1bac0c32c678145

Changes: https://git.openjdk.org/jdk8u-dev/pull/488/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=488&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8222299
  Stats: 16 lines in 16 files changed: 14 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/488.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/488/head:pull/488

PR: https://git.openjdk.org/jdk8u-dev/pull/488

From lzhai at openjdk.org  Sun Apr 28 06:53:30 2024
From: lzhai at openjdk.org (Leslie Zhai)
Date: Sun, 28 Apr 2024 06:53:30 GMT
Subject: [jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64 zero
 build is not accurate.
Message-ID: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>

Hi,

I'd like to backport this patch to jdk8u. `common/autoconf/platform.m4` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually.

A native build on LoongArch hardware is tested.

Debian: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-April/018378.html


$ ./build/images/j2sdk-image/bin/java -version
openjdk version "1.8.0_412"
OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1-b08)
OpenJDK 64-Bit Zero VM (build 25.412-b08, interpreted mode)


Loongnix Desktop:


$ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
openjdk version "1.8.0_422-internal"
OpenJDK Runtime Environment (build 1.8.0_422-internal-zhaixiang_2024_04_28_10_57-b00)
OpenJDK 64-Bit Zero VM (build 25.422-b00, interpreted mode)


The risk of the downport is low.

Thanks,
Leslie Zhai

-------------

Commit messages:
 - Backport 725ec0ce1b463b21cd4c5287cf4ccbee53ec7349

Changes: https://git.openjdk.org/jdk8u-dev/pull/489/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=489&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8315020
  Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/489.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/489/head:pull/489

PR: https://git.openjdk.org/jdk8u-dev/pull/489

From lzhai at openjdk.org  Sun Apr 28 07:06:10 2024
From: lzhai at openjdk.org (Leslie Zhai)
Date: Sun, 28 Apr 2024 07:06:10 GMT
Subject: [jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64
 zero build is not accurate.
In-Reply-To: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
References: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
Message-ID: <EpDwEzDJBaKxr3eGM3icfDSCxBOdJGbm3lT_D10Tn4M=.52a3a2b5-ef24-46df-b4d6-c81b34ba051b@github.com>

On Sun, 28 Apr 2024 06:48:33 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> I'd like to backport this patch to jdk8u. `common/autoconf/platform.m4` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually.
> 
> A native build on LoongArch hardware is tested.
> 
> Debian: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-April/018378.html
> 
> 
> $ ./build/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_412"
> OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1-b08)
> OpenJDK 64-Bit Zero VM (build 25.412-b08, interpreted mode)
> 
> 
> Loongnix Desktop:
> 
> 
> $ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_422-internal"
> OpenJDK Runtime Environment (build 1.8.0_422-internal-zhaixiang_2024_04_28_10_57-b00)
> OpenJDK 64-Bit Zero VM (build 25.422-b00, interpreted mode)
> 
> 
> The risk of the downport is low.
> 
> Thanks,
> Leslie Zhai

Hi @theaoqi @gnu-andrew 

Could you review and sponsor the patch please?

Thanks,
Leslie Zhai

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/489#issuecomment-2081364305

From zhaixiang at loongson.cn  Sun Apr 28 07:06:16 2024
From: zhaixiang at loongson.cn (Leslie Zhai)
Date: Sun, 28 Apr 2024 15:06:16 +0800
Subject: 8u412-ga build error on loong64
In-Reply-To: <7f215cb1-d8ad-f29a-099b-7efb1f1966bb@qvest-digital.com>
References: <7f215cb1-d8ad-f29a-099b-7efb1f1966bb@qvest-digital.com>
Message-ID: <1120e4b7-ed98-3a72-e947-d697577c9916@loongson.cn>

Hi Thorsten,

Thanks for point out my fault!

I reproduced the issue on our Debian build machine.

Backport JDK-8315020 is request for review[1] right now, so we need to handle it additionally[2].

[1] https://github.com/openjdk/jdk8u-dev/pull/489

[2]
Author: zhaixiang <zhaixiang at loongson.cn>
Date:   Sun Apr 28 14:42:47 2024 +0800

     Backport JDK-8315020

diff --git a/patches/loong64-backport-jdk-8315020.diff b/patches/loong64-backport-jdk-8315020.diff
new file mode 100644
index 0000000..1515193
--- /dev/null
+++ b/patches/loong64-backport-jdk-8315020.diff
@@ -0,0 +1,20 @@
+diff --git a/hotspot/src/os/linux/vm/os_linux.cpp b/hotspot/src/os/linux/vm/os_linux.cpp
+index 54cfcdd116..5629a640f6 100644
+--- a/hotspot/src/os/linux/vm/os_linux.cpp
++++ b/hotspot/src/os/linux/vm/os_linux.cpp
+@@ -2009,13 +2009,13 @@
+     static  Elf32_Half running_arch_code=EM_68K;
+   #elif  (defined AARCH64)
+     static  Elf32_Half running_arch_code=EM_AARCH64;
+-  #elif  (defined LOONGARCH)
++  #elif  (defined LOONGARCH64)
+     static  Elf32_Half running_arch_code=EM_LOONGARCH;
+   #elif  (defined ZERO_SH)
+     static  Elf32_Half running_arch_code=EM_SH;
+   #else
+     #error Method os::dll_load requires that one of following is defined:\
+-         IA32, AMD64, IA64, __sparc, __powerpc__, ARM, S390, ALPHA, MIPS, MIPSEL, PARISC, M68K, AARCH64, LOONGARCH, SH
++         IA32, AMD64, IA64, __sparc, __powerpc__, ARM, S390, ALPHA, MIPS, MIPSEL, PARISC, M68K, AARCH64, LOONGARCH64, SH
+   #endif
+
+   // Identify compatability class for VM's architecture and library's architecture
diff --git a/rules b/rules
index dd54b6f..f41daff 100755
--- a/rules
+++ b/rules
@@ -388,6 +388,7 @@ COMMON_PATCHES = \
         sparc-inline-conflict.diff \
         zero-sh.diff \
         t64-dlsyms.diff \
+       loong64-backport-jdk-8315020.diff \
  
  ifeq ($(derivative),Debian)
    COMMON_PATCHES += \


Thanks,
Leslie Zhai

? 2024/4/26 ??11:01, Thorsten Glaser ??:
> /<<PKGBUILDDIR>>/src/hotspot/src/os/linux/vm/os_linux.cpp: In static member function 'static void* os::dll_load(c
> onst char*, char*, int)':
> /<<PKGBUILDDIR>>/src/hotspot/src/os/linux/vm/os_linux.cpp:2041:9: error: 'running_arch_code' was not declared in
> this scope; did you mean 'running_arch_index'?
>   2041 |     if (running_arch_code == arch_array[i].code) {
>        |         ^~~~~~~~~~~~~~~~~
>        |         running_arch_index
>
> This is probably from?
>
>     #elif  (defined LOONGARCH)
>       static  Elf32_Half running_arch_code=EM_LOONGARCH;
>
> ? not triggering. An earlier version of that patch had?
>
> +  #elif  (defined LOONGARCH64)
> +    static  Elf32_Half running_arch_code=EM_LOONGARCH;
>
> ? there, notice the difference in the architecture definition,
> which (looking at other places) seems to be the correct one.
>
> bye,
> //mirabilos


From gaoxiang at kylinos.cn  Sun Apr 28 07:13:01 2024
From: gaoxiang at kylinos.cn (gaoxiang at kylinos.cn)
Date: Sun, 28 Apr 2024 15:13:01 +0800
Subject: Question about backporting JDK-8223923 : C2: Missing interference
 with mismatched unsafe accesses
Message-ID: <00bd01da993b$a4514280$ecf3c780$@kylinos.cn>

Hello,

 

I have a question about the backporting of JDK-8223923, specifically whether
it is applicable to our situation:

 

It is similar to JDK-8212637, We got a report from our customer that C2
thread got 100% CPU usage. Due to their security policies in the production
environment, we are unable to get more details using gdb or JIT debugging
information. The probability of this issue recurring is very low, having
occurred only twice in the past two months. (The customer did not preserve
the scene...)

 

>From the flame graph, we noticed the "while" loop in can_see_stored_value
caused CPU usage, and the critical path was MemBarCPUOrder. We found a patch
in JDK-8223923, which forbids stepping over MemBarCPUOrder nodes in
can_see_stored_value . With this fix, the conditions for the customer's
issue to recur no longer exist. 

 

Perf record:

Samples: 10K of event 'cycles:ppp', Event count (approx.): 26570671846


  Children      Self  Command          Shared Object       Symbol


-   98.18%     0.00%  C2 CompilerThre  libjvm.so           [.]
Compile::Compile                          

     Compile::Compile


     Compile::Optimize


     PhaseIterGVN::optimize


     PhaseIterGVN::transform_old


     LoadNode::Value


   - MemNode::can_see_stored_value


      + 35.08% MergeMemNode::memory_at


        13.03% MemBarCPUOrderNode::Opcode


        8.97% Node::in (inlined)


      + 1.97% MergeMemNode::base_memory (inlined)


+   98.18%     0.00%  C2 CompilerThre  libjvm.so           [.]
Compile::Optimize                         

+   98.18%     0.00%  C2 CompilerThre  libjvm.so           [.]
PhaseIterGVN::optimize                    

+   98.18%     0.00%  C2 CompilerThre  libjvm.so           [.]
PhaseIterGVN::transform_old               

+   98.18%     0.00%  C2 CompilerThre  libjvm.so           [.]
LoadNode::Value                           

+   98.18%    50.06%  C2 CompilerThre  libjvm.so           [.]
MemNode::can_see_stored_value             

+   35.08%    26.14%  C2 CompilerThre  libjvm.so           [.]
MergeMemNode::memory_at                   

+   17.58%     0.00%  C2 CompilerThre  libjvm.so           [.] Node::in
(inlined)                        

+   14.14%     0.00%  C2 CompilerThre  libjvm.so           [.]
MergeMemNode::base_memory (inlined)       

+   13.03%    13.00%  C2 CompilerThre  libjvm.so           [.]
MemBarCPUOrderNode::Opcode                

+   10.94%     0.00%  C2 CompilerThre  libjvm.so           [.] Node::in
(inlined)                        

+    9.58%     0.00%  C2 CompilerThre  libjvm.so           [.]
Compile::current (inlined)                

+    9.58%     0.00%  C2 CompilerThre  libjvm.so           [.]
ciEnv::current (inlined)                  

+    9.58%     0.00%  C2 CompilerThre  libjvm.so           [.]
CompilerThread::current (inlined)         

+    9.58%     0.00%  C2 CompilerThre  libjvm.so           [.]
JavaThread::current (inlined)             

+    9.58%     0.00%  C2 CompilerThre  libjvm.so           [.]
Thread::current (inlined)                 

+    9.58%     0.00%  C2 CompilerThre  libjvm.so           [.]
Thread::current_or_null (inlined)         

+    8.94%     8.94%  C2 CompilerThre  libjvm.so           [.]
ThreadLocalStorage::is_initialized        

+    8.94%     0.00%  C2 CompilerThre  libjvm.so           [.]
ThreadLocalStorage::thread_index (inlined)

+    1.97%     0.00%  C2 CompilerThre  libjvm.so           [.]
MergeMemNode::base_memory (inlined)       

     0.08%     0.08%  RxComputationSc  perf-1012711.map    [.]
0x0000fffcb00122c8                        

     0.06%     0.06%  RxComputationSc  perf-1012711.map    [.]
0x0000fffcb0012444                        

     0.06%     0.06%  RxComputationSc  perf-1012711.map    [.]
0x0000fffcb0023620   

 

JDK-8223923 has already been merged into JDK11&17. Based on the frequency of
the issue, we are not yet able to verify the modification.

Could we get a suggestion about whether this patch should be backported to
JDK 8?

 

Thanks~

BR

Mail: gaoxiang at kylinos.cn <mailto:gaoxiang at kylinos.cn> 

Tel: 13502020281

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/jdk8u-dev/attachments/20240428/2851daa8/attachment-0001.htm>

From t.glaser at qvest-digital.com  Sun Apr 28 16:10:56 2024
From: t.glaser at qvest-digital.com (Thorsten Glaser)
Date: Sun, 28 Apr 2024 18:10:56 +0200 (CEST)
Subject: [jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64
 zero build is not accurate.
In-Reply-To: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
References: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
Message-ID: <3b5353e1-f538-0fa3-14be-ded1d54f8848@qvest-digital.com>

On Sun, 28 Apr 2024, Leslie Zhai wrote:

>  Patch: https://git.openjdk.org/jdk8u-dev/pull/489.diff

There?s an unnecessary line in there, I noted that on the web thingy.

>PR: https://git.openjdk.org/jdk8u-dev/pull/489

The failing s390x build is because this is still using
Debian 10 (buster), which has recently been archived.

Do an s!http://(httpredir|deb).debian.org!http://archive.debian.org!g
to fix that.

bye,
//mirabilos
-- 
Infrastrukturexperte ? Qvest Digital AG
Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/
Telephon +49 228 54881-393 ? Fax: +49 228 54881-235
HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441
Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg
Vorsitzender Aufsichtsrat: Peter N?then

From duke at openjdk.org  Sun Apr 28 16:11:11 2024
From: duke at openjdk.org (mirabilos)
Date: Sun, 28 Apr 2024 16:11:11 GMT
Subject: [jdk8u-dev] RFR: 8315020: The macro definition for LoongArch64
 zero build is not accurate.
In-Reply-To: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
References: <PKq_6sdeY_ROekA8iu-wZcs3i317oEaU1k2_rqD5ZSU=.bfe52254-b045-47e2-97da-b53bf36f6f6d@github.com>
Message-ID: <RaFVagiNLflqbhvBPRcNAEcfbr2AMyhDLC8KJCWtjKw=.b317a191-f53c-4cf7-9fa0-4f2af135678e@github.com>

On Sun, 28 Apr 2024 06:48:33 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

> Hi,
> 
> I'd like to backport this patch to jdk8u. `common/autoconf/platform.m4` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually.
> 
> A native build on LoongArch hardware is tested.
> 
> Debian: https://mail.openjdk.org/pipermail/jdk8u-dev/2024-April/018378.html
> 
> 
> $ ./build/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_412"
> OpenJDK Runtime Environment (build 1.8.0_412-8u412-ga-1-b08)
> OpenJDK 64-Bit Zero VM (build 25.412-b08, interpreted mode)
> 
> 
> Loongnix Desktop:
> 
> 
> $ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
> openjdk version "1.8.0_422-internal"
> OpenJDK Runtime Environment (build 1.8.0_422-internal-zhaixiang_2024_04_28_10_57-b00)
> OpenJDK 64-Bit Zero VM (build 25.422-b00, interpreted mode)
> 
> 
> The risk of the downport is low.
> 
> Thanks,
> Leslie Zhai

Changes requested by mirabilos at github.com (no known OpenJDK username).

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/489#pullrequestreview-2027168673

From duke at openjdk.org  Mon Apr 29 04:45:37 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Mon, 29 Apr 2024 04:45:37 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
Message-ID: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>

Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

-------------

Commit messages:
 - Backport? 1b925183894778acce8aff4c101f67af98f0097f

Changes: https://git.openjdk.org/jdk8u-dev/pull/476/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=476&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8235834
  Stats: 111 lines in 2 files changed: 108 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jdk8u-dev/pull/476.diff
  Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/476/head:pull/476

PR: https://git.openjdk.org/jdk8u-dev/pull/476

From duke at openjdk.org  Mon Apr 29 04:45:37 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Mon, 29 Apr 2024 04:45:37 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <nMpo8V7Je-1J0Vs4etIQvZR5Ycsx-pZv88MdlLc2ddg=.90b65a4a-3379-4930-a59c-3e6fb3abd2e6@github.com>

On Mon, 1 Apr 2024 10:21:20 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

This contribution is on behalf of my employer, IBM, which is a corporate OCA signatory.

Closing this PR as my OCA verification is taking too long to approve. 
Opened another PR by a different contributor:- https://github.com/openjdk/jdk8u-dev/pull/480.

Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.

Reported issue : https://bugs.openjdk.org/browse/JDK-8235834.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2029539048
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2056423488
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2081877216

From duke at openjdk.org  Mon Apr 29 04:51:10 2024
From: duke at openjdk.org (Pratiksha Sawant)
Date: Mon, 29 Apr 2024 04:51:10 GMT
Subject: [jdk8u-dev] RFR: 8235834: IBM-943 charset encoder needs updating
In-Reply-To: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
References: <yEl6huG2yuSxFGdyXRiwbbE-8ZKaG0tfjb8xFcv3XlI=.1f045d0b-c13e-4a71-a127-82f25109edc0@github.com>
Message-ID: <QqDDPwTkX9pbHiCwa3Rc1EGb0m3wGEwdlh9yD7usY2Q=.027ae28d-ee7b-44da-964e-b570ae24a245@github.com>

On Mon, 1 Apr 2024 10:21:20 GMT, Pratiksha Sawant <duke at openjdk.org> wrote:

> Backporting JDK-8235834 - IBM-943 charset encoder needs updating.
> There are few characters which display garbled values when using IBM943C, so this mapping file needs to be backported to fix the issue.
> 
> Reported issue : https://bugs.openjdk.org/browse/JDK-8235834

@gnu-andrew, @mrserb Could you please review this PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/476#issuecomment-2081883577

From sgehwolf at openjdk.org  Tue Apr 30 15:30:12 2024
From: sgehwolf at openjdk.org (Severin Gehwolf)
Date: Tue, 30 Apr 2024 15:30:12 GMT
Subject: [jdk8u-dev] RFR: 8326529: JFR: Test for CompilerCompile events
 fails due to time out
In-Reply-To: <2g8E5z-FlvdvGwg-PduE119bq9bx0g81_cXvwFcAlFw=.4002bf20-9532-4b7e-8400-3f016117ae7a@github.com>
References: <2g8E5z-FlvdvGwg-PduE119bq9bx0g81_cXvwFcAlFw=.4002bf20-9532-4b7e-8400-3f016117ae7a@github.com>
Message-ID: <MiSUFAP2IjgcjYp7GvpBwTRaP_XE7fKigd9twdwD4gA=.4191bcd7-51ce-4fbe-8610-7677b642c85d@github.com>

On Fri, 19 Apr 2024 21:02:20 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

> This is a backport of https://github.com/openjdk/jdk/commit/4dd6c44cbdb0b5957414fa87b6c559fa4d6f2fa8
> 
> This backport limits compilation only to the test methods [TestCompileCompile](https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/compiler/TestCompilerCompile.java) cares about. It should help resolve some test failures for Adoptium (see https://github.com/adoptium/aqa-tests/issues/3046).
> 
> Testing: the updated `jdk/test/jdk/jfr/event/compiler/TestCompilerCompile.java` test passes.

LGTM.

-------------

Marked as reviewed by sgehwolf (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/484#pullrequestreview-2031752769