[jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64 zip files
Severin Gehwolf
sgehwolf at openjdk.org
Fri Apr 5 16:57:09 UTC 2024
On Fri, 5 Apr 2024 16:41:55 GMT, fitzsim <duke at openjdk.org> wrote:
>>> I verified that the patch applies cleanly to jdk8u-dev master.
>>
>> I'm confused. The original patch https://hg.openjdk.org/jdk10/master/rev/723486922bfe touches ZipFile.java, not zip_util.c. How is this a clean apply? AFAICS this patch re-implements part of the original patch.
>
> (From what I can tell, I will not receive GitHub email updates just for comments on this pull request because I did not file it -- that is why I did not receive a notification for @tstuefe's initial question. I will try to visit this/refresh this more often, and @jerboaa's mention of me did send a notification. See also https://github.com/orgs/community/discussions/44376)
@fitzsim Yes, please remove the `zip_util.c` changes. Then we can proceed with reviewing. Different question: Is there a reason why you didn't submit this PR for review?
-------------
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2040258527
More information about the jdk8u-dev
mailing list