[jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v4]

[Severin Gehwolf]

On Mon, 8 Apr 2024 18:22:38 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
> 
>  - Merge master
>  - Merge branch 'pr/453' of https://git.openjdk.org/jdk8u-dev into Backport-JDK-8293562
>  - 8291226: Create Test Cases to cover scenarios for JDK-8278067
>    
>    Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
>  - Merge branch 'master' into Backport-JDK-8278067
>  - Remove SystemProperty tag as it is not supported in JDK8
>  - Merge pr/437
>  - Fix indentation
>  - Backport d8f44aa39e921594505864e6270f42b745265293
>  - Fix indentation
>  - Backport 770c1f65c588f3156f9b70097df752d8059c1038
>  - ... and 1 more: https://git.openjdk.org/jdk8u-dev/compare/d0d9a152...36cb9124

This seems OK now modulo some whitespace changes. The best course of action would be to compare the `KeepAliveCache.java` file to the version from `jdk11u` and fix the whitespace changes in the  current version. The only difference then should be in the `AccessController.doPrivileged(` block between JDK 8 and 11 and nothing else.

http tests pass for me:

Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingTest.java
Passed: sun/net/www/http/ChunkedInputStream/ChunkedEncodingWithProgressMonitorTest.java
Passed: sun/net/www/http/ChunkedInputStream/TestAvailable.java
Passed: sun/net/www/http/ChunkedOutputStream/checkError.java
Passed: sun/net/www/http/ChunkedOutputStream/Test.java
Passed: sun/net/www/http/HttpClient/B6726695.java
Passed: sun/net/www/http/HttpClient/B7025238.java
Passed: sun/net/www/http/HttpClient/B8025710.java
Passed: sun/net/www/http/HttpClient/B8209178.java
Passed: sun/net/www/http/HttpClient/CookieHttpClientTest.java
Passed: sun/net/www/http/HttpClient/GetProxyPort.java
Passed: sun/net/www/http/HttpClient/ImplicitFileName.java
Passed: sun/net/www/http/HttpClient/IsAvailable.java
Passed: sun/net/www/http/HttpClient/IsKeepingAlive.java
Passed: sun/net/www/http/HttpClient/KeepAliveTest.java
Passed: sun/net/www/http/HttpClient/MultiThreadTest.java
Passed: sun/net/www/http/HttpClient/OpenServer.java
Passed: sun/net/www/http/HttpClient/ProxyFromCache.java
Passed: sun/net/www/http/HttpClient/ProxyTest.java
Passed: sun/net/www/http/HttpClient/RequestURI.java
Passed: sun/net/www/http/HttpClient/RetryPost.sh
Passed: sun/net/www/http/HttpClient/StreamingRetry.java
Passed: sun/net/www/http/HttpURLConnection/PostOnDelete.java
Passed: sun/net/www/http/KeepAliveCache/B5045306.java
Passed: sun/net/www/http/KeepAliveCache/B8291637.java
Passed: sun/net/www/http/KeepAliveCache/B8293562.java
Passed: sun/net/www/http/KeepAliveCache/KeepAliveProperty.java
Passed: sun/net/www/http/KeepAliveCache/KeepAliveTimerThread.java
Passed: sun/net/www/http/KeepAliveStream/InfiniteLoop.java
Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamClose.java
Passed: sun/net/www/http/KeepAliveStream/KeepAliveStreamCloseWithWrongContentLength.java
Passed: sun/net/www/http/RequestMethodCheck/RequestMethodEquality.java
Test results: passed: 32

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/409#pullrequestreview-1989178436