[jdk8u-dev] Integrated: 8069389: CompilerOracle prefix wildcarding is broken for long strings

Roman Marchenko rmarchenko at openjdk.org
Wed Apr 10 14:27:16 UTC 2024


On Fri, 16 Feb 2024 18:33:02 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

> Clean backport.
> 
> I've just found that the issue occurs even with short strings like "*123*", see my screenshot attached to JDK-8069389. This can be reproduced currently with "slowdebug" build on my Ubuntu 22.04 + gcc-9.5.0, however I believe we cannot rely on it isn't reproduced with "release" now.
> 
> Anyway, it wasn't good to use "strcpy" with overlapped buffers, because strcpy's docs says "The behavior is undefined if the strings overlap." So, I believe it should be fixed in jdk8 as well.

This pull request has now been integrated.

Changeset: cde8aca6
Author:    Roman Marchenko <rmarchenko at openjdk.org>
Committer: Andrew John Hughes <andrew at openjdk.org>
URL:       https://git.openjdk.org/jdk8u-dev/commit/cde8aca6cb0fae77b9300b9d65d094a4f74e4d53
Stats:     80 lines in 2 files changed: 79 ins; 0 del; 1 mod

8069389: CompilerOracle prefix wildcarding is broken for long strings

Replace strcpy with memmove

Reviewed-by: andrew
Backport-of: 01ec6950020268a375eb5330373e6c0813f3a924

-------------

PR: https://git.openjdk.org/jdk8u-dev/pull/446


More information about the jdk8u-dev mailing list