[jdk8u-dev] RFR: 8324185: [8u] Accept Xcode 12+ builds on macOS [v4]

[Andrew John Hughes]

On Tue, 27 Feb 2024 17:45:03 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> I would like to update the build logic for macOS so it will accept the XCode 14 and 15. It could be done in a few ways:
>> 
>>  - Add XCode 13, 14 and 15 to the list of supported versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d2d157ff4dd04cb108e036282643b21ac132016c)
>>  - Accept all XCode 9+ versions, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d1d5e2d214135084e50bc5aba839afab98cf2de7).
>>  - Delete the "fail fast" code path. So if the xcode and command-line tools are there then build it, like [this](https://github.com/openjdk/jdk8u-dev/pull/422/commits/d28f6cdbc2bd6cb6bfefc84837a6c7c76c287572). 
>> 
>> I think we can safely delete this check, so this PR implements it.
>
> Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
> 
>  - Merge branch 'openjdk:master' into xcode
>  - Merge branch 'master' into xcode
>  - Merge branch 'openjdk:master' into xcode
>  - Drop "Fail-fast" code path
>  - Accept XCode 9+
>  - Add Xcode 13, 14 and 15

I agree removal is appropriate here. These kind of version tests serve no real purpose in the first place. If one is trying to get the JDK to build with a new XCode version, this check is just a blocker that has to be removed to get to the real issues and actually have something to work with to add support.  If the aim is to avoid a specific bug, or check for a specific feature, then the check should be for the bug or feature (see what we do with flags for GCC)

The thing I was most curious about with this PR was why it wasn't a backport from later versions. It seems that [JDK-8043340](https://bugs.openjdk.org/browse/JDK-8043340) was implemented differently in 8u and 9. In [the 9 version](https://hg.openjdk.org/jdk9/jdk9/rev/26ba036c46fc) this check is not added. It is unique to [the 8 version](https://github.com/openjdk/jdk8u/commit/d85158eee8a044501fd316ffe709e2483ab578e8), restricting it to XCode 4. @benty-amzn's later change just extended it to more versions.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/422#pullrequestreview-2002359139