[jdk8u-dev] RFR: 8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging" [v2]

[Kazuhisa Takakuri]

On Mon, 8 Apr 2024 12:23:55 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all, This is a backport of JDK-8137329: [windows] Build broken on VS2010 after "8046148: JEP 158: Unified JVM Logging".
>> I worked on backporting JDK-8159695 to jdk8u ( https://github.com/openjdk/jdk8u-dev/pull/428 ), and found that VS2010 build fails. This is because strtoull function, which the JDK-8159695 patch contains, is not predefined in VS2010. This patch defines strtoull macro when the earlier versions of Visual Studio are used, so this patch need to be backported for builing with VS2010 if JDK-8159695 is backported as proposed.
>> 
>> This patch couldn't be applied cleanly due to a previously backported fix for earlier versions of Visual Studio at the same location, which needs to be merged.
>> 
>> The risk is low as this only affects earlier VS builds and introduces one macro.  
>> Testing: GHA
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request incrementally with 40 additional commits since the last revision:
> 
>  - Merge branch 'master' into 8137329
>  - 8203691: [TESTBUG] Test /runtime/containers/cgroup/PlainRead.java fails
>    
>    Backport-of: 2fa6eac464048176087092c91c8430781ab15301
>  - 8291226: Create Test Cases to cover scenarios for JDK-8278067
>    
>    Reviewed-by: sgehwolf
>    Backport-of: 86ec158dfb7a770fe9a74ff8617bac938d0bb90f
>  - 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
>    
>    Reviewed-by: simonis
>    Backport-of: a9d21c61fb12a11e18c6bb8aa903e5a8e42473f1
>  - 8325927: [8u] Backport of JDK-8170552 missed part of the test
>    
>    Reviewed-by: sgehwolf
>  - 8328809: [8u] Problem list some CA tests
>    
>    Reviewed-by: andrew
>  - 8317507: C2 compilation fails with "Exceeded _node_regs array"
>    
>    Reviewed-by: roland, andrew
>    Backport-of: a5818972c16bd883d768ff2fb23a8aa9e0142c65
>  - Merge
>  - 8321408: Add Certainly roots R1 and E1
>    
>    Reviewed-by: sgehwolf
>    Backport-of: e8f7eaeefe503a34089fd49051f9114d98a63cb1
>  - 8322750: Test "api/java_awt/interactive/SystemTrayTests.html" failed because A blue ball icon is added outside of the system tray
>    
>    Reviewed-by: phh, andrew
>    Backport-of: 5a988a5087d0afbb577c6715fd5e1e44564888cb
>  - ... and 30 more: https://git.openjdk.org/jdk8u-dev/compare/7b175458...5fbb88b2

Some tests are failing in GHA, but they are irrelevant as they are related to certification or GC.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/434#issuecomment-2059237715