[jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2]

[Kazuhisa Takakuri]

On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri <ktakakuri at openjdk.org> wrote:

>> Hi all,
>> 
>> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612  
>> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed.
>> 
>> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations.
>> 
>> Thank you.
>
> Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into 8217850
>  - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d
>  - d6a75a0f86d4c84132a3794c432b34068163fa60

Could someone please review this backport?
I have merged master branch to resolve the GHA error. Once #431 is merged, these diffs will disappear.
The only fix I put in this backport is https://github.com/openjdk/jdk8u-dev/pull/433/commits/ccb8463a09dc09a6df363017a350c8bc00fcbd60.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2060860956