[jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v3]

[Eirik Øverby]

On Thu, 8 Feb 2024 22:28:29 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains three commits:
> 
>  - Merge pr/437
>  - Fix indentation
>  - Backport 770c1f65c588f3156f9b70097df752d8059c1038

I'd like to pitch in that this feels (to us) like a serious bug that warrants fixing in 8. I don't know what the criteria for calling something a "performance issue" are, but my gut feeling tells me it falls far short of being classified as "just" that. Our application ground to a complete halt (not just a slowdown) when the client switched on TLS 1.3, and it took us the better part of a day to figure out the root cause and restore service.

My few cents, and a huge thanks to @dhanalla and anyone else working on backporting this fix.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-1976406480