From mbalao at openjdk.org Fri Aug 2 02:26:36 2024 From: mbalao at openjdk.org (Martin Balao) Date: Fri, 2 Aug 2024 02:26:36 GMT Subject: [jdk8u-dev] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions [v2] In-Reply-To: References: Message-ID: On Thu, 4 Jul 2024 21:31:54 GMT, Martin Balao wrote: >> Hi, >> >> I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date. >> >> Thanks, >> Martin.- > > Martin Balao has updated the pull request incrementally with one additional commit since the last revision: > > 8152207: JDK changes Keep this open. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/527#issuecomment-2264386850 From phh at openjdk.org Fri Aug 2 16:09:39 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 2 Aug 2024 16:09:39 GMT Subject: [jdk8u-dev] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions [v2] In-Reply-To: References: Message-ID: On Thu, 4 Jul 2024 21:31:54 GMT, Martin Balao wrote: >> Hi, >> >> I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date. >> >> Thanks, >> Martin.- > > Martin Balao has updated the pull request incrementally with one additional commit since the last revision: > > 8152207: JDK changes Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/527#pullrequestreview-2215945782 From ktakakuri at openjdk.org Mon Aug 5 12:44:39 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 5 Aug 2024 12:44:39 GMT Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2268984337 From ktakakuri at openjdk.org Mon Aug 5 12:46:40 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 5 Aug 2024 12:46:40 GMT Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect overflows In-Reply-To: References: Message-ID: On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri wrote: > Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows. > The bug reported is reproducible in JDK8, so this patch should be applied. > The original patch does not apply cleanly, and the following modifications are needed: > > - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9. > - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8. > > Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options. > Testing > > - Manually check the behaviour > When a given value is too large to fit in a julong, the proper exception is raised with this patch. > > without patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget > > uintx GCDrainStackTargetSize := 18446744073709551615 {product} > > > with patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version > Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > - hotspot_tier1 > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2268988043 From ktakakuri at openjdk.org Mon Aug 5 12:47:39 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 5 Aug 2024 12:47:39 GMT Subject: [jdk8u-dev] RFR: 8066708: JMXStartStopTest fails to connect to port 38112 [v3] In-Reply-To: References: Message-ID: On Tue, 18 Jun 2024 11:21:04 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8066708: JMXStartStopTest fails to connect to port 38112. >> I worked for backporting JDK-8035395 to jdk8u #429, and found that this fix makes this test more stable. >> >> The risk is low as this fix only affects testing. >> Testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Resolve conflicts > - Backport d9fe0af0483e5954ba1d68107fb448669724a464 > - Backport 70f2238ba9a81ba0bb3fe6cbd98a553009992ecb This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/430#issuecomment-2268988952 From ktakakuri at openjdk.org Mon Aug 5 12:48:42 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 5 Aug 2024 12:48:42 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2] In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 12:17:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8217612 > - d6a75a0f86d4c84132a3794c432b34068163fa60 Could anyone review this backport please? Failure of gc/metaspace/CompressedClassSpaceSizeInJmapHeap.java in GHA will be resolved in https://github.com/openjdk/jdk8u-dev/pull/433. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2268990803 From ktakakuri at openjdk.org Mon Aug 5 12:50:36 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 5 Aug 2024 12:50:36 GMT Subject: [jdk8u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: <-7nbEyx_NW7d4EOcq_t8qr2Y8nV2b0DCn9iG1S22tWI=.d6038726-1fb9-47f9-b1fc-f9a8984aed45@github.com> On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/517#issuecomment-2268995190 From ktakakuri at openjdk.org Mon Aug 5 12:50:41 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 5 Aug 2024 12:50:41 GMT Subject: [jdk8u-dev] RFR: 8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 [v2] In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 12:19:43 GMT, Kazuhisa Takakuri wrote: >> Hi all, >> >> This is a backport of JDK-8217850: CompressedClassSpaceSizeInJmapHeap fails after JDK-8217612 >> The bug reported is reproducible in JDK8, so this follow-up patch for JDK-8217612 is needed. >> >> The original patch does not apply cleanly. The Long.parseUnsignedLong method was introduced in JDK8, so building with JDK7 as the boot-jdk cannot utilize this method. I have introduced an alternative private method to Long.parseUnsignedLong. This is almost a duplicate of Long.parseUnsignedLong(String s, int radix), but it is necesary to replace compareUnsigned(long x, long y) and NumberFormatException.forInputString(s) with their respective implementations. >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' into 8217850 > - Backport 49c91b7f9522a991bcac789b9fcccfee8bf08b5d > - d6a75a0f86d4c84132a3794c432b34068163fa60 Could someone please review this backport with #431? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/433#issuecomment-2268994533 From ktakakuri at openjdk.org Mon Aug 5 12:50:40 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 5 Aug 2024 12:50:40 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: On Tue, 11 Jun 2024 04:35:10 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2268995550 From phh at openjdk.org Mon Aug 5 13:57:39 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 5 Aug 2024 13:57:39 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2] In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 12:17:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8217612 > - d6a75a0f86d4c84132a3794c432b34068163fa60 I think we can safely require JDK 8 as the boot JDK. I doubt any JDK 8 developer uses JDK 7 for anything. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/431#pullrequestreview-2219074429 From syan at openjdk.org Tue Aug 6 00:56:35 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 6 Aug 2024 00:56:35 GMT Subject: [jdk8u-dev] RFR: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 In-Reply-To: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> References: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> Message-ID: <4clAyQHEraJZRC72I35Iwafex1jibJW-DfIkjebf1KU=.393e2878-6ea2-4859-b66d-745919064d44@github.com> On Mon, 8 Jul 2024 09:14:01 GMT, SendaoYan wrote: > Hi all, > The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk. Fix test bugs of testcase, no risk. Can anyone take look this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/541#issuecomment-2270164568 From ktakakuri at openjdk.org Tue Aug 6 13:14:41 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 6 Aug 2024 13:14:41 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2] In-Reply-To: References: Message-ID: On Mon, 8 Apr 2024 12:17:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8217612 > - d6a75a0f86d4c84132a3794c432b34068163fa60 In my environment, I am building JDK8 using JDK7 according to the N-1 rule. As for me, I would like to support builds using JDK7. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2271261097 From magnus.ihse.bursie at oracle.com Tue Aug 6 16:37:05 2024 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 6 Aug 2024 18:37:05 +0200 Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: References: Message-ID: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> Hi Elazar, I see that you never got any replies here. I suggest that you re-ask your question on the jdk8u mailing list instead (cc'd). /Magnus On 2024-07-19 16:20, Elazar Leibovich wrote: > When trying to compile the latest jdk8u on linux I get failures over > warnings with the register keywords. > > I'm using https://github.com/openjdk/jdk8u-dev.git which seems to be > pretty up to date (I'm using master), and last commit is less than two > days ago. > > This is a workaround I had to use: > diff --git a/hotspot/make/linux/makefiles/gcc.make > b/hotspot/make/linux/makefiles/gcc.make > index 7dde7f0963..81f156574a 100644 > --- a/hotspot/make/linux/makefiles/gcc.make > +++ b/hotspot/make/linux/makefiles/gcc.make > @@ -202,7 +202,7 @@ else > ?endif > > ?# Compiler warnings are treated as errors > -WARNINGS_ARE_ERRORS = -Werror > +WARNINGS_ARE_ERRORS = -Werror -Wno-register > > But I guess the best solution is to remove the register keywords from > the codebase. > > How is adoptium?building it? Does it use specific compiler? Is the > supported compiler documented anywhere? > > FTR using temurin-build repository and scripts, fails for other > reasons, and fails even with -D/--podman docker containers. > > This patch builds it with centos stream 9 on amd64. > > Am I doing something wrong? What's the recommended way of building jdk8? > > Thanks, > Elazar Leibovich From zzambers at redhat.com Tue Aug 6 18:10:21 2024 From: zzambers at redhat.com (=?UTF-8?B?WmRlbsSbayDFvWFtYmVyc2vDvQ==?=) Date: Tue, 6 Aug 2024 20:10:21 +0200 Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> References: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> Message-ID: Hello, this is known issue, which should get fixed by JDK-8281096: https://github.com/openjdk/jdk8u-dev/pull/357 (see also: https://github.com/openjdk/jdk8u-dev/pull/508) TLDR: Jdk 8 explicitly specifies older c++ version (gnu++98, which not yet deprecated 'register' keyword), but flags are not propagated to ADLC build due to bug. (correct me, if I am wrong) When it comes to Adoptium, I don't know exactly, but I think they are using older compiler, which uses older c++ standard by default. On 06. 08. 24 18:37, Magnus Ihse Bursie wrote: > Hi Elazar, > > I see that you never got any replies here. I suggest that you re-ask > your question on the jdk8u mailing list instead (cc'd). > > /Magnus > > On 2024-07-19 16:20, Elazar Leibovich wrote: >> When trying to compile the latest jdk8u on linux I get failures over >> warnings with the register keywords. >> >> I'm using https://github.com/openjdk/jdk8u-dev.git which seems to be >> pretty up to date (I'm using master), and last commit is less than >> two days ago. >> >> This is a workaround I had to use: >> diff --git a/hotspot/make/linux/makefiles/gcc.make >> b/hotspot/make/linux/makefiles/gcc.make >> index 7dde7f0963..81f156574a 100644 >> --- a/hotspot/make/linux/makefiles/gcc.make >> +++ b/hotspot/make/linux/makefiles/gcc.make >> @@ -202,7 +202,7 @@ else >> ?endif >> >> ?# Compiler warnings are treated as errors >> -WARNINGS_ARE_ERRORS = -Werror >> +WARNINGS_ARE_ERRORS = -Werror -Wno-register >> >> But I guess the best solution is to remove the register keywords from >> the codebase. >> >> How is adoptium?building it? Does it use specific compiler? Is the >> supported compiler documented anywhere? >> >> FTR using temurin-build repository and scripts, fails for other >> reasons, and fails even with -D/--podman docker containers. >> >> This patch builds it with centos stream 9 on amd64. >> >> Am I doing something wrong? What's the recommended way of building jdk8? >> >> Thanks, >> Elazar Leibovich > -- Zden?k ?ambersk? OpenJDK QE Red Hat From magnus.ihse.bursie at oracle.com Tue Aug 6 18:37:20 2024 From: magnus.ihse.bursie at oracle.com (Magnus Ihse Bursie) Date: Tue, 6 Aug 2024 20:37:20 +0200 Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: References: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> Message-ID: On 2024-08-06 20:33, Elazar Leibovich wrote: > Thanks, > I still fail to understand how JDK8u developers are building the project. Setting up a build environment for jdk8 is unfortunately not a trivial task. The build readme can be of some use: https://github.com/openjdk/jdk8u-dev/blob/master/doc/building.md. The build system has gone through a complete overhaul in later versions, so if you were to build the mainline JDK it would be a much smoother experience. After all, JDK 8 was released 10 years ago, and much has happened since then. /Magnus > Is there a docker file specifying the build environment? What's the > recommended way of doing that? > Removing the register keyword, plus disabling an overflow warning in a > specific test with pragma did the?trick for me, but: > 1. I could not get it built in Mac OS X > 2. I felt as if I'm paving my own path building it, instead of > following the Yellow Brick Road, which I'm trying to locate. > > Thanks again, > > On Tue, 6 Aug 2024 at 21:10, Zden?k ?ambersk? wrote: > > Hello, > > this is known issue, which should get fixed by JDK-8281096: > https://github.com/openjdk/jdk8u-dev/pull/357 > > (see also: https://github.com/openjdk/jdk8u-dev/pull/508) > > TLDR: > Jdk 8 explicitly specifies older c++ version (gnu++98, which not yet > deprecated > 'register' keyword), but flags are not propagated to ADLC build > due to bug. > (correct me, if I am wrong) > > > When it comes to Adoptium, I don't know exactly, but I think they > are using > older compiler, which uses older c++ standard by default. > > On 06. 08. 24 18:37, Magnus Ihse Bursie wrote: > > Hi Elazar, > > > > I see that you never got any replies here. I suggest that you > re-ask > > your question on the jdk8u mailing list instead (cc'd). > > > > /Magnus > > > > On 2024-07-19 16:20, Elazar Leibovich wrote: > >> When trying to compile the latest jdk8u on linux I get failures > over > >> warnings with the register keywords. > >> > >> I'm using https://github.com/openjdk/jdk8u-dev.git which seems > to be > >> pretty up to date (I'm using master), and last commit is less than > >> two days ago. > >> > >> This is a workaround I had to use: > >> diff --git a/hotspot/make/linux/makefiles/gcc.make > >> b/hotspot/make/linux/makefiles/gcc.make > >> index 7dde7f0963..81f156574a 100644 > >> --- a/hotspot/make/linux/makefiles/gcc.make > >> +++ b/hotspot/make/linux/makefiles/gcc.make > >> @@ -202,7 +202,7 @@ else > >> ?endif > >> > >> ?# Compiler warnings are treated as errors > >> -WARNINGS_ARE_ERRORS = -Werror > >> +WARNINGS_ARE_ERRORS = -Werror -Wno-register > >> > >> But I guess the best solution is to remove the register > keywords from > >> the codebase. > >> > >> How is adoptium?building it? Does it use specific compiler? Is the > >> supported compiler documented anywhere? > >> > >> FTR using temurin-build repository and scripts, fails for other > >> reasons, and fails even with -D/--podman docker containers. > >> > >> This patch builds it with centos stream 9 on amd64. > >> > >> Am I doing something wrong? What's the recommended way of > building jdk8? > >> > >> Thanks, > >> Elazar Leibovich > > > > -- > Zden?k ?ambersk? > OpenJDK QE > Red Hat > -------------- next part -------------- An HTML attachment was scrubbed... URL: From duke at openjdk.org Tue Aug 6 22:13:40 2024 From: duke at openjdk.org (fitzsim) Date: Tue, 6 Aug 2024 22:13:40 GMT Subject: [jdk8u-dev] RFR: 8186464: ZipFile cannot read some InfoZip ZIP64 zip files In-Reply-To: References: Message-ID: On Tue, 20 Feb 2024 20:40:13 GMT, Andrew John Hughes wrote: > This is a re-do of #445 as we reached a deadlock where I could not make myself commit author, as I was not the PR author, and Thomas could not make me the author as he was not a Committer (see [SKARA-2173](https://bugs.openjdk.org/browse/SKARA-2173)). The content remains the same. > > What follows is Thomas' introduction from the original PR: > > This patch was applied to the Red Hat 1.8.0 RPMs in June 2020, so it has been deployed to Red Hat customers for over three years. > > I verified that the patch applies cleanly to jdk8u-dev master. I confirmed that with the fix portion of the patch reverted, the ReadZip.java test portion of the patch produces this exception: > > ~~~ > java.lang.RuntimeException: zipfile: zip64 end failed > at ReadZip.main(ReadZip.java:209) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127) > at java.lang.Thread.run(Thread.java:750) > ~~~ > > With the fix applied the test passes: > > ~~~ > Passed: java/util/zip/ZipFile/ReadZip.java > ~~~ > > With the patch applied on top of jdk8u-dev master tip, 3dc011b7ff955f6c1334058f300708412b21a3ad, `make test` on Fedora 38 x86-64 passes, with: > ~~~ > Test results: passed: 3,122 > ~~~ > I also retested the test cases in [JDK-8186464](https://bugs.openjdk.org/browse/JDK-8186464) and confirmed that without this backport, they fail, and with the backport they succeed. > > Thank you, > Thomas https://github.com/openjdk/jdk/pull/19678 is ready for review if someone who looked at this one wants to take a look at the `zip_util.c` changes as applied to JDK head. I wrote three new test cases for it. The new tests, if/when backported to jdk8u-dev, will need all the Java-only backports we have discussed here. I am going to wait to see what happens with it first, before getting the Java-only parts ready for this one. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/452#issuecomment-2272236530 From david.holmes at oracle.com Wed Aug 7 01:10:09 2024 From: david.holmes at oracle.com (David Holmes) Date: Wed, 7 Aug 2024 11:10:09 +1000 Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: References: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> Message-ID: <3e10bd91-0e6d-4a9e-a99b-e3632812e444@oracle.com> On 7/08/2024 4:42 am, Elazar Leibovich wrote: > Thanks, > I did follow the readme, but could not find any commentary about the > build environment or the required compilers. There is a tiny bit of info there but I think it is out-of-date: Linux X86 (32-bit) and X64 (64-bit) Fedora 9 gcc 4.3 Mac OS X X64 (64-bit) Mac OS X 10.7 "Lion" XCode 4.5.2 or newer There is also info here, but again likely out-of-date: https://wiki.openjdk.org/display/Build/Supported+Build+Platforms The folks on jdk8u-dev are the best source of current info. David ----- > Even less information was on Mac OS X, where the autoconf files seems > not to be updated, and as a result arm was chosen instead of aarch64. > > If you can point me to a specific section in the documentation > specifying, say, a list of known good compilers, I'll be grateful. > > On Tue, 6 Aug 2024 at 21:37, Magnus Ihse Bursie > > > wrote: > > __ > > On 2024-08-06 20:33, Elazar Leibovich wrote: > >> Thanks, >> I still fail to understand how JDK8u developers are building the >> project. > > Setting up a build environment for jdk8 is unfortunately not a > trivial task. The build readme can be of some use: > https://github.com/openjdk/jdk8u-dev/blob/master/doc/building.md > . > The build system has gone through a complete overhaul in later > versions, so if you were to build the mainline JDK it would be a > much smoother experience. After all, JDK 8 was released 10 years > ago, and much has happened since then. > > /Magnus > > > >> Is there a docker file specifying the build environment? What's >> the recommended way of doing that? >> Removing the register keyword, plus disabling an overflow warning >> in a specific test with pragma did the?trick for me, but: >> 1. I could not get it built in Mac OS X >> 2. I felt as if I'm paving my own path building it, instead of >> following the Yellow Brick Road, which I'm trying to locate. >> >> Thanks again, >> >> On Tue, 6 Aug 2024 at 21:10, Zden?k ?ambersk? > > wrote: >> >> Hello, >> >> this is known issue, which should get fixed by JDK-8281096: >> https://github.com/openjdk/jdk8u-dev/pull/357 >> >> >> (see also: https://github.com/openjdk/jdk8u-dev/pull/508 >> ) >> >> TLDR: >> Jdk 8 explicitly specifies older c++ version (gnu++98, which >> not yet >> deprecated >> 'register' keyword), but flags are not propagated to ADLC >> build due to bug. >> (correct me, if I am wrong) >> >> >> When it comes to Adoptium, I don't know exactly, but I think >> they are using >> older compiler, which uses older c++ standard by default. >> >> On 06. 08. 24 18:37, Magnus Ihse Bursie wrote: >> > Hi Elazar, >> > >> > I see that you never got any replies here. I suggest that >> you re-ask >> > your question on the jdk8u mailing list instead (cc'd). >> > >> > /Magnus >> > >> > On 2024-07-19 16:20, Elazar Leibovich wrote: >> >> When trying to compile the latest jdk8u on linux I get >> failures over >> >> warnings with the register keywords. >> >> >> >> I'm using https://github.com/openjdk/jdk8u-dev.git >> which seems to be >> >> pretty up to date (I'm using master), and last commit is >> less than >> >> two days ago. >> >> >> >> This is a workaround I had to use: >> >> diff --git a/hotspot/make/linux/makefiles/gcc.make >> >> b/hotspot/make/linux/makefiles/gcc.make >> >> index 7dde7f0963..81f156574a 100644 >> >> --- a/hotspot/make/linux/makefiles/gcc.make >> >> +++ b/hotspot/make/linux/makefiles/gcc.make >> >> @@ -202,7 +202,7 @@ else >> >> ?endif >> >> >> >> ?# Compiler warnings are treated as errors >> >> -WARNINGS_ARE_ERRORS = -Werror >> >> +WARNINGS_ARE_ERRORS = -Werror -Wno-register >> >> >> >> But I guess the best solution is to remove the register >> keywords from >> >> the codebase. >> >> >> >> How is adoptium?building it? Does it use specific compiler? >> Is the >> >> supported compiler documented anywhere? >> >> >> >> FTR using temurin-build repository and scripts, fails for >> other >> >> reasons, and fails even with -D/--podman docker containers. >> >> >> >> This patch builds it with centos stream 9 on amd64. >> >> >> >> Am I doing something wrong? What's the recommended way of >> building jdk8? >> >> >> >> Thanks, >> >> Elazar Leibovich >> > >> >> -- >> Zden?k ?ambersk? >> OpenJDK QE >> Red Hat >> From zzambers at redhat.com Wed Aug 7 12:02:13 2024 From: zzambers at redhat.com (=?UTF-8?B?WmRlbsSbayDFvWFtYmVyc2vDvQ==?=) Date: Wed, 7 Aug 2024 14:02:13 +0200 Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: References: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> Message-ID: <0a027333-1971-491a-8789-a7d0849a37b5@redhat.com> I think to have jdk8 build work out of box, it is better to use older OSes. Like rhel/centos <= 8. You can use VM or container. I personally usually use rhel-8 VM, if I want to build jdk8 locally. Others distros, which should work: Ubuntu <= 20.04 debian <= bullseye (I think) When it comes to vendors providing JDK 8 builds, I think they generally use older linux distros (like rhel-6/7 or equivalent) to maximize portability. I cannot really comment much on Mac OS X. I have never owned mac. GHA was just recently updated macos-13. (there are still some issues to solve there) https://github.com/openjdk/jdk8u-dev/pull/544 I don't think MacOS/aarch64 is even supported currently, at least I am not aware of any work in that regard. May need some additional patching. (Adoptium does not offer MacOS/aarch64.) However if you just want to test some changes, you can just use GHA. You can do test branch, with modified GHA workflow to run test groups, you are interested in, on top of your changes. On 06. 08. 24 20:42, Elazar Leibovich wrote: > Thanks, > I did follow the readme, but could not find any commentary about the > build environment or the required compilers. > Even less information was on Mac OS X, where the autoconf files seems > not to be updated, and as a result arm was chosen instead of aarch64. > > If you can point me to a specific section in the documentation > specifying, say, a list of known good compilers, I'll be grateful. > > On Tue, 6 Aug 2024 at 21:37, Magnus Ihse Bursie > wrote: > > On 2024-08-06 20:33, Elazar Leibovich wrote: > >> Thanks, >> I still fail to understand how JDK8u developers are building the >> project. > > Setting up a build environment for jdk8 is unfortunately not a > trivial task. The build readme can be of some use: > https://github.com/openjdk/jdk8u-dev/blob/master/doc/building.md. > The build system has gone through a complete overhaul in later > versions, so if you were to build the mainline JDK it would be a > much smoother experience. After all, JDK 8 was released 10 years > ago, and much has happened since then. > > /Magnus > > > >> Is there a docker file specifying the build environment? What's >> the recommended way of doing that? >> Removing the register keyword, plus disabling an overflow warning >> in a specific test with pragma did the?trick for me, but: >> 1. I could not get it built in Mac OS X >> 2. I felt as if I'm paving my own path building it, instead of >> following the Yellow Brick Road, which I'm trying to locate. >> >> Thanks again, >> >> On Tue, 6 Aug 2024 at 21:10, Zden?k ?ambersk? >> wrote: >> >> Hello, >> >> this is known issue, which should get fixed by JDK-8281096: >> https://github.com/openjdk/jdk8u-dev/pull/357 >> >> (see also: https://github.com/openjdk/jdk8u-dev/pull/508) >> >> TLDR: >> Jdk 8 explicitly specifies older c++ version (gnu++98, which >> not yet >> deprecated >> 'register' keyword), but flags are not propagated to ADLC >> build due to bug. >> (correct me, if I am wrong) >> >> >> When it comes to Adoptium, I don't know exactly, but I think >> they are using >> older compiler, which uses older c++ standard by default. >> >> On 06. 08. 24 18:37, Magnus Ihse Bursie wrote: >> > Hi Elazar, >> > >> > I see that you never got any replies here. I suggest that >> you re-ask >> > your question on the jdk8u mailing list instead (cc'd). >> > >> > /Magnus >> > >> > On 2024-07-19 16:20, Elazar Leibovich wrote: >> >> When trying to compile the latest jdk8u on linux I get >> failures over >> >> warnings with the register keywords. >> >> >> >> I'm using https://github.com/openjdk/jdk8u-dev.git which >> seems to be >> >> pretty up to date (I'm using master), and last commit is >> less than >> >> two days ago. >> >> >> >> This is a workaround I had to use: >> >> diff --git a/hotspot/make/linux/makefiles/gcc.make >> >> b/hotspot/make/linux/makefiles/gcc.make >> >> index 7dde7f0963..81f156574a 100644 >> >> --- a/hotspot/make/linux/makefiles/gcc.make >> >> +++ b/hotspot/make/linux/makefiles/gcc.make >> >> @@ -202,7 +202,7 @@ else >> >> ?endif >> >> >> >> ?# Compiler warnings are treated as errors >> >> -WARNINGS_ARE_ERRORS = -Werror >> >> +WARNINGS_ARE_ERRORS = -Werror -Wno-register >> >> >> >> But I guess the best solution is to remove the register >> keywords from >> >> the codebase. >> >> >> >> How is adoptium?building it? Does it use specific >> compiler? Is the >> >> supported compiler documented anywhere? >> >> >> >> FTR using temurin-build repository and scripts, fails for >> other >> >> reasons, and fails even with -D/--podman docker containers. >> >> >> >> This patch builds it with centos stream 9 on amd64. >> >> >> >> Am I doing something wrong? What's the recommended way of >> building jdk8? >> >> >> >> Thanks, >> >> Elazar Leibovich >> > >> >> -- >> Zden?k ?ambersk? >> OpenJDK QE >> Red Hat >> -- Zden?k ?ambersk? OpenJDK QE Red Hat From t.glaser at qvest-digital.com Wed Aug 7 12:12:09 2024 From: t.glaser at qvest-digital.com (Thorsten Glaser) Date: Wed, 7 Aug 2024 14:12:09 +0200 (CEST) Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: <0a027333-1971-491a-8789-a7d0849a37b5@redhat.com> References: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> <0a027333-1971-491a-8789-a7d0849a37b5@redhat.com> Message-ID: On Wed, 7 Aug 2024, Zden?k ?ambersk? wrote: > Others distros, which should work: > Ubuntu <= 20.04 > debian <= bullseye (I think) I maintain OpenJDK 8 for Debian, and my own (local repo and PPA), Debian?s and Ubuntu?s own builds cover Debian wheezy (7) up to unstable and all Ubuntu LTS versions from 14.04 on and the few recent n?n-LTS releases, although they use the GCC version that is appropriate for each. https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=alioth/openjdk-8.git;a=blob;f=debian/rules;h=b1854f48be30d0d1cef2f026dd2019ae85965a73;hb=HEAD#l259 I?ve not yet gone to 14, the distros switched to it only very recently (maybe two weeks or so ago). bye, //mirabilos -- Infrastrukturexperte ? Qvest Digital AG Am Dickobskreuz 10, D-53121 Bonn ? https://www.qvest-digital.com/ Telephon +49 228 54881-393 ? Fax: +49 228 54881-235 HRB AG Bonn 18196 ? USt-ID (VAT): DE274355441 Vorstand: Dr. Stefan Barth, Kai Ebenrett, Boris Esser, Alexander Steeg Vorsitzender Aufsichtsrat: Peter N?then From zzambers at redhat.com Wed Aug 7 17:49:23 2024 From: zzambers at redhat.com (=?UTF-8?B?WmRlbsSbayDFvWFtYmVyc2vDvQ==?=) Date: Wed, 7 Aug 2024 19:49:23 +0200 Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: References: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> <0a027333-1971-491a-8789-a7d0849a37b5@redhat.com> Message-ID: Just to clarify, I meant distros, which should just work out of box (currently). That is: installation of dependencies -> configure -> make. According to documentation, without patching, explicit/custom toolchain configuration, etc.. (newer distros often need some additional effort due to newer toolchain) On 07. 08. 24 14:12, Thorsten Glaser wrote: > On Wed, 7 Aug 2024, Zden?k ?ambersk? wrote: > >> Others distros, which should work: >> Ubuntu <= 20.04 >> debian <= bullseye (I think) > I maintain OpenJDK 8 for Debian, and my own (local repo and PPA), > Debian?s and Ubuntu?s own builds cover Debian wheezy (7) up to > unstable and all Ubuntu LTS versions from 14.04 on and the few > recent n?n-LTS releases, although they use the GCC version that > is appropriate for each. > > https://evolvis.org/plugins/scmgit/cgi-bin/gitweb.cgi?p=alioth/openjdk-8.git;a=blob;f=debian/rules;h=b1854f48be30d0d1cef2f026dd2019ae85965a73;hb=HEAD#l259 > > I?ve not yet gone to 14, the distros switched to it only very > recently (maybe two weeks or so ago). > > bye, > //mirabilos -- Zden?k ?ambersk? OpenJDK QE Red Hat From zzambers at redhat.com Thu Aug 8 10:41:18 2024 From: zzambers at redhat.com (=?UTF-8?B?WmRlbsSbayDFvWFtYmVyc2vDvQ==?=) Date: Thu, 8 Aug 2024 12:41:18 +0200 Subject: jdk8u: -Wno-regsiter to support newer compilers In-Reply-To: <0a027333-1971-491a-8789-a7d0849a37b5@redhat.com> References: <8e27b2e0-0e1b-4a2e-909b-5db0c0fac582@oracle.com> <0a027333-1971-491a-8789-a7d0849a37b5@redhat.com> Message-ID: On 07. 08. 24 14:02, Zden?k ?ambersk? wrote: > I think to have jdk8 build work out of box, it is better to use older > OSes. > Like rhel/centos <= 8. You can use VM or container. > I personally usually use rhel-8 VM, if I want to build jdk8 locally. > > Others distros, which should work: > Ubuntu <= 20.04 > debian <= bullseye (I think) > > When it comes to vendors providing JDK 8 builds, I think they > generally use > older linux distros (like rhel-6/7 or equivalent) to maximize > portability. > > I cannot really comment much on Mac OS X. I have never owned mac. > GHA was just recently updated macos-13. (there are still some issues > to solve there) > https://github.com/openjdk/jdk8u-dev/pull/544 > > I don't think MacOS/aarch64 is even supported currently, at least I am > not aware of any work in that regard. > May need some additional patching. (Adoptium does not offer > MacOS/aarch64.) > Here is the bug for MacOS/aarch64port: https://bugs.openjdk.org/browse/JDK-8253795 It has not been backported to openjdk8. You may be able to build zero port on MacOS/aarc64, but it will be much slower compared to "full" ports. > > However if you just want to test some changes, you can just use GHA. > You can do test branch, > with modified GHA workflow to run test groups, you are interested in, > on top of your changes. > > > On 06. 08. 24 20:42, Elazar Leibovich wrote: >> Thanks, >> I did follow the readme, but could not find any commentary about the >> build environment or the required compilers. >> Even less information was on Mac OS X, where the autoconf files seems >> not to be updated, and as a result arm was chosen instead of aarch64. >> >> If you can point me to a specific section in the documentation >> specifying, say, a list of known good compilers, I'll be grateful. >> >> On Tue, 6 Aug 2024 at 21:37, Magnus Ihse Bursie >> wrote: >> >> ??? On 2024-08-06 20:33, Elazar Leibovich wrote: >> >>> ??? Thanks, >>> ??? I still fail to understand how JDK8u developers are building the >>> ??? project. >> >> ??? Setting up a build environment for jdk8 is unfortunately not a >> ??? trivial task. The build readme can be of some use: >> https://github.com/openjdk/jdk8u-dev/blob/master/doc/building.md. >> ??? The build system has gone through a complete overhaul in later >> ??? versions, so if you were to build the mainline JDK it would be a >> ??? much smoother experience. After all, JDK 8 was released 10 years >> ??? ago, and much has happened since then. >> >> ??? /Magnus >> >> >> >>> ??? Is there a docker file specifying the build environment? What's >>> ??? the recommended way of doing that? >>> ??? Removing the register keyword, plus disabling an overflow warning >>> ??? in a specific test with pragma did the?trick for me, but: >>> ??? 1. I could not get it built in Mac OS X >>> ??? 2. I felt as if I'm paving my own path building it, instead of >>> ??? following the Yellow Brick Road, which I'm trying to locate. >>> >>> ??? Thanks again, >>> >>> ??? On Tue, 6 Aug 2024 at 21:10, Zden?k ?ambersk? >>> ??? wrote: >>> >>> ??????? Hello, >>> >>> ??????? this is known issue, which should get fixed by JDK-8281096: >>> ??????? https://github.com/openjdk/jdk8u-dev/pull/357 >>> >>> ??????? (see also: https://github.com/openjdk/jdk8u-dev/pull/508) >>> >>> ??????? TLDR: >>> ??????? Jdk 8 explicitly specifies older c++ version (gnu++98, which >>> ??????? not yet >>> ??????? deprecated >>> ??????? 'register' keyword), but flags are not propagated to ADLC >>> ??????? build due to bug. >>> ??????? (correct me, if I am wrong) >>> >>> >>> ??????? When it comes to Adoptium, I don't know exactly, but I think >>> ??????? they are using >>> ??????? older compiler, which uses older c++ standard by default. >>> >>> ??????? On 06. 08. 24 18:37, Magnus Ihse Bursie wrote: >>> ??????? > Hi Elazar, >>> ??????? > >>> ??????? > I see that you never got any replies here. I suggest that >>> ??????? you re-ask >>> ??????? > your question on the jdk8u mailing list instead (cc'd). >>> ??????? > >>> ??????? > /Magnus >>> ??????? > >>> ??????? > On 2024-07-19 16:20, Elazar Leibovich wrote: >>> ??????? >> When trying to compile the latest jdk8u on linux I get >>> ??????? failures over >>> ??????? >> warnings with the register keywords. >>> ??????? >> >>> ??????? >> I'm using https://github.com/openjdk/jdk8u-dev.git which >>> ??????? seems to be >>> ??????? >> pretty up to date (I'm using master), and last commit is >>> ??????? less than >>> ??????? >> two days ago. >>> ??????? >> >>> ??????? >> This is a workaround I had to use: >>> ??????? >> diff --git a/hotspot/make/linux/makefiles/gcc.make >>> ??????? >> b/hotspot/make/linux/makefiles/gcc.make >>> ??????? >> index 7dde7f0963..81f156574a 100644 >>> ??????? >> --- a/hotspot/make/linux/makefiles/gcc.make >>> ??????? >> +++ b/hotspot/make/linux/makefiles/gcc.make >>> ??????? >> @@ -202,7 +202,7 @@ else >>> ??????? >> ?endif >>> ??????? >> >>> ??????? >> ?# Compiler warnings are treated as errors >>> ??????? >> -WARNINGS_ARE_ERRORS = -Werror >>> ??????? >> +WARNINGS_ARE_ERRORS = -Werror -Wno-register >>> ??????? >> >>> ??????? >> But I guess the best solution is to remove the register >>> ??????? keywords from >>> ??????? >> the codebase. >>> ??????? >> >>> ??????? >> How is adoptium?building it? Does it use specific >>> ??????? compiler? Is the >>> ??????? >> supported compiler documented anywhere? >>> ??????? >> >>> ??????? >> FTR using temurin-build repository and scripts, fails for >>> ??????? other >>> ??????? >> reasons, and fails even with -D/--podman docker containers. >>> ??????? >> >>> ??????? >> This patch builds it with centos stream 9 on amd64. >>> ??????? >> >>> ??????? >> Am I doing something wrong? What's the recommended way of >>> ??????? building jdk8? >>> ??????? >> >>> ??????? >> Thanks, >>> ??????? >> Elazar Leibovich >>> ??????? > >>> >>> ??????? -- ??????? Zden?k ?ambersk? >>> ??????? OpenJDK QE >>> ??????? Red Hat >>> > -- Zden?k ?ambersk? OpenJDK QE Red Hat From phh at openjdk.org Fri Aug 9 17:23:39 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 9 Aug 2024 17:23:39 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v2] In-Reply-To: References: Message-ID: <8SWQfpSd043P3Ah7aQZGDb2XRKR_doPsQalohm-PoTc=.0c98f169-84c7-44c1-b617-e082a39c90f1@github.com> On Mon, 8 Apr 2024 12:17:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'master' into 8217612 > - d6a75a0f86d4c84132a3794c432b34068163fa60 I agree with adding ClhsdbFlags.java as a "needed for a future backport", but please add a comment to that effect in place of @test. ------------- Changes requested by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/431#pullrequestreview-2230702607 From phh at openjdk.org Fri Aug 9 18:39:38 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 9 Aug 2024 18:39:38 GMT Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong position In-Reply-To: References: Message-ID: <_ThOXAPqtR2gr2ssrJZrdMCjKJDcvm8eDf8LPEE4y0c=.8b529327-3865-47cd-b9dd-7a900c078390@github.com> On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri wrote: > This fix includes a fix for JDK-8189687 in JDK9. > JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > HWND hTop = GetTopLevelParentForWindow(hWnd); > ::ClientToScreen(hTop, &p); > + int sx = ScaleUpX(x) - p.x; > + int sy = ScaleUpY(y) - p.y; > if (!m_bitsCandType) { > - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); > + SetCandidateWindow(m_bitsCandType, sx, sy); > return; > } > for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { > if ( m_bitsCandType & bits ) > - SetCandidateWindow(iCandType, x - p.x, y - p.y); > + SetCandidateWindow(iCandType, sx, sy); > } > } > > > In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. Why not just reframe this change as a backport of [JDK-8189687](https://bugs.openjdk.org/browse/JDK-8189687)? The backport would be identical to this PR because you would naturally have to drop the JEP 263 related code. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/483#pullrequestreview-2230835927 From andrew at openjdk.org Sat Aug 10 12:46:07 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 10 Aug 2024 12:46:07 GMT Subject: [jdk8u-dev] RFR: 8338144: [8u] Remove duplicate license files Message-ID: This removes the duplicate copies of the three licensing files - `LICENSE`, `ASSEMBLY_EXCEPTION` and `THIRD_PARTY_README` - from the top of each of the old subrepositories - `corba`, `jaxp`, `jaxws`, `langtools`, `jdk`, `hotspot` and `nashorn`. The `Images.gmk` makefile under the `jdk` tree has to be updated to use the top-level versions rather than the `jdk` ones. ------------- Commit messages: - 8338144: [8u] Remove duplicate license files Changes: https://git.openjdk.org/jdk8u-dev/pull/557/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=557&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8338144 Stats: 26217 lines in 22 files changed: 0 ins; 26215 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/557.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/557/head:pull/557 PR: https://git.openjdk.org/jdk8u-dev/pull/557 From sgehwolf at openjdk.org Mon Aug 12 14:07:40 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 12 Aug 2024 14:07:40 GMT Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v3] In-Reply-To: <6l1mmj3FM3vyAu6l9N_9apWfaD0YWBVOQpMqZwfAvtI=.abffbe6f-991d-4669-9696-af92be7b322b@github.com> References: <6l1mmj3FM3vyAu6l9N_9apWfaD0YWBVOQpMqZwfAvtI=.abffbe6f-991d-4669-9696-af92be7b322b@github.com> Message-ID: On Tue, 30 Jul 2024 15:16:12 GMT, George Adams wrote: >> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions. >> >> This will remove all warnings about deprecated Node.js versions > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > Update .github/workflows/submit.yml Seems fine. I'll rely on @zzambers for checking this doesn't break any other things. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/546#pullrequestreview-2233139373 From tim.bell at oracle.com Mon Aug 12 15:04:20 2024 From: tim.bell at oracle.com (tim.bell at oracle.com) Date: Mon, 12 Aug 2024 15:04:20 +0000 Subject: Need CCATS for OpenJDK 8 (ECCN 5D992.c) In-Reply-To: References: Message-ID: <1f18679e-9e7e-4024-818a-4e90b61c43f7@oracle.com> Hello OpenJDK can't provide export control certification information for third parties. Contact the vendor providing your JDK 8 runtime for this information. Best regards- Tim Bell OpenJDK.org infrastructure team On 8/12/24 13:34, Hemantkumar Prakashbhai Makhijani wrote: > Hello > Jdk8u, build-dev , jdk-updates-dev > > Can you guys help us here please ? > > > > > > Regards > Hemantkumar Makhijani > > > > ------------------------------------------------------------------------ > *From:* Hemantkumar Prakashbhai Makhijani > *Sent:* Monday, August 12, 2024 3:45 PM > *To:* mailman-owner at openjdk.org > *Cc:* Shankar Shailesh ; Rim Bains > *Subject:* RE: Need CCATS for OpenJDK 8 (ECCN 5D992.c) > > Gentle reminder ? > > Since *OpenJDK 8*is managed by you, > > Please provide Commodity Classification Automated Tracking System > (CCATS > ) > . > > This is because, we got to know that, for ENC product, it is mandatory > to get CCATS certificate from U.S. to meet export control guidelines. > > Regards > > *Hemant Makhijani* > > *From:*Hemantkumar Prakashbhai Makhijani > *Sent:* Thursday, August 8, 2024 7:21 PM > *To:* mailman-owner at openjdk.org > *Cc:* Shankar Shailesh ; Rim Bains > *Subject:* Need CCATS for OpenJDK 8 (ECCN 5D992.c) > > Hello > > We are interested to obtain a copy of the Commodity Classification > Automated Tracking System (CCATS > )certificate > so that we can understand how *ENC note reporting* should be handled > for your *below* product : > > OpenJDK 8 > . > > Note :- > > Referring this, we could understand that OpenJDK has ECCN as 5D992.c > and CCATS number as *G167674. *However, we don?t see actual CCATS > certificate anywhere. > > Regards > > *Hemantkumar Makhijani | SLB* > > SLB-Public > -------------- next part -------------- An HTML attachment was scrubbed... URL: From sgehwolf at openjdk.org Mon Aug 12 15:34:38 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 12 Aug 2024 15:34:38 GMT Subject: [jdk8u-dev] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions [v2] In-Reply-To: References: Message-ID: <3C99EWR6joy-d0NbR-GqxpH8b5AisBKasS1vqkOfiTU=.fbb8c537-82de-4b4e-826a-8e5e4c19763f@github.com> On Thu, 4 Jul 2024 21:31:54 GMT, Martin Balao wrote: >> Hi, >> >> I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date. >> >> Thanks, >> Martin.- > > Martin Balao has updated the pull request incrementally with one additional commit since the last revision: > > 8152207: JDK changes LGTM. Copyright updates in later releases are not needed since the files have already newer dates. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/527#pullrequestreview-2233395599 From serb at openjdk.org Mon Aug 12 17:22:40 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:22:40 GMT Subject: [jdk8u-dev] RFR: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04 In-Reply-To: References: Message-ID: On Mon, 8 Jul 2024 05:46:09 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [ae60ed6f](https://github.com/openjdk/jdk11u-dev/commit/ae60ed6f0517465bbd164f600c3bccf25d6bb35a) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Goetz Lindenmaier on 23 Sep 2021 and was reviewed by Martin Doerr. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/537#issuecomment-2284543695 From serb at openjdk.org Mon Aug 12 17:22:40 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:22:40 GMT Subject: [jdk8u-dev] RFR: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java In-Reply-To: References: Message-ID: On Sat, 6 Jul 2024 14:10:57 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [6678b01c](https://github.com/openjdk/jdk/commit/6678b01c576532a393272dc74d87b6c180a869e7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Mar 2021 and was reviewed by Alexander Zuev, Tejpal Rebari and Pankaj Bansal. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/535#issuecomment-2284544186 From serb at openjdk.org Mon Aug 12 17:23:38 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:23:38 GMT Subject: [jdk8u-dev] RFR: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option In-Reply-To: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> References: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> Message-ID: On Wed, 3 Jul 2024 04:53:56 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0abb2b14](https://github.com/openjdk/jdk/commit/0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 3 Feb 2014 and was reviewed by Michael McMahon. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/533#issuecomment-2284544807 From serb at openjdk.org Mon Aug 12 17:23:43 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:23:43 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java In-Reply-To: References: Message-ID: On Sun, 30 Jun 2024 03:42:07 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [40e667c1](https://github.com/openjdk/jdk/commit/40e667c174269a73cd9b5612673c5e4b2293d6c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/531#issuecomment-2284546023 From serb at openjdk.org Mon Aug 12 17:24:38 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:24:38 GMT Subject: [jdk8u-dev] RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails In-Reply-To: References: Message-ID: On Fri, 28 Jun 2024 16:32:51 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [b7540df6](https://github.com/openjdk/jdk/commit/b7540df6a4279c63e69d32b9d9834f7a427478d1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 5 Mar 2024 and was reviewed by Phil Race. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/530#issuecomment-2284547024 From serb at openjdk.org Mon Aug 12 17:25:36 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:25:36 GMT Subject: [jdk8u-dev] RFR: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 In-Reply-To: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> References: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> Message-ID: On Wed, 12 Jun 2024 23:04:11 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [dedddd5a](https://github.com/openjdk/jdk/commit/dedddd5ab2e39a30a039d24f629a7974048b0923) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 May 2021 and was reviewed by Phil Race and Alexander Zvegintsev. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/520#issuecomment-2284549342 From serb at openjdk.org Mon Aug 12 17:25:40 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:25:40 GMT Subject: [jdk8u-dev] RFR: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690 In-Reply-To: <96JBnFAoN4R4Flicahn2yjFji1blAhyq6MozR6JeJ7E=.763161cb-b3c8-4d6b-ad52-3da96ac7c6d9@github.com> References: <96JBnFAoN4R4Flicahn2yjFji1blAhyq6MozR6JeJ7E=.763161cb-b3c8-4d6b-ad52-3da96ac7c6d9@github.com> Message-ID: On Mon, 24 Jun 2024 23:05:59 GMT, Sergey Bylokhov wrote: > The missed line in the test is restored. keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/525#issuecomment-2284548105 From serb at openjdk.org Mon Aug 12 17:25:40 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:25:40 GMT Subject: [jdk8u-dev] RFR: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows. In-Reply-To: References: Message-ID: <84qy1mD1b48-EwSdDYMNu7fTd6xdHqdbYgwe29tn63o=.b285d08d-2167-4743-8472-22aeb6b7d9f2@github.com> On Mon, 24 Jun 2024 05:59:28 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [791267a0](https://github.com/openjdk/jdk/commit/791267a0961353693ad6a92d888675b2e2837edc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Yuri Nesterenko on 31 Jul 2015 and was reviewed by Sergey Bylokhov. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/524#issuecomment-2284548728 From serb at openjdk.org Mon Aug 12 17:26:34 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:26:34 GMT Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Mon, 10 Jun 2024 02:24:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/516#issuecomment-2284549872 From serb at openjdk.org Mon Aug 12 17:27:36 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:27:36 GMT Subject: [jdk8u-dev] RFR: 8318951: Additional negative value check in JPEG decoding In-Reply-To: References: Message-ID: On Thu, 30 May 2024 21:30:33 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [75ce02fe](https://github.com/openjdk/jdk/commit/75ce02fe74e1232bfa8d72b4fdad82ed938ef957) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jayathirth D V on 31 Oct 2023 and was reviewed by Alexander Zvegintsev and Phil Race. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/510#issuecomment-2284551507 From serb at openjdk.org Mon Aug 12 17:27:36 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:27:36 GMT Subject: [jdk8u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 02:33:55 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/506#issuecomment-2284551856 From serb at openjdk.org Mon Aug 12 17:27:42 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:27:42 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v3] In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 19:27:10 GMT, Sergey Bylokhov wrote: >> The tests are updated to force the MarlinRenderingEngine. >> >> @bourgesl please take a look. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8326110 > - PR feedback > - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/447#issuecomment-2284552419 From serb at openjdk.org Mon Aug 12 17:33:42 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:33:42 GMT Subject: [jdk8u-dev] RFR: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. [v13] In-Reply-To: References: Message-ID: <0GG0cVTtf1ZMjVRBMjYAA1LUCT3CQzEuN3k1elsfekk=.5dd6a9ad-7b09-4327-8ba2-4d2eb49fe861@github.com> On Wed, 26 Jun 2024 06:44:28 GMT, yaqsun wrote: >> This backport has modified the following aspects: >> >> - there are 52 cases that do not exist: >> jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java >> jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java >> jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java >> jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/Button >> jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java >> jdk/test/java/awt/Frame/8158918/SetExtendedState.java >> jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java >> jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java >> jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java >> jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java >> jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java >> jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java >> jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java >> jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java >> jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java >> jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java >> jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java >> jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java >> jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java >> jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java >> jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java >> jdk/test/javax/swing/JButton/8151303/PressedIconTest.java >> jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java >> jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java >> jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java >> jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java >> jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java >> jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java >> jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java >> jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java >> jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java >> jdk/test/javax/swing/JList/6567433/UpdateUIRecursionTest.... > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > add '@build Sysout' keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/464#issuecomment-2284563508 From serb at openjdk.org Mon Aug 12 17:35:38 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:35:38 GMT Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test [v5] In-Reply-To: <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> <3fiMt61R7iLEwkpzAosnZnoVR4cSQxHE63dTlnyBYWk=.9bab6833-bd33-4833-bb35-79444bfefac6@github.com> Message-ID: On Wed, 26 Jun 2024 07:25:40 GMT, yaqsun wrote: >> JDK-8164119 remove key attribute headful, >> MoveToOtherScreenTest fails due wrong key attribute: >> @key headful >> isn't included in TEST.ROOT in jdk8. >> But define "headful" jtreg keyword on JDK-8129822. >> So add keywords headful in MoveToOtherScreenTest.java test. > > yaqsun has updated the pull request incrementally with one additional commit since the last revision: > > adjust headful position keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/460#issuecomment-2284566575 From serb at openjdk.org Mon Aug 12 17:38:40 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 12 Aug 2024 17:38:40 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v4] In-Reply-To: References: <0GHr4S0HzJRGkbPyQdB79OnrgmqwLE-1XM5oscR8r_Y=.b0329029-5602-4d09-beae-66d273496f29@github.com> Message-ID: On Tue, 4 Jul 2023 20:27:54 GMT, George Adams wrote: >> George Adams has updated the pull request incrementally with one additional commit since the last revision: >> >> move libfreetype to correct src directory > > Please keep this open @gdams do you have a chance to look at the merge-conflict? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2284569188 From gdams at openjdk.org Mon Aug 12 17:38:41 2024 From: gdams at openjdk.org (George Adams) Date: Mon, 12 Aug 2024 17:38:41 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v4] In-Reply-To: References: <0GHr4S0HzJRGkbPyQdB79OnrgmqwLE-1XM5oscR8r_Y=.b0329029-5602-4d09-beae-66d273496f29@github.com> Message-ID: On Mon, 12 Aug 2024 17:34:29 GMT, Sergey Bylokhov wrote: >> Please keep this open > > @gdams do you have a chance to look at the merge-conflict? Yup @mrserb I'll try and get to it this week. I must stress that it would be good to make a decision on this as it's very painful to keep such a large changeset up to date ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2284572601 From phh at openjdk.org Mon Aug 12 20:49:37 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 12 Aug 2024 20:49:37 GMT Subject: [jdk8u-dev] RFR: 8338144: [8u] Remove duplicate license files In-Reply-To: References: Message-ID: On Sat, 10 Aug 2024 12:41:52 GMT, Andrew John Hughes wrote: > This removes the duplicate copies of the three licensing files - `LICENSE`, `ASSEMBLY_EXCEPTION` and `THIRD_PARTY_README` - from the top of each of the old subrepositories - `corba`, `jaxp`, `jaxws`, `langtools`, `jdk`, `hotspot` and `nashorn`. The `Images.gmk` makefile under the `jdk` tree has to be updated to use the top-level versions rather than the `jdk` ones. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/557#pullrequestreview-2233989634 From syan at openjdk.org Tue Aug 13 01:09:57 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 13 Aug 2024 01:09:57 GMT Subject: [jdk8u-dev] RFR: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir In-Reply-To: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> References: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> Message-ID: On Mon, 8 Jul 2024 15:31:07 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138). > Only change the testcase, the change has been verified, no risk. Can anyone take look this PR ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/542#issuecomment-2285156921 From aph at openjdk.org Tue Aug 13 09:59:54 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 13 Aug 2024 09:59:54 GMT Subject: [jdk8u-dev] RFR: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04 In-Reply-To: References: Message-ID: <1Jfl9PES88POsgIqmX7eArs82VRp3nk4dVB13U6EGz8=.eccac5e1-4a74-424b-bfad-b660c71bf728@github.com> On Mon, 8 Jul 2024 05:46:09 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [ae60ed6f](https://github.com/openjdk/jdk11u-dev/commit/ae60ed6f0517465bbd164f600c3bccf25d6bb35a) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Goetz Lindenmaier on 23 Sep 2021 and was reviewed by Martin Doerr. > > Thanks! Marked as reviewed by aph (Lead). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/537#pullrequestreview-2235098734 From aph at openjdk.org Tue Aug 13 10:00:55 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 13 Aug 2024 10:00:55 GMT Subject: [jdk8u-dev] RFR: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option In-Reply-To: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> References: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> Message-ID: On Wed, 3 Jul 2024 04:53:56 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0abb2b14](https://github.com/openjdk/jdk/commit/0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 3 Feb 2014 and was reviewed by Michael McMahon. > > Thanks! Marked as reviewed by aph (Lead). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/533#pullrequestreview-2235100948 From aph at openjdk.org Tue Aug 13 10:03:50 2024 From: aph at openjdk.org (Andrew Haley) Date: Tue, 13 Aug 2024 10:03:50 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java In-Reply-To: References: Message-ID: <3w2xClKvpgiveQBx0qC02bdI4rVxvq12ZebDbHqZCNQ=.e749bd9e-0498-4b89-89f6-16e2f00ef1a6@github.com> On Sun, 30 Jun 2024 03:42:07 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [40e667c1](https://github.com/openjdk/jdk/commit/40e667c174269a73cd9b5612673c5e4b2293d6c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov. > > Thanks! Marked as reviewed by aph (Lead). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/531#pullrequestreview-2235107727 From sgehwolf at openjdk.org Tue Aug 13 10:37:54 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Aug 2024 10:37:54 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v7] In-Reply-To: References: Message-ID: On Mon, 24 Jun 2024 13:58:48 GMT, Andrew John Hughes wrote: >> The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user. >> >> 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build. >> >> ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set. >> >> However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code. >> >> We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped. >> >> This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system. >> >> With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms) >> >> During testing, we found we could not use the `EXTRA_` prefixed variables as they include flags for the target compiler on cross-compilation builds. To fix this, we split out new `HOST_` prefixed variables which include all the flags of the `EXTRA_` prefixed variables, bar the `--sysroot` options. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8281096 > - Separate host and target compiler flags > - Merge remote-tracking branch 'dev/master' into JDK-8281096 > - Print spec files in right workflow and use path to build directory > - Fix whitespace in yaml file > - Merge remote-tracking branch 'dev/master' into JDK-8281096 > - Print the spec.gmk and hotspot-spec.gmk files > - Temporarily enable debug logging for cross-compile build > - 8281096: Flags introduced by configure script are not passed to ADLC build Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/357#pullrequestreview-2235184716 From gdams at openjdk.org Tue Aug 13 11:46:18 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 13 Aug 2024 11:46:18 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v5] In-Reply-To: References: Message-ID: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: - Merge remote-tracking branch 'upstream/master' into freetype - move libfreetype to correct src directory - remove freetype from actions - and more changes - further required changes - Backport 58ff4ee8c4ec399528338b59eadea996110366a0 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/318/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=04 Stats: 172120 lines in 329 files changed: 166024 ins; 5731 del; 365 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From gdams at openjdk.org Tue Aug 13 11:46:18 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 13 Aug 2024 11:46:18 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v4] In-Reply-To: References: <0GHr4S0HzJRGkbPyQdB79OnrgmqwLE-1XM5oscR8r_Y=.b0329029-5602-4d09-beae-66d273496f29@github.com> Message-ID: <66ccFEQpNVCn-zKykNQVi6-fFfZeT7OE7SGcHktj-a0=.98b26db3-3a6b-4d65-8592-38772f8daee2@github.com> On Mon, 12 Aug 2024 17:34:29 GMT, Sergey Bylokhov wrote: >> Please keep this open > > @gdams do you have a chance to look at the merge-conflict? @mrserb I've resolved the merge conflicts. I'm slightly worried about the changes to `common/autoconf/generated-configure.sh` though. I've got `autoconf at 2.69` on my mac (installed using brew) but there might be a more specific version required? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2286042762 From gdams at openjdk.org Tue Aug 13 14:01:57 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 13 Aug 2024 14:01:57 GMT Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v3] In-Reply-To: References: Message-ID: <1Qu4B3-FEA4folbgGNO9n0R4eG7DFDWOuayEbPXjTik=.29167051-ca66-4aa6-a978-e60d69a8bc03@github.com> On Tue, 30 Jul 2024 12:35:11 GMT, George Adams wrote: >> LGTM. Thanks for fixing. > > @jerboaa I need to request another review please > @gdams Your change (at version [efe7e7a](https://github.com/openjdk/jdk8u-dev/commit/efe7e7a955a15ae168af67e759c0c1926dfa1d1f)) is now ready to be sponsored by a Committer. I am a committer ?? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2286328188 From duke at openjdk.org Tue Aug 13 14:01:56 2024 From: duke at openjdk.org (duke) Date: Tue, 13 Aug 2024 14:01:56 GMT Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v3] In-Reply-To: <6l1mmj3FM3vyAu6l9N_9apWfaD0YWBVOQpMqZwfAvtI=.abffbe6f-991d-4669-9696-af92be7b322b@github.com> References: <6l1mmj3FM3vyAu6l9N_9apWfaD0YWBVOQpMqZwfAvtI=.abffbe6f-991d-4669-9696-af92be7b322b@github.com> Message-ID: On Tue, 30 Jul 2024 15:16:12 GMT, George Adams wrote: >> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions. >> >> This will remove all warnings about deprecated Node.js versions > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > Update .github/workflows/submit.yml @gdams Your change (at version efe7e7a955a15ae168af67e759c0c1926dfa1d1f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2286324901 From gdams at openjdk.org Tue Aug 13 14:01:57 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 13 Aug 2024 14:01:57 GMT Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v3] In-Reply-To: <1Qu4B3-FEA4folbgGNO9n0R4eG7DFDWOuayEbPXjTik=.29167051-ca66-4aa6-a978-e60d69a8bc03@github.com> References: <1Qu4B3-FEA4folbgGNO9n0R4eG7DFDWOuayEbPXjTik=.29167051-ca66-4aa6-a978-e60d69a8bc03@github.com> Message-ID: <8uQeskIayRRPIBwRGkRehxDCfIEtCdj3pqZiNSVrZBM=.d55dba2e-1914-4aa2-8361-1ef9dcf04d31@github.com> On Tue, 13 Aug 2024 13:58:30 GMT, George Adams wrote: >> @jerboaa I need to request another review please > >> @gdams Your change (at version [efe7e7a](https://github.com/openjdk/jdk8u-dev/commit/efe7e7a955a15ae168af67e759c0c1926dfa1d1f)) is now ready to be sponsored by a Committer. > > I am a committer ?? > @gdams Only [Committers](https://openjdk.org/bylaws#committer) are allowed to sponsor changes. bot seems broken, @jerboaa would you mind doing the honours? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2286330650 From sgehwolf at openjdk.org Tue Aug 13 14:37:55 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Aug 2024 14:37:55 GMT Subject: [jdk8u-dev] RFR: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" In-Reply-To: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> References: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> Message-ID: <_is0kEy5o5I8nlydPJ6w1D3YnrvbGsIYKevYq_S8BiQ=.86a07f87-7d9a-43a4-b723-a135a10fca20@github.com> On Wed, 10 Jul 2024 10:31:10 GMT, Adam Farley wrote: > ?lls: 51. After deopt 50" > > Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1. > > Backported manually from the jdk9u commit below: > 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/545#pullrequestreview-2235751173 From sgehwolf at openjdk.org Tue Aug 13 14:55:12 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Aug 2024 14:55:12 GMT Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v3] In-Reply-To: <8uQeskIayRRPIBwRGkRehxDCfIEtCdj3pqZiNSVrZBM=.d55dba2e-1914-4aa2-8361-1ef9dcf04d31@github.com> References: <1Qu4B3-FEA4folbgGNO9n0R4eG7DFDWOuayEbPXjTik=.29167051-ca66-4aa6-a978-e60d69a8bc03@github.com> <8uQeskIayRRPIBwRGkRehxDCfIEtCdj3pqZiNSVrZBM=.d55dba2e-1914-4aa2-8361-1ef9dcf04d31@github.com> Message-ID: <8QdnTzzJorMDE5GmOG7qlQOokFOHjoBnx638gMWIfY4=.b0b93a3e-bc33-4620-a2c8-763e15914999@github.com> On Tue, 13 Aug 2024 13:59:32 GMT, George Adams wrote: > > @gdams Only [Committers](https://openjdk.org/bylaws#committer) are allowed to sponsor changes. > > bot seems broken, @jerboaa would you mind doing the honours? Looking at the [census](https://openjdk.org/census#gdams) you'll find that you are an jdk-updates project committer. This is project [JDK 8 Update Releases](https://openjdk.org/projects/jdk8u/). So the bot has it correct. I'll sponsor it. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2286453240 From sgehwolf at openjdk.org Tue Aug 13 14:59:00 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 13 Aug 2024 14:59:00 GMT Subject: [jdk8u-dev] RFR: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 [v3] In-Reply-To: <6l1mmj3FM3vyAu6l9N_9apWfaD0YWBVOQpMqZwfAvtI=.abffbe6f-991d-4669-9696-af92be7b322b@github.com> References: <6l1mmj3FM3vyAu6l9N_9apWfaD0YWBVOQpMqZwfAvtI=.abffbe6f-991d-4669-9696-af92be7b322b@github.com> Message-ID: On Tue, 30 Jul 2024 15:16:12 GMT, George Adams wrote: >> This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions. >> >> This will remove all warnings about deprecated Node.js versions > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > Update .github/workflows/submit.yml GHA failures are unrelated to this patch. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/546#issuecomment-2286460321 From gdams at openjdk.org Tue Aug 13 14:59:01 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 13 Aug 2024 14:59:01 GMT Subject: [jdk8u-dev] Integrated: 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 In-Reply-To: References: Message-ID: On Fri, 12 Jul 2024 10:51:34 GMT, George Adams wrote: > This backport is written from scratch, as GHA workflows in jdk8u differ significantly from newer jdk versions. > > This will remove all warnings about deprecated Node.js versions This pull request has now been integrated. Changeset: 047b08a8 Author: George Adams URL: https://git.openjdk.org/jdk8u-dev/commit/047b08a891d837efb925448b6334679f772ef0e5 Stats: 82 lines in 1 file changed: 5 ins; 0 del; 77 mod 8324723: GHA: Upgrade some actions to avoid deprecated Node 16 8315863: [GHA] Update checkout action to use v4 Reviewed-by: sgehwolf, zzambers Backport-of: f2565a6c6f26e84d8e5eede39c0f3a50be5d579f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/546 From mbalao at openjdk.org Tue Aug 13 15:00:56 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 13 Aug 2024 15:00:56 GMT Subject: [jdk8u-dev] RFR: 8152207: Perform array bound checks while getting a length of bytecode instructions [v2] In-Reply-To: References: Message-ID: On Thu, 4 Jul 2024 21:31:54 GMT, Martin Balao wrote: >> Hi, >> >> I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date. >> >> Thanks, >> Martin.- > > Martin Balao has updated the pull request incrementally with one additional commit since the last revision: > > 8152207: JDK changes The GHA failures look unrelated to this change ?has to do with certificates apparently. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/527#issuecomment-2286463131 From mbalao at openjdk.org Tue Aug 13 15:00:57 2024 From: mbalao at openjdk.org (Martin Balao) Date: Tue, 13 Aug 2024 15:00:57 GMT Subject: [jdk8u-dev] Integrated: 8152207: Perform array bound checks while getting a length of bytecode instructions In-Reply-To: References: Message-ID: On Wed, 26 Jun 2024 01:42:00 GMT, Martin Balao wrote: > Hi, > > I'd like to propose a backport of 8152207 for 8u as this release is affected. The JDK main line patch applies almost cleanly, except for the file path and the copyright date. > > Thanks, > Martin.- This pull request has now been integrated. Changeset: d4adbe33 Author: Martin Balao URL: https://git.openjdk.org/jdk8u-dev/commit/d4adbe339c3dd09a7f431da2c909b03560c6579e Stats: 11 lines in 2 files changed: 6 ins; 0 del; 5 mod 8152207: Perform array bound checks while getting a length of bytecode instructions Reviewed-by: sgehwolf, phh Backport-of: 68c8a74fbe25918ec50711ce10eff65afcc73b93 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/527 From duke at openjdk.org Tue Aug 13 15:16:11 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 13 Aug 2024 15:16:11 GMT Subject: [jdk8u] RFR: 8305400: ISO 4217 Amendment 175 Update Message-ID: backport 7cf24d1c0 ------------- Commit messages: - backport 7cf24d1c0 Changes: https://git.openjdk.org/jdk8u/pull/59/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=59&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305400 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk8u/pull/59.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/59/head:pull/59 PR: https://git.openjdk.org/jdk8u/pull/59 From yan at openjdk.org Tue Aug 13 15:17:17 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Tue, 13 Aug 2024 15:17:17 GMT Subject: [jdk8u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() Message-ID: This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker. The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues. There will be a second fix in this series, JDK-8278794. ------------- Commit messages: - Backport 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f Changes: https://git.openjdk.org/jdk8u-dev/pull/558/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=558&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8193682 Stats: 257 lines in 4 files changed: 189 ins; 25 del; 43 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/558.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/558/head:pull/558 PR: https://git.openjdk.org/jdk8u-dev/pull/558 From duke at openjdk.org Tue Aug 13 15:46:58 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 13 Aug 2024 15:46:58 GMT Subject: [jdk8u] Withdrawn: 8305400: ISO 4217 Amendment 175 Update In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 15:10:55 GMT, Karm Michal Babacek wrote: > backport 7cf24d1c0 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u/pull/59 From duke at openjdk.org Tue Aug 13 16:51:34 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 13 Aug 2024 16:51:34 GMT Subject: [jdk8u] RFR: 8305400 8321480 8334653 ISO 4217 Amendment 144->177 Update Message-ID: backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update ------------- Commit messages: - backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update Changes: https://git.openjdk.org/jdk8u/pull/60/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=60&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305400 Stats: 44 lines in 7 files changed: 10 ins; 1 del; 33 mod Patch: https://git.openjdk.org/jdk8u/pull/60.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/60/head:pull/60 PR: https://git.openjdk.org/jdk8u/pull/60 From duke at openjdk.org Tue Aug 13 16:56:58 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 13 Aug 2024 16:56:58 GMT Subject: [jdk8u] RFR: 8305400 8321480 8334653 ISO 4217 Amendment 144->177 Update In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 16:45:47 GMT, Karm Michal Babacek wrote: > backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update > backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update Wrong repo ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/60#issuecomment-2286701522 From duke at openjdk.org Tue Aug 13 16:56:58 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 13 Aug 2024 16:56:58 GMT Subject: [jdk8u] Withdrawn: 8305400 8321480 8334653 ISO 4217 Amendment 144->177 Update In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 16:45:47 GMT, Karm Michal Babacek wrote: > backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update > backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u/pull/60 From duke at openjdk.org Tue Aug 13 17:08:23 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 13 Aug 2024 17:08:23 GMT Subject: [jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update Message-ID: backport 8c243a3 JDK11 ------------- Commit messages: - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update Changes: https://git.openjdk.org/jdk8u-dev/pull/559/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=559&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8305400 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/559.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/559/head:pull/559 PR: https://git.openjdk.org/jdk8u-dev/pull/559 From abakhtin at openjdk.org Tue Aug 13 17:11:00 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 13 Aug 2024 17:11:00 GMT Subject: [jdk8u-dev] Integrated: 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials In-Reply-To: References: Message-ID: On Mon, 15 Jul 2024 16:04:08 GMT, Alexey Bakhtin wrote: > Almost clean backport except for /jdk/test/ProblemList.txt (the tests were not excluded in JDK8) > > The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. > > Requires follow-up JDK-8205653 This pull request has now been integrated. Changeset: 09bab6e4 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk8u-dev/commit/09bab6e4c31531975ab6461832d4618dc9759ca9 Stats: 13 lines in 4 files changed: 11 ins; 0 del; 2 mod 8145919: sun/management/jmxremote/bootstrap/RmiSslBootstrapTest failed with Connection failed for no credentials Reviewed-by: phh Backport-of: ee5b32591130f560b90ec2cea7ab40d0612ecb8d ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/547 From abakhtin at openjdk.org Tue Aug 13 17:15:28 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 13 Aug 2024 17:15:28 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure [v2] In-Reply-To: References: Message-ID: > Follow-up fix for JDK-8145919 > Almost clean backport except for /jdk/test/ProblemList.txt > > The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/548/files - new: https://git.openjdk.org/jdk8u-dev/pull/548/files/cd915175..cd915175 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=548&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=548&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/548.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/548/head:pull/548 PR: https://git.openjdk.org/jdk8u-dev/pull/548 From serb at openjdk.org Tue Aug 13 17:35:58 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 13 Aug 2024 17:35:58 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v4] In-Reply-To: References: <0GHr4S0HzJRGkbPyQdB79OnrgmqwLE-1XM5oscR8r_Y=.b0329029-5602-4d09-beae-66d273496f29@github.com> Message-ID: On Mon, 12 Aug 2024 17:34:29 GMT, Sergey Bylokhov wrote: >> Please keep this open > > @gdams do you have a chance to look at the merge-conflict? > @mrserb I've resolved the merge conflicts. I'm slightly worried about the changes to `common/autoconf/generated-configure.sh` though. I've got `autoconf at 2.69` on my mac (installed using brew) but there might be a more specific version required? I had a similar issue some time ago https://github.com/openjdk/jdk8u-dev/pull/413#issuecomment-1951600088, at that time I also run 2.69 on macos. Solved that by running autoconf on some linux hosts. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2286773269 From abakhtin at openjdk.org Tue Aug 13 18:45:21 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 13 Aug 2024 18:45:21 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure [v3] In-Reply-To: References: Message-ID: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> > Follow-up fix for JDK-8145919 > Almost clean backport except for /jdk/test/ProblemList.txt > > The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge master - Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531 - Fix keystore and trustore files - Backport ee5b32591130f560b90ec2cea7ab40d0612ecb8d ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/548/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=548&range=02 Stats: 12 lines in 5 files changed: 6 ins; 1 del; 5 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/548.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/548/head:pull/548 PR: https://git.openjdk.org/jdk8u-dev/pull/548 From gdams at openjdk.org Tue Aug 13 20:41:35 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 13 Aug 2024 20:41:35 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v6] In-Reply-To: References: Message-ID: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: - rerun autoconf - Merge remote-tracking branch 'upstream/master' into freetype - Merge remote-tracking branch 'upstream/master' into freetype - move libfreetype to correct src directory - remove freetype from actions - and more changes - further required changes - Backport 58ff4ee8c4ec399528338b59eadea996110366a0 ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/318/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=05 Stats: 172107 lines in 329 files changed: 166024 ins; 5719 del; 364 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From gdams at openjdk.org Tue Aug 13 20:41:36 2024 From: gdams at openjdk.org (George Adams) Date: Tue, 13 Aug 2024 20:41:36 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v4] In-Reply-To: References: <0GHr4S0HzJRGkbPyQdB79OnrgmqwLE-1XM5oscR8r_Y=.b0329029-5602-4d09-beae-66d273496f29@github.com> Message-ID: On Tue, 13 Aug 2024 17:33:25 GMT, Sergey Bylokhov wrote: >> @gdams do you have a chance to look at the merge-conflict? > >> @mrserb I've resolved the merge conflicts. I'm slightly worried about the changes to `common/autoconf/generated-configure.sh` though. I've got `autoconf at 2.69` on my mac (installed using brew) but there might be a more specific version required? > > I had a similar issue some time ago https://github.com/openjdk/jdk8u-dev/pull/413#issuecomment-1951600088, at that time I also run 2.69 on macos. Solved that by running autoconf on some linux hosts. > > @mrserb I've resolved the merge conflicts. I'm slightly worried about the changes to `common/autoconf/generated-configure.sh` though. I've got `autoconf at 2.69` on my mac (installed using brew) but there might be a more specific version required? > > I had a similar issue some time ago [#413 (comment)](https://github.com/openjdk/jdk8u-dev/pull/413#issuecomment-1951600088), at that time I also run 2.69 on macos. Solved that by running autoconf on some linux hosts. that looks better, I've compiled it locally with the patch applied and the generated configure looks correct now ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2287096974 From abakhtin at openjdk.org Tue Aug 13 20:43:53 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 13 Aug 2024 20:43:53 GMT Subject: [jdk8u-dev] RFR: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure [v3] In-Reply-To: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> References: <0WHbqcbfHYi2WsyIrsGgBzzYL_UBCDFIyw_58nblRUk=.b6828afd-17ed-4731-9f45-b59d95b1b675@github.com> Message-ID: On Tue, 13 Aug 2024 18:45:21 GMT, Alexey Bakhtin wrote: >> Follow-up fix for JDK-8145919 >> Almost clean backport except for /jdk/test/ProblemList.txt >> >> The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. > > Alexey Bakhtin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge master > - Backport 136331b7f064d6d61abf3c09ba7106dc9a22a531 > - Fix keystore and trustore files > - Backport ee5b32591130f560b90ec2cea7ab40d0612ecb8d CI failures are not related to the changes in this PR ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/548#issuecomment-2287101843 From serb at openjdk.org Tue Aug 13 20:54:59 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 13 Aug 2024 20:54:59 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v6] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:41:35 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: > > - rerun autoconf > - Merge remote-tracking branch 'upstream/master' into freetype > - Merge remote-tracking branch 'upstream/master' into freetype > - move libfreetype to correct src directory > - remove freetype from actions > - and more changes > - further required changes > - Backport 58ff4ee8c4ec399528338b59eadea996110366a0 make/copy/Copy-java.desktop.gmk line 32: > 30: ################################################################################ > 31: > 32: $(CONF_DST_DIR)/sound.properties: $(TOPDIR)/src/java.desktop/share/conf/sound.properties "java.desktop" module is used. make/lib/Awt2dLibraries.gmk line 1: > 1: # looks like this file duplicates the jdk/make/lib/Awt2dLibraries.gmk? ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1715913531 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1715912892 From yan at openjdk.org Wed Aug 14 06:53:55 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 14 Aug 2024 06:53:55 GMT Subject: [jdk8u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 15:11:57 GMT, Yuri Nesterenko wrote: > This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker. > > The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues. > > There will be a second fix in this series, JDK-8278794. Most pre-submit failures are unrelated, even build failures on Windows x86 -- but these are my debt from July release, 8320097, isinf/isnan not sufficiently covered in this case. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/558#issuecomment-2287983608 From gdams at openjdk.org Wed Aug 14 08:05:57 2024 From: gdams at openjdk.org (George Adams) Date: Wed, 14 Aug 2024 08:05:57 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v6] In-Reply-To: References: Message-ID: <27uUgHqrMA3qM3aCzXm4ITE2SOj9B_eoZmCbDP-359A=.18d14da7-30db-450e-8c05-f983390b9df5@github.com> On Tue, 13 Aug 2024 20:51:33 GMT, Sergey Bylokhov wrote: >> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: >> >> - rerun autoconf >> - Merge remote-tracking branch 'upstream/master' into freetype >> - Merge remote-tracking branch 'upstream/master' into freetype >> - move libfreetype to correct src directory >> - remove freetype from actions >> - and more changes >> - further required changes >> - Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > make/lib/Awt2dLibraries.gmk line 1: > >> 1: # > > looks like this file duplicates the jdk/make/lib/Awt2dLibraries.gmk? correct, I'll remove it ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1716481096 From gdams at openjdk.org Wed Aug 14 08:11:22 2024 From: gdams at openjdk.org (George Adams) Date: Wed, 14 Aug 2024 08:11:22 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v6] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 20:52:15 GMT, Sergey Bylokhov wrote: >> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits: >> >> - rerun autoconf >> - Merge remote-tracking branch 'upstream/master' into freetype >> - Merge remote-tracking branch 'upstream/master' into freetype >> - move libfreetype to correct src directory >> - remove freetype from actions >> - and more changes >> - further required changes >> - Backport 58ff4ee8c4ec399528338b59eadea996110366a0 > > make/copy/Copy-java.desktop.gmk line 32: > >> 30: ################################################################################ >> 31: >> 32: $(CONF_DST_DIR)/sound.properties: $(TOPDIR)/src/java.desktop/share/conf/sound.properties > > "java.desktop" module is used. updated PTAL ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1716486523 From gdams at openjdk.org Wed Aug 14 08:11:21 2024 From: gdams at openjdk.org (George Adams) Date: Wed, 14 Aug 2024 08:11:21 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v7] In-Reply-To: References: Message-ID: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request incrementally with one additional commit since the last revision: changes from review ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/318/files - new: https://git.openjdk.org/jdk8u-dev/pull/318/files/0d2a0045..59602192 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=05-06 Stats: 1132 lines in 2 files changed: 0 ins; 1130 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From gdams at openjdk.org Wed Aug 14 08:16:36 2024 From: gdams at openjdk.org (George Adams) Date: Wed, 14 Aug 2024 08:16:36 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v8] In-Reply-To: References: Message-ID: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request incrementally with one additional commit since the last revision: remove make/conf/jib-profiles.js ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/318/files - new: https://git.openjdk.org/jdk8u-dev/pull/318/files/59602192..40869c5e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=07 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=06-07 Stats: 1133 lines in 1 file changed: 0 ins; 1133 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From gdams at openjdk.org Wed Aug 14 08:20:53 2024 From: gdams at openjdk.org (George Adams) Date: Wed, 14 Aug 2024 08:20:53 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v6] In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 08:08:00 GMT, George Adams wrote: >> make/copy/Copy-java.desktop.gmk line 32: >> >>> 30: ################################################################################ >>> 31: >>> 32: $(CONF_DST_DIR)/sound.properties: $(TOPDIR)/src/java.desktop/share/conf/sound.properties >> >> "java.desktop" module is used. > > updated PTAL Actually I wonder if this entire file is required at all, it doesn't appear to be used in JDK8 ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1716500025 From zzambers at openjdk.org Wed Aug 14 12:10:23 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 14 Aug 2024 12:10:23 GMT Subject: [jdk8u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken Message-ID: Backport fixes code, which removes unnecessary artifacts (jdk builds), as it longer works after [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723). **Notes:** - changeset is quite different form newer JDKs, because there are significant differences to GHA code - in jdk 8 bundle artifacts use transient prefix instead of bundle - `Display current artifacts` and `Delete transient artifacts` steps were updated to use documented REST API - I switched last step to use new `actions/upload-artifact/merge at v4`, which allows to turn last 3 steps into one **Testing:** - GHA: OK - only single artifacts with resulst of all ran tests (checked) is produced, as expected on 8 - windows x86 build failures are unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/555 - macos test failures are unrelates, see: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257 ------------- Commit messages: - Backport 98562166e4a4c8921709014423c6cbc993aa0d97 Changes: https://git.openjdk.org/jdk8u-dev/pull/560/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=560&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8336928 Stats: 41 lines in 1 file changed: 3 ins; 14 del; 24 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/560.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/560/head:pull/560 PR: https://git.openjdk.org/jdk8u-dev/pull/560 From duke at openjdk.org Wed Aug 14 13:41:17 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Wed, 14 Aug 2024 13:41:17 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update Message-ID: backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update depends on #559 ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/559 Commit messages: - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update Changes: https://git.openjdk.org/jdk8u-dev/pull/561/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=561&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8321480 Stats: 28 lines in 5 files changed: 8 ins; 0 del; 20 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/561.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/561/head:pull/561 PR: https://git.openjdk.org/jdk8u-dev/pull/561 From duke at openjdk.org Wed Aug 14 13:58:21 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Wed, 14 Aug 2024 13:58:21 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update Message-ID: backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update depends on #561 ------------- Depends on: https://git.openjdk.org/jdk8u-dev/pull/561 Commit messages: - backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update Changes: https://git.openjdk.org/jdk8u-dev/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=562&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8334653 Stats: 21 lines in 6 files changed: 2 ins; 1 del; 18 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/562.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/562/head:pull/562 PR: https://git.openjdk.org/jdk8u-dev/pull/562 From andrew at openjdk.org Wed Aug 14 15:37:52 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 14 Aug 2024 15:37:52 GMT Subject: [jdk8u-dev] Integrated: 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097 In-Reply-To: References: Message-ID: On Sat, 27 Jul 2024 20:40:45 GMT, Andrew John Hughes wrote: > Attempt to fix 8337312 using the same logic from `jdk/src/share/native/sun/java2d/cmm/lcms/lcms2_internal.h`: > > ~~~ > /// Properly define some macros to accommodate > /// older MSVC versions. > # if defined(_MSC_VER) && _MSC_VER <= 1700 > #include > #define isnan _isnan > #define isinf(x) (!_finite((x))) > # endif > ~~~ This pull request has now been integrated. Changeset: b4fc8e71 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/b4fc8e711c5953823e687f8cc133aac5e8fdd577 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod 8337312: [8u] Windows x86 VS2010 build broken by JDK-8320097 Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/555 From andrew at openjdk.org Wed Aug 14 15:53:01 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 14 Aug 2024 15:53:01 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v7] In-Reply-To: References: Message-ID: On Mon, 24 Jun 2024 13:58:48 GMT, Andrew John Hughes wrote: >> The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user. >> >> 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build. >> >> ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set. >> >> However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code. >> >> We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped. >> >> This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system. >> >> With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms) >> >> During testing, we found we could not use the `EXTRA_` prefixed variables as they include flags for the target compiler on cross-compilation builds. To fix this, we split out new `HOST_` prefixed variables which include all the flags of the `EXTRA_` prefixed variables, bar the `--sysroot` options. > > Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: > > - Merge remote-tracking branch 'dev/master' into JDK-8281096 > - Separate host and target compiler flags > - Merge remote-tracking branch 'dev/master' into JDK-8281096 > - Print spec files in right workflow and use path to build directory > - Fix whitespace in yaml file > - Merge remote-tracking branch 'dev/master' into JDK-8281096 > - Print the spec.gmk and hotspot-spec.gmk files > - Temporarily enable debug logging for cross-compile build > - 8281096: Flags introduced by configure script are not passed to ADLC build > I have done some additional testing: > > * I [tested](https://github.com/zzambers/jdk8u-dev/actions/runs/9664993178) this, with GHA workflows updated to ubuntu-22.04 on top (+ [fix for jdi test](https://github.com/openjdk/jdk8u-dev/pull/497)). This is because, I have recently seen build failures on some archs, when I [tried to update GHA testing to ubuntu-22.04](https://github.com/openjdk/jdk8u-dev/pull/491#issue-2281128235), while looking at another issue. There are no build failures with this changeset (1 test failure/error on linux x86 seems unrelated). > > * I have also tried to do build in rhel-9 VM (gcc-11.4.1). It passed ADLC build (unlike unpatched version). Build later failed on another (separate) error in `hotspot/src/share/vm/opto/type.cpp` (see [8329826: GCC 12 reports some compiler error when building jdk8 #479 (comment)](https://github.com/openjdk/jdk8u-dev/pull/479#issuecomment-2058078166)). If I also modified `type.cpp` (based on that PR), build passed. > > > Change looks good. (works for me) Thanks for testing. Can you give me more details on what kind of build failed in `type.cpp` (e.g. release/slowdebug/fastdebug)? With just this patch, it builds for me on GCC 13. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2289157265 From andrew at openjdk.org Wed Aug 14 15:53:01 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 14 Aug 2024 15:53:01 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v7] In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 10:34:57 GMT, Severin Gehwolf wrote: >> Andrew John Hughes has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision: >> >> - Merge remote-tracking branch 'dev/master' into JDK-8281096 >> - Separate host and target compiler flags >> - Merge remote-tracking branch 'dev/master' into JDK-8281096 >> - Print spec files in right workflow and use path to build directory >> - Fix whitespace in yaml file >> - Merge remote-tracking branch 'dev/master' into JDK-8281096 >> - Print the spec.gmk and hotspot-spec.gmk files >> - Temporarily enable debug logging for cross-compile build >> - 8281096: Flags introduced by configure script are not passed to ADLC build > > Marked as reviewed by sgehwolf (Reviewer). Thanks for the approval, @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2289157978 From andrew at openjdk.org Wed Aug 14 15:53:01 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 14 Aug 2024 15:53:01 GMT Subject: [jdk8u-dev] Integrated: 8281096: Flags introduced by configure script are not passed to ADLC build In-Reply-To: References: Message-ID: On Wed, 23 Aug 2023 03:58:10 GMT, Andrew John Hughes wrote: > The 8u configure script defines compiler flags in `EXTRA_CFLAGS`, `EXTRA_LDFLAGS` and `EXTRA_ASFLAGS`. Some are added by configure tests, while others are taken directly from corresponding options passed by the user. > > 8u still use the legacy HotSpot build system which is not fully integrated with the autoconf system. Variables defined by configure thus have to be explicitly passed down to the separate HotSpot build. > > ADLC is a tool used at build-time and so the flags it uses don't impact on the end product. So, for a long time, it has been ignoring these flags defined by configure and using just its own minimal set. > > However, with newer compilers, this means that the code is compiled to a newer version of the C++ standard, as the default has changed in GCC 6 and later (see [JDK-8151841](https://bugs.openjdk.org/browse/JDK-8151841)). With the latest versions of GCC (11 and 12), this actually leads to build failures due to the use of 'register' (GCC 11) and the way comments are used (GCC 12) in the code. > > We should fix the ADLC build to use the same flags as the rest of the build. The impact should be negligible, given the same flags are already used in the code that is actually shipped. > > This does not affect 9+ where HotSpot's build system has been replaced with full integration in the autoconf system. > > With this change, 8u can be built with GCC 11 on GNU/Linux. I'd appreciate testing on other platforms, particularly those not covered by GHA (Solaris, AIX - @adamfarley, @sxa & @deepa181 who have provided previous fixes for these platforms) > > During testing, we found we could not use the `EXTRA_` prefixed variables as they include flags for the target compiler on cross-compilation builds. To fix this, we split out new `HOST_` prefixed variables which include all the flags of the `EXTRA_` prefixed variables, bar the `--sysroot` options. This pull request has now been integrated. Changeset: 4106121e Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/4106121e0ae42d644e45c6eab9037874110ed670 Stats: 184 lines in 8 files changed: 63 ins; 14 del; 107 mod 8281096: Flags introduced by configure script are not passed to ADLC build Reviewed-by: stuefe, zzambers, sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/357 From andrew at openjdk.org Wed Aug 14 16:22:51 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 14 Aug 2024 16:22:51 GMT Subject: [jdk8u-dev] RFR: 8338144: [8u] Remove duplicate license files In-Reply-To: References: Message-ID: On Mon, 12 Aug 2024 20:47:23 GMT, Paul Hohensee wrote: >> This removes the duplicate copies of the three licensing files - `LICENSE`, `ASSEMBLY_EXCEPTION` and `THIRD_PARTY_README` - from the top of each of the old subrepositories - `corba`, `jaxp`, `jaxws`, `langtools`, `jdk`, `hotspot` and `nashorn`. The `Images.gmk` makefile under the `jdk` tree has to be updated to use the top-level versions rather than the `jdk` ones. > > Marked as reviewed by phh (Reviewer). Thanks for the review, @phohensee ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/557#issuecomment-2289233515 From zzambers at openjdk.org Wed Aug 14 16:25:57 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Wed, 14 Aug 2024 16:25:57 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v7] In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 15:48:09 GMT, Andrew John Hughes wrote: > > I have done some additional testing: > > ``` > > * I [tested](https://github.com/zzambers/jdk8u-dev/actions/runs/9664993178) this, with GHA workflows updated to ubuntu-22.04 on top (+ [fix for jdi test](https://github.com/openjdk/jdk8u-dev/pull/497)). This is because, I have recently seen build failures on some archs, when I [tried to update GHA testing to ubuntu-22.04](https://github.com/openjdk/jdk8u-dev/pull/491#issue-2281128235), while looking at another issue. There are no build failures with this changeset (1 test failure/error on linux x86 seems unrelated). > > > > * I have also tried to do build in rhel-9 VM (gcc-11.4.1). It passed ADLC build (unlike unpatched version). Build later failed on another (separate) error in `hotspot/src/share/vm/opto/type.cpp` (see [8329826: GCC 12 reports some compiler error when building jdk8 #479 (comment)](https://github.com/openjdk/jdk8u-dev/pull/479#issuecomment-2058078166)). If I also modified `type.cpp` (based on that PR), build passed. > > ``` > > > > > > > > > > > > > > > > > > > > > > > > Change looks good. (works for me) > > Thanks for testing. Can you give me more details on what kind of build failed in `type.cpp` (e.g. release/slowdebug/fastdebug)? With just this patch, it builds for me on GCC 13. I can still reproduce issue with `type.cpp` on rhel-9, with just most default build (just boot jdk set). Gcc version is 11.4.1 (system one). Errors look following way (see [jdk8-type.cpp-error.log](https://github.com/user-attachments/files/16615930/jdk8-type.cpp-error.log) for full configure/make log): In constructor ?TypeOopPtr::TypeOopPtr(Type::TYPES, TypePtr::PTR, ciKlass*, bool, ciObject*, int, int, const TypeOopPtr*, int)?, inlined from ?TypeAryPtr::TypeAryPtr(TypePtr::PTR, ciObject*, const TypeAry*, ciKlass*, bool, int, int, bool, const TypeOopPtr*, int)? at /home/tester/jdk8u-dev/hotspot/src/share/vm/opto/type.hpp:1094:39, inlined from ?static const TypeAryPtr* TypeAryPtr::make(TypePtr::PTR, const TypeAry*, ciKlass*, bool, int, int, const TypeOopPtr*, int)? at /home/tester/jdk8u-dev/hotspot/src/share/vm/opto/type.cpp:3745:115: /home/tester/jdk8u-dev/hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null [-Werror=nonnull] 2556 | ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass(); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~ In file included from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciCallSite.hpp:28, from /home/tester/jdk8u-dev/hotspot/src/share/vm/code/dependencies.hpp:28, from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciEnv.hpp:32, from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciUtilities.hpp:28, from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciNullObject.hpp:30, from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciConstant.hpp:29, from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciArray.hpp:29, from /home/tester/jdk8u-dev/hotspot/src/share/vm/precompiled/precompiled.hpp:33: /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciInstance.hpp: In function ?static const TypeAryPtr* TypeAryPtr::make(TypePtr::PTR, const TypeAry*, ciKlass*, bool, int, int, const TypeOopPtr*, int)?: /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciInstance.hpp:68:12: note: in a call to non-static member function ?ciKlass* ciInstance::java_lang_Class_klass()? 68 | ciKlass* java_lang_Class_klass(); | ^~~~~~~~~~~~~~~~~~~~~ ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2289238973 From serb at openjdk.org Wed Aug 14 17:16:51 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 14 Aug 2024 17:16:51 GMT Subject: [jdk8u-dev] RFR: 8338144: [8u] Remove duplicate license files In-Reply-To: References: Message-ID: On Sat, 10 Aug 2024 12:41:52 GMT, Andrew John Hughes wrote: > This removes the duplicate copies of the three licensing files - `LICENSE`, `ASSEMBLY_EXCEPTION` and `THIRD_PARTY_README` - from the top of each of the old subrepositories - `corba`, `jaxp`, `jaxws`, `langtools`, `jdk`, `hotspot` and `nashorn`. The `Images.gmk` makefile under the `jdk` tree has to be updated to use the top-level versions rather than the `jdk` ones. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/557#pullrequestreview-2238767174 From serb at openjdk.org Wed Aug 14 20:49:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 14 Aug 2024 20:49:55 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v6] In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 08:18:16 GMT, George Adams wrote: >> updated PTAL > > Actually I wonder if this entire file is required at all, it doesn't appear to be used in JDK8 right, I think all changes(the new files) in the "TOPDIR/make" folder are unnecessary ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1717532231 From serb at openjdk.org Thu Aug 15 00:56:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 00:56:55 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v8] In-Reply-To: References: Message-ID: <8hnGhBU-xGIWC-JhlDjef_mfaVrq6T3vF850cq7BiAU=.9a1fcd6f-2fb1-4ef4-8823-f226f32d59df@github.com> On Wed, 14 Aug 2024 08:16:36 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > remove make/conf/jib-profiles.js I did a quick test on macOS. If the "libfreetype.dylib" is deleted from some old jdk8 build(or jdk-21) the next exception is occurred for the font demo: >./jdk-8/bin/java -jar ./build/macosx-x86_64-normal-server-release/images/j2sdk-image/demo/jfc/Font2DTest/Font2DTest.jar Exception in thread "main" java.lang.UnsatisfiedLinkError: /Users/openjdk/jdk8u-dev/jdk-8/jre/lib/libfontmanager.dylib: dlopen(/Users/openjdk/jdk8u-dev/jdk-8/jre/lib/libfontmanager.dylib, 0x0001): Library not loaded: @rpath/libfreetype.dylib.6 Referenced from: /Users/openjdk/jdk8u-dev/jdk-8/jre/lib/libfontmanager.dylib Reason: tried: '/Users/openjdk/jdk8u-dev/jdk-8/jre/lib/./libfreetype.dylib.6' (no such file), '/Users/openjdk/jdk8u-dev/jdk-8/jre/lib/./libfreetype.dylib.6' (no such file), '/Users/openjdk/jdk8u-dev/jdk-8/jre/lib/server/./libfreetype.dylib.6' (no such file), '/Users/openjdk/jdk8u-dev/jdk-8/jre/lib/server/../libfreetype.dylib.6' (no such file), '/Users/openjdk/jdk8u-dev/jdk-8/bin/./libfreetype.dylib.6' (no such file), '/usr/lib/libfreetype.dylib.6' (no such file, not in dyld cache) at java.lang.ClassLoader$NativeLibrary.load(Native Method) at java.lang.ClassLoader.loadLibrary0(ClassLoader.java:1934) at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1838) at java.lang.Runtime.loadLibrary0(Runtime.java:871) at java.lang.System.loadLibrary(System.java:1124) at sun.lwawt.macosx.LWCToolkit$1.run(LWCToolkit.java:93) at sun.lwawt.macosx.LWCToolkit$1.run(LWCToolkit.java:80) at java.security.AccessController.doPrivileged(Native Method) at sun.lwawt.macosx.LWCToolkit.(LWCToolkit.java:79) .... at java.awt.Toolkit.getDefaultToolkit(Toolkit.java:854) .... at Font2DTest.main(Font2DTest.java:1031) But If I delete the "libfreetype.dylib" from the build after this patch the demo works fine. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2290179354 From serb at openjdk.org Thu Aug 15 01:52:56 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 01:52:56 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v8] In-Reply-To: <8hnGhBU-xGIWC-JhlDjef_mfaVrq6T3vF850cq7BiAU=.9a1fcd6f-2fb1-4ef4-8823-f226f32d59df@github.com> References: <8hnGhBU-xGIWC-JhlDjef_mfaVrq6T3vF850cq7BiAU=.9a1fcd6f-2fb1-4ef4-8823-f226f32d59df@github.com> Message-ID: On Thu, 15 Aug 2024 00:54:11 GMT, Sergey Bylokhov wrote: > But If I delete the "libfreetype.dylib" from the build after this patch the demo works fine. Using "DYLD_PRINT_LIBRARIES=YES" traced that the "Homebrew" version of freetype is loaded. it is unclear why this version is not loaded in case of jdk-21. @rpath looks the same. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2290324979 From serb at openjdk.org Thu Aug 15 02:07:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 02:07:55 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v8] In-Reply-To: References: <8hnGhBU-xGIWC-JhlDjef_mfaVrq6T3vF850cq7BiAU=.9a1fcd6f-2fb1-4ef4-8823-f226f32d59df@github.com> Message-ID: On Thu, 15 Aug 2024 01:49:49 GMT, Sergey Bylokhov wrote: > Using "DYLD_PRINT_LIBRARIES=YES" traced that the "Homebrew" version of freetype is loaded. it is unclear why this version is not loaded in case of jdk-21. @rpath looks the same. nevermind seems that in case of "macos+Homebrew" the jdk-21 is affected as well but only if I build jdk locally. tested on windows and works fine. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2290362523 From gdams at openjdk.org Thu Aug 15 07:23:27 2024 From: gdams at openjdk.org (George Adams) Date: Thu, 15 Aug 2024 07:23:27 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v6] In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 20:47:35 GMT, Sergey Bylokhov wrote: >> Actually I wonder if this entire file is required at all, it doesn't appear to be used in JDK8 > > right, I think all changes(the new files) in the "TOPDIR/make" folder are unnecessary agreed, I've removed all those changes ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1718058616 From gdams at openjdk.org Thu Aug 15 07:23:27 2024 From: gdams at openjdk.org (George Adams) Date: Thu, 15 Aug 2024 07:23:27 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - Merge remote-tracking branch 'upstream/master' into freetype - remove top level make changes - remove make/conf/jib-profiles.js - changes from review - rerun autoconf - Merge remote-tracking branch 'upstream/master' into freetype - Merge remote-tracking branch 'upstream/master' into freetype - move libfreetype to correct src directory - remove freetype from actions - and more changes - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/318/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=08 Stats: 168775 lines in 324 files changed: 162602 ins; 5721 del; 452 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From serb at openjdk.org Thu Aug 15 23:07:59 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 23:07:59 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 07:23:27 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge remote-tracking branch 'upstream/master' into freetype > - remove top level make changes > - remove make/conf/jib-profiles.js > - changes from review > - rerun autoconf > - Merge remote-tracking branch 'upstream/master' into freetype > - Merge remote-tracking branch 'upstream/master' into freetype > - move libfreetype to correct src directory > - remove freetype from actions > - and more changes > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c jdk/src/share/legal/freetype.md line 1: > 1: ## The FreeType Project: Freetype v2.9 The "legal" folder is used in jdk9+, for jdk8 licenses should be placed in THIRD_PARTY_README file. We have several of them in jdk8, but after https://github.com/openjdk/jdk8u-dev/pull/557 integration there will be only one. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719097485 From serb at openjdk.org Thu Aug 15 23:18:58 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 23:18:58 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: <_NBHHe_qzjnsIbtKJDyDXpX4UY1b0v3x7KKqB0RfDVg=.2727e7db-6136-49a9-b68b-435045ec1fcd@github.com> On Thu, 15 Aug 2024 07:23:27 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge remote-tracking branch 'upstream/master' into freetype > - remove top level make changes > - remove make/conf/jib-profiles.js > - changes from review > - rerun autoconf > - Merge remote-tracking branch 'upstream/master' into freetype > - Merge remote-tracking branch 'upstream/master' into freetype > - move libfreetype to correct src directory > - remove freetype from actions > - and more changes > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c common/autoconf/toolchain_windows.m4 line 160: > 158: # 'v110' or 'v120' for VS 2010, 2012 or VS2013 > 159: eval PLATFORM_TOOLSET="\${VS_VS_PLATFORM_NAME_${VS_VERSION}}" > 160: this change probably correct, but it is not part of the jdk11 [commit](https://github.com/openjdk/jdk/commit/58ff4ee8c4ec399528338b59eadea996110366a0#diff-098656ab8708ea86ee2cc19047997ed8f58caf22b2d239630276329fae933269), and this code still exists in the [openjdk/jdk](https://github.com/openjdk/jdk/blob/74066bcca82749722e6fee57469520d418bf3430/make/autoconf/toolchain_microsoft.m4#L105) ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719103616 From serb at openjdk.org Thu Aug 15 23:28:59 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 23:28:59 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 07:23:27 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge remote-tracking branch 'upstream/master' into freetype > - remove top level make changes > - remove make/conf/jib-profiles.js > - changes from review > - rerun autoconf > - Merge remote-tracking branch 'upstream/master' into freetype > - Merge remote-tracking branch 'upstream/master' into freetype > - move libfreetype to correct src directory > - remove freetype from actions > - and more changes > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c doc/building.md line 408: > 406: Some examples: > 407: > 408: > **Windows 32bit build with freetype specified:** \ doc/building.html should be updated as well. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719107160 From serb at openjdk.org Thu Aug 15 23:28:59 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 23:28:59 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 23:22:55 GMT, Sergey Bylokhov wrote: >> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: >> >> - Merge remote-tracking branch 'upstream/master' into freetype >> - remove top level make changes >> - remove make/conf/jib-profiles.js >> - changes from review >> - rerun autoconf >> - Merge remote-tracking branch 'upstream/master' into freetype >> - Merge remote-tracking branch 'upstream/master' into freetype >> - move libfreetype to correct src directory >> - remove freetype from actions >> - and more changes >> - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c > > doc/building.md line 408: > >> 406: Some examples: >> 407: >> 408: > **Windows 32bit build with freetype specified:** \ > > doc/building.html should be updated as well. note that the documentation for freetype in jdk8 is outdated, in jdk9 it was reworked by this [commit](https://github.com/openjdk/jdk/commit/8dc9c32d0d1bbc791555f231e51c55924f256e75). We should update at least the freetype related part as a follow-up patch. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719108839 From serb at openjdk.org Thu Aug 15 23:50:04 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 23:50:04 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 07:23:27 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge remote-tracking branch 'upstream/master' into freetype > - remove top level make changes > - remove make/conf/jib-profiles.js > - changes from review > - rerun autoconf > - Merge remote-tracking branch 'upstream/master' into freetype > - Merge remote-tracking branch 'upstream/master' into freetype > - move libfreetype to correct src directory > - remove freetype from actions > - and more changes > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c common/autoconf/libraries.m4 line 262: > 260: METHOD="$3" > 261: > 262: # Assume we've found freetype to begin from where this comment is come from? the jdk11 and openjdk/jdk use "# Let's start with an optimistic view of the world :-)" added by the "https://github.com/openjdk/jdk/commit/6b1eac7c4e86e33cba1dd30d43b417675de9000f" common/autoconf/libraries.m4 line 328: > 326: if test "x$OPENJDK_TARGET_OS" != "xwindows" && \ > 327: test "x$OPENJDK_TARGET_OS" != "xmacosx" && \ > 328: test "x$OPENJDK_TARGET_OS" != "xaix"; then I am not sure about "aix" do we want to use the bundled version on it? ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719120231 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719121635 From serb at openjdk.org Thu Aug 15 23:54:57 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 15 Aug 2024 23:54:57 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 07:23:27 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: > > - Merge remote-tracking branch 'upstream/master' into freetype > - remove top level make changes > - remove make/conf/jib-profiles.js > - changes from review > - rerun autoconf > - Merge remote-tracking branch 'upstream/master' into freetype > - Merge remote-tracking branch 'upstream/master' into freetype > - move libfreetype to correct src directory > - remove freetype from actions > - and more changes > - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c it will be good to test it on solartis and aix. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2292470895 From serb at openjdk.org Fri Aug 16 00:19:54 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 16 Aug 2024 00:19:54 GMT Subject: [jdk8u-dev] RFR: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir In-Reply-To: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> References: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> Message-ID: On Mon, 8 Jul 2024 15:31:07 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138). > Only change the testcase, the change has been verified, no risk. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/542#pullrequestreview-2241555163 From duke at openjdk.org Fri Aug 16 00:27:52 2024 From: duke at openjdk.org (duke) Date: Fri, 16 Aug 2024 00:27:52 GMT Subject: [jdk8u-dev] RFR: 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use In-Reply-To: References: Message-ID: On Thu, 25 Jan 2024 07:32:51 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use. > The JMXStartStopTest.java test failures reported in this issue also occur in JDK8. > This backport improves testing to use a dynamically allocated port. > > testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java > > With this fix alone, the test remains unstable. > Backporting with JDK-8035395 makes JMXStartStopTest.java more stable. > > Thank you. @ktakakuri Your change (at version 98cff0fe2875d1aaee5702c5359796488d57aa13) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/429#issuecomment-2171942192 From serb at openjdk.org Fri Aug 16 00:27:53 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 16 Aug 2024 00:27:53 GMT Subject: [jdk8u-dev] RFR: 8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use In-Reply-To: References: Message-ID: On Thu, 25 Jan 2024 07:32:51 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8035395: sun/management/jmxremote/startstop/JMXStartStopTest.java fails intermittently: Port already in use. > The JMXStartStopTest.java test failures reported in this issue also occur in JDK8. > This backport improves testing to use a dynamically allocated port. > > testing: jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java > > With this fix alone, the test remains unstable. > Backporting with JDK-8035395 makes JMXStartStopTest.java more stable. > > Thank you. jdk/test/sun/management/jmxremote/startstop/JMXStartStopTest.java line 768: > 766: "jmxremote.port=" + pa.getPort1() > 767: ); > 768: testConnect(port1); fyi: change to port1 is missed, see https://github.com/openjdk/jdk8u-dev/pull/541 ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/429#discussion_r1719147475 From serb at openjdk.org Fri Aug 16 00:28:52 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 16 Aug 2024 00:28:52 GMT Subject: [jdk8u-dev] RFR: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 In-Reply-To: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> References: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> Message-ID: On Mon, 8 Jul 2024 09:14:01 GMT, SendaoYan wrote: > Hi all, > The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/541#pullrequestreview-2241562230 From gdams at openjdk.org Fri Aug 16 08:48:23 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 16 Aug 2024 08:48:23 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 23:04:55 GMT, Sergey Bylokhov wrote: >> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: >> >> - Merge remote-tracking branch 'upstream/master' into freetype >> - remove top level make changes >> - remove make/conf/jib-profiles.js >> - changes from review >> - rerun autoconf >> - Merge remote-tracking branch 'upstream/master' into freetype >> - Merge remote-tracking branch 'upstream/master' into freetype >> - move libfreetype to correct src directory >> - remove freetype from actions >> - and more changes >> - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c > > jdk/src/share/legal/freetype.md line 1: > >> 1: ## The FreeType Project: Freetype v2.9 > > The "legal" folder is used in jdk9+, for jdk8 licenses should be placed in THIRD_PARTY_README file. We have several of them in jdk8, but after https://github.com/openjdk/jdk8u-dev/pull/557 integration there will be only one. I've copied the entire contents of this file to the THIRD_PARTY_README file. Hopefully that's the correct way to do it. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719551767 From gdams at openjdk.org Fri Aug 16 08:48:22 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 16 Aug 2024 08:48:22 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v10] In-Reply-To: References: Message-ID: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request incrementally with one additional commit since the last revision: move freetype license to THIRD_PARTY_README ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/318/files - new: https://git.openjdk.org/jdk8u-dev/pull/318/files/7be05c5c..4eab0b01 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=09 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=08-09 Stats: 1083 lines in 2 files changed: 546 ins; 537 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From gdams at openjdk.org Fri Aug 16 08:54:33 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 16 Aug 2024 08:54:33 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v11] In-Reply-To: References: Message-ID: > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request incrementally with one additional commit since the last revision: fix comment ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/318/files - new: https://git.openjdk.org/jdk8u-dev/pull/318/files/4eab0b01..279fb6f9 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=10 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=09-10 Stats: 12 lines in 2 files changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From gdams at openjdk.org Fri Aug 16 08:54:34 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 16 Aug 2024 08:54:34 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 23:41:39 GMT, Sergey Bylokhov wrote: >> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: >> >> - Merge remote-tracking branch 'upstream/master' into freetype >> - remove top level make changes >> - remove make/conf/jib-profiles.js >> - changes from review >> - rerun autoconf >> - Merge remote-tracking branch 'upstream/master' into freetype >> - Merge remote-tracking branch 'upstream/master' into freetype >> - move libfreetype to correct src directory >> - remove freetype from actions >> - and more changes >> - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c > > common/autoconf/libraries.m4 line 262: > >> 260: METHOD="$3" >> 261: >> 262: # Assume we've found freetype to begin > > from where this comment is come from? the jdk11 and openjdk/jdk use "# Let's start with an optimistic view of the world :-)" added by the "https://github.com/openjdk/jdk/commit/6b1eac7c4e86e33cba1dd30d43b417675de9000f" good spot, I've updated the comment but this is only a partial backport of those changes ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719557198 From gdams at openjdk.org Fri Aug 16 08:58:38 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 16 Aug 2024 08:58:38 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: References: Message-ID: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> > Imports the Freetype source to be consistent with JDK11+ > > As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew George Adams has updated the pull request incrementally with one additional commit since the last revision: test removal of common/autoconf/toolchain_windows.m4 changes ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/318/files - new: https://git.openjdk.org/jdk8u-dev/pull/318/files/279fb6f9..7f84ed17 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=11 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=318&range=10-11 Stats: 75 lines in 2 files changed: 74 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/318.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/318/head:pull/318 PR: https://git.openjdk.org/jdk8u-dev/pull/318 From gdams at openjdk.org Fri Aug 16 08:58:38 2024 From: gdams at openjdk.org (George Adams) Date: Fri, 16 Aug 2024 08:58:38 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: <_NBHHe_qzjnsIbtKJDyDXpX4UY1b0v3x7KKqB0RfDVg=.2727e7db-6136-49a9-b68b-435045ec1fcd@github.com> References: <_NBHHe_qzjnsIbtKJDyDXpX4UY1b0v3x7KKqB0RfDVg=.2727e7db-6136-49a9-b68b-435045ec1fcd@github.com> Message-ID: On Thu, 15 Aug 2024 23:16:35 GMT, Sergey Bylokhov wrote: >> George Adams has updated the pull request incrementally with one additional commit since the last revision: >> >> test removal of common/autoconf/toolchain_windows.m4 changes > > common/autoconf/toolchain_windows.m4 line 160: > >> 158: ]) >> 159: >> 160: ################################################################################ > > this change probably correct, but it is not part of the jdk11 [commit](https://github.com/openjdk/jdk/commit/58ff4ee8c4ec399528338b59eadea996110366a0#diff-098656ab8708ea86ee2cc19047997ed8f58caf22b2d239630276329fae933269), and this code still exists in the [openjdk/jdk](https://github.com/openjdk/jdk/blob/74066bcca82749722e6fee57469520d418bf3430/make/autoconf/toolchain_microsoft.m4#L105) good spot, I've pushed a commit to revert this and will see if a build still passes ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719561999 From sgehwolf at openjdk.org Fri Aug 16 10:08:53 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 Aug 2024 10:08:53 GMT Subject: [jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 17:02:20 GMT, Karm Michal Babacek wrote: > backport 8c243a3 JDK11 LGTM. Seems clean to the JDK 11 version modulo `FILEVERSION` differences. Please apply for approval using the `/approval` command. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/559#pullrequestreview-2242383495 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2293223841 From yan at openjdk.org Fri Aug 16 10:43:23 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 16 Aug 2024 10:43:23 GMT Subject: [jdk8u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() [v2] In-Reply-To: References: Message-ID: > This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker. > > The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues. > > There will be a second fix in this series, JDK-8278794. Yuri Nesterenko has updated the pull request incrementally with one additional commit since the last revision: Trigger rebuild ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/558/files - new: https://git.openjdk.org/jdk8u-dev/pull/558/files/953a0aaa..f68b0a11 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=558&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=558&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/558.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/558/head:pull/558 PR: https://git.openjdk.org/jdk8u-dev/pull/558 From yan at openjdk.org Fri Aug 16 11:29:05 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 16 Aug 2024 11:29:05 GMT Subject: [jdk8u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3] In-Reply-To: References: Message-ID: > This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker. > > The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues. > > There will be a second fix in this series, JDK-8278794. Yuri Nesterenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of https://github.com/openjdk/jdk8u-dev into bpZipClose - Trigger rebuild - Backport 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/558/files - new: https://git.openjdk.org/jdk8u-dev/pull/558/files/f68b0a11..2c224688 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=558&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=558&range=01-02 Stats: 297 lines in 15 files changed: 92 ins; 14 del; 191 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/558.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/558/head:pull/558 PR: https://git.openjdk.org/jdk8u-dev/pull/558 From duke at openjdk.org Fri Aug 16 12:41:51 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Fri, 16 Aug 2024 12:41:51 GMT Subject: [jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update In-Reply-To: References: Message-ID: <767s1uZl9qeaXtvzwTeFsxJeDWkYRGgCgTIzjNvih3E=.ff65dff6-0d65-4a08-a354-167459311c6a@github.com> On Tue, 13 Aug 2024 17:02:20 GMT, Karm Michal Babacek wrote: > backport 8c243a3 JDK11 > ?? @Karm the full name on your profile does not match the author name in this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit. If this pull request gets integrated then the author name from this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork: > > ``` > $ git checkout JDK-8305400-amendment-175 > $ git commit --author='Preferred Full Name ' --allow-empty -m 'Update full name' > $ git push > ``` @jerboaa Any idea what the machine is worrying about, please? The commit is Author: Michal Karm Babacek and it is signed... ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2293437585 From sgehwolf at openjdk.org Fri Aug 16 12:45:54 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 Aug 2024 12:45:54 GMT Subject: [jdk8u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3] In-Reply-To: References: Message-ID: <-C-oFE14HiKxRKQbzeAN_ioe6cjikGGxUBgsMdEQ4xE=.488ea8c0-9313-454d-be71-3529af68dc55@github.com> On Fri, 16 Aug 2024 11:29:05 GMT, Yuri Nesterenko wrote: >> This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker. >> >> The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues. >> >> There will be a second fix in this series, JDK-8278794. > > Yuri Nesterenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of https://github.com/openjdk/jdk8u-dev into bpZipClose > - Trigger rebuild > - Backport 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f Looks OK to me. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/558#pullrequestreview-2242633823 From sgehwolf at openjdk.org Fri Aug 16 12:54:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 Aug 2024 12:54:52 GMT Subject: [jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update In-Reply-To: <767s1uZl9qeaXtvzwTeFsxJeDWkYRGgCgTIzjNvih3E=.ff65dff6-0d65-4a08-a354-167459311c6a@github.com> References: <767s1uZl9qeaXtvzwTeFsxJeDWkYRGgCgTIzjNvih3E=.ff65dff6-0d65-4a08-a354-167459311c6a@github.com> Message-ID: On Fri, 16 Aug 2024 12:39:35 GMT, Karm Michal Babacek wrote: >> backport 8c243a3 JDK11 > >> ?? @Karm the full name on your profile does not match the author name in this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit. If this pull request gets integrated then the author name from this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork: >> >> ``` >> $ git checkout JDK-8305400-amendment-175 >> $ git commit --author='Preferred Full Name ' --allow-empty -m 'Update full name' >> $ git push >> ``` > > @jerboaa > > Any idea what the machine is worrying about, please? > > The commit is > > > Author: Michal Karm Babacek > > and it is signed... > @Karm 8305400: The approval [request](https://bugs.openjdk.org/browse/JDK-8305400?focusedCommentId=14698720) has been created successfully. The request comment is: [jdk8u-fix-request] Approval Request from Karm Michal Babacek @Karm This is not a suitable approval request comment. It should mention the anticipated risk, what testing you have done and why it should get approved in the first place. Please update the comment by using `/approval request `. See also point 6 in: https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix > > ?? @Karm the full name on your profile does not match the author name in this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit. If this pull request gets integrated then the author name from this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork: > > ``` > > $ git checkout JDK-8305400-amendment-175 > > $ git commit --author='Preferred Full Name ' --allow-empty -m 'Update full name' > > $ git push > > ``` > > @jerboaa > > Any idea what the machine is worrying about, please? > > The commit is > > ``` > Author: Michal Karm Babacek > ``` > > and it is signed... It says the full name in your github profile (`Karm Michal Babacek`) doesn't match the name in the commit (`Michal Karm Babacek`). I'd suggest to fix it so they match and the warning should be gone. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2293453203 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2293456427 From duke at openjdk.org Fri Aug 16 13:02:23 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Fri, 16 Aug 2024 13:02:23 GMT Subject: [jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update [v2] In-Reply-To: References: Message-ID: <-K6Uh_Qv93VWKAS2qnh_5q3acMZR0Tfmtxe5SmD_W1M=.e9dc28df-c5d5-40e4-9090-18e2c32f33ac@github.com> > backport 8c243a3 JDK11 Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: Update full name ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/559/files - new: https://git.openjdk.org/jdk8u-dev/pull/559/files/cf4ea716..cf40dbf7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=559&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=559&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/559.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/559/head:pull/559 PR: https://git.openjdk.org/jdk8u-dev/pull/559 From sgehwolf at openjdk.org Fri Aug 16 13:02:55 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 Aug 2024 13:02:55 GMT Subject: [jdk8u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 12:03:56 GMT, Zdenek Zambersky wrote: > Backport fixes code, which removes unnecessary artifacts (jdk builds), as it longer works after [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723). > > **Notes:** > - changeset is quite different form newer JDKs, because there are significant differences to GHA code > - in jdk 8 bundle artifacts use transient prefix instead of bundle > - `Display current artifacts` and `Delete transient artifacts` steps were updated to use documented [REST API](https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28) > - I switched last step to use new `actions/upload-artifact/merge at v4`, which allows to turn last 3 steps into one > > **Testing:** > - GHA: OK > - only single artifacts with resulst of all ran tests (checked) is produced, as expected on 8 (see [artifacts in summary tab](https://github.com/zzambers/jdk8u-dev/actions/runs/10375295565#artifacts)) > - windows x86 build failures are unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/555 > - macos test failures are unrelates, see: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257 Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/560#pullrequestreview-2242661077 From aph at openjdk.org Fri Aug 16 13:12:56 2024 From: aph at openjdk.org (Andrew Haley) Date: Fri, 16 Aug 2024 13:12:56 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> References: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> Message-ID: On Fri, 16 Aug 2024 08:58:38 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > test removal of common/autoconf/toolchain_windows.m4 changes This one is outside the usual rules for 8u, which is closed for enhancements. For that reason, it must be accompanied by a _very_ strong justification, and evidence that it carries no risk. By now, I'd have thought that everyone building JDK 8 on Windows etc. had workflows in place. We are at the (long) tail of the JDK 8 life cycle. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2293482629 From yan at openjdk.org Fri Aug 16 13:15:51 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Fri, 16 Aug 2024 13:15:51 GMT Subject: [jdk8u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3] In-Reply-To: References: Message-ID: <9ftIZuhoq_3v3iYTofuGKbvrrSk44-4lHPXVuoBz9Jg=.41d4ab1d-f7f7-403f-b00c-738fb2592786@github.com> On Fri, 16 Aug 2024 11:29:05 GMT, Yuri Nesterenko wrote: >> This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker. >> >> The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues. >> >> There will be a second fix in this series, JDK-8278794. > > Yuri Nesterenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of https://github.com/openjdk/jdk8u-dev into bpZipClose > - Trigger rebuild > - Backport 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f Thank you Severin! macOS test failures are connection problems, apparently. Windows x86 does pass after JDK-8337312, thank you Andrew. I'm sorry I was too slow to fix it :-( ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/558#issuecomment-2293487467 From sgehwolf at openjdk.org Fri Aug 16 14:07:51 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Fri, 16 Aug 2024 14:07:51 GMT Subject: [jdk8u-dev] RFR: 8193682: Infinite loop in ZipOutputStream.close() [v3] In-Reply-To: <9ftIZuhoq_3v3iYTofuGKbvrrSk44-4lHPXVuoBz9Jg=.41d4ab1d-f7f7-403f-b00c-738fb2592786@github.com> References: <9ftIZuhoq_3v3iYTofuGKbvrrSk44-4lHPXVuoBz9Jg=.41d4ab1d-f7f7-403f-b00c-738fb2592786@github.com> Message-ID: On Fri, 16 Aug 2024 13:13:16 GMT, Yuri Nesterenko wrote: > macOS test failures are connection problems, apparently. Yes. Known issues. See: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/558#issuecomment-2293574920 From duke at openjdk.org Fri Aug 16 15:21:54 2024 From: duke at openjdk.org (Stewart X Addison) Date: Fri, 16 Aug 2024 15:21:54 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v7] In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 16:23:26 GMT, Zdenek Zambersky wrote: > I can still reproduce issue with type.cpp on rhel-9, with just most default build (just boot jdk set). Gcc version is 11.4.1 (system one). @zzambers Looks similar to what [I saw with GCC 11.2/aarch64](https://github.com/openjdk/jdk8u-dev/pull/357#issuecomment-2091050348) Ref: https://github.com/adoptium/temurin-build/issues/3758#issuecomment-2293651827 which links to the full log in our jenkins instance. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2293700542 From syan at openjdk.org Fri Aug 16 16:18:00 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 16:18:00 GMT Subject: [jdk8u-dev] RFR: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 In-Reply-To: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> References: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> Message-ID: On Mon, 8 Jul 2024 09:14:01 GMT, SendaoYan wrote: > Hi all, > The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk. Thanks all for the approved and review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/541#issuecomment-2293786591 From duke at openjdk.org Fri Aug 16 16:18:00 2024 From: duke at openjdk.org (duke) Date: Fri, 16 Aug 2024 16:18:00 GMT Subject: [jdk8u-dev] RFR: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 In-Reply-To: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> References: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> Message-ID: <8lAOXR2nydh0-4RFlzIqQLQPCsPPopMtuezc8Efcze4=.70a11d81-f7bf-431b-be47-408e6ba64d4f@github.com> On Mon, 8 Jul 2024 09:14:01 GMT, SendaoYan wrote: > Hi all, > The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk. @sendaoYan Your change (at version bca02cc788967797c7eefeacfa6b10757068d162) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/541#issuecomment-2293788047 From syan at openjdk.org Fri Aug 16 16:21:51 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 16:21:51 GMT Subject: [jdk8u-dev] RFR: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir In-Reply-To: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> References: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> Message-ID: On Mon, 8 Jul 2024 15:31:07 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138). > Only change the testcase, the change has been verified, no risk. Thanks all for the approved and review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/542#issuecomment-2293791644 From duke at openjdk.org Fri Aug 16 16:21:51 2024 From: duke at openjdk.org (duke) Date: Fri, 16 Aug 2024 16:21:51 GMT Subject: [jdk8u-dev] RFR: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir In-Reply-To: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> References: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> Message-ID: On Mon, 8 Jul 2024 15:31:07 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138). > Only change the testcase, the change has been verified, no risk. @sendaoYan Your change (at version 41b38a780432c64f29912d52bfbd39b663e8cc42) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/542#issuecomment-2293793195 From duke at openjdk.org Fri Aug 16 20:07:57 2024 From: duke at openjdk.org (duke) Date: Fri, 16 Aug 2024 20:07:57 GMT Subject: [jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update [v2] In-Reply-To: <-K6Uh_Qv93VWKAS2qnh_5q3acMZR0Tfmtxe5SmD_W1M=.e9dc28df-c5d5-40e4-9090-18e2c32f33ac@github.com> References: <-K6Uh_Qv93VWKAS2qnh_5q3acMZR0Tfmtxe5SmD_W1M=.e9dc28df-c5d5-40e4-9090-18e2c32f33ac@github.com> Message-ID: <6YohuM9A47fhAcCeflAcMwvtLG2wqq4s0r-Cv3uXQSg=.8fb001dc-c38c-4274-bb3c-0c8cdb385618@github.com> On Fri, 16 Aug 2024 13:02:23 GMT, Karm Michal Babacek wrote: >> backport 8c243a3 JDK11 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Update full name @Karm Your change (at version cf40dbf7219bf387aaf305c02c6aab64f175fa35) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2294156205 From syan at openjdk.org Fri Aug 16 22:50:07 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 22:50:07 GMT Subject: [jdk8u-dev] Integrated: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 In-Reply-To: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> References: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> Message-ID: On Mon, 8 Jul 2024 09:14:01 GMT, SendaoYan wrote: > Hi all, > The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk. This pull request has now been integrated. Changeset: 4538bba3 Author: SendaoYan Committer: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/4538bba37c61982e3122dbf83fa2ea5c70434641 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 Reviewed-by: serb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/541 From syan at openjdk.org Fri Aug 16 22:57:09 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 16 Aug 2024 22:57:09 GMT Subject: [jdk8u-dev] Integrated: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir In-Reply-To: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> References: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> Message-ID: <9nHqvDUM532OL4eTHJcy0o-O8w-aQqMOzfcZo7MDBRc=.108765a3-c843-4c4f-8880-9ebd74d7ad40@github.com> On Mon, 8 Jul 2024 15:31:07 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138). > Only change the testcase, the change has been verified, no risk. This pull request has now been integrated. Changeset: fb0a658d Author: SendaoYan Committer: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/fb0a658dd5dc417fa4ce74b17d10c507ed6bc66f Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir Reviewed-by: serb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/542 From syan at openjdk.org Sat Aug 17 00:54:52 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 17 Aug 2024 00:54:52 GMT Subject: [jdk8u-dev] RFR: 8335851: [8u] Test JMXStartStopTest.java fails after JDK-8334415 In-Reply-To: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> References: <6MWndFP7ArYWfTBgu9YzAiyLuEZIbuPNBJPtBEDiYgQ=.b12a5605-189f-4589-83d6-8ce2e8a05c55@github.com> Message-ID: On Mon, 8 Jul 2024 09:14:01 GMT, SendaoYan wrote: > Hi all, > The testcase `sun/management/jmxremote/startstop/JMXStartStopTest.java` compile error after [JDK-8334415](https://bugs.openjdk.org/browse/JDK-8334415). This PR fix the testcase bug, the change has been verified, no risk. Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/541#issuecomment-2294505536 From serb at openjdk.org Sat Aug 17 01:04:55 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 17 Aug 2024 01:04:55 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. [v6] In-Reply-To: References: Message-ID: On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. >> >> This patch has already been applied to OracleJDK8. >> As noted in the Bug Issue comments, some tests do not exist in 8u. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Merge branch 'master' into 8160974 > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 @gnu-andrew please take a look, more tests marked by headful keyword. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2294508355 From andrew at openjdk.org Sat Aug 17 10:23:53 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 17 Aug 2024 10:23:53 GMT Subject: [jdk8u-dev] RFR: 8338144: [8u] Remove duplicate license files In-Reply-To: References: Message-ID: On Sat, 10 Aug 2024 12:41:52 GMT, Andrew John Hughes wrote: > This removes the duplicate copies of the three licensing files - `LICENSE`, `ASSEMBLY_EXCEPTION` and `THIRD_PARTY_README` - from the top of each of the old subrepositories - `corba`, `jaxp`, `jaxws`, `langtools`, `jdk`, `hotspot` and `nashorn`. The `Images.gmk` makefile under the `jdk` tree has to be updated to use the top-level versions rather than the `jdk` ones. Thanks @jerboaa ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/557#issuecomment-2294818436 From andrew at openjdk.org Sat Aug 17 10:23:53 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 17 Aug 2024 10:23:53 GMT Subject: [jdk8u-dev] Integrated: 8338144: [8u] Remove duplicate license files In-Reply-To: References: Message-ID: On Sat, 10 Aug 2024 12:41:52 GMT, Andrew John Hughes wrote: > This removes the duplicate copies of the three licensing files - `LICENSE`, `ASSEMBLY_EXCEPTION` and `THIRD_PARTY_README` - from the top of each of the old subrepositories - `corba`, `jaxp`, `jaxws`, `langtools`, `jdk`, `hotspot` and `nashorn`. The `Images.gmk` makefile under the `jdk` tree has to be updated to use the top-level versions rather than the `jdk` ones. This pull request has now been integrated. Changeset: ea76f37d Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/ea76f37ddb113b84f5421d64e687e1b6b7a13ea6 Stats: 26217 lines in 22 files changed: 0 ins; 26215 del; 2 mod 8338144: [8u] Remove duplicate license files Reviewed-by: phh, serb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/557 From syan at openjdk.org Sat Aug 17 11:01:56 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 17 Aug 2024 11:01:56 GMT Subject: [jdk8u-dev] RFR: 8335894: [8u] Fix SupplementalJapaneseEraTest.java for jdks with symlinked conf dir In-Reply-To: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> References: <-PCx9fQeZ2hPLBY7Q_acdHCZAtJX6p_ML2ZL_-iF_XI=.468e2d50-e3b2-4a39-912a-47e2c7eb5cf0@github.com> Message-ID: <-G-D3v_h7AfSCFUbRMiqBrug4RzQ9QOKvcrd7Ep0jtM=.da5e5a58-7be9-42ab-8e14-3543ebb2d04f@github.com> On Mon, 8 Jul 2024 15:31:07 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138). > Only change the testcase, the change has been verified, no risk. Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/542#issuecomment-2294826341 From syan at openjdk.org Sat Aug 17 11:04:54 2024 From: syan at openjdk.org (SendaoYan) Date: Sat, 17 Aug 2024 11:04:54 GMT Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jun 2024 09:27:43 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8048215 > - 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo > > Ensure the target thread has reached wait() before inspecting it > > Reviewed-by: mchung, dfuchs, jcbeyler Hi, can anyone task look this PR. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2294826950 From serb at openjdk.org Sat Aug 17 16:34:51 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sat, 17 Aug 2024 16:34:51 GMT Subject: [jdk8u-dev] RFR: 8298887: On the latest macOS+XCode the Robot API may report wrong colors In-Reply-To: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com> References: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com> Message-ID: On Mon, 26 Feb 2024 20:40:53 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [ceb6793b](https://github.com/openjdk/jdk11u-dev/commit/ceb6793bf3b5855c7c521678b5d99d752800b441) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Sergey Bylokhov on 5 May 2023 and was reviewed by Paul Hohensee. > > This patch is needed to support XCode 14.2+ > > Thanks! keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/457#issuecomment-2294906889 From serb at openjdk.org Sun Aug 18 08:18:33 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Sun, 18 Aug 2024 08:18:33 GMT Subject: [jdk8u-dev] RFR: 8260380: Upgrade to LittleCMS 2.12 Message-ID: Hi all, This pull request contains a backport of commit [4caeb39f](https://github.com/openjdk/jdk/commit/4caeb39f01b13b5472d8dacb268262fd418fd0c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Phil Race on 10 Feb 2021 and was reviewed by Jayathirth D V and Sergey Bylokhov. The backport is mostly clean, I had to update the license in `THIRD_PARTY_README` instead of `lcms.md`. No new issues found by the :jdk_desktop tests. Thanks! ------------- Commit messages: - Merge branch 'openjdk:master' into 8260380 - Backport 4caeb39f01b13b5472d8dacb268262fd418fd0c4 Changes: https://git.openjdk.org/jdk8u-dev/pull/563/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=563&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8260380 Stats: 717 lines in 20 files changed: 249 ins; 286 del; 182 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/563.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/563/head:pull/563 PR: https://git.openjdk.org/jdk8u-dev/pull/563 From sgehwolf at openjdk.org Mon Aug 19 08:33:54 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 19 Aug 2024 08:33:54 GMT Subject: [jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update [v2] In-Reply-To: <-K6Uh_Qv93VWKAS2qnh_5q3acMZR0Tfmtxe5SmD_W1M=.e9dc28df-c5d5-40e4-9090-18e2c32f33ac@github.com> References: <-K6Uh_Qv93VWKAS2qnh_5q3acMZR0Tfmtxe5SmD_W1M=.e9dc28df-c5d5-40e4-9090-18e2c32f33ac@github.com> Message-ID: On Fri, 16 Aug 2024 13:02:23 GMT, Karm Michal Babacek wrote: >> backport 8c243a3 JDK11 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Update full name GHA failures are unrelated. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2295978000 From duke at openjdk.org Mon Aug 19 08:33:54 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Mon, 19 Aug 2024 08:33:54 GMT Subject: [jdk8u-dev] Integrated: 8305400: ISO 4217 Amendment 175 Update In-Reply-To: References: Message-ID: <1UmXq83RKzOuI7tvxSclg_4hvbP56fh-4RGwSznc5Kg=.393a76bd-b987-4bd6-9827-021ea2795c6a@github.com> On Tue, 13 Aug 2024 17:02:20 GMT, Karm Michal Babacek wrote: > backport 8c243a3 JDK11 This pull request has now been integrated. Changeset: 1ca84ad5 Author: Karm Michal Babacek Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/1ca84ad59a4db33ab43cebc7d78ee99f87455be1 Stats: 5 lines in 2 files changed: 0 ins; 0 del; 5 mod 8305400: ISO 4217 Amendment 175 Update Reviewed-by: sgehwolf Backport-of: 8c243a33b290f5e747ee227f005d30260e6d846f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/559 From duke at openjdk.org Mon Aug 19 08:38:27 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Mon, 19 Aug 2024 08:38:27 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v2] In-Reply-To: References: Message-ID: > backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > > depends on #559 Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/561/files - new: https://git.openjdk.org/jdk8u-dev/pull/561/files/9c607c08..9c607c08 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=561&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=561&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/561.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/561/head:pull/561 PR: https://git.openjdk.org/jdk8u-dev/pull/561 From zzambers at openjdk.org Mon Aug 19 10:21:52 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 19 Aug 2024 10:21:52 GMT Subject: [jdk8u-dev] RFR: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Fri, 16 Aug 2024 12:59:54 GMT, Severin Gehwolf wrote: >> Backport fixes code, which removes unnecessary artifacts (jdk builds), as it longer works after [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723). >> >> **Notes:** >> - changeset is quite different form newer JDKs, because there are significant differences to GHA code >> - in jdk 8 bundle artifacts use transient prefix instead of bundle >> - `Display current artifacts` and `Delete transient artifacts` steps were updated to use documented [REST API](https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28) >> - I switched last step to use new `actions/upload-artifact/merge at v4`, which allows to turn last 3 steps into one >> >> **Testing:** >> - GHA: OK >> - only single artifacts with resulst of all ran tests (checked) is produced, as expected on 8 (see [artifacts in summary tab](https://github.com/zzambers/jdk8u-dev/actions/runs/10375295565#artifacts)) >> - windows x86 build failures are unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/555 >> - macos test failures are unrelates, see: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257 > > Marked as reviewed by sgehwolf (Reviewer). @jerboaa thanks ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/560#issuecomment-2296218592 From zzambers at openjdk.org Mon Aug 19 10:21:53 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 19 Aug 2024 10:21:53 GMT Subject: [jdk8u-dev] Integrated: 8336928: GHA: Bundle artifacts removal broken In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 12:03:56 GMT, Zdenek Zambersky wrote: > Backport fixes code, which removes unnecessary artifacts (jdk builds), as it longer works after [JDK-8324723](https://bugs.openjdk.org/browse/JDK-8324723). > > **Notes:** > - changeset is quite different form newer JDKs, because there are significant differences to GHA code > - in jdk 8 bundle artifacts use transient prefix instead of bundle > - `Display current artifacts` and `Delete transient artifacts` steps were updated to use documented [REST API](https://docs.github.com/en/rest/actions/artifacts?apiVersion=2022-11-28) > - I switched last step to use new `actions/upload-artifact/merge at v4`, which allows to turn last 3 steps into one > > **Testing:** > - GHA: OK > - only single artifacts with resulst of all ran tests (checked) is produced, as expected on 8 (see [artifacts in summary tab](https://github.com/zzambers/jdk8u-dev/actions/runs/10375295565#artifacts)) > - windows x86 build failures are unrelated, see: https://github.com/openjdk/jdk8u-dev/pull/555 > - macos test failures are unrelates, see: https://github.com/openjdk/jdk8u-dev/pull/544#issuecomment-2250636257 This pull request has now been integrated. Changeset: edbdf053 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/edbdf0538df3fe764ea6a109c3e07cb145dbfe48 Stats: 41 lines in 1 file changed: 3 ins; 14 del; 24 mod 8336928: GHA: Bundle artifacts removal broken Reviewed-by: sgehwolf Backport-of: 98562166e4a4c8921709014423c6cbc993aa0d97 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/560 From zzambers at openjdk.org Mon Aug 19 10:29:57 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 19 Aug 2024 10:29:57 GMT Subject: [jdk8u-dev] RFR: 8329826: GCC 12 reports some compiler error when building jdk8 [v3] In-Reply-To: References: Message-ID: On Fri, 10 May 2024 01:15:32 GMT, Kun Wang wrote: >> Env: >> ldd (GNU libc) 2.38 >> gcc (GCC) 12.3.1 >> >> Test the PR patch; >> Build release/fastdebug/slowdebug version pass >> >> Reported issue : https://bugs.openjdk.org/browse/JDK-8329826 > > Kun Wang has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains two new commits since the last revision: > > - revert gcc.make and cuncurrentMark.cpp > - add the processing of the failure to obtain static fields by instanceKlass Issue with register keyword has been fixed by: https://github.com/openjdk/jdk8u-dev/pull/357 Issue in `type.cpp` seems like duplicate of these backports: https://github.com/openjdk/jdk8u-dev/pull/536 https://github.com/openjdk/jdk8u-dev/pull/552 (which also include tests) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/479#issuecomment-2296237119 From zzambers at openjdk.org Mon Aug 19 10:34:55 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 19 Aug 2024 10:34:55 GMT Subject: [jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v7] In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 15:48:31 GMT, Andrew John Hughes wrote: >> Marked as reviewed by sgehwolf (Reviewer). > > Thanks for the approval, @jerboaa @gnu-andrew Actually I have found that that there are actually backports to fix `type.cpp` (they also include tests): https://github.com/openjdk/jdk8u-dev/pull/536 and this one (see discussion in higher PR): https://github.com/openjdk/jdk8u-dev/pull/552 (so compiler warnings seem to symptom of real issue) Issue, I referenced earlier actually seems like duplicate: https://github.com/openjdk/jdk8u-dev/pull/479 (I commented there) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2296245983 From duke at openjdk.org Mon Aug 19 10:52:27 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Mon, 19 Aug 2024 10:52:27 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v3] In-Reply-To: References: Message-ID: > backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > > depends on #559 Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-559-amendment-175-176 - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/561/files - new: https://git.openjdk.org/jdk8u-dev/pull/561/files/9c607c08..01b9bf7c Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=561&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=561&range=01-02 Stats: 26518 lines in 39 files changed: 94 ins; 26229 del; 195 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/561.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/561/head:pull/561 PR: https://git.openjdk.org/jdk8u-dev/pull/561 From ktakakuri at openjdk.org Mon Aug 19 12:08:28 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 19 Aug 2024 12:08:28 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: > Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. > The bug reported is reproducible in JDK8, so this patch should be applied. > This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. > The original patch does not apply cleanly, and the following modifications are needed: > > hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java > > * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. > * The size_t type was introduced in JDK9, so the related fix is skipped. > * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. > * Replace var with String. > > hotspot/src/share/vm/runtime/globals.hpp > > * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. > > hotspot/test/serviceability/sa/ClhsdbFlags.java > > * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. > > Testing > > * manually check the behaviour > Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. > > without patch > > > hsdb> flags NativeMemoryTracking > NativeMemoryTracking = null 1 > hsdb> flags OnError > OnError = null 1 > hsdb> flags Max... Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: Add comment ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/431/files - new: https://git.openjdk.org/jdk8u-dev/pull/431/files/465ea187..34c43b78 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=431&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=431&range=01-02 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/431.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/431/head:pull/431 PR: https://git.openjdk.org/jdk8u-dev/pull/431 From ktakakuri at openjdk.org Mon Aug 19 12:11:53 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 19 Aug 2024 12:11:53 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: <1aFt_5_AtVbRw4PpOnuPpOxxa0heiNiJsJvT9ocncZQ=.ce82dcc0-007e-4a82-ac21-06cc47acb555@github.com> On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Add comment I added a comment. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2296421344 From duke at openjdk.org Mon Aug 19 15:09:57 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Mon, 19 Aug 2024 15:09:57 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 10:52:27 GMT, Karm Michal Babacek wrote: >> backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update >> >> depends on #559 > > Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-559-amendment-175-176 > - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update Faild test: FAILED: security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java#sslrooteccca ... Caused by: java.io.IOException: Server returned HTTP response code: 502 for URL: http://ocsps.ssl.com/ ... IMHO OCSP responder is just down... ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/561#issuecomment-2296809136 From phh at openjdk.org Mon Aug 19 15:28:53 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 19 Aug 2024 15:28:53 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Add comment Thank you. ------------- Marked as reviewed by phh (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/431#pullrequestreview-2245853592 From sgehwolf at openjdk.org Mon Aug 19 16:32:54 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 19 Aug 2024 16:32:54 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 10:52:27 GMT, Karm Michal Babacek wrote: >> backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update >> >> depends on #559 > > Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-559-amendment-175-176 > - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update What testing have you done? jdk/test/java/util/Currency/ValidateISO4217.java line 27: > 25: * @bug 4691089 4819436 4942982 5104960 6544471 6627549 7066203 7195759 > 26: * 8039317 8074350 8074351 8145952 8187946 8193552 8202026 8204269 > 27: * 8208746 8209775 8264792 8274658 8283277 8296239 8321480 This should only be a one-line change appending `8321480` to the last line. See the [JDK 11u commit](https://github.com/openjdk/jdk11u-dev/commit/ea06b5c966e9261cacb35300ddde6eae48ec632f#diff-07e0488dd131c8c4cfcf7c135041095716c42fdeacaf67e8f37475bf9c4780ffR27) which does the same thing. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/561#pullrequestreview-2245988608 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/561#discussion_r1722059396 From phh at openjdk.org Mon Aug 19 17:55:52 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 19 Aug 2024 17:55:52 GMT Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jun 2024 09:27:43 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8048215 > - 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo > > Ensure the target thread has reached wait() before inspecting it > > Reviewed-by: mchung, dfuchs, jcbeyler Marked as reviewed by phh (Reviewer). GHA failures are unrelated. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/504#pullrequestreview-2246134507 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2297119444 From syan at openjdk.org Tue Aug 20 01:43:54 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 01:43:54 GMT Subject: [jdk8u-dev] RFR: 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo [v2] In-Reply-To: References: Message-ID: On Fri, 21 Jun 2024 09:27:43 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8048215](https://bugs.openjdk.org/browse/JDK-8048215). This PR try to fixed the intermitent failure. The change has been verifed. Only change the testcase, no risk. > > SendaoYan has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into jbs8048215 > - 8048215: [TESTBUG] java/lang/management/ManagementFactory/ThreadMXBeanProxy.java Expected non-null LockInfo > > Ensure the target thread has reached wait() before inspecting it > > Reviewed-by: mchung, dfuchs, jcbeyler Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/504#issuecomment-2297803182 From ktakakuri at openjdk.org Tue Aug 20 07:06:55 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 20 Aug 2024 07:06:55 GMT Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong position In-Reply-To: References: Message-ID: <35-OeONA7eieaxL0EJNM1t1xLZm3h5GqvcNbAMwO6sc=.29ffd325-a385-47fb-831e-ae4c67ee35b6@github.com> On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri wrote: > This fix includes a fix for JDK-8189687 in JDK9. > JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > HWND hTop = GetTopLevelParentForWindow(hWnd); > ::ClientToScreen(hTop, &p); > + int sx = ScaleUpX(x) - p.x; > + int sy = ScaleUpY(y) - p.y; > if (!m_bitsCandType) { > - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); > + SetCandidateWindow(m_bitsCandType, sx, sy); > return; > } > for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { > if ( m_bitsCandType & bits ) > - SetCandidateWindow(iCandType, x - p.x, y - p.y); > + SetCandidateWindow(iCandType, sx, sy); > } > } > > > In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. OK. I created a new issue because JDK-8189687 primarily reports a problem in Hi-DPI and the fix assumes JEP263 which supports Hi-DPI. If it is better to backport ignoring JEP 263 as you said, I will create new pull request. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/483#issuecomment-2298119543 From duke at openjdk.org Tue Aug 20 11:23:54 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 20 Aug 2024 11:23:54 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 16:30:18 GMT, Severin Gehwolf wrote: >> Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-559-amendment-175-176 >> - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update >> - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update > > What testing have you done? @jerboaa > What testing have you done? karm at laptop:~/Tools/jtreg/build/images/jtreg/bin ((jtreg-7.4+1))$ TIME=`date +%s`;mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; jtreg -a -ignore:quiet -w:test.${TIME}/jdk/JTwork -r:test.${TIME}/jdk/JTreport -jdk:/home/karm/workspaceRH/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/ /home/karm/workspaceRH/jdk8u/jdk/test/java/util/Currency/ Test results: passed: 5 Report written to /home/karm/Tools/jtreg/build/images/jtreg/bin/test.1724152749/jdk/JTreport/html/report.html Results written to /home/karm/Tools/jtreg/build/images/jtreg/bin/test.1724152749/jdk/JTwork ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/561#issuecomment-2298614344 From duke at openjdk.org Tue Aug 20 11:38:29 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 20 Aug 2024 11:38:29 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v4] In-Reply-To: References: Message-ID: > backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > > depends on #559 Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: Append only 8321480 to ValidateISO4217 test ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/561/files - new: https://git.openjdk.org/jdk8u-dev/pull/561/files/01b9bf7c..bc18ee31 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=561&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=561&range=02-03 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/561.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/561/head:pull/561 PR: https://git.openjdk.org/jdk8u-dev/pull/561 From duke at openjdk.org Tue Aug 20 11:38:30 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 20 Aug 2024 11:38:30 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 16:29:09 GMT, Severin Gehwolf wrote: >> Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: >> >> - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-559-amendment-175-176 >> - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update >> - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update > > jdk/test/java/util/Currency/ValidateISO4217.java line 27: > >> 25: * @bug 4691089 4819436 4942982 5104960 6544471 6627549 7066203 7195759 >> 26: * 8039317 8074350 8074351 8145952 8187946 8193552 8202026 8204269 >> 27: * 8208746 8209775 8264792 8274658 8283277 8296239 8321480 > > This should only be a one-line change appending `8321480` to the last line. See the [JDK 11u commit](https://github.com/openjdk/jdk11u-dev/commit/ea06b5c966e9261cacb35300ddde6eae48ec632f#diff-07e0488dd131c8c4cfcf7c135041095716c42fdeacaf67e8f37475bf9c4780ffR27) which does the same thing. @jerboaa Ack. bc18ee3 ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/561#discussion_r1723161374 From ktakakuri at openjdk.org Tue Aug 20 11:41:21 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 20 Aug 2024 11:41:21 GMT Subject: [jdk8u-dev] RFR: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows Message-ID: This is a backport of JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows. JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow 1. Fix to make OpenCandidateWindow reference the correct Window Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) { UINT bits = 1; POINT p = {0, 0}; // upper left corner of the client area - HWND hWnd = GetHWnd(); + HWND hWnd = ImmGetHWnd(); if (!::IsWindowVisible(hWnd)) { return; } 2. Scaling fixes to enhance JDK-8073320 OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) HWND hTop = GetTopLevelParentForWindow(hWnd); ::ClientToScreen(hTop, &p); + int sx = ScaleUpX(x) - p.x; + int sy = ScaleUpY(y) - p.y; if (!m_bitsCandType) { - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); + SetCandidateWindow(m_bitsCandType, sx, sy); return; } for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { if ( m_bitsCandType & bits ) - SetCandidateWindow(iCandType, x - p.x, y - p.y); + SetCandidateWindow(iCandType, sx, sy); } } In the attached test that reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. Therefore, the candidate window will appear in the correct position with the "1" fix. Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. ------------- Commit messages: - Fix the Copyright year - Backport 489e5ae3349370825b7faa1d7514796a2b1ac1c7 Changes: https://git.openjdk.org/jdk8u-dev/pull/564/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=564&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8189687 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/564.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/564/head:pull/564 PR: https://git.openjdk.org/jdk8u-dev/pull/564 From sgehwolf at openjdk.org Tue Aug 20 12:08:55 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 12:08:55 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v4] In-Reply-To: References: Message-ID: <9ccm2rq3mdmZ0doR9qMnjRg5dmYbIXmySodEGw7HUTo=.c284c082-e21a-466d-a4f1-ee4776790b01@github.com> On Tue, 20 Aug 2024 11:38:29 GMT, Karm Michal Babacek wrote: >> backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update >> >> depends on #559 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Append only 8321480 to ValidateISO4217 test Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/561#pullrequestreview-2247805713 From sgehwolf at openjdk.org Tue Aug 20 15:30:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 15:30:52 GMT Subject: [jdk8u-dev] RFR: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails In-Reply-To: References: Message-ID: On Fri, 28 Jun 2024 16:32:51 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [b7540df6](https://github.com/openjdk/jdk/commit/b7540df6a4279c63e69d32b9d9834f7a427478d1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 5 Mar 2024 and was reviewed by Phil Race. > > Thanks! Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/530#pullrequestreview-2248345692 From sgehwolf at openjdk.org Tue Aug 20 15:38:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 15:38:52 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Mon, 8 Jul 2024 06:58:37 GMT, SendaoYan wrote: > Hi all > This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > Only change the testcase lib file, the risk is low. > > Additional testing: > > - [x] jdk/test/jdk/internal/platform/docker > > [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) Please include the same change in the Hotspot copy of `DockerTestUtils.java` in this backport. ------------- Changes requested by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/538#pullrequestreview-2248360897 From sgehwolf at openjdk.org Tue Aug 20 15:38:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 15:38:52 GMT Subject: [jdk8u-dev] RFR: 8318951: Additional negative value check in JPEG decoding In-Reply-To: References: Message-ID: On Thu, 30 May 2024 21:30:33 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [75ce02fe](https://github.com/openjdk/jdk/commit/75ce02fe74e1232bfa8d72b4fdad82ed938ef957) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jayathirth D V on 31 Oct 2023 and was reviewed by Alexander Zvegintsev and Phil Race. > > Thanks! OK. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/510#pullrequestreview-2248365592 From phh at openjdk.org Tue Aug 20 15:39:53 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 Aug 2024 15:39:53 GMT Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong position In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri wrote: > This fix includes a fix for JDK-8189687 in JDK9. > JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > HWND hTop = GetTopLevelParentForWindow(hWnd); > ::ClientToScreen(hTop, &p); > + int sx = ScaleUpX(x) - p.x; > + int sy = ScaleUpY(y) - p.y; > if (!m_bitsCandType) { > - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); > + SetCandidateWindow(m_bitsCandType, sx, sy); > return; > } > for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { > if ( m_bitsCandType & bits ) > - SetCandidateWindow(iCandType, x - p.x, y - p.y); > + SetCandidateWindow(iCandType, sx, sy); > } > } > > > In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. Thanks. I think it'll be easier to get approval if the request is just a backport. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/483#issuecomment-2299159228 From sgehwolf at openjdk.org Tue Aug 20 15:44:52 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 15:44:52 GMT Subject: [jdk8u-dev] RFR: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java In-Reply-To: References: Message-ID: On Sat, 6 Jul 2024 14:10:57 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [6678b01c](https://github.com/openjdk/jdk/commit/6678b01c576532a393272dc74d87b6c180a869e7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Mar 2021 and was reviewed by Alexander Zuev, Tejpal Rebari and Pankaj Bansal. > > Thanks! Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/535#pullrequestreview-2248379978 From sgehwolf at openjdk.org Tue Aug 20 15:42:53 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 15:42:53 GMT Subject: [jdk8u-dev] RFR: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 In-Reply-To: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> References: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> Message-ID: On Wed, 12 Jun 2024 23:04:11 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [dedddd5a](https://github.com/openjdk/jdk/commit/dedddd5ab2e39a30a039d24f629a7974048b0923) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 May 2021 and was reviewed by Phil Race and Alexander Zvegintsev. > > Thanks! Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/520#pullrequestreview-2248375870 From syan at openjdk.org Tue Aug 20 15:52:08 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 15:52:08 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir [v2] In-Reply-To: References: Message-ID: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> > Hi all > This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > Only change the testcase lib file, the risk is low. > > This backport not clean, because of this PR include the same change to the Hotspot copy of `DockerTestUtils.java` > > Additional testing: > > - [x] jdk/test/jdk/internal/platform/docker > - [ ] hotspot/test/runtime/containers/docker > > [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) SendaoYan has updated the pull request incrementally with two additional commits since the last revision: - include the same change in the Hotspot copy of DockerTestUtils.java - include the same change in the Hotspot copy of DockerTestUtils.java ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/538/files - new: https://git.openjdk.org/jdk8u-dev/pull/538/files/4d1e313b..a89176e6 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=538&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=538&range=00-01 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/538.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/538/head:pull/538 PR: https://git.openjdk.org/jdk8u-dev/pull/538 From syan at openjdk.org Tue Aug 20 15:52:09 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 15:52:09 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir [v2] In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 15:34:09 GMT, Severin Gehwolf wrote: > Please include the same change in the Hotspot copy of `DockerTestUtils.java` in this backport. Thanks for the advice. The Hotspot copy of `DockerTestUtils.java` has included the same change just now. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/538#issuecomment-2299182886 From phh at openjdk.org Tue Aug 20 16:01:53 2024 From: phh at openjdk.org (Paul Hohensee) Date: Tue, 20 Aug 2024 16:01:53 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir [v2] In-Reply-To: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> References: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> Message-ID: On Tue, 20 Aug 2024 15:52:08 GMT, SendaoYan wrote: >> Hi all >> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. >> Only change the testcase lib file, the risk is low. >> >> This backport not clean, because of this PR include the same change to the Hotspot copy of `DockerTestUtils.java` >> >> Additional testing: >> >> - [x] jdk/test/jdk/internal/platform/docker >> - [x] hotspot/test/runtime/containers/docker >> >> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) > > SendaoYan has updated the pull request incrementally with two additional commits since the last revision: > > - include the same change in the Hotspot copy of DockerTestUtils.java > - include the same change in the Hotspot copy of DockerTestUtils.java Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/538#pullrequestreview-2248425244 From sgehwolf at openjdk.org Tue Aug 20 16:04:54 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Tue, 20 Aug 2024 16:04:54 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir [v2] In-Reply-To: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> References: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> Message-ID: <9YxAwCxHMnaPXLlcXwlBO_YICHulzLAIjwCG1BvweAU=.32dc3a2e-7127-4748-b59c-9df28dfc6b31@github.com> On Tue, 20 Aug 2024 15:52:08 GMT, SendaoYan wrote: >> Hi all >> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. >> Only change the testcase lib file, the risk is low. >> >> This backport not clean, because of this PR include the same change to the Hotspot copy of `DockerTestUtils.java` >> >> Additional testing: >> >> - [x] jdk/test/jdk/internal/platform/docker >> - [x] hotspot/test/runtime/containers/docker >> >> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) > > SendaoYan has updated the pull request incrementally with two additional commits since the last revision: > > - include the same change in the Hotspot copy of DockerTestUtils.java > - include the same change in the Hotspot copy of DockerTestUtils.java LGTM. ------------- Marked as reviewed by sgehwolf (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/538#pullrequestreview-2248432115 From syan at openjdk.org Tue Aug 20 16:15:56 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 16:15:56 GMT Subject: [jdk8u-dev] RFR: 8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Mon, 8 Jul 2024 07:50:00 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > Only change the testcase lib file, the risk is low. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138), but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory. > > Additional testing: > > - [x] hotspot/test/runtime/containers/docker > > [docker-tests.log](https://github.com/user-attachments/files/16124421/docker-tests.log) Include by https://github.com/openjdk/jdk8u-dev/pull/538 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/539#issuecomment-2299236007 From syan at openjdk.org Tue Aug 20 16:15:57 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 20 Aug 2024 16:15:57 GMT Subject: [jdk8u-dev] Withdrawn: 8335845: [8u] Fix hotspot/test/runtime/containers tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: <0bBeV2yPi5stauMbDuC3-I-yrdxp3UXABZruc2Jdb-0=.de852c40-8b35-44a0-bbdc-279bf8179b53@github.com> On Mon, 8 Jul 2024 07:50:00 GMT, SendaoYan wrote: > Hi all, > Fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > Only change the testcase lib file, the risk is low. > This is similar to [JDK-8309138](https://bugs.openjdk.org/browse/JDK-8309138), but in jdk8u-dev repository, there is a separated DockerTestUtils.java in hotspot/test directory. > > Additional testing: > > - [x] hotspot/test/runtime/containers/docker > > [docker-tests.log](https://github.com/user-attachments/files/16124421/docker-tests.log) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/539 From duke at openjdk.org Tue Aug 20 16:39:02 2024 From: duke at openjdk.org (duke) Date: Tue, 20 Aug 2024 16:39:02 GMT Subject: [jdk8u-dev] RFR: 8321480: ISO 4217 Amendment 176 Update [v4] In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 11:38:29 GMT, Karm Michal Babacek wrote: >> backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update >> >> depends on #559 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Append only 8321480 to ValidateISO4217 test @Karm Your change (at version bc18ee319f08663c17e011d3156f5592cf7964ba) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/561#issuecomment-2299255968 From duke at openjdk.org Tue Aug 20 16:44:06 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 20 Aug 2024 16:44:06 GMT Subject: [jdk8u-dev] Integrated: 8321480: ISO 4217 Amendment 176 Update In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 13:35:04 GMT, Karm Michal Babacek wrote: > backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > > depends on #559 This pull request has now been integrated. Changeset: 439e9104 Author: Karm Michal Babacek Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/439e910420ab9e1ca7c4645bb20634bc7cdbbe57 Stats: 27 lines in 5 files changed: 8 ins; 0 del; 19 mod 8321480: ISO 4217 Amendment 176 Update Reviewed-by: sgehwolf Backport-of: ea06b5c966e9261cacb35300ddde6eae48ec632f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/561 From duke at openjdk.org Tue Aug 20 17:08:28 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Tue, 20 Aug 2024 17:08:28 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v2] In-Reply-To: References: Message-ID: > backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update > depends on #561 Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/562/files - new: https://git.openjdk.org/jdk8u-dev/pull/562/files/df73302f..df73302f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=562&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=562&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/562.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/562/head:pull/562 PR: https://git.openjdk.org/jdk8u-dev/pull/562 From serb at openjdk.org Wed Aug 21 00:05:08 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 00:05:08 GMT Subject: [jdk8u-dev] Integrated: 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04 In-Reply-To: References: Message-ID: On Mon, 8 Jul 2024 05:46:09 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [ae60ed6f](https://github.com/openjdk/jdk11u-dev/commit/ae60ed6f0517465bbd164f600c3bccf25d6bb35a) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Goetz Lindenmaier on 23 Sep 2021 and was reviewed by Martin Doerr. > > Thanks! This pull request has now been integrated. Changeset: 2afd9188 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/2afd9188fa17d748dca15bcdc1f39bdb1c6dfca9 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8221903: PIT: javax/swing/RepaintManager/IconifyTest/IconifyTest.java fails on ubuntu18.04 Reviewed-by: aph Backport-of: ae60ed6f0517465bbd164f600c3bccf25d6bb35a ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/537 From serb at openjdk.org Wed Aug 21 00:12:06 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 00:12:06 GMT Subject: [jdk8u-dev] Integrated: 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java In-Reply-To: References: Message-ID: On Sat, 6 Jul 2024 14:10:57 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [6678b01c](https://github.com/openjdk/jdk/commit/6678b01c576532a393272dc74d87b6c180a869e7) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 29 Mar 2021 and was reviewed by Alexander Zuev, Tejpal Rebari and Pankaj Bansal. > > Thanks! This pull request has now been integrated. Changeset: 8b28c35f Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/8b28c35f2efe5f4d6bd2f4e36720ca6a529836dd Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod 8264328: Broken license in javax/swing/JComboBox/8072767/bug8072767.java Reviewed-by: sgehwolf Backport-of: 6678b01c576532a393272dc74d87b6c180a869e7 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/535 From ktakakuri at openjdk.org Wed Aug 21 00:13:08 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 21 Aug 2024 00:13:08 GMT Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong position In-Reply-To: References: Message-ID: <0ylC8T3g1rymXH85Agct75VrI69z_WJV-qt31BgOdek=.8f2c631a-3b52-4de1-89b9-a0151d8648bf@github.com> On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri wrote: > This fix includes a fix for JDK-8189687 in JDK9. > JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > HWND hTop = GetTopLevelParentForWindow(hWnd); > ::ClientToScreen(hTop, &p); > + int sx = ScaleUpX(x) - p.x; > + int sy = ScaleUpY(y) - p.y; > if (!m_bitsCandType) { > - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); > + SetCandidateWindow(m_bitsCandType, sx, sy); > return; > } > for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { > if ( m_bitsCandType & bits ) > - SetCandidateWindow(iCandType, x - p.x, y - p.y); > + SetCandidateWindow(iCandType, sx, sy); > } > } > > > In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. Thank you. I have created a backport. #564 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/483#issuecomment-2299971064 From serb at openjdk.org Wed Aug 21 00:21:09 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 00:21:09 GMT Subject: [jdk8u-dev] Integrated: 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails In-Reply-To: References: Message-ID: On Fri, 28 Jun 2024 16:32:51 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [b7540df6](https://github.com/openjdk/jdk/commit/b7540df6a4279c63e69d32b9d9834f7a427478d1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 5 Mar 2024 and was reviewed by Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 4c9c5a42 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/4c9c5a4275550fee0dbf46697255c147a8dc98b6 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod 8327007: javax/swing/JSpinner/8008657/bug8008657.java fails Reviewed-by: sgehwolf Backport-of: b7540df6a4279c63e69d32b9d9834f7a427478d1 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/530 From serb at openjdk.org Wed Aug 21 00:29:10 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 00:29:10 GMT Subject: [jdk8u-dev] Integrated: 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690 In-Reply-To: <96JBnFAoN4R4Flicahn2yjFji1blAhyq6MozR6JeJ7E=.763161cb-b3c8-4d6b-ad52-3da96ac7c6d9@github.com> References: <96JBnFAoN4R4Flicahn2yjFji1blAhyq6MozR6JeJ7E=.763161cb-b3c8-4d6b-ad52-3da96ac7c6d9@github.com> Message-ID: On Mon, 24 Jun 2024 23:05:59 GMT, Sergey Bylokhov wrote: > The missed line in the test is restored. This pull request has now been integrated. Changeset: 855480b9 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/855480b9336976cfdeea6ff5f57a712e4119e61a Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod 8334905: [8u] The test java/awt/Mixing/AWT_Mixing/JButtonOverlapping.java started to fail after 8159690 Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/525 From serb at openjdk.org Wed Aug 21 00:38:09 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 00:38:09 GMT Subject: [jdk8u-dev] Integrated: 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows. In-Reply-To: References: Message-ID: On Mon, 24 Jun 2024 05:59:28 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [791267a0](https://github.com/openjdk/jdk/commit/791267a0961353693ad6a92d888675b2e2837edc) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Yuri Nesterenko on 31 Jul 2015 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 4fe22e82 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/4fe22e82ebd3640c7999e094903874c9ac7f2391 Stats: 6 lines in 1 file changed: 4 ins; 0 del; 2 mod 6544871: java/awt/event/KeyEvent/KeyTyped/CtrlASCII.html fails from jdk b09 on windows. Backport-of: 791267a0961353693ad6a92d888675b2e2837edc ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/524 From syan at openjdk.org Wed Aug 21 01:06:06 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 01:06:06 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir [v2] In-Reply-To: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> References: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> Message-ID: On Tue, 20 Aug 2024 15:52:08 GMT, SendaoYan wrote: >> Hi all >> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. >> Only change the testcase lib file, the risk is low. >> >> This backport not clean, because of this PR include the same change to the Hotspot copy of `DockerTestUtils.java` >> >> Additional testing: >> >> - [x] jdk/test/jdk/internal/platform/docker >> - [x] hotspot/test/runtime/containers/docker >> >> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) > > SendaoYan has updated the pull request incrementally with two additional commits since the last revision: > > - include the same change in the Hotspot copy of DockerTestUtils.java > - include the same change in the Hotspot copy of DockerTestUtils.java Thanks all for the review and approved. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/538#issuecomment-2300013551 From duke at openjdk.org Wed Aug 21 01:06:06 2024 From: duke at openjdk.org (duke) Date: Wed, 21 Aug 2024 01:06:06 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir [v2] In-Reply-To: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> References: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> Message-ID: <26KnXH6_Cjc7g0119NaFl2oxGr8q5hSRpPr3OIV9QyM=.68effff1-5e79-4f14-8bc4-5c369d685d51@github.com> On Tue, 20 Aug 2024 15:52:08 GMT, SendaoYan wrote: >> Hi all >> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. >> Only change the testcase lib file, the risk is low. >> >> This backport not clean, because of this PR include the same change to the Hotspot copy of `DockerTestUtils.java` >> >> Additional testing: >> >> - [x] jdk/test/jdk/internal/platform/docker >> - [x] hotspot/test/runtime/containers/docker >> >> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) > > SendaoYan has updated the pull request incrementally with two additional commits since the last revision: > > - include the same change in the Hotspot copy of DockerTestUtils.java > - include the same change in the Hotspot copy of DockerTestUtils.java @sendaoYan Your change (at version a89176e637fd7f0ca365d31afaf0ffd7430ba2f1) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/538#issuecomment-2300014087 From serb at openjdk.org Wed Aug 21 04:42:42 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 04:42:42 GMT Subject: [jdk8u-dev] RFR: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 [v2] In-Reply-To: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> References: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> Message-ID: > Hi all, > > This pull request contains a backport of commit [dedddd5a](https://github.com/openjdk/jdk/commit/dedddd5ab2e39a30a039d24f629a7974048b0923) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 May 2021 and was reviewed by Phil Race and Alexander Zvegintsev. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-dedddd5a-master - Backport dedddd5ab2e39a30a039d24f629a7974048b0923 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/520/files - new: https://git.openjdk.org/jdk8u-dev/pull/520/files/c6e902ad..ed8082d2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=520&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=520&range=00-01 Stats: 32299 lines in 116 files changed: 2267 ins; 28465 del; 1567 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/520.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/520/head:pull/520 PR: https://git.openjdk.org/jdk8u-dev/pull/520 From syan at openjdk.org Wed Aug 21 08:50:14 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 08:50:14 GMT Subject: [jdk8u-dev] Integrated: 8309138: Fix container tests for jdks with symlinked conf dir In-Reply-To: References: Message-ID: On Mon, 8 Jul 2024 06:58:37 GMT, SendaoYan wrote: > Hi all > This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. > Only change the testcase lib file, the risk is low. > > This backport not clean, because of this PR include the same change to the Hotspot copy of `DockerTestUtils.java` > > Additional testing: > > - [x] jdk/test/jdk/internal/platform/docker > - [x] hotspot/test/runtime/containers/docker > > [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) This pull request has now been integrated. Changeset: 933c78eb Author: SendaoYan Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/933c78ebd5be5aedc2181b95917933dffe7e279c Stats: 6 lines in 2 files changed: 4 ins; 0 del; 2 mod 8309138: Fix container tests for jdks with symlinked conf dir Reviewed-by: phh, sgehwolf Backport-of: c1bb926f4d5eaf49777f93b9f8788db243bba83b ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/538 From syan at openjdk.org Wed Aug 21 09:11:13 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 21 Aug 2024 09:11:13 GMT Subject: [jdk8u-dev] RFR: 8309138: Fix container tests for jdks with symlinked conf dir [v2] In-Reply-To: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> References: <2dJYycj9vPviOuhypN_IZXirDfoEgJAHUXvWH7LatwE=.a78e609d-d732-4b92-991b-698fde114e18@github.com> Message-ID: On Tue, 20 Aug 2024 15:52:08 GMT, SendaoYan wrote: >> Hi all >> This is backport of JDK-8309138, to fix the testcase bug, which if the tested jdk directory is symlinked, symlinks are followed when copying tested jdk. >> Only change the testcase lib file, the risk is low. >> >> This backport not clean, because of this PR include the same change to the Hotspot copy of `DockerTestUtils.java` >> >> Additional testing: >> >> - [x] jdk/test/jdk/internal/platform/docker >> - [x] hotspot/test/runtime/containers/docker >> >> [docker-tests.log](https://github.com/user-attachments/files/16124002/docker-tests.log) > > SendaoYan has updated the pull request incrementally with two additional commits since the last revision: > > - include the same change in the Hotspot copy of DockerTestUtils.java > - include the same change in the Hotspot copy of DockerTestUtils.java Thanks for the sponsor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/538#issuecomment-2301550573 From afarley at openjdk.org Wed Aug 21 09:24:11 2024 From: afarley at openjdk.org (Adam Farley) Date: Wed, 21 Aug 2024 09:24:11 GMT Subject: [jdk8u-dev] RFR: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" In-Reply-To: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> References: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> Message-ID: On Wed, 10 Jul 2024 10:31:10 GMT, Adam Farley wrote: > ?lls: 51. After deopt 50" > > Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1. > > Backported manually from the jdk9u commit below: > 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee I will be going on vacation shortly. Please feel free to integrate this PR once sponsored. Thank you. :) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/545#issuecomment-2301577051 From sgehwolf at openjdk.org Wed Aug 21 09:28:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 21 Aug 2024 09:28:10 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v2] In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 17:08:28 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. @Karm Please merge master into this PR, resolve conflicts etc. Thanks! ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2301585507 From sgehwolf at openjdk.org Wed Aug 21 09:35:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 21 Aug 2024 09:35:10 GMT Subject: [jdk8u-dev] RFR: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" In-Reply-To: References: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> Message-ID: On Wed, 21 Aug 2024 09:21:20 GMT, Adam Farley wrote: >> ?lls: 51. After deopt 50" >> >> Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1. >> >> Backported manually from the jdk9u commit below: >> 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee > > I will be going on vacation shortly. Please feel free to integrate this PR once sponsored. Thank you. :) @adamfarley Please add `/integrate` and I'll sponsor. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/545#issuecomment-2301596499 From sgehwolf at openjdk.org Wed Aug 21 09:35:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 21 Aug 2024 09:35:10 GMT Subject: [jdk8u-dev] RFR: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" In-Reply-To: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> References: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> Message-ID: On Wed, 10 Jul 2024 10:31:10 GMT, Adam Farley wrote: > ?lls: 51. After deopt 50" > > Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1. > > Backported manually from the jdk9u commit below: > 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee See https://github.com/openjdk/jdk8u-dev/pull/545#issuecomment-2220291127 for the details. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/545#issuecomment-2301599243 From afarley at openjdk.org Wed Aug 21 09:46:12 2024 From: afarley at openjdk.org (Adam Farley) Date: Wed, 21 Aug 2024 09:46:12 GMT Subject: [jdk8u-dev] RFR: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" In-Reply-To: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> References: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> Message-ID: On Wed, 10 Jul 2024 10:31:10 GMT, Adam Farley wrote: > ?lls: 51. After deopt 50" > > Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1. > > Backported manually from the jdk9u commit below: > 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee Afterwards, right. Got mixed up. Thanks for clarifying. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/545#issuecomment-2301617239 From afarley at openjdk.org Wed Aug 21 09:46:13 2024 From: afarley at openjdk.org (Adam Farley) Date: Wed, 21 Aug 2024 09:46:13 GMT Subject: [jdk8u-dev] Integrated: 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" In-Reply-To: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> References: <-x6M0xjELfYYL5eHATRXEGERDE4SxmR3gyP1AOvjlvA=.5c029d3f-4955-4990-a1f1-1f18899dbf83@github.com> Message-ID: On Wed, 10 Jul 2024 10:31:10 GMT, Adam Farley wrote: > ?lls: 51. After deopt 50" > > Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1. > > Backported manually from the jdk9u commit below: > 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee This pull request has now been integrated. Changeset: 5c7f201a Author: Adam Farley Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/5c7f201af69a500b06a345f84a5b1ce550b605b2 Stats: 56 lines in 2 files changed: 43 ins; 0 del; 13 mod 8021775: compiler/8009761/Test8009761.java "Failed: init recursive calls: 51. After deopt 50" Reimplemented the test using the Whitebox API to deterministically trigger compilation and deoptimization. Now allowing number of recursive calls to vary by 1. Reviewed-by: sgehwolf Backport-of: 1ed4c8394859f6c36e165c4f59a6b5c9fbd793ee ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/545 From duke at openjdk.org Wed Aug 21 10:30:36 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Wed, 21 Aug 2024 10:30:36 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v3] In-Reply-To: References: Message-ID: > backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update > depends on #561 Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-561-amendment-175-176-177 - backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/562/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=562&range=02 Stats: 20 lines in 6 files changed: 2 ins; 1 del; 17 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/562.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/562/head:pull/562 PR: https://git.openjdk.org/jdk8u-dev/pull/562 From duke at openjdk.org Wed Aug 21 10:46:10 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Wed, 21 Aug 2024 10:46:10 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v3] In-Reply-To: References: Message-ID: <55vPTZ9YPIsbOasNzFA70DxUeCazlhunWGUgFEof-Vg=.9494100c-2fd0-4079-a1da-536d94002962@github.com> On Wed, 21 Aug 2024 10:30:36 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-561-amendment-175-176-177 > - backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update > - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update Cleaned, reconfigured, rebuilt, tested: $ TIME=`date +%s`;mkdir -p test.${TIME}/jdk/JTwork test.${TIME}/jdk/JTreport; jtreg -a -ignore:quiet -w:test.${TIME}/jdk/JTwork -r:test.${TIME}/jdk/JTreport -jdk:/home/karm/workspaceRH/jdk8u/build/linux-x86_64-normal-server-release/images/j2sdk-image/ /home/karm/workspaceRH/jdk8u/jdk/test/java/util/Currency/ Test results: passed: 5 Report written to /home/karm/Tools/jtreg/build/images/jtreg/bin/test.1724236868/jdk/JTreport/html/report.html Results written to /home/karm/Tools/jtreg/build/images/jtreg/bin/test.1724236868/jdk/JTwork ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2301743430 From yan at openjdk.org Wed Aug 21 10:50:09 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 21 Aug 2024 10:50:09 GMT Subject: [jdk8u-dev] Integrated: 8193682: Infinite loop in ZipOutputStream.close() In-Reply-To: References: Message-ID: On Tue, 13 Aug 2024 15:11:57 GMT, Yuri Nesterenko wrote: > This is a backport of JDK-8193682 already present in all 11+ releases of OpenJDK and in Oracle release 8u341. The problem was encountered in the wild and reported as a blocker. > > The backport of jdk11 version is clean with paths adjustments only. Performed testing did not reveal any issues. > > There will be a second fix in this series, JDK-8278794. This pull request has now been integrated. Changeset: 8867d017 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk8u-dev/commit/8867d017b18ad7cd8842b9324c5c031a44a58064 Stats: 257 lines in 4 files changed: 189 ins; 25 del; 43 mod 8193682: Infinite loop in ZipOutputStream.close() Reviewed-by: sgehwolf Backport-of: 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/558 From yan at openjdk.org Wed Aug 21 11:57:22 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 21 Aug 2024 11:57:22 GMT Subject: [jdk8u-dev] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() Message-ID: This is a second fix after "8193682: Infinite loop in ZipOutputStream.close()". Again, clean after 8193682 in code part, using jdk11 form as a prototype. The test added in the original fix had an issue fixed later in 8284771. Test is included in that fixed form. The issue 8284771 will be added to the commit message. ------------- Commit messages: - Backport ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 Changes: https://git.openjdk.org/jdk8u-dev/pull/565/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=565&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8278794 Stats: 379 lines in 5 files changed: 225 ins; 147 del; 7 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/565.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/565/head:pull/565 PR: https://git.openjdk.org/jdk8u-dev/pull/565 From sgehwolf at openjdk.org Wed Aug 21 12:32:06 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 21 Aug 2024 12:32:06 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v3] In-Reply-To: References: Message-ID: <_Mpgj-3jidP8hGx1EEukKSFa-ZM-fK6aooJLPEcFgPk=.22610e28-0eaf-4445-a6f5-50be5f0ee5ea@github.com> On Wed, 21 Aug 2024 10:30:36 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-561-amendment-175-176-177 > - backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update > - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update > /approval request Backporting regular ISO 4217 update from JDK 11. The backport adds only the new currency update, keeping the `FILEVERSION=2`, i.e. not dragging along other updates. Tests in jdk/test/java/util/Currency/ pass. @Karm In general, please only apply for approval once you have a successful review. I.e. review first, then approval. Thanks! It's OK this time. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2301934897 From duke at openjdk.org Wed Aug 21 13:14:08 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Wed, 21 Aug 2024 13:14:08 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v3] In-Reply-To: <_Mpgj-3jidP8hGx1EEukKSFa-ZM-fK6aooJLPEcFgPk=.22610e28-0eaf-4445-a6f5-50be5f0ee5ea@github.com> References: <_Mpgj-3jidP8hGx1EEukKSFa-ZM-fK6aooJLPEcFgPk=.22610e28-0eaf-4445-a6f5-50be5f0ee5ea@github.com> Message-ID: On Wed, 21 Aug 2024 12:29:11 GMT, Severin Gehwolf wrote: > > /approval request Backporting regular ISO 4217 update from JDK 11. The backport adds only the new currency update, keeping the `FILEVERSION=2`, i.e. not dragging along other updates. Tests in jdk/test/java/util/Currency/ pass. > > @Karm In general, please only apply for approval once you have a successful review. I.e. review first, then approval. Thanks! It's OK this time. Ack. Thx. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2302025115 From duke at openjdk.org Wed Aug 21 13:25:10 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Wed, 21 Aug 2024 13:25:10 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v3] In-Reply-To: <5--If0e9Hl7cXoOTX-Rnd2x2whyGnlo3Q3I3HHZm8tY=.1e14deee-9845-4974-8e79-04cc3f44cb35@github.com> References: <5--If0e9Hl7cXoOTX-Rnd2x2whyGnlo3Q3I3HHZm8tY=.1e14deee-9845-4974-8e79-04cc3f44cb35@github.com> Message-ID: On Wed, 21 Aug 2024 13:19:55 GMT, Andrew John Hughes wrote: > An additional blank line is removed in `CurrencyData.properties` and the bug ID line change is missing for `ValidateISO4217.java`. Otherwise, the backport matches the changes in the 11u version. > > Have you verified that the updated Currency tests pass against the patched build? https://github.com/openjdk/jdk8u-dev/pull/562#issuecomment-2301743430 i.e. yes I have, the Currency package. > jdk/src/share/classes/java/util/CurrencyData.properties line 60: > >> 58: XPT962-XSU994-XTS963-XUA965-XXX999-YER886-YUM891-ZAR710-ZMK894-ZMW967-ZWD716-ZWL932-\ >> 59: ZWN942-ZWR935 >> 60: > > This blank line should not be removed here. Will amend presently. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2302047926 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/562#discussion_r1725047090 From andrew at openjdk.org Wed Aug 21 13:25:09 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 21 Aug 2024 13:25:09 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v3] In-Reply-To: References: Message-ID: <5--If0e9Hl7cXoOTX-Rnd2x2whyGnlo3Q3I3HHZm8tY=.1e14deee-9845-4974-8e79-04cc3f44cb35@github.com> On Wed, 21 Aug 2024 10:30:36 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits: > > - Merge branch 'master' of https://git.openjdk.org/jdk8u-dev into pr-561-amendment-175-176-177 > - backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update > - backport ea06b5c JDK11 JDK-8321480 ISO 4217 Amendment 176 Update > - backport 8c243a3 JDK11 JDK-8305400 ISO 4217 Amendment 175 Update An additional blank line is removed in `CurrencyData.properties` and the bug ID line change is missing for `ValidateISO4217.java`. Otherwise, the backport matches the changes in the 11u version. Have you verified that the updated Currency tests pass against the patched build? jdk/src/share/classes/java/util/CurrencyData.properties line 60: > 58: XPT962-XSU994-XTS963-XUA965-XXX999-YER886-YUM891-ZAR710-ZMK894-ZMW967-ZWD716-ZWL932-\ > 59: ZWN942-ZWR935 > 60: This blank line should not be removed here. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/562#pullrequestreview-2250776734 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/562#discussion_r1725035410 From andrew at openjdk.org Wed Aug 21 13:46:12 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 21 Aug 2024 13:46:12 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: References: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> Message-ID: On Fri, 16 Aug 2024 13:09:56 GMT, Andrew Haley wrote: > This one is outside the usual rules for 8u, which is closed for enhancements. For that reason, it must be accompanied by a _very_ strong justification, and evidence that it carries no risk. By now, I'd have thought that everyone building JDK 8 on Windows etc. had workflows in place. We are at the (long) tail of the JDK 8 life cycle. I'm not sure I'd call this an enhancement. The lack of in-tree sources for FreeType means that there is no reference version of FreeType to build and test against, as there is with other libraries used by the AWT classes (libjpeg, libpng, giflib, LCMS). Historically, this is because Oracle did not use FreeType and its maintenance was largely left to others. There is evidence of this in this patch with the only JDK code changes being to allow FreeType to be used on non-OpenJDK builds (largely irrelevant to use I would expect) Yes, those on Windows & Mac likely have some way of building against FreeType in place, but it is an ongoing burden to maintain that version of FreeType, and it means every person building OpenJDK potentially uses some different version of FreeType. It's also an issue on the GNU/Linux side as there is no option *not* to use a system FreeType, which potentially reduces the portability of such builds. A build of OpenJDK may take place against one system installation of FreeType and then be used against a completely different one. The reason these issues have not been a bigger problem up to now is FreeType is a pretty stable library. I think the risk of introducing this now is still very low (as I say, there are very few code changes at all) and it improves the maintainability of 8u for everyone. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/318#issuecomment-2302097041 From yan at openjdk.org Wed Aug 21 13:42:07 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 21 Aug 2024 13:42:07 GMT Subject: [jdk8u-dev] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 11:51:03 GMT, Yuri Nesterenko wrote: > This is a second fix after "8193682: Infinite loop in ZipOutputStream.close()". Again, clean after 8193682 in code part, using jdk11 form as a prototype. The test added in the original fix had an issue fixed later in 8284771. Test is included in that fixed form. The issue 8284771 will be added to the commit message. Tests failures are unrelated: on macOS/hotspot it is again https://github.com/openjdk/jdk8u-dev/pull/544 it seems, and everything else is a certificate validation issue. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/565#issuecomment-2302089196 From yan at openjdk.org Wed Aug 21 15:00:08 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Wed, 21 Aug 2024 15:00:08 GMT Subject: [jdk8u-dev] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 11:51:03 GMT, Yuri Nesterenko wrote: > This is a second fix after "8193682: Infinite loop in ZipOutputStream.close()". Again, clean after 8193682 in code part, using jdk11 form as a prototype. The test added in the original fix had an issue fixed later in 8284771. Test is included in that fixed form. The issue 8284771 will be added to the commit message. Tests failures are unrelated: on macOS/hotspot it is again https://github.com/openjdk/jdk8u-dev/pull/544 it seems, and everything else is a certificate validation issue. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/565#issuecomment-2302268041 From phh at openjdk.org Wed Aug 21 18:03:09 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Aug 2024 18:03:09 GMT Subject: [jdk8u-dev] RFR: 8330561: [Windows][8u] IME candidate window wrong position In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri wrote: > This fix includes a fix for JDK-8189687 in JDK9. > JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > HWND hTop = GetTopLevelParentForWindow(hWnd); > ::ClientToScreen(hTop, &p); > + int sx = ScaleUpX(x) - p.x; > + int sy = ScaleUpY(y) - p.y; > if (!m_bitsCandType) { > - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); > + SetCandidateWindow(m_bitsCandType, sx, sy); > return; > } > for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { > if ( m_bitsCandType & bits ) > - SetCandidateWindow(iCandType, x - p.x, y - p.y); > + SetCandidateWindow(iCandType, sx, sy); > } > } > > > In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. Thanks. I've reviewed https://github.com/openjdk/jdk8u-dev/pull/564. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/483#issuecomment-2302662664 From phh at openjdk.org Wed Aug 21 18:03:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Wed, 21 Aug 2024 18:03:11 GMT Subject: [jdk8u-dev] RFR: 8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows In-Reply-To: References: Message-ID: On Tue, 20 Aug 2024 11:34:03 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8189687: Swing: Invalid position of candidate pop-up of InputMethod in Hi-DPI on Windows. > JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > HWND hTop = GetTopLevelParentForWindow(hWnd); > ::ClientToScreen(hTop, &p); > + int sx = ScaleUpX(x) - p.x; > + int sy = ScaleUpY(y) - p.y; > if (!m_bitsCandType) { > - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); > + SetCandidateWindow(m_bitsCandType, sx, sy); > return; > } > for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { > if ( m_bitsCandType & bits ) > - SetCandidateWindow(iCandType, x - p.x, y - p.y); > + SetCandidateWindow(iCandType, sx, sy); > } > } > > > In the attached test that reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/564#pullrequestreview-2251544345 From serb at openjdk.org Wed Aug 21 18:26:14 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 18:26:14 GMT Subject: [jdk8u-dev] Integrated: 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 In-Reply-To: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> References: <3lyNmOVPO_MnJb2l3MzUwkIExlF4-1pSuJ24U1lGfsM=.800c7770-0a7b-415b-9f84-2a20b4904e36@github.com> Message-ID: <_EIFZNV4AbL0vw56Tr7GjWpzUO_Tc1GohcMb40V2R_M=.972d86f1-bc54-4598-962d-cb611834849e@github.com> On Wed, 12 Jun 2024 23:04:11 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [dedddd5a](https://github.com/openjdk/jdk/commit/dedddd5ab2e39a30a039d24f629a7974048b0923) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 2 May 2021 and was reviewed by Phil Race and Alexander Zvegintsev. > > Thanks! This pull request has now been integrated. Changeset: fc33f51c Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/fc33f51c24d21e30a73ce3a70ba961651b483672 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 8266248: Compilation failure in PLATFORM_API_MacOSX_MidiUtils.c with Xcode 12.5 Reviewed-by: sgehwolf Backport-of: dedddd5ab2e39a30a039d24f629a7974048b0923 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/520 From serb at openjdk.org Wed Aug 21 18:42:08 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 18:42:08 GMT Subject: [jdk8u-dev] Integrated: 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails In-Reply-To: References: Message-ID: On Sun, 9 Jun 2024 04:37:21 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [c640fe42](https://github.com/openjdk/jdk/commit/c640fe42c2b5e6668a2a875678be44443942c868) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by lawrence.andrews on 5 Sep 2021 and was reviewed by Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: aa443466 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/aa443466bbe5f8326ab595ef9f4a2fa9919250e9 Stats: 182 lines in 1 file changed: 153 ins; 22 del; 7 mod 7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails Backport-of: c640fe42c2b5e6668a2a875678be44443942c868 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/515 From serb at openjdk.org Wed Aug 21 21:25:23 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 21:25:23 GMT Subject: [jdk8u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes [v2] In-Reply-To: References: Message-ID: > Hi all, > > This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-9b1d6d66 - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/506/files - new: https://git.openjdk.org/jdk8u-dev/pull/506/files/46967a47..efebfaf3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=506&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=506&range=00-01 Stats: 35040 lines in 158 files changed: 3273 ins; 29548 del; 2219 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/506.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/506/head:pull/506 PR: https://git.openjdk.org/jdk8u-dev/pull/506 From serb at openjdk.org Wed Aug 21 22:52:10 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 21 Aug 2024 22:52:10 GMT Subject: [jdk8u-dev] Integrated: 8318951: Additional negative value check in JPEG decoding In-Reply-To: References: Message-ID: On Thu, 30 May 2024 21:30:33 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [75ce02fe](https://github.com/openjdk/jdk/commit/75ce02fe74e1232bfa8d72b4fdad82ed938ef957) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Jayathirth D V on 31 Oct 2023 and was reviewed by Alexander Zvegintsev and Phil Race. > > Thanks! This pull request has now been integrated. Changeset: 9a426ad4 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/9a426ad460815f2637d53df37b27b68e64d5b75b Stats: 8 lines in 2 files changed: 8 ins; 0 del; 0 mod 8318951: Additional negative value check in JPEG decoding Reviewed-by: sgehwolf Backport-of: 75ce02fe74e1232bfa8d72b4fdad82ed938ef957 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/510 From syan at openjdk.org Thu Aug 22 01:27:09 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 22 Aug 2024 01:27:09 GMT Subject: [jdk8u-dev] RFR: 8255466: C2 crashes at ciObject::get_oop() const+0x0 In-Reply-To: References: Message-ID: On Sun, 7 Jul 2024 08:55:07 GMT, SendaoYan wrote: > Hi all > This is backport of JDK-8255466, to fixes the corner case in C2. This PR also fix the compiler warning `hotspot/src/share/vm/opto/type.cpp:2556:71: error: ?this? pointer is null` with gcc13. > Patch does not apply cleanly due to in jdk8u, the jtreg tag @run main need add `bootclasspath`. > New test fails without the patch, passes with it. > > Additional testing: > > - [x] linux x64 tier1/2/3 jtreg test > - [x] linux aarch64 tier1/2/3 jtreg test Wait the prefixed [PR](https://github.com/openjdk/jdk8u-dev/pull/552) merged. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/536#issuecomment-2303395677 From ktakakuri at openjdk.org Thu Aug 22 11:10:10 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Thu, 22 Aug 2024 11:10:10 GMT Subject: [jdk8u-dev] Withdrawn: 8330561: [Windows][8u] IME candidate window wrong position In-Reply-To: References: Message-ID: On Thu, 18 Apr 2024 08:48:09 GMT, Kazuhisa Takakuri wrote: > This fix includes a fix for JDK-8189687 in JDK9. > JDK-8189687 contains two fixes to AwtComponent:: OpenCandidateWindow > > 1. Fix to make OpenCandidateWindow reference the correct Window > Fix OpenCandidateWindow to reference the proxy window that has focus when getting "HWND." > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > { > UINT bits = 1; > POINT p = {0, 0}; // upper left corner of the client area > - HWND hWnd = GetHWnd(); > + HWND hWnd = ImmGetHWnd(); > if (!::IsWindowVisible(hWnd)) { > return; > } > > > > 2. Scaling fixes to enhance JDK-8073320 > OpenJDK9 has supported HiDPI Graphics since JEP 263 (JDK-8055212). This fix is one of its enhancements: when OpenCandidateWindow opens an IME conversion candidate, it corrects the coordinates for the device. > > > --- a/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > +++ b/src/java.desktop/windows/native/libawt/windows/awt_Component.cpp > @@ -3880,19 +3880,21 @@ void AwtComponent::OpenCandidateWindow(int x, int y) > HWND hTop = GetTopLevelParentForWindow(hWnd); > ::ClientToScreen(hTop, &p); > + int sx = ScaleUpX(x) - p.x; > + int sy = ScaleUpY(y) - p.y; > if (!m_bitsCandType) { > - SetCandidateWindow(m_bitsCandType, x - p.x, y - p.y); > + SetCandidateWindow(m_bitsCandType, sx, sy); > return; > } > for (int iCandType=0; iCandType<32; iCandType++, bits<<=1) { > if ( m_bitsCandType & bits ) > - SetCandidateWindow(iCandType, x - p.x, y - p.y); > + SetCandidateWindow(iCandType, sx, sy); > } > } > > > In attatchmented test which reproduces the issue problem, the Panel containing the TextField is a child component, so it refers to the wrong window to get the position coordinate of the candidate window. > Therefore, the candidate window will appear in the correct position with the "1" fix. > Note that OpenJDK8 does not implement JEP 263, so the "2" fix is not included in this pull request. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/483 From duke at openjdk.org Thu Aug 22 12:31:23 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Thu, 22 Aug 2024 12:31:23 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v4] In-Reply-To: References: Message-ID: > backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update > depends on #561 Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: Newline CurrencyData, bugid ValidateISO4217 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/562/files - new: https://git.openjdk.org/jdk8u-dev/pull/562/files/bb6d4914..71a321f2 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=562&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=562&range=02-03 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/562.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/562/head:pull/562 PR: https://git.openjdk.org/jdk8u-dev/pull/562 From sgehwolf at openjdk.org Thu Aug 22 15:03:10 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Thu, 22 Aug 2024 15:03:10 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v4] In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:31:23 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Newline CurrencyData, bugid ValidateISO4217 `CurrencyTest.java` is missing this hunk: @@ -60,7 +60,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; public class CurrencyTest { - // 'tablea1.txt' should be up-to-date before testing + // 'ISO4217-list-one.txt' should be up-to-date before testing @Test public void dataVersionTest() { CheckDataVersion.check(); See: https://github.com/openjdk/jdk11u-dev/commit/b05f58e9ec57ce7f140ad47df3b5bdf4cc42f5f9#diff-9b35965750742d3e80baa3c18194cd60156bf561990636e49fa0f6eadf4854dfR63 ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/562#pullrequestreview-2254788686 From duke at openjdk.org Thu Aug 22 20:02:12 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Thu, 22 Aug 2024 20:02:12 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v4] In-Reply-To: References: Message-ID: <1d6Yesm9oDfGGTwo09xIwdX-Xck0EEm1BiCma1cznrM=.6979859b-21d2-48af-92a3-9f99a0b6c768@github.com> On Thu, 22 Aug 2024 12:31:23 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Newline CurrencyData, bugid ValidateISO4217 > `CurrencyTest.java` is missing this hunk: > > ``` > @@ -60,7 +60,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows; > > public class CurrencyTest { > > - // 'tablea1.txt' should be up-to-date before testing > + // 'ISO4217-list-one.txt' should be up-to-date before testing > @Test > public void dataVersionTest() { > CheckDataVersion.check(); > ``` > > See: [openjdk/jdk11u-dev at b05f58e#diff-9b35965750742d3e80baa3c18194cd60156bf561990636e49fa0f6eadf4854dfR63](https://github.com/openjdk/jdk11u-dev/commit/b05f58e9ec57ce7f140ad47df3b5bdf4cc42f5f9#diff-9b35965750742d3e80baa3c18194cd60156bf561990636e49fa0f6eadf4854dfR63) @jerboaa Why do you think that? I did not port the tests to JUnit, I left that in its original state. The data file is loaded in CheckDataVersion. No point in bringing the comment that belongs to a JUnit that does not exist here IMHO. Or perhaps I misunderstood something. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2305526258 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2305529265 From phh at openjdk.org Thu Aug 22 21:29:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Aug 2024 21:29:11 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v3] In-Reply-To: References: Message-ID: On Thu, 14 Mar 2024 19:27:10 GMT, Sergey Bylokhov wrote: >> The tests are updated to force the MarlinRenderingEngine. >> >> @bourgesl please take a look. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8326110 > - PR feedback > - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/447#pullrequestreview-2255753007 From phh at openjdk.org Thu Aug 22 21:32:09 2024 From: phh at openjdk.org (Paul Hohensee) Date: Thu, 22 Aug 2024 21:32:09 GMT Subject: [jdk8u-dev] RFR: 8260380: Upgrade to LittleCMS 2.12 In-Reply-To: References: Message-ID: On Sat, 17 Aug 2024 00:28:23 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [4caeb39f](https://github.com/openjdk/jdk/commit/4caeb39f01b13b5472d8dacb268262fd418fd0c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 10 Feb 2021 and was reviewed by Jayathirth D V and Sergey Bylokhov. > > The backport is mostly clean, I had to update the license in `THIRD_PARTY_README` instead of `lcms.md`. > No new issues found by the :jdk_desktop tests. > > Thanks! Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/563#pullrequestreview-2255772009 From andrew at openjdk.org Fri Aug 23 01:09:12 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 23 Aug 2024 01:09:12 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v4] In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:31:23 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Newline CurrencyData, bugid ValidateISO4217 Thanks for correcting those two issues. Looks good to me now. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/562#pullrequestreview-2256030570 From andrew at openjdk.org Fri Aug 23 01:09:13 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 23 Aug 2024 01:09:13 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v4] In-Reply-To: <1d6Yesm9oDfGGTwo09xIwdX-Xck0EEm1BiCma1cznrM=.6979859b-21d2-48af-92a3-9f99a0b6c768@github.com> References: <1d6Yesm9oDfGGTwo09xIwdX-Xck0EEm1BiCma1cznrM=.6979859b-21d2-48af-92a3-9f99a0b6c768@github.com> Message-ID: On Thu, 22 Aug 2024 19:59:40 GMT, Karm Michal Babacek wrote: > Or perhaps I misunderstood something. No, this is the same conclusion I came to. 8u does not have [JDK-8310923](https://bugs.openjdk.org/browse/JDK-8310923) which completely refactors this test and is part of a bigger task to move to a newer version of JTreg across the testsuite. We don't intend to backport that to 8u. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2305991689 From syan at openjdk.org Fri Aug 23 02:49:09 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 23 Aug 2024 02:49:09 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u Hi, can anyone take look this backport to jdk8u. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2306082137 From duke at openjdk.org Fri Aug 23 09:36:12 2024 From: duke at openjdk.org (duke) Date: Fri, 23 Aug 2024 09:36:12 GMT Subject: [jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v4] In-Reply-To: References: Message-ID: On Thu, 22 Aug 2024 12:31:23 GMT, Karm Michal Babacek wrote: >> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update >> depends on #561 > > Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision: > > Newline CurrencyData, bugid ValidateISO4217 @Karm Your change (at version 71a321f22ec841e1d7bbdf6e57bb53c0f072c2c3) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2306693108 From duke at openjdk.org Fri Aug 23 12:06:16 2024 From: duke at openjdk.org (Karm Michal Babacek) Date: Fri, 23 Aug 2024 12:06:16 GMT Subject: [jdk8u-dev] Integrated: 8334653: ISO 4217 Amendment 177 Update In-Reply-To: References: Message-ID: On Wed, 14 Aug 2024 13:52:35 GMT, Karm Michal Babacek wrote: > backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update > depends on #561 This pull request has now been integrated. Changeset: 89697c3c Author: Karm Michal Babacek Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/89697c3c19f1276e92c6955600730b8d3353c4ea Stats: 20 lines in 6 files changed: 2 ins; 0 del; 18 mod 8334653: ISO 4217 Amendment 177 Update Reviewed-by: andrew Backport-of: b05f58e9ec57ce7f140ad47df3b5bdf4cc42f5f9 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/562 From phh at openjdk.org Fri Aug 23 14:20:11 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 23 Aug 2024 14:20:11 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/552#pullrequestreview-2257368927 From syan at openjdk.org Fri Aug 23 15:18:10 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 23 Aug 2024 15:18:10 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/552#issuecomment-2307297262 From phh at openjdk.org Fri Aug 23 15:42:05 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 23 Aug 2024 15:42:05 GMT Subject: [jdk8u-dev] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 11:51:03 GMT, Yuri Nesterenko wrote: > This is a second fix after "8193682: Infinite loop in ZipOutputStream.close()". Again, clean after 8193682 in code part, using jdk11 form as a prototype. The test added in the original fix had an issue fixed later in 8284771. Test is included in that fixed form. The issue 8284771 will be added to the commit message. Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/565#pullrequestreview-2257545645 From syan at openjdk.org Mon Aug 26 08:10:37 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 26 Aug 2024 08:10:37 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java Message-ID: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Hi all, This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, other files are backported cleanly. Test fix only, the risk is quite low. Additional testing: - [ ] full jtreg tests on linux x64 - [ ] full jtreg tests on linux aarch64 ------------- Commit messages: - Backpoer 8138382780b16f4184ad5bbfe07ab2468afe71a8 - 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java Changes: https://git.openjdk.org/jdk8u-dev/pull/567/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=567&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8266881 Stats: 52 lines in 7 files changed: 5 ins; 4 del; 43 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/567.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/567/head:pull/567 PR: https://git.openjdk.org/jdk8u-dev/pull/567 From syan at openjdk.org Mon Aug 26 08:23:08 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 26 Aug 2024 08:23:08 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, the risk is quite low. > > Additional testing: > > - [ ] full jtreg tests on linux x64 > - [ ] full jtreg tests on linux aarch64 Changes(total 6 releated testcases) has been verified locally. [test.log](https://github.com/user-attachments/files/16746117/test.log) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/567#issuecomment-2309630088 From syan at openjdk.org Mon Aug 26 08:27:07 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 26 Aug 2024 08:27:07 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: <6d3za-w-3FaTbLOmAmj2v9oKdcJ_xNVMizcq6uNlQqw=.fcbde2ce-d404-4e4a-ba95-c0087bbb34f0@github.com> On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, the risk is quite low. > > Additional testing: > > - [ ] full jtreg tests on linux x64 > - [ ] full jtreg tests on linux aarch64 approval JDK-8266881 Prefixed backport of JDK-8212096, add debug information, test-fix only, no risk. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/567#issuecomment-2309636553 From sgehwolf at openjdk.org Mon Aug 26 09:42:08 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 26 Aug 2024 09:42:08 GMT Subject: [jdk8u-dev] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 11:51:03 GMT, Yuri Nesterenko wrote: > This is a second fix after "8193682: Infinite loop in ZipOutputStream.close()". Again, clean after 8193682 in code part, using jdk11 form as a prototype. The test added in the original fix had an issue fixed later in 8284771. Test is included in that fixed form. The issue 8284771 will be added to the commit message. > Tests failures are unrelated: on macOS/hotspot it is again #544 it seems, and everything else is a certificate validation issue. Agreed. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/565#issuecomment-2309787731 From sgehwolf at openjdk.org Mon Aug 26 09:55:13 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Mon, 26 Aug 2024 09:55:13 GMT Subject: [jdk8u-dev] RFR: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 11:51:03 GMT, Yuri Nesterenko wrote: > This is a second fix after "8193682: Infinite loop in ZipOutputStream.close()". Again, clean after 8193682 in code part, using jdk11 form as a prototype. The test added in the original fix had an issue fixed later in 8284771. Test is included in that fixed form. The issue 8284771 will be added to the commit message. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/565#pullrequestreview-2260287995 From yan at openjdk.org Mon Aug 26 10:31:12 2024 From: yan at openjdk.org (Yuri Nesterenko) Date: Mon, 26 Aug 2024 10:31:12 GMT Subject: [jdk8u-dev] Integrated: 8278794: Infinite loop in DeflaterOutputStream.finish() In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 11:51:03 GMT, Yuri Nesterenko wrote: > This is a second fix after "8193682: Infinite loop in ZipOutputStream.close()". Again, clean after 8193682 in code part, using jdk11 form as a prototype. The test added in the original fix had an issue fixed later in 8284771. Test is included in that fixed form. The issue 8284771 will be added to the commit message. This pull request has now been integrated. Changeset: 49425166 Author: Yuri Nesterenko URL: https://git.openjdk.org/jdk8u-dev/commit/49425166c201e73dd954bd033ea6e33f4a9811b3 Stats: 379 lines in 5 files changed: 225 ins; 147 del; 7 mod 8278794: Infinite loop in DeflaterOutputStream.finish() 8284771: java/util/zip/CloseInflaterDeflaterTest.java failed with "AssertionError: Expected IOException to be thrown, but nothing was thrown" Reviewed-by: phh, sgehwolf Backport-of: ff0b0927a2df8b36f8fd6ed41bd4e20e71a5b653 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/565 From zzambers at openjdk.org Mon Aug 26 11:23:07 2024 From: zzambers at openjdk.org (Zdenek Zambersky) Date: Mon, 26 Aug 2024 11:23:07 GMT Subject: [jdk8u-dev] Integrated: 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory In-Reply-To: <9Sq8g4wXZ4l_aRUgNXH6VK4bTMLoE4IA0bs6qtNwrKs=.4da9e0e0-4563-4ce5-9eff-e5e597e4f836@github.com> References: <9Sq8g4wXZ4l_aRUgNXH6VK4bTMLoE4IA0bs6qtNwrKs=.4da9e0e0-4563-4ce5-9eff-e5e597e4f836@github.com> Message-ID: <9ZAJNAj8g-Ejs72VjREYs3yEsTUbSNmSPKm4dtN7UDg=.3c9b2492-ba8c-478a-a16e-9dc6cd3639af@github.com> On Wed, 24 Jul 2024 10:46:31 GMT, Zdenek Zambersky wrote: > `TestNoEagerReclaimOfHumongousRegions.java` is placed (as the only test) in `gc_implementation/g1` directory instead of `gc/g1`, where similar tests are placed. As a result test is not part of any test group and is currently not executed as part of tier1. > > This seems like mistake in JDK-8139424 backport ([orig](https://github.com/openjdk/jdk/commit/6983acfb5f19b4873ec144ad9a38a27c2b0bb402), [8](https://github.com/openjdk/jdk8u-dev/commit/baf5076889f3e5b4c535e1a25f00eb629de15770)). Hotspot code uses dir named `gc_implementation` instead of `gc` on 8, but this is not the case for tests. > > This change moves `TestNoEagerReclaimOfHumongousRegions.java` hotspot test from `gc_implementation/g1` -> `gc/g1`. > > **Testing:** > tier1: OK (After this change, test newly executes as part of tier1 and passes on all systems. Failures of other tests are unrelated.) This pull request has now been integrated. Changeset: 7d36fed8 Author: Zdenek Zambersky URL: https://git.openjdk.org/jdk8u-dev/commit/7d36fed8e01c6ee0a1b301a379df5dae8afa960d Stats: 0 lines in 1 file changed: 0 ins; 0 del; 0 mod 8337110: [8u] TestNoEagerReclaimOfHumongousRegions.java should be in gc/g1 directory Reviewed-by: phh ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/551 From syan at openjdk.org Mon Aug 26 12:34:11 2024 From: syan at openjdk.org (SendaoYan) Date: Mon, 26 Aug 2024 12:34:11 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, the risk is quite low. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 All the GHA test failures are unreleated to this PR 1. [Linux x64 (jdk/tier1)](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/10555873125/job/29240793571#logs) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526 2. [Linux x86 (jdk/tier1)](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/10555873125/job/29240916614#logs) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526 3. [Windows x64 (jdk/tier1)](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/10555873125/job/29241921407#logs) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526 4. [Windows x86 (jdk/tier1)](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/10555873125/job/29241181093#logs) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526 5. [MacOS x64 (jdk/tier1)](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/10555873125/job/29241181093#logs) failures fixing by https://github.com/openjdk/jdk8u-dev/pull/526 6. [macOS x64 (hotspot/tier1)](https://github.com/sendaoYan/jdk8u-dev-ysd/actions/runs/10555873125/job/29240998277#logs) report `compiler/unsafe/OpaqueAccesses.java` is a known failure, which has been recorded by [JDK-8337185](https://bugs.openjdk.org/browse/JDK-8337185) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/567#issuecomment-2310097136 From phh at openjdk.org Mon Aug 26 23:07:05 2024 From: phh at openjdk.org (Paul Hohensee) Date: Mon, 26 Aug 2024 23:07:05 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 Marked as reviewed by phh (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/567#pullrequestreview-2261798387 From syan at openjdk.org Tue Aug 27 06:43:10 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 27 Aug 2024 06:43:10 GMT Subject: [jdk8u-dev] RFR: 8266881: Enable debug log for SSLEngineExplorerMatchedSNI.java In-Reply-To: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> References: <2E0dddUXPlbd3bSrNk-i6OD66Pck2Iwzu1YKhDeyI58=.fe132c6b-35a7-4316-977e-ebd6faf865b5@github.com> Message-ID: On Mon, 26 Aug 2024 08:02:37 GMT, SendaoYan wrote: > Hi all, > This PR contains two backports [JDK-8266881](https://github.com/openjdk/jdk11u-dev/commit/8138382780b16f4184ad5bbfe07ab2468afe71a8) and [JDK-8227651](https://github.com/openjdk/jdk11u-dev/commit/e8b7e77c8b71946eaee952443e001105b48fe73e) from jdk11u-dev. > We observed `javax/net/ssl/ServerName/SSLEngineExplorerMatchedSNI.java failed intermittently due to SSLException: Tag mismatch` by ours nightly CI, so we want to backport these two PRs to fix the test bugs which cause intermittent fails. > > The change in `test/jdk/ProblemList.txt` was not needed deal with in jdk8u-dev, all other files are backported cleanly. > > Changes(total 6 releated testcases) has been verified locally. Test fix only, no risk. > > Additional testing: > > - [x] full jtreg tests on linux x64 > - [x] full jtreg tests on linux aarch64 Thanks for the review. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/567#issuecomment-2311692608 From andrew at openjdk.org Wed Aug 28 00:38:24 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 28 Aug 2024 00:38:24 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Thu, 25 Jul 2024 03:21:08 GMT, SendaoYan wrote: >> Hi all, >> This is backport of [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825). It's prefixed PR for [JDK-8255466](https://bugs.openjdk.org/browse/JDK-8255466) [backport](https://github.com/openjdk/jdk8u-dev/pull/536). >> New test fails without the patch, passes with it. >> >> There are two parts make this backport not clean: >> >> 1. Patch does not apply cleanly due to different context, before [JDK-8250825](https://bugs.openjdk.org/browse/JDK-8250825) the PR [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) change releated lines, and I think [JDK-8230505](https://bugs.openjdk.org/browse/JDK-8230505) do not needed backport to jdk8u-dev. >> 2. The added testcase can't backport to jdk8u directly, `import jdk.internal.misc.Unsafe` should instead of `import sun.misc.Unsafe` in jdk8u. >> >> >> >> Additional testing: >> >> - [x] linux x64 tier1/2/3 jtreg test >> - [x] inux aarch64 tier1/2/3 jtreg test > > SendaoYan has updated the pull request incrementally with one additional commit since the last revision: > > implement Unsafe.getUnsafe() in jdk8u The change to the test for `Unsafe` looks fine and matches other 8u tests that use `Unsafe`. I'm not sure what patch you're backporting from, but the 11u version is already adjusted for the absence of JDK-8230505. If you fix up the indentation to match 11u, this should be good to go. hotspot/src/share/vm/opto/type.cpp line 2561: > 2559: BasicType basic_elem_type = field->layout_type(); > 2560: _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || > 2561: basic_elem_type == T_ARRAY); This line hasn't been adjusted to line up with the one above. Are you not backporting from the 11u patch? That also doesn't have JDK-8230505 and would match your patch exactly if not for this misaligned line. This is the 11u version: ~~~ - assert(field != NULL, "missing field"); - BasicType basic_elem_type = field->layout_type(); - _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || - basic_elem_type == T_ARRAY); + if (field != NULL) { + BasicType basic_elem_type = field->layout_type(); + _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || + basic_elem_type == T_ARRAY); + } else { + // unsafe access + _is_ptr_to_narrowoop = UseCompressedOops; + } ~~~ ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/552#pullrequestreview-2264717131 PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/552#discussion_r1733694929 From andrew at openjdk.org Wed Aug 28 00:58:28 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 28 Aug 2024 00:58:28 GMT Subject: [jdk8u-dev] RFR: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option In-Reply-To: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> References: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> Message-ID: On Wed, 3 Jul 2024 04:53:56 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0abb2b14](https://github.com/openjdk/jdk/commit/0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 3 Feb 2014 and was reviewed by Michael McMahon. > > Thanks! Confirmed clean. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/533#pullrequestreview-2264769885 From apangin at openjdk.org Wed Aug 28 02:22:07 2024 From: apangin at openjdk.org (Andrei Pangin) Date: Wed, 28 Aug 2024 02:22:07 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method Message-ID: When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. The fix is trivial and safe: it affects only `AsyncGetCallTrace`. Testing: tier1, renaissance suite with async-profiler enabled ------------- Commit messages: - 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method Changes: https://git.openjdk.org/jdk8u-dev/pull/568/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=568&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339133 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/568.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/568/head:pull/568 PR: https://git.openjdk.org/jdk8u-dev/pull/568 From syan at openjdk.org Wed Aug 28 02:25:25 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 02:25:25 GMT Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee. > > Trivial fix but useful, no risk. > > Thanks! Hi all, does this backport useful to jdk8u-dev. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/556#issuecomment-2313959648 From syan at openjdk.org Wed Aug 28 03:22:24 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 03:22:24 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 00:31:07 GMT, Andrew John Hughes wrote: >> SendaoYan has updated the pull request incrementally with one additional commit since the last revision: >> >> implement Unsafe.getUnsafe() in jdk8u > > hotspot/src/share/vm/opto/type.cpp line 2561: > >> 2559: BasicType basic_elem_type = field->layout_type(); >> 2560: _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || >> 2561: basic_elem_type == T_ARRAY); > > This line hasn't been adjusted to line up with the one above. > > Are you not backporting from the 11u patch? That also doesn't have JDK-8230505 and would match your patch exactly if not for this misaligned line. > > This is the 11u version: > > ~~~ > - assert(field != NULL, "missing field"); > - BasicType basic_elem_type = field->layout_type(); > - _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || > - basic_elem_type == T_ARRAY); > + if (field != NULL) { > + BasicType basic_elem_type = field->layout_type(); > + _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || > + basic_elem_type == T_ARRAY); > + } else { > + // unsafe access > + _is_ptr_to_narrowoop = UseCompressedOops; > + } > ~~~ No, I was backported from jdk trunk repo. But I think line 2561 is not misaligned line, it just a github code display style issue. The below screenshot can explain the difference. The left side shows this PR change, the right side shows the jdk11u-dev change of JDK-8250825. I think the change is equivalent. ![image](https://github.com/user-attachments/assets/479e94da-7984-4d8a-9b2c-5a6832e5c2e2) ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/552#discussion_r1733922166 From syan at openjdk.org Wed Aug 28 03:30:25 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 03:30:25 GMT Subject: [jdk8u-dev] RFR: 8250825: C2 crashes with assert(field != __null) failed: missing field [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 03:19:32 GMT, SendaoYan wrote: >> hotspot/src/share/vm/opto/type.cpp line 2561: >> >>> 2559: BasicType basic_elem_type = field->layout_type(); >>> 2560: _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || >>> 2561: basic_elem_type == T_ARRAY); >> >> This line hasn't been adjusted to line up with the one above. >> >> Are you not backporting from the 11u patch? That also doesn't have JDK-8230505 and would match your patch exactly if not for this misaligned line. >> >> This is the 11u version: >> >> ~~~ >> - assert(field != NULL, "missing field"); >> - BasicType basic_elem_type = field->layout_type(); >> - _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || >> - basic_elem_type == T_ARRAY); >> + if (field != NULL) { >> + BasicType basic_elem_type = field->layout_type(); >> + _is_ptr_to_narrowoop = UseCompressedOops && (basic_elem_type == T_OBJECT || >> + basic_elem_type == T_ARRAY); >> + } else { >> + // unsafe access >> + _is_ptr_to_narrowoop = UseCompressedOops; >> + } >> ~~~ > > No, I was backported from jdk trunk repo. But I think line 2561 is not misaligned line, it just a github code display style issue. The below screenshot can explain the difference. The left side shows this PR change, the right side shows the jdk11u-dev change of JDK-8250825. I think the change is equivalent. > > ![image](https://github.com/user-attachments/assets/479e94da-7984-4d8a-9b2c-5a6832e5c2e2) Backport from jdk11u-dev to jdk8u-dev is more reasonable and exactly than from jdk trunk. I will pay attention for that. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/552#discussion_r1733926318 From syan at openjdk.org Wed Aug 28 03:47:21 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 28 Aug 2024 03:47:21 GMT Subject: [jdk8u-dev] RFR: 8244966: Add .vscode to .hgignore and .gitignore In-Reply-To: References: Message-ID: On Tue, 30 Jul 2024 15:11:18 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit [95c0b97b](https://github.com/openjdk/jdk11u-dev/commit/95c0b97bc2bfcb686dfabc6d74424772f0f866a1) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by SendaoYan on 30 Jul 2024 and was reviewed by Paul Hohensee. > > Trivial fix but useful, no risk. > > Thanks! The GHA report several failures, all the failures are unreleated to this PR. 1. windows x86 build [fails](https://github.com/openjdk-bots/jdk8u-dev/actions/runs/10164981708/job/28111895084) `_isnan referenced in function _checkOverflow` which has been recorded and fixed by [JDK-8337312](https://bugs.openjdk.org/browse/JDK-8337312) 2. macosx-64 jdk/tier1 report `com/sun/jdi` tests [fails](https://github.com/openjdk-bots/jdk8u-dev/actions/runs/10164981708/job/28112859874), `transport error 202: gethostbyname: unknown host` seems to be GHA environmental issue. 3. macos-x64 hotpsot/tier1 report `OpaqueAccesses.java` fails, which has been recorded by [JDK-8337185](https://bugs.openjdk.org/browse/JDK-8337185) 4. macos-x64 hotpsot/tier1 report `FieldMonitor.java` fails, same to 2 5. All the fails are CA test fails, which fixing by https://github.com/openjdk/jdk8u-dev/pull/526 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/556#issuecomment-2314143038 From apangin at openjdk.org Wed Aug 28 10:42:37 2024 From: apangin at openjdk.org (Andrei Pangin) Date: Wed, 28 Aug 2024 10:42:37 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: > When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: > > guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); > > According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. > > Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. > > The fix is trivial and safe: it affects only `AsyncGetCallTrace`. > > Testing: tier1, renaissance suite with async-profiler enabled Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/568/files - new: https://git.openjdk.org/jdk8u-dev/pull/568/files/03002200..39d64536 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=568&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=568&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/568.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/568/head:pull/568 PR: https://git.openjdk.org/jdk8u-dev/pull/568 From duke at openjdk.org Wed Aug 28 13:35:30 2024 From: duke at openjdk.org (duke) Date: Wed, 28 Aug 2024 13:35:30 GMT Subject: [jdk8u-dev] Withdrawn: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> Message-ID: On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows. > The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead. > > Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64 This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/498 From duke at openjdk.org Wed Aug 28 13:36:30 2024 From: duke at openjdk.org (duke) Date: Wed, 28 Aug 2024 13:36:30 GMT Subject: [jdk8u-dev] Withdrawn: 8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism In-Reply-To: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> References: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> Message-ID: On Tue, 7 May 2024 12:39:47 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 > The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/493 From stuefe at openjdk.org Wed Aug 28 14:30:24 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 28 Aug 2024 14:30:24 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 10:42:37 GMT, Andrei Pangin wrote: >> When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: >> >> guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); >> >> According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. >> >> Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. >> >> The fix is trivial and safe: it affects only `AsyncGetCallTrace`. >> >> Testing: tier1, renaissance suite with async-profiler enabled > > Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method Hi Andrey, why do you submit this as a jdk 8 PR? Why not fix it upstream? Is it not an issue on JDK 11/17/21 etc? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/568#issuecomment-2315493814 From apangin at openjdk.org Wed Aug 28 15:34:26 2024 From: apangin at openjdk.org (Andrei Pangin) Date: Wed, 28 Aug 2024 15:34:26 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 14:27:47 GMT, Thomas Stuefe wrote: >> Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method > > Hi Andrey, why do you submit this as a jdk 8 PR? Why not fix it upstream? Is it not an issue on JDK 11/17/21 etc? @tstuefe The issue has been already fixed in upstream in JDK-8329103 and then backported to 21u, 17u and 11u. I created a separate issue for 8u instead of calling it a backport because: (1) in jdk8u, there is no assertion mentioned in the title of JDK-8329103; (2) the patch for JDK-8329103 does not apply to jdk8u, the fix needs to be implemented differently, although the idea is essentially the same. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/568#issuecomment-2315682787 From stuefe at openjdk.org Wed Aug 28 15:39:27 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 28 Aug 2024 15:39:27 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 10:42:37 GMT, Andrei Pangin wrote: >> When running AsyncGetCallTrace based profiler, JVM occasionally crashes on the guarantee at codeCache.cpp:287: >> >> guarantee(is_result_safe || is_in_asgct(), "unsafe access to zombie method"); >> >> According to the stack trace, a thread is inside `AsyncGetCallTrace` at the moment of crash, but `is_in_asgct() == false`. >> >> Current implementation of `AsyncGetCallTrace` is not reentrant, since it incorrectly resets `in_asgct` flag of the current thread. The fix is similar to [JDK-8329103](https://bugs.openjdk.org/browse/JDK-8329103): `in_asgct` should be reset to previous value instead of `false`. >> >> The fix is trivial and safe: it affects only `AsyncGetCallTrace`. >> >> Testing: tier1, renaissance suite with async-profiler enabled > > Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method LGTM ------------- Marked as reviewed by stuefe (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/568#pullrequestreview-2266646151 From stuefe at openjdk.org Wed Aug 28 15:39:27 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Wed, 28 Aug 2024 15:39:27 GMT Subject: [jdk8u-dev] RFR: 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method [v2] In-Reply-To: References: Message-ID: On Wed, 28 Aug 2024 14:27:47 GMT, Thomas Stuefe wrote: >> Andrei Pangin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: >> >> 8339133: [8u] Profiler crashes at guarantee(is_result_safe || is_in_asgct()): unsafe access to zombie method > > Hi Andrey, why do you submit this as a jdk 8 PR? Why not fix it upstream? Is it not an issue on JDK 11/17/21 etc? > @tstuefe The issue has been already fixed in upstream in JDK-8329103 and then backported to 21u, 17u and 11u. I created a separate issue for 8u instead of calling it a backport because: (1) in jdk8u, there is no assertion mentioned in the title of JDK-8329103; (2) the patch for JDK-8329103 does not apply to jdk8u, the fix needs to be implemented differently, although the idea is essentially the same. Okay, thank you for the explanation. Up to @gnu-andrew to decide if this is the right approach. Technically, the patch is fine. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/568#issuecomment-2315694755 From serb at openjdk.org Wed Aug 28 23:03:23 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Wed, 28 Aug 2024 23:03:23 GMT Subject: [jdk8u-dev] Integrated: 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option In-Reply-To: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> References: <5BIJtu3y24vrFbugvJHxJCRKclescwYVCUDcuEFHhkM=.624c3b66-2ffb-4783-b253-68ab480a2ae6@github.com> Message-ID: On Wed, 3 Jul 2024 04:53:56 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0abb2b14](https://github.com/openjdk/jdk/commit/0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alan Bateman on 3 Feb 2014 and was reviewed by Michael McMahon. > > Thanks! This pull request has now been integrated. Changeset: 7c13bd84 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/7c13bd84274ffdd437ffcc3b39694f9efce0ec1b Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod 8030795: java/nio/file/Files/probeContentType/ForceLoad.java failing with ServiceConfigurationError without jtreg -agentvm option Reviewed-by: aph, andrew Backport-of: 0abb2b14edd9f7b4de461efa47fe31b4cbfb92c1 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/533 From serb at openjdk.org Thu Aug 29 02:18:49 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Thu, 29 Aug 2024 02:18:49 GMT Subject: [jdk8u-dev] RFR: 8133287: (fs) java/nio/file/Files/probeContentType/ParallelProbes.java should use othervm mode Message-ID: Hi all, This pull request contains a backport of commit [eb790603](https://github.com/openjdk/jdk/commit/eb790603374262134543bb03171a6ead1b13fc4b) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Brian Burkhalter on 11 Aug 2015 and was reviewed by Joe Darcy. Thanks! ------------- Commit messages: - Backport eb790603374262134543bb03171a6ead1b13fc4b Changes: https://git.openjdk.org/jdk8u-dev/pull/570/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=570&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8133287 Stats: 2 lines in 1 file changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/570.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/570/head:pull/570 PR: https://git.openjdk.org/jdk8u-dev/pull/570 From syan at openjdk.org Thu Aug 29 15:50:26 2024 From: syan at openjdk.org (SendaoYan) Date: Thu, 29 Aug 2024 15:50:26 GMT Subject: [jdk8u-dev] RFR: 8298527: Cygwin's uname -m returns different string than before In-Reply-To: References: Message-ID: <2aGe9eZDC3O_YNpx55JkuNX1p3U-X0co_vAxtp61g9A=.bf310304-4700-4ab6-b67d-2bffbc426f84@github.com> On Thu, 16 May 2024 07:48:31 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of [JDK-8298527](https://bugs.openjdk.org/browse/JDK-8298527), commit [1da982b4](https://github.com/openjdk/jdk17u-dev/commit/1da982b4f4653002177b1bb2deee7688f2600c05) from the [openjdk/jdk17u-dev](https://git.openjdk.org/jdk17u-dev) repository. > I had to resolve because RISCV64 was not handled in jdk8u-dev yet. > > The commit being backported was authored by Christoph Langer on 22 Dec 2022 and was reviewed by Matthias Baesken. > > This backport not clean bacause of file `common/autoconf/build-aux/config.guess` was move to `make/autoconf/build-aux/config.guess` > > Thanks! Before this PR has been reviewed, the approval label should not seted. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/499#issuecomment-2318198594 From andrew at openjdk.org Thu Aug 29 17:47:53 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 29 Aug 2024 17:47:53 GMT Subject: [jdk8u-dev] RFR: 8328999: Update GIFlib to 5.2.2 Message-ID: <9ZtnRvABbtHSlYnLBINebgkvpNyoCxJuZ97PZRbfnCM=.02cc0ea5-908c-4542-8d64-a521e01c69fe@github.com> This updates the in-tree giflib to 5.2.2. The actual code changes are a clean backport, but the license file changes needed adapting from the `giflib.md` file in 11u and later to the `THIRD_PARTY_README` file in 8u (now only one copy following [JDK-8338144](https://bugs.openjdk.org/browse/JDK-8338144)) 8u is also missing [JDK-8225487](https://bugs.openjdk.org/browse/JDK-8225487) which I've included as part of this patch. This updates the license to credit `openbsd-reallocarray.c` and is updated further by 8238999. I also included changes made by the 5.2.1 update which were missed because 8225487 was missing. The `giflib.md` changes include some odd changes, replacing the giflib VCS URL with just `tree/README`. I've raised [8339271](https://bugs.openjdk.org/browse/JDK-8339271) to correct this. ------------- Commit messages: - Backport bc8aeb6496b7e86d1f616d4c1b7c26f172c1dd8a Changes: https://git.openjdk.org/jdk8u-dev/pull/571/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=571&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8328999 Stats: 847 lines in 8 files changed: 182 ins; 105 del; 560 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/571.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/571/head:pull/571 PR: https://git.openjdk.org/jdk8u-dev/pull/571 From andrew at openjdk.org Fri Aug 30 00:23:24 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 00:23:24 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. [v6] In-Reply-To: References: Message-ID: On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. >> >> This patch has already been applied to OracleJDK8. >> As noted in the Bug Issue comments, some tests do not exist in 8u. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Merge branch 'master' into 8160974 > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 Contrary to the approval request, this does not seem like a "mostly clean backport" if 56 files are being skipped. It will take some time to review this as with [JDK-8159690](https://bugs.openjdk.org/browse/JDK-8159690) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2319529845 From andrew at openjdk.org Fri Aug 30 00:36:23 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 00:36:23 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java In-Reply-To: References: Message-ID: <0SSfVPPhM2qbpdSGivl2TjIY_nxXpu_jOAdmO3VHwlA=.0e6666b1-1ab0-4a12-a883-0e074b90a1cc@github.com> On Sun, 30 Jun 2024 03:42:07 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [40e667c1](https://github.com/openjdk/jdk/commit/40e667c174269a73cd9b5612673c5e4b2293d6c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov. > > Thanks! Patch verified clean. This is a MacOS patch but the GHA MacOS build has not been run. Please merge with the current jdk8u-dev so that the Mac build runs before we approve this patch. It should be working now (see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/10619513292/job/29437308137 for example) ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/531#pullrequestreview-2270693270 PR Comment: https://git.openjdk.org/jdk8u-dev/pull/531#issuecomment-2319551400 From andrew at openjdk.org Fri Aug 30 00:39:24 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 00:39:24 GMT Subject: [jdk8u-dev] RFR: 8298887: On the latest macOS+XCode the Robot API may report wrong colors In-Reply-To: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com> References: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com> Message-ID: On Mon, 26 Feb 2024 20:40:53 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [ceb6793b](https://github.com/openjdk/jdk11u-dev/commit/ceb6793bf3b5855c7c521678b5d99d752800b441) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Sergey Bylokhov on 5 May 2023 and was reviewed by Paul Hohensee. > > This patch is needed to support XCode 14.2+ > > Thanks! Patch looks good. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/457#pullrequestreview-2270697986 From andrew at openjdk.org Fri Aug 30 00:44:24 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 00:44:24 GMT Subject: [jdk8u-dev] RFR: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes [v2] In-Reply-To: References: Message-ID: On Wed, 21 Aug 2024 21:25:23 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-9b1d6d66 > - Backport 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb Looks like a trivial clean backport to me. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/506#pullrequestreview-2270703777 From andrew at openjdk.org Fri Aug 30 00:48:24 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 00:48:24 GMT Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Mon, 10 Jun 2024 02:24:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov. > > Thanks! This looks clean but then it is just introducing new files. Can you confirm these tests all build, run and pass on 8u? ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/516#pullrequestreview-2270708766 From serb at openjdk.org Fri Aug 30 00:58:50 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 30 Aug 2024 00:58:50 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java [v2] In-Reply-To: References: Message-ID: <4HKQdNRnRVZsibOr9MZeJ3dyC4UW85h9JoGA11lW0To=.9b3f782f-0d67-471c-8c6e-de435b6c52c6@github.com> > Hi all, > > This pull request contains a backport of commit [40e667c1](https://github.com/openjdk/jdk/commit/40e667c174269a73cd9b5612673c5e4b2293d6c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-40e667c1-master - Backport 40e667c174269a73cd9b5612673c5e4b2293d6c0 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/531/files - new: https://git.openjdk.org/jdk8u-dev/pull/531/files/6ec6e798..7dd33590 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=531&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=531&range=00-01 Stats: 28343 lines in 106 files changed: 1450 ins; 26369 del; 524 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/531.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/531/head:pull/531 PR: https://git.openjdk.org/jdk8u-dev/pull/531 From andrew at openjdk.org Fri Aug 30 01:25:29 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 01:25:29 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: References: Message-ID: On Thu, 15 Aug 2024 23:25:16 GMT, Sergey Bylokhov wrote: >> doc/building.md line 408: >> >>> 406: Some examples: >>> 407: >>> 408: > **Windows 32bit build with freetype specified:** \ >> >> doc/building.html should be updated as well. > > note that the documentation for freetype in jdk8 is outdated, in jdk9 it was reworked by this [commit](https://github.com/openjdk/jdk/commit/8dc9c32d0d1bbc791555f231e51c55924f256e75). We should update at least the freetype related part as a follow-up patch. Yes, that commit probably needs to be backported as a starting point and then further changes made, including the other FreeType changes in the original version of this commit and replacing Mercurial with git. I think this patch should at least update `doc/building.html` to match the `building.md` changes being made. ------------- PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1737601045 From serb at openjdk.org Fri Aug 30 01:27:22 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 30 Aug 2024 01:27:22 GMT Subject: [jdk8u-dev] Integrated: 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes In-Reply-To: References: Message-ID: On Fri, 24 May 2024 02:33:55 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [9b1d6d66](https://github.com/openjdk/jdk/commit/9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Sergey Bylokhov on 23 May 2024 and was reviewed by Paul Hohensee, Aleksey Shipilev and Erik Gahlin. > > Thanks! This pull request has now been integrated. Changeset: 8b0fedcc Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/8b0fedccb89308b7dfdf1ab7c7801b4e3a786ec2 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 8316328: Test jdk/jfr/event/oldobject/TestSanityDefault.java times out for some heap sizes Reviewed-by: phh, andrew Backport-of: 9b1d6d66b8297d53c6b96b9e2f9bd69af90ab8fb ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/506 From andrew at openjdk.org Fri Aug 30 01:28:25 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 01:28:25 GMT Subject: [jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12] In-Reply-To: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> References: <49WrRlRLlFHK72wZDLM87dK_JgUtlH0pBqcnY02o7OA=.054d15bb-11c1-46df-b7f6-aca8486d236a@github.com> Message-ID: <_SlTsHrQjX8RI0ENiJst4v1Okb3oU-PMWnBjfN_ledY=.863ec5f9-88a7-4432-97ac-a586e974e4cb@github.com> On Fri, 16 Aug 2024 08:58:38 GMT, George Adams wrote: >> Imports the Freetype source to be consistent with JDK11+ >> >> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew > > George Adams has updated the pull request incrementally with one additional commit since the last revision: > > test removal of common/autoconf/toolchain_windows.m4 changes Patch looks good for comparison with the 11u version. My only real issue is with the doc updates. I thought at first we should update the other FreeType documentation here, but, after reading other comments, it seems better to follow up this work by trying to sync closer to later JDK versions first, then apply the changes from this changeset. This patch should at least update `building.html` to match `building.md` though by regenerating the HTML. I'll try bundled and system builds with this patch while you work on that. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/318#pullrequestreview-2270752111 From andrew at openjdk.org Fri Aug 30 01:32:20 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 30 Aug 2024 01:32:20 GMT Subject: [jdk8u-dev] RFR: 8260380: Upgrade to LittleCMS 2.12 In-Reply-To: References: Message-ID: On Sat, 17 Aug 2024 00:28:23 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [4caeb39f](https://github.com/openjdk/jdk/commit/4caeb39f01b13b5472d8dacb268262fd418fd0c4) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 10 Feb 2021 and was reviewed by Jayathirth D V and Sergey Bylokhov. > > The backport is mostly clean, I had to update the license in `THIRD_PARTY_README` instead of `lcms.md`. > No new issues found by the :jdk_desktop tests. > > Thanks! Change looks good, with `lcms.md` changes adapted to `THIRD_PARTY_README`. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/563#pullrequestreview-2270757039 From serb at openjdk.org Fri Aug 30 01:55:25 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 30 Aug 2024 01:55:25 GMT Subject: [jdk8u-dev] Integrated: 8298887: On the latest macOS+XCode the Robot API may report wrong colors In-Reply-To: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com> References: <_ZeNGD5YCKMsD4f1679JKBufN70V_p2JwMmILkP-6hQ=.c864f37f-cdc6-4b61-9cec-3050cb481230@github.com> Message-ID: On Mon, 26 Feb 2024 20:40:53 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [ceb6793b](https://github.com/openjdk/jdk11u-dev/commit/ceb6793bf3b5855c7c521678b5d99d752800b441) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Sergey Bylokhov on 5 May 2023 and was reviewed by Paul Hohensee. > > This patch is needed to support XCode 14.2+ > > Thanks! This pull request has now been integrated. Changeset: e32d62e2 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/e32d62e2a39510f643b32d615e76f0ff9be3d9f3 Stats: 16 lines in 4 files changed: 0 ins; 12 del; 4 mod 8298887: On the latest macOS+XCode the Robot API may report wrong colors Reviewed-by: phh, andrew Backport-of: ceb6793bf3b5855c7c521678b5d99d752800b441 ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/457 From serb at openjdk.org Fri Aug 30 03:04:27 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Fri, 30 Aug 2024 03:04:27 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java In-Reply-To: <0SSfVPPhM2qbpdSGivl2TjIY_nxXpu_jOAdmO3VHwlA=.0e6666b1-1ab0-4a12-a883-0e074b90a1cc@github.com> References: <0SSfVPPhM2qbpdSGivl2TjIY_nxXpu_jOAdmO3VHwlA=.0e6666b1-1ab0-4a12-a883-0e074b90a1cc@github.com> Message-ID: <3buzkB_LHqqj8OnRYBHPWaTWBI6OjVb3w1mtBHPPsN4=.25cdc450-007a-4c30-a610-65aa2184a986@github.com> On Fri, 30 Aug 2024 00:33:30 GMT, Andrew John Hughes wrote: > This is a MacOS patch but the GHA MacOS build has not been run. Please merge with the current jdk8u-dev so that the Mac build runs before we approve this patch. It should be working now (see https://github.com/gnu-andrew/jdk8u-dev/actions/runs/10619513292/job/29437308137 for example) done. There are some known failed tests: ".../CertPathValidator/certification/CAInterop#..." ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/531#issuecomment-2319772794 From phh at openjdk.org Fri Aug 30 16:54:26 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 30 Aug 2024 16:54:26 GMT Subject: [jdk8u-dev] RFR: 8239312: [macOS] javax/swing/JFrame/NSTexturedJFrame/NSTexturedJFrame.java [v2] In-Reply-To: <4HKQdNRnRVZsibOr9MZeJ3dyC4UW85h9JoGA11lW0To=.9b3f782f-0d67-471c-8c6e-de435b6c52c6@github.com> References: <4HKQdNRnRVZsibOr9MZeJ3dyC4UW85h9JoGA11lW0To=.9b3f782f-0d67-471c-8c6e-de435b6c52c6@github.com> Message-ID: On Fri, 30 Aug 2024 00:58:50 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [40e667c1](https://github.com/openjdk/jdk/commit/40e667c174269a73cd9b5612673c5e4b2293d6c0) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Prasanta Sadhukhan on 26 Mar 2020 and was reviewed by Sergey Bylokhov. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-40e667c1-master > - Backport 40e667c174269a73cd9b5612673c5e4b2293d6c0 All the GHA failures but one are cert issues that look unrelated. For that one (MacOS-x64 hotspot/test/compiler/unsafe/OpaqueAccesses.java) I merged the patch with the latest upstream 8u and ran it on my Intel Mac laptop and it passed. So did the modified test. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/531#issuecomment-2321963572 From phh at openjdk.org Fri Aug 30 17:00:26 2024 From: phh at openjdk.org (Paul Hohensee) Date: Fri, 30 Aug 2024 17:00:26 GMT Subject: [jdk8u-dev] RFR: 8315731: Open source several Swing Text related tests In-Reply-To: References: Message-ID: On Mon, 10 Jun 2024 02:24:47 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [0dc17ca0](https://github.com/openjdk/jdk11u-dev/commit/0dc17ca068b837606252e1db614fd005a2f2b942) from the [openjdk/jdk11u-dev](https://git.openjdk.org/jdk11u-dev) repository. > > The commit being backported was authored by Jonathan Dowland on 5 Feb 2024 and was reviewed by Sergey Bylokhov. > > Thanks! GHA failures are unrelated cert issues, or unrelated (in the case of linux-x86) GC test failures. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/516#issuecomment-2321976680