[jdk8u-dev] RFR: 8281096: Flags introduced by configure script are not passed to ADLC build [v7]

[Zdenek Zambersky]

On Wed, 14 Aug 2024 15:48:09 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > I have done some additional testing:
> > ```
> > * I  [tested](https://github.com/zzambers/jdk8u-dev/actions/runs/9664993178)  this, with GHA workflows updated to ubuntu-22.04 on top (+ [fix for jdi test](https://github.com/openjdk/jdk8u-dev/pull/497)). This is because, I have recently seen build failures on some archs, when I [tried to update GHA testing to ubuntu-22.04](https://github.com/openjdk/jdk8u-dev/pull/491#issue-2281128235), while looking at another issue. There are no build failures with this changeset (1 test failure/error on linux x86 seems unrelated).
> > 
> > * I have also tried to do build in rhel-9 VM (gcc-11.4.1). It passed ADLC build (unlike unpatched version). Build later failed on another (separate) error in `hotspot/src/share/vm/opto/type.cpp` (see [8329826: GCC 12 reports some compiler error when building jdk8 #479 (comment)](https://github.com/openjdk/jdk8u-dev/pull/479#issuecomment-2058078166)). If I also modified `type.cpp` (based on that PR), build passed.
> > ```
> > 
> > 
> >     
> >       
> >     
> > 
> >       
> >     
> > 
> >     
> >   
> > Change looks good. (works for me)
> 
> Thanks for testing. Can you give me more details on what kind of build failed in `type.cpp` (e.g. release/slowdebug/fastdebug)? With just this patch, it builds for me on GCC 13.

I can still reproduce issue with `type.cpp` on rhel-9, with just most default build (just boot jdk set). Gcc version is 11.4.1 (system one).

Errors look following way (see [jdk8-type.cpp-error.log](https://github.com/user-attachments/files/16615930/jdk8-type.cpp-error.log) for full configure/make log):

In constructor ‘TypeOopPtr::TypeOopPtr(Type::TYPES, TypePtr::PTR, ciKlass*, bool, ciObject*, int, int, const TypeOopPtr*, int)’,
    inlined from ‘TypeAryPtr::TypeAryPtr(TypePtr::PTR, ciObject*, const TypeAry*, ciKlass*, bool, int, int, bool, const TypeOopPtr*, int)’ at /home/tester/jdk8u-dev/hotspot/src/share/vm/opto/type.hpp:1094:39,
    inlined from ‘static const TypeAryPtr* TypeAryPtr::make(TypePtr::PTR, const TypeAry*, ciKlass*, bool, int, int, const TypeOopPtr*, int)’ at /home/tester/jdk8u-dev/hotspot/src/share/vm/opto/type.cpp:3745:115:
/home/tester/jdk8u-dev/hotspot/src/share/vm/opto/type.cpp:2556:71: error: ‘this’ pointer is null [-Werror=nonnull]
 2556 |           ciInstanceKlass* k = o->as_instance()->java_lang_Class_klass()->as_instance_klass();
      |                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
In file included from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciCallSite.hpp:28,
                 from /home/tester/jdk8u-dev/hotspot/src/share/vm/code/dependencies.hpp:28,
                 from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciEnv.hpp:32,
                 from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciUtilities.hpp:28,
                 from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciNullObject.hpp:30,
                 from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciConstant.hpp:29,
                 from /home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciArray.hpp:29,
                 from /home/tester/jdk8u-dev/hotspot/src/share/vm/precompiled/precompiled.hpp:33:
/home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciInstance.hpp: In function ‘static const TypeAryPtr* TypeAryPtr::make(TypePtr::PTR, const TypeAry*, ciKlass*, bool, int, int, const TypeOopPtr*, int)’:
/home/tester/jdk8u-dev/hotspot/src/share/vm/ci/ciInstance.hpp:68:12: note: in a call to non-static member function ‘ciKlass* ciInstance::java_lang_Class_klass()’
   68 |   ciKlass* java_lang_Class_klass();
      |            ^~~~~~~~~~~~~~~~~~~~~

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/357#issuecomment-2289238973