[jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v9]

[Sergey Bylokhov]

On Thu, 15 Aug 2024 07:23:27 GMT, George Adams <gdams at openjdk.org> wrote:

>> Imports the Freetype source to be consistent with JDK11+
>> 
>> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew
>
> George Adams has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into freetype
>  - remove top level make changes
>  - remove make/conf/jib-profiles.js
>  - changes from review
>  - rerun autoconf
>  - Merge remote-tracking branch 'upstream/master' into freetype
>  - Merge remote-tracking branch 'upstream/master' into freetype
>  - move libfreetype to correct src directory
>  - remove freetype from actions
>  - and more changes
>  - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/4106121e...7be05c5c

common/autoconf/libraries.m4 line 262:

> 260:   METHOD="$3"
> 261: 
> 262:   # Assume we've found freetype to begin

from where this comment is come from? the jdk11 and openjdk/jdk use "# Let's start with an optimistic view of the world :-)" added by the "https://github.com/openjdk/jdk/commit/6b1eac7c4e86e33cba1dd30d43b417675de9000f"

common/autoconf/libraries.m4 line 328:

> 326:   if test "x$OPENJDK_TARGET_OS" != "xwindows" && \
> 327:       test "x$OPENJDK_TARGET_OS" != "xmacosx" && \
> 328:       test "x$OPENJDK_TARGET_OS" != "xaix"; then

I am not sure about "aix" do we want to use the bundled version on it?

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719120231
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/318#discussion_r1719121635