[jdk8u-dev] RFR: 8305400: ISO 4217 Amendment 175 Update

[Severin Gehwolf]

On Fri, 16 Aug 2024 12:39:35 GMT, Karm Michal Babacek <duke at openjdk.org> wrote:

>> backport 8c243a3 JDK11
>
>> ⚠️ @Karm the full name on your profile does not match the author name in this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit. If this pull request gets integrated then the author name from this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:
>> 
>> ```
>> $ git checkout JDK-8305400-amendment-175
>> $ git commit --author='Preferred Full Name <you at example.com>' --allow-empty -m 'Update full name'
>> $ git push
>> ```
> 
> @jerboaa 
> 
> Any idea what the machine is worrying about, please?
> 
> The commit is
> 
> 
> Author: Michal Karm Babacek <karm at redhat.com>
> 
> and it is signed...

> @Karm 8305400: The approval [request](https://bugs.openjdk.org/browse/JDK-8305400?focusedCommentId=14698720) has been created successfully.

The request comment is:

[jdk8u-fix-request] Approval Request from Karm Michal Babacek


@Karm This is not a suitable approval request comment. It should mention the anticipated risk, what testing you have done and why it should get approved in the first place. Please update the comment by using `/approval request <comment>`. See also point 6 in: https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

> > ⚠️ @Karm the full name on your profile does not match the author name in this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit. If this pull request gets integrated then the author name from this pull requests' [HEAD](https://git.openjdk.org/jdk8u-dev/pull/559/commits/cf4ea7164eb4ead50902ca72d733b8bd4f1cc229) commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:
> > ```
> > $ git checkout JDK-8305400-amendment-175
> > $ git commit --author='Preferred Full Name <you at example.com>' --allow-empty -m 'Update full name'
> > $ git push
> > ```
> 
> @jerboaa
> 
> Any idea what the machine is worrying about, please?
> 
> The commit is
> 
> ```
> Author: Michal Karm Babacek <karm at redhat.com>
> ```
> 
> and it is signed...

It says the full name in your github profile (`Karm Michal Babacek`) doesn't match the name in the commit (`Michal Karm Babacek`). I'd suggest to fix it so they match and the warning should be gone.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2293453203
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/559#issuecomment-2293456427