[jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v3]

Wed Aug 21 13:25:10 UTC 2024

On Wed, 21 Aug 2024 13:19:55 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> An additional blank line is removed in `CurrencyData.properties` and the bug ID line change is missing for `ValidateISO4217.java`. Otherwise, the backport matches the changes in the 11u version.
> 
> Have you verified that the updated Currency tests pass against the patched build?

https://github.com/openjdk/jdk8u-dev/pull/562#issuecomment-2301743430

i.e. yes I have, the Currency package.

> jdk/src/share/classes/java/util/CurrencyData.properties line 60:
> 
>> 58:     XPT962-XSU994-XTS963-XUA965-XXX999-YER886-YUM891-ZAR710-ZMK894-ZMW967-ZWD716-ZWL932-\
>> 59:     ZWN942-ZWR935
>> 60: 
> 
> This blank line should not be removed here.

Will amend presently.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2302047926
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/562#discussion_r1725047090