[jdk8u-dev] RFR: 8334653: ISO 4217 Amendment 177 Update [v4]

[Karm Michal Babacek]

On Thu, 22 Aug 2024 12:31:23 GMT, Karm Michal Babacek <duke at openjdk.org> wrote:

>> backport b05f58e JDK11 JDK-8334653 ISO 4217 Amendment 177 Update
>> depends on #561
>
> Karm Michal Babacek has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Newline CurrencyData, bugid ValidateISO4217

> `CurrencyTest.java` is missing this hunk:
> 
> ```
> @@ -60,7 +60,7 @@ import static org.junit.jupiter.api.Assertions.assertThrows;
> 
>  public class CurrencyTest {
> 
> -    // 'tablea1.txt' should be up-to-date before testing
> +    // 'ISO4217-list-one.txt' should be up-to-date before testing
>      @Test
>      public void dataVersionTest() {
>          CheckDataVersion.check();
> ```
> 
> See: [openjdk/jdk11u-dev at b05f58e#diff-9b35965750742d3e80baa3c18194cd60156bf561990636e49fa0f6eadf4854dfR63](https://github.com/openjdk/jdk11u-dev/commit/b05f58e9ec57ce7f140ad47df3b5bdf4cc42f5f9#diff-9b35965750742d3e80baa3c18194cd60156bf561990636e49fa0f6eadf4854dfR63)

@jerboaa Why do you think that? I did not port the tests to JUnit, I left that in its original state. The data file is loaded in CheckDataVersion. No point in bringing the comment that belongs to a JUnit that does not exist here IMHO.

Or perhaps I misunderstood something.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2305526258
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/562#issuecomment-2305529265