[jdk8u-dev] RFR: 8193017: Import freetype sources into OpenJDK source tree [v12]

Andrew John Hughes andrew at openjdk.org
Fri Aug 30 01:28:25 UTC 2024


On Fri, 16 Aug 2024 08:58:38 GMT, George Adams <gdams at openjdk.org> wrote:

>> Imports the Freetype source to be consistent with JDK11+
>> 
>> As discussed in https://github.com/ibmruntimes/openj9-openjdk-jdk8/pull/631 CC @gnu-andrew
>
> George Adams has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test removal of common/autoconf/toolchain_windows.m4 changes

Patch looks good for comparison with the 11u version. My only real issue is with the doc updates. I thought at first we should update the other FreeType documentation here, but, after reading other comments, it seems better to follow up this work by trying to sync closer to later JDK versions first, then apply the changes from this changeset.  This patch should at least update `building.html` to match `building.md` though by regenerating the HTML.

I'll try bundled and system builds with this patch while you work on that.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/318#pullrequestreview-2270752111


More information about the jdk8u-dev mailing list