From duke at openjdk.org Mon Dec 2 19:43:47 2024 From: duke at openjdk.org (duke) Date: Mon, 2 Dec 2024 19:43:47 GMT Subject: [jdk8u-dev] RFR: 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX In-Reply-To: References: Message-ID: On Fri, 15 Nov 2024 20:04:10 GMT, sophia-guo wrote: > 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX @sophia-guo Your change (at version 1005a0aa3b6f50b47867ca619c0a9335ec3e5b87) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/604#issuecomment-2512600572 From duke at openjdk.org Mon Dec 2 20:37:49 2024 From: duke at openjdk.org (sophia-guo) Date: Mon, 2 Dec 2024 20:37:49 GMT Subject: [jdk8u-dev] Integrated: 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX In-Reply-To: References: Message-ID: On Fri, 15 Nov 2024 20:04:10 GMT, sophia-guo wrote: > 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX This pull request has now been integrated. Changeset: 9d330daa Author: Sophia Guo Committer: Severin Gehwolf URL: https://git.openjdk.org/jdk8u-dev/commit/9d330daad5b2acd49fa4dcf00f8fda68932fb8b0 Stats: 86 lines in 2 files changed: 1 ins; 83 del; 2 mod 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX Reviewed-by: andrew Backport-of: 02186906efdb581a7b4494cfd9e21f45bc76e9ed ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/604 From serb at openjdk.org Mon Dec 2 22:26:09 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 2 Dec 2024 22:26:09 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v7] In-Reply-To: References: Message-ID: > The tests are updated to force the MarlinRenderingEngine. > > @bourgesl please take a look. Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - Merge branch 'openjdk:master' into JDK-8326110 - PR feedback - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/447/files - new: https://git.openjdk.org/jdk8u-dev/pull/447/files/f7507e15..7f6ed435 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=06 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=447&range=05-06 Stats: 89 lines in 5 files changed: 1 ins; 83 del; 5 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/447.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/447/head:pull/447 PR: https://git.openjdk.org/jdk8u-dev/pull/447 From serb at openjdk.org Mon Dec 2 23:27:49 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 2 Dec 2024 23:27:49 GMT Subject: [jdk8u-dev] Integrated: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 In-Reply-To: References: Message-ID: On Sun, 18 Feb 2024 03:01:32 GMT, Sergey Bylokhov wrote: > The tests are updated to force the MarlinRenderingEngine. > > @bourgesl please take a look. This pull request has now been integrated. Changeset: 00d25421 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/00d254215576d356337dc23425377a6a3f15f438 Stats: 5 lines in 4 files changed: 0 ins; 0 del; 5 mod 8326110: [8u] The Marlin tests should be updated after JDK-8241307 Reviewed-by: phh, andrew, lbourges ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/447 From serb at openjdk.org Mon Dec 2 23:28:59 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Mon, 2 Dec 2024 23:28:59 GMT Subject: [jdk8u-dev] RFR: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F [v4] In-Reply-To: References: Message-ID: <-MgSB2Sdcwx9V0Vk0m3fFAussFzpzOmx_t-E3E7CvGw=.05087259-1c79-4b40-b682-6818541c0d81@github.com> > Hi all, > > This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. > > Thanks! Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master - Backport bc24a0ce18373217b97dc3a8f4071a7ffc92691d ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/575/files - new: https://git.openjdk.org/jdk8u-dev/pull/575/files/d9ff1400..3ba27a88 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=575&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=575&range=02-03 Stats: 1375 lines in 39 files changed: 1150 ins; 145 del; 80 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/575.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/575/head:pull/575 PR: https://git.openjdk.org/jdk8u-dev/pull/575 From ktakakuri at openjdk.org Tue Dec 3 00:07:42 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Dec 2024 00:07:42 GMT Subject: [jdk8u-dev] RFR: 6622468: TEST_BUG: Time to retire the @debuggeeVMOptions mechanism used in the com.sun.jdi infrastructure In-Reply-To: References: Message-ID: On Tue, 7 May 2024 12:29:04 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > Currently, hotspot tests require jtreg 4.2 b13 or newer. Therefore, even if TEST.ROOT of the jdk test does not specify a required minimum jtreg version, it is unlikely that jdk tests will be run with a version of jtreg which does not support -vmoption. > Given this, the @debuggeeVMOptions mechanism can be safely removed. > The patch is almost clean. Only difference is that DoubleAgentTest.java is skipped because the fix is alreaday in another patch. > > There is a related patch JDK-8048892, and I have proposed a separate backport for it. #493 > Additionally, when JDK-8054066 was backported, a @debuggeeVMOptions file was added to the original patch. I plan to propose an issue regarding the modification of that test once this fix is approved. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/492#issuecomment-2513231083 From ktakakuri at openjdk.org Tue Dec 3 00:07:49 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Dec 2024 00:07:49 GMT Subject: [jdk8u-dev] RFR: 8074883: Tab key should move to focused button in a button group In-Reply-To: References: Message-ID: On Fri, 16 Dec 2022 10:30:19 GMT, Kazuhisa Takakuri wrote: > This is a backport of JDK-8074883: Tab key should move to focused button in a button group. > > I would like to backport the patch to OpenJDK8u. > Original patch does not apply cleanly to 8u, because the fix uses a new API published in JDK9. > > * Since RequestFocusController only determines whether or not to set focus, I modified it so that requestFocus/requestFocusInWindow is called by SwingUtilities.invokeLater() and re-set focus and return false. > Without invokeLater(), the focus returns to the first button in case of Cause.ACTIVATION. > > * ToggleButton.getGroupSelection() is defined as a package private method, because it must be called by JCompoennt.focusController. > > * Calling requestFocus()/requestFocusInWindow() will be processed as Cause.UNKNOWN. > ToggleButton.getGroupSelection() returns itself, so no circular call occurs. > > * I moved Component.requestFocusController.acceptRequestFocus because RequestFocusContoroller is not called when Cause.ACTIVATION. > > * Only Swing components replace default RequestFocusController to JComponent.focusController. > The focusController returns true except for Swing, so this change does not affect other components. > > Testing: > build on Windows x86_64 > java/awt, javax/swing and ButtonGroupFocusTest.java on Windows x86_64 This pull request is pending review of https://github.com/openjdk/jdk8u-dev/pull/285. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/212#issuecomment-2513231559 From ktakakuri at openjdk.org Tue Dec 3 00:07:51 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Dec 2024 00:07:51 GMT Subject: [jdk8u-dev] RFR: 8159695: Arguments::atojulong() fails to detect overflows In-Reply-To: References: Message-ID: <76_HF9_qzKopluD8ou4fRUWoLco2abMbjLTxc-cXDvI=.1e833b68-dfe2-491d-b9f5-99be51d626c1@github.com> On Thu, 25 Jan 2024 05:57:35 GMT, Kazuhisa Takakuri wrote: > Hi all, this is a backport of JDK-8159695: Arguments::atojulong() fails to detect overflows. > The bug reported is reproducible in JDK8, so this patch should be applied. > The original patch does not apply cleanly, and the following modifications are needed: > > - Lines related to hexadecimal numbers are skipped because support for hexadecimal numbers as a VM option, corresponding to JDK-8042885, was not introduced until JDK9. > - The accompanying test to check the functionality of the atojulong() function is dropped because it is a GTest, which is not available in JDK8. > > Note that atomull() was renamed to atojulong() in JDK9 as part of the enhancement JDK-8153073, which supports suffixes in memory size options. > Testing > > - Manually check the behaviour > When a given value is too large to fit in a julong, the proper exception is raised with this patch. > > without patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version | grep StackTarget > > uintx GCDrainStackTargetSize := 18446744073709551615 {product} > > > with patch > > java -XX:GCDrainStackTargetSize=999999999999999999999999999999 -XX:+PrintFlagsFinal -version > Improperly specified VM option 'GCDrainStackTargetSize=999999999999999999999999999999' > Error: Could not create the Java Virtual Machine. > Error: A fatal exception has occurred. Program will exit. > > > - hotspot_tier1 > > Thank you. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/428#issuecomment-2513231239 From ktakakuri at openjdk.org Tue Dec 3 00:07:48 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Dec 2024 00:07:48 GMT Subject: [jdk8u-dev] RFR: 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken In-Reply-To: References: Message-ID: On Tue, 16 Jan 2024 02:31:22 GMT, Kazuhisa Takakuri wrote: > I would like to backport > 8248001: javadoc generates invalid HTML pages whose ftp:// links are broken. > There are minor differences regarding DocRoot, but otherwise this is a clean backport. This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/420#issuecomment-2513231372 From ktakakuri at openjdk.org Tue Dec 3 00:08:47 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Dec 2024 00:08:47 GMT Subject: [jdk8u-dev] Integrated: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. This pull request has now been integrated. Changeset: 10122b59 Author: Kazuhisa Takakuri URL: https://git.openjdk.org/jdk8u-dev/commit/10122b593165d6bcaf58abfe2721c3dcb407b593 Stats: 221 lines in 7 files changed: 196 ins; 21 del; 4 mod 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML Reviewed-by: phh, andrew Backport-of: 83bce94cc8a7fb45b0604598411fbecc62000dfd ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/517 From ktakakuri at openjdk.org Tue Dec 3 00:15:07 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Tue, 3 Dec 2024 00:15:07 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v2] In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/518/files - new: https://git.openjdk.org/jdk8u-dev/pull/518/files/5346a7ba..5346a7ba Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=518&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=518&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/518.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/518/head:pull/518 PR: https://git.openjdk.org/jdk8u-dev/pull/518 From serb at openjdk.org Tue Dec 3 06:21:46 2024 From: serb at openjdk.org (Sergey Bylokhov) Date: Tue, 3 Dec 2024 06:21:46 GMT Subject: [jdk8u-dev] Integrated: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F In-Reply-To: References: Message-ID: On Fri, 6 Sep 2024 16:56:21 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. > > Thanks! This pull request has now been integrated. Changeset: 2931b1d2 Author: Sergey Bylokhov URL: https://git.openjdk.org/jdk8u-dev/commit/2931b1d250dbf820b2094b67f5ae19d223e7c887 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F Reviewed-by: andrew Backport-of: bc24a0ce18373217b97dc3a8f4071a7ffc92691d ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/575 From mbalao at openjdk.org Wed Dec 4 02:12:45 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 4 Dec 2024 02:12:45 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: <-Udm-8mB5GGx_KW7hp5Wz7Tb1nv_nczEhcms43rMuKE=.d1d3c7c1-6351-4cca-b6cb-d8c0490f2132@github.com> On Tue, 26 Nov 2024 23:41:59 GMT, Alexey Bakhtin wrote: > Not clean backport from JDK11 patch: > - No GNUStyle options in JDK8 > - No support for long options > - Tests updated to use JDK8 API > - Removed subtest for long option > > JTREG tests passed Thanks for this contribution. One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too. I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think? The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface. ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/608#pullrequestreview-2477125092 From ktakakuri at openjdk.org Wed Dec 4 06:32:16 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 4 Dec 2024 06:32:16 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v3] In-Reply-To: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: > This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. > This patch complements JDK-8268457, which I have already proposed for backporting. #517 > This backport is not clean due to the fact that the JDK-8268457 backport is not clean. > > I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits: - Merge branch 'master' into 8274606 - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 - Backport 7eb0372e55f23275b12470593adc97f1b79bc965 - Import Collectors - Remove test library - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd - Backport 83bce94cc8a7fb45b0604598411fbecc62000dfd - Fix the indent - ... and 2 more: https://git.openjdk.org/jdk8u-dev/compare/2931b1d2...6d3982bf ------------- Changes: https://git.openjdk.org/jdk8u-dev/pull/518/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=518&range=02 Stats: 18 lines in 1 file changed: 6 ins; 3 del; 9 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/518.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/518/head:pull/518 PR: https://git.openjdk.org/jdk8u-dev/pull/518 From ktakakuri at openjdk.org Wed Dec 4 06:34:44 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 4 Dec 2024 06:34:44 GMT Subject: [jdk8u-dev] RFR: 8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test [v2] In-Reply-To: References: <6wo8wRncYeyz5uTpqFiLBPVspHnz-U0_AQgbm3J3ibs=.b81fd330-70a4-495c-9383-ffda06567c3a@github.com> Message-ID: <6kVI0rfCDdYmvbrn2V5VyVFzrrLZp8yJTYs9TvUnwmg=.57655417-01bd-4fd9-9354-7f3866b2d3d2@github.com> On Tue, 3 Dec 2024 00:15:07 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8274606: Fix jaxp/javax/xml/jaxp/unittest/transform/SurrogateTest.java test. >> This patch complements JDK-8268457, which I have already proposed for backporting. #517 >> This backport is not clean due to the fact that the JDK-8268457 backport is not clean. >> >> I confirmed that SurrogateTest.java fails in the build before applying JDK-8268457 and succeeds in the build after applying it. >> >> Testing: All tests under jdk/test/javax/xml/jaxp/ >> >> Thank you. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. I resolved the conflicts. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/518#issuecomment-2516312854 From ktakakuri at openjdk.org Wed Dec 4 07:48:46 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Wed, 4 Dec 2024 07:48:46 GMT Subject: [jdk8u-dev] RFR: 8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows In-Reply-To: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> References: <92mSCD2WLjegzKtiYbt9ukogjad5qIJk5sDLbI6GeEM=.11e6c042-b496-4ba0-81be-7d11fec57e46@github.com> Message-ID: On Mon, 13 May 2024 09:28:10 GMT, Kazuhisa Takakuri wrote: > Hi all, > > This is a backport of JDK-8046883: com/sun/jdi/ProcessAttachTest.sh gets "java.io.IOException: Invalid process identifier" on windows. > The original patch does not apply cleanly. Process.pid() method was introduced in JDK9, so I used the results of the jps command instead. > > Testing: jdk/test/com/sun/jdi/ProcessAttachTest.java on Windows x86_64 This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/498#issuecomment-2516432175 From abakhtin at openjdk.org Wed Dec 4 15:35:21 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 15:35:21 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v2] In-Reply-To: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: > Not clean backport from JDK11 patch: > - No GNUStyle options in JDK8 > - No support for long options > - Tests updated to use JDK8 API > - Removed subtest for long option > > JTREG tests passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Update warning and usage strings ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/608/files - new: https://git.openjdk.org/jdk8u-dev/pull/608/files/c644d77a..538f97fe Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=608&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=608&range=00-01 Stats: 12 lines in 11 files changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/608.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/608/head:pull/608 PR: https://git.openjdk.org/jdk8u-dev/pull/608 From abakhtin at openjdk.org Wed Dec 4 15:40:55 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 15:40:55 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v2] In-Reply-To: <-Udm-8mB5GGx_KW7hp5Wz7Tb1nv_nczEhcms43rMuKE=.d1d3c7c1-6351-4cca-b6cb-d8c0490f2132@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <-Udm-8mB5GGx_KW7hp5Wz7Tb1nv_nczEhcms43rMuKE=.d1d3c7c1-6351-4cca-b6cb-d8c0490f2132@github.com> Message-ID: On Wed, 4 Dec 2024 02:10:30 GMT, Martin Balao wrote: >> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: >> >> Update warning and usage strings > > Thanks for this contribution. > > One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too. > > I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think? > > The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface. Hello @martinuy Thank you for review > One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too. You are right. "-k" is not used separately, so I have updated the warning message > I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think? Good catch. Thank you. It should be added as soon as it is main usage string for JDK8 > The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface. Right. "testGnuOptionsKeptOldFile" does not apply for JDK8 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2517805613 From gnu.andrew at redhat.com Wed Dec 4 16:29:19 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Wed, 4 Dec 2024 16:29:19 +0000 Subject: [RAMPDOWN] 8u442 Now in Rampdown Stage Message-ID: 8u442 is in rampdown for release in January 2025. jdk8u-dev is CLOSED for commits until https://bugs.openjdk.org/browse/JDK-8345504 is integrated to begin the 8u452 release cycle. For critical fixes (i.e. regressions or urgent fixes like tzdata & cacerts updates) for 8u442, please file a PR against https://github.com/openjdk/jdk8u and use jdk8u-critical-request to obtain approval to push (automatic with the /approval request command [0]). [0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval Thanks, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Wed Dec 4 16:38:18 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 16:38:18 GMT Subject: [jdk8u-dev] RFR: 8345504: Bump update version of OpenJDK: 8u452 Message-ID: Rampdown for 8u442 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html). 8u-dev needs to transition to 8u452. ------------- Commit messages: - 8345504: Bump update version of OpenJDK: 8u452 Changes: https://git.openjdk.org/jdk8u-dev/pull/609/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=609&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345504 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/609.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/609/head:pull/609 PR: https://git.openjdk.org/jdk8u-dev/pull/609 From mbalao at openjdk.org Wed Dec 4 17:24:44 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 4 Dec 2024 17:24:44 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v2] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <-Udm-8mB5GGx_KW7hp5Wz7Tb1nv_nczEhcms43rMuKE=.d1d3c7c1-6351-4cca-b6cb-d8c0490f2132@github.com> Message-ID: On Wed, 4 Dec 2024 15:37:44 GMT, Alexey Bakhtin wrote: >> Thanks for this contribution. >> >> One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too. >> >> I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think? >> >> The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface. > > Hello @martinuy > Thank you for review > >> One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too. > > You are right. "-k" is not used separately, so I have updated the warning message > >> I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think? > > Good catch. Thank you. It should be added as soon as it is main usage string for JDK8 > >> The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface. > > Right. "testGnuOptionsKeptOldFile" does not apply for JDK8 @alexeybakhtin , thanks for considering the suggested changes. Looks like `jar_pt_BR.properties` was missed, if we really want to update all `jar...properties`. Changes to `jar...properties` make me think that the new option will not be documented for languages other than English. Would be very tricky to do the translation for all languages and perhaps is acceptable not to do it, as it has not been done for JDK main line either. While the spirit in 8u was different, it's not unreasonable for developer tools to be in English only. I'd suggest to update `jar_pt_BR.properties` and leave it there. The reader will probably fall back to English for an explanation of the (undocumented) `k`. If people really want to do the translation, I can contribute Spanish and Portuguese. What do you think? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2518081313 From sgehwolf at openjdk.org Wed Dec 4 17:32:42 2024 From: sgehwolf at openjdk.org (Severin Gehwolf) Date: Wed, 4 Dec 2024 17:32:42 GMT Subject: [jdk8u-dev] RFR: 8345504: Bump update version of OpenJDK: 8u452 In-Reply-To: References: Message-ID: <05Mnhd2K4sFC5Jmna06022PUtjBaOSuiA7OmDb_6iEc=.c2de3e87-9b5b-494d-8b26-1374318ded7b@github.com> On Wed, 4 Dec 2024 16:32:44 GMT, Andrew John Hughes wrote: > Rampdown for 8u442 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html). 8u-dev needs to transition to 8u452. Marked as reviewed by sgehwolf (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/609#pullrequestreview-2479434200 From abakhtin at openjdk.org Wed Dec 4 17:37:58 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 17:37:58 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v3] In-Reply-To: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: <9WBmaYjG0EfF8XNY-H2J4_C4x873YyW-JcZoybN8i-c=.fb2f2b44-4d21-4a12-89fb-109fe76c0356@github.com> > Not clean backport from JDK11 patch: > - No GNUStyle options in JDK8 > - No support for long options > - Tests updated to use JDK8 API > - Removed subtest for long option > > JTREG tests passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Update jar_pt_BR.properties ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/608/files - new: https://git.openjdk.org/jdk8u-dev/pull/608/files/538f97fe..bdb6cf46 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=608&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=608&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/608.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/608/head:pull/608 PR: https://git.openjdk.org/jdk8u-dev/pull/608 From abakhtin at openjdk.org Wed Dec 4 17:40:47 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 17:40:47 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v3] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <-Udm-8mB5GGx_KW7hp5Wz7Tb1nv_nczEhcms43rMuKE=.d1d3c7c1-6351-4cca-b6cb-d8c0490f2132@github.com> Message-ID: <3xL1LjSi7pNtBlS127roh8HowjKHxTY7_io36nfXzQk=.cd3dc1b9-0ce3-4bae-b33a-1b5f57c22248@github.com> On Wed, 4 Dec 2024 15:37:44 GMT, Alexey Bakhtin wrote: >> Thanks for this contribution. >> >> One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too. >> >> I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think? >> >> The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface. > > Hello @martinuy > Thank you for review > >> One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too. > > You are right. "-k" is not used separately, so I have updated the warning message > >> I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think? > > Good catch. Thank you. It should be added as soon as it is main usage string for JDK8 > >> The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface. > > Right. "testGnuOptionsKeptOldFile" does not apply for JDK8 > @alexeybakhtin , thanks for considering the suggested changes. > > Looks like `jar_pt_BR.properties` was missed, if we really want to update all `jar...properties`. Changes to `jar...properties` make me think that the new option will not be documented for languages other than English. Would be very tricky to do the translation for all languages and perhaps is acceptable not to do it, as it has not been done for JDK main line either. While the spirit in 8u was different, it's not unreasonable for developer tools to be in English only. I'd suggest to update `jar_pt_BR.properties` and leave it there. The reader will probably fall back to English for an explanation of the (undocumented) `k`. If people really want to do the translation, I can contribute Spanish and Portuguese. > > What do you think? Thank you @martinuy Added the 'k' option to `jar_pt_BR.properties`. Translation for new and missed options can be done separately. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2518114588 From mbalao at openjdk.org Wed Dec 4 17:59:46 2024 From: mbalao at openjdk.org (Martin Balao) Date: Wed, 4 Dec 2024 17:59:46 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v3] In-Reply-To: <9WBmaYjG0EfF8XNY-H2J4_C4x873YyW-JcZoybN8i-c=.fb2f2b44-4d21-4a12-89fb-109fe76c0356@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <9WBmaYjG0EfF8XNY-H2J4_C4x873YyW-JcZoybN8i-c=.fb2f2b44-4d21-4a12-89fb-109fe76c0356@github.com> Message-ID: On Wed, 4 Dec 2024 17:37:58 GMT, Alexey Bakhtin wrote: >> Not clean backport from JDK11 patch: >> - No GNUStyle options in JDK8 >> - No support for long options >> - Tests updated to use JDK8 API >> - Removed subtest for long option >> >> JTREG tests passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Update jar_pt_BR.properties Marked as reviewed by mbalao (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/608#pullrequestreview-2479494075 From abakhtin at openjdk.org Wed Dec 4 19:19:10 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 4 Dec 2024 19:19:10 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: > Not clean backport from JDK11 patch: > - No GNUStyle options in JDK8 > - No support for long options > - Tests updated to use JDK8 API > - Removed subtest for long option > > JTREG tests passed Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: Fix ExtractFilesTest test ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/608/files - new: https://git.openjdk.org/jdk8u-dev/pull/608/files/bdb6cf46..a99b5b5e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=608&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=608&range=02-03 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/608.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/608/head:pull/608 PR: https://git.openjdk.org/jdk8u-dev/pull/608 From andrew at openjdk.org Wed Dec 4 23:30:45 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 23:30:45 GMT Subject: [jdk8u-dev] RFR: 8345504: Bump update version of OpenJDK: 8u452 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 16:32:44 GMT, Andrew John Hughes wrote: > Rampdown for 8u442 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html). 8u-dev needs to transition to 8u452. Version number is now available in JBS too. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/609#issuecomment-2518765357 From andrew at openjdk.org Wed Dec 4 23:32:48 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 23:32:48 GMT Subject: [jdk8u-dev] RFR: 8068305: [TEST_BUG] Test java/awt/Mixing/HWDisappear.java fails with GTKL&F [v4] In-Reply-To: <-MgSB2Sdcwx9V0Vk0m3fFAussFzpzOmx_t-E3E7CvGw=.05087259-1c79-4b40-b682-6818541c0d81@github.com> References: <-MgSB2Sdcwx9V0Vk0m3fFAussFzpzOmx_t-E3E7CvGw=.05087259-1c79-4b40-b682-6818541c0d81@github.com> Message-ID: On Mon, 2 Dec 2024 23:28:59 GMT, Sergey Bylokhov wrote: >> Hi all, >> >> This pull request contains a backport of commit [bc24a0ce](https://github.com/openjdk/jdk/commit/bc24a0ce18373217b97dc3a8f4071a7ffc92691d) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. >> >> The commit being backported was authored by Alexander Zvegintsev on 13 Jan 2015 and was reviewed by Alexander Scherbatiy and Sergey Bylokhov. >> >> Thanks! > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master > - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master > - Merge branch 'openjdk:master' into backport-mrserb-bc24a0ce-master > - Backport bc24a0ce18373217b97dc3a8f4071a7ffc92691d Moved to 8u452; see https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/575#issuecomment-2518767537 From andrew at openjdk.org Wed Dec 4 23:35:53 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 23:35:53 GMT Subject: [jdk8u-dev] RFR: 8268457: XML Transformer outputs Unicode supplementary character incorrectly to HTML In-Reply-To: References: Message-ID: On Tue, 11 Jun 2024 04:19:07 GMT, Kazuhisa Takakuri wrote: > Hi all, > > JDK8 reproduces the reported bug and I would like to backport this patch. > The patch is not clean. > > * Eliminated the use of test libraries and TestNG, and embedded compareWithGold() method and compareStringWithGold() method. > * Removed indentation from SurrogateTest1.html because indentation is not added in ToHTMLStream.java in JDK8. This difference is due to JDK-8175793 introduced in JDK9. > > There is a related patch JDK-8274606, and I have proposed a separate backport for it. #518 > > Testing: All tests under jdk/test/javax/xml/jaxp/ > > Thank you. Moved to 8u452; see https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/517#issuecomment-2518770785 From andrew at openjdk.org Wed Dec 4 23:35:55 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 23:35:55 GMT Subject: [jdk8u-dev] RFR: 8326110: [8u] The Marlin tests should be updated after JDK-8241307 [v7] In-Reply-To: References: Message-ID: On Mon, 2 Dec 2024 22:26:09 GMT, Sergey Bylokhov wrote: >> The tests are updated to force the MarlinRenderingEngine. >> >> @bourgesl please take a look. > > Sergey Bylokhov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision: > > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - Merge branch 'openjdk:master' into JDK-8326110 > - PR feedback > - 8326110: [8u] The Marlin tests should be updated after JDK-8241307 Moved to 8u452; see https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/447#issuecomment-2518770679 From andrew at openjdk.org Wed Dec 4 23:35:53 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 4 Dec 2024 23:35:53 GMT Subject: [jdk8u-dev] RFR: 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX In-Reply-To: References: Message-ID: On Fri, 15 Nov 2024 20:04:10 GMT, sophia-guo wrote: > 8037013: [TESTBUG] Fix test/java/lang/ClassLoader/Assert.sh on AIX Moved to 8u452; see https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/604#issuecomment-2518769928 From duke at openjdk.org Thu Dec 5 01:03:41 2024 From: duke at openjdk.org (lingjun-cg) Date: Thu, 5 Dec 2024 01:03:41 GMT Subject: [jdk8u-dev] RFR: 8261020: Wrong format parameter in create_emergency_chunk_path [v2] In-Reply-To: References: Message-ID: On Wed, 6 Nov 2024 02:03:09 GMT, lingjun-cg wrote: >> Clean backport from jdk11u. >> I'd like to backport it to fix a crash like the following stack when run the testcase ' 'jdk/jfr/event/gc/detailed/TestPromotionFailedEventWithParallelScavenge.java' on host with AArch64. >> >> >> =============================== >> Stack: [0x0000ffff8b860000,0x0000ffff8ba60000], sp=0x0000ffff8ba5da80, free space=2038k >> Native frames: (J=compiled Java code, j=interpreted, Vv=VM code, C=native code) >> C [libc.so.6+0x27b0c] __strlen_mte+0xc >> C [libc.so.6+0x756e4] __vsnprintf_internal+0xb0 >> C [libc.so.6+0x7576c] vsnprintf+0x2c >> V [libjvm.so+0x868134] os::vsnprintf(char*, unsigned long, char const*, std::__va_list)+0x30 >> V [libjvm.so+0x685ba8] jio_vsnprintf+0x34 >> V [libjvm.so+0x685c44] jio_snprintf+0x78 >> V [libjvm.so+0x5fd624] JfrEmergencyDump::build_dump_path(char const*)+0xe0 >> V [libjvm.so+0x61e634] JfrRepository::open_chunk(bool)+0x98 >> V [libjvm.so+0x61a860] JfrRecorderService::prepare_for_vm_error_rotation()+0x90 >> V [libjvm.so+0x61db50] JfrRecorderService::rotate(int)+0x260 >> V [libjvm.so+0x5fdc18] JfrEmergencyDump::on_vm_shutdown(bool)+0x264 >> V [libjvm.so+0x5e2210] before_exit(JavaThread*)+0x124 >> V [libjvm.so+0x9be134] Threads::destroy_vm()+0x1cc >> V [libjvm.so+0x64901c] jni_DestroyJavaVM+0x80 >> C [libjli.so+0x2e44] JavaMain+0x284 >> C [libpthread.so.0+0x7f74] start_thread+0xd0 >> C [libc.so.6+0x28f9c] thread_start+0xc > > lingjun-cg has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: > > Backport d27533f1967411dfd1b50b3fe0f0cebb936f1d3a keep alive. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/602#issuecomment-2518864534 From mbalao at openjdk.org Thu Dec 5 02:07:45 2024 From: mbalao at openjdk.org (Martin Balao) Date: Thu, 5 Dec 2024 02:07:45 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: On Wed, 4 Dec 2024 19:19:10 GMT, Alexey Bakhtin wrote: >> Not clean backport from JDK11 patch: >> - No GNUStyle options in JDK8 >> - No support for long options >> - Tests updated to use JDK8 API >> - Removed subtest for long option >> >> JTREG tests passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Fix ExtractFilesTest test Marked as reviewed by mbalao (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk8u-dev/pull/608#pullrequestreview-2480266585 From duke at openjdk.org Thu Dec 5 03:03:49 2024 From: duke at openjdk.org (duke) Date: Thu, 5 Dec 2024 03:03:49 GMT Subject: [jdk8u-dev] Withdrawn: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak In-Reply-To: References: Message-ID: On Tue, 3 Sep 2024 21:41:56 GMT, Daniel Hu wrote: > Clean backport that makes TestListenerLeak more robust; already backported to [11](https://github.com/openjdk/jdk11u-dev/pull/2923), 17 and 21. Not clean because 8 file structure. Passes affected test on Linux x64. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/574 From duke at openjdk.org Thu Dec 5 03:46:45 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 5 Dec 2024 03:46:45 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. In-Reply-To: References: Message-ID: On Fri, 29 Nov 2024 00:18:20 GMT, Andrew John Hughes wrote: > This seems to be a dupe of #383? Yes, it is. And the difference in quantity between #607 and #383 is that I did not handle jdk/test/java/awt/Focus/MouseClickRequestFocusRaceTest/MouseClickRequestFocusRaceTest.html. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/607#issuecomment-2519024045 From duke at openjdk.org Thu Dec 5 11:30:16 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 5 Dec 2024 11:30:16 GMT Subject: [jdk8u-dev] RFR: 8044051: Test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation Message-ID: <3jvtyF2FUWX_OKA-exKt23Q2LBFqBrhYQcgwPiNgX_8=.ae1418fc-b8e8-4bd5-941e-97efe5d3a595@github.com> Apply clean. Low risk. ------------- Commit messages: - Backport 9b8b6695108762063f96a275d9567bed72b88126 Changes: https://git.openjdk.org/jdk8u-dev/pull/610/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=610&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8044051 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/610.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/610/head:pull/610 PR: https://git.openjdk.org/jdk8u-dev/pull/610 From andrew at openjdk.org Thu Dec 5 17:56:51 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Thu, 5 Dec 2024 17:56:51 GMT Subject: [jdk8u-dev] Integrated: 8345504: Bump update version of OpenJDK: 8u452 In-Reply-To: References: Message-ID: On Wed, 4 Dec 2024 16:32:44 GMT, Andrew John Hughes wrote: > Rampdown for 8u442 [has begun](https://mail.openjdk.org/pipermail/jdk8u-dev/2024-December/019551.html). 8u-dev needs to transition to 8u452. This pull request has now been integrated. Changeset: d407d631 Author: Andrew John Hughes URL: https://git.openjdk.org/jdk8u-dev/commit/d407d631f80559a5fed251d9fef2cef64ddf7936 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 8345504: Bump update version of OpenJDK: 8u452 Reviewed-by: sgehwolf ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/609 From gnu.andrew at redhat.com Thu Dec 5 20:30:36 2024 From: gnu.andrew at redhat.com (Andrew Hughes) Date: Thu, 5 Dec 2024 20:30:36 +0000 Subject: [RAMPDOWN] 8u442 Now in Rampdown Stage In-Reply-To: References: Message-ID: On 16:29 Wed 04 Dec 2024, Andrew Hughes wrote: > 8u442 is in rampdown for release in January 2025. > > jdk8u-dev is CLOSED for commits until > https://bugs.openjdk.org/browse/JDK-8345504 is integrated to begin the > 8u452 release cycle. > > For critical fixes (i.e. regressions or urgent fixes like tzdata > & cacerts updates) for 8u442, please file a PR against > https://github.com/openjdk/jdk8u and use jdk8u-critical-request to > obtain approval to push (automatic with the /approval request > command [0]). > > [0] https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/approval > > Thanks, > -- > Andrew :) > Pronouns: he / him or they / them > Principal Free Java Software Engineer > OpenJDK Package Owner > Red Hat, Inc. (http://www.redhat.com) > > PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) > Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 > > Please contact via e-mail, not proprietary chat networks > Available on Libera Chat & OFTC IRC networks as gnu_andrew jdk8u-dev is now OPEN for 8u452 development: https://github.com/openjdk/jdk8u-dev/commit/d407d631f80559a5fed251d9fef2cef64ddf7936 Thanks for your patience, -- Andrew :) Pronouns: he / him or they / them Principal Free Java Software Engineer OpenJDK Package Owner Red Hat, Inc. (http://www.redhat.com) PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net) Fingerprint = 5132 579D D154 0ED2 3E04 C5A0 CFDA 0F9B 3596 4222 Please contact via e-mail, not proprietary chat networks Available on Libera Chat & OFTC IRC networks as gnu_andrew -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 228 bytes Desc: not available URL: From andrew at openjdk.org Fri Dec 6 18:40:47 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Dec 2024 18:40:47 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: On Wed, 4 Dec 2024 19:19:10 GMT, Alexey Bakhtin wrote: >> Not clean backport from JDK11 patch: >> - No GNUStyle options in JDK8 >> - No support for long options >> - Tests updated to use JDK8 API >> - Removed subtest for long option >> >> JTREG tests passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Fix ExtractFilesTest test The change looks good to me. Martin has already covered the same comments I would have had about the initial version. I note that the simple `warn` method is pulled in from [JDK-8164805](https://bugs.openjdk.org/browse/JDK-8164805), which is fine because we hardly want to backport a change to do with modular JARs to 8u. I appreciate you considering the translated property files, as I think there's a building problem there in update releases. I'll say more on this in reply to Martin's comment. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u-dev/pull/608#pullrequestreview-2485615926 From andrew at openjdk.org Fri Dec 6 20:26:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 6 Dec 2024 20:26:46 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: <3xL1LjSi7pNtBlS127roh8HowjKHxTY7_io36nfXzQk=.cd3dc1b9-0ce3-4bae-b33a-1b5f57c22248@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <-Udm-8mB5GGx_KW7hp5Wz7Tb1nv_nczEhcms43rMuKE=.d1d3c7c1-6351-4cca-b6cb-d8c0490f2132@github.com> <3xL1LjSi7pNtBlS127roh8HowjKHxTY7_io36nfXzQk=.cd3dc1b9-0ce3-4bae-b33a-1b5f57c22248@github.com> Message-ID: On Wed, 4 Dec 2024 17:37:50 GMT, Alexey Bakhtin wrote: > @alexeybakhtin , thanks for considering the suggested changes. > > Looks like `jar_pt_BR.properties` was missed, if we really want to update all `jar...properties`. Changes to `jar...properties` make me think that the new option will not be documented for languages other than English. Would be very tricky to do the translation for all languages and perhaps is acceptable not to do it, as it has not been done for JDK main line either. While the spirit in 8u was different, it's not unreasonable for developer tools to be in English only. I'd suggest to update `jar_pt_BR.properties` and leave it there. The reader will probably fall back to English for an explanation of the (undocumented) `k`. If people really want to do the translation, I can contribute Spanish and Portuguese. > > What do you think? They do tend to get documented, but in separate updates from the i18n team. The last one is [JDK-8337054](https://github.com/openjdk/jdk/commit/e68df528f80cff3a5564a12b7ec71a920800ce28) for JDK 23. I suspect we'll get another mass update for 24 when it is released, which will include these. There is an issue with backport releases that we don't get these updates when Oracle cede ownership of them. The last one for 8u is [8214357](https://github.com/openjdk/jdk8u/commit/419ea432e817aabdd064665af594c018135a508d). We likely need to do a check for where the base properties file has keys that the translations do not, but content changes to existing keys will be harder to spot. Contributing translations for this to trunk might be a good way to open conversation on this, if you have the time. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2524091668 From abakhtin at openjdk.org Fri Dec 6 20:36:47 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Fri, 6 Dec 2024 20:36:47 GMT Subject: [jdk8u-dev] Integrated: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files In-Reply-To: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: On Tue, 26 Nov 2024 23:41:59 GMT, Alexey Bakhtin wrote: > Not clean backport from JDK11 patch: > - No GNUStyle options in JDK8 > - No support for long options > - Tests updated to use JDK8 API > - Removed subtest for long option > > JTREG tests passed This pull request has now been integrated. Changeset: 5a4b4408 Author: Alexey Bakhtin URL: https://git.openjdk.org/jdk8u-dev/commit/5a4b44089f3f95b92620ef3a7b49f2390b70afaa Stats: 508 lines in 14 files changed: 495 ins; 0 del; 13 mod 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files Reviewed-by: mbalao, andrew Backport-of: 158b93d19a518d2b9d3d185e2d4c4dbff9c82aab ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/608 From syan at openjdk.org Sun Dec 8 02:08:42 2024 From: syan at openjdk.org (SendaoYan) Date: Sun, 8 Dec 2024 02:08:42 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: On Wed, 4 Dec 2024 19:19:10 GMT, Alexey Bakhtin wrote: >> Not clean backport from JDK11 patch: >> - No GNUStyle options in JDK8 >> - No support for long options >> - Tests updated to use JDK8 API >> - Removed subtest for long option >> >> JTREG tests passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Fix ExtractFilesTest test The two newly added tests fails. Tests: tools/jar/ExtractFilesTest.java tools/jar/MultipleManifestTest.java Test log snippet: /tmp/tone/run/jtreg/jdk-repo/jdk/test/tools/jar/ExtractFilesTest.java:38: error: package org.junit.jupiter.api does not exist import org.junit.jupiter.api.TestInstance; ^ /tmp/tone/run/jtreg/jdk-repo/jdk/test/tools/jar/ExtractFilesTest.java:39: error: package org.junit.jupiter.api.TestInstance does not exist import org.junit.jupiter.api.TestInstance.Lifecycle; ^ /tmp/tone/run/jtreg/jdk-repo/jdk/test/tools/jar/ExtractFilesTest.java:54: error: cannot find symbol @TestInstance(Lifecycle.PER_CLASS) ^ symbol: class TestInstance ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2525379337 From syan at openjdk.org Sun Dec 8 02:53:43 2024 From: syan at openjdk.org (SendaoYan) Date: Sun, 8 Dec 2024 02:53:43 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: On Wed, 4 Dec 2024 19:19:10 GMT, Alexey Bakhtin wrote: >> Not clean backport from JDK11 patch: >> - No GNUStyle options in JDK8 >> - No support for long options >> - Tests updated to use JDK8 API >> - Removed subtest for long option >> >> JTREG tests passed > > Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision: > > Fix ExtractFilesTest test The minimum jtreg version of jdk11u-dev is 7.3.1+1, the minimum jtreg version of jdk8u-dev seems to be 5.1. So these two tests can't backport from jdk11u-dev to jdk8u-dev directively ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2525391088 From abakhtin at openjdk.org Mon Dec 9 19:43:47 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Mon, 9 Dec 2024 19:43:47 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: On Sun, 8 Dec 2024 02:51:03 GMT, SendaoYan wrote: > The minimum jtreg version of jdk11u-dev is 7.3.1+1, the minimum jtreg version of jdk8u-dev seems to be 5.1. So these two tests can't backport from jdk11u-dev to jdk8u-dev directively. The `org.junit.jupiter.api` does not exist in jtreg5.1 Sorry for breaking this compatibility, but is there any document that defines the minimum jtreg version for jdk8u-dev? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2529237719 From fferrari at openjdk.org Tue Dec 10 00:43:45 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Tue, 10 Dec 2024 00:43:45 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Thu, 7 Nov 2024 11:40:27 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX Hi, sorry for my delayed reply, I'm resuming work on this issue. Here is [the relevant part of the failure log](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/484/consoleText#:~:text=machnode.cpp-,%5B2024%2D11%2D14T21%3A10%3A24.721Z%5D,Error%201) (from [`jdk8u-aix-ppc64-temurin` Build #484](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/484/) thanks @jerboaa for pointing me to that Jenkins instance): [2024-11-14T21:10:24.721Z] "/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-aix-ppc64-temurin/workspace/build/src/hotspot/src/share/vm/opto/superword.hpp", line 591.26: 1540-0219 (S) The call to "abs" has no best match. [2024-11-14T21:10:24.721Z] "/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-aix-ppc64-temurin/workspace/build/src/hotspot/src/share/vm/opto/superword.hpp", line 591.43: 1540-1229 (I) Argument number 1 is an rvalue of type "long". [2024-11-14T21:10:24.721Z] "/usr/include/math.h", line 1033.20: 1540-1202 (I) No candidate is better than "abs(long double)". [2024-11-14T21:10:24.721Z] "/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-aix-ppc64-temurin/workspace/build/src/hotspot/src/share/vm/opto/superword.hpp", line 591.43: 1540-1231 (I) The conversion from argument number 1 to "long double" uses "a floating point-integral conversion". [2024-11-14T21:10:24.721Z] "/usr/include/math.h", line 1003.14: 1540-1202 (I) No candidate is better than "abs(float)". [2024-11-14T21:10:24.721Z] "/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-aix-ppc64-temurin/workspace/build/src/hotspot/src/share/vm/opto/superword.hpp", line 591.43: 1540-1231 (I) The conversion from argument number 1 to "float" uses "a floating point-integral conversion". [2024-11-14T21:10:24.721Z] "/usr/include/math.h", line 1001.15: 1540-1202 (I) No candidate is better than "abs(double)". [2024-11-14T21:10:24.721Z] "/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-aix-ppc64-temurin/workspace/build/src/hotspot/src/share/vm/opto/superword.hpp", line 591.43: 1540-1231 (I) The conversion from argument number 1 to "double" uses "a floating point-integral conversion". [2024-11-14T21:10:24.721Z] "/usr/include/stdlib.h", line 803.18: 1540-1202 (I) No candidate is better than "abs(int)". [2024-11-14T21:10:24.721Z] "/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-aix-ppc64-temurin/workspace/build/src/hotspot/src/share/vm/opto/superword.hpp", line 591.43: 1540-1231 (I) The conversion from argument number 1 to "int" uses "an integral conversion". [2024-11-14T21:10:24.721Z] gmake[6]: *** [/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-aix-ppc64-temurin/workspace/build/src/hotspot/make/aix/makefiles/rules.make:151: loopnode.o] Error 1 We are building for _ppc64_, and searching the best candidate for `abs(long)`. The following candidates are considered at an equal-level (so none of them is the "best match"): * `abs(long double)` from `/usr/include/math.h`, using "a floating point-integral conversion" * `abs(float)` from `/usr/include/math.h`, using "a floating point-integral conversion" * `abs(double)` from `/usr/include/math.h`, using "a floating point-integral conversion" * `abs(int)` from `/usr/include/stdlib.h`, using "an integral conversion" `xlC` is unable to find the `abs(long)` candidate, which should qualify at the highest level (no argument conversion, so the "best match"). >From @varada1110 [tests](#issuecomment-2487668534), this candidate is available in `cstdlib` (although in that particular case, isn't a "best match" for `unsigned long`): "/opt/IBM/xlC/13.1.3/include/cstdlib", line 74.15: 1540-1202 (I) No candidate is better than "abs(long)". Trying to get some external clues, I did a simple _Fedora Linux x86-64_ test with GCC. I found that `std::abs` is used even if we include `stdlib.h` and don't qualify `abs` with the `std::` namespace: ```c++ g++ -pedantic -Wall -xc++ -std=c++11 -op -<<'EOF' ////////////////////////////////////////////////// #include #include int main() { long var = -1234567890; // 0xffffffffb669fd2e std::cout << abs(var) << std::endl; } ////////////////////////////////////////////////// EOF ./p sha256sum p objdump --insn-width=8 -dC p | grep -A10 'abs|
' rm -f p Output: 1234567890 3657bd6d3bb686f0dc8e058cce73199bb38b7c20113f3c599a11629577dbb12b p 0000000000401146
: 401146: 55 push %rbp 401147: 48 89 e5 mov %rsp,%rbp 40114a: 48 83 ec 10 sub $0x10,%rsp 40114e: 48 c7 45 f8 2e fd 69 b6 movq $0xffffffffb669fd2e,-0x8(%rbp) 401156: 48 8b 45 f8 mov -0x8(%rbp),%rax 40115a: 48 89 c7 mov %rax,%rdi 40115d: e8 21 00 00 00 call 401183 401162: 48 89 c6 mov %rax,%rsi 401165: bf 40 40 40 00 mov $0x404040,%edi 40116a: e8 e1 fe ff ff call 401050 40116f: be 30 10 40 00 mov $0x401030,%esi 401174: 48 89 c7 mov %rax,%rdi 401177: e8 c4 fe ff ff call 401040 40117c: b8 00 00 00 00 mov $0x0,%eax 401181: c9 leave 401182: c3 ret 0000000000401183 : 401183: 55 push %rbp 401184: 48 89 e5 mov %rsp,%rbp 401187: 48 89 7d f8 mov %rdi,-0x8(%rbp) 40118b: 48 8b 45 f8 mov -0x8(%rbp),%rax 40118f: 48 89 c2 mov %rax,%rdx 401192: 48 f7 da neg %rdx 401195: 48 0f 49 c2 cmovns %rdx,%rax 401199: 5d pop %rbp 40119a: c3 ret In fact, the following three combinations produce an identical binary: * `#include ` / `std::abs(var)` * `#include ` / `abs(var)` (the combination in the previous snippet) * `#include ` / `std::abs(var)` Apparently, the `#include ` / `abs(var)` combination yields some sort of inlined `abs` (I don't know where it's coming from): 0000000000401146
: [...] 40114e: 48 c7 45 f8 2e fd 69 b6 movq $0xffffffffb669fd2e,-0x8(%rbp) 401156: 48 8b 45 f8 mov -0x8(%rbp),%rax 40115a: 89 c2 mov %eax,%edx 40115c: f7 da neg %edx 40115e: 0f 49 c2 cmovns %edx,%eax [...] I will proceed to get [Temporary test system access](https://github.com/adoptium/infrastructure/blob/master/docs/AccessControl.md#temporary-test-system-access) and continue experimentation in _AIX ppc64_. Some doubts I plan to clarify are: 1. What are the _AIX ppc64_ results of the equivalent tests I did for _Fedora Linux x86-64_? 2. Assuming I get access to both compiler versions, are there any differences between `xlC` 13.1.3 and `xlC` 16.1.0? 3. Is there a `/opt/IBM/xlC/13.1.3/include/stdlib.h` file? * What happens if we include that one instead of `/usr/include/stdlib.h`? * Assuming I get access to both compiler versions, repeat for `/opt/IBM/xlC/16.1.0/include/stdlib.h` Any other research suggestions or advices are welcome. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2529925265 From syan at openjdk.org Tue Dec 10 03:07:46 2024 From: syan at openjdk.org (SendaoYan) Date: Tue, 10 Dec 2024 03:07:46 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> Message-ID: <3Vey0IZxocP5qKc-hSHzjwjNlvkEl0uWk9ct90OdJZ8=.8311d70a-711d-45ee-b115-20da86401985@github.com> On Mon, 9 Dec 2024 19:41:28 GMT, Alexey Bakhtin wrote: > is there any document that defines the minimum jtreg version for jdk8u-dev? jdk8u-dev: https://github.com/openjdk/jdk8u-dev/blob/master/make/conf/test-dependencies#L29 jdk11u-dev: https://github.com/openjdk/jdk11u-dev/blob/master/make/conf/github-actions.conf#L29 or: https://github.com/openjdk/jdk11u-dev/blob/master/test/jdk/TEST.ROOT#L65 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2530141212 From dcherepanov at openjdk.org Tue Dec 10 19:17:00 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Tue, 10 Dec 2024 19:17:00 GMT Subject: [jdk8u] RFR: 8339644: Improve parsing of Day/Month in tzdata rules Message-ID: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release). The change doesn?t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it?s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year. Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (?Unknown month: April?) without the changes and builds with the changes. Thanks. ------------- Commit messages: - Backport 86a2f9c7dcb6585cabf03c0940511d11560e85b7 Changes: https://git.openjdk.org/jdk8u/pull/64/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=64&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8339644 Stats: 88 lines in 3 files changed: 32 ins; 28 del; 28 mod Patch: https://git.openjdk.org/jdk8u/pull/64.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/64/head:pull/64 PR: https://git.openjdk.org/jdk8u/pull/64 From abakhtin at openjdk.org Tue Dec 10 19:49:48 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 10 Dec 2024 19:49:48 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: <3Vey0IZxocP5qKc-hSHzjwjNlvkEl0uWk9ct90OdJZ8=.8311d70a-711d-45ee-b115-20da86401985@github.com> References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <3Vey0IZxocP5qKc-hSHzjwjNlvkEl0uWk9ct90OdJZ8=.8311d70a-711d-45ee-b115-20da86401985@github.com> Message-ID: On Tue, 10 Dec 2024 03:05:09 GMT, SendaoYan wrote: >>> The minimum jtreg version of jdk11u-dev is 7.3.1+1, the minimum jtreg version of jdk8u-dev seems to be 5.1. So these two tests can't backport from jdk11u-dev to jdk8u-dev directively. The `org.junit.jupiter.api` does not exist in jtreg5.1 >> >> Sorry for breaking this compatibility, but is there any document that defines the minimum jtreg version for jdk8u-dev? > >> is there any document that defines the minimum jtreg version for jdk8u-dev? > > jdk8u-dev: > > https://github.com/openjdk/jdk8u-dev/blob/master/make/conf/test-dependencies#L29 > > jdk11u-dev: > > https://github.com/openjdk/jdk11u-dev/blob/master/make/conf/github-actions.conf#L29 > > or: > > https://github.com/openjdk/jdk11u-dev/blob/master/test/jdk/TEST.ROOT#L65 Thank you @sendaoYan, Could you suggest how we should deal with these tests? Should I submit an issue to remove these tests OR add them to the ProblemList OR update jtreg requirements? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2532717658 From abakhtin at openjdk.org Tue Dec 10 22:49:13 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Tue, 10 Dec 2024 22:49:13 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties Message-ID: Add missing properties for the j2gss.dll and sspi_bridge.dll files ------------- Commit messages: - 8345358: Some DLL Files are missing Windows Properties Changes: https://git.openjdk.org/jdk8u-dev/pull/611/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=611&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8345358 Stats: 10 lines in 1 file changed: 10 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/611.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/611/head:pull/611 PR: https://git.openjdk.org/jdk8u-dev/pull/611 From duke at openjdk.org Tue Dec 10 23:33:40 2024 From: duke at openjdk.org (Taizo Kurashige) Date: Tue, 10 Dec 2024 23:33:40 GMT Subject: [jdk8u-dev] RFR: 8341946: [8u] sun/security/pkcs11/ec/ tests fail on RHEL9 In-Reply-To: References: Message-ID: On Fri, 11 Oct 2024 08:56:05 GMT, Taizo Kurashige wrote: > The following tests fail when they cannot find the NSS version information, because the initial value of nss_ecc_status is ECCState.Extended and tries to use the EC algorithm not supported in ECCState.Basic, > > sun/security/pkcs11/ec/TestECDH.java > sun/security/pkcs11/ec/TestECDSA.java > sun/security/pkcs11/ec/TestECGenSpec.java > > To resolve these failures, change the initial value of nss_ecc_status from ECCState.Extended to ECCState.Basic. > > Similar fix was made in [JDK-8253637](https://bugs.openjdk.org/browse/JDK-8253637) for jdk16 and later, and [JDK-8328889](https://bugs.openjdk.org/browse/JDK-8328889) for jdk11. > > JDK-8253637 and JDK-8313206 were done with versions higher than jdk8. For this reason, it is normal to do a backport, but do not backport to jdk11 or jdk8 because: > > JDK-8253637 > About jdk11 > ?The ECDHKeyAgreement.java diff contains enhancements that have not been applied to jdk11 and cannot be backported to jdk11. > ?Since TestEC.java is now passed in jdk11 and has been removed from the ProblemList, there is no need to modify Problemlist.txt and TestEC.java. > ?The fix for PKCS11Test.java has already been made in JDK-8313206. > About jdk8 > ?For the same reason as jdk11, the ECDHKeyAgreement.java diff is not applicable, and the TestEC.java and Problemlist.txt diffs need not be applied. > ?All we need is a PKCS11Test.java fix to resolve 3 failures (TestECDH.java, TestECDSA.java and TestECGenSpec.java). It is appropriate to issue a new bug ID this time because the test to be solved is different from JDK-8253637. > > JDK-8313206 > In JDK-8313206, only jdk11 has the fix to the initial value of nss_ecc_status in PKCS11Test.java. > Since JDK-8313206 is a different topic than the one I want to solve this time, I think it is inappropriate to backport to solve 3 failures(TestECDH.java, TestECDSA.java and TestECGenSpec.java). > > Thanks @gnu-andrew I'm sorry, but if you have time, I would appreciate it if you could check it. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/594#issuecomment-2533215841 From abakhtin at openjdk.org Wed Dec 11 00:22:44 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Wed, 11 Dec 2024 00:22:44 GMT Subject: [jdk8u-dev] RFR: 8345358: Some DLL Files are missing Windows Properties In-Reply-To: References: Message-ID: On Tue, 10 Dec 2024 22:45:15 GMT, Alexey Bakhtin wrote: > Add missing properties for the j2gss.dll and sspi_bridge.dll files CI Failures are not related to the changes. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/611#issuecomment-2533332141 From srl at openjdk.org Wed Dec 11 02:39:51 2024 From: srl at openjdk.org (Steven Loomis) Date: Wed, 11 Dec 2024 02:39:51 GMT Subject: [jdk8u-dev] RFR: 8195675: Call to insertText with single character from custom Input Method ignored [v4] In-Reply-To: References: Message-ID: On Mon, 4 Nov 2024 16:25:54 GMT, Steven Loomis wrote: >> Hi all, >> >> This pull request contains a backport of commit b8f2ec90 from the openjdk/jdk repository. >> >> The commit being backported was authored by Steven Loomis on 28 May 2024 and was reviewed by Phil Race. >> PR was https://github.com/openjdk/jdk/pull/17921 >> >> Thanks > > Steven Loomis has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: > > - 8195675: merge from master > - 8195675: whitespace fix > - 8195675: partial backport of 8214578 to add kbdLayout > > - This change turned out to depend on 8214578 > - Backport of https://github.com/openjdk/jdk/commit/0b0a33e4c1a5d3f54f733767796cd7e612c4d93d for the kbdLayout > - also see https://github.com/openjdk/jdk/commit/02bbbb41857c8ba3c56b1c1670a7e72d8264658d > - Backport b8f2ec9091f9f7e5f4611991d04dd8aa113b94fd > > > @srl295 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! I need help with 8-request triaging ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/595#issuecomment-2533494421 From syan at openjdk.org Wed Dec 11 02:47:47 2024 From: syan at openjdk.org (SendaoYan) Date: Wed, 11 Dec 2024 02:47:47 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <3Vey0IZxocP5qKc-hSHzjwjNlvkEl0uWk9ct90OdJZ8=.8311d70a-711d-45ee-b115-20da86401985@github.com> Message-ID: On Tue, 10 Dec 2024 19:46:40 GMT, Alexey Bakhtin wrote: > Could you suggest how we should deal with these tests? Should I submit an issue to remove these tests OR add them to the ProblemList OR update jtreg requirements? Maybe there are some tests in jdk8u-dev depends jtreg5.1, so I think update jtreg version requirements maybe not a good idea. I think the better way is resolve the dependencies of jtreg7.3.1 for these tests, similar to https://github.com/openjdk/jdk11u-dev/pull/2553 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2533502567 From duke at openjdk.org Thu Dec 12 02:25:50 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Dec 2024 02:25:50 GMT Subject: [jdk8u-dev] Withdrawn: 8185500: [TESTBUG] Add keywords headful/printer in java/awt and javax tests. In-Reply-To: References: Message-ID: On Mon, 4 Mar 2024 02:36:32 GMT, yaqsun wrote: > This backport has modified the following aspects: > > - there are 53 cases that do not exist: > jdk/test/java/awt/Choice/ChoiceHiDpi/ChoiceTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modal/NestedModalDialogTest.java > jdk/test/java/awt/Dialog/NestedDialogs/Modeless/NestedModelessDialogTest.java > jdk/test/java/awt/FileDialog/FileDialogIconTest/FileDialogIconTest.java > jdk/test/java/awt/Focus/FocusTraversalPolicy/ButtonGroupLayoutTraversal/ButtonGroupLayoutTraversalTest.java > jdk/test/java/awt/Focus/RequestFocusByCause/RequestFocusByCauseTest.java > jdk/test/java/awt/Frame/8158918/SetExtendedState.java > jdk/test/java/awt/Frame/DecoratedFrameInsets/DecoratedFrameInsetsTest.java > jdk/test/java/awt/Frame/SetMaximizedBounds/MaximizedMovedWindow.java > jdk/test/java/awt/FullScreen/CurrentDisplayModeTest/CurrentDisplayModeTest.java > jdk/test/java/awt/GraphicsDevice/DisplayModes/CompareToXrandrTest.java > jdk/test/java/awt/hidpi/properties/HiDPIPropertiesWindowsTest.java > jdk/test/java/awt/image/multiresolution/Corrupted2XImageTest.java > jdk/test/java/awt/keyboard/AllKeyCode/AllKeyCode.java > jdk/test/java/awt/Robot/HiDPIMouseClick/HiDPIRobotMouseClick.java > jdk/test/java/awt/Robot/HiDPIScreenCapture/HiDPIRobotScreenCaptureTest.java > jdk/test/java/awt/Scrollbar/ScrollbarMouseWheelTest/ScrollbarMouseWheelTest.java > jdk/test/java/awt/SplashScreen/MultiResolutionSplash/unix/UnixMultiResolutionSplashTest.java > jdk/test/java/awt/TextArea/AutoScrollOnSelectAndAppend/AutoScrollOnSelectAndAppend.java > jdk/test/java/awt/TextArea/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/TextField/OverScrollTest/OverScrollTest.java > jdk/test/java/awt/Window/GetScreenLocation/GetScreenLocationTest.java > jdk/test/java/awt/Window/SetWindowLocationByPlatformTest/SetWindowLocationByPlatformTest.java > jdk/test/javax/swing/JButton/8151303/PressedIconTest.java > jdk/test/javax/swing/JComboBox/8041909/ActionListenerExceptionTest.java > jdk/test/javax/swing/JComboBox/WindowsComboBoxSize/WindowsComboBoxSizeTest.java > jdk/test/javax/swing/JFileChooser/8010718/bug8010718.java > jdk/test/javax/swing/JFileChooser/8152677/SelectAllFilesFilterTest.java > jdk/test/javax/swing/JInternalFrame/6288609/TestJInternalFrameDispose.java > jdk/test/javax/swing/JInternalFrame/8075314/bug8075314.java > jdk/test/javax/swing/JInternalFrame/8145060/TestJInternalFrameMinimize.java > jdk/test/javax/swing/JInternalFrame/8160248/JInternalFrameDraggingTest.java > jdk/test/javax/swing/JInternalFrame/DockIconRepaint/DockIconRepaint.java > jdk/test/javax/swing/J... This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/464 From dzhang at openjdk.org Thu Dec 12 03:24:46 2024 From: dzhang at openjdk.org (Dingli Zhang) Date: Thu, 12 Dec 2024 03:24:46 GMT Subject: [jdk8u-dev] RFR: 8199138: Add RISC-V support to Zero [v2] In-Reply-To: References: Message-ID: <1yijscgoKu1yV3WR-DLGKLaFupNzvAO-X4X68MQ2sSk=.490c0091-4d38-44d4-9a07-9acf0bea1617@github.com> On Tue, 3 Sep 2024 11:34:42 GMT, Dingli Zhang wrote: >> Hi all, >> >> I'd like to backport this patch to jdk8u. Since most linux distributions support riscv64 and provide zero version jdk8 for riscv64. However, we may need to do some workarounds each time we upgrade the version, so I think it is helpful to provide zero support for riscv64 here. >> >> `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path and remove test of `x$OPENJDK_$1_CPU`. >> >> `common/autoconf/generated-configure.sh` regenerated by `bash common/autoconf/autogen.sh`. I used autoconf-2.69 and build from the [source](https://ftp.gnu.org/gnu/autoconf/autoconf-2.69.tar.gz) . But it looks a bit different from the one generated in the repo. I also tried autoconf-2.69 that comes with ubuntu 20.04 and the generated file is similar to the one in https://github.com/openjdk/jdk8u-dev/pull/413. I'm not quite sure which version of autoconf2.69 to use, if anyone has a better suggestion or is willing to help me generate a different one, I'd appreciate it! >> >> Both cross-compile build and native build on riscv64 hardware is tested. >> >> ### cross-compile on x86 >> #### boot jdk >> >> openjdk version "1.8.0_43" >> OpenJDK Runtime Environment (build 1.8.0_43-b03) >> OpenJDK 64-Bit Server VM (build 25.40-b25, mixed mode) >> >> #### run on qemu >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-zhangdingli_2024_09_02_21_37-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> ### native build on lp4a >> #### boot jdk >> >> openjdk version "1.8.0_412" >> OpenJDK Runtime Environment Bisheng (build 1.8.0_412-b08) >> OpenJDK 64-Bit Zero VM Bisheng (build 25.412-b08, interpreted mode) >> >> #### run on lp4a >> >> openjdk version "1.8.0_432-internal" >> OpenJDK Runtime Environment (build 1.8.0_432-internal-openeuler_2024_09_02_21_38-b00) >> OpenJDK 64-Bit Zero VM (build 25.432-b00, interpreted mode) >> >> >> Thanks, >> Dingli > > Dingli Zhang has updated the pull request incrementally with one additional commit since the last revision: > > Put EM_RISCV after definition of EM_LOONGARCH bot, please keep it open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/573#issuecomment-2537722689 From duke at openjdk.org Thu Dec 12 08:10:46 2024 From: duke at openjdk.org (duke) Date: Thu, 12 Dec 2024 08:10:46 GMT Subject: [jdk8u-dev] Withdrawn: 8275303: sun/java2d/pipe/InterpolationQualityTest.java fails with D3D basic render driver In-Reply-To: References: Message-ID: On Sat, 22 Jun 2024 00:00:05 GMT, Sergey Bylokhov wrote: > Hi all, > > This pull request contains a backport of commit [bc0379ea](https://github.com/openjdk/jdk/commit/bc0379ea1a22a2631b49ecd6a331352bec81c1c6) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being backported was authored by Phil Race on 25 May 2022 and was reviewed by Sergey Bylokhov and Prasanta Sadhukhan. > > Thanks! This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/523 From duke at openjdk.org Thu Dec 12 08:24:48 2024 From: duke at openjdk.org (yaqsun) Date: Thu, 12 Dec 2024 08:24:48 GMT Subject: [jdk8u-dev] RFR: 8326725: [TESTBUG] [8u] Add keywords headful in MoveToOtherScreenTest.java test [v6] In-Reply-To: References: <_oBGvGjLmD1PmA986t28Pu172gvp_O4h9wbpPnFT9Kk=.2708e011-fec0-4d87-8d34-fcd1621e690b@github.com> Message-ID: On Thu, 14 Nov 2024 02:32:13 GMT, yaqsun wrote: >> JDK-8164119 remove key attribute headful, >> MoveToOtherScreenTest fails due wrong key attribute: >> @key headful >> isn't included in TEST.ROOT in jdk8. >> But define "headful" jtreg keyword on JDK-8129822. >> So add keywords headful in MoveToOtherScreenTest.java test. > > yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision: > > - Merge branch 'openjdk:master' into backport-8164119 > - adjust headful position > - Merge branch 'openjdk:master' into backport-8164119 > - Merge branch 'openjdk:master' into backport-8164119 > - update Copyright > - MoveToOtherScreenTest fails due wrong key attribute keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/460#issuecomment-2538145684 From abakhtin at openjdk.org Thu Dec 12 22:58:56 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 12 Dec 2024 22:58:56 GMT Subject: [jdk8u-dev] RFR: 8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 Message-ID: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com> ?stTest.java fails with jtreg5.1 Tests fixed to be compatible with jtreg 5.1 ------------- Commit messages: - 8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 Changes: https://git.openjdk.org/jdk8u-dev/pull/612/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=612&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8346140 Stats: 42 lines in 2 files changed: 1 ins; 18 del; 23 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/612.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/612/head:pull/612 PR: https://git.openjdk.org/jdk8u-dev/pull/612 From abakhtin at openjdk.org Thu Dec 12 22:58:50 2024 From: abakhtin at openjdk.org (Alexey Bakhtin) Date: Thu, 12 Dec 2024 22:58:50 GMT Subject: [jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4] In-Reply-To: References: <3FoHDTDYyBLxK2Q3vwuRXg2awbt1JQv71OyqiFornB0=.e8f8cbae-bc57-477f-b0cd-225b588c71b5@github.com> <3Vey0IZxocP5qKc-hSHzjwjNlvkEl0uWk9ct90OdJZ8=.8311d70a-711d-45ee-b115-20da86401985@github.com> Message-ID: On Wed, 11 Dec 2024 02:44:43 GMT, SendaoYan wrote: >> Thank you @sendaoYan, >> >> Could you suggest how we should deal with these tests? Should I submit an issue to remove these tests OR add them to the ProblemList OR update jtreg requirements? > >> Could you suggest how we should deal with these tests? Should I submit an issue to remove these tests OR add them to the ProblemList OR update jtreg requirements? > > Maybe there are some tests in jdk8u-dev depends jtreg5.1, so I think update jtreg version requirements maybe not a good idea. > I think the better way is resolve the dependencies of jtreg7.3.1 for these tests, similar to https://github.com/openjdk/jdk11u-dev/pull/2553 @sendaoYan , Thank you for the finding one more time. Please have a look at the proposed fix at https://github.com/openjdk/jdk8u-dev/pull/612 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2540172593 From syan at openjdk.org Fri Dec 13 04:34:40 2024 From: syan at openjdk.org (SendaoYan) Date: Fri, 13 Dec 2024 04:34:40 GMT Subject: [jdk8u-dev] RFR: 8346140: tools/jar/ExtractFilesTest.java and tools/jar/MultipleManifestTest.java fails with jtreg5.1 In-Reply-To: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com> References: <9vkehHdfhZqRaU5ok39v-lvQq64jbGMMleFGJVhcVyk=.e4b05e3e-df54-407c-abf1-93e7dcfef74a@github.com> Message-ID: On Thu, 12 Dec 2024 22:54:30 GMT, Alexey Bakhtin wrote: > ?stTest.java fails with jtreg5.1 > > Tests fixed to be compatible with jtreg 5.1 Tests run passed with jtreg5.1 ------------- Marked as reviewed by syan (no project role). PR Review: https://git.openjdk.org/jdk8u-dev/pull/612#pullrequestreview-2501272488 From ktakakuri at openjdk.org Mon Dec 16 10:51:43 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Mon, 16 Dec 2024 10:51:43 GMT Subject: [jdk8u-dev] RFR: 8217612: (CL)HSDB cannot show some JVM flags [v3] In-Reply-To: References: Message-ID: On Mon, 19 Aug 2024 12:08:28 GMT, Kazuhisa Takakuri wrote: >> Hi all, this is a backport of JDK-8217612: (CL)HSDB cannot show some JVM flags. >> The bug reported is reproducible in JDK8, so this patch should be applied. >> This patch requires the follow-up patch JDK-8217850 and the correspoding pull request has been submitted. >> The original patch does not apply cleanly, and the following modifications are needed: >> >> hotspot/agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java >> >> * Long.toUnsignedString method was introduced in JDK8, and the build fails with JDK7 as the boot-jdk when using this method. Consequently, an alternative private method to Long.toUnsignedString(long i, 10) is required in VM.java. >> * The size_t type was introduced in JDK9, so the related fix is skipped. >> * To return a String value in the getValue method, the original fix uses a static method, whereas this fix creates a new instance each time. The use of a static method was introduced to JDK-9 in the enhancement JDK-8145061. This enhancement has not been backported, so the same format as the other part of the getValue() method should be used. >> * Replace var with String. >> >> hotspot/src/share/vm/runtime/globals.hpp >> >> * A comment on the flag type double and uint64_t is added, which matches teh implementation. This comment was added in JDK-8059847, but this fix is an enhancement and not necessary to backport, so I believe it is valid to fix the comment in this PR. >> >> hotspot/test/serviceability/sa/ClhsdbFlags.java >> >> * This test is backported from the original commit with `@test` removed. This test will not function because the serviceability/sa test framework has not been backported. This follows the discussion in backporting JDK-8196969 to JDK8 (https://mail.openjdk.org/pipermail/jdk8u-dev/2020-May/011785.html ). Backporting SA-related tests is excessive and may require some follow-up test fixes, but it is beneficial to indicate that this test append should be integrated when the test framework is backported in the future. >> >> Testing >> >> * manually check the behaviour >> Consider Running java program with option `-XX:NativeMemoryTracking=off -XX:OnError=echo -XX:MaxRAMPercentage=20.0 -XX:MaxRAM=10000000`. The flag types correspond to ccstr, ccstrlist, double, and uint64_t, respectively. When attaching the process using clhsdb, the value is corrected by this patch as follows. Note that the default value of MaxMetaspaceSize is max_uintx. >> >> without patch >> >> >> hsdb> flags NativeMemoryTracking >> NativeMemoryTracking =... > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Add comment This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/431#issuecomment-2545242138 From varadam at openjdk.org Mon Dec 16 12:18:46 2024 From: varadam at openjdk.org (Varada M) Date: Mon, 16 Dec 2024 12:18:46 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Thu, 7 Nov 2024 11:40:27 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX The build error persists with xlc 16.1.0 version. Also observed that with or adding inline abs() function resolves the issue. https://github.com/openjdk/jdk8u-dev/compare/master...varada1110:abs?expand=1 --- a/hotspot/src/share/vm/libadt/port.hpp +++ b/hotspot/src/share/vm/libadt/port.hpp @@ -91,7 +91,7 @@ inline int max( int a, int b) { return a > b ? a : b; } #define IMPLEMENTATION #include #include - +inline long abs( long x ) { return x < 0 ? -x : x; } +//#include #elif defined(_MSC_VER) // Microsoft Visual C++ //#define INTERFACE ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2545474471 From fferrari at openjdk.org Mon Dec 16 22:51:41 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Mon, 16 Dec 2024 22:51:41 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Thu, 7 Nov 2024 11:40:27 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX Hi, after getting access to an _AIX system_ (thanks @sxa) I have a clearer understanding of what is going on. # Tests I executed in _AIX 7.2_ All the tests have the following structure, I will specify the C++ snippet and the results. cat >test.cpp <<'EOF' // C++ snippet goes here EOF /opt/IBM/xlC/13.1.3/bin/xlC_r -q64 -c -o/dev/null test.cpp /opt/IBM/xlC/16.1.0/bin/xlC_r -q64 -c -o/dev/null test.cpp rm -f test.cpp ## Finding the combination that causes the failure ### Snippets that worked All the following snippets worked, both with `xlC` 13.1.3 and 16.1.0. #### Use `stdlib.h` alone, with `abs()` #include long test() { return abs((long)1); } #### Use `cstdlib` alone, with `std::abs()` #include long test() { return std::abs((long)1); } #### Use `cstdlib` with `std::abs()`, but also include `cmath` before `cstdlib` #include #include long test() { return std::abs((long)1); } #### Use `cstdlib` with `std::abs()`, but also include `cmath` after `cstdlib` #include #include long test() { return std::abs((long)1); } ### Snippets that failed The following snippets failed in the same way, both with `xlC` 13.1.3 and 16.1.0. See the error at the end. #### Use `stdlib.h` with `abs()`, but also include `cmath` before `cstdlib` #include #include long test() { return abs((long)1); } #### Use `stdlib.h` with `abs()`, but also include `cmath` after `cstdlib` #include #include long test() { return abs((long)1); } #### Error "test.cpp", line 5.12: 1540-0219 (S) The call to "abs" has no best match. "test.cpp", line 5.16: 1540-1229 (I) Argument number 1 is an rvalue of type "long". "/usr/include/math.h", line 1033.20: 1540-1202 (I) No candidate is better than "abs(long double)". "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "long double" uses "a floating point-integral conversion". "/usr/include/math.h", line 1003.14: 1540-1202 (I) No candidate is better than "abs(float)". "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "float" uses "a floating point-integral conversion". "/usr/include/math.h", line 1001.15: 1540-1202 (I) No candidate is better than "abs(double)". "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "double" uses "a floating point-integral conversion". "/usr/include/stdlib.h", line 829.18: 1540-1202 (I) No candidate is better than "abs(int)". "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "int" uses "an integral conversion". ### Snippets that resolve the issue It seems the problem is the conjunction of `cmath` with `stdlib.h`, this looks pretty similar to [IY68511: NO ABS(LONG) IMPLEMENTATION IN ](https://www.ibm.com/support/pages/apar/IY68511): > ## Error description > > There is currently no implementation for `abs(long)` functions in ``, but `abs(long)` is defined in the C++ Standard. > > ## Local fix > > Use `` without `` > > ## Problem summary > > `abs(long)` was not defined in the library implementation. > > ## Problem conclusion > > In order to use `abs(long)`, the macro `__ABS_LONG__` must be defined if using `stdlib.h` instead of `cstdlib`, or if `stdlib.h` occurs before `cstdlib` in the include path. The following snippets make it work by adding a third element (inspiration from *Problem conclusion*). #### Define the `__ABS_LONG__` macro as suggested #define __ABS_LONG__ #include #include long test() { return abs((long)1); } NOTE: `__ABS_LONG__` must be defined at the beginning, any combination defining `__ABS_LONG__` after some of the includes, fails. #### Include `cstdlib` in addition to `stdlib.h` #include #include #include long test() { return abs((long)1); } NOTES: * This succeeds for all the 6 possible ways of arranging the 3 includes * If I replace `cstdlib` with `iostream` I get the same results (for the 6 possible arrangements) * I don't see a direct `#include ` from `iostream`, but I assume an indirect inclusion or this somehow implying the definition of `__ABS_LONG__` * This originally made it more difficult to reproduce the issue, as I was basing on my previous snippets, which were including `iostream` to use `std::cout` # Conclusions For 11u, I would discard the compiler version as a possible reason why we aren't experiencing this issue (given all the previous tests were identical in both versions). I would lean towards a different preprocessor result, due to a different topology of the includes graph. For 8u, in my opinion, the acceptable fixes would include: * Passing `-D__ABS_LONG__` to `xlC` * Including `cstdlib` in `hotspot/src/share/vm/opto/superword.hpp`, which is the one using `abs(long)` * This shouldn't break other platforms builds, but we would need to test them I've tested both by re-executing the failed build command (not the whole build) and seem to be working. Here is the build command I've obtained building with `make_64 LOG=debug CONF=aix-ppc64-normal-server-release images`, in case anyone wants to give a look to the compiler flags: # PWD: /home/fferrari/jdk8u/build/aix-ppc64-normal-server-release/hotspot/aix_ppc64_compiler2/product rm -f loopnode.o /opt/IBM/xlC/13.1.3/bin/xlC_r -DAIX -DPPC64 -DPRODUCT \ -I/home/fferrari/jdk8u/hotspot/src/share/vm/prims \ -I/home/fferrari/jdk8u/hotspot/src/share/vm \ -I/home/fferrari/jdk8u/hotspot/src/share/vm/precompiled \ -I/home/fferrari/jdk8u/hotspot/src/cpu/ppc/vm \ -I/home/fferrari/jdk8u/hotspot/src/os_cpu/aix_ppc/vm \ -I/home/fferrari/jdk8u/hotspot/src/os/aix/vm \ -I/home/fferrari/jdk8u/hotspot/src/os/posix/vm \ -I../generated \ -DHOTSPOT_RELEASE_VERSION=""25.442-b00"" \ -DHOTSPOT_BUILD_TARGET=""product"" -DHOTSPOT_BUILD_USER=""fferrari"" \ -DHOTSPOT_LIB_ARCH="ppc64" -DHOTSPOT_VM_DISTRO=""OpenJDK"" \ -DTARGET_OS_FAMILY_aix -DTARGET_ARCH_ppc -DTARGET_ARCH_MODEL_ppc_64 \ -DTARGET_OS_ARCH_aix_ppc -DTARGET_OS_ARCH_MODEL_aix_ppc_64 \ -DTARGET_COMPILER_xlc -DINCLUDE_JFR=0 -DCOMPILER2 -qpic=large -qnortti \ -qnoeh -D_REENTRANT -D__STDC_FORMAT_MACROS -q64 -O3 -qalias=noansi -g \ -qarch=ppc64 -qtune=balanced -qinlglue -qstrict -qxflag=ASMMIDCOALFIX \ -qxflag=asmfastsync -qhot=level=1 -qignerrno -qinline -q64 -qlanglvl=c99vla \ -qlanglvl=noredefmac -qsuppress=1540-0198 -qsuppress=1540-1090 \ -qsuppress=1500-010 -qsuppress=1540-1639 -qsuppress=1540-1088 \ -lpthread -DALLOW_OPERATOR_NEW_USAGE -c -qmakedep=gcc \ -MF ../generated/dependencies/loopnode.o.d -o loopnode.o \ /home/fferrari/jdk8u/hotspot/src/share/vm/opto/loopnode.cpp ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2547031877 From duke at openjdk.org Tue Dec 17 08:21:43 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 17 Dec 2024 08:21:43 GMT Subject: [jdk8u-dev] RFR: 8237834: com/sun/jndi/ldap/LdapDnsProviderTest.java failing with LDAP response read timeout In-Reply-To: References: Message-ID: <-9zqb3k0UhHBujMpKCd9rVzlD_dH9BLT8wviH3U-Gak=.c438946b-ca8c-4430-8ce0-1e0d907d7d34@github.com> On Tue, 19 Nov 2024 02:39:40 GMT, yaqsun wrote: > This is a backport of JDK-8237834. > The reported bug is reproducible in 8u and needs to be backported. > > This backport is clean. keep open ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/606#issuecomment-2547772718 From varadam at openjdk.org Tue Dec 17 17:55:20 2024 From: varadam at openjdk.org (Varada M) Date: Tue, 17 Dec 2024 17:55:20 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v3] In-Reply-To: References: Message-ID: > Use of llabs() for jlong resolves the build error on AIX. > Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) Varada M has updated the pull request incrementally with one additional commit since the last revision: 8342822: jdk8u432-b06 does not compile on AIX ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/600/files - new: https://git.openjdk.org/jdk8u-dev/pull/600/files/8d18c559..3f0afd8f Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=600&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=600&range=01-02 Stats: 3 lines in 1 file changed: 1 ins; 1 del; 1 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/600.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/600/head:pull/600 PR: https://git.openjdk.org/jdk8u-dev/pull/600 From varadam at openjdk.org Tue Dec 17 18:55:43 2024 From: varadam at openjdk.org (Varada M) Date: Tue, 17 Dec 2024 18:55:43 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Mon, 16 Dec 2024 22:48:40 GMT, Francisco Ferrari Bihurriet wrote: >> Varada M has updated the pull request incrementally with one additional commit since the last revision: >> >> 8342822: jdk8u432-b06 does not compile on AIX > > Hi, after getting access to an _AIX system_ (thanks @sxa) I have a clearer understanding of what is going on. > > # Tests I executed in _AIX 7.2_ > > All the tests have the following structure, I will specify the C++ snippet and the results. > > > cat >test.cpp <<'EOF' > // C++ snippet goes here > EOF > /opt/IBM/xlC/13.1.3/bin/xlC_r -q64 -c -o/dev/null test.cpp > /opt/IBM/xlC/16.1.0/bin/xlC_r -q64 -c -o/dev/null test.cpp > rm -f test.cpp > > > ## Finding the combination that causes the failure > > ### Snippets that worked > > All the following snippets worked, both with `xlC` 13.1.3 and 16.1.0. > > #### Use `stdlib.h` alone, with `abs()` > > > #include > > long test() { > return abs((long)1); > } > > > #### Use `cstdlib` alone, with `std::abs()` > > > #include > > long test() { > return std::abs((long)1); > } > > > #### Use `cstdlib` with `std::abs()`, but also include `cmath` before `cstdlib` > > > #include > #include > > long test() { > return std::abs((long)1); > } > > > #### Use `cstdlib` with `std::abs()`, but also include `cmath` after `cstdlib` > > > #include > #include > > long test() { > return std::abs((long)1); > } > > > ### Snippets that failed > > The following snippets failed in the same way, both with `xlC` 13.1.3 and 16.1.0. See the error at the end. > > #### Use `stdlib.h` with `abs()`, but also include `cmath` before `cstdlib` > > > #include > #include > > long test() { > return abs((long)1); > } > > > #### Use `stdlib.h` with `abs()`, but also include `cmath` after `cstdlib` > > > #include > #include > > long test() { > return abs((long)1); > } > > > #### Error > > > "test.cpp", line 5.12: 1540-0219 (S) The call to "abs" has no best match. > "test.cpp", line 5.16: 1540-1229 (I) Argument number 1 is an rvalue of type "long". > "/usr/include/math.h", line 1033.20: 1540-1202 (I) No candidate is better than "abs(long double)". > "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "long double" uses "a floating point-integral conversion". > "/usr/include/math.h", line 1003.14: 1540-1202 (I) No candidate is better than "abs(float)". > "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "float" uses "a floating point-integral conversion". > "/usr/include/math.h", line 1001.15: 1540-1202 (I) No candidate is better than "abs(double)". > "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "double" uses "a floating point-integral conversion". > "/usr/include/stdlib.h", line 829.18: 1540-1202 (I) No candidate ... Thank you, @franferrax, for identifying the root cause of the issue. I have added the header file, which is resolving the build error. Additionally, I checked by adding -D__ABS_LONG__ in the AIX configuration, and that also resolves the issue. Testing for hotspot/test is successful, with no related failures observed. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2549334410 From duke at openjdk.org Wed Dec 18 10:36:46 2024 From: duke at openjdk.org (duke) Date: Wed, 18 Dec 2024 10:36:46 GMT Subject: [jdk8u-dev] Withdrawn: 8205653: test/jdk/sun/management/jmxremote/bootstrap/RmiRegistrySslTest.java and RmiSslBootstrapTest.sh fail with handshake_failure In-Reply-To: References: Message-ID: On Mon, 15 Jul 2024 16:34:14 GMT, Alexey Bakhtin wrote: > Follow-up fix for JDK-8145919 > Almost clean backport except for /jdk/test/ProblemList.txt > > The patch fixes intermittent failure in test/jdk/sun/management/jmxremote/bootstrap/RmiSslBootstrapTest.sh test. This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/548 From duke at openjdk.org Wed Dec 18 12:58:44 2024 From: duke at openjdk.org (Stewart X Addison) Date: Wed, 18 Dec 2024 12:58:44 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v2] In-Reply-To: References: <9UC1jS2CzyhK1Bt3R15PdlUYuB9dt8_sejh-U_cE-uM=.908558a6-8977-4dcc-8c46-375cfe3aed04@github.com> Message-ID: On Mon, 16 Dec 2024 22:48:40 GMT, Francisco Ferrari Bihurriet wrote: >> Varada M has updated the pull request incrementally with one additional commit since the last revision: >> >> 8342822: jdk8u432-b06 does not compile on AIX > > Hi, after getting access to an _AIX system_ (thanks @sxa) I have a clearer understanding of what is going on. > > # Tests I executed in _AIX 7.2_ > > All the tests have the following structure, I will specify the C++ snippet and the results. > > > cat >test.cpp <<'EOF' > // C++ snippet goes here > EOF > /opt/IBM/xlC/13.1.3/bin/xlC_r -q64 -c -o/dev/null test.cpp > /opt/IBM/xlC/16.1.0/bin/xlC_r -q64 -c -o/dev/null test.cpp > rm -f test.cpp > > > ## Finding the combination that causes the failure > > ### Snippets that worked > > All the following snippets worked, both with `xlC` 13.1.3 and 16.1.0. > > #### Use `stdlib.h` alone, with `abs()` > > > #include > > long test() { > return abs((long)1); > } > > > #### Use `cstdlib` alone, with `std::abs()` > > > #include > > long test() { > return std::abs((long)1); > } > > > #### Use `cstdlib` with `std::abs()`, but also include `cmath` before `cstdlib` > > > #include > #include > > long test() { > return std::abs((long)1); > } > > > #### Use `cstdlib` with `std::abs()`, but also include `cmath` after `cstdlib` > > > #include > #include > > long test() { > return std::abs((long)1); > } > > > ### Snippets that failed > > The following snippets failed in the same way, both with `xlC` 13.1.3 and 16.1.0. See the error at the end. > > #### Use `stdlib.h` with `abs()`, but also include `cmath` before `cstdlib` > > > #include > #include > > long test() { > return abs((long)1); > } > > > #### Use `stdlib.h` with `abs()`, but also include `cmath` after `cstdlib` > > > #include > #include > > long test() { > return abs((long)1); > } > > > #### Error > > > "test.cpp", line 5.12: 1540-0219 (S) The call to "abs" has no best match. > "test.cpp", line 5.16: 1540-1229 (I) Argument number 1 is an rvalue of type "long". > "/usr/include/math.h", line 1033.20: 1540-1202 (I) No candidate is better than "abs(long double)". > "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "long double" uses "a floating point-integral conversion". > "/usr/include/math.h", line 1003.14: 1540-1202 (I) No candidate is better than "abs(float)". > "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "float" uses "a floating point-integral conversion". > "/usr/include/math.h", line 1001.15: 1540-1202 (I) No candidate is better than "abs(double)". > "test.cpp", line 5.16: 1540-1231 (I) The conversion from argument number 1 to "double" uses "a floating point-integral conversion". > "/usr/include/stdlib.h", line 829.18: 1540-1202 (I) No candidate ... > Thank you, @franferrax, for identifying the root cause of the issue. I have added the header file, which is resolving the build error. Additionally, I checked by adding -D__ABS_LONG__ in the AIX configuration, and that also resolves the issue. Testing for hotspot/test is successful, with no related failures observed. This seems to break Solaris which can't find the new header file: `09:40:41 "/export/home/jenkins/workspace/build-scripts/jobs/jdk8u/jdk8u-solaris-x64-temurin/workspace/build/src/hotspot/src/share/vm/opto/superword.hpp", line 33: Error: Could not open include file "cstdlib".` Ref: https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/524/consoleText ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2551256620 From varadam at openjdk.org Wed Dec 18 15:59:22 2024 From: varadam at openjdk.org (Varada M) Date: Wed, 18 Dec 2024 15:59:22 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: References: Message-ID: > Use of llabs() for jlong resolves the build error on AIX. > Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) Varada M has updated the pull request incrementally with one additional commit since the last revision: 8342822: jdk8u432-b06 does not compile on AIX ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/600/files - new: https://git.openjdk.org/jdk8u-dev/pull/600/files/3f0afd8f..d1fac94e Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=600&range=03 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=600&range=02-03 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/600.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/600/head:pull/600 PR: https://git.openjdk.org/jdk8u-dev/pull/600 From varadam at openjdk.org Wed Dec 18 16:02:45 2024 From: varadam at openjdk.org (Varada M) Date: Wed, 18 Dec 2024 16:02:45 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 15:59:22 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX I have enclosed the header file within an #ifdef and made it specific to AIX to ensure compatibility ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2551705131 From fferrari at openjdk.org Wed Dec 18 18:33:47 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 18 Dec 2024 18:33:47 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: References: Message-ID: <6cF47g1uhBu_u3k6_pbQ725piFeOtPNxmmA01d345Zs=.aa57a603-a8d3-4680-b465-ab676e0bc98d@github.com> On Wed, 18 Dec 2024 15:59:22 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX Hi @varada1110, Great! The change looks good to me, is based on the root cause, and should be 100% innocuous for other platforms. I would also like to know if this looks good to @rwestrel or @gnu-andrew. I'm not a reviewer and we will need approval from one anyway. ------------- Marked as reviewed by fferrari (no project role). PR Review: https://git.openjdk.org/jdk8u-dev/pull/600#pullrequestreview-2512572525 From andrew at openjdk.org Wed Dec 18 19:31:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Wed, 18 Dec 2024 19:31:46 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 15:59:45 GMT, Varada M wrote: >> Varada M has updated the pull request incrementally with one additional commit since the last revision: >> >> 8342822: jdk8u432-b06 does not compile on AIX > > I have enclosed the header file within an #ifdef and made it specific to AIX to ensure compatibility > Hi @varada1110, > > Great! The change looks good to me, is based on the root cause, and should be 100% innocuous for other platforms. > > I would also like to know if this looks good to @rwestrel or @gnu-andrew. I'm not a reviewer and we will need approval from one anyway. It looks pretty risk-free to me, if it is only applied where it is needed (on AIX) I would suggest moving this PR to github.com/openjdk/jdk8u as a regression fix aimed at the January release. Otherwise, 8u442 will be broken on AIX as well (8u-dev is now 8u452, due for release in April 2025). Thanks for the detailed analysis and testing. I wasn't aware there were public build runs on AIX either. Maybe this is worth referencing on https://wiki.openjdk.org/display/Build/Supported+Build+Platforms ? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2552109313 From fferrari at openjdk.org Wed Dec 18 20:39:44 2024 From: fferrari at openjdk.org (Francisco Ferrari Bihurriet) Date: Wed, 18 Dec 2024 20:39:44 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 15:59:22 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX # Bonus > For 11u, I would discard the compiler version as a possible reason why we aren't experiencing this issue (given all the previous tests were identical in both versions). I would lean towards a different preprocessor result, due to a different topology of the includes graph. I was wrong, after a quick trick to ignore a missing `fontconfig` dependency, I was able to start a 11u build (I'm not interested in finishing it). By executing with `make_64 LOG=debug CONF=aix-ppc64-normal-server-release images`, I was able to retrieve the build command, and discovered that the compiler employed is `/opt/IBM/xlC/16.1.0/bin/xlclang++` (not `/opt/IBM/xlC/16.1.0/bin/xlC_r`). So the previous tests were wrong, and in fact `xlclang++` 16.1.0 is not affected by the issue, the following snippet builds without problems: cat >test.cpp <<'EOF' #include #include long test() { return abs((long)1); } EOF /opt/IBM/xlC/16.1.0/bin/xlclang++ -q64 -c -o/dev/null test.cpp rm -f test.cpp So we won't hit this in 11u. For reference, here is the full `loopnode.o` build command: /opt/IBM/xlC/16.1.0/bin/xlclang++ -qmakedep=gcc \ -MF ./build/aix-ppc64-normal-server-release/hotspot/variant-server/libjvm/objs/loopnode.d.tmp \ -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -D__STDC_CONSTANT_MACROS -D_REENTRANT \ -qtbtable=full -qtune=balanced -qalias=noansi -qstrict -qtls=default -qnortti -qnoeh \ -qignerrno -qstackprotect -DLIBC=default -DSUPPORTS_CLOCK_MONOTONIC -DAIX \ -qpic=large -qarch=ppc64 -q64 -DNDEBUG -DPRODUCT -DTARGET_ARCH_ppc -DINCLUDE_SUFFIX_OS=_aix \ -DINCLUDE_SUFFIX_CPU=_ppc -DINCLUDE_SUFFIX_COMPILER=_xlc -DTARGET_COMPILER_xlc -DPPC64 \ -DHOTSPOT_LIB_ARCH='"ppc64"' -DCOMPILER1 -DCOMPILER2 -DINCLUDE_JVMCI=0 -DINCLUDE_CDS=0 \ -DINCLUDE_AOT=0 -DINCLUDE_ZGC=0 -DINCLUDE_SHENANDOAHGC=0 -DINCLUDE_JFR=0 \ -I ./build/aix-ppc64-normal-server-release/hotspot/variant-server/gensrc/adfiles \ -I ./src/hotspot/share \ -I ./src/hotspot/os/aix \ -I ./src/hotspot/os/posix \ -I ./src/hotspot/cpu/ppc \ -I ./src/hotspot/os_cpu/aix_ppc \ -I ./build/aix-ppc64-normal-server-release/hotspot/variant-server/gensrc \ -I ./src/hotspot/share/precompiled \ -I ./src/hotspot/share/include \ -I ./src/hotspot/os/posix/include \ -I ./build/aix-ppc64-normal-server-release/support/modules_include/java.base \ -I ./build/aix-ppc64-normal-server-release/support/modules_include/java.base/aix \ -I ./src/java.base/share/native/libjimage -q64 -DDONT_USE_PRECOMPILED_HEADER -g1 \ -qsuppress=1540-0216 -qsuppress=1540-0198 -qsuppress=1540-1090 -qsuppress=1540-1639 \ -qsuppress=1540-1088 -qsuppress=1500-010 -O3 -qhot=level=1 -qinline -qinlglue -c \ -o ./build/aix-ppc64-normal-server-release/hotspot/variant-server/libjvm/objs/loopnode.o \ ./src/hotspot/share/opto/loopnode.cpp ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2552223741 From duke at openjdk.org Thu Dec 19 12:42:53 2024 From: duke at openjdk.org (Stewart X Addison) Date: Thu, 19 Dec 2024 12:42:53 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: References: Message-ID: <8dpUCZ65grT0ec7VAef8FC1I3yR7Hejx27EC_awy7Lo=.18176105-7499-4df5-984d-9715e6046681@github.com> On Wed, 18 Dec 2024 15:59:22 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX I've tested the updated branch on [Solaris](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/525/console) (and [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/491/console) and [macos](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-temurin/538/console)) and it passed the compilation phase on all three so this looks good now if we're going to stick with the include instead of the `'#define` :-) > It looks pretty risk-free to me, if it is only applied where it is needed (on AIX) Thanks @gnu-andrew - I agree that with this guard around it so it only takes effect on AIX there is as near zero risk as we can get (and we know it's definitely broken on AIX without this!) > I would suggest moving this PR to github.com/openjdk/jdk8u as a regression fix aimed at the January release. Otherwise, 8u442 will be broken on AIX as well (8u-dev is now 8u452, due for release in April 2025). Agreed - that's what I was hopign for - that this would get accepted in time to fix 8u442 next month. @varada1110 Can you handle migrating the PR into jdk8u? > Thanks for the detailed analysis and testing. I wasn't aware there were public build runs on AIX either. Maybe this is worth referencing on https://wiki.openjdk.org/display/Build/Supported+Build+Platforms ? Yeah I'd be good with that. the post at https://api.adoptium.net/v3/binary/latest/21/ea/linux/aarch64/jdk/hotspot/normal/adoptium talks about the builds we publish for each EA tag that comes out. [The build link I referenced above](https://github.com/openjdk/jdk8u-dev/pull/600#issuecomment-2551256620) was a special that I ran specifically against that branch (That isn't done automatically!) but in general they can be pulled from the API links referenced in that article e.g. https://api.adoptium.net/v3/binary/latest/8/ea/aix/ppc64/jdk/hotspot/normal/adoptium for the latest AIX jdk8u EA tag (unless it failed to build of course, like it does for AIX, so that link is currently serving up jdk8u432-b05 as the last one that built successfully) ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2553735305 From andrew at openjdk.org Fri Dec 20 21:33:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Dec 2024 21:33:43 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: <8dpUCZ65grT0ec7VAef8FC1I3yR7Hejx27EC_awy7Lo=.18176105-7499-4df5-984d-9715e6046681@github.com> References: <8dpUCZ65grT0ec7VAef8FC1I3yR7Hejx27EC_awy7Lo=.18176105-7499-4df5-984d-9715e6046681@github.com> Message-ID: On Thu, 19 Dec 2024 12:39:54 GMT, Stewart X Addison wrote: > > I would suggest moving this PR to github.com/openjdk/jdk8u as a regression fix aimed at the January release. Otherwise, 8u442 will be broken on AIX as well (8u-dev is now 8u452, due for release in April 2025). > > Agreed - that's what I was hoping for - that this would get accepted in time to fix 8u442 next month. @varada1110 Can you handle migrating the PR into jdk8u? We need to do this ASAP as we freeze at the end of next week. I doubt many people will be around next week either, so it may already be too late. I'll try and keep an eye out, but today is my last work day of 2024. > > > Thanks for the detailed analysis and testing. I wasn't aware there were public build runs on AIX either. Maybe this is worth referencing on https://wiki.openjdk.org/display/Build/Supported+Build+Platforms ? > > Yeah I'd be good with that. the post at https://api.adoptium.net/v3/binary/latest/21/ea/linux/aarch64/jdk/hotspot/normal/adoptium talks about the builds we publish for each EA tag that comes out. [The build link I referenced above](https://github.com/openjdk/jdk8u-dev/pull/600#issuecomment-2551256620) was a special that I ran specifically against that branch (That isn't done automatically!) but in general they can be pulled from the API links referenced in that article e.g. https://api.adoptium.net/v3/binary/latest/8/ea/aix/ppc64/jdk/hotspot/normal/adoptium for the latest AIX jdk8u EA tag (unless it failed to build of course, like it does for AIX, so that link is currently serving up jdk8u432-b05 as the last one that built successfully) Is the first link wrong? It take me to an AArch64 binary, not a post. It is really good to know this is being regularly tested. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2557741874 From andrew at openjdk.org Fri Dec 20 22:10:43 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Fri, 20 Dec 2024 22:10:43 GMT Subject: [jdk8u] RFR: 8339644: Improve parsing of Day/Month in tzdata rules In-Reply-To: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> References: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> Message-ID: On Tue, 10 Dec 2024 19:11:17 GMT, Dmitry Cherepanov wrote: > The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release). > > The change doesn?t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it?s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year. > > Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (?Unknown month: April?) without the changes and builds with the changes. > > Thanks. Thanks for looking into this. [JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) is a nasty change, because it combines two things; the dependency removal and improvements to the compiler. The dependency removal is a no go for 8u as it would break the build with JDK 7. I'll try and look into whether the compiler changes can be backported in the new year, but this minimal change looks good to me and is appropriate for getting this fixed in the near term. Do you plan to also get 2024b into 8u442? There is only a week left before the freeze and I doubt many people will be around next week - myself included - but I can try and keep an eye out if you plan to submit it. I'm still happy for this to go in as it will enable people to use 2024b with 8u442 manually. ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u/pull/64#pullrequestreview-2518402207 From varadam at openjdk.org Sun Dec 22 14:12:47 2024 From: varadam at openjdk.org (Varada M) Date: Sun, 22 Dec 2024 14:12:47 GMT Subject: [jdk8u] Integrated: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: <0Xn8uUMNfSta6dLf3XAv1BgrOXbUeJIeJQrslHyS1w0=.628cfb05-b663-42f5-b280-99e717ee15d2@github.com> On Sat, 21 Dec 2024 16:47:09 GMT, Varada M wrote: > Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) This pull request has now been integrated. Changeset: 1a6e3a5e Author: Varada M Committer: Andrew John Hughes URL: https://git.openjdk.org/jdk8u/commit/1a6e3a5ea32d5c671cb46a590046f16426089921 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod 8342822: jdk8u432-b06 does not compile on AIX Reviewed-by: andrew, amitkumar ------------- PR: https://git.openjdk.org/jdk8u/pull/65 From varadam at openjdk.org Sat Dec 21 16:53:59 2024 From: varadam at openjdk.org (Varada M) Date: Sat, 21 Dec 2024 16:53:59 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX Message-ID: Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) ------------- Commit messages: - 8342822: jdk8u432-b06 does not compile on AIX Changes: https://git.openjdk.org/jdk8u/pull/65/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=65&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8342822 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk8u/pull/65.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/65/head:pull/65 PR: https://git.openjdk.org/jdk8u/pull/65 From amitkumar at openjdk.org Sun Dec 22 02:48:39 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Sun, 22 Dec 2024 02:48:39 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: <9xSgTzbGcnhukjArlSsolMguVDaQUlbhvWNz-UxpQ9w=.db65290c-13f0-4ae6-b4db-b1bccbeff467@github.com> On Sat, 21 Dec 2024 16:47:09 GMT, Varada M wrote: > Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) Marked as reviewed by amitkumar (no project role). ------------- PR Review: https://git.openjdk.org/jdk8u/pull/65#pullrequestreview-2519537748 From duke at openjdk.org Sat Dec 21 18:03:43 2024 From: duke at openjdk.org (duke) Date: Sat, 21 Dec 2024 18:03:43 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 16:47:09 GMT, Varada M wrote: > Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) @varada1110 Your change (at version e45539c7a0f27ea62c85e105041bd0d28a3c6e6f) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/65#issuecomment-2558189112 From varadam at openjdk.org Sat Dec 21 17:00:42 2024 From: varadam at openjdk.org (Varada M) Date: Sat, 21 Dec 2024 17:00:42 GMT Subject: [jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4] In-Reply-To: References: Message-ID: On Wed, 18 Dec 2024 15:59:22 GMT, Varada M wrote: >> Use of llabs() for jlong resolves the build error on AIX. >> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed >> >> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) > > Varada M has updated the pull request incrementally with one additional commit since the last revision: > > 8342822: jdk8u432-b06 does not compile on AIX I was away and did not have access to my laptop. I have created the PR on jdk8u. Please review the code change, jtreg testing looks fine too https://github.com/openjdk/jdk8u/pull/65 ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2558173754 From andrew at openjdk.org Sat Dec 21 17:19:45 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sat, 21 Dec 2024 17:19:45 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 16:47:09 GMT, Varada M wrote: > Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) Already successfully reviewed on https://github.com/openjdk/jdk8u-dev/pull/600 by myself, @franferrax & @sxa ------------- Marked as reviewed by andrew (Reviewer). PR Review: https://git.openjdk.org/jdk8u/pull/65#pullrequestreview-2518692438 From varadam at openjdk.org Sat Dec 21 18:03:43 2024 From: varadam at openjdk.org (Varada M) Date: Sat, 21 Dec 2024 18:03:43 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 16:47:09 GMT, Varada M wrote: > Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) Thank you ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/65#issuecomment-2558188855 From andrew at openjdk.org Sun Dec 22 14:12:46 2024 From: andrew at openjdk.org (Andrew John Hughes) Date: Sun, 22 Dec 2024 14:12:46 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Sun, 22 Dec 2024 02:50:12 GMT, Amit Kumar wrote: > I do have committer rights for jdk-updates. Looks like jdk8u requires separate rights. Yes, jdk6u, jdk7u and jdk8u were all separate projects, before the consolidation under jdk-updates for more recent long term support releases. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/65#issuecomment-2558469400 From amitkumar at openjdk.org Sun Dec 22 02:52:36 2024 From: amitkumar at openjdk.org (Amit Kumar) Date: Sun, 22 Dec 2024 02:52:36 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 16:47:09 GMT, Varada M wrote: > Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) I do have committer rights for jdk-updates. Looks like jdk8u requires separate rights. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/65#issuecomment-2558309098 From stuefe at openjdk.org Mon Dec 23 09:05:43 2024 From: stuefe at openjdk.org (Thomas Stuefe) Date: Mon, 23 Dec 2024 09:05:43 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Sat, 21 Dec 2024 16:47:09 GMT, Varada M wrote: > Build error on AIX could be resolved with the addition of header file which could be guarded with ifdef to make it aix-specific. Jtreg testing for hotspot/test on aix-ppc64 is successful with no related failures. > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) +1 ------------- PR Review: https://git.openjdk.org/jdk8u/pull/65#pullrequestreview-2520202538 From dcherepanov at openjdk.org Mon Dec 23 09:38:43 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 23 Dec 2024 09:38:43 GMT Subject: [jdk8u] RFR: 8339644: Improve parsing of Day/Month in tzdata rules In-Reply-To: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> References: <4NbHToGWNHDYWFgJV825Az4M-MXYwywdVmzTMU8b2tY=.546115dd-07b5-4a00-a106-2d7ae962d452@github.com> Message-ID: <1qwloclkEXcKODVAGihZfhTztRyX_F790rd0GT3lwA0=.4eb82d0a-b8d0-42b5-a18f-15d61ad6293f@github.com> On Tue, 10 Dec 2024 19:11:17 GMT, Dmitry Cherepanov wrote: > The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release). > > The change doesn?t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it?s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year. > > Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (?Unknown month: April?) without the changes and builds with the changes. > > Thanks. Thanks for reviewing this. Added approval request to this bug. Yes, I plan to backport 2024b to 8u442 and there are two other changes ([JDK-8339803](https://bugs.openjdk.org/browse/JDK-8339803) and [JDK-8340552](https://bugs.openjdk.org/browse/JDK-8340552)) that makes sense to consider for inclusion in 8u442. I'll try to prepare PRs today or tomorrow. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/64#issuecomment-2559303806 From duke at openjdk.org Mon Dec 23 10:16:45 2024 From: duke at openjdk.org (Stewart X Addison) Date: Mon, 23 Dec 2024 10:16:45 GMT Subject: [jdk8u] RFR: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Sun, 22 Dec 2024 14:10:38 GMT, Andrew John Hughes wrote: >> I do have committer rights for jdk-updates. Looks like jdk8u requires separate rights. > >> I do have committer rights for jdk-updates. Looks like jdk8u requires separate rights. > > Yes, jdk6u, jdk7u and jdk8u were all separate projects, before the consolidation under jdk-updates for more recent long term support releases. Thanks @gnu-andrew ... Will we get a jdk8u442-b05 tag with this change in before the GA in January? We haven't had any new 8u442 tags for a few weeks now. ------------- PR Comment: https://git.openjdk.org/jdk8u/pull/65#issuecomment-2559366078 From dcherepanov at openjdk.org Mon Dec 23 12:32:10 2024 From: dcherepanov at openjdk.org (Dmitry Cherepanov) Date: Mon, 23 Dec 2024 12:32:10 GMT Subject: [jdk8u] RFR: 8340552: Harden TzdbZoneRulesCompiler against missing zone names Message-ID: Almost clean backport after path reshuffling except copyright year (updated manually). All relevant tests passed (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). ------------- Commit messages: - Backport 1bc13a1c10a580f84f1b7686c95344ec2633f611 Changes: https://git.openjdk.org/jdk8u/pull/66/files Webrev: https://webrevs.openjdk.org/?repo=jdk8u&pr=66&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8340552 Stats: 12 lines in 1 file changed: 8 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jdk8u/pull/66.diff Fetch: git fetch https://git.openjdk.org/jdk8u.git pull/66/head:pull/66 PR: https://git.openjdk.org/jdk8u/pull/66 From varadam at openjdk.org Mon Dec 23 13:41:47 2024 From: varadam at openjdk.org (Varada M) Date: Mon, 23 Dec 2024 13:41:47 GMT Subject: [jdk8u-dev] Withdrawn: 8342822: jdk8u432-b06 does not compile on AIX In-Reply-To: References: Message-ID: On Thu, 31 Oct 2024 10:17:49 GMT, Varada M wrote: > Use of llabs() for jlong resolves the build error on AIX. > Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed > > JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822) This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jdk8u-dev/pull/600 From duke at openjdk.org Tue Dec 24 01:56:35 2024 From: duke at openjdk.org (yaqsun) Date: Tue, 24 Dec 2024 01:56:35 GMT Subject: [jdk8u-dev] RFR: 8044051: Test jdk/lambda/vm/InterfaceAccessFlagsTest.java gets IOException during compilation [v2] In-Reply-To: <3jvtyF2FUWX_OKA-exKt23Q2LBFqBrhYQcgwPiNgX_8=.ae1418fc-b8e8-4bd5-941e-97efe5d3a595@github.com> References: <3jvtyF2FUWX_OKA-exKt23Q2LBFqBrhYQcgwPiNgX_8=.ae1418fc-b8e8-4bd5-941e-97efe5d3a595@github.com> Message-ID: <_VD1A7at--g4DmcqkTd0Z6bFMfV6C1WfXQU53dY5hdA=.deb73fe1-73e1-4b58-a2e5-57f6e2fadbe8@github.com> > Apply clean. Low risk. yaqsun has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision: - Merge branch 'openjdk:master' into backport-8044051 - Backport 9b8b6695108762063f96a275d9567bed72b88126 ------------- Changes: - all: https://git.openjdk.org/jdk8u-dev/pull/610/files - new: https://git.openjdk.org/jdk8u-dev/pull/610/files/dded67cc..279425f4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=610&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk8u-dev&pr=610&range=00-01 Stats: 848 lines in 36 files changed: 709 ins; 105 del; 34 mod Patch: https://git.openjdk.org/jdk8u-dev/pull/610.diff Fetch: git fetch https://git.openjdk.org/jdk8u-dev.git pull/610/head:pull/610 PR: https://git.openjdk.org/jdk8u-dev/pull/610 From ktakakuri at openjdk.org Fri Dec 27 05:04:42 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 27 Dec 2024 05:04:42 GMT Subject: [jdk8u-dev] RFR: 8048892: TEST_BUG: shell script tests need to be change to not use retired @debuggeeVMOptions mechanism In-Reply-To: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> References: <5xcghWO-ny_tjFjoLtSxvinEjv2Gu4G4c1xpAbaUlV8=.39de4f70-e3d4-4c30-927a-25c96f4f5140@github.com> Message-ID: On Tue, 7 May 2024 12:39:47 GMT, Kazuhisa Takakuri wrote: > Hi all, > > I would like to backport this patch to improve test maintainability. > This patch icompliments JDK-6622468, which I have already proposed for backporting. #492 > The patch is clean. However there is a typo in this patch, which was later fixed as part of JDK-8143583. Without modification, the added test fails. JDK-8143583 contains fixes for other tessts which were not backported, and I think backporting it for this patch is not reasonable. Given this, I also corrected a typo in tis patch. > > Testing: All tests under jdk/test/com/sun/jdi > > Thank you. Could someone please review this backport along with https://github.com/openjdk/jdk8u-dev/pull/492? ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/493#issuecomment-2563319085 From ktakakuri at openjdk.org Fri Dec 27 05:05:47 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 27 Dec 2024 05:05:47 GMT Subject: [jdk8u-dev] RFR: 8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. [v3] In-Reply-To: References: Message-ID: On Wed, 6 Sep 2023 06:52:18 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8154043: Fields not reachable anymore by tab-key, because of new tabbing behaviour of radio button groups. >> >> Applying the JDK-8154043 fix as is will result in a regression of JDK-8182577. >> The fix of JDK-8182577 adds an interface for JDK10, therefore this fix cannot be backported simply for JDK8u. >> So, I propose to judge the buttonModel is an instance of DefaultButtonModel. >> >> Testing: >> java/awt >> javax/swing >> ButtonGroupLayoutTraversalTest.java >> bug8033699.java >> DefaultButtonModelCrashTest.java >> on Windows x86_64 > > Kazuhisa Takakuri has updated the pull request incrementally with one additional commit since the last revision: > > Fix the copyright years I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/285#issuecomment-2563319238 From ktakakuri at openjdk.org Fri Dec 27 05:05:47 2024 From: ktakakuri at openjdk.org (Kazuhisa Takakuri) Date: Fri, 27 Dec 2024 05:05:47 GMT Subject: [jdk8u-dev] RFR: 8160974: [TESTBUG] Mark more headful tests with @key headful. [v6] In-Reply-To: References: Message-ID: <2_4MW64w91VGq3oheza7ohlxWN35ZxdWC7QlMie-C7c=.e001186f-1368-4263-804d-6485a94f37d7@github.com> On Wed, 5 Jun 2024 10:15:15 GMT, Kazuhisa Takakuri wrote: >> This is a backport of JDK-8160974: [TESTBUG] Mark more headful tests with @key headful. >> >> This patch has already been applied to OracleJDK8. >> As noted in the Bug Issue comments, some tests do not exist in 8u. > > Kazuhisa Takakuri has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits: > > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 > - Merge branch 'master' into 8160974 > - Merge branch 'master' into 8160974 > - Backport e52b963d0cdc49e2048757eae2e4b10bb279f296 This pull request is pending approval of the Fix Request. I comment to not close. ------------- PR Comment: https://git.openjdk.org/jdk8u-dev/pull/383#issuecomment-2563319173