[jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v2]

[Alexey Bakhtin]

On Wed, 4 Dec 2024 02:10:30 GMT, Martin Balao <mbalao at openjdk.org> wrote:

>> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update warning and usage strings
>
> Thanks for this contribution.
> 
> One minor comment regarding the text "-k/k" in the warning message.  Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too.
> 
> I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k  Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that.  Just wonder if we should add "k" to "[vfmn0PMe]". What do you think?
> 
> The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface.

Hello @martinuy 
Thank you for review

> One minor comment regarding the text "-k/k" in the warning message. Passing the argument as a standalone "-k" seems to work only with GNUStyleOptions. We can pass "-k..." (along with other options), but the most typical invocation would be "-xk...". I'm okay with the suggested "-k/k" text but would have been okay with with "k" too.

You are right. "-k" is not used separately, so I have updated the warning message
 
> I have the impression that the addition of "main.help.opt.extract.keep-old-files" is related to GNUStyleOptions. The place where "-k Do not overwrite existing files" was added is not the exact equivalent, but we should be able to live with that. Just wonder if we should add "k" to "[vfmn0PMe]". What do you think?

Good catch. Thank you. It should be added as soon as it is main usage string for JDK8
 
> The test "testGnuOptionsKeptOldFile" does not apply, does it? The leading "-" is optional for the non-Gnu interface.

Right. "testGnuOptionsKeptOldFile" does not apply for JDK8

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/608#issuecomment-2517805613