[jdk8u-dev] RFR: 8335912: Add an operation mode to the jar command when extracting to not overwriting existing files [v4]

[Andrew John Hughes]

On Wed, 4 Dec 2024 19:19:10 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:

>> Not clean backport from JDK11 patch:
>> - No GNUStyle options in JDK8
>> - No support for long options
>> - Tests updated to use JDK8 API
>> - Removed subtest for long option
>> 
>> JTREG tests passed
>
> Alexey Bakhtin has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix ExtractFilesTest test

The change looks good to me. Martin has already covered the same comments I would have had about the initial version. I note that the simple `warn` method is pulled in from [JDK-8164805](https://bugs.openjdk.org/browse/JDK-8164805), which is fine because we hardly want to backport a change to do with modular JARs to 8u.

I appreciate you considering the translated property files, as I think there's a building problem there in update releases. I'll say more on this in reply to Martin's comment.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/608#pullrequestreview-2485615926