[jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4]

[Andrew John Hughes]

On Wed, 18 Dec 2024 15:59:45 GMT, Varada M <varadam at openjdk.org> wrote:

>> Varada M has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8342822: jdk8u432-b06 does not compile on AIX
>
> I have enclosed the header file within an #ifdef and made it specific to AIX to ensure compatibility

> Hi @varada1110,
> 
> Great! The change looks good to me, is based on the root cause, and should be 100% innocuous for other platforms.
> 
> I would also like to know if this looks good to @rwestrel or @gnu-andrew. I'm not a reviewer and we will need approval from one anyway.

It looks pretty risk-free to me, if it is only applied where it is needed (on AIX)

I would suggest moving this PR to github.com/openjdk/jdk8u as a regression fix aimed at the January release. Otherwise, 8u442 will be broken on AIX as well (8u-dev is now 8u452, due for release in April 2025).

Thanks for the detailed analysis and testing. I wasn't aware there were public build runs on AIX either. Maybe this is worth referencing on https://wiki.openjdk.org/display/Build/Supported+Build+Platforms ?

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2552109313