[jdk8u-dev] RFR: 8342822: jdk8u432-b06 does not compile on AIX [v4]

[Stewart X Addison]

On Wed, 18 Dec 2024 15:59:22 GMT, Varada M <varadam at openjdk.org> wrote:

>> Use of llabs() for jlong resolves the build error on AIX.
>> Performed jtreg testing for hotspot/test on both aix-ppc64 and linux-ppc64le and no related failures observed 
>> 
>> JBS : [JDK-8342822](https://bugs.openjdk.org/browse/JDK-8342822)
>
> Varada M has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8342822: jdk8u432-b06 does not compile on AIX

I've tested the updated branch on [Solaris](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-solaris-x64-temurin/525/console) (and [AIX](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-aix-ppc64-temurin/491/console) and [macos](https://ci.adoptium.net/job/build-scripts/job/jobs/job/jdk8u/job/jdk8u-mac-x64-temurin/538/console)) and it passed the compilation phase on all three so this looks good now if we're going to stick with the include instead of the `'#define` :-)


> It looks pretty risk-free to me, if it is only applied where it is needed (on AIX)

Thanks @gnu-andrew - I agree that with this guard around it so it only takes effect on AIX there is as near zero risk as we can get (and we know it's definitely broken on AIX without this!)

> I would suggest moving this PR to github.com/openjdk/jdk8u as a regression fix aimed at the January release. Otherwise, 8u442 will be broken on AIX as well (8u-dev is now 8u452, due for release in April 2025).

Agreed - that's what I was hopign for - that this would get accepted in time to fix 8u442 next month. @varada1110 Can you handle migrating the PR into jdk8u?

> Thanks for the detailed analysis and testing. I wasn't aware there were public build runs on AIX either. Maybe this is worth referencing on https://wiki.openjdk.org/display/Build/Supported+Build+Platforms ?

Yeah I'd be good with that. the post at https://api.adoptium.net/v3/binary/latest/21/ea/linux/aarch64/jdk/hotspot/normal/adoptium talks about the builds we publish for each EA tag that comes out. [The build link I referenced above](https://github.com/openjdk/jdk8u-dev/pull/600#issuecomment-2551256620) was a special that I ran specifically against that branch (That isn't done automatically!) but in general they can be pulled from the API links referenced in that article e.g. https://api.adoptium.net/v3/binary/latest/8/ea/aix/ppc64/jdk/hotspot/normal/adoptium for the latest AIX jdk8u EA tag (unless it failed to build of course, like it does for AIX, so that link is currently serving up jdk8u432-b05 as the last one that built successfully)

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/600#issuecomment-2553735305