[jdk8u] RFR: 8339644: Improve parsing of Day/Month in tzdata rules

[Andrew John Hughes]

On Tue, 10 Dec 2024 19:11:17 GMT, Dmitry Cherepanov <dcherepanov at openjdk.org> wrote:

> The backport is a prerequisite for timezone data update to 2024b. Targeting the PR to jdk8u repo (January release).
> 
> The change doesn’t apply cleanly. In JDK9, JDK-8042369 rewrote the builder classes but it’s too large to backport to 8u so I adopted 11u backport for 8u codebase. The test change applies cleanly after path reshuffling except copyright year.
> 
> Testing: jtreg tests (java/text/Format java/util/TimeZone sun/util/calendar sun/util/resources). Sanity checked that tzdata-2024b (rearguard version) fails to build (“Unknown month: April”) without the changes and builds with the changes. 
> 
> Thanks.

Thanks for looking into this. [JDK-8042369](https://bugs.openjdk.org/browse/JDK-8042369) is a nasty change, because it combines two things; the dependency removal and improvements to the compiler.  The dependency removal is a no go for 8u as it would break the build with JDK 7. I'll try and look into whether the compiler changes can be backported in the new year, but this minimal change looks good to me and is appropriate for getting this fixed in the near term.

Do you plan to also get 2024b into 8u442? There is only a week left before the freeze and I doubt many people will be around next week - myself included - but I can try and keep an eye out if you plan to submit it. I'm still happy for this to go in as it will enable people to use 2024b with 8u442 manually.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u/pull/64#pullrequestreview-2518402207