[jdk8u-dev] RFR: 8293562: KeepAliveCache Blocks Threads while Closing Connections [v2]

[Dhamoder Nalla]

On Wed, 31 Jan 2024 05:07:18 GMT, Dhamoder Nalla <dhanalla at openjdk.org> wrote:

>> Issue: [JDK-8293562](https://bugs.openjdk.org/browse/JDK-8293562): KeepAliveCache Blocks Threads while Closing Connections
>> Backport of PR https://github.com/openjdk/jdk11u-dev/pull/1890 fromJDK11 to JDK8.
>> 
>> The JDK11 patch doesn't apply cleanly 3/11 hunks need to be ported manually in KeepAliveCache.java.
>> 
>> Test performed:
>> 
>> 1. JTreg jdk_tier1
>> 2. JTreg jdk_tier2
>> 3. New test case added to this PR passed with the fix and failed without it.
>> 4. The customer failure scenario has been validated.
>
> Dhamoder Nalla has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix indentation

> > This PR seems OK. It would have been easier to review if the whitespace wasn't all different. Consider adding [jerboaa at 054efe5](https://github.com/jerboaa/jdk8u-dev/commit/054efe518681e6334b700c8a236fa4c508db640d) to make this more aligned with JDK 11u. Finally, I wonder if we should bring in https://bugs.openjdk.org/browse/JDK-8278067 first so as to make the patch cleaner (as compared to JDK 11). That one is in 8u361 oracle as well, so would probably good to have and seems low risk. Meanwhile, please apply for approval for #407 so this can get in.
> 
> Thanks @jerboaa for reviewing this PR. I have submitted a request for approval for PR #407 and have addressed the indentation and spacing issues.

I am happy to backport the bug https://bugs.openjdk.org/browse/JDK-8278067, but my concern is that the backport of the other files in the PR (https://github.com/openjdk/jdk11u-dev/pull/1193) may not be clean and could result in bringing in other changes.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/409#issuecomment-1926070196