[jdk8u-dev] RFR: 8168518: rcache interop with krb5-1.15
Andrew John Hughes
andrew at openjdk.org
Mon Feb 12 21:21:02 UTC 2024
On Thu, 11 Jan 2024 22:34:19 GMT, Alexey Bakhtin <abakhtin at openjdk.org> wrote:
> I'd like to backport JDK-8168518 to update rcache hash algorithm from MD5 to SHA-256. It fixes issues on the FIPS environment without MD5 digest support
>
> Implementation classes are applied cleanly.
>
> Test changes are merged manually:
> - Changes in the Proc.java are skipped because of no module support in JDK8
> - "-Dsun.net.spi.nameservice.provider.1=ns,mock" option is added to rcache_usemd5.sh
> - ReplayCacheTestProc.java is merged manually because of JDK-8190690 changes in JDK8
>
> sun/security/krb5/auto tests passed
Backport looks good to me and should allow 8u to work with caches from more modern mit-krb5 versions without breaking backwards compatibility (we are on 1.20 now)
The `Proc.java` change seems like it really should have been in a bug of its own as it's not related to this change at all. The other test changes are expected with the state of the tests in 8u. ~~I take it all relevant tests passed with the backport?~~ (saw your comment in the original post now)
-------------
Marked as reviewed by andrew (Reviewer).
PR Review: https://git.openjdk.org/jdk8u-dev/pull/418#pullrequestreview-1876332566
More information about the jdk8u-dev
mailing list