[jdk8u-dev] RFR: JDK-8324530: Build error with gcc 10

[Andrew John Hughes]

On Tue, 23 Jan 2024 15:15:10 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> This is a trivial fix to a build error (and the underlying off-by-one error, which is only theoretical) gcc 10 warns about.
> 
> Note that this issue has been fixed in JDK 11 and later as part of 8140594: "Various minor code improvements (compiler)", but that patch is much larger and would need more intense review. Here, I'd like to just fix this one problem that breaks the build with gcc 10.

Sorry, Thomas, I only just saw this.

I seem to remember looking at JDK-8140594 myself a while back and it does have a lot of unrelated changes, some of which potentially change behaviour. I agree cherry-picking the fix we actually need here is the better approach.

I have built 8u myself on GCC 13 (with the help of #357) but I guess that was a product build and this code is inside `#ifndef PRODUCT`.

Windows x86 issue was a result of the January 2024 security changes and should now have been resolved by [JDK-8324184](https://bugs.openjdk.org/browse/JDK-8324184)

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/424#pullrequestreview-1885753807
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/424#issuecomment-1949065350