[jdk8u-dev] RFR: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows

[Andrew John Hughes]

On Tue, 20 Feb 2024 18:31:41 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

> Hi,
> 
> This is a backport of [JDK-8082592](https://bugs.openjdk.org/browse/JDK-8082592) which adds Structured Exception Handling (SEH) to guard 'JNI_CreateJavaVM' on Windows.
> 
> The motivation for this backport is to help reduce the number of occurences where a VM might crash will terminate VM immediately without writing an error log Windows, making root cause analysis very difficult in such cases.
> 
> In addition, I plan to also backport [JDK-8186199](https://bugs.openjdk.org/browse/JDK-8186199) as a follow-up, which does something similar to guard 'JNI_DestroyJavaVM'.
> 
> Thanks!

Patch looks clean code-wise. The delta is mostly copyright headers (including `os_windows.hpp` already having a newer date thanks to JDK-8183925) and indentation. I do notice there is an additional change to the formatting of `HOTSPOT_JNI_CREATEJAVAVM_ENTRY` which makes it match the context of the patch. I don't see a problem with that.

I'd like Thomas' ack on this one as well.

-------------

Marked as reviewed by andrew (Reviewer).

PR Review: https://git.openjdk.org/jdk8u-dev/pull/449#pullrequestreview-1891859277
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/449#issuecomment-1955629433