[jdk8u-dev] RFR: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows

[Frederic Thevenet]

On Wed, 21 Feb 2024 01:10:03 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> > Since the back port was not clean, could you describe what the delta is?
> 
> Yes, it is good form in these cases to describe what changes you had to make in the backport. Otherwise, the reviewers have to work this out for themselves and make assumptions as to why you made certain decisions.

Conflicts arose from changes that were introduced in the target at a latter date and therefore not present in the original patch. I opted to keep things the same as they currently were and only add new lines from the patch, with three notable exceptions:
1. When the patch explicitly removed code that was present in the target
2. I picked the most recent copyright date (for some files that means the one from the target and others the one from the patch) though I'm not sure this is correct or if it matters much.
3. I used the target's indentation for `HOTSPOT_JNI_CREATEJAVAVM_ENTRY` rather that the source's because it felt less jarring.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/449#issuecomment-1956775590