[jdk8u-dev] RFR: 8074860: Structured Exception Catcher missing around CreateJavaVM on Windows

[Andrew John Hughes]

On Wed, 21 Feb 2024 01:11:22 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

>> Hi,
>> 
>> This is a backport of [JDK-8082592](https://bugs.openjdk.org/browse/JDK-8082592) which adds Structured Exception Handling (SEH) to guard 'JNI_CreateJavaVM' on Windows.
>> 
>> The motivation for this backport is to help reduce the number of occurrences where a VM might terminate immediately without writing an error log Windows, making root cause analysis very difficult in such cases.
>> 
>> In addition, I plan to also backport [JDK-8186199](https://bugs.openjdk.org/browse/JDK-8186199) as a follow-up, which does something similar to guard 'JNI_DestroyJavaVM'.
>> 
>> Thanks!
>
> I'd like Thomas' ack on this one as well.

> BTW, @gnu-andrew, should we do something about the failing security tests that make everything red? Maybe at least exclude them?

I was hoping there was a simple solution to fixing them, but I can't see anything obvious. Frederic, did you get anywhere? I can propose a temporary exclusion so it's not failing every PR.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/449#issuecomment-1957161905