[jdk8u-dev] RFR: 8186199: [windows] JNI_DestroyJavaVM not covered by SEH [v3]

[Andrew John Hughes]

On Thu, 22 Feb 2024 17:08:20 GMT, Frederic Thevenet <fthevenet at openjdk.org> wrote:

>> Hi,
>> 
>> This is a backport of [8186199: [windows] JNI_DestroyJavaVM not covered by SEH](https://bugs.openjdk.org/browse/JDK-8186199).
>> 
>> The motivation for this backport is to help reduce the number of occurences where a VM might crash will terminate VM immediately without writing an error log Windows, making root cause analysis very difficult in such cases.
>> 
>> This is a follow-up to the backport of  [JDK-8082592](https://bugs.openjdk.org/browse/JDK-8082592) and depends on the integration of PR #449
>> 
>> Thanks!
>
> Frederic Thevenet has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   8186199: [windows] JNI_DestroyJavaVM not covered by SEH

> @fthevenet Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See [OpenJDK Developers’ Guide](https://openjdk.org/guide/#working-with-pull-requests) for more information.

Yes, and you rebasing the commit on #449 has created the situation where there are two identical commits with different hashes. `rebase` is the correct way to resolve this as it will spot that they are identical and drop one. Merging tries to apply the same patch twice to the same code and creates conflicts, which could actually introduce errors into the original patch.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/451#issuecomment-1959897159