[jdk8u-dev] RFR: 8240756: [macos] SwingSet2:TableDemo:Printed Japanese characters were garbled

Andrew John Hughes andrew at openjdk.org
Fri Feb 23 20:14:00 UTC 2024


On Wed, 14 Feb 2024 21:38:31 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Hi all,
>> 
>> This pull request contains a backport of commit https://github.com/openjdk/jdk/commit/27fe3d7f8db4ede6441a7cc325d9f29eb4a1d10d from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>> 
>> The commit being backported was authored by Toshio Nakamura on Mar 15, 2022 and was reviewed by Sergey Bylokhov and Phil Race.
>> 
>> There are two reasons to backport:
>>  - This patch is one of the pre-requirements to support XCode 14.2
>>  - Parity with Oracle JDK 8u361
>> 
>> Thanks!
>
> jdk/test/java/awt/font/GlyphVector/MultiSlotFontTest.java line 28:
> 
>> 26:  * @bug 8240756
>> 27:  * @summary Non-English characters are printed with wrong glyphs on MacOS
>> 28:  * @modules java.desktop/sun.java2d java.desktop/sun.java2d.loops java.desktop/sun.font
> 
> Note that the test uses the @module tag which is noop for jdk8. The policy about this flag in jdk8 is [unclear](https://github.com/openjdk/jdk8u-dev/pull/405#discussion_r1445510434).

I'd say remove it, but I'm not surprised some have slipped through when the patch is otherwise clean.

-------------

PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/441#discussion_r1501123212


More information about the jdk8u-dev mailing list