[jdk8u-dev] RFR: 8069389: CompilerOracle prefix wildcarding is broken for long strings [v3]

[Andrew John Hughes]

On Fri, 23 Feb 2024 09:53:21 GMT, Roman Marchenko <rmarchenko at openjdk.org> wrote:

>> Clean backport.
>> 
>> I've just found that the issue occurs even with short strings like "*123*", see my screenshot attached to JDK-8069389. This can be reproduced currently with "slowdebug" build on my Ubuntu 22.04 + gcc-9.5.0, however I believe we cannot rely on it isn't reproduced with "release" now.
>> 
>> Anyway, it wasn't good to use "strcpy" with overlapped buffers, because strcpy's docs says "The behavior is undefined if the strings overlap." So, I believe it should be fixed in jdk8 as well.
>
> Roman Marchenko has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains one additional commit since the last revision:
> 
>   Backport 01ec6950020268a375eb5330373e6c0813f3a924

Does the new test pass on 8u?

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/446#pullrequestreview-1901317101