[jdk8u-dev] RFR: 8278067: Make HttpURLConnection default keep alive timeout configurable [v4]

[Dhamoder Nalla]

On Tue, 27 Feb 2024 18:30:21 GMT, Andrew John Hughes <andrew at openjdk.org> wrote:

> The text in `jdk/src/share/classes/java/net/doc-files/net-properties.html` seems to be indented differently to the 11u version:
> 
> ```
> +--- a/jdk/src/share/classes/java/net/doc-files/net-properties.html
> ++++ b/jdk/src/share/classes/java/net/doc-files/net-properties.html
> +@@ -172,6 +172,16 @@ <H2>Misc HTTP properties</H2>
>         If HTTP keepalive is enabled (see above) this value determines the
>         maximum number of idle connections that will be simultaneously kept
>         alive, per destination.</P>
> -+      <LI><P><B>{@systemProperty http.keepAlive.time.server}</B> and
> -+        <B>{@systemProperty http.keepAlive.time.proxy}</B> </P>
> ++      <LI><P><B>http.keepAlive.time.server</B> and
> ++      <B>http.keepAlive.time.proxy</B> </P>
>  +      <P>These properties modify the behavior of the HTTP keepalive cache in the case
> -+        where the server (or proxy) has not specified a keepalive time. If the
> -+        property is set in this case, then idle connections will be closed after the 
> -+        specified number of seconds. If the property is set, and the server does
> -+        specify a keepalive time in a "Keep-Alive" response header, then the time specified 
> -+        by the server is used. If the property is not set and also the server
> -+        does not specify a keepalive time, then connections are kept alive for an
> -+        implementation defined time, assuming {@code http.keepAlive} is {@code true}.</P>
> ++      where the server (or proxy) has not specified a keepalive time. If the
> ++      property is set in this case, then idle connections will be closed after the
> ++      specified number of seconds. If the property is set, and the server does
> ++      specify a keepalive time in a "Keep-Alive" response header, then the time specified
> ++      by the server is used. If the property is not set and also the server
> ++      does not specify a keepalive time, then connections are kept alive for an
> ++      implementation defined time, assuming {@code http.keepAlive} is {@code true}.</P>
>         <LI><P><B>http.maxRedirects</B> (default: 20)<BR>
>         This integer value determines the maximum number, for a given request,
>         of HTTP redirects that will be automatically followed by the
> ```
> 
> Can we please align these? Removing the `@systemProperty` tag should not mean changing the indentation of the entire block. Comparing while ignoring whitespace changes shows that most of it is identical, bar the first two lines.
> 
> Otherwise seems mostly clean. The change to the test library looks fine and the absence of the empty line removal is due to [8279842: HTTPS Channel Binding support for Java GSS/Kerberos](https://bugs.openjdk.org/browse/JDK-8279842) being absent (which we should probably also backport at some point as it is in Oracle 8u341)

Thanks @gnu-andrew for reviewing this PR.
Adjusted the Indentation according to 11u.

-------------

PR Comment: https://git.openjdk.org/jdk8u-dev/pull/437#issuecomment-1967411560