[jdk8u-dev] RFR: 8299677: Formatter.format might take a long time to format an integer or floating-point [v2]

[Aleksey Shipilev]

On Tue, 27 Feb 2024 18:52:06 GMT, Chad Rakoczy <duke at openjdk.org> wrote:

>> Backport of [JDK-8299677](https://bugs.openjdk.org/browse/JDK-8299677)
>> 
>> Backport was not clean. Rewrote test to not include junit `ParameterizedTest`. Rewrote fix since `String.repeat` is not in JDK8
>
> Chad Rakoczy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update Formatter zero padding

More comments.

jdk/test/java/util/Formatter/Padding.java line 36:

> 34:         String expected;
> 35:         String format;
> 36:         Object value;

These should be `final`.

jdk/test/java/util/Formatter/Padding.java line 310:

> 308:     public static void main(String [] args) {
> 309:         for(Argument arg : arguments) {
> 310:             if(!arg.expected.equals(String.format(arg.format, arg.value))) {

Suggestion:

        for (Argument arg : arguments) {
            if (!arg.expected.equals(String.format(arg.format, arg.value))) {

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/459#pullrequestreview-1904671650
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/459#discussion_r1504874529
PR Review Comment: https://git.openjdk.org/jdk8u-dev/pull/459#discussion_r1504875542