[jdk8u-dev] RFR: 8270517: Add Zero support for LoongArch [v2]

Ao Qi aoqi at openjdk.org
Sat Jan 6 05:10:27 UTC 2024


On Sat, 6 Jan 2024 02:53:45 GMT, Leslie Zhai <lzhai at openjdk.org> wrote:

>> Hi,
>> 
>> I'd like to backport this patch to jdk8u. `common/autoconf/build-aux/config.guess` and `hotspot/src/os/linux/vm/os_linux.cpp` do not apply cleanly due to context difference, but it is easy to resolve them manually. `common/autoconf/platform.m4` just changed file path.
>> 
>> `common/autoconf/generated-configure.sh` regenerated by `bash bash common/autoconf/autogen.sh`.
>> 
>> A native build on LoongArch hardware is tested.
>> 
>> Debian:
>> 
>> 
>> $ ./build/images/j2sdk-image/bin/java -version
>> openjdk version "1.8.0_392"
>> OpenJDK Runtime Environment (build 1.8.0_392-8u392-ga-1-b08)
>> OpenJDK 64-Bit Zero VM (build 25.392-b08, interpreted mode)
>> 
>> 
>> Loongnix Desktop:
>> 
>> 
>> $ ./build/linux-loongarch64-normal-zero-release/images/j2sdk-image/bin/java -version
>> openjdk version "1.8.0_412-internal"
>> OpenJDK Runtime Environment (build 1.8.0_412-internal-zhaixiang_2024_01_06_10_53-b00)
>> OpenJDK 64-Bit Zero VM (build 25.412-b00, interpreted mode)
>> 
>> 
>> Thanks,
>> Leslie Zhai
>
> Leslie Zhai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   bash common/autoconf/autogen.sh to regerated common/autoconf/generated-configure.sh

Marked as reviewed by aoqi (no project role).

As the author of [8270517](https://bugs.openjdk.org/browse/JDK-8270517), the backport looks good to me. The releaes and fastdebug native builds are passed on my loongarch64 platform. I am not a Reviewer. The GHA test failure seems unrelated, see https://github.com/openjdk/jdk8u-dev/pull/169#issuecomment-1353434077 and https://github.com/openjdk/jdk8u-dev/pull/228#issuecomment-1380658336.

-------------

PR Review: https://git.openjdk.org/jdk8u-dev/pull/413#pullrequestreview-1807244741
PR Comment: https://git.openjdk.org/jdk8u-dev/pull/413#issuecomment-1879552385


More information about the jdk8u-dev mailing list